| 3cbb10a30c000fcd2cd4658dd215778422c7bbb1 |
|
10-Apr-2018 |
Primiano Tucci <primiano@google.com> |
Remove warning suppressions and fix many casting bugs
This change removes most warning suppressions, in particular
from production code. In the past we inherit a bunch of -Wno-xxx
suppressions required to build gtest and libprotobuf headers.
Doing so, however, caused the suppressions to propagate back to
the translation units that were including any protobuf header
or any auto-generated .pb.h stub.
This change moves the gtest and probobuf header to be a
system include (-isystem vs -I). Doing so implicitly blacklists
any compiler warning on the headers.
This CL then re-enables warnings and deals with the fall out of
fixes that came out of this.
Bug: 77316877
Test: pefetto_unittests / perfetto_integrationtests
Change-Id: I3a01852ebf7d0b9bf19658ddf117209d129c70be
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| 55e73f3ac1258b5f6f2913b066ffe1bee42cabe9 |
|
15-Mar-2018 |
Primiano Tucci <primiano@google.com> |
Fix GCC build
Bug: 73283884
Change-Id: Ibd41f5c0f9f6ff82e8de8aad7ac6ca9e857bfd32
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| 941b221544449997e9323d719b2f04eb3c393a7f |
|
14-Mar-2018 |
Primiano Tucci <primiano@google.com> |
Introduce base::TempFile / TempDir
Commonly needed by tests.
Bug: 73283884
Change-Id: I033b3816eb6d0f30c235de26f39b06a7e7bd1f3d
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| 22e4b396fcfd44ef7f70c5f2ecb8f665eee97742 |
|
08-Mar-2018 |
Florian Mayer <fmayer@google.com> |
Run clang-tidy.
Change-Id: I4b173963d14a627daf319427ba2752fca482ada4
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| d16508e288431f2b5fc02e5f45ba1e3cb1801487 |
|
02-Mar-2018 |
Florian Mayer <fmayer@google.com> |
Allow to send FD from client.
Bug: 73625179
Change-Id: I6e1eb38167348c8ea853ef357f003e1a476143d6
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| 5b65c9f715a02b08e44d20b88657fbae8d22351f |
|
29-Jan-2018 |
Primiano Tucci <primiano@google.com> |
ipc: Fix dontreply logic when using derived Deferred messages
This is a follow up to Id56e124bbad0870c4a29653289bf021cfdbf4c14.
The previous CL added the right boilerplate but failed to work
as intended end-to-end. The reason was in the callback argument
adaptor in the Deferred class that was always binding the adapter
even when the original callback was empty.
Unfortunately this bug was not unveiled by the unittest because the
test was using the DeferredBase class (without the callback adapter)
and not a derivate like the production code.
This CL fixes the issue and the unittest (verified that the unittest
change alone without the change in deferred.h would have failed).
Test: perfetto_unittests --gtest_filter=ClientImplTest.InvokeMethodDropReply
Change-Id: I6fd11f7c27452526559beeb595641d141f6261f2
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| 2d0b225dcc40ea2289a1e67864a407a035932136 |
|
25-Jan-2018 |
Primiano Tucci <primiano@google.com> |
IPC: introduce dont_reply flag to avoid useless empty replies
This is to avoid wasteful wakeups (and CPU usage) for methods like
NotifySharedMemoryUpdate(), where neither the client nor the host
have anything meaningful to attach in reply.
This allows to reduce our cpu usage, removing one IPC (hence a
context switch) in the traced -> traced_probes direction.
Change-Id: Id56e124bbad0870c4a29653289bf021cfdbf4c14
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| aab53553d6ad0ab821e45328487f9d88912fb71c |
|
24-Jan-2018 |
Florian Mayer <fmayer@google.com> |
Run clang-tidy
Change-Id: I144335b7cd196e453351db3a83a214fb2f0245da
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| 2e36683621099e142e7ea0ac0bf60cead7d56190 |
|
06-Dec-2017 |
Sami Kyostila <skyostil@google.com> |
Enable missing-field-initializers warning
Change-Id: I098d86101236dbc9e99d5c6b703387598fc36a56
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| b03ba36a7ed038f2c547b79eb839d738a437143e |
|
06-Dec-2017 |
Primiano Tucci <primiano@google.com> |
Unify test targets under perfetto_{tests,benchmarks}
To avoid collisions in chrome on binary names like base_unittests.
Also drop the ipc_test.cc which was a half demo and not really a
test. The full code and real tests will come in the next weeks.
Bug: 68710794
Change-Id: Ib472cc344e0a3316dfbad90108c9638647409809
/external/perfetto/src/ipc/client_impl_unittest.cc
|
| 4f9b6d7b7b2ad7b86e1577a18dc6e2df91b98164 |
|
05-Dec-2017 |
Primiano Tucci <primiano@google.com> |
Pivot source files into top-level src,include and unify test target
See discussion in go/perfetto-build-files .
This is to disambiguate things like
#include "base/logging.h"
when in the chrome tree.
Also this CL unifies the test targets into two monolithic targets:
perfetto_tests and perfetto_benchmarks. This is to avoid ending
up with confusing binary names in the chrome tree (e.g.,
ipc_unittests)
Bug: 68710794
Change-Id: I1768e15b661406052b2be060d7aab0f1e7443a98
/external/perfetto/src/ipc/client_impl_unittest.cc
|