| f35fd8d2f26ef7217368d1a09d231ee68ed0cb2f |
|
22-Jan-2018 |
Robert Phillips <robertphillips@google.com> |
Move more internal methods from GrContext to GrContextPriv (take 3)
Change-Id: Ied630e61cf95780bf85032867e6ce663e1ef9c2f
Reviewed-on: https://skia-review.googlesource.com/98000
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/bench/SKPBench.cpp
|
| 2914555e004676465c5255d8b42ee0d25887ac73 |
|
20-Jan-2018 |
Leon Scroggins <scroggo@google.com> |
Revert "Move more internal methods from GrContext to GrContextPriv (take 2)"
This reverts commit c22e50bd317fe3658445c04e18a6e319d746c510.
Reason for revert: Speculative fix for Android roll
Original change's description:
> Move more internal methods from GrContext to GrContextPriv (take 2)
>
> Change-Id: I47108910517d61edeb52f82793d384fdb5605d45
> Reviewed-on: https://skia-review.googlesource.com/97241
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>
TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
Change-Id: I3a77ac33c5f48529357cf9c683d5f4cacaa2379f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/97582
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
/external/skia/bench/SKPBench.cpp
|
| c22e50bd317fe3658445c04e18a6e319d746c510 |
|
19-Jan-2018 |
Robert Phillips <robertphillips@google.com> |
Move more internal methods from GrContext to GrContextPriv (take 2)
Change-Id: I47108910517d61edeb52f82793d384fdb5605d45
Reviewed-on: https://skia-review.googlesource.com/97241
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/bench/SKPBench.cpp
|
| 07320e46c0064dc1fe876f4621e94cb9ad529f85 |
|
19-Jan-2018 |
Hal Canary <halcanary@google.com> |
Revert "Move more internal methods from GrContext to GrContextPriv"
This reverts commit f440cecbfdf1910104f36aedd0e963da2ae8b6a8.
Reason for revert: breaking android builds.
Original change's description:
> Move more internal methods from GrContext to GrContextPriv
>
> TBR=bsalomon@google.com
> Change-Id: Ia8cf0e0d30451c69bc7a08215aafa6abe6e0ddbe
> Reviewed-on: https://skia-review.googlesource.com/97080
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>
TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
Change-Id: If263f8161f0fbe3fc6ee8f34bb09e237705c3694
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/97200
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/bench/SKPBench.cpp
|
| f440cecbfdf1910104f36aedd0e963da2ae8b6a8 |
|
19-Jan-2018 |
Robert Phillips <robertphillips@google.com> |
Move more internal methods from GrContext to GrContextPriv
TBR=bsalomon@google.com
Change-Id: Ia8cf0e0d30451c69bc7a08215aafa6abe6e0ddbe
Reviewed-on: https://skia-review.googlesource.com/97080
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/bench/SKPBench.cpp
|
| 918e144408ba218df919528f8b48c544f4767883 |
|
23-Jan-2017 |
Mike Reed <reed@google.com> |
change clip-bounds getters to always return the rect
(actually fixes undefined result in getClipBounds)
future CLs
- update all callers to new apis
- move/rename virtuals
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=7400
Change-Id: I45b93014e915c0d1c36d97d948c9ac8931f23258
Reviewed-on: https://skia-review.googlesource.com/7400
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/bench/SKPBench.cpp
|
| 09d994ecb30de2e62a31af2c16307af31fe0e0b3 |
|
21-Dec-2016 |
Brian Salomon <bsalomon@google.com> |
Misc batch->op cleanup Part 1 of 2
Change-Id: I80f951976558a284e55386e0a368f08bd835d8ca
Reviewed-on: https://skia-review.googlesource.com/6359
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/bench/SKPBench.cpp
|
| 2db83612576d64935bd88747cf9855e79cad70d4 |
|
04-Nov-2016 |
Hal Canary <halcanary@google.com> |
bench, samples, etc: s/SkAutoTUnref/sk_sp/
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4437
Change-Id: Ice071684ac8a99e4bb405b4b9be8e8f42c7bac42
Reviewed-on: https://skia-review.googlesource.com/4437
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/bench/SKPBench.cpp
|
| e8f3062a36d3682f4019309a32b5b84dc9eddf8c |
|
24-Mar-2016 |
reed <reed@google.com> |
switch surface to sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1817383002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1817383002
/external/skia/bench/SKPBench.cpp
|
| 9ce9d6772df650ceb0511f275e1a83dffa78ff72 |
|
17-Mar-2016 |
reed <reed@google.com> |
update callsites for Make image factories
not forced yet, as we still have the build-guard. waiting on chrome CL
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810813003
TBR=
Review URL: https://codereview.chromium.org/1810813003
/external/skia/bench/SKPBench.cpp
|
| 31c45bbd5a4129b73843872e00b3bd86bd32008f |
|
22-Feb-2016 |
cdalton <cdalton@nvidia.com> |
Fix nanobench SKP flushes between loops
Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715873002
Review URL: https://codereview.chromium.org/1715873002
/external/skia/bench/SKPBench.cpp
|
| dc5685ac3752e90dd68179e9f1675ff6f15ed600 |
|
02-Dec-2015 |
joshualitt <joshualitt@chromium.org> |
Wire up resource cache stats dumping in nanobench
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1495543003
/external/skia/bench/SKPBench.cpp
|
| 8fd844f38ed46eaac78bb187623ffcc40b592707 |
|
02-Dec-2015 |
joshualitt <joshualitt@chromium.org> |
reset shader compilations for stats
BUG=skia:
Review URL: https://codereview.chromium.org/1491823003
/external/skia/bench/SKPBench.cpp
|
| e45c81c8f3bb62e45f2ff3b8772b4b23f1ddc6ca |
|
02-Dec-2015 |
joshualitt <joshualitt@chromium.org> |
Began logging more gpu stats from nanobench
BUG=skia:
Review URL: https://codereview.chromium.org/1489033004
/external/skia/bench/SKPBench.cpp
|
| e6d2024c689199b09df0d7048fc5252179d52aff |
|
26-Oct-2015 |
cdalton <cdalton@nvidia.com> |
Flush GrContext between benchmark draw loops
This change updates a small subset of benchmarks to flush the GrContext
between draw loops (specifically SKP benchmarks, SampleApp, and the
warmup in visualbench). This helps improve timing accuracy by not
allowing the gpu to batch across draw boundaries in the affected
benchmarks.
BUG=skia:
Review URL: https://codereview.chromium.org/1427533002
/external/skia/bench/SKPBench.cpp
|
| a1ebeb25e9acfcd801e089e063311d716b83b8a5 |
|
01-Oct-2015 |
mtklein <mtklein@chromium.org> |
Remove const from `const int loops`.
This drives me nuts, and prevents `while (loops --> 0)`.
BUG=skia:
Review URL: https://codereview.chromium.org/1379923005
/external/skia/bench/SKPBench.cpp
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/bench/SKPBench.cpp
|
| b4022965a280dd1ed64d6103dd29e2189abe6e00 |
|
25-Jun-2015 |
cdalton <cdalton@nvidia.com> |
Add loopSKP flag to nanobench
Adds a loopSKP flag that forces SKPBenches to draw with only 1 loop.
BUG=skia:
Review URL: https://codereview.chromium.org/1203193002
/external/skia/bench/SKPBench.cpp
|
| bf9e60006987f23773b1e0bdfad9d424d4bc5170 |
|
16-Jun-2015 |
mtklein <mtklein@chromium.org> |
nanobench: split CPU and GPU .SKP tile sizes.
Let's make CPU-bound .SKP benching mimic Chrome's tiles.
Unfortunately, the CPU code also performs a lot better with those big wide tiles...
BUG=skia:
Review URL: https://codereview.chromium.org/1189863002
/external/skia/bench/SKPBench.cpp
|
| 261c3ad7fde95748da92550735decc949dc73bf2 |
|
27-Apr-2015 |
joshualitt <joshualitt@chromium.org> |
Change to add zoom animations to nanobench
BUG=skia:
Review URL: https://codereview.chromium.org/1061323003
/external/skia/bench/SKPBench.cpp
|
| 1d24b8dfe9aac9cadaf3914b8574a4ff6e9bc19d |
|
27-Mar-2015 |
robertphillips <robertphillips@google.com> |
Add matrix constructing helpers to SkMatrix
Review URL: https://codereview.chromium.org/1034273002
/external/skia/bench/SKPBench.cpp
|
| 9a0f629973ee97ea10f5e3c36a802eca4270d7e0 |
|
20-Mar-2015 |
egdaniel <egdaniel@google.com> |
Only use 256x256 tiles on hd2000 nanobench bots
Initial experiments did show that the 256 tile size fixed the hd2000 win7
nanobot failures. However it did not have any effect on other bots, so this
change is to move back to the larger tile size on all bots expect for the
hd2000.
BUG=skia:
Review URL: https://codereview.chromium.org/1022083002
/external/skia/bench/SKPBench.cpp
|
| 5d09568a0c67bc54dfb38552d0136b06d3ebf018 |
|
19-Mar-2015 |
egdaniel <egdaniel@google.com> |
Move skp nanobench tile size back to 256x256 to see if it fixes nanobench crashes
Going back to old nanobench tile size to see if the increase to tile is what has been
causing recent nanobench crashes. The crashes seem very nondeterministic and hard to
debug manually.
256x256 is too small of a tile to give accurate gpu results but if this fixes we can try some compromise in the middle
BUG=skia:
Review URL: https://codereview.chromium.org/1022823003
/external/skia/bench/SKPBench.cpp
|
| cc4d6673a942db11a678b572cf0dc5fca2b97f8a |
|
05-Mar-2015 |
bsalomon <bsalomon@google.com> |
Increase default tile sizes in nanobench
R=mtklein@google.com
Review URL: https://codereview.chromium.org/982863003
/external/skia/bench/SKPBench.cpp
|
| 0004e7db42713592fa16a0e6481c95fcf8b398c3 |
|
26-Jan-2015 |
tfarina <tfarina@chromium.org> |
Update references to skiaperf.com.
The new server is being run in perf.skia.org.
BUG=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/866943003
/external/skia/bench/SKPBench.cpp
|
| a3e52724ac8b9fa7b48507bff4fa8e558a213e49 |
|
09-Dec-2014 |
robertphillips <robertphillips@google.com> |
Switch non-MPD nanobench path to use a separate canvas per tile
It is desirable that, when layer hoisting is disabled, the MPD and non-MPD timings be
roughly the same. Unfortunately, using a separate canvas for each tile (a requirement
for MPD) introduces its own discrepancy into the timing. Using a separate canvas for
each tile doesn't seem to make a difference for 8888 (see the non-MPD 8888 column below)
but slows down GPU rendering (see the non-MPD GPU column below). Since this is how
Chromium renders I propose switching to this regimen (even though it is "slowing down"
GPU rendering).
nanobench mean times (ms) with layer hoisting disabled (for desk_amazon.skp)
8888
MPD non-MPD
1 canvas (old-style) 0.628 1.71
separate (new-style) 0.795 1.63
GPU
MPD non-MPD
1 canvas (old-style) 2.34 1.69
separate (new-style) 2.32 2.66
Review URL: https://codereview.chromium.org/779643002
/external/skia/bench/SKPBench.cpp
|
| 63242d7d24917f836eace34ee20faeb49def5e67 |
|
04-Dec-2014 |
robertphillips <robertphillips@google.com> |
Fix SKPBench tiling so MPD and non-MPD match
Two issues with the SKPBench tile computation were causing the MPD path to do more work:
The clip from the parent canvas wasn't being used to trim content off the edges of the MPD tiles
The non-MPD path was not taking the scale into account in its tile placement (resulting in it having fewer, larger active tiles when scaling).
Review URL: https://codereview.chromium.org/776273002
/external/skia/bench/SKPBench.cpp
|
| 186a08ed72749976b533efe7abec062e20c48bda |
|
21-Nov-2014 |
robertphillips <robertphillips@google.com> |
Fix memory leak in nanobench
This is cleanup for (Add MultiPictureDraw to nanobench - https://codereview.chromium.org/731973005/)
Review URL: https://codereview.chromium.org/730343003
/external/skia/bench/SKPBench.cpp
|
| 5b69377507478623dcf5b11f3ecb010f87c4794f |
|
21-Nov-2014 |
robertphillips <robertphillips@google.com> |
Add MultiPictureDraw to nanobench
I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
TBR=bsalomon@google.com
Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe
Review URL: https://codereview.chromium.org/731973005
/external/skia/bench/SKPBench.cpp
|
| e77dadd91ae6f4319c2c047e7e36cc79bb4d1eff |
|
21-Nov-2014 |
robertphillips <robertphillips@google.com> |
Revert of Add MultiPictureDraw to nanobench (patchset #7 id:120001 of https://codereview.chromium.org/731973005/)
Reason for revert:
Needs more work
Original issue's description:
> Add MultiPictureDraw to nanobench
>
> I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
>
> TBR=bsalomon@google.com
>
> Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe
TBR=mtklein@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/750583002
/external/skia/bench/SKPBench.cpp
|
| 0ddad31012dabfc1267effc8071d37f7d606efbe |
|
21-Nov-2014 |
robertphillips <robertphillips@google.com> |
Add MultiPictureDraw to nanobench
I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/731973005
/external/skia/bench/SKPBench.cpp
|
| 6838d854a87e79f1fbb7b89b9f395155ad44dc0a |
|
29-Oct-2014 |
mtklein <mtklein@chromium.org> |
Try out SkTree in nanobench.
Looks like a fairly large recording speed win with no playback cost.
BUG=skia:
Review URL: https://codereview.chromium.org/653023003
/external/skia/bench/SKPBench.cpp
|
| c7f7f467df07be73b22dbee38a59762997eb19bc |
|
21-Oct-2014 |
mtklein <mtklein@chromium.org> |
Draw SKPs in 256x256 tiles in nanobench.
(This CL will certainly trigger performance regression alerts. Tiled drawing is slower than non-tiled drawing.)
BUG=skia:
Review URL: https://codereview.chromium.org/669983002
/external/skia/bench/SKPBench.cpp
|
| 962890568ddac03d8eb8467a2e81b6f2b7f046f0 |
|
10-Sep-2014 |
mtklein <mtklein@chromium.org> |
Distinguish common and unique names for skiaperf.com.
Turns out we tack on the size post-facto in ResultsWriter::bench(), so the only
place we need getUniqueName() to differ from getName() is SKPBench.
BUG=skia:
R=jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/552303004
/external/skia/bench/SKPBench.cpp
|
| c5ba71d2e5cd426def66fa49dcf003e5b2c98dc7 |
|
04-Sep-2014 |
robertphillips <robertphillips@google.com> |
Change SkPicture::draw to playback
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/540963002
/external/skia/bench/SKPBench.cpp
|
| 92007583e43115998412ac8b0a06cc2780eb025c |
|
01-Aug-2014 |
mtklein <mtklein@chromium.org> |
SKPs-as-benches in nanobench
This is meant to replace bench_pictures.
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Release-iOS-Trybot
BUG=skia:
R=bsalomon@google.com, jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/425393004
/external/skia/bench/SKPBench.cpp
|