History log of /external/skia/debugger/QT/SkGLWidget.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
bdecacfbe47bc7211336bb847bb33c00ef85ea3e 03-Feb-2018 Brian Salomon <bsalomon@google.com> Revert "Revert "Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend.""""""

This reverts commit 3a2cc2c2ec124de36d2544b2a523ef1dd317ca32.

Fix code with samplecnt=0 that slipped in between trybots/CQ and landing of previous version

Change-Id: Iab19f2e8d1e9901601c8c76244d7a88c5d707fab
Reviewed-on: https://skia-review.googlesource.com/103181
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
3a2cc2c2ec124de36d2544b2a523ef1dd317ca32 03-Feb-2018 Brian Salomon <bsalomon@google.com> Revert "Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend."""""

This reverts commit 5bb82cbecd740d21b92e8d2944280ab6eb6af7a6.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend.""""
>
> This reverts commit 18c52a7b52211de5d0dcd86dc048adef758c6c75.
>
> Also relands "More sample count cleanup:" and "Add new GrContext queries for imagability, surfacability, and max sample count of color types"
>
>
> Bug: skia:
> Change-Id: I4028105a3a1f16ce3944e134619eb6245af6b947
> Reviewed-on: https://skia-review.googlesource.com/102940
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com

Change-Id: Idee23be2f1719f0bdc9305043e95a2d589bee8d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/103220
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
5bb82cbecd740d21b92e8d2944280ab6eb6af7a6 02-Feb-2018 Brian Salomon <bsalomon@google.com> Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend.""""

This reverts commit 18c52a7b52211de5d0dcd86dc048adef758c6c75.

Also relands "More sample count cleanup:" and "Add new GrContext queries for imagability, surfacability, and max sample count of color types"


Bug: skia:
Change-Id: I4028105a3a1f16ce3944e134619eb6245af6b947
Reviewed-on: https://skia-review.googlesource.com/102940
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
18c52a7b52211de5d0dcd86dc048adef758c6c75 02-Feb-2018 Brian Salomon <bsalomon@google.com> Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend."""

This reverts commit d0d7270fcc32546005b8e847df516cb11592cd30.

Revert "More sample count cleanup:"

This reverts commit d653cac70ed17983125ceed053138c09f1401846.

Revert "Add new GrContext queries for imagability, surfacability, and max sample count of color types"

This reverts commit 85ae7159c9c8a9186a4c7e74304eabb35bca9a79.


Need to understand NVPR perf changes before relanding

Change-Id: I0db075fb42438ef2a1f9885df184dce52892ac4b
Reviewed-on: https://skia-review.googlesource.com/102780
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
d0d7270fcc32546005b8e847df516cb11592cd30 01-Feb-2018 Brian Salomon <bsalomon@google.com> Revert "Revert "Redefine the meaning of sample counts in GPU backend.""

Fixes gpu config default samples to be 1 and updates config parsing test accordingly.

This reverts commit c1ce2f7966babaae0deb150f93f1227ee5af9285.

Bug: skia:
Change-Id: I456973b1f52ced85a2011ea10fc49449bfc5846f
Reviewed-on: https://skia-review.googlesource.com/102147
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
c1ce2f7966babaae0deb150f93f1227ee5af9285 01-Feb-2018 Brian Salomon <bsalomon@google.com> Revert "Redefine the meaning of sample counts in GPU backend."

This reverts commit 48825b11ad25c98b9a4884d5cc0edd4e290c4409.

Reason for revert: nanobench

Original change's description:
> Redefine the meaning of sample counts in GPU backend.
>
> Old: 0 -> nonMSAA
> 1+ -> MSAA
>
> New:
> 0 -> error/unsupported
> 1 -> nonMSAA
> 2+ -> MSAA
>
> We still allow 0 to mean nonMSAA in three sets of public APIs for backwards compatibility:
>
> 1) SkSurface factories
> 2) GrBackendRenderTarget constructors
> 3) GrCaps::getSampleCnt()'s requestedCount parameter
>
> However, we immediately clamp to 1 and treat 0 as invalid/non-renderable internally.
>
> This also changes the behavior when using a large sample count. We now fail in that case rather than using the largest sample available sample count. GrCaps::getSampleCount() will return 0 in this case.
>
>
> Bug: skia:
> Change-Id: Ida22c6b22c1365e563c9046b611e88bf5eb3ff33
> Reviewed-on: https://skia-review.googlesource.com/101560
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com

Change-Id: Ic257619a8a5ee9ac15419ecf10259e42daed7f82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/102662
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
48825b11ad25c98b9a4884d5cc0edd4e290c4409 01-Feb-2018 Brian Salomon <bsalomon@google.com> Redefine the meaning of sample counts in GPU backend.

Old: 0 -> nonMSAA
1+ -> MSAA

New:
0 -> error/unsupported
1 -> nonMSAA
2+ -> MSAA

We still allow 0 to mean nonMSAA in three sets of public APIs for backwards compatibility:

1) SkSurface factories
2) GrBackendRenderTarget constructors
3) GrCaps::getSampleCnt()'s requestedCount parameter

However, we immediately clamp to 1 and treat 0 as invalid/non-renderable internally.

This also changes the behavior when using a large sample count. We now fail in that case rather than using the largest sample available sample count. GrCaps::getSampleCount() will return 0 in this case.


Bug: skia:
Change-Id: Ida22c6b22c1365e563c9046b611e88bf5eb3ff33
Reviewed-on: https://skia-review.googlesource.com/101560
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
faa095e9842b924c20de84dce1bcc1adad7fe2e4 19-Dec-2017 Greg Daniel <egdaniel@google.com> Update SkSurface MakeFromBackend* factories to take an SkColorType.

Bug: skia:
Change-Id: Ib1b03b1181ec937843eac2e8d8cb03ebe53e32c1
Reviewed-on: https://skia-review.googlesource.com/86760
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
3d6801eeee6b036de9f8d09e2ae8fa99df5a397c 11-Dec-2017 Brian Salomon <bsalomon@google.com> Add GrGLMakeNativeInterface factory that returns sk_sp<const GrGLInterface>.

Removes the concept of a configurable "default" interface and makes the default
always be the "native" interface.

Also removes unused functions: GrGLInterfaceAddTestDebugMarker and
GrGLInterface::NewClone.

Keeps around legacy GrGLCreateNativeInterface() until clients can be weened.

Change-Id: I4a3bdafa8cf8c68ed13318393abd55686b045ccb
Reviewed-on: https://skia-review.googlesource.com/83000
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
f43d0001e4139978fa9699083f4c62f92eb03106 31-Aug-2017 Brian Salomon <bsalomon@google.com> Revert "Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""""

This reverts commit 6df4d6be0d025211400de6a910e17f2a87219887.

Reason for revert: Google3 fix landed

Original change's description:
> Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget."""
>
> This reverts commit 71554bc256b705fe959b7aa2fb2f24ed48782362.
>
> Reason for revert: Google3
>
> Original change's description:
> > Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""
> >
> > This reverts commit 807371c15bd742efb98a9df6e1dee73e8bda8af5.
> >
> > Docs-Preview: https://skia.org/?cl=40260
> > Change-Id: I28e0434c455155ff39a5aaa4141abdf442474e87
> > Reviewed-on: https://skia-review.googlesource.com/40260
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> > Commit-Queue: Brian Salomon <bsalomon@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com
>
> Change-Id: Ifdfa896a70db69935473276d12dce54de5c6b6f7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/41500
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com

Change-Id: I827419bb19972c3644929a8c984bb9534baab0ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/41700
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
6df4d6be0d025211400de6a910e17f2a87219887 31-Aug-2017 Brian Salomon <bsalomon@google.com> Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget."""

This reverts commit 71554bc256b705fe959b7aa2fb2f24ed48782362.

Reason for revert: Google3

Original change's description:
> Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""
>
> This reverts commit 807371c15bd742efb98a9df6e1dee73e8bda8af5.
>
> Docs-Preview: https://skia.org/?cl=40260
> Change-Id: I28e0434c455155ff39a5aaa4141abdf442474e87
> Reviewed-on: https://skia-review.googlesource.com/40260
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com

Change-Id: Ifdfa896a70db69935473276d12dce54de5c6b6f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/41500
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
71554bc256b705fe959b7aa2fb2f24ed48782362 30-Aug-2017 Brian Salomon <bsalomon@google.com> Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""

This reverts commit 807371c15bd742efb98a9df6e1dee73e8bda8af5.

Docs-Preview: https://skia.org/?cl=40260
Change-Id: I28e0434c455155ff39a5aaa4141abdf442474e87
Reviewed-on: https://skia-review.googlesource.com/40260
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
02611d9afdd887ee443825ac88377f2eea093380 25-Jul-2017 Greg Daniel <egdaniel@google.com> Add Make[backend] calls for creating GrContexts

Docs-Preview: https://skia.org/?cl=26369
Bug: skia:
Change-Id: I460ee63e466f85b05918479f068a2e5ca2d70550
Reviewed-on: https://skia-review.googlesource.com/26369
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
807371c15bd742efb98a9df6e1dee73e8bda8af5 20-Jul-2017 Brian Salomon <bsalomon@google.com> Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget."

This reverts commit e2d37c2a07f5473e5fc6fb65e9e23e14127580e9.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.
>
> Also removes a reference to GrBackendTextureDesc in a comment and updates markdown docs.
>
> Docs-Preview: https://skia.org/?cl=24861
> Bug: skia:
> Change-Id: Ic6490d5ef46953450e6dee69271397bb2b94d0d6
> Reviewed-on: https://skia-review.googlesource.com/24861
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: I4b85b529727f0bf5aec21d87e725a8195666e2e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/25182
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
e2d37c2a07f5473e5fc6fb65e9e23e14127580e9 20-Jul-2017 Brian Salomon <bsalomon@google.com> Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.

Also removes a reference to GrBackendTextureDesc in a comment and updates markdown docs.

Docs-Preview: https://skia.org/?cl=24861
Bug: skia:
Change-Id: Ic6490d5ef46953450e6dee69271397bb2b94d0d6
Reviewed-on: https://skia-review.googlesource.com/24861
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
e0707272e83b8c022fe7cb9af0a4c2b70f56be2d 06-Jan-2017 Robert Phillips <robertphillips@google.com> Get Debugger app compiling again

Change-Id: I307088b2cf4fc1404313f280975ac39105f70ac0
Reviewed-on: https://skia-review.googlesource.com/6604
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/debugger/QT/SkGLWidget.cpp
f530586c417800d086e6e727ecb1b31e678f4183 15-Nov-2016 Florin Malita <fmalita@chromium.org> Resurrect SkDebugger

Can't let go <sniffle>.

R=robertphillips@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4793

Change-Id: Ida5936d17af2ef60c3f50e27b4f4987a79165fa5
Reviewed-on: https://skia-review.googlesource.com/4793
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/debugger/QT/SkGLWidget.cpp
12e9662cf796c7c1bd1f6e247691d8603335e57f 01-Aug-2016 robertphillips <robertphillips@google.com> Remove some ancillary users of SkSurface::MakeRenderTargetDirect

calved off of: https://codereview.chromium.org/2176333002/ (Remove SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198433003

Review-Url: https://codereview.chromium.org/2198433003
/external/skia/debugger/QT/SkGLWidget.cpp
20a272d024572efa50afb436c4770341abe9e1c1 25-Jul-2016 chrishtr <chrishtr@chromium.org> Fix debugger build by specifying nullptr for color space.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002

Review-Url: https://codereview.chromium.org/2181733002
/external/skia/debugger/QT/SkGLWidget.cpp
221196dac99dcbb402fd79c651e2a96fd5016dba 29-Apr-2016 robertphillips <robertphillips@google.com> Fix old debugger
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1935623002

Review-Url: https://codereview.chromium.org/1935623002
/external/skia/debugger/QT/SkGLWidget.cpp
9ea8acdf3ff8b7787e59de8c393e12a72b34ddc0 01-Mar-2016 robertphillips <robertphillips@google.com> Unbust the old debugger

AFAICT the recent STL changes have introduced some QT conflicts.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753813002

Review URL: https://codereview.chromium.org/1753813002
/external/skia/debugger/QT/SkGLWidget.cpp
96fcdcc219d2a0d3579719b84b28bede76efba64 27-Aug-2015 halcanary <halcanary@google.com> Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002

Review URL: https://codereview.chromium.org/1316233002
/external/skia/debugger/QT/SkGLWidget.cpp
52d4deb1288633551ad275be748d8b0f73d7b2aa 24-Jun-2015 robertphillips <robertphillips@google.com> Fix debugger compilation

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/1205933002
/external/skia/debugger/QT/SkGLWidget.cpp
4e11c0b54d659222e9d203bf9f6838a8811d9148 04-May-2015 robertphillips <robertphillips@google.com> Get debugger compiling again

Review URL: https://codereview.chromium.org/1125543003
/external/skia/debugger/QT/SkGLWidget.cpp
9e33d1dbccee9b13ac001dfc3094a503f9e84e9d 11-Feb-2015 kkinnunen <kkinnunen@nvidia.com> debugger: Abandon context when Qt changes it without notice

Qt changes the context on many conditions. Abandon GrContext
in these cases.

Also call GrContext::resetContext during Qt GL paint callback,
the GL state may be touched by Qt.

Fixes the bug where changing between gpu and msaa would start
erroring in framebuffer binds, if the .skp had many layers.

Review URL: https://codereview.chromium.org/915573002
/external/skia/debugger/QT/SkGLWidget.cpp
a2d9478e927a8d6c02fd6472d5aad8d14c0bfccd 16-Jan-2015 Brian Salomon <bsalomon@google.com> Fix debugger wrt to new SkGpuDevice factory signature'

Review URL: https://codereview.chromium.org/855083003
/external/skia/debugger/QT/SkGLWidget.cpp
cfdc0e3fee69694e0f6b083d8455665b2a810589 14-Jan-2015 kkinnunen <kkinnunen@nvidia.com> debugger: SW rasterize the picture only when it changes

Rasterize the picture only when it changes, not every time
raster widget paints itself.

Removes include SkForceLinking.h while organizing the SkDebuggerGUI.cpp
includes.

This is part of the work trying to remove bugs that come from
SkDebugCanvas stateful draw. Part of the state comes from some
optimization that this tries to reproduce in a different way.

Review URL: https://codereview.chromium.org/839743003
/external/skia/debugger/QT/SkGLWidget.cpp
26e5400de4db969d32356a0b703261c1c98735f6 05-Jan-2015 kkinnunen <kkinnunen@nvidia.com> Remove draw window size state from SkDebugCanvas

The SkDebugCanvas can be (or is currently) being used to draw to multiple
different canvases. If this use-case is intended, then storing draw
-related state in the canvas causes bugs.

Remove draw window size state form SkDebugCanvas. Instead, use the canvas
base layer size as the window size to clip to. This is consistent with
the current use in debugger.

This is part of work trying to remove bugs in debugger that result from
replaying one SkDrawCanvas to two different canvases. Currently the
SkDrawCanvas stores state that can only be valid if it is used for one
canvas.

Review URL: https://codereview.chromium.org/835113002
/external/skia/debugger/QT/SkGLWidget.cpp
4be0238b116cb271122f26d0114540d15dce5bf1 22-Dec-2014 kkinnunen <kkinnunen@nvidia.com> Avoid leaking render targets in debugger

Render targets were not unreffed when QGLWidget::resizeGL was called.

Review URL: https://codereview.chromium.org/817243002
/external/skia/debugger/QT/SkGLWidget.cpp
4a8126e7f81384526629b1e21bf89b632ea13cd9 22-Sep-2014 reed <reed@google.com> Introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/)"

This reverts commit 29c857d0f3a1cb837f73406eeb6ba9771879b5e7.

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/588143004
/external/skia/debugger/QT/SkGLWidget.cpp
29c857d0f3a1cb837f73406eeb6ba9771879b5e7 21-Sep-2014 reed <reed@chromium.org> Revert of introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/)

Reason for revert:
Broke call site in WebKit

Original issue's description:
> introduce Props to surface (work in progress)
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3716fd067a5621bb94a6cb08d72afec8bf3aceda

R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@google.com
TBR=bsalomon@google.com, bungeman@google.com, fmalita@google.com, jvanverth@google.com, reed@google.com, robertphillips@google.com, vangelis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/583773004
/external/skia/debugger/QT/SkGLWidget.cpp
3716fd067a5621bb94a6cb08d72afec8bf3aceda 21-Sep-2014 reed <reed@google.com> introduce Props to surface (work in progress)

BUG=skia:
R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/551463004
/external/skia/debugger/QT/SkGLWidget.cpp
a8d7f0b13cd4c6d773fcf055fe17db75d260fa05 29-Aug-2014 robertphillips <robertphillips@google.com> Try out scalar picture sizes

This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect.

R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/513983002
/external/skia/debugger/QT/SkGLWidget.cpp
23b406cc040d55b45acc96e63db5c2d5c934a53c 28-Aug-2014 bsalomon <bsalomon@google.com> Make SkGpuDevice constructors private.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/517033002
/external/skia/debugger/QT/SkGLWidget.cpp
fae599b4a642aae776966b0f2ea67e2fdf4d6a65 10-Mar-2014 commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Avoid black flashes when resizing debugger window using MSAA

Avoid black flashes when resizing debugger window using MSAA. Clear the
stencil buffer always after resize. Also reset the GrContext state
when Qt calls resizeGL -- we do not know what GL state Qt changes.

Remove setting of white background to SkGLWidget, it is not
effective. QGLWidget does not respect the stylesheet.

Also move the initial stencil clearing before GrContext is created
in order to preserve GrContext state consistent with actual GL
state.

R=robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/192433003

git-svn-id: http://skia.googlecode.com/svn/trunk@13721 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
e1ca705cac4b946993f6cbf798e2a0ba27e739f3 17-Dec-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/111353003

git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
fde1e7ccb4524aa2e0c42872e529ee25d09e7f34 02-Aug-2013 commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Support MSAA in the picture debugger

Add radio buttons for setting the GL sample count to 0 ("off"), 4 or
16.

Change the default mode of the GL widget to MSAA4. Previous behavior
corresponded to "off".

BUG=1459
R=robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/21752002

git-svn-id: http://skia.googlecode.com/svn/trunk@10509 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
0b4d6b289c89f0b6c6891e2fb812fa3614cb55a2 01-Jul-2013 bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Basic error checking for debugger GL widget.

Currently the debugger segfaults if the GL context cannot be created.
This change allows the debugger to build with GL support, but still run if the
GL context cannot be created at runtime.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18275002

git-svn-id: http://skia.googlecode.com/svn/trunk@9834 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
e8fe4bc3efa8f18f5651c5d005fba1935a741be0 13-Feb-2013 robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Allow debugger to be compiled without Ganesh

https://codereview.appspot.com/7311084/



git-svn-id: http://skia.googlecode.com/svn/trunk@7710 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
6577cd37c73bd6e3bbdb7b7af2fc625a2cd69b39 08-Feb-2013 robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Fix uninitialized Render Target origin issue in debugger

https://codereview.appspot.com/7314066/



git-svn-id: http://skia.googlecode.com/svn/trunk@7682 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
fec0bc3fc13481f5bcb341ab2d2d695911f39bd4 07-Feb-2013 bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Remove legacy names no longer referenced in Chrome and WebKit.
Review URL: https://codereview.appspot.com/7311055

git-svn-id: http://skia.googlecode.com/svn/trunk@7640 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
16e3ddea6a80972aced04b21b1d66377fa95e7c7 25-Oct-2012 bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Platform/Engine -> Backend
createPlatform -> wrapBackend

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6785044

git-svn-id: http://skia.googlecode.com/svn/trunk@6123 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
b8ec32e050ab7151eb5660c37edf36a1119f2255 14-Aug-2012 chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Bug Fix: Fixes incremental drawing in conjunction with the highlighting filter for the OpenGL widget.

Review URL: https://codereview.appspot.com/6441141

git-svn-id: http://skia.googlecode.com/svn/trunk@5094 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
607357fde8a9c4c70549d4223e0bd1181b012e0e 07-Aug-2012 chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Refactoring into a public facing facing SkDebugger class first pass.

Review URL: https://codereview.appspot.com/6450096

git-svn-id: http://skia.googlecode.com/svn/trunk@4986 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
a9e937c7b712b024de108fa963f92d0e70e4a296 03-Aug-2012 chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Moved the ownership of the current clip and current matrix into the debug canvas as part of the upcoming general refactor to everything living in debug canvas.

Review URL: https://codereview.appspot.com/6447077

git-svn-id: http://skia.googlecode.com/svn/trunk@4950 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
830b8793bb1646bb76817bdc228dd8e2a92bef7d 01-Aug-2012 chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Optimization: SkDebugCanvas is capable of pausing and drawing incrementally instead of redrawing all commands.

Review URL: https://codereview.appspot.com/6458056

git-svn-id: http://skia.googlecode.com/svn/trunk@4891 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
0b5bbb0f82e022c8acfbcb6312f0ed18e1ab90ce 31-Jul-2012 chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Optimized hit testing feature, refactored into seperate function from canvas draw calls

Review URL: https://codereview.appspot.com/6443068

git-svn-id: http://skia.googlecode.com/svn/trunk@4867 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
2d537a18f49cb492358c2b051f4786075dd9406c 31-Jul-2012 chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Fixed numerous mem errors

Review URL: https://codereview.appspot.com/6441070

git-svn-id: http://skia.googlecode.com/svn/trunk@4849 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp
ea5488b9655fc7d71345c3a823de85f8b74e3279 26-Jul-2012 chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> GL Widget Alpha

Review URL: https://codereview.appspot.com/6422060

git-svn-id: http://skia.googlecode.com/svn/trunk@4789 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkGLWidget.cpp