| b4aab9ae6d27c446af8302b79d15b832c816c633 |
|
16-Aug-2017 |
Ben Wagner <bungeman@google.com> |
Replace SkFAIL with SK_ABORT.
SkFAIL is a legacy macro which is just SK_ABORT. This CL mechanically
changes uses of SkFAIL to SK_ABORT in preparation for its removal. The
related sk_throw macro will be changed independently, due to needing to
actually clean up its users.
Change-Id: Id70b5c111a02d2458dc60c8933f444df27d9cebb
Reviewed-on: https://skia-review.googlesource.com/35284
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/gm/occludedrrectblur.cpp
|
| 33d2055e594177b27360f84e0631b26d74a55a9b |
|
22-Mar-2017 |
Mike Klein <mtklein@chromium.org> |
GM: some header cleanup
gm.h includes sk_tool_utils.h but does not use it.
The bulk of this CL makes each gm that uses sk_tool_utils include it.
sk_tool_utils.h also provided SkRandom and SkTDArray,
so a couple GMs add those headers too.
Change-Id: Ieb2a7c542f0ca89c3223f744fc11b0ff37af36c1
Reviewed-on: https://skia-review.googlesource.com/10014
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/gm/occludedrrectblur.cpp
|
| dbfd7ab10883f173f5c1b653a233e18dc6142002 |
|
01-Sep-2016 |
mtklein <mtklein@chromium.org> |
Replace a lot of 'static const' with 'constexpr' or 'const'.
'static const' means, there must be at most one of these, and initialize it at
compile time if possible or runtime if necessary. This leads to unexpected
code execution, and TSAN* will complain about races on the guard variables.
Generally 'constexpr' or 'const' are better choices. Neither can cause races:
they're either intialized at compile time (constexpr) or intialized each time
independently (const).
This CL prefers constexpr where possible, and uses const where not. It even
prefers constexpr over const where they don't make a difference... I want to have
lots of examples of constexpr for people to see and mimic.
The scoped-to-class static has nothing to do with any of this, and is not changed.
* Not yet on the bots, which use an older TSAN.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005
Review-Url: https://codereview.chromium.org/2300623005
/external/skia/gm/occludedrrectblur.cpp
|
| 27cdd947903a4262bb483e7d35153358f4541bf8 |
|
11-Aug-2016 |
robertphillips <robertphillips@google.com> |
Implement GPU occluded blur mask filter
Spawned off: https://codereview.chromium.org/2214163003/ (Minor clean up related to blur mask filters)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
Review-Url: https://codereview.chromium.org/2201133002
/external/skia/gm/occludedrrectblur.cpp
|
| 9aff85a545703af5880e10726dfb40005ea9934e |
|
05-Aug-2016 |
robertphillips <robertphillips@google.com> |
Minor clean up related to blur mask filters
This is the non-substantive portion of: https://codereview.chromium.org/2201133002/ (Implement GPU occluded blur mask filter)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214163003
Review-Url: https://codereview.chromium.org/2214163003
/external/skia/gm/occludedrrectblur.cpp
|
| 401c1968a1727b7dd1543f7e5536ca544fc6d752 |
|
04-Aug-2016 |
robertphillips <robertphillips@google.com> |
Add new GM for occluded blurmask filter draws
This splits out just the GM portion of https://codereview.chromium.org/2201993003/ (Add GM to test out blurmaskfilter occluders) which included some API changes
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214033002
Review-Url: https://codereview.chromium.org/2214033002
/external/skia/gm/occludedrrectblur.cpp
|