5dd202dc9002ec7b42279b85ff89ba4780ad394d |
|
07-Feb-2018 |
Mike Reed <reed@google.com> |
Revert "Revert "move GrColor.h to private, IWYU"" This reverts commit 63cc29304a65039feaf27842d587ed16de010b0d. Reason for revert: pdfium updated Original change's description: > Revert "move GrColor.h to private, IWYU" > > This reverts commit e602f395813aab8242afad356008b8e79911adbb. > > Reason for revert: Breaks PDFIUM > > Original change's description: > > move GrColor.h to private, IWYU > > > > Bug: skia: > > Change-Id: I0f0dabd7cc54cb7786f53bd6da0c0c012375037e > > Reviewed-on: https://skia-review.googlesource.com/104160 > > Commit-Queue: Mike Reed <reed@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > TBR=bsalomon@google.com,reed@google.com > > Change-Id: Ifaa50f8771fa1ca8bc152270efdb1fe27f7210f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/104440 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,reed@google.com Change-Id: I22fa5c0e0628b5c1f3b5f13879c7d1a4528cc93a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/104561 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/gm/showmiplevels.cpp
|
63cc29304a65039feaf27842d587ed16de010b0d |
|
06-Feb-2018 |
Brian Salomon <bsalomon@google.com> |
Revert "move GrColor.h to private, IWYU" This reverts commit e602f395813aab8242afad356008b8e79911adbb. Reason for revert: Breaks PDFIUM Original change's description: > move GrColor.h to private, IWYU > > Bug: skia: > Change-Id: I0f0dabd7cc54cb7786f53bd6da0c0c012375037e > Reviewed-on: https://skia-review.googlesource.com/104160 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,reed@google.com Change-Id: Ifaa50f8771fa1ca8bc152270efdb1fe27f7210f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/104440 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/gm/showmiplevels.cpp
|
e602f395813aab8242afad356008b8e79911adbb |
|
06-Feb-2018 |
Mike Reed <reed@google.com> |
move GrColor.h to private, IWYU Bug: skia: Change-Id: I0f0dabd7cc54cb7786f53bd6da0c0c012375037e Reviewed-on: https://skia-review.googlesource.com/104160 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/gm/showmiplevels.cpp
|
e32500f0642df381fd79731df2f7a4a4a71a46e2 |
|
19-Jul-2017 |
Mike Reed <reed@google.com> |
Assume HQ is handled by pipeline, delete legacy code-path CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Bug: skia: Change-Id: If6f0d0a57463bf99a66d674e65a62ce3931d0116 Reviewed-on: https://skia-review.googlesource.com/24644 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/gm/showmiplevels.cpp
|
7785dd235d50e51f80bc4bb82639b0ffb29540b5 |
|
07-Jun-2017 |
Greg Daniel <egdaniel@google.com> |
Update showmiplevel gm to round coords the same for both variations of the GM The versions of showmiplevel that take both a width and height, round the coords of draws to integers. The basic version did not do this which caused sampling bugs on adreno when using nearest neighbor at half pixel coords. Since this GM isn't testing the GPU rendering of the mips, this workaround is okay. Bug: skia:5905 Change-Id: I4080532e8c1f37d74c60089970c5d0fc83cd5373 Reviewed-on: https://skia-review.googlesource.com/18939 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
/external/skia/gm/showmiplevels.cpp
|
68b8e3d50d0954eb5eeb7f625f06026c7fbd38c1 |
|
28-Apr-2017 |
Matt Sarett <msarett@google.com> |
Revert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag"" This reverts commit 0122af08f6af0dee490e1a4f35b552377d0d4753. Reason for revert: Fixed Android callsite Original change's description: > Revert "Delete copyTo(Allocator), hide copyTo() behind flag" > > This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971. > > Reason for revert: Looks like I missed something I was supposed to delete in Android. > > Original change's description: > > Delete copyTo(Allocator), hide copyTo() behind flag > > > > Replace uses of copyTo() in Skia. > > > > Bug: skia:6464 > > Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548 > > Reviewed-on: https://skia-review.googlesource.com/14502 > > Commit-Queue: Matt Sarett <msarett@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > > > TBR=msarett@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e > Reviewed-on: https://skia-review.googlesource.com/14602 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,reviews@skia.org,reed@google.com Change-Id: I81659a820f79f1958fda23cb62513065b57db99d Reviewed-on: https://skia-review.googlesource.com/14640 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
/external/skia/gm/showmiplevels.cpp
|
0122af08f6af0dee490e1a4f35b552377d0d4753 |
|
27-Apr-2017 |
Matt Sarett <msarett@google.com> |
Revert "Delete copyTo(Allocator), hide copyTo() behind flag" This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971. Reason for revert: Looks like I missed something I was supposed to delete in Android. Original change's description: > Delete copyTo(Allocator), hide copyTo() behind flag > > Replace uses of copyTo() in Skia. > > Bug: skia:6464 > Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548 > Reviewed-on: https://skia-review.googlesource.com/14502 > Commit-Queue: Matt Sarett <msarett@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=msarett@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e Reviewed-on: https://skia-review.googlesource.com/14602 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/gm/showmiplevels.cpp
|
d4a338f4d0a0cdc08d7d3668931c60997f0fa971 |
|
27-Apr-2017 |
Matt Sarett <msarett@google.com> |
Delete copyTo(Allocator), hide copyTo() behind flag Replace uses of copyTo() in Skia. Bug: skia:6464 Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548 Reviewed-on: https://skia-review.googlesource.com/14502 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/gm/showmiplevels.cpp
|
4edb5d219eb99aa1e8fbe5e37260d3b34314e54b |
|
17-Apr-2017 |
Mike Reed <reed@google.com> |
hide lockpixels api behind flag guarded by SK_SUPPORT_OBSOLETE_LOCKPIXELS needs https://codereview.chromium.org/2820873002/# to land first Bug: skia:6481 Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09 Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09 Reviewed-on: https://skia-review.googlesource.com/13580 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/gm/showmiplevels.cpp
|
33d2055e594177b27360f84e0631b26d74a55a9b |
|
22-Mar-2017 |
Mike Klein <mtklein@chromium.org> |
GM: some header cleanup gm.h includes sk_tool_utils.h but does not use it. The bulk of this CL makes each gm that uses sk_tool_utils include it. sk_tool_utils.h also provided SkRandom and SkTDArray, so a couple GMs add those headers too. Change-Id: Ieb2a7c542f0ca89c3223f744fc11b0ff37af36c1 Reviewed-on: https://skia-review.googlesource.com/10014 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
/external/skia/gm/showmiplevels.cpp
|
65a17539d2ab1866b2c8252155b0a7fbe127d861 |
|
26-Jan-2017 |
Brian Salomon <bsalomon@google.com> |
Fix clang warning about unused lambda capture. This was found by a tip of tree build of clang. Change-Id: I9aa3fecd47ae69350e8d58e796f960a991b7759e Reviewed-on: https://skia-review.googlesource.com/7586 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/gm/showmiplevels.cpp
|
4897fb898f62a983829e56fc72b5ce6fd1ad62e4 |
|
18-Jan-2017 |
Matt Sarett <msarett@google.com> |
Implement sk_tool_utils::copy_to_g8(), used by gms BUG=skia: Change-Id: Ic5b2b07fb3f408edf1f2b982235424c22795fe50 Reviewed-on: https://skia-review.googlesource.com/7187 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/gm/showmiplevels.cpp
|
cb6266b5aa5bbfd880532f08eec83b0c585e873f |
|
17-Jan-2017 |
Matt Sarett <msarett@google.com> |
Reland "Add SkImageInfoValidConversion() and SkImageInfoIsValid" The original is at: https://skia-review.googlesource.com/c/6887/ The only change to the original is to temporarily comment out a check in SkImageInfoPriv.h until a Chrome unit test can be fixed. The idea is share these standards for the following: SkImage::readPixels() SkCanvas::readPixels() SkCanvas::writePixels() SkBitmap::readPixels() SkPixmap::readPixels() On the raster side, SkPixmap::readPixels() is the right place to check, because all raster calls go through there eventually. Then at lower levels (ex: SkPixelInfo), we can assert. There's not really a unifying location for gpu calls, so I've added this in multiple places. I haven't really dug into the gpu code to SkASSERT() on invalid cases that we will have already caught. Follow-up work: Similar refactor for SkReadPixelRec::trim(). Code cleanup in SkPixelInfo::CopyPixels() BUG=skia:6021 Change-Id: I6a16f9479bc09e3c87e10c72b0378579f1a70866 Reviewed-on: https://skia-review.googlesource.com/7104 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/gm/showmiplevels.cpp
|
7a6c9f7be115031a8a86fdae20e8869fd973fdb6 |
|
15-Jan-2017 |
Brian Osman <brianosman@google.com> |
Revert "Add SkImageInfoValidConversion() and SkImageInfoIsValid" This reverts commit cf5d6caff7a58f1c7ecc36d9a91ccdada5fc7b78. Reason for revert: Chrome DEPS roll failing, based on the unit tests, I suspect this is the cause. Original change's description: > Add SkImageInfoValidConversion() and SkImageInfoIsValid > > The idea is share these standards for the following: > SkImage::readPixels() > SkCanvas::readPixels() > SkCanvas::writePixels() > SkBitmap::readPixels() > SkPixmap::readPixels() > > On the raster side, SkPixmap::readPixels() is the right > place to check, because all raster calls go through > there eventually. Then at lower levels (ex: SkPixelInfo), > we can assert. > > There's not really a unifying location for gpu calls, > so I've added this in multiple places. I haven't really > dug into the gpu code to SkASSERT() on invalid cases > that we will have already caught. > > Follow-up work: > Similar refactor for SkReadPixelRec::trim(). > Code cleanup in SkPixelInfo::CopyPixels() > > BUG=skia:6021 > > Change-Id: I91ecce10e46c1a6530f0af24a9eb8226dbecaaa2 > Reviewed-on: https://skia-review.googlesource.com/6887 > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=mtklein@google.com,msarett@google.com,brianosman@google.com,reed@google.com,reviews@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia:6021 Change-Id: I63b88e90bdbb3051a14de00ac73a8351ab776d25 Reviewed-on: https://skia-review.googlesource.com/7095 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/gm/showmiplevels.cpp
|
cf5d6caff7a58f1c7ecc36d9a91ccdada5fc7b78 |
|
13-Jan-2017 |
Matt Sarett <msarett@google.com> |
Add SkImageInfoValidConversion() and SkImageInfoIsValid The idea is share these standards for the following: SkImage::readPixels() SkCanvas::readPixels() SkCanvas::writePixels() SkBitmap::readPixels() SkPixmap::readPixels() On the raster side, SkPixmap::readPixels() is the right place to check, because all raster calls go through there eventually. Then at lower levels (ex: SkPixelInfo), we can assert. There's not really a unifying location for gpu calls, so I've added this in multiple places. I haven't really dug into the gpu code to SkASSERT() on invalid cases that we will have already caught. Follow-up work: Similar refactor for SkReadPixelRec::trim(). Code cleanup in SkPixelInfo::CopyPixels() BUG=skia:6021 Change-Id: I91ecce10e46c1a6530f0af24a9eb8226dbecaaa2 Reviewed-on: https://skia-review.googlesource.com/6887 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/gm/showmiplevels.cpp
|
7b8400dad2f82dcc6ed3c7cc1707ebaf85f04840 |
|
08-Nov-2016 |
Brian Osman <brianosman@google.com> |
Rename SkSourceGammaTreatment to SkDestinationSurfaceColorMode This is much more explicit about what that type represents (are we in legacy mode or not), which also makes it suitable for other (upcoming) usage. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4529 Change-Id: Iacb397c34e7765f1ca86c0195bc622b2be4d9acf Reviewed-on: https://skia-review.googlesource.com/4529 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/gm/showmiplevels.cpp
|
cefc43112c8f6fe3702facb89447bdfcc2715345 |
|
04-Nov-2016 |
Hal Canary <halcanary@google.com> |
gm: s/SkAutoTUnref/sk_sp/ GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4434 Change-Id: Ib2bea321617a17012190b33f2c7c439a5b6b3025 Reviewed-on: https://skia-review.googlesource.com/4434 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
/external/skia/gm/showmiplevels.cpp
|
55713afb7a531bbb6a345a42b5a25ad709d8fd19 |
|
26-Aug-2016 |
robertphillips <robertphillips@google.com> |
Move work from ctor to onOnceBeforeDraw in ShowMipLevel GMs These were making debugging stroking more difficult than necessary GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2285813002 Review-Url: https://codereview.chromium.org/2285813002
/external/skia/gm/showmiplevels.cpp
|
6644d9353f3f0c09914385fd762e073f98d54205 |
|
10-Jun-2016 |
reed <reed@google.com> |
respect srgb gamma when building mips Proposed policy: - If the target is *legacy* (e.g. L32/PMColor) ignore gamma - If the target is S32/F16 respect gamma BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2029373004 Review-Url: https://codereview.chromium.org/2029373004
/external/skia/gm/showmiplevels.cpp
|
9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 |
|
29-Mar-2016 |
halcanary <halcanary@google.com> |
Style bikeshed - remove extraneous whitespace GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002 Review URL: https://codereview.chromium.org/1842753002
/external/skia/gm/showmiplevels.cpp
|
e820dfebbc652bfc4a653f07a29f5fe371eb019b |
|
18-Mar-2016 |
msarett <msarett@google.com> |
Remove uses of SkImageDecoder from gms BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1791583002 Committed: https://skia.googlesource.com/skia/+/d427266a58af7e6ea6c12c9cd56ade3e179a0c04 Review URL: https://codereview.chromium.org/1791583002
/external/skia/gm/showmiplevels.cpp
|
003571887de747942478e33d4e2ff40bf3a65a72 |
|
17-Mar-2016 |
bungeman <bungeman@google.com> |
Revert of Remove uses of SkImageDecoder from gms (patchset #2 id:20001 of https://codereview.chromium.org/1791583002/ ) Reason for revert: Suspected of causing assertion failures in unrelated tests on Windows. Original issue's description: > Remove uses of SkImageDecoder from gms > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1791583002 > > Committed: https://skia.googlesource.com/skia/+/d427266a58af7e6ea6c12c9cd56ade3e179a0c04 TBR=scroggo@google.com,reed@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1806383002
/external/skia/gm/showmiplevels.cpp
|
d427266a58af7e6ea6c12c9cd56ade3e179a0c04 |
|
17-Mar-2016 |
msarett <msarett@google.com> |
Remove uses of SkImageDecoder from gms BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1791583002 Review URL: https://codereview.chromium.org/1791583002
/external/skia/gm/showmiplevels.cpp
|
7c249e531900929c2fe2cdde76619fa6d2538c49 |
|
21-Feb-2016 |
mtklein <mtklein@chromium.org> |
SkNx: kth<...>() -> [...] Just some syntax cleanup. No real change: kth<...>() was calling [...] already. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1714363002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1714363002
/external/skia/gm/showmiplevels.cpp
|
33ed3ad9f62b3c84d439b92ab45732d4fa6d05ad |
|
09-Feb-2016 |
fmalita <fmalita@chromium.org> |
Relocate anisotropic mipmap logic to SkMipMap::extractLevel() Pass a full x/y scale and defer the anisotropic heuristic to SkMipMap. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686563002 Review URL: https://codereview.chromium.org/1686563002
/external/skia/gm/showmiplevels.cpp
|
67b09bf6b7422c7a3209781cbb7827224e3ffc17 |
|
17-Jan-2016 |
reed <reed@google.com> |
use pixmaps in mipmap api BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1598803002 Review URL: https://codereview.chromium.org/1598803002
/external/skia/gm/showmiplevels.cpp
|
32e0b4a34a2d461927056677e0ef99241e29df0d |
|
15-Jan-2016 |
reed <reed@google.com> |
use triangle filter for odd dimensions in mip-levels BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1592473002 Review URL: https://codereview.chromium.org/1592473002
/external/skia/gm/showmiplevels.cpp
|
01dc44ae669b53b45f9b33ab826ba22956bddf62 |
|
15-Jan-2016 |
reed <reed@google.com> |
add GM to show miplevels for all colortypes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1594613002 TBR= Review URL: https://codereview.chromium.org/1594613002
/external/skia/gm/showmiplevels.cpp
|
a40be09c443d15fcb080adde0ab9625e8a5af73d |
|
14-Jan-2016 |
reed <reed@google.com> |
expand gm to exercise miplevels and various scalers BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1574233003 TBR= Review URL: https://codereview.chromium.org/1574233003
/external/skia/gm/showmiplevels.cpp
|