d85db609626e6182f7346635ddb3f2e78b83974e |
|
31-May-2018 |
Derek Sollenberger <djsollen@google.com> |
Expose API for temporary use by the Android WebView. The WebView needs this information in order to correctly draw into an unclipped layer. This API can be removed when we update the Android framework to no longer depend on unclipped layers. Bug: b/79619253 Change-Id: Ibba63005730158021363d1d09e5338578f4fa541 Reviewed-on: https://skia-review.googlesource.com/131148 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com> (cherry picked from commit 9d637c7b0613dc038650f982e7f1ab711e801c2c) Reviewed-on: https://skia-review.googlesource.com/131180 Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/include/core/SkCanvas.h
|
b604bae872ab468a0fb42e30fa10683dea969ed0 |
|
08-May-2018 |
Leon Scroggins III <scroggo@google.com> |
Reland "(Mostly) respect FilterQuality in draw[stretchy]" This reverts commit 149bd00d874139a78c4dd6ff35d9b2095b7e6900. It was only temporarily reverted while the other CLs needed along with it were landed. Original message: Bug: b/77917978 For drawImageLattice drawBitmapLattice drawImageNine drawBitmapNine , respect the SkFilterQuality on the SkPaint. Previously the GPU used the lowest quality to avoid a bleeding effect, leading to ugly nine- patches on Android. For all backends, cap the filter quality at kLow_SkFilterQuality. Update SkCanvas' documentation to specify this. No-Tree-Checks: true No-Try: true No-Presubmit: true Change-Id: I07becc335bb136e6bca9e181bd68b9a3681dd8ab Reviewed-on: https://skia-review.googlesource.com/126822 Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/include/core/SkCanvas.h
|
149bd00d874139a78c4dd6ff35d9b2095b7e6900 |
|
30-Apr-2018 |
Leon Scroggins <scroggo@google.com> |
Revert "(Mostly) respect FilterQuality in draw[stretchy]" This reverts commit e81058c6811a40828636486670ba1e9c1ecf4ce6. Reason for revert: Still need another CL in order to avoid the bleeding. That CL is not ready yet, and Stan wants to land other changes in pi-dev, without this one. Original change's description: > (Mostly) respect FilterQuality in draw[stretchy] > > Bug: b/77917978 > > For > drawImageLattice > drawBitmapLattice > drawImageNine > drawBitmapNine > , respect the SkFilterQuality on the SkPaint. Previously the GPU used > the lowest quality to avoid a bleeding effect, leading to ugly nine- > patches on Android. > > For all backends, cap the filter quality at kLow_SkFilterQuality. > Update SkCanvas' documentation to specify this. > > Change-Id: Id28c7753834975f039170f14bc51be4f2bd44d41 > Reviewed-on: https://skia-review.googlesource.com/121891 > Reviewed-by: Cary Clark <caryclark@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Leon Scroggins <scroggo@google.com> > Auto-Submit: Leon Scroggins <scroggo@google.com> > (cherry picked from commit 57e1f020116e9023b9dfd92478d46749b7248d6e) > Reviewed-on: https://skia-review.googlesource.com/123540 > Reviewed-by: Leon Scroggins <scroggo@google.com> TBR=scroggo@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/77917978 Change-Id: I0a83c3c20f2cdf862741963913c9cb5a55bf8aaa Reviewed-on: https://skia-review.googlesource.com/124620 Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/include/core/SkCanvas.h
|
e81058c6811a40828636486670ba1e9c1ecf4ce6 |
|
20-Apr-2018 |
Leon Scroggins III <scroggo@google.com> |
(Mostly) respect FilterQuality in draw[stretchy] Bug: b/77917978 For drawImageLattice drawBitmapLattice drawImageNine drawBitmapNine , respect the SkFilterQuality on the SkPaint. Previously the GPU used the lowest quality to avoid a bleeding effect, leading to ugly nine- patches on Android. For all backends, cap the filter quality at kLow_SkFilterQuality. Update SkCanvas' documentation to specify this. Change-Id: Id28c7753834975f039170f14bc51be4f2bd44d41 Reviewed-on: https://skia-review.googlesource.com/121891 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Auto-Submit: Leon Scroggins <scroggo@google.com> (cherry picked from commit 57e1f020116e9023b9dfd92478d46749b7248d6e) Reviewed-on: https://skia-review.googlesource.com/123540 Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/include/core/SkCanvas.h
|
5734c4b3d89bac522af3c76d8f711a73039a58c2 |
|
15-Mar-2018 |
Mike Reed <reed@google.com> |
drawTextRSXform should not apply matrix to shader drawTextRSXform should draw the same as drawTextOnPath (as regards shaders) Bug: b/69904791 Change-Id: I393dd8fd7a5bdc6a018b1ca33592b208c7141868 Reviewed-on: https://skia-review.googlesource.com/114468 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> (cherry picked from commit 9c2916e0c7e0a61c0f85384c736247d4fa6d3a7b) Reviewed-on: https://skia-review.googlesource.com/115720 Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/include/core/SkCanvas.h
|
75959391681495896570e7bf8d7f9effdd1306f3 |
|
27-Feb-2018 |
Cary Clark <caryclark@skia.org> |
updated includes update includes to latest bookmaker docs TBR=reed@google.com Bug: skia:6898 Change-Id: If42ab25f98a0f0d8b410ae30ca1cd641e19ce89f Reviewed-on: https://skia-review.googlesource.com/107021 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
/external/skia/include/core/SkCanvas.h
|
e083f7c9f2ed6640866e2d974aabb98e6f3d0712 |
|
07-Feb-2018 |
Mike Klein <mtklein@chromium.org> |
Reland "remove SkCanvas::kIsOpaque_SaveLayerFlag" This reverts the revert 9ff8c8c073ba553dc8b22bb9aacc23949292f72f. Original: This is a performance-only hint that no one but fuzzers is using. It's even explicitly filtered out in Android. The fuzzers have noticed they can trick us into allocating uninitialized memory and treating it as opaque, blending uninitialized pixels, etc. Since no one's using this, we can just kill the bit. Bug: skia:7566, chromium:808830 Docs-Preview: https://skia.org/?cl=105282 Change-Id: I4326c663f777aa373ff7ec9f319519da9729350d Reviewed-on: https://skia-review.googlesource.com/105282 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
9ff8c8c073ba553dc8b22bb9aacc23949292f72f |
|
07-Feb-2018 |
Mike Klein <mtklein@google.com> |
Revert "remove SkCanvas::kIsOpaque_SaveLayerFlag" This reverts commit 9a7a2ee5ad8453a985d7d76c1e0ebb50d17fec63. Reason for revert: still need to update blink_headless in Google3 Original change's description: > remove SkCanvas::kIsOpaque_SaveLayerFlag > > This is a performance-only hint that no one but fuzzers > is using. It's even explicitly filtered out in Android. > > The fuzzers have noticed they can trick us into allocating > uninitialized memory and treating it as opaque, blending > uninitialized pixels, etc. > > Since no one's using this, we can just kill the bit. > > Bug: skia:7566, chromium:808830 > > Change-Id: Id74a85e51bc4d0907b4127eb9ac5b02576f8f0a7 > Reviewed-on: https://skia-review.googlesource.com/104441 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,fmalita@chromium.org,reed@google.com Change-Id: I10d3c7e5184b9322715a5bfb6a7106292c8876a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7566, chromium:808830 Reviewed-on: https://skia-review.googlesource.com/104781 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
/external/skia/include/core/SkCanvas.h
|
9a7a2ee5ad8453a985d7d76c1e0ebb50d17fec63 |
|
06-Feb-2018 |
Mike Klein <mtklein@chromium.org> |
remove SkCanvas::kIsOpaque_SaveLayerFlag This is a performance-only hint that no one but fuzzers is using. It's even explicitly filtered out in Android. The fuzzers have noticed they can trick us into allocating uninitialized memory and treating it as opaque, blending uninitialized pixels, etc. Since no one's using this, we can just kill the bit. Bug: skia:7566, chromium:808830 Change-Id: Id74a85e51bc4d0907b4127eb9ac5b02576f8f0a7 Reviewed-on: https://skia-review.googlesource.com/104441 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
a6cd625f49567754d2ffabf3e89a68ad34b74b65 |
|
22-Jan-2018 |
Mike Reed <reed@google.com> |
Revert "declare SkRasterizer for android" This reverts commit e168c3e8f9a13472983a567ecd679226c9d0d186. Reason for revert: fix in android landed Original change's description: > declare SkRasterizer for android > > Bug: skia: > Change-Id: Ibea090143c7fe21c21a5d98dc490eca0fc72ab99 > Reviewed-on: https://skia-review.googlesource.com/97665 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=scroggo@google.com,reed@google.com Change-Id: I54b4dfdef9645605fbdb69bfdb0b03293cd4f4a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/97880 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
e168c3e8f9a13472983a567ecd679226c9d0d186 |
|
21-Jan-2018 |
Mike Reed <reed@google.com> |
declare SkRasterizer for android Bug: skia: Change-Id: Ibea090143c7fe21c21a5d98dc490eca0fc72ab99 Reviewed-on: https://skia-review.googlesource.com/97665 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
8ad91a9bf896d728b905124847d74787aac698a7 |
|
20-Jan-2018 |
Mike Reed <reed@google.com> |
remove unused SkRasterizer Bug: skia:7500 Change-Id: Iaa683cf8f0b18887cce4ec676631d1e1efee1712 Reviewed-on: https://skia-review.googlesource.com/97400 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
2823f9f06c15fd581e7518dc4e674ad56917dcdb |
|
03-Jan-2018 |
Cary Clark <caryclark@skia.org> |
refresh public includes Update includes to fix minor edits and bookmaker bugs. Also update SkPoint.h for the first time to see if that sticks. TBR=reed@google.com Bug: skia:6898 Change-Id: I7d11dea45482602248e2d15b05699bb4c86ea4c6 Reviewed-on: https://skia-review.googlesource.com/90541 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
/external/skia/include/core/SkCanvas.h
|
ca8c0953e8da1def5e6c12dde6d4368b4bf16077 |
|
11-Dec-2017 |
Stan Iliev <stani@google.com> |
Implement a fast path for solid color lattice rectangle Add a flag that hints, which lattice rectangles are solid colors. Draw solid rectangles and 1x1 rectangles with drawRect. Test: Measured performance of a ninepatch drawn by HWUI Bug: b/69796044 Change-Id: Ib3b00ca608da42fa9f2d2038cc126a978421ec7c Reviewed-on: https://skia-review.googlesource.com/79821 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/include/core/SkCanvas.h
|
83c8dd9b1a20ec5b866a6c5a557313c13ae8904f |
|
28-Nov-2017 |
Mike Klein <mtklein@chromium.org> |
devirtualize SkCanvas getClipBounds methods We no longer have any subclasses overriding the virtual hooks, and we've seen subtle bugs come up back when they did. In all modes, SkCanvas can answer these queries itself. BUG=chromium:781238 Change-Id: I37c7511c7bd00c638faacbe4bee89f785691453f Reviewed-on: https://skia-review.googlesource.com/77202 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
12f77343ee645d7b96e5d6a78370e5f5a38eaea4 |
|
08-Nov-2017 |
Mike Reed <reed@google.com> |
add surfaceprops param to SkCanvas::MakeRasterDirect Bug: skia: Change-Id: I8b69280469cdf34c3c3cb126db9457a712143f88 Reviewed-on: https://skia-review.googlesource.com/68701 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
61b43daa858f3e68c95bf972d510c2d66461b386 |
|
01-Nov-2017 |
Brian Osman <brianosman@google.com> |
Plumb internal helper to enable more GPU GMs w/SkColorSpaceXformCanvas API change isn't really public. TBR:bsalomon@google.com Bug: skia: Change-Id: I3a1ae5d7ddb562387e8b8e1248b347704f88037b Reviewed-on: https://skia-review.googlesource.com/66144 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/include/core/SkCanvas.h
|
cc309eb9b18a707dfb94d89866a474bebf7f2777 |
|
30-Oct-2017 |
Cary Clark <caryclark@skia.org> |
generated include refresh The latest, minor changes on includes already generated, plus four new ones. TBR=reed@google.com Bug: skia:6898 Change-Id: If06ae9b9aaa3a0a9fae570aa7a6698ff340c43b8 Reviewed-on: https://skia-review.googlesource.com/62862 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
/external/skia/include/core/SkCanvas.h
|
63fd760a37905c45d26fc3d49cac261fad1b4808 |
|
09-Oct-2017 |
Ben Wagner <bungeman@google.com> |
Remove trailing whitespace. Also adds a presubmit to prevent adding trailing whitespace to source code in the future. Change-Id: I41a4df81487f6f00aa19b188f0cac6a3377efde6 Reviewed-on: https://skia-review.googlesource.com/57380 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/include/core/SkCanvas.h
|
8a02b0bca0905e6e151c1584b923ae288b7c5af4 |
|
21-Sep-2017 |
Cary Clark <caryclark@skia.org> |
regenerate includes Fresh off the griddle versions of: SkPaint.h, SkCanvas.h, SkPath.h, and SkPixmap.h. TBR=reed@google.com Bug: skia: 9868 Change-Id: If3f0c1cd7973c53482772c2478b12f1070c9fc4d Reviewed-on: https://skia-review.googlesource.com/46587 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Cary Clark <caryclark@skia.org>
/external/skia/include/core/SkCanvas.h
|
b7da7239f73554abebc579a1525e1f4993fee8d8 |
|
01-Sep-2017 |
Cary Clark <caryclark@skia.org> |
generated SkCanvas.h SkCanvas.h generated from docs/SkCanvas.bmh using bookmaker. Also added corrections to SkPaint.h, and generated SkPath.h. Once these are functionally correct (e.g., they don't break anything) I plan to check them in -- feel free to continue to review them before and after the check in event. R=brianosman@google.com TBR=reed@google.com Bug: skia:6898 Change-Id: I6d01e9eee422304e5ab871b3870a7ed710efd645 Reviewed-on: https://skia-review.googlesource.com/30460 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org> Reviewed-by: Yuqian Li <liyuqian@google.com>
/external/skia/include/core/SkCanvas.h
|
a93a14a99816d25b773f0b12868143702baf44bf |
|
28-Aug-2017 |
Ben Wagner <bungeman@google.com> |
Convert NULL and 0 to nullptr. This was created by looking at warnings produced by clang's -Wzero-as-null-pointer-constant. This updates most issues in Skia code. However, there are places where GL and Vulkan want pointer values which are explicitly 0, external headers which use NULL directly, and possibly more uses in un-compiled sources (for other platforms). Change-Id: Id22fbac04d5c53497a53d734f0896b4f06fe8345 Reviewed-on: https://skia-review.googlesource.com/39521 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/include/core/SkCanvas.h
|
6dd8cf144ecbc395dc12bd5f775bbeee04b9d38c |
|
04-Aug-2017 |
Robert Phillips <robertphillips@google.com> |
Remove SkLightingShader and associated classes Change-Id: I8050414c30dfdb5df23ca79955adc5ba3a29d3f5 Reviewed-on: https://skia-review.googlesource.com/31140 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
73d8fd90653135bb1247f92ebc1d730a40b4f9d5 |
|
02-Aug-2017 |
Stan Iliev <stani@google.com> |
Add a private API for writing the clip to the stencil Add a private API used by Android framework, which writes the clip into a stencil buffer. This is used by HWUI to clip the WebView. Bug: 31489986 Change-Id: I94515f1539acd9d069c8aceb3300577feed9c94f Reviewed-on: https://skia-review.googlesource.com/29521 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/include/core/SkCanvas.h
|
d0e0a8ff416abf9b4736ddac8f6faeb11023ab80 |
|
04-Jun-2017 |
Vaclav Brozek <vabr@chromium.org> |
Don't move raw pointers in SkCanvas Moving raw pointers does the same job as copying, but is more verbose and also more confusing: e.g., is the supposed pointer meant to be a smart one? This instance was flagged by the tool from https://codereview.chromium.org/2919243002/. BUG=chromium:729393 Change-Id: I4c89e9d80fab9f6d14ab7db53e8b9b6e7cf966dc Reviewed-on: https://skia-review.googlesource.com/18540 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
4204da25aa4c6e0b321314aa32fd9affb4865563 |
|
17-May-2017 |
Mike Reed <reed@google.com> |
move shadows to device virtual This CL keeps the impl for each device backend in the utils file for simplicity (shared helpers). Future CLs may move into their respective impl as they become more specialized. Bug: skia: Change-Id: I97ce6cdcc5106ebf4c84778f943cc32d0b7613c1 Reviewed-on: https://skia-review.googlesource.com/15893 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
23e474cb7331c5d2389d97dce2d9e5c93c58f39f |
|
15-May-2017 |
Hal Canary <halcanary@google.com> |
SkCanvas: Helpers for draw{Point,Line,Circle} Change-Id: Ie9c7d3b8f01aee435563b23b7d27f098f07dd287 Reviewed-on: https://skia-review.googlesource.com/16909 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/include/core/SkCanvas.h
|
304f9d4e0feb4665d88804c3a4c28b6397c377b0 |
|
13-May-2017 |
Cary Clark <caryclark@skia.org> |
add and fix parameter names after manually fixing missing names needed to make documentation easier, the bookmaker tool found a number of additional errors. this is why computers will take our jobs R=reed@google.com DOCS_PREVIEW= https://skia.org/?cl=16616 Change-Id: Ieabebf5672601769852adde9be47459602fb43ab Change-Id: Ieabebf5672601769852adde9be47459602fb43ab Reviewed-on: https://skia-review.googlesource.com/16616 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
0418a888d31689f5358b6b90fd09287aeba368db |
|
10-May-2017 |
Cary Clark <caryclark@google.com> |
add parameter names Functions in SkPaint and SkCanvas are easier to write about when all of their parameters are named. Also, move GlyphCacheProc to private since the only interface that returns it is already in private. R=reed@google.com Change-Id: Iaea46213d5614d564c1c3de99e6f96c5efaec4b1 Reviewed-on: https://skia-review.googlesource.com/16175 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
/external/skia/include/core/SkCanvas.h
|
d2da87d0b8d127da0530c661618f059eb1cc0f1e |
|
08-May-2017 |
Brian Osman <brianosman@google.com> |
Forward getGrContext in color space xform canvas Bug: chromium:719664 Change-Id: I7477c1eb0479d5305233dc6a643280d88029bd17 Reviewed-on: https://skia-review.googlesource.com/15888 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/include/core/SkCanvas.h
|
ab244f045a0740fa6106ed21a4e5824cd09f84f3 |
|
03-May-2017 |
Florin Malita <fmalita@chromium.org> |
Revert "Revert "Reland: Remove SkLights include from SkCanvas.h"" This reverts commit 9d5f66d9c21eda7d3e2ed47654180c0c4b6e38b1. Reason for revert: Leon landed Android fixes. Original change's description: > Revert "Reland: Remove SkLights include from SkCanvas.h" > > This reverts commit fed00319c9bafa41c8df658708030c072b301a41. > > Reason for revert: breaking the Android roll. > > Original change's description: > > Reland: Remove SkLights include from SkCanvas.h > > > > SkLights.h pulls in a bunch of other headers and is not needed (fwdecl > > works fine). > > > > Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb > > TBR=reed@google.com > > Reviewed-on: https://skia-review.googlesource.com/15143 > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > Reviewed-by: Florin Malita <fmalita@chromium.org> > > > > TBR=fmalita@chromium.org,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I3b0e69f1d04d160f16a5567b09982d35cc9ca84e > Reviewed-on: https://skia-review.googlesource.com/15195 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=msarett@google.com,reviews@skia.org,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I0a1c2f9df61f16987ab72dfb4f3a205fbcc37667 Reviewed-on: https://skia-review.googlesource.com/15229 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
a9e241d357641493ba1908cd36cf43d16490421b |
|
03-May-2017 |
Mike Reed <reed@google.com> |
drawfilter is legacy-guarded, no need for deprecated Bug: skia: Change-Id: Ic8dbe9aa043bd793e49975f5b6f08a0ac38e4faa Reviewed-on: https://skia-review.googlesource.com/15185 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
9d5f66d9c21eda7d3e2ed47654180c0c4b6e38b1 |
|
03-May-2017 |
Florin Malita <fmalita@chromium.org> |
Revert "Reland: Remove SkLights include from SkCanvas.h" This reverts commit fed00319c9bafa41c8df658708030c072b301a41. Reason for revert: breaking the Android roll. Original change's description: > Reland: Remove SkLights include from SkCanvas.h > > SkLights.h pulls in a bunch of other headers and is not needed (fwdecl > works fine). > > Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb > TBR=reed@google.com > Reviewed-on: https://skia-review.googlesource.com/15143 > Commit-Queue: Florin Malita <fmalita@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > TBR=fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I3b0e69f1d04d160f16a5567b09982d35cc9ca84e Reviewed-on: https://skia-review.googlesource.com/15195 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
fed00319c9bafa41c8df658708030c072b301a41 |
|
02-May-2017 |
Florin Malita <fmalita@chromium.org> |
Reland: Remove SkLights include from SkCanvas.h SkLights.h pulls in a bunch of other headers and is not needed (fwdecl works fine). Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb TBR=reed@google.com Reviewed-on: https://skia-review.googlesource.com/15143 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
343fe49b82d5b220d64c64f253bb362026006632 |
|
02-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Remove translateZ and lights from SkCanvas Bug: skia:6557 Change-Id: I0dbf70c4131ab59e7fc6c674a6587767af98e13a Reviewed-on: https://skia-review.googlesource.com/15151 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
4c9155bd66d86de48069192f4b73bc292cfec135 |
|
02-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Remove EXPERIMENTAL_SHADOWING, Part 1 Bug: skia:6557 Change-Id: I6482d74be7b360c93141a73dd80c67854530c7a1 Reviewed-on: https://skia-review.googlesource.com/15101 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
38aad81a542612a86c5765ec2bf9d2c164280e9e |
|
02-May-2017 |
Florin Malita <fmalita@chromium.org> |
Revert "Remove SkLights include from SkCanvas.h" This reverts commit 9ff301bf918cd85d9f67047f10631b7a74345a90. Reason for revert: need to update G3, Flutter. Original change's description: > Remove SkLights include from SkCanvas.h > > SkLights.h pulls in a bunch of other headers and is not needed (fwdecl > works fine). > > Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f > Reviewed-on: https://skia-review.googlesource.com/14904 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4799ad5b31aaeaf529c8b912bbe09aa8869a5e6c Reviewed-on: https://skia-review.googlesource.com/15107 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
9ff301bf918cd85d9f67047f10631b7a74345a90 |
|
01-May-2017 |
Florin Malita <fmalita@chromium.org> |
Remove SkLights include from SkCanvas.h SkLights.h pulls in a bunch of other headers and is not needed (fwdecl works fine). Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f Reviewed-on: https://skia-review.googlesource.com/14904 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
6a280a50eddc30c6b2a090d9e8e7df78afe7a457 |
|
01-May-2017 |
Adrienne Walker <enne@chromium.org> |
Expose resetForNextPicture in SkNoDrawCanvas SkRecorder has some private Skia behavior with the way it handles an SkNoDrawCanvas that is not exposed. In particular, it's able to create an arbitrary SkIRect device clip at construction time. This is a performance optimization when reusing SkNoDrawCanvas across multiple recordings instead of reconstructing a new canvas every time. https://codereview.chromium.org/2768143002 is trying to implement another version of SkPictureBuilder/SkRecorder and so wants to be able to use similar SkNoDrawCanvas behavior. Change-Id: I0ac5f0eef8f0548cefd7354062311667cf448b07 Reviewed-on: https://skia-review.googlesource.com/11320 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
b34ab04884f6219b93c1f143c83a1fc60fded40c |
|
01-May-2017 |
Mike Klein <mtklein@chromium.org> |
Revert "Revert "SaveLayerRec::fClipMask -> raw pointer"" This reverts commit 3354969a4a4adcea159f3a0b01ad0a7c04fc9115. Reason for revert: not the problem? Original change's description: > Revert "SaveLayerRec::fClipMask -> raw pointer" > > This reverts commit a6b72cb5729306fdd676d739c1e2c53afa0786a7. > > Reason for revert: red bots > > Original change's description: > > SaveLayerRec::fClipMask -> raw pointer > > > > Use raw pointers for optional clip mask plumbing, to match the backdrop > > API. > > > > Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2 > > Reviewed-on: https://skia-review.googlesource.com/14901 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > > > TBR=fmalita@chromium.org,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I4387620cdc3410018af9cef221e5cf8d09015380 > Reviewed-on: https://skia-review.googlesource.com/14955 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,reviews@skia.org,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I6dde9e0441928f7a7423139a5c39f520f892f4b5 Reviewed-on: https://skia-review.googlesource.com/14958 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
3354969a4a4adcea159f3a0b01ad0a7c04fc9115 |
|
01-May-2017 |
Mike Klein <mtklein@chromium.org> |
Revert "SaveLayerRec::fClipMask -> raw pointer" This reverts commit a6b72cb5729306fdd676d739c1e2c53afa0786a7. Reason for revert: red bots Original change's description: > SaveLayerRec::fClipMask -> raw pointer > > Use raw pointers for optional clip mask plumbing, to match the backdrop > API. > > Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2 > Reviewed-on: https://skia-review.googlesource.com/14901 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4387620cdc3410018af9cef221e5cf8d09015380 Reviewed-on: https://skia-review.googlesource.com/14955 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkCanvas.h
|
a6b72cb5729306fdd676d739c1e2c53afa0786a7 |
|
01-May-2017 |
Florin Malita <fmalita@chromium.org> |
SaveLayerRec::fClipMask -> raw pointer Use raw pointers for optional clip mask plumbing, to match the backdrop API. Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2 Reviewed-on: https://skia-review.googlesource.com/14901 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
25b37430e606ff268d000b8d1d2c59b4c90679ed |
|
01-May-2017 |
Florin Malita <fmalita@chromium.org> |
Restore legacy SaveLayerRec ctor Let's not break existing clients. Change-Id: I056fefefb49d46fb284597c5bcf0319470537524 Reviewed-on: https://skia-review.googlesource.com/14829 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
53f77bd4fdd76525b66b7f26d1c5c550858120df |
|
28-Apr-2017 |
Florin Malita <fmalita@chromium.org> |
Initial clip-mask-layer support SkBitmapDevice-only implementation. Will add A8 fast path specializations in a follow-up. Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1 BUG=skia:6005 Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1 Reviewed-on: https://skia-review.googlesource.com/14183 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
135c908812874e1b1ee1b9dcaf7d55544d1f8e2a |
|
19-Apr-2017 |
Florin Malita <fmalita@chromium.org> |
Remove temporary_internal_describeTopLayer Change-Id: I035b7db84b524be13fb675b75bc402bc9b733cb5 Reviewed-on: https://skia-review.googlesource.com/13803 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
2a475eae622adc1e8fa29206be1eaf862c23548e |
|
28-Apr-2017 |
Cary Clark <caryclark@google.com> |
add drawString helper to canvas Many tests and examples use drawText with a guess of how long the text is in bytes, or a call to strlen(). Add a helper to SkCanvas to simplify these examples. Add another helper for SkString. R=reed@google.com Change-Id: I0204a31e938f065606f08ee7cd9a6b36db791ee2 Reviewed-on: https://skia-review.googlesource.com/13642 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Cary Clark <caryclark@skia.org>
/external/skia/include/core/SkCanvas.h
|
544e0ad49c11bd349782618de6430bdf8cec0106 |
|
20-Apr-2017 |
Mike Reed <reed@google.com> |
remove dead code around SK_SUPPORT_LEGACY_CANVAS_READPIXELS Bug: skia:6513 Change-Id: I8e4e0ffb371ae5b1af972110339e57d491ad9ff1 Reviewed-on: https://skia-review.googlesource.com/13779 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
12e946b4bfdf598bffb276776ea6e25439e25265 |
|
17-Apr-2017 |
Mike Reed <reed@google.com> |
deprecate odd variants of SkCanvas::readPixels Bug: skia:6513 Change-Id: I51179a85f0912d3f899c368c30a943d346dd1d05 Reviewed-on: https://skia-review.googlesource.com/13589 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
1335a0561e28b97ff4347129c7cc3fdcbf952eb5 |
|
13-Apr-2017 |
Mike Reed <reed@google.com> |
remove dead code around replayClips Bug: skia: Change-Id: I208bf41846265524d86f65de660311199fefc158 Reviewed-on: https://skia-review.googlesource.com/13338 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
31f99ce7d2f3c2b61742d07ab92b6dac6a928ef9 |
|
11-Apr-2017 |
Matt Sarett <msarett@google.com> |
SkCanvas constructor with legacy flag for Android framework Bug: skia: Change-Id: I5b268ad03dde075f2710196d5ad2bd19249557f7 Reviewed-on: https://skia-review.googlesource.com/11788 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
9d9172fe2c798eb2a1fe2cce51feb157050294d9 |
|
05-Apr-2017 |
Mike Reed <reed@google.com> |
remove legacy vertices flag and code Bug: skia:6366 Change-Id: Ibea5f71c5ff570e4f3ccec7d064893602c3335cf Reviewed-on: https://skia-review.googlesource.com/11359 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
93b1b4feda10c50ce10763ddf7e807f9b85c7953 |
|
05-Apr-2017 |
Mike Reed <reed@google.com> |
add guard for obsolete (non-functioning) replayClips replayClips has been disabled (broken) for a while. This CL just attempts to hide the api (will remove once android's callsite is removed) Bug: skia: Change-Id: I35b412addfc0a08ea888a62609888b9b54dce2a6 Reviewed-on: https://skia-review.googlesource.com/11401 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
8653e973893bcaf0b09325d8e0a81b4b20d47aa3 |
|
05-Apr-2017 |
Mike Reed <reed@google.com> |
remove legacy canvas helpers Bug: skia: Change-Id: I79e08adb49556be506e6198d9fadda684bcb08f2 Reviewed-on: https://skia-review.googlesource.com/11321 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
887cdf112809727c51890ba8b98b3ddce22249f0 |
|
03-Apr-2017 |
Mike Reed <reed@google.com> |
move vertex-mode enum into SkVertices BUG=skia:6366 Change-Id: I3c0bf96cce6d32c9b8d12d16a772aaa6f18981aa Reviewed-on: https://skia-review.googlesource.com/11062 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
3130fbb1a7aa60ac764f5ccb64a1a0ee976ea127 |
|
21-Mar-2017 |
Mike Reed <reed@google.com> |
remove SK_SUPPORT_LEGACY_DRAWVERTICES_VIRTUAL flag BUG=skia:6366 Change-Id: If5e5bc2a65f2d8c66d7bef36cbb906c01225f80f Reviewed-on: https://skia-review.googlesource.com/9940 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
6ab59baa84644a30f57ebf98a57a7561b644dfb3 |
|
17-Mar-2017 |
Mike Reed <reed@google.com> |
remove unused params BUG=skia:6366 Change-Id: I0cfb8e4a969dc018339047183176fb242e455ab8 NOTRY=True Reviewed-on: https://skia-review.googlesource.com/9869 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
fed9cfdc0216152d7fffe6d838ea7281466ffe74 |
|
17-Mar-2017 |
Mike Reed <reed@google.com> |
remove legacy virtual for vertices, only support object form BUG=skia:6366 Change-Id: Ic422fa44a788d3488c050c6218dbfba188bb8f3e Reviewed-on: https://skia-review.googlesource.com/9835 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
e88a1cb20e6b4c9f099070112225a88693a4630b |
|
17-Mar-2017 |
Mike Reed <reed@google.com> |
Revert[2] "More SkVertices implementation work"" The fix was to release the array of vertices in the picturerecorder destructor (where we also release textblobs etc. This reverts commit 1eb3fef136bc75bd8e8ed717ec7c5d4ab26def62. BUG=skia: Change-Id: I3bf4acd6ad209205b0832a3cb7f94cd89dfcefc5 Reviewed-on: https://skia-review.googlesource.com/9826 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
1eb3fef136bc75bd8e8ed717ec7c5d4ab26def62 |
|
17-Mar-2017 |
Mike Reed <reed@google.com> |
Revert "More SkVertices implementation work" This reverts commit 14583e11fd622c686993b741499060a6f3527055. Reason for revert: leaking Direct leak of 499104 byte(s) in 2112 object(s) allocated from: #0 0x1e195f0 in operator new(unsigned long) (/b/swarm_slave/w/irazbR79/out/Debug/dm+0x1e195f0) #1 0x3142b0a in SkVertices::Builder::init(SkCanvas::VertexMode, int, int, SkVertices::Sizes const&) (/b/swarm_slave/w/irazbR79/out/Debug/dm+0x3142b0a) Original change's description: > More SkVertices implementation work > > - change virtuals to take const SkVertices*, as we do for TextBobs and Images > - override onDrawVerticesObject in recording canvases > - deserialize raw-vertices into SkVertices object > > Possibly a follow-on would intercept the raw-form directly in canvas, > and remove the virtual, and only support the object form. > > BUG=skia:6366 > > Change-Id: I57a932667ccb3b3b004beb802ac3ae6898e3c6e0 > Reviewed-on: https://skia-review.googlesource.com/9633 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6366 Change-Id: I40bb7a20698ef6aa0a9ef71a3d6ac4c1473e081c Reviewed-on: https://skia-review.googlesource.com/9825 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
14583e11fd622c686993b741499060a6f3527055 |
|
16-Mar-2017 |
Mike Reed <reed@google.com> |
More SkVertices implementation work - change virtuals to take const SkVertices*, as we do for TextBobs and Images - override onDrawVerticesObject in recording canvases - deserialize raw-vertices into SkVertices object Possibly a follow-on would intercept the raw-form directly in canvas, and remove the virtual, and only support the object form. BUG=skia:6366 Change-Id: I57a932667ccb3b3b004beb802ac3ae6898e3c6e0 Reviewed-on: https://skia-review.googlesource.com/9633 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/include/core/SkCanvas.h
|
5fa6645dbe4f56a51ce0f59c13c99afb12ff3f5c |
|
16-Mar-2017 |
Mike Reed <reed@google.com> |
remove unused VerticesFlags Deferring removing the flags parameter from the virtuals until a later CL (as it collides with another related CL) BUG=skia:6366 Change-Id: I817fae3df03ecebe5ec3532f691ed06deab890e6 Reviewed-on: https://skia-review.googlesource.com/9739 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
8310f0e051e5cb19206428336720bd9988190416 |
|
08-Mar-2017 |
Mike Reed <reed@google.com> |
Revert "remove SkClipVisitor" This reverts commit 91b961d33d1d3e78c212be8738c1c7c468c358ca. Reason for revert: need to update caller in android Original change's description: > remove SkClipVisitor > > With new device clipping, this is unsupported on SkCanvas > > BUG=skia: > > Change-Id: I39443f213be1005b8b9208d604e4bfb31cbda424 > Reviewed-on: https://skia-review.googlesource.com/9349 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: I22df0c66ec564ca32355179d2ee5ea14bff7b1d5 Reviewed-on: https://skia-review.googlesource.com/9456 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
91b961d33d1d3e78c212be8738c1c7c468c358ca |
|
08-Mar-2017 |
Mike Reed <reed@google.com> |
remove SkClipVisitor With new device clipping, this is unsupported on SkCanvas BUG=skia: Change-Id: I39443f213be1005b8b9208d604e4bfb31cbda424 Reviewed-on: https://skia-review.googlesource.com/9349 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
a1361364e64138adda3dc5f71d50d7503838bb6d |
|
07-Mar-2017 |
Mike Reed <reed@google.com> |
Revert[6] "Remove SkDraw from device-draw methods, and enable device-centric clipping."""""" Previous failure was failure to detect that the clip wasn't wide-open when optimizing for retain-vs-discard in copy-on-write. gm:copy_on_write_retain detected this. Now fixed by adding new method to SkBaseDevice.h This reverts commit 27d07f0acb85eea4062075dfbe9148ce12d92c66. BUG=skia:6214 Change-Id: I532d16ec075a4525c2a550b1157bcec695dd8efd Reviewed-on: https://skia-review.googlesource.com/9341 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
27d07f0acb85eea4062075dfbe9148ce12d92c66 |
|
04-Mar-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "Revert "Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping.""""" This reverts commit 025e2444c1f5a0c3cdc0bf60d1fa59941a0b5db4. Reason for revert: layouttest failures -- need to rebase these (tiny diffs in gradients) https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/6018/layout-test-results/results.html Original change's description: > Revert "Revert "Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping."""" > > This reverts commit baf06bc89a0ee2ac4033281e7310f6c727faab79. > > Reason for revert: reland to diagnose possible g3 failure > > Original change's description: > > Revert "Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping.""" > > > > This reverts commit cfaa63237b152ae216f1351207bce3ea9808814c. > > > > Reason for revert: speculative revert to fix Google3 > > > > Original change's description: > > > Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping."" > > > > > > passes new (augmented) CanvasClipType unittest > > > fixed rasterclipstack::setnewsize > > > > > > This reverts commit ea5e676a7b75600edcde3912886486004ccd7626. > > > > > > BUG=skia: > > > > > > Change-Id: I004653e0f4d01454662f8516fccab0046486f273 > > > Reviewed-on: https://skia-review.googlesource.com/9185 > > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > > Commit-Queue: Mike Reed <reed@google.com> > > > > > > > TBR=bsalomon@google.com,reed@google.com,reviews@skia.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Change-Id: Ibd7ee6383999f008eb6ee59c1c3f1c06a86044ea > > Reviewed-on: https://skia-review.googlesource.com/9230 > > Reviewed-by: Cary Clark <caryclark@google.com> > > Commit-Queue: Cary Clark <caryclark@google.com> > > > > TBR=bsalomon@google.com,reviews@skia.org,caryclark@google.com,reed@google.com,mtklein@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Change-Id: I093fa8788056be39af01191bbf3a9e5de9f73954 > Reviewed-on: https://skia-review.googlesource.com/9244 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=mtklein@chromium.org,bsalomon@google.com,reviews@skia.org,caryclark@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: I58f810a8ff241dbaf3133e2fe844548fcd0fa67a Reviewed-on: https://skia-review.googlesource.com/9245 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
025e2444c1f5a0c3cdc0bf60d1fa59941a0b5db4 |
|
04-Mar-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping."""" This reverts commit baf06bc89a0ee2ac4033281e7310f6c727faab79. Reason for revert: reland to diagnose possible g3 failure Original change's description: > Revert "Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping.""" > > This reverts commit cfaa63237b152ae216f1351207bce3ea9808814c. > > Reason for revert: speculative revert to fix Google3 > > Original change's description: > > Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping."" > > > > passes new (augmented) CanvasClipType unittest > > fixed rasterclipstack::setnewsize > > > > This reverts commit ea5e676a7b75600edcde3912886486004ccd7626. > > > > BUG=skia: > > > > Change-Id: I004653e0f4d01454662f8516fccab0046486f273 > > Reviewed-on: https://skia-review.googlesource.com/9185 > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Commit-Queue: Mike Reed <reed@google.com> > > > > TBR=bsalomon@google.com,reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Change-Id: Ibd7ee6383999f008eb6ee59c1c3f1c06a86044ea > Reviewed-on: https://skia-review.googlesource.com/9230 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Cary Clark <caryclark@google.com> > TBR=bsalomon@google.com,reviews@skia.org,caryclark@google.com,reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: I093fa8788056be39af01191bbf3a9e5de9f73954 Reviewed-on: https://skia-review.googlesource.com/9244 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
baf06bc89a0ee2ac4033281e7310f6c727faab79 |
|
03-Mar-2017 |
Cary Clark <caryclark@google.com> |
Revert "Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping.""" This reverts commit cfaa63237b152ae216f1351207bce3ea9808814c. Reason for revert: speculative revert to fix Google3 Original change's description: > Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping."" > > passes new (augmented) CanvasClipType unittest > fixed rasterclipstack::setnewsize > > This reverts commit ea5e676a7b75600edcde3912886486004ccd7626. > > BUG=skia: > > Change-Id: I004653e0f4d01454662f8516fccab0046486f273 > Reviewed-on: https://skia-review.googlesource.com/9185 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=bsalomon@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: Ibd7ee6383999f008eb6ee59c1c3f1c06a86044ea Reviewed-on: https://skia-review.googlesource.com/9230 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
/external/skia/include/core/SkCanvas.h
|
cfaa63237b152ae216f1351207bce3ea9808814c |
|
03-Mar-2017 |
Mike Reed <reed@google.com> |
Revert[2] "Remove SkDraw from device-draw methods, and enable device-centric clipping."" passes new (augmented) CanvasClipType unittest fixed rasterclipstack::setnewsize This reverts commit ea5e676a7b75600edcde3912886486004ccd7626. BUG=skia: Change-Id: I004653e0f4d01454662f8516fccab0046486f273 Reviewed-on: https://skia-review.googlesource.com/9185 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
ea5e676a7b75600edcde3912886486004ccd7626 |
|
02-Mar-2017 |
Mike Reed <reed@google.com> |
Revert "Remove SkDraw from device-draw methods, and enable device-centric clipping." This reverts commit c77e33f73d3e86cfabf925d6f2e1166f81022575. Reason for revert: breaks isClipRect - this CL inspected the conservative clip for this, which is (by definition) a rect - probably need to query the device for this info Original change's description: > Remove SkDraw from device-draw methods, and enable device-centric clipping. > > BUG=skia:6214 > > Change-Id: I593900724310d09133ae4791ef68d38c43762fc2 > Reviewed-on: https://skia-review.googlesource.com/8806 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=bsalomon@google.com,halcanary@google.com,msarett@google.com,robertphillips@google.com,fmalita@chromium.org,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6214 Change-Id: I9090cbbb9f45b2dd204d9fdc187de2ff714b93f6 Reviewed-on: https://skia-review.googlesource.com/9172 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
c77e33f73d3e86cfabf925d6f2e1166f81022575 |
|
02-Mar-2017 |
Mike Reed <reed@google.com> |
Remove SkDraw from device-draw methods, and enable device-centric clipping. BUG=skia:6214 Change-Id: I593900724310d09133ae4791ef68d38c43762fc2 Reviewed-on: https://skia-review.googlesource.com/8806 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
c61abeed8958a757c6b49937f28b63066148dd67 |
|
28-Feb-2017 |
Mike Reed <reed@google.com> |
add isolate (init-with-previous) savelayer flag BUG=skia:4884 Change-Id: If7fabf5cc2c87b870f48dfb87e27a2524fec5ae5 Reviewed-on: https://skia-review.googlesource.com/9045 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
3661bc997620899695041010a750d11dbe8a972d |
|
22-Feb-2017 |
Mike Reed <reed@google.com> |
hide trivial helpers on canvas BUG=skia: Change-Id: I42d4ca92897bde5bd8e0575a0104b12b83134cef Reviewed-on: https://skia-review.googlesource.com/8852 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
ea91b118725f8004dd6dde5ef2d58bd7ccf9500d |
|
16-Feb-2017 |
Mike Reed <reed@google.com> |
remove code for TextDecorations BUG=skia:6250 Change-Id: I8c67c69017e0514b09f4583f5f2f9d16dec4f830 Reviewed-on: https://skia-review.googlesource.com/8497 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
c42a1cdd1de7a3cf57a9a5fd7363f5fb660e97d0 |
|
14-Feb-2017 |
Mike Reed <reed@google.com> |
work on raster device clipping With the flag (SkDevice.h) enabled, I get correct drawing w/ the rasterbackend. After this lands, hopefully we can work in parallel on gpu/pdf/svg/xps/etc. BUG=skia:6214 Change-Id: Ie35fee818470aab57aebacca8a2a5b812a552ee2 Reviewed-on: https://skia-review.googlesource.com/8192 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
c5aa2669df99f1faa341aa5f0d8ceb4c85eef185 |
|
13-Feb-2017 |
Mike Reed <reed@google.com> |
include what you use BUG=skia: Change-Id: I3b9fb3db06a26c55f338f05418ca8ba6fbe7cedf Reviewed-on: https://skia-review.googlesource.com/8400 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
267be7fbc38174652c750ec69d8dc1feaa72db0c |
|
13-Feb-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "IWYU"" This reverts commit 3c727d2386059c1d7cbdcdc9bef5fa18ed33667e. BUG=skia: Change-Id: I72e9b40fec96d044e0ac12906669a52529e77882 Reviewed-on: https://skia-review.googlesource.com/8356 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
3c727d2386059c1d7cbdcdc9bef5fa18ed33667e |
|
11-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Revert "IWYU" This reverts commit 2aeae78a2ce3b036f0401fd0381d6fd6e2a7a1fc. Reason for revert: It looks like this is breaking the android roll out/target/product/angler/obj/SHARED_LIBRARIES/libandroid_runtime_intermediates/android_graphics_Canvas.o frameworks/base/core/jni/android_graphics_Canvas.cpp" frameworks/base/core/jni/android_graphics_Canvas.cpp:178:15: error: incomplete type 'SkRegion' named in nested name specifier Original change's description: > IWYU > > BUG=skia: > > Change-Id: Ib6b4d52841dbe3fa69a86ddb6b97d6a5d0f004ee > Reviewed-on: https://skia-review.googlesource.com/8231 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@google.com> > TBR=fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: If979c3dd9dc3fe08ac450ced113b3d1e9a86f02a Reviewed-on: https://skia-review.googlesource.com/8346 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
2aeae78a2ce3b036f0401fd0381d6fd6e2a7a1fc |
|
10-Feb-2017 |
Mike Reed <reed@google.com> |
IWYU BUG=skia: Change-Id: Ib6b4d52841dbe3fa69a86ddb6b97d6a5d0f004ee Reviewed-on: https://skia-review.googlesource.com/8231 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
199fb875c5e63c13233209e89b943c7ac7ab6665 |
|
06-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Add refcnt'ed immutable vertices class for SkCanvas::drawVertices. Change-Id: I44a62f5efc674d0adbbf4a33690c3ded9fab3803 Reviewed-on: https://skia-review.googlesource.com/8040 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/include/core/SkCanvas.h
|
837e74365e511853df534cc23bd2128c7c235e2f |
|
27-Jan-2017 |
Mike Reed <reed@google.com> |
remove SK_SUPPORT_LEGACY_GETCLIPBOUNDS BUG=skia:6166 Change-Id: I5c8035ee172e14a7a769baff45392a29014d09cb Reviewed-on: https://skia-review.googlesource.com/7645 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
6f4a9b294868a94e5b1e06a8e855833614355bcc |
|
24-Jan-2017 |
Mike Reed <reed@google.com> |
restore bool version of clip-bounds BUG=skia: Change-Id: I94e35566cf5bcd250515c71a566dd79030e2acb4 Reviewed-on: https://skia-review.googlesource.com/7430 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
42e8c53b3ef58f887a623b410d9783b4d4ab4921 |
|
23-Jan-2017 |
Mike Reed <reed@google.com> |
rename virtuals for clipbounds, and deprecate older bool/var-arg pattern BUG=skia: Change-Id: I08bcc2d0559e02838772538816b928e0716dd3aa Reviewed-on: https://skia-review.googlesource.com/7412 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
918e144408ba218df919528f8b48c544f4767883 |
|
23-Jan-2017 |
Mike Reed <reed@google.com> |
change clip-bounds getters to always return the rect (actually fixes undefined result in getClipBounds) future CLs - update all callers to new apis - move/rename virtuals BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=7400 Change-Id: I45b93014e915c0d1c36d97d948c9ac8931f23258 Reviewed-on: https://skia-review.googlesource.com/7400 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
288e471eda2c3648ed1c2dfe6212ad3e6b2451b3 |
|
20-Jan-2017 |
Mike Reed <reed@google.com> |
clipstack is now private BUG=skia: Change-Id: I91e601d59eb5d46de17c280898ca01fcfab89e5c NOTREECHECKS=True Reviewed-on: https://skia-review.googlesource.com/7362 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
4f364fd951eac36adbc1c8719f3e7c42974dfad1 |
|
19-Jan-2017 |
Mike Reed <reed@google.com> |
remove clipstack from lua -- deprecated BUG=skia: Change-Id: I7974b5921aeeabc9c58fdf76731d80b8f0702a70 Reviewed-on: https://skia-review.googlesource.com/7309 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
3726a4ac68821deea7ef4d5472a42f7d35ec4b4e |
|
19-Jan-2017 |
Mike Reed <reed@google.com> |
new hacky api to get cliprgn for android BUG=skia: Change-Id: I42711a474906084adb3c888a599ae02505726484 Reviewed-on: https://skia-review.googlesource.com/7220 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
46784be70c4712942163bb2ade9e7364bca47157 |
|
16-Jan-2017 |
Mike Reed <reed@google.com> |
hide getClipStack BUG=skia:6122 Change-Id: I0aca03b349541174ced019f4f2116e0015c980c4 Reviewed-on: https://skia-review.googlesource.com/7097 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
0ed3b640c9da71fbbd73c65a4ec1992f85596271 |
|
13-Jan-2017 |
Florin Malita <fmalita@google.com> |
Revert "Revert "Hide SkCanvas getDevice() & getTopDevice()}"" This reverts commit e050ca783297db6d88d4d8d0f466f12020747cb8. Reason for revert: Chromium change is sticking, revert not needed. Change-Id: Ic3004460606e4c512f79ba0923746706b960881a Reviewed-on: https://skia-review.googlesource.com/7021 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@google.com>
/external/skia/include/core/SkCanvas.h
|
e050ca783297db6d88d4d8d0f466f12020747cb8 |
|
13-Jan-2017 |
Florin Malita <fmalita@google.com> |
Revert "Hide SkCanvas getDevice() & getTopDevice()}" This reverts commit 76467a11a0aa4ba15f0f2e3ee078ba9b6ecbaa91. Reason for revert: we may need to revert the Chromium GDI change. Original change's description: > Hide SkCanvas getDevice() & getTopDevice()} > > No longer used externally. > > R=reed@google.com > > Change-Id: I450148010852c2567d136d2c85c8837c6dcbc6b9 > Reviewed-on: https://skia-review.googlesource.com/6974 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=fmalita@chromium.org,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: If8480aa5d36ff843c28409a5c94d51570ba0fc1c Reviewed-on: https://skia-review.googlesource.com/6991 Commit-Queue: Florin Malita <fmalita@google.com> Reviewed-by: Florin Malita <fmalita@google.com>
/external/skia/include/core/SkCanvas.h
|
76467a11a0aa4ba15f0f2e3ee078ba9b6ecbaa91 |
|
12-Jan-2017 |
Florin Malita <fmalita@chromium.org> |
Hide SkCanvas getDevice() & getTopDevice()} No longer used externally. R=reed@google.com Change-Id: I450148010852c2567d136d2c85c8837c6dcbc6b9 Reviewed-on: https://skia-review.googlesource.com/6974 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
356f7c2600ef54237fb8678cf63d5953f065b7da |
|
10-Jan-2017 |
Mike Reed <reed@google.com> |
support external raster handles draft CL for chrome: https://codereview.chromium.org/2618323005/ BUG=skia: Change-Id: I5dbcd700818776a9f62f1e10723d2efcc248dc44 Reviewed-on: https://skia-review.googlesource.com/6406 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
f4e27f68b07c063f00d5ef618f5d4a64e785f9c3 |
|
20-Dec-2016 |
Robert Phillips <robertphillips@google.com> |
Remove getDevice_just_for_deprecated_compatibility_testing (take 2) Change-Id: I516ba4ff1c30bb91563a50c6f2b50f6c01c96f5b Reviewed-on: https://skia-review.googlesource.com/6346 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
33667da26dfa376f508ee7dec3b3dd89ef641129 |
|
20-Dec-2016 |
Robert Phillips <robertphillips@google.com> |
Restore getDevice_just_for_deprecated_compatibility_testing Change-Id: I98e73a5f72ef8c8efb1a4f382a5359d21bb5edc8 Reviewed-on: https://skia-review.googlesource.com/6325 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
22f4a1fd4859aa75133de37a24b3201cce5d6844 |
|
20-Dec-2016 |
Robert Phillips <robertphillips@google.com> |
Remove getDevice_just_for_deprecated_compatibility_test() BUG=skia:6067 Change-Id: I646e75f43bc77ea884b7fad7281bf0b684996bb9 Reviewed-on: https://skia-review.googlesource.com/6299 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
2dc523722ec27003ced0735618531f9f2aed1f01 |
|
14-Dec-2016 |
Mike Reed <reed@google.com> |
remove PLAIN_ENUM flag for SkClipOp BUG=skia: Change-Id: I4fc6f270582bb02218144098427bc356b715c893 Reviewed-on: https://skia-review.googlesource.com/6083 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
5f1bb0a7c5186e797aa0f0d447a68fc3fbf3c2fe |
|
12-Dec-2016 |
Stan Iliev <stani@google.com> |
Add a method in SkCanvas to set "hard" clip bounds. Add SkCanvas::setBoundRect, which sets the max clip rectangle, which can be replaced by clipRect, clipRRect and clipPath. BUG=skia: Change-Id: Ie39eb1715214971576e7a1dda760c6997a7e0208 Reviewed-on: https://skia-review.googlesource.com/5359 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/include/core/SkCanvas.h
|
ebfce6d9b42198e04288a15953f40c395a7b6139 |
|
12-Dec-2016 |
Mike Reed <reed@google.com> |
change SkClipOp to a class enum BUG=skia: Change-Id: I25dbe6d6b8666a2a0a7be7bdd2ae0b067868d14e Reviewed-on: https://skia-review.googlesource.com/5718 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
c1f7774e8d327e3c98b4094c9c01d26e27013f71 |
|
09-Dec-2016 |
Mike Reed <reed@google.com> |
Revert[2] "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS" This reverts commit a129dfef2aaab0b5995cdf1ab7b2cdd41c29cf72. BUG=skia: Change-Id: I717de6e5fcd4516aa684b014b1414b0f82ac2b91 Reviewed-on: https://skia-review.googlesource.com/5722 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/include/core/SkCanvas.h
|
a129dfef2aaab0b5995cdf1ab7b2cdd41c29cf72 |
|
09-Dec-2016 |
Mike Reed <reed@google.com> |
Revert "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS" This reverts commit 8e7432b7f98dd592e529a0c8bb038d73ebfb0478. Reason for revert: <INSERT REASONING HERE> external/skia/bench/../tools/android/SkAndroidSDKCanvas.h:103:36: error: C++ requires a type specifier for all declarations void onClipRect(const SkRect&, ClipOp, ClipEdgeStyle) override; Original change's description: > remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS > > > switch over to SkClipOps now that SK_SUPPORT_LEGACY_CLIP_REGIONOPS is gone > > BUG=skia: > > Change-Id: Ifdc8b3746d508348a40cc009a4e529a1cb3c405d > Reviewed-on: https://skia-review.googlesource.com/5714 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org BUG=skia: NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: If26ea91d7464615e43c1d3d2f726e337ff56b55c Reviewed-on: https://skia-review.googlesource.com/5721 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
8e7432b7f98dd592e529a0c8bb038d73ebfb0478 |
|
08-Dec-2016 |
Mike Reed <reed@google.com> |
remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS switch over to SkClipOps now that SK_SUPPORT_LEGACY_CLIP_REGIONOPS is gone BUG=skia: Change-Id: Ifdc8b3746d508348a40cc009a4e529a1cb3c405d Reviewed-on: https://skia-review.googlesource.com/5714 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
02b7349af7ce61c3f7d301148b54e17877233030 |
|
07-Dec-2016 |
Mike Reed <reed@google.com> |
no need for SK_SUPPORT_LEGACY_CANVAS_IS_REFCNT anymore BUG=skia: Change-Id: If0aa01beb8be9bd7d9a3a5b23c795223b02f02d3 Reviewed-on: https://skia-review.googlesource.com/5690 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
439ace939b6aaa58408ece0e9e89b633353571ae |
|
02-Dec-2016 |
Florin Malita <fmalita@chromium.org> |
Rebase non-drawing SkCanvas subclasses to SkNoDrawCanvas R=reed@google.com,mtklein@google.com Change-Id: I7df84587821db561e262a915afa23108a4a78834 Reviewed-on: https://skia-review.googlesource.com/5508 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
4b7b6f0229fa51f5beb71f92cb77ba84d39b41e1 |
|
01-Dec-2016 |
Florin Malita <fmalita@chromium.org> |
Retire SkNoSaveLayerCanvas No clients, superseded by SkNoDrawCanvas. R=reed@google.com Change-Id: I93352c6cfb24ec133ed8433c3b31a5fa5ab1ace8 Reviewed-on: https://skia-review.googlesource.com/5460 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
ee424acbb87bf999be132a437527e656e37541d7 |
|
01-Dec-2016 |
Florin Malita <fmalita@chromium.org> |
SkNoDrawCanvas - a public non-drawing canvas base class TODO: - convert SkDeferredCanvas, SkLiteRecorder, etc. to the new base - remove unused SkNoSaveLayerCanvas BUG=chromium:668925 R=reed@google.com,mtklein@google.com Change-Id: Ie9af577477a6b9eaa5ef55523287ad1635dca116 Reviewed-on: https://skia-review.googlesource.com/5349 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkCanvas.h
|
1a42791a58c4a8e4d83def7efdec700ff443ea6c |
|
29-Nov-2016 |
Mike Klein <mtklein@chromium.org> |
Make SkNWayCanvas use conservative clipping. Like most other canvas subclasses, its clips don't need to be perfect. BUG=chromium:668925 Change-Id: I107f8ed6fa60654426fd52c066b1018d5801850d Reviewed-on: https://skia-review.googlesource.com/5308 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
22886c493596655d8fd9512951f9010869b7fbc5 |
|
22-Nov-2016 |
Matt Sarett <msarett@google.com> |
Add SkOverdrawCanvas to detect overdraw This is the first part of a multi-part change to detect and display gpu overdraw on Android. BUG:32370375 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4907 Change-Id: Ibba9d7343f2fd57397fa1168a5a5b1ef6ef91287 Reviewed-on: https://skia-review.googlesource.com/4907 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/include/core/SkCanvas.h
|
71fecc32b1b4f71ef3c6467b1f5e0b55c2a12428 |
|
18-Nov-2016 |
Mike Reed <reed@google.com> |
don't memtion SkXfermode in public BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5070 Change-Id: Ia9527bfd0f13146669df5e71098af903e14bae3a Reviewed-on: https://skia-review.googlesource.com/5070 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
5df4934b3e40cdc378e225d1dda39f015cae9bae |
|
12-Nov-2016 |
Mike Reed <reed@google.com> |
Revert[2] "Change SkCanvas to *not* inherit from SkRefCnt" Changes over original: - conditionalize ownership in SkPictureRecorder - conditionalize ownership in SkCanvasStateUtils This reverts commit b613c266df48cf45296ecc23d1bd7098c84bb7ba. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4742 Change-Id: Ib25514d6f546c69b6650b5c957403b04f7380dc2 Reviewed-on: https://skia-review.googlesource.com/4742 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
b613c266df48cf45296ecc23d1bd7098c84bb7ba |
|
10-Nov-2016 |
Heather Miller <hcm@google.com> |
Revert "Change SkCanvas to *not* inherit from SkRefCnt" This reverts commit 824075071885b6b741c141cbe2134d8345d34589. Reason for revert: Breaking WebView (chromium:663959) Original change's description: > Change SkCanvas to *not* inherit from SkRefCnt > > Definitely tricky for classes like SkNWayCanvas, where the caller (today) > need not pay attention to ownership of the canvases it gave the NWay > (after this CL, the caller *must* managed ownership) > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4441 > > DOCS_PREVIEW= https://skia.org/?cl=4441 > > Change-Id: Ib1ac07a3cdf0686d78e7aaa4735d45cc90bea081 > Reviewed-on: https://skia-review.googlesource.com/4441 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=djsollen@google.com,mtklein@google.com,halcanary@google.com,robertphillips@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I5e3b3e876b7d2c09833cf841801321033b6b968b Reviewed-on: https://skia-review.googlesource.com/4687 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Heather Miller <hcm@google.com>
/external/skia/include/core/SkCanvas.h
|
824075071885b6b741c141cbe2134d8345d34589 |
|
09-Nov-2016 |
Mike Reed <reed@google.com> |
Change SkCanvas to *not* inherit from SkRefCnt Definitely tricky for classes like SkNWayCanvas, where the caller (today) need not pay attention to ownership of the canvases it gave the NWay (after this CL, the caller *must* managed ownership) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4441 DOCS_PREVIEW= https://skia.org/?cl=4441 Change-Id: Ib1ac07a3cdf0686d78e7aaa4735d45cc90bea081 Reviewed-on: https://skia-review.googlesource.com/4441 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
faba3715b8ddfaa0ce4df79bc8006e9bc7694e5b |
|
03-Nov-2016 |
Mike Reed <reed@google.com> |
remove unused code around SK_SUPPORT_LEGACY_XFERMODE_PARAM BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4384 Change-Id: I5121acd027d935ade169ff65941f29f654a47bd0 Reviewed-on: https://skia-review.googlesource.com/4384 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
09d9435835f48b06954904f16d14c1c2eeaaad2e |
|
31-Oct-2016 |
Mike Reed <reed@google.com> |
remove lots of legacy flags BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4209 Change-Id: I49ae36a9b2bb51a6470638d3264923ff4a4dea0a Reviewed-on: https://skia-review.googlesource.com/4209 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
7d954ad797176afedb9262fdea4507d0fc60eb9d |
|
28-Oct-2016 |
Mike Reed <reed@google.com> |
remove xfermode from public api BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4020 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Change-Id: I19cd056f2af778f10e8c6c2b7b2735593b43dbac Reviewed-on: https://skia-review.googlesource.com/4020 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
1105224f9701e57ec5ce0354d6a380b664f5c638 |
|
27-Oct-2016 |
Brian Osman <brianosman@google.com> |
Rename GrDrawContext to GrRenderTargetContext This is in preparation for GrTextureContext and GrSurfaceContext BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4030 Change-Id: Ie58c93052e68f3f1f5fe8d15d63760de274a6fbd Reviewed-on: https://skia-review.googlesource.com/4030 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkCanvas.h
|
6bd5284415bd983b0628c4941dff5def40018f5a |
|
27-Oct-2016 |
bungeman <bungeman@google.com> |
Remove SkAutoTUnref and SkAutoTDelete from public includes. This also makes the required changed to src, tests, and tools. The few public APIs modified by this change appear to be unused outside of Skia. Removing these from the public API makes it easier to ensure users are no longer using them. This also updates GrGpu::wrapBackendXXX and the ::onWrapBackendXXX methods to clarify ownership. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2448593002 Review-Url: https://codereview.chromium.org/2448593002
/external/skia/include/core/SkCanvas.h
|
ee677f7afbbdcd5cbb73ff57efdee674b9a5a8c6 |
|
21-Oct-2016 |
Mike Reed <reed@google.com> |
use conservative-clip-bit in pipecanvas BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3821 Change-Id: I18bbcf0fa715c8136355812997766b0f7d8412b6 Reviewed-on: https://skia-review.googlesource.com/3821 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
1356978f15a4dc36928353a6fca4cbd6c40abce5 |
|
06-Oct-2016 |
Herb Derby <herb@google.com> |
Fix SkDeferredCanvas for use on android. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3030 Change-Id: Ie55023257736a12360a233d01096462ba2eb3e74 Reviewed-on: https://skia-review.googlesource.com/3030 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
374772bd61951f01bf84fe17bf53d8867681c9ae |
|
06-Oct-2016 |
reed <reed@google.com> |
Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit c245574ba3d0e2ade6c94b2812de3baa383bf4c4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2396953002 TBR= Review-Url: https://codereview.chromium.org/2396953002
/external/skia/include/core/SkCanvas.h
|
c245574ba3d0e2ade6c94b2812de3baa383bf4c4 |
|
05-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[7] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8. Reason for revert: new assert from 100K bot Original change's description: > Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints" > > - perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter > This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992 > > Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8 > Reviewed-on: https://skia-review.googlesource.com/2992 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I848e5a69c5cd67f2c14889f4f0a346652578c4ff Reviewed-on: https://skia-review.googlesource.com/3023 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
2b2fc7db4f8a4a4d4a51d7eb4df6aa62e309928d |
|
05-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints" - perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992 Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8 Reviewed-on: https://skia-review.googlesource.com/2992 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
3ed485f4249e17abb4b11f5018d03175fd1afb44 |
|
04-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[5] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit I0fa5c58af428f3da8565465d1219a34ef8417d9a. Reason for revert: failing to deserialize some of the 100K Original change's description: > Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints" > > This reverts commit 2cbcd12281ee807214df094964c584c78932e10b. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924 > > Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a > Reviewed-on: https://skia-review.googlesource.com/2924 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I1805a57eef5ebcac203da5989c8539345ecf806f Reviewed-on: https://skia-review.googlesource.com/2962 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
1834242ec6e3cd62669227d394bc79e1cd66dcfb |
|
04-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit 2cbcd12281ee807214df094964c584c78932e10b. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924 Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a Reviewed-on: https://skia-review.googlesource.com/2924 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
2cbcd12281ee807214df094964c584c78932e10b |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
Revert "Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints""" This reverts commit I86875511a13497112827cbaed1dbd7639e9e3d10. legacy (100K) skp failure Original change's description: > Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints"" > > This reverts commit ce02e7175872abde3721df9e5d3ec0ab8384cd8e. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878 > > Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10 > Reviewed-on: https://skia-review.googlesource.com/2878 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=msarett@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ife6f0cf3a22b3e8cf885a188f7f44e1ff62e06a5 Reviewed-on: https://skia-review.googlesource.com/2881 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
70cdb396eb5ffbbed128b902532e9292b5ec0e9d |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints"" This reverts commit ce02e7175872abde3721df9e5d3ec0ab8384cd8e. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878 Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10 Reviewed-on: https://skia-review.googlesource.com/2878 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
ce02e7175872abde3721df9e5d3ec0ab8384cd8e |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
Revert "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit I4fb489ba6b3f77b458f7e4a99f79c7ad10859135. Reason for revert: <INSERT REASONING HERE> Original change's description: > replace SkXfermode obj with SkBlendMode enum in paints > > BUG=skia:5814 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714 > > Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135 > Reviewed-on: https://skia-review.googlesource.com/2714 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=bsalomon@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I3e43f79ef5c1709929663fe63cc1f67cd78270b7 Reviewed-on: https://skia-review.googlesource.com/2871 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
0591897548c8fcb7d53cc94053e01702e58f1ac5 |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
replace SkXfermode obj with SkBlendMode enum in paints BUG=skia:5814 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714 Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135 Reviewed-on: https://skia-review.googlesource.com/2714 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkCanvas.h
|
71df2d7bc1bbc83ad4cf005f9027df4cb3b88a9b |
|
30-Sep-2016 |
msarett <msarett@google.com> |
Add a src rect to drawImageLattice() API This will allow us to draw ninepatches directly from an asset texture without having to upload them individually. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382893002 Review-Url: https://codereview.chromium.org/2382893002
/external/skia/include/core/SkCanvas.h
|
872b4c8cef7cfa67fa7a95be15f279d07cc06ff6 |
|
29-Sep-2016 |
bsalomon <bsalomon@google.com> |
Remove soft clip bool from SkCanvas GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2380163002 Review-Url: https://codereview.chromium.org/2380163002
/external/skia/include/core/SkCanvas.h
|
669983856d99b9312be3166b7dd1f8483a90c315 |
|
21-Sep-2016 |
reed <reed@google.com> |
allow clip calls w/o op param, remove unnecessary kReplace ops BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357333002 Review-Url: https://codereview.chromium.org/2357333002
/external/skia/include/core/SkCanvas.h
|
73603f3c52ffd89fe9d035be827b566a0e7d3b79 |
|
20-Sep-2016 |
reed <reed@google.com> |
abstract name of clipping ops, to transtion to a more restricted set SkRegion::Op --> SkCanvas::ClipOp (alias) --> SkClipOp pre-CL needed in chrome : https://codereview.chromium.org/2355583002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355483002 Review-Url: https://codereview.chromium.org/2355483002
/external/skia/include/core/SkCanvas.h
|
0764efe6a9ae65ad83992f614f57ca9db5b1f191 |
|
02-Sep-2016 |
msarett <msarett@google.com> |
Add option to skip rects to drawImageLattice() HWUI skips transparent rects when drawing. When skia draws using bilerp, we will blend transparent rects with neighboring rects and might draw a bit of a smudge. This CL adds the option to skip rects, allowing us to have compatible behavior with the framework. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002 Review-Url: https://codereview.chromium.org/2305433002
/external/skia/include/core/SkCanvas.h
|
dca352e2d42cfe698573947b3d11abc1eaade160 |
|
26-Aug-2016 |
msarett <msarett@google.com> |
drawRegion() cleanups (1) Move implementation to the cpp. (2) Check for the isRect() case. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286693002 Review-Url: https://codereview.chromium.org/2286693002
/external/skia/include/core/SkCanvas.h
|
cc319b95a58ae15e88c3c028b8726e7cab9121ff |
|
26-Aug-2016 |
msarett <msarett@google.com> |
GPU implementation of drawRegion() Nexus 6P drawregion Bench Performance Before 48.0ms After 3.57ms BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267273006 Review-Url: https://codereview.chromium.org/2267273006
/external/skia/include/core/SkCanvas.h
|
44df651ebefc284acc2f66425dff3ea0b0e14b36 |
|
25-Aug-2016 |
msarett <msarett@google.com> |
Add drawRegion() API to SkCanvas This will allow us to optimize for the RectGrid macrobench. Currently, SkiaGL is much slower than OpenGL. SkiaGL 12 items/s OpenGL 160 items/s This contains everything except for the fast implementation on GPU. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277053002 Review-Url: https://codereview.chromium.org/2277053002
/external/skia/include/core/SkCanvas.h
|
21af9ca1b1f54d9ba1de055aa8475928d5c8ecdf |
|
25-Aug-2016 |
bsalomon <bsalomon@google.com> |
Respecify SkCanvas::drawArc, consolidate conversion to SkPath, add GM for oddball drawArcs Allows the arc to wind more than 360 degrees when useCenter is true, specs that nothing draws if the oval is empty or the sweep angle is 0. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281653002 Review-Url: https://codereview.chromium.org/2281653002
/external/skia/include/core/SkCanvas.h
|
e6f5d5623160a69e1585f5121a3695092327dfe0 |
|
25-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Made shadows blurry (thru implementing variance mapping) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2224163005 Review-Url: https://codereview.chromium.org/2224163005
/external/skia/include/core/SkCanvas.h
|
ac3aa245acc7b469aa2f0d0078e53401d78ac8b9 |
|
19-Aug-2016 |
bsalomon <bsalomon@google.com> |
Plumb drawArc to SkDevice. Plumbs the drawArc canvas method down to SkDevice without converting to a path. Plumbs through the various recording canvas classes. BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257023003 Review-Url: https://codereview.chromium.org/2257023003
/external/skia/include/core/SkCanvas.h
|
cbdf007bc2eb85056a1a5c75c088202becba2d16 |
|
19-Aug-2016 |
mtklein <mtklein@chromium.org> |
Fast path translate() in SkCanvas and SkLiteDL. This adds didTranslate() so that SkLiteDL (and other canvas recorders) can record the translate rather than the full concat. It also adds a case to SkMatrix::preTranslate() to fast path translate x translate -> translate (i.e. +=). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002 Committed: https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c Misc bots failing in pictureimagefilter replay modes. https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout Problem is FMA vs. not. CQ_INCLUDE_TRYBOTS=master.client.skia: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot Review-Url: https://codereview.chromium.org/2255283002
/external/skia/include/core/SkCanvas.h
|
954df2fe9f4f66655c99af08b108cb582c402c5d |
|
19-Aug-2016 |
mtklein <mtklein@google.com> |
Revert of Fast path translate() in SkCanvas and SkLiteDL. (patchset #5 id:80001 of https://codereview.chromium.org/2255283002/ ) Reason for revert: speculative Original issue's description: > Fast path translate() in SkCanvas and SkLiteDL. > > This adds didTranslate() so that SkLiteDL (and other canvas recorders) > can record the translate rather than the full concat. > > It also adds a case to SkMatrix::preTranslate() to fast path > translate x translate -> translate (i.e. +=). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002 > > Committed: https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c TBR=herb@google.com,reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2264433002
/external/skia/include/core/SkCanvas.h
|
5fa47f4fd13b3158de4599414c86d17649c2dd1c |
|
19-Aug-2016 |
mtklein <mtklein@chromium.org> |
Fast path translate() in SkCanvas and SkLiteDL. This adds didTranslate() so that SkLiteDL (and other canvas recorders) can record the translate rather than the full concat. It also adds a case to SkMatrix::preTranslate() to fast path translate x translate -> translate (i.e. +=). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002 Review-Url: https://codereview.chromium.org/2255283002
/external/skia/include/core/SkCanvas.h
|
9637ea91b88ff8f8e95325bfc41417ffc4d5ee0b |
|
18-Aug-2016 |
msarett <msarett@google.com> |
Fix initialization bug for fConservativeIsScaleTranslate Also don't mark it as conservative, we expect it to be correct all the time. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261573002 Review-Url: https://codereview.chromium.org/2261573002
/external/skia/include/core/SkCanvas.h
|
3aafe111b6cc388400092851cc53bbbdfcb8a81c |
|
18-Aug-2016 |
reed <reed@google.com> |
make LayerIter private, and remove skipClip option BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257203002 Review-Url: https://codereview.chromium.org/2257203002
/external/skia/include/core/SkCanvas.h
|
168820625c35a8c19f66c661efcbce7a5e334837 |
|
16-Aug-2016 |
msarett <msarett@google.com> |
Add onDrawBitmapLattice(), avoid unnecessary bitmap->image copy out/Release/nanobench --match Lattice --config gpu --ms 3000 3.42ms -> 17.2us For reference, a loop over drawBitmapRects (which is what Android currently does) is about 13us. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205273003 Review-Url: https://codereview.chromium.org/2205273003
/external/skia/include/core/SkCanvas.h
|
fbfa25802709139c2f14e304319c9541da65ca27 |
|
12-Aug-2016 |
msarett <msarett@google.com> |
Optimized implementation of quickReject() Impl Overview (1) Keep the device clip bounds up to date. This requires minimal additional work in a few places throughout canvas. (2) Keep track of if the ctm isScaleTranslate. Yes, there's a function that does this, but it's slow to call. (3) Perform the src->device transform in quick reject, then check intersection/nan. Other Notes: (1) NaN and intersection checks are performed simultaneously. (2) We no longer quick reject infinity. (3) Affine and perspective are both handled in the slow case. (4) SkRasterClip::isEmpty() is handled by the intersection check. Performance on Nexus 6P: 93.2ms -> 59.8ms Overall Android Jank Tests Performance Impact: Should gain us a ms or two on some tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225393002 Committed: https://skia.googlesource.com/skia/+/d22a817ff57986407facd16af36320fc86ce02da Review-Url: https://codereview.chromium.org/2225393002
/external/skia/include/core/SkCanvas.h
|
5aeb2fa25384b9d3202a1e8c6cd6832038419fe6 |
|
12-Aug-2016 |
mtklein <mtklein@google.com> |
Revert of Optimized implementation of quickReject() (patchset #12 id:260001 of https://codereview.chromium.org/2225393002/ ) Reason for revert: New assert triggering in the Chrome roll, https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/208750/steps/webkit_unit_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/FrameThrottlingTest.SynchronousLayoutInAnimationFrameCallback and breaks the SKNX_NO_SIMD bot, https://codereview.chromium.org/2236363004 Original issue's description: > Optimized implementation of quickReject() > > Impl Overview > (1) Keep the device clip bounds up to date. This > requires minimal additional work in a few places > throughout canvas. > (2) Keep track of if the ctm isScaleTranslate. Yes, > there's a function that does this, but it's slow > to call. > (3) Perform the src->device transform in quick reject, > then check intersection/nan. > > Other Notes: > (1) NaN and intersection checks are performed > simultaneously. > (2) We no longer quick reject infinity. > (3) Affine and perspective are both handled in the slow > case. > (4) SkRasterClip::isEmpty() is handled by the intersection > check. > > Performance on Nexus 6P: > 93.2ms -> 59.8ms > > Overall Android Jank Tests Performance Impact: > Should gain us a ms or two on some tests. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225393002 > > Committed: https://skia.googlesource.com/skia/+/d22a817ff57986407facd16af36320fc86ce02da TBR=reed@google.com,herb@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2231393003
/external/skia/include/core/SkCanvas.h
|
d22a817ff57986407facd16af36320fc86ce02da |
|
11-Aug-2016 |
msarett <msarett@google.com> |
Optimized implementation of quickReject() Impl Overview (1) Keep the device clip bounds up to date. This requires minimal additional work in a few places throughout canvas. (2) Keep track of if the ctm isScaleTranslate. Yes, there's a function that does this, but it's slow to call. (3) Perform the src->device transform in quick reject, then check intersection/nan. Other Notes: (1) NaN and intersection checks are performed simultaneously. (2) We no longer quick reject infinity. (3) Affine and perspective are both handled in the slow case. (4) SkRasterClip::isEmpty() is handled by the intersection check. Performance on Nexus 6P: 93.2ms -> 59.8ms Overall Android Jank Tests Performance Impact: Should gain us a ms or two on some tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225393002 Review-Url: https://codereview.chromium.org/2225393002
/external/skia/include/core/SkCanvas.h
|
6372e6590924c459d88fa1fae52ff996a56ee9ab |
|
11-Aug-2016 |
msarett <msarett@google.com> |
Delete quickRejectY() This is the first step in a refactor of quickReject(). TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241473002 Review-Url: https://codereview.chromium.org/2241473002
/external/skia/include/core/SkCanvas.h
|
2ab9057b31ee92060b9769ea1adfada51c11c010 |
|
10-Aug-2016 |
reed <reed@google.com> |
update textblob api to use sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2236013002 NOTREECHECKS=True Review-Url: https://codereview.chromium.org/2236013002
/external/skia/include/core/SkCanvas.h
|
9c5052f16b249d2b7674ea86bd24ed0038ccc61f |
|
06-Aug-2016 |
mtklein <mtklein@chromium.org> |
SkLite* SkLiteRecorder, a new SkCanvas, fills out SkLiteDL, a new SkDrawable. This SkDrawable is a display list similar to SkRecord and SkBigPicture / SkRecordedDrawable, but with a few new design points inspired by Android and slimming paint: 1) SkLiteDL is structured as one big contiguous array rather than the two layer structure of SkRecord. This trades away flexibility and large-op-count performance for better data locality for small to medium size pictures. 2) We keep a global freelist of SkLiteDLs, both reusing the SkLiteDL struct itself and its contiguous byte array. This keeps the expected number of mallocs per display list allocation <1 (really, ~0) for cyclical use cases. These two together mean recording is faster. Measuring against the code we use at head, SkLiteRecorder trends about ~3x faster across various size pictures, matching speed at 0 draws and beating the special-case 1-draw pictures we have today. (I.e. we won't need those special case implementations anymore, because they're slower than this new generic code.) This new strategy records 10 drawRects() in about the same time the old strategy took for 2. This strategy stays the winner until at least 500 drawRect()s on my laptop, where I stopped checking. A simpler alternative to freelisting is also possible (but not implemented here), where we allow the client to manually reset() an SkLiteDL for reuse when its refcnt is 1. That's essentially what we're doing with the freelist, except tracking what's available for reuse globally instead of making the client do it. This code is not fully capable yet, but most of the key design points are there. The internal structure of SkLiteDL is the area I expect to be most volatile (anything involving Op), but its interface and the whole of SkLiteRecorder ought to be just about done. You can run nanobench --match picture_overhead as a demo. Everything it exercises is fully fleshed out, so what it tests is an apples-to-apples comparison as far as recording costs go. I have not yet compared playback performance. It should be simple to wrap this into an SkPicture subclass if we want. I won't start proposing we replace anything old with anything new quite yet until I have more ducks in a row, but this does look pretty promising (similar to the SkRecord over old SkPicture change a couple years ago) and I'd like to land, experiment, iterate, especially with an eye toward Android. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213333002 Review-Url: https://codereview.chromium.org/2213333002
/external/skia/include/core/SkCanvas.h
|
c573a40ed5024b463e47088d307e3164a486dba5 |
|
02-Aug-2016 |
msarett <msarett@google.com> |
Add drawImageLattice() and drawBitmapLattice() APIs The specified image/bitmap is divided into rects, which can be draw stretched, shrunk, or at a fixed size. Will be used by Android to draw 9patch (which are acutally N-patch) images. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1992283002 Review-Url: https://codereview.chromium.org/1992283002
/external/skia/include/core/SkCanvas.h
|
5bfee98c8cf59db8d71aa6672088b107f0abf8c9 |
|
22-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Creating framework for drawShadowedPicture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003 Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a Committed: https://skia.googlesource.com/skia/+/95302da19d8b0a3bcd9d9be0e79f486760787f09 Review-Url: https://codereview.chromium.org/2146073003
/external/skia/include/core/SkCanvas.h
|
95302da19d8b0a3bcd9d9be0e79f486760787f09 |
|
21-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Creating framework for drawShadowedPicture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003 Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a Review-Url: https://codereview.chromium.org/2146073003
/external/skia/include/core/SkCanvas.h
|
33d325890e549c113a258248002246b46e8040b2 |
|
21-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/2146073003/ ) Reason for revert: Decided to re-wait for a final LGTM. Already found a bug in variable naming to fix. Original issue's description: > Creating framework for drawShadowedPicture > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003 > > Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a TBR=reed@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2167223002
/external/skia/include/core/SkCanvas.h
|
0ae097d116f4332be02a135ffc99c162473dee6a |
|
21-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Creating framework for drawShadowedPicture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003 Review-Url: https://codereview.chromium.org/2146073003
/external/skia/include/core/SkCanvas.h
|
a2217ef965e57fdbbf989989e7ec1f2c04f62d39 |
|
20-Jul-2016 |
reed <reed@google.com> |
use special-image for imagefilters and save/restore layer add special virtuals to device, in preparation for using them instead of bitmap for imagefilters BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155933002 patch from issue 2155933002 at patchset 20001 (http://crrev.com/2155933002#ps20001) use specialimages instead of bitmaps for imagefiltering Review-Url: https://codereview.chromium.org/2155063002
/external/skia/include/core/SkCanvas.h
|
7503d60847c4ad22df87458aecd917772b23d293 |
|
15-Jul-2016 |
reed <reed@google.com> |
move responsibility for creating raster-device into pdf BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146333004 NOTRY=True win failure seems unrelated Review-Url: https://codereview.chromium.org/2146333004
/external/skia/include/core/SkCanvas.h
|
e5de130788c8637d2f7df9ddb0241b78e04d5882 |
|
13-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Added the framework for having canvas/recorder/picture record depth_set's. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002 Committed: https://skia.googlesource.com/skia/+/6d3fb898d5f73a82e36f11c712a633c3921ed518 Committed: https://skia.googlesource.com/skia/+/1185d90c785f743364cc9113d7007a59af07470c Review-Url: https://codereview.chromium.org/2127233002
/external/skia/include/core/SkCanvas.h
|
6e998e6137e6b25f047b5c5943f2b02485165e3e |
|
13-Jul-2016 |
mtklein <mtklein@chromium.org> |
Revert "Added the framework for having canvas/recorder/picture record depth_set's." 1-click revert failed again. This reverts commit 1185d90c785f743364cc9113d7007a59af07470c. BUG=skia: TBR= NOTRY=true Review-Url: https://codereview.chromium.org/2147963002
/external/skia/include/core/SkCanvas.h
|
1185d90c785f743364cc9113d7007a59af07470c |
|
13-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Added the framework for having canvas/recorder/picture record depth_set's. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002 Committed: https://skia.googlesource.com/skia/+/6d3fb898d5f73a82e36f11c712a633c3921ed518 Review-Url: https://codereview.chromium.org/2127233002
/external/skia/include/core/SkCanvas.h
|
e504dbc092ec09c056ba3aa72693962a06d3aa4c |
|
13-Jul-2016 |
mtklein <mtklein@chromium.org> |
Revert "Added the framework for having canvas/recorder/picture record depth_set's." 1-click revert failed. This reverts commit 6d3fb898d5f73a82e36f11c712a633c3921ed518. TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2148543002 Review-Url: https://codereview.chromium.org/2148543002
/external/skia/include/core/SkCanvas.h
|
7438bfc0804d021aa92cdd5ea644994a4248f3db |
|
13-Jul-2016 |
bungeman <bungeman@google.com> |
Factor code to rotate a canvas about a point. SkMatrix::scale and ::rotate take a point around which to scale or rotate. Canvas lacks these helpers, so the code to rotate a canvas around a point has been duplicated many times. Factor all of these implementations into SkCanvas::rotate. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142033002 Review-Url: https://codereview.chromium.org/2142033002
/external/skia/include/core/SkCanvas.h
|
6d3fb898d5f73a82e36f11c712a633c3921ed518 |
|
12-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Added the framework for having canvas/recorder/picture record depth_set's. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002 Review-Url: https://codereview.chromium.org/2127233002
/external/skia/include/core/SkCanvas.h
|
ea5a6513c05e3d7261b68c3ef7d42645ee5bfe17 |
|
08-Jul-2016 |
reed <reed@google.com> |
make some canvas utils virtual (for proxy based subclasses) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130973002 Review-Url: https://codereview.chromium.org/2130973002
/external/skia/include/core/SkCanvas.h
|
63f30d90498ca1a48868421b528036f3be30e2ad |
|
08-Jul-2016 |
reed <reed@google.com> |
fix typos and capitalization on drawTextRSXform CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2123923006 Review-Url: https://codereview.chromium.org/2123923006
/external/skia/include/core/SkCanvas.h
|
45561a0b15fe045ba272c328684c3f7ae290785a |
|
07-Jul-2016 |
reed <reed@google.com> |
drawTextRSXform BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004 Review-Url: https://codereview.chromium.org/2130643004
/external/skia/include/core/SkCanvas.h
|
cb3bd18a4b787f6281930dbe49e1c430f28a367c |
|
18-May-2016 |
tomhudson <tomhudson@google.com> |
SkCanvas::adjustToTopLayer() Given a matrix and a clip bounds, offsets them to reflect the difference between device coordinates and global coordinates. Useful when a client wants an OS-specific backing for a canvas. R=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1986383002 Review-Url: https://codereview.chromium.org/1986383002
/external/skia/include/core/SkCanvas.h
|
175dd9b5e3d7d749738dac743d2ac360b5340187 |
|
28-Apr-2016 |
robertphillips <robertphillips@google.com> |
Clean up test drawContext usage The general idea is to provide access to SkGpuDevice's drawContext rather than its GrRenderTarget. That is usually what the testing framework actually wants. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1930623003 Review-Url: https://codereview.chromium.org/1930623003
/external/skia/include/core/SkCanvas.h
|
1e7f5e708e5daeb0c18ae49001c9e3cd5e3b13cb |
|
27-Apr-2016 |
reed <reed@google.com> |
remove 'deprecated' region from SkDraw Most call-sites that used it just took its bounds, so it was trivial to convert them to get the bounds of the RasterClip. Two clients wanted the actual region: 1. layeriter for android 2. pdf Android already only has BW clips, so should be safe. PDF now overrides its clip methods to ensure that all clips are BW. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925693002 Review URL: https://codereview.chromium.org/1925693002
/external/skia/include/core/SkCanvas.h
|
36736a2dae94947e075ac9503d5de7799772a5f7 |
|
23-Apr-2016 |
robertphillips <robertphillips@google.com> |
Remove SkCanvas::LayerIter guard The LayerIter is no longer required by the Bazel build. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917693002 Review URL: https://codereview.chromium.org/1917693002
/external/skia/include/core/SkCanvas.h
|
cb61a6452fbf9b147dc9d3f31bf520efb0e2c7fd |
|
22-Apr-2016 |
robertphillips <robertphillips@google.com> |
Add compile guard for SkCanvas::LayerIter TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911893002 Review URL: https://codereview.chromium.org/1911893002
/external/skia/include/core/SkCanvas.h
|
da2cd8b1d9b9307cb3fbfb28af4139b6dbe31c94 |
|
21-Apr-2016 |
robertphillips <robertphillips@google.com> |
Hide SkCanvas::LayerIter GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897863008 Committed: https://skia.googlesource.com/skia/+/a814000cbb0e90624a410b4359fff7f3ec66f0e0 Review URL: https://codereview.chromium.org/1897863008
/external/skia/include/core/SkCanvas.h
|
a1f4fa72303492e3ce496d9eae529dce6d592026 |
|
21-Apr-2016 |
fmalita <fmalita@google.com> |
Revert of Hide SkCanvas::LayerIter (patchset #2 id:20001 of https://codereview.chromium.org/1897863008/ ) Reason for revert: Das roll ist gebusted: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/214775/steps/compile%20%28with%20patch%29/logs/stdio FAILED: /b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/platform/graphics/paint/blink_platform_unittests.PaintArtifactToSkCanvasTest.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=266460-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DINSIDE_BLINK -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DENABLE_OILPAN=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -Igen/blink -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -Igen/third_party/WebKit -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/harfbuzz-ng/src -I../../third_party/qcms/src -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../v8/include -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -fvisibility=hidden -Werror -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -c ../../third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp -o obj/third_party/WebKit/Source/platform/graphics/paint/blink_platform_unittests.PaintArtifactToSkCanvasTest.o ../../third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp:201:22: error: 'LayerIter' is a protected member of 'SkCanvas' return SkCanvas::LayerIter(canvas, false).clip(); ^ ../../third_party/skia/include/core/SkCanvas.h:1230:18: note: declared protected here class SK_API LayerIter /*: SkNoncopyable*/ { ^ 1 error generated. ninja: build stopped: subcommand failed. Original issue's description: > Hide SkCanvas::LayerIter > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897863008 > > Committed: https://skia.googlesource.com/skia/+/a814000cbb0e90624a410b4359fff7f3ec66f0e0 TBR=reed@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1906573003
/external/skia/include/core/SkCanvas.h
|
8c30a8196dd5903d2d23b4d0a5dc888e802bf698 |
|
21-Apr-2016 |
reed <reed@google.com> |
post apply non-scale transforms after imagefilters have run may choose to eliminate the final matrix-filter buffer before the sprite blit, but at the moment want to defer that change to a 2nd CL. heavily inspired by https://codereview.chromium.org/1140943004 Need these CLs to land first: https://codereview.chromium.org/1898193005/# https://codereview.chromium.org/1902253003/ BUG=skia:3288 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1899263002 Review URL: https://codereview.chromium.org/1899263002
/external/skia/include/core/SkCanvas.h
|
a814000cbb0e90624a410b4359fff7f3ec66f0e0 |
|
21-Apr-2016 |
robertphillips <robertphillips@google.com> |
Hide SkCanvas::LayerIter GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897863008 Review URL: https://codereview.chromium.org/1897863008
/external/skia/include/core/SkCanvas.h
|
898235c4864df66aa7f6d32bc2a8b8551040ce1e |
|
06-Apr-2016 |
brianosman <brianosman@google.com> |
SkSurfaceProps now has a gamma-correct ("AllowSRGBInputs") flag. That's propagated in a few places so that the backend can do the right thing for L32 vs S32 mode. Also added SkSurfaceProps to SkSpecialImage, so that Image -> Surface conversion can preserve the desired behavior during filtering. Many small changes, including a bunch of comments about places where we may be losing information right now. My approach was to ensure that if anything fails, it will always fall back to "legacy" mode - gamma-correctness is opt-in, so I'll just have to feed things through as missing cases are exposed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1838953007 Review URL: https://codereview.chromium.org/1845283003
/external/skia/include/core/SkCanvas.h
|
0fba3b97b5b0e3707b31931ab9325030b81c940f |
|
01-Apr-2016 |
mtklein <mtklein@chromium.org> |
sk_sp for SkCanvas::drawAnnotation() BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849703003 Review URL: https://codereview.chromium.org/1849703003
/external/skia/include/core/SkCanvas.h
|
92d48830852f3e34644561dbbfaf10364836482d |
|
01-Apr-2016 |
mtklein <mtklein@chromium.org> |
fix typo: add missing const TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1848533004 Review URL: https://codereview.chromium.org/1848533004
/external/skia/include/core/SkCanvas.h
|
cfb6bdf767796c950f89985445738d2d8e7f12b0 |
|
29-Mar-2016 |
reed <reed@google.com> |
switch xfermodes over to sk_sp waiting on https://codereview.chromium.org/1835163002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1832223002 Review URL: https://codereview.chromium.org/1832223002
/external/skia/include/core/SkCanvas.h
|
e8597a4dd07d78eb0e7a45d6502896c1b9a8bfeb |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb Committed: https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkCanvas.h
|
910f7ec7e79cd051f69b47c3e19d4fda2adbcef4 |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Revert of Delete SkImageDecoder (patchset #9 id:150001 of https://codereview.chromium.org/1820503002/ ) Reason for revert: Roll still failing Original issue's description: > Delete SkImageDecoder > > This image decoding implementation has been replaced > by SkCodec in Android. > > Additionally, we have replaced uses of SkImageDecoder > in Skia and Google3 with uses of SkCodec. > > Now we can delete SkImageDecoder :). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 > > Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb > > Committed: https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1830943002
/external/skia/include/core/SkCanvas.h
|
f037fdebda2a2626e6512d7532063f2cd41a264d |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkCanvas.h
|
e8f3062a36d3682f4019309a32b5b84dc9eddf8c |
|
24-Mar-2016 |
reed <reed@google.com> |
switch surface to sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1817383002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review URL: https://codereview.chromium.org/1817383002
/external/skia/include/core/SkCanvas.h
|
041c870425eb0a3e2b0cbc46581b3da2f50571d9 |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Revert of Delete SkImageDecoder (patchset #8 id:130001 of https://codereview.chromium.org/1820503002/ ) Reason for revert: Testing the roll - it's still failing Original issue's description: > Delete SkImageDecoder > > This image decoding implementation has been replaced > by SkCodec in Android. > > Additionally, we have replaced uses of SkImageDecoder > in Skia and Google3 with uses of SkCodec. > > Now we can delete SkImageDecoder :). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 > > Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1828433004
/external/skia/include/core/SkCanvas.h
|
5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkCanvas.h
|
39b54951c4e61c137d9911685600490da25470c1 |
|
23-Mar-2016 |
msarett <msarett@google.com> |
Revert of Delete SkImageDecoder (patchset #7 id:110001 of https://codereview.chromium.org/1820503002/ ) Reason for revert: Various problems Original issue's description: > Delete SkImageDecoder > > This image decoding implementation has been replaced > by SkCodec in Android. > > Additionally, we have replaced uses of SkImageDecoder > in Skia and Google3 with uses of SkCodec. > > Now we can delete SkImageDecoder :). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1830723002
/external/skia/include/core/SkCanvas.h
|
f799706656f2581c5bf5510d94df3fa17cce1607 |
|
23-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkCanvas.h
|
ca2622ba051829fed5f30facd74c5b41cd4b931c |
|
18-Mar-2016 |
reed <reed@google.com> |
return pictures as sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1811703002 Review URL: https://codereview.chromium.org/1811703002
/external/skia/include/core/SkCanvas.h
|
f8053da25981c6b3152b637c1c91f43cff194c25 |
|
17-Mar-2016 |
reed <reed@google.com> |
Allow const& for SkImages and SkPictures in draw methods. This is just a convenience for callers, since we are (strongly) encouraging them to use sk_sp<> for managing image objects (and pictures btw). No change under the hood, as we are keeping our agnostic approach to these for the protected virtuals (since often we don't want to ref the parameter). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777403002 Review URL: https://codereview.chromium.org/1777403002
/external/skia/include/core/SkCanvas.h
|
6ceeebd37a43d879c120b6ba100ae1febdd67a18 |
|
09-Mar-2016 |
reed <reed@google.com> |
unify peekPixels around pixmap parameter requires this chrome CL to land first https://codereview.chromium.org/1775393003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784563002 Review URL: https://codereview.chromium.org/1784563002
/external/skia/include/core/SkCanvas.h
|
f70b531daaf47db1ee95c70da9843f1dd1f418d3 |
|
05-Mar-2016 |
reed <reed@google.com> |
Move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ )" Need to land chrome change first https://codereview.chromium.org/1766723003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758023003 TBR= Review URL: https://codereview.chromium.org/1758023003
/external/skia/include/core/SkCanvas.h
|
1610835624a9658cc60940b80038b84f297e836f |
|
03-Mar-2016 |
reed <reed@google.com> |
Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ ) Reason for revert: need to update unittest in blink: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=261368-1 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DENABLE_OILPAN=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DV8_SHARED -DUSING_V8_SHARED -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../../third_party/WebKit/public/web -I../../third_party/WebKit/Source/web -I../../third_party/WebKit/Source/web/src -I../../third_party/WebKit/public/web/mac -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/libwebp -I../../third_party/zlib -I../../v8/include -Igen/blink -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O0 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -fstack-protector-all -c ../../third_party/WebKit/Source/core/page/PrintContextTest.cpp -o obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o ../../third_party/WebKit/Source/core/page/PrintContextTest.cpp:54:20: error: no member named 'getAnnotation' in 'SkPaint' if (!paint.getAnnotation()) ~~~~~ ^ Original issue's description: > move annotations to canvas virtual > > In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002 > > Committed: https://skia.googlesource.com/skia/+/0eda2587cc9233066cb3f3fec08f35c061780f8e TBR=halcanary@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1761793003
/external/skia/include/core/SkCanvas.h
|
0eda2587cc9233066cb3f3fec08f35c061780f8e |
|
03-Mar-2016 |
reed <reed@google.com> |
move annotations to canvas virtual In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002 Review URL: https://codereview.chromium.org/1744103002
/external/skia/include/core/SkCanvas.h
|
952538ed50661ad7dff6ec2b7af3f921e1d91b52 |
|
26-Feb-2016 |
caryclark <caryclark@google.com> |
fix undefined signed shifts The expression (1 << 31) is technically undefined. Fixed the undefined shift referenced by this bug and a few friends. R=reed@google.com BUG=skia:2285 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737363002 Review URL: https://codereview.chromium.org/1737363002
/external/skia/include/core/SkCanvas.h
|
e63ffef6248bd103b5f7827f1e4bc75e47ca9e20 |
|
05-Feb-2016 |
bsalomon <bsalomon@google.com> |
Remove deferred clear from SkGpuDevice Add combining to GrClearBatch Fix issue with state tracking in GrGLGpu::createTestingOnlyBackendTexture Add tests for clearing GPU SkSurfaces and add tests for GrDrawContext::clear(). Add comment that SkCanvas::flush will resolve the RT in the GPU case. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658823002 Review URL: https://codereview.chromium.org/1658823002
/external/skia/include/core/SkCanvas.h
|
afc7cce5d68663934128d76963cd501f771d71de |
|
03-Feb-2016 |
senorblanco <senorblanco@chromium.org> |
Fix for rounded-rect clips with filters. Don't use the base canvas size to limit raster of complex clips, since the top canvas size may actually be larger (e.g., a blur filter which expands the clip bounds to accommodate filter margins). Use the top canvas bounds instead. BUG=skia:4879,471212 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657333002 Review URL: https://codereview.chromium.org/1657333002
/external/skia/include/core/SkCanvas.h
|
54d60293cecb384de5683d9bea925c97f6ed485b |
|
28-Jan-2016 |
fmalita <fmalita@chromium.org> |
SaveFlags begone! This is now dead code (post https://codereview.chromium.org/1636103002). R=reed@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1648773002 Review URL: https://codereview.chromium.org/1648773002
/external/skia/include/core/SkCanvas.h
|
4c5f1f611469b489297b1ce4f5dd0bc54cb5bb88 |
|
28-Jan-2016 |
fmalita <fmalita@chromium.org> |
Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android Android is the only platform still using SK_SUPPORT_LEGACY_SAVEFLAGS (indirectly, due to SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG). At this point it should be safe to remove the define. R=djsollen@google.com,scroggo@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1636103002 Review URL: https://codereview.chromium.org/1636103002
/external/skia/include/core/SkCanvas.h
|
53d9f1cfbd5ddbf57c2f22b9e613ce48e5b2896c |
|
25-Jan-2016 |
fmalita <fmalita@chromium.org> |
SK_SUPPORT_LEGACY_DRAWFLTER typo s/FLTER/FILTER/ R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1634573002 Review URL: https://codereview.chromium.org/1634573002
/external/skia/include/core/SkCanvas.h
|
7765000709dc64eb23be7df47d1f995d1f787115 |
|
22-Jan-2016 |
fmalita <fmalita@chromium.org> |
Hide SkCanvas::{set,get}DrawFilter Except for Android, which still makes use of it. BUG=skia:3587 R=reed@google.com,djsollen@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618843002 Review URL: https://codereview.chromium.org/1618843002
/external/skia/include/core/SkCanvas.h
|
bfd5f171e6a3eccd7c4bede652a85fd76bcbce2a |
|
07-Jan-2016 |
reed <reed@google.com> |
Revert[2] of "add backdrop option to SaveLayerRec" Reverted because of picture/serialization failure BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567063002 TBR=mtklein Review URL: https://codereview.chromium.org/1567063002
/external/skia/include/core/SkCanvas.h
|
0575cb2def2f4dfdad04e0674d0f8eb8e7c24cec |
|
07-Jan-2016 |
reed <reed@google.com> |
Revert of add backdrop option to SaveLayerRec (patchset #14 id:260001 of https://codereview.chromium.org/1523053003/ ) Reason for revert: serialized != direct, will investigate Original issue's description: > add backdrop option to SaveLayerRec > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1523053003 > > Committed: https://skia.googlesource.com/skia/+/247415969a9a5ed6c83cc09395472416c4b7de7f TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1565203002
/external/skia/include/core/SkCanvas.h
|
247415969a9a5ed6c83cc09395472416c4b7de7f |
|
07-Jan-2016 |
reed <reed@google.com> |
add backdrop option to SaveLayerRec BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1523053003 Review URL: https://codereview.chromium.org/1523053003
/external/skia/include/core/SkCanvas.h
|
ffe031e65cda3f52e057dd7aafbc9407c25cbf8d |
|
04-Jan-2016 |
scroggo <scroggo@google.com> |
Add conversion from SaveLayerFlags to SaveFlags Needed for SkiaAndroidProxy::getSaveLayerStrategy. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559873003 Review URL: https://codereview.chromium.org/1559873003
/external/skia/include/core/SkCanvas.h
|
48eb08a790b32a4d39d8bb91983434e25d8b0b4e |
|
25-Dec-2015 |
reed <reed@google.com> |
remove unused SkAutoROCanvasPixels BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1550583002 TBR= Review URL: https://codereview.chromium.org/1550583002
/external/skia/include/core/SkCanvas.h
|
bada1885da479d948f065182d6dfa85a1140bda5 |
|
21-Dec-2015 |
reed <reed@google.com> |
hide old SaveFlags, but keep them available (for now) for Android BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535993003 requires https://codereview.chromium.org/1537203002/# to land in chrome first (android should be safe) Review URL: https://codereview.chromium.org/1535993003
/external/skia/include/core/SkCanvas.h
|
03ef4b16b25248f4545722f649baadf494c232d2 |
|
19-Dec-2015 |
reed <reed@google.com> |
remove SK_SUPPORT_LEGACY_SAVELAYERPARAMS code BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1537193002 TBR= Review URL: https://codereview.chromium.org/1537193002
/external/skia/include/core/SkCanvas.h
|
4960eeec4a1f2a772654883d7f3615d47bcd5dc3 |
|
18-Dec-2015 |
reed <reed@google.com> |
change signature for virtual related to saveLayer, passing SaveLayerRec BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1533953002 NOTREECHECKS=True Review URL: https://codereview.chromium.org/1533953002
/external/skia/include/core/SkCanvas.h
|
96205ddedcd477ae737fb3ad9a8987fbb62f4b30 |
|
16-Dec-2015 |
reed <reed@google.com> |
remove obsolete ondrawsprite base virtual BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1529283003 TBR= Review URL: https://codereview.chromium.org/1529283003
/external/skia/include/core/SkCanvas.h
|
da420b976e61071cfe5de10556b4b23e519091d6 |
|
16-Dec-2015 |
reed <reed@google.com> |
Reland of move drawSprite from canvas (patchset #1 id:1 of https://codereview.chromium.org/1529803004/ ) Reason for revert: guard has landed in chrome Original issue's description: > Revert of remove drawSprite from canvas (patchset #4 id:60001 of https://codereview.chromium.org/1534443003/ ) > > Reason for revert: > need to remove an override in chrome > > Original issue's description: > > remove drawSprite from canvas > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/4657ce2324ea197507c4ba728d81138f56da13b1 > > TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/32704674f64cb6a14356dfebe060cd3484c06cc7 TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1530203002
/external/skia/include/core/SkCanvas.h
|
32704674f64cb6a14356dfebe060cd3484c06cc7 |
|
16-Dec-2015 |
reed <reed@google.com> |
Revert of remove drawSprite from canvas (patchset #4 id:60001 of https://codereview.chromium.org/1534443003/ ) Reason for revert: need to remove an override in chrome Original issue's description: > remove drawSprite from canvas > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4657ce2324ea197507c4ba728d81138f56da13b1 TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1529803004
/external/skia/include/core/SkCanvas.h
|
4657ce2324ea197507c4ba728d81138f56da13b1 |
|
16-Dec-2015 |
reed <reed@google.com> |
remove drawSprite from canvas BUG=skia: Review URL: https://codereview.chromium.org/1534443003
/external/skia/include/core/SkCanvas.h
|
a1bb8e02fe7956b2f85a0afadbca5f607a804403 |
|
11-Dec-2015 |
benjaminwagner <benjaminwagner@google.com> |
In SkPixmap.cpp, change SkAlphaMul to SkMulDiv255. Add a test that we get the same color back after calling SkBitmap::eraseColor, modulo rounding. Also update some incorrect docs. BUG=skia:4297 Review URL: https://codereview.chromium.org/1521673002
/external/skia/include/core/SkCanvas.h
|
70ee31b2fa127eee6c0cea61cf05508e9d3ca7b1 |
|
10-Dec-2015 |
reed <reed@google.com> |
try adding flag to allow lcd text even in a layer BUG=skia: Review URL: https://codereview.chromium.org/1513513002
/external/skia/include/core/SkCanvas.h
|
262a71b7f95ce98ff3dd8dba845afbd724470903 |
|
05-Dec-2015 |
reed <reed@google.com> |
detect when we can filter bitmaps/images directly, w/o a tmp layer visual bench run on Mac Pro curr/maxrss loops min median mean max stddev samples config bench 100/100 MB 16 412µs 413µs 413µs 414µs 0% ▄▁▇▄▄▄▄█▄▃▅ gpu warmupbench 101/102 MB 32 547µs 548µs 611µs 1.24ms 34% █▁▁▁▁▁▁▁▁▁▁ gpu image-filter-sprite-draw-image 102/103 MB 32 547µs 548µs 721µs 1.23ms 41% █▁▇▁▁█▁▁▁▁▁ gpu image-filter-sprite-draw-bitmap 103/103 MB 64 546µs 546µs 546µs 547µs 0% ▆▄▂▁▇█▅▇▅▇▃ gpu image-filter-sprite-draw-sprite Should have no effect on Chrome while SK_SUPPORT_LEGACY_LAYER_BITMAP_IMAGEFILTERS is defined (which it is in chrome) BUG=skia:1073 Review URL: https://codereview.chromium.org/1491293002
/external/skia/include/core/SkCanvas.h
|
42b73eb00367c8315974b1c374308d20efa78897 |
|
20-Nov-2015 |
reed <reed@google.com> |
enable conservative raster clipping There may be other (better?) ways to enable this. For example, if we queried the device *before* we init our root DeviceCM, we wouldn't need this flag in InitFlags, since the device already has a virtual to opt-in ... BUG=skia: Review URL: https://codereview.chromium.org/1458153003
/external/skia/include/core/SkCanvas.h
|
31b80a9dc60ae5411ad6abd10269c4f88c635ec2 |
|
16-Nov-2015 |
reed <reed@google.com> |
increase pre-allocated MCRecs to match common android calling pattern BUG=skia: Review URL: https://codereview.chromium.org/1450093002
/external/skia/include/core/SkCanvas.h
|
19e82e3b9f6fb5a02fc033121f2047b4d886112e |
|
23-Oct-2015 |
bsalomon <bsalomon@google.com> |
Update SrcRectConstraint doc. Previous doc never matched the implementation or the c2d spec. Review URL: https://codereview.chromium.org/1411103003
/external/skia/include/core/SkCanvas.h
|
33366974d43eae80e22284a2e445225c343859da |
|
08-Oct-2015 |
reed <reed@google.com> |
remove internalDrawBitmap, as it is no longer shared with any other caller, and can be folded into onDrawBitmap BUG=skia: Review URL: https://codereview.chromium.org/1391333004
/external/skia/include/core/SkCanvas.h
|
451af5062e6bf9c665126d84516e0baafa27ecc4 |
|
19-Aug-2015 |
reed <reed@google.com> |
remove SkDeferredCanvas Waiting a day or so to see if the blink-removal of SkDeferredCanvas sticks BUG=skia: Review URL: https://codereview.chromium.org/1269093002
/external/skia/include/core/SkCanvas.h
|
021f631dc66da06dbe4aed21df2f27daecce9db7 |
|
10-Aug-2015 |
reed <reed@chromium.org> |
api helpers inspired by blink use-cases BUG=skia: TBR= Review URL: https://codereview.chromium.org/1278323002
/external/skia/include/core/SkCanvas.h
|
41838a019401af6e88afc6039f9de76fbca39ff2 |
|
08-Aug-2015 |
reed <reed@chromium.org> |
remove unneeded _DRAWIMAGERECT flags BUG=skia: TBR= Review URL: https://codereview.chromium.org/1281123002
/external/skia/include/core/SkCanvas.h
|
e47829b6b1eeb6b0c97ccb3df3016d197046824c |
|
06-Aug-2015 |
reed <reed@google.com> |
flag to use const& instead of const* for src-rect BUG=skia: Review URL: https://codereview.chromium.org/1272713005
/external/skia/include/core/SkCanvas.h
|
d3ebb48320cf1b7e969974673e4bd7743816985e |
|
05-Aug-2015 |
bungeman <bungeman@google.com> |
IWYU: 'core' target, files starting A-C. TBR=reed@google.com Verbal lgtm, does not change API. Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 Review URL: https://codereview.chromium.org/1265033002
/external/skia/include/core/SkCanvas.h
|
fb8c1fcab19c99b56d2fdcf6234751d6f0465142 |
|
05-Aug-2015 |
reed <reed@chromium.org> |
Revert of IWYU: 'core' target, files starting A-C. (patchset #5 id:80001 of https://codereview.chromium.org/1265033002/ ) Reason for revert: revert to unblock DEPS roll ../../chrome/browser/chromeos/display/overscan_calibrator.cc:43:10: error: variable has incomplete type 'SkPath' SkPath base_path; Original issue's description: > IWYU: 'core' target, files starting A-C. > > TBR=reed@google.com > Verbal lgtm, does not change API. > > Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 TBR=reed@google.com,mtklein@google.com,bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1273613002
/external/skia/include/core/SkCanvas.h
|
7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 |
|
04-Aug-2015 |
bungeman <bungeman@google.com> |
IWYU: 'core' target, files starting A-C. TBR=reed@google.com Verbal lgtm, does not change API. Review URL: https://codereview.chromium.org/1265033002
/external/skia/include/core/SkCanvas.h
|
562fe4767cc73e08a4e039362bc0336aea66ecfb |
|
28-Jul-2015 |
reed <reed@google.com> |
remove all guards for changes to drawBitmapRect / drawImageRect BUG=skia: Review URL: https://codereview.chromium.org/1239193002
/external/skia/include/core/SkCanvas.h
|
84984efeb64787b88c5f8bd6929cfe2d58a3ba06 |
|
17-Jul-2015 |
reed <reed@google.com> |
Revert[2] of guard to remove DrawBitmapRectFlags This reverts commit 91110195a2eee170c11885da9d16f94b00a39f87. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1240753003
/external/skia/include/core/SkCanvas.h
|
91110195a2eee170c11885da9d16f94b00a39f87 |
|
17-Jul-2015 |
scroggo <scroggo@google.com> |
Revert of guard to remove DrawBitmapRectFlags (patchset #1 id:1 of https://codereview.chromium.org/1235393003/) Reason for revert: breaking android framework build Original issue's description: > guard to remove DrawBitmapRectFlags > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d TBR=fmalita@chromium.org,djsollen@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1230823007
/external/skia/include/core/SkCanvas.h
|
c83a29759a5c2966da5ab973e4fd90763e4c962b |
|
16-Jul-2015 |
reed <reed@google.com> |
have canvas send discard instead of retain if the draw would overwrite everything Motivation: - perf win for clients that overwrite the surface after a snapshot. - may allow us to eliminate SkDeferredCanvas, as this was its primary advantage. BUG=skia: Review URL: https://codereview.chromium.org/1236023004
/external/skia/include/core/SkCanvas.h
|
6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d |
|
16-Jul-2015 |
reed <reed@chromium.org> |
guard to remove DrawBitmapRectFlags BUG=skia: Review URL: https://codereview.chromium.org/1235393003
/external/skia/include/core/SkCanvas.h
|
a5517e2b190a8083b38964972b031c13e99f1012 |
|
14-Jul-2015 |
reed <reed@google.com> |
add src-rect-constraint to drawImageRect Follow-on work - unify around SrcRectConstraint (i.e. drawBitmapRect) - remove silly drawBitmapRectToRect alias - clean-up (possibly remove) alias problems around drawBitmapRect + IRect parameter BUG=skia: Review URL: https://codereview.chromium.org/1228083004
/external/skia/include/core/SkCanvas.h
|
a8db72864a43ad1fbba3c2892cf5cd88060a43ef |
|
07-Jul-2015 |
reed <reed@google.com> |
add matrix options to drawDrawable BUG=skia: Review URL: https://codereview.chromium.org/1224783002
/external/skia/include/core/SkCanvas.h
|
2766c00fc0b6a07d46e5f74cdad45da2ef625237 |
|
26-Jun-2015 |
mtklein <mtklein@chromium.org> |
remove SkInstCnt It's been outclassed by Valgrind and leak sanitizer, and it seems to be causing problems for external folks building Skia. I'm not sure why our own builds seem unaffected. Latest thread: https://groups.google.com/forum/#!topic/skia-discuss/oj9FsQwwSF0 BUG=skia: Review URL: https://codereview.chromium.org/1217573002
/external/skia/include/core/SkCanvas.h
|
4c21dc5ddf3b482293ed34eead876d8d61a662c3 |
|
25-Jun-2015 |
reed <reed@google.com> |
add drawImageNine this also exposes nine-patch drawing directly to devices, and creates a shared iterator for unrolling a nine-patch into single rect->rect draws. BUG=skia: Review URL: https://codereview.chromium.org/1211583003
/external/skia/include/core/SkCanvas.h
|
71c3c760a83123ee0b3127b8c65c6394ce541c50 |
|
24-Jun-2015 |
reed <reed@google.com> |
add SkCanvas::drawAtlas BUG=skia: Review URL: https://codereview.chromium.org/1181913003
/external/skia/include/core/SkCanvas.h
|
efbffedd68636e94d4379e84a2585bce80f6fb8f |
|
22-Jun-2015 |
robertphillips <robertphillips@google.com> |
Clean up usage of SkSurfaceProps This CL continues cleaning up Skia's usage of SkSurfaceProps. It: Removes the duplicate SkSurfaceProps object from SkImageFilter::Proxy. Removes a dispreferred ctor from SkCanvas Removes the initForRootLayer entry point from SkDevice (since the root device and the canvas should always have the same pixel geometry now). Review URL: https://codereview.chromium.org/1201983006
/external/skia/include/core/SkCanvas.h
|
fcf7829b67b798aff4c41c4688daa9c7381991e6 |
|
19-Jun-2015 |
robertphillips <robertphillips@google.com> |
remove SkDeviceProperties There is a lot more clean up to do here but this is probably a big enough bite. Review URL: https://codereview.chromium.org/1196683003
/external/skia/include/core/SkCanvas.h
|
109a23d64ff9cf210e6b0aa8940b4fcea3f05a97 |
|
15-Jun-2015 |
fmalita <fmalita@chromium.org> |
Remove the SkCanvas comment API No longer used in Chromium/Blink. R=reed@google.com,robertphillips@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1153593003
/external/skia/include/core/SkCanvas.h
|
41e010cb901c0da9066c4df562030808c9ccd7f8 |
|
09-Jun-2015 |
reed <reed@google.com> |
Revert[2] SkDraw and all Blitters to use pixmap instead of bitmapi This reverts commit b3f0ec9f9967da2f80f0d842cb7fd53617b48de3. BUG=skia: Review URL: https://codereview.chromium.org/1168303006
/external/skia/include/core/SkCanvas.h
|
884e97cb04db7ed053a866567ee9c6e4c01f993a |
|
26-May-2015 |
reed <reed@google.com> |
change internals over to SkPixmap and stop using accessBitmap BUG=skia: Review URL: https://codereview.chromium.org/1155443004
/external/skia/include/core/SkCanvas.h
|
86a17e7716c8db858e219a46b9db3817bb770bee |
|
14-May-2015 |
reed <reed@google.com> |
Revert of Implement support for non-scale/translate CTM in image filters. (patchset #4 id:60001 of https://codereview.chromium.org/1140943004/) Reason for revert: matriximagefilter needs to antialias its draw, so we get smooth diagonals... Original issue's description: > Implement support for non-scale/translate CTM in image filters. > > Clone with tweaks of https://codereview.chromium.org/986623003/ > > pre-cl to guard chrome here: https://codereview.chromium.org/1133403003/ > > BUG=skia:3288 > > Committed: https://skia.googlesource.com/skia/+/35786b176c159d2e7a816e9da9b051ef3129d5cb TBR=robertphillips@google.com,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3288 Review URL: https://codereview.chromium.org/1139173002
/external/skia/include/core/SkCanvas.h
|
35786b176c159d2e7a816e9da9b051ef3129d5cb |
|
14-May-2015 |
reed <reed@google.com> |
Implement support for non-scale/translate CTM in image filters. Clone with tweaks of https://codereview.chromium.org/986623003/ pre-cl to guard chrome here: https://codereview.chromium.org/1133403003/ BUG=skia:3288 Review URL: https://codereview.chromium.org/1140943004
/external/skia/include/core/SkCanvas.h
|
177cb8498662600e9866e260d52d6a2401ad78a8 |
|
13-May-2015 |
reed <reed@google.com> |
Revert of Implement support for non-scale/translate CTM in image filters. (patchset #4 id:60001 of https://codereview.chromium.org/1120043002/) Reason for revert: don't reference layer after its deleted Original issue's description: > Implement support for non-scale/translate CTM in image filters. > > Implemented by extracting out the non-scale/translate components > and applying that post-filter as an SkMatrixImageFilter. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4f12b8bd2cb43daeffa4d1c53120ae94c5ccf486 TBR=robertphillips@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1128133005
/external/skia/include/core/SkCanvas.h
|
4f12b8bd2cb43daeffa4d1c53120ae94c5ccf486 |
|
13-May-2015 |
reed <reed@google.com> |
Implement support for non-scale/translate CTM in image filters. Implemented by extracting out the non-scale/translate components and applying that post-filter as an SkMatrixImageFilter. BUG=skia: Review URL: https://codereview.chromium.org/1120043002
/external/skia/include/core/SkCanvas.h
|
a499f905e9340e4935447f2562fd92e8853382b1 |
|
01-May-2015 |
reed <reed@google.com> |
clean up pre-storage in canvas BUG=skia: TBR= Review URL: https://codereview.chromium.org/1117213003
/external/skia/include/core/SkCanvas.h
|
1c2c441fede0ae9573afc098017011e3439624a9 |
|
30-Apr-2015 |
reed <reed@google.com> |
add heuristic to pour small pictures into recordings, rather than ref'ing BUG=skia: Review URL: https://codereview.chromium.org/1118693003
/external/skia/include/core/SkCanvas.h
|
61f501f8c675da8d5915e5e7fd32dfdb113f1cfb |
|
29-Apr-2015 |
reed <reed@google.com> |
onCreateDevice -> NULL now means the caller should create its own (bitmap) device BUG=skia: Review URL: https://codereview.chromium.org/1116453002
/external/skia/include/core/SkCanvas.h
|
feaadee1c38e1d4e1ec0069a3509ef6fbc5fbeff |
|
08-Apr-2015 |
mtklein <mtklein@chromium.org> |
SkCanvas::resetForNextPicture() No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu. picture_overhead_draw 1.62us -> 1.6us 0.99x picture_overhead_nodraw 792ns -> 342ns 0.43x tiles and serialization modes will also test this a bit. BUG=chromium:470553 Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d Review URL: https://codereview.chromium.org/1067893002
/external/skia/include/core/SkCanvas.h
|
c654e9016a15985ebeb24f94f819d113ad48a251 |
|
08-Apr-2015 |
mtklein <mtklein@google.com> |
Revert of SkCanvas::resetForNextPicture() (patchset #4 id:60001 of https://codereview.chromium.org/1067893002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1816 Original issue's description: > SkCanvas::resetForNextPicture() > > No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu. > > picture_overhead_draw 1.62us -> 1.6us 0.99x > picture_overhead_nodraw 792ns -> 342ns 0.43x > > tiles and serialization modes will also test this a bit. > > BUG=chromium:470553 > > Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470553 Review URL: https://codereview.chromium.org/1062353002
/external/skia/include/core/SkCanvas.h
|
f920e468ac66a36c9653d1b11181480295044c7d |
|
07-Apr-2015 |
mtklein <mtklein@chromium.org> |
SkCanvas::resetForNextPicture() No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu. picture_overhead_draw 1.62us -> 1.6us 0.99x picture_overhead_nodraw 792ns -> 342ns 0.43x tiles and serialization modes will also test this a bit. BUG=chromium:470553 Review URL: https://codereview.chromium.org/1067893002
/external/skia/include/core/SkCanvas.h
|
687fa1c745febb57f42b0d5f03d7c1f4be2530ca |
|
07-Apr-2015 |
reed <reed@google.com> |
restore clipstack to heap-ptr, so clients can ref it BUG=skia: Review URL: https://codereview.chromium.org/1068883004
/external/skia/include/core/SkCanvas.h
|
b679ca8926a832274b14fdb512f88f64b61d32ea |
|
07-Apr-2015 |
reed <reed@chromium.org> |
reduce alloc overhead for SkCanvas use pre-allocated space in the canvas to avoid initial calls to malloc BUG=skia: Review URL: https://codereview.chromium.org/1060583007
/external/skia/include/core/SkCanvas.h
|
68260fa1e913cb1f1f4f07755acd11357a47dc6f |
|
23-Mar-2015 |
tomhudson <tomhudson@google.com> |
Make SkCanvas::getBaseLayerSize() virtual Subclasses of SkCanvas may need to override the behavior here - for example, any proxy or deferred canvas may not know its own size and need to delegate to another object. We'll also work on reducing use of this function (https://skbug.com/3569), but some of the current uses seem to be semantically necessary. R=reed@google.com BUG=skia:3566 Review URL: https://codereview.chromium.org/1022423002
/external/skia/include/core/SkCanvas.h
|
76033be81b82c44fd5d4fdf2672eb22e505da1f0 |
|
14-Mar-2015 |
reed <reed@chromium.org> |
Revert[6] of Change device creation to see the (optional) layer-paint This reverts commit 173e5fe5f4be28272246e5676f5d2e5c4b1f9167. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1010503002
/external/skia/include/core/SkCanvas.h
|
173e5fe5f4be28272246e5676f5d2e5c4b1f9167 |
|
14-Mar-2015 |
reed <reed@chromium.org> |
Revert of Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1005173004/) Reason for revert: arrrg. this is a staging nightmare. override required on the chrome side. must revert (again) Original issue's description: > Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1001423002/) > > Reason for revert: > chrome now has the new virtual, so trying again > > Original issue's description: > > Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1006923002/) > > > > Reason for revert: > > platform_canvas tests failures > > > > skia_unittests (with patch) skia_unittests (with patch) PlatformCanvas.TranslateLayer failed 2 > > Flakiness dashboard > > > > failures: > > PlatformCanvas.TranslateLayer > > PlatformCanvas.FillLayer > > > > Original issue's description: > > > Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/) > > > > > > Reason for revert: > > > guard in chrome has landed > > > > > > Original issue's description: > > > > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/) > > > > > > > > Reason for revert: > > > > need to have chrome opt-in for the older API before this can land (in chrome) > > > > > > > > Original issue's description: > > > > > Change device creation to see the (optional) layer-paint > > > > > > > > > > Motivation: > > > > > > > > > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice. > > > > > > > > > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands. > > > > > > > > > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0 > > > > > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > > > > > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90 > > > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > > > > Committed: https://skia.googlesource.com/skia/+/f7076a13e2d4269903b34ef2780e1c84723e4477 > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Committed: https://skia.googlesource.com/skia/+/8e14d660b2a434bc708a70180c84210883611683 > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/307d1ed129ff75eb64137dea75df858f9e250b69 TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1005183003
/external/skia/include/core/SkCanvas.h
|
307d1ed129ff75eb64137dea75df858f9e250b69 |
|
14-Mar-2015 |
reed <reed@chromium.org> |
Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1001423002/) Reason for revert: chrome now has the new virtual, so trying again Original issue's description: > Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1006923002/) > > Reason for revert: > platform_canvas tests failures > > skia_unittests (with patch) skia_unittests (with patch) PlatformCanvas.TranslateLayer failed 2 > Flakiness dashboard > > failures: > PlatformCanvas.TranslateLayer > PlatformCanvas.FillLayer > > Original issue's description: > > Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/) > > > > Reason for revert: > > guard in chrome has landed > > > > Original issue's description: > > > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/) > > > > > > Reason for revert: > > > need to have chrome opt-in for the older API before this can land (in chrome) > > > > > > Original issue's description: > > > > Change device creation to see the (optional) layer-paint > > > > > > > > Motivation: > > > > > > > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice. > > > > > > > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands. > > > > > > > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0 > > > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > > > > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90 > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Committed: https://skia.googlesource.com/skia/+/f7076a13e2d4269903b34ef2780e1c84723e4477 > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/8e14d660b2a434bc708a70180c84210883611683 TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1005173004
/external/skia/include/core/SkCanvas.h
|
8e14d660b2a434bc708a70180c84210883611683 |
|
13-Mar-2015 |
reed <reed@google.com> |
Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1006923002/) Reason for revert: platform_canvas tests failures skia_unittests (with patch) skia_unittests (with patch) PlatformCanvas.TranslateLayer failed 2 Flakiness dashboard failures: PlatformCanvas.TranslateLayer PlatformCanvas.FillLayer Original issue's description: > Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/) > > Reason for revert: > guard in chrome has landed > > Original issue's description: > > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/) > > > > Reason for revert: > > need to have chrome opt-in for the older API before this can land (in chrome) > > > > Original issue's description: > > > Change device creation to see the (optional) layer-paint > > > > > > Motivation: > > > > > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice. > > > > > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands. > > > > > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0 > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90 > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/f7076a13e2d4269903b34ef2780e1c84723e4477 TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1001423002
/external/skia/include/core/SkCanvas.h
|
f7076a13e2d4269903b34ef2780e1c84723e4477 |
|
13-Mar-2015 |
reed <reed@google.com> |
Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/) Reason for revert: guard in chrome has landed Original issue's description: > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/) > > Reason for revert: > need to have chrome opt-in for the older API before this can land (in chrome) > > Original issue's description: > > Change device creation to see the (optional) layer-paint > > > > Motivation: > > > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice. > > > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands. > > > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0 > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90 TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1006923002
/external/skia/include/core/SkCanvas.h
|
0e040f7da2fdfeb49aa60d24117306e3b1e6ea90 |
|
13-Mar-2015 |
reed <reed@google.com> |
Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/) Reason for revert: need to have chrome opt-in for the older API before this can land (in chrome) Original issue's description: > Change device creation to see the (optional) layer-paint > > Motivation: > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice. > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands. > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0 TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1008863002
/external/skia/include/core/SkCanvas.h
|
1182d9a96b80bd12183ee7c81325a979a51ee0c0 |
|
13-Mar-2015 |
reed <reed@google.com> |
Change device creation to see the (optional) layer-paint Motivation: PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice. This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands. Review URL: https://codereview.chromium.org/988413003
/external/skia/include/core/SkCanvas.h
|
44977485bdac75c055c3fa638f118874ccd2d22f |
|
27-Feb-2015 |
reed <reed@google.com> |
Revert of Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (patchset #1 id:1 of https://codereview.chromium.org/966753002/) Reason for revert: Android has been updated, so we can re-land this. Original issue's description: > Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (patchset #3 id:40001 of https://codereview.chromium.org/964613002/) > > Reason for revert: > This breaks Android framework build. See > > https://android-build.storage.googleapis.com/builds/git_master-skia-linux-volantisg-userdebug/1759130/7f0fcdbf3c0d47530d770a15c912298dac20dd7d90a01de63ecb9ba16c96b25c/logs/build_error.log?Expires=1425047630&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Signature=BHPS1lffyH7WykwyEw5RXVVXWqQK5rab%2B6Pl1VaUrTlmWT%2FXb6fq%2FBe22AUDZYFPG24MBR%2F2IzIDzTqH3mihQS9wIkcKJ4kJpA2G%2BI3l8jCX20brZSr3bsDSx%2F4wsLwU1bBpIxI%2FbrauoPRqddbXP8sNI1l51u6ZCxpvRQms9Mc%3D > > We need to stop them from using kIgnore before we can reland this. > > Original issue's description: > > replace kIgnore_SkAlphaType with kUnknown_SkAlphaType > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/1c8aeeaebce9675197be31bd769e8ffa2531bf86 > > TBR=reed@google.com,reed@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/574290f61a47bd1ce1f9e2d941533bda9c8f03fe TBR=reed@chromium.org,scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/966853002
/external/skia/include/core/SkCanvas.h
|
574290f61a47bd1ce1f9e2d941533bda9c8f03fe |
|
27-Feb-2015 |
scroggo <scroggo@google.com> |
Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (patchset #3 id:40001 of https://codereview.chromium.org/964613002/) Reason for revert: This breaks Android framework build. See https://android-build.storage.googleapis.com/builds/git_master-skia-linux-volantisg-userdebug/1759130/7f0fcdbf3c0d47530d770a15c912298dac20dd7d90a01de63ecb9ba16c96b25c/logs/build_error.log?Expires=1425047630&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Signature=BHPS1lffyH7WykwyEw5RXVVXWqQK5rab%2B6Pl1VaUrTlmWT%2FXb6fq%2FBe22AUDZYFPG24MBR%2F2IzIDzTqH3mihQS9wIkcKJ4kJpA2G%2BI3l8jCX20brZSr3bsDSx%2F4wsLwU1bBpIxI%2FbrauoPRqddbXP8sNI1l51u6ZCxpvRQms9Mc%3D We need to stop them from using kIgnore before we can reland this. Original issue's description: > replace kIgnore_SkAlphaType with kUnknown_SkAlphaType > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/1c8aeeaebce9675197be31bd769e8ffa2531bf86 TBR=reed@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/966753002
/external/skia/include/core/SkCanvas.h
|
1c8aeeaebce9675197be31bd769e8ffa2531bf86 |
|
27-Feb-2015 |
reed <reed@chromium.org> |
replace kIgnore_SkAlphaType with kUnknown_SkAlphaType BUG=skia: TBR= Review URL: https://codereview.chromium.org/964613002
/external/skia/include/core/SkCanvas.h
|
abcfab4d68d53900ef33320bb2622696c14d14b0 |
|
23-Feb-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Swap render target instead of creating a new gpu device for surface copy-on-write Swap render target of the gpu device instead of creating a new gpu device when making a copy-on-write upon surface modification. This removes the SkCanvas::setRootDevice which contains problematic code when trying to increase the use of SkImages internally in Skia. BUG=skia:3388 Review URL: https://codereview.chromium.org/925343002
/external/skia/include/core/SkCanvas.h
|
3cb3840c9af6f70896cf5565a38d4ee03c02d767 |
|
06-Feb-2015 |
reed <reed@google.com> |
Rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/)" This reverts commit c4e87724920222a218f31b22612efc5b1ec0ed6c. BUG=skia: TBR= NOTREECHECKS=True Review URL: https://codereview.chromium.org/898343004
/external/skia/include/core/SkCanvas.h
|
c4e87724920222a218f31b22612efc5b1ec0ed6c |
|
06-Feb-2015 |
reed <reed@google.com> |
Revert of rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/) Reason for revert: bug in gyp Original issue's description: > rename SkCanvasDrawable to SkDrawable, and make public > > BUG=skia: > NOTRY=True > ... winbuilder flake > > Committed: https://skia.googlesource.com/skia/+/4ae9eb7463cf2160723407359608f221c0d5e2a6 TBR=robertphillips@google.com,djsollen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/882853006
/external/skia/include/core/SkCanvas.h
|
4ae9eb7463cf2160723407359608f221c0d5e2a6 |
|
06-Feb-2015 |
reed <reed@google.com> |
rename SkCanvasDrawable to SkDrawable, and make public BUG=skia: NOTRY=True ... winbuilder flake Review URL: https://codereview.chromium.org/903993002
/external/skia/include/core/SkCanvas.h
|
de358a9946fb6cffa905c7aa0e5f29cf6960b927 |
|
05-Feb-2015 |
joshualitt <joshualitt@chromium.org> |
BUG=skia: Review URL: https://codereview.chromium.org/894693003
/external/skia/include/core/SkCanvas.h
|
3d91aad293b0f68886ed48ecfa6aa75826a27da8 |
|
02-Feb-2015 |
fmalita <fmalita@chromium.org> |
Disable LCD text when rasterizing SkPictureShader tiles. BUG=chromium:453299 R=reed@google.com Review URL: https://codereview.chromium.org/884163003
/external/skia/include/core/SkCanvas.h
|
96a857ef5a40b3d0751ec9ebaaa96d9f20b82b21 |
|
25-Jan-2015 |
reed <reed@chromium.org> |
initial preroll api BUG=skia: Review URL: https://codereview.chromium.org/855473002
/external/skia/include/core/SkCanvas.h
|
0846f1b1c43f5edebc2d87a19c7bca6574ff41df |
|
09-Jan-2015 |
reed <reed@google.com> |
remove (dead) SK_SUPPORT_LEGACY_DRAWDATA and SK_SUPPORT_LEGACY_CANVAS_VIRTUAL BUG=skia: TBR= Review URL: https://codereview.chromium.org/844053002
/external/skia/include/core/SkCanvas.h
|
41af966ab338e95eee81ab618ab28195075338f7 |
|
05-Jan-2015 |
reed <reed@google.com> |
Revert of Revert of move remaining virtual draw methods to onDraw (patchset #1 id:1 of https://codereview.chromium.org/835913002/) Reason for revert: test to see if it wasn't this CL that broke chromeos Original issue's description: > Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/) > > Reason for revert: > did this cause chromeos heap corruption on skp? > > Original issue's description: > > move remaining virtual draw methods to onDraw > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419 > > TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e87e383351e1547b21d96d02bcd0c3cbbe0837f1 TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com,reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/831253002
/external/skia/include/core/SkCanvas.h
|
e87e383351e1547b21d96d02bcd0c3cbbe0837f1 |
|
05-Jan-2015 |
reed <reed@chromium.org> |
Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/) Reason for revert: did this cause chromeos heap corruption on skp? Original issue's description: > move remaining virtual draw methods to onDraw > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419 TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/835913002
/external/skia/include/core/SkCanvas.h
|
2e0f7d53bba5438c9bf11ee5ccae2c301e348419 |
|
05-Jan-2015 |
reed <reed@chromium.org> |
move remaining virtual draw methods to onDraw BUG=skia: Review URL: https://codereview.chromium.org/817723005
/external/skia/include/core/SkCanvas.h
|
c4fda92f45b9649f233a5b8636618a6431aa59cb |
|
02-Jan-2015 |
reed <reed@chromium.org> |
remove unused drawData BUG=skia: Review URL: https://codereview.chromium.org/830083002
/external/skia/include/core/SkCanvas.h
|
0acf1b4b3645772d220c720313821bac389751b5 |
|
23-Dec-2014 |
reed <reed@google.com> |
add private flag for sprite-as-bitmap BUG=skia:3272 Review URL: https://codereview.chromium.org/806853005
/external/skia/include/core/SkCanvas.h
|
d990e2f14f14c36c3d0beb303dd0953c7aa1fcfa |
|
22-Dec-2014 |
reed <reed@google.com> |
add testing flag to ignore saveLayer bounds BUG=skia: Review URL: https://codereview.chromium.org/819123003
/external/skia/include/core/SkCanvas.h
|
f7430ccfc0e7b445a44b840c1453c9ef5988a656 |
|
21-Dec-2014 |
reed <reed@chromium.org> |
removed dead SK_SUPPORT_LEGACY_DRAWTEXT_VIRTUAL code BUG=skia: TBR= Review URL: https://codereview.chromium.org/817193002
/external/skia/include/core/SkCanvas.h
|
3fcc125c776c837aa858598ce385f5c6f8f01795 |
|
15-Dec-2014 |
junov <junov@chromium.org> |
Remove SkCanvas::isDrawingToLayer BUG=3245 Review URL: https://codereview.chromium.org/803913005
/external/skia/include/core/SkCanvas.h
|
f0f14113431ace669f278fdd97b50950f2cf4c80 |
|
12-Dec-2014 |
mtklein <mtklein@chromium.org> |
Cull pushCull and popCull from Skia. These calls are unused and going away. Waiting on crrev.com/796083002. BUG=skia: Review URL: https://codereview.chromium.org/794263002
/external/skia/include/core/SkCanvas.h
|
2ff1fcede1e9525285c5de1f35fb2dcb0fab32bd |
|
11-Dec-2014 |
reed <reed@google.com> |
Defer saves() until they're needed patch from issue 759443006 at patchset 40001 (http://crrev.com/759443006#ps40001) BUG=skia: Review URL: https://codereview.chromium.org/767333002
/external/skia/include/core/SkCanvas.h
|
c54d8db4d169ea5f2af2a9a2349df007bd428475 |
|
10-Dec-2014 |
Florin Malita <fmalita@google.com> |
Remove SkCanvas::drawBitmapMatrix() R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/789033002
/external/skia/include/core/SkCanvas.h
|
3054be16dfdb0d06233770cbfc338958edef44ea |
|
10-Dec-2014 |
reed <reed@google.com> |
Remove canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) BUG=skia: TBR= re-landing after chrome fixes have landed Review URL: https://codereview.chromium.org/784223007
/external/skia/include/core/SkCanvas.h
|
a8918a065075dece6e407cce0dfddf110e5d61a9 |
|
09-Dec-2014 |
reed <reed@google.com> |
Revert of remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul (patchset #3 id:40001 of https://codereview.chromium.org/790733003/) Reason for revert: need to update chrome first Original issue's description: > remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul > > patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2c1605a1fbaa2e35a27399a34254fb1200ec2ae6 TBR=fmalita@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/791763002
/external/skia/include/core/SkCanvas.h
|
2c1605a1fbaa2e35a27399a34254fb1200ec2ae6 |
|
09-Dec-2014 |
reed <reed@google.com> |
remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) BUG=skia: Review URL: https://codereview.chromium.org/790733003
/external/skia/include/core/SkCanvas.h
|
f4e0d9eb2d72fe92c30237de978936113143dc16 |
|
06-Dec-2014 |
reed <reed@google.com> |
clear() is now an alias for drawPaint, so remove its virtual Needs these to land first: https://codereview.chromium.org/733343005 https://codereview.chromium.org/777413004 BUG=skia: Review URL: https://codereview.chromium.org/780393002
/external/skia/include/core/SkCanvas.h
|
8eddfb50c0c9e4bcba6384a2ce39852b5fb5becb |
|
04-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip This reverts commit af641a1c10f176cb9617026d3cc93c117a85d13d. BUG=skia: TBR= Review URL: https://codereview.chromium.org/783493002
/external/skia/include/core/SkCanvas.h
|
af641a1c10f176cb9617026d3cc93c117a85d13d |
|
03-Dec-2014 |
reed <reed@chromium.org> |
Revert "Change clear() to respect the clip" This reverts commit 3729469d6a12266037b697c2192768545e097ab0. BUG=skia: TBR= Review URL: https://codereview.chromium.org/778563002
/external/skia/include/core/SkCanvas.h
|
3729469d6a12266037b697c2192768545e097ab0 |
|
02-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip patch from issue 769703002 at patchset 1 (http://crrev.com/769703002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/772533004
/external/skia/include/core/SkCanvas.h
|
2d97bc139a7de5813468bd3dbfd0037351ae5606 |
|
20-Nov-2014 |
fmalita <fmalita@chromium.org> |
Disable LCD text explicitly in SkPictureImageFilter::onFilterImage() As an intermediate fix for https://code.google.com/p/skia/issues/detail?id=3142, we can use a non-public SkCanvas constructor and force-disable LCD text. BUG=skia:3142 R=reed@google.com,senorblanco@google.com Review URL: https://codereview.chromium.org/725243004
/external/skia/include/core/SkCanvas.h
|
78e276889795454891cbba48ab11927968114953 |
|
19-Nov-2014 |
reed <reed@google.com> |
Allow pictures to have a full bounds This reverts commit 7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264. BUG=skia: Review URL: https://codereview.chromium.org/738083002
/external/skia/include/core/SkCanvas.h
|
7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264 |
|
19-Nov-2014 |
reed <reed@google.com> |
Revert of allow pictures to have a full bounds (patchset #3 id:40001 of https://codereview.chromium.org/736583004/) Reason for revert: needed to update legacy width() helpers Original issue's description: > allow pictures to have a full bounds > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7e76bff26e7c74902841ca4f607eb0b24a833a4a TBR=fmalita@google.com,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/722043005
/external/skia/include/core/SkCanvas.h
|
7e76bff26e7c74902841ca4f607eb0b24a833a4a |
|
19-Nov-2014 |
reed <reed@google.com> |
allow pictures to have a full bounds BUG=skia: Review URL: https://codereview.chromium.org/736583004
/external/skia/include/core/SkCanvas.h
|
c87dd2ce965cd1bbc8a74abe0c141658a469d7f2 |
|
14-Nov-2014 |
djsollen <djsollen@google.com> |
Enable unused param checking for public includes. This CL cleans up the existing violations and enables the build time check to ensure that we don't regress. The motiviation behind this change is to allow clients who include our headers to be able to build with this warning enabled. Review URL: https://codereview.chromium.org/726923002
/external/skia/include/core/SkCanvas.h
|
b2db898573e3cdcc8234eebf51961bfc4977ebbc |
|
13-Nov-2014 |
reed <reed@google.com> |
rename filterTextFlags to disableLCD Under the hood, add SkPixelGeometry to the CreateInfo for new devices, allowing them to see their geometry (SkDeviceProperties) up front, rather than having it changed later. The only exception is for devices that are used on the root-layer, where we don't see the device until after the fact (at least as long as we allow clients to attach a device to a canvas externally). We also filter the geometry when we're creating a layer, so we can disable LCD text automatically if the layer is not marked as opaque. NOTRY=True -- gammatext flake? Review URL: https://codereview.chromium.org/719253002
/external/skia/include/core/SkCanvas.h
|
6a070dc06af4e9f305f9d08a69e34d18ade473cb |
|
12-Nov-2014 |
reed <reed@google.com> |
experimental BUG=skia: Review URL: https://codereview.chromium.org/716793004
/external/skia/include/core/SkCanvas.h
|
81f71b6630a9b7398bf983689436cccdd8dd3ff7 |
|
11-Nov-2014 |
robertphillips <robertphillips@google.com> |
Change where layer hoisting data is gathered This CL: 1) removes the EXPERIMENTAL_optimize on SkCanvas & SkDevice 2) moves the saveLayer gathering step to endRecording 3) Replaces GPUOptimize with SkRecordComputeLayers 4) Update bench_pictures & render_pictures to provide the new flag #2 also necessitated moving the BBH computation (and record optimization) out of SkPicture's ctor (and into endRecording) Review URL: https://codereview.chromium.org/718443002
/external/skia/include/core/SkCanvas.h
|
a5414c4a8efc3119ee20fcee96c0bf68a04909c7 |
|
10-Oct-2014 |
tfarina <tfarina@chromium.org> |
Turn SkCanvasStateUtils into a class with static functions. That simplifies the way to declare it a friend, as needed in SkCanvas. BUG=skia:2914 TEST=make most R=reed@google.com Review URL: https://codereview.chromium.org/645773002
/external/skia/include/core/SkCanvas.h
|
d52893cfc8c3fb1187c04c66f6beda66e1bb0b2c |
|
25-Sep-2014 |
piotaixr <piotaixr@chromium.org> |
Add doc on SkCanvas::drawImage*() methods BUG=skia:2947 R=junov@chromium.org, reed@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/595043002
/external/skia/include/core/SkCanvas.h
|
b5fae93d72c7b6480f83fd8a7b534cd1fdfcd49a |
|
24-Sep-2014 |
piotaixr <piotaixr@chromium.org> |
SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/583453002
/external/skia/include/core/SkCanvas.h
|
2456b7681aea8d91072186b17f8209955846f2f7 |
|
24-Sep-2014 |
borenet <borenet@google.com> |
Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a Canvas (patchset #9 id:160001 of https://codereview.chromium.org/583453002/) Reason for revert: Broke ChromiumOS Ozone builder: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/4087/steps/compile/logs/stdio Reverting to unblock DEPS roll. Original issue's description: > SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08 R=junov@chromium.org, reed@google.com, bsalomon@google.com, piotaixr@chromium.org TBR=bsalomon@google.com, junov@chromium.org, piotaixr@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2947 Author: borenet@google.com Review URL: https://codereview.chromium.org/598133002
/external/skia/include/core/SkCanvas.h
|
432789972c1e1f8a66165c75a250dba1853efa08 |
|
23-Sep-2014 |
piotaixr <piotaixr@chromium.org> |
SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas BUG=skia:2947 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/583453002
/external/skia/include/core/SkCanvas.h
|
4a8126e7f81384526629b1e21bf89b632ea13cd9 |
|
22-Sep-2014 |
reed <reed@google.com> |
Introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/)" This reverts commit 29c857d0f3a1cb837f73406eeb6ba9771879b5e7. TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/588143004
/external/skia/include/core/SkCanvas.h
|
29c857d0f3a1cb837f73406eeb6ba9771879b5e7 |
|
21-Sep-2014 |
reed <reed@chromium.org> |
Revert of introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/) Reason for revert: Broke call site in WebKit Original issue's description: > introduce Props to surface (work in progress) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3716fd067a5621bb94a6cb08d72afec8bf3aceda R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@google.com TBR=bsalomon@google.com, bungeman@google.com, fmalita@google.com, jvanverth@google.com, reed@google.com, robertphillips@google.com, vangelis@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@chromium.org Review URL: https://codereview.chromium.org/583773004
/external/skia/include/core/SkCanvas.h
|
3716fd067a5621bb94a6cb08d72afec8bf3aceda |
|
21-Sep-2014 |
reed <reed@google.com> |
introduce Props to surface (work in progress) BUG=skia: R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/551463004
/external/skia/include/core/SkCanvas.h
|
d954498c01ccf0417feacf89e45d0c62a06a813b |
|
10-Sep-2014 |
reed <reed@chromium.org> |
Revert of Revert of allow canvas to force conservative clips (for speed) (patchset #1 id:1 of https://codereview.chromium.org/554033003/) Reason for revert: May just rebaseline, plus want to see the results of the chrome tests, so re-trying this CL. Original issue's description: > Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/) > > Reason for revert: > multipicturedraw failed on nvprmsaa -- don't know why yet > > Original issue's description: > > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: > > > > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. > > > > 2. The conservative clips mean less work is done. > > > > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. > > > > 4. API is private for now. > > > > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241 > > TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com,junov@google.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/6f09709519b79a1159f3826645f1c5fbc101ee11 R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com, reed@google.com TBR=bsalomon@google.com, junov@google.com, mtklein@google.com, reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/560713002
/external/skia/include/core/SkCanvas.h
|
6f09709519b79a1159f3826645f1c5fbc101ee11 |
|
09-Sep-2014 |
reed <reed@google.com> |
Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/) Reason for revert: multipicturedraw failed on nvprmsaa -- don't know why yet Original issue's description: > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: > > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. > > 2. The conservative clips mean less work is done. > > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. > > 4. API is private for now. > > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241 R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com TBR=bsalomon@google.com, junov@google.com, mtklein@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/554033003
/external/skia/include/core/SkCanvas.h
|
27a5e656c3d6ef22f9cb34de18e1b960da3aa241 |
|
09-Sep-2014 |
reed <reed@google.com> |
Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. 2. The conservative clips mean less work is done. 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. 4. API is private for now. R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/541593005
/external/skia/include/core/SkCanvas.h
|
49f085dddff10473b6ebf832a974288300224e60 |
|
05-Sep-2014 |
bsalomon <bsalomon@google.com> |
"NULL !=" = NULL R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/544233002
/external/skia/include/core/SkCanvas.h
|
8f2e791baa1287bd321217c88756695c41699a7e |
|
04-Sep-2014 |
reed <reed@google.com> |
add SK_API to forward declare in canvas.h NOTRY=True TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/541073002
/external/skia/include/core/SkCanvas.h
|
fa35f8e6ebc9d98d57d2edc35e4a83556eb75cae |
|
04-Sep-2014 |
reed <reed@google.com> |
remove getTotalClipAsPath, privatize getTotalClip R=robertphillips@google.com, djsollen@google.com TBR=robertphilips Author: reed@google.com Review URL: https://codereview.chromium.org/546493002
/external/skia/include/core/SkCanvas.h
|
00d5c2c6523321d25b32905ff4822f083a4173ee |
|
21-Aug-2014 |
fmalita <fmalita@chromium.org> |
SkTextBlob Initial implementation. R=bungeman@google.com, jbroman@chromium.org, mtklein@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/473633002
/external/skia/include/core/SkCanvas.h
|
8bf3df68c58967d6297ccfe3eef36eea36c8b5ab |
|
21-Aug-2014 |
reed <reed@google.com> |
remove code for (dead) SK_SUPPORT_LEGACY_GETCLIPTYPE BUG=skia: R=djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/489103003
/external/skia/include/core/SkCanvas.h
|
6cfa73a29a26edf1d03bca224ad6860396308ffc |
|
13-Aug-2014 |
mtklein <mtklein@chromium.org> |
Start tracking the CTM while filling the BBH in SkRecordDraw. Depends on https://codereview.chromium.org/475473002/ BUG=skia: R=robertphillips@google.com, reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/468193003
/external/skia/include/core/SkCanvas.h
|
b3c9d1c33caf325aada244204215eb790c228c12 |
|
12-Aug-2014 |
dandov <dandov@google.com> |
SkCanvas::drawPatch param SkPoint[12] drawPatch now receives as parameter const SkPoint cubics[12] Adjusted derived classes and serialization. Ajusted GM's and benches that take into account combinations of optional parameters, the scale of the patch and 4 different types of patches. Planning on adding the extra functionality of SkPatch in another CL. BUG=skia: R=egdaniel@google.com, reed@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/463493002
/external/skia/include/core/SkCanvas.h
|
872e3dc89d82bbd5884a282640f20e430e2ac1f7 |
|
11-Aug-2014 |
reed <reed@google.com> |
Revert of Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/457253002/) Reason for revert: webkit has been updated, so re-landing Original issue's description: > Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/456203002/) > > Reason for revert: > still need to update ProfilingCanvas in blink > > Original issue's description: > > remove (now unneeded) legacy onDrawPicture variant > > > > TBR=fmalita@google.com > > > > Committed: https://skia.googlesource.com/skia/+/2e69d292e5a389db7d9264eb66172376692de8ca > > TBR= > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/47f9bdcc3d741a63935c52bfe85db44ab13f66f2 R=reed@chromium.org TBR=reed@chromium.org NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/460693002
/external/skia/include/core/SkCanvas.h
|
47f9bdcc3d741a63935c52bfe85db44ab13f66f2 |
|
11-Aug-2014 |
reed <reed@chromium.org> |
Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/456203002/) Reason for revert: still need to update ProfilingCanvas in blink Original issue's description: > remove (now unneeded) legacy onDrawPicture variant > > TBR=fmalita@google.com > > Committed: https://skia.googlesource.com/skia/+/2e69d292e5a389db7d9264eb66172376692de8ca TBR= NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/457253002
/external/skia/include/core/SkCanvas.h
|
2e69d292e5a389db7d9264eb66172376692de8ca |
|
10-Aug-2014 |
reed <reed@chromium.org> |
remove (now unneeded) legacy onDrawPicture variant TBR=fmalita@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/456203002
/external/skia/include/core/SkCanvas.h
|
d5fa1a455aad61f3e99081fe7a9b065cb3b115c6 |
|
09-Aug-2014 |
reed <reed@google.com> |
add drawPicture variant that takes a matrix and paint will need some staging strategy, since chrome and blink have overrides of onDrawPicture R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/448793004
/external/skia/include/core/SkCanvas.h
|
3b1c3d2c6160f714c4ebada05dd834f88fe5fd00 |
|
08-Aug-2014 |
reed <reed@google.com> |
add dummy onDrawPicture to allow migration for chrome overrides after this lands in chrome, land these two CLs https://codereview.chromium.org/454993002/ https://codereview.chromium.org/454143003 then land this skia CL https://codereview.chromium.org/448793004/ then remove the onDrawPicture overrides from chrome R=fmalita@google.com, robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/457753002
/external/skia/include/core/SkCanvas.h
|
963137b75c0a1fe91f35e9826742f36309f5e65d |
|
07-Aug-2014 |
dandov <dandov@google.com> |
Stopped skipping tests in dm of SkPatch by implementing the corresponding drawPath calls on classes that derive from SkCanvas. BUG=skia: R=egdaniel@google.com, bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/429343004
/external/skia/include/core/SkCanvas.h
|
ecfff21bde1f0ca3c36533eded325066b5f2d42d |
|
04-Aug-2014 |
dandov <dandov@google.com> |
SkCanvas interface for drawing a patch. Added function SkCanvas::drawPatch to the API. This function receives the patch to draw and the paint. Added function SkBaseDevice::drawPatch to the API. This function also receives the patch to draw and the paint. Currently SkGpuDevice and SkBitmapDevice generate the mesh taking into account the scale factor and call the corresponding device's drawVertices. BUG=skia: R=jvanverth@google.com, egdaniel@google.com, bsalomon@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/424663006
/external/skia/include/core/SkCanvas.h
|
d771f6bc273457bc7aa95938ac326dfbbf876e1a |
|
22-Jul-2014 |
robertphillips <robertphillips@google.com> |
Add auto purging for SkPicture-related Ganesh resources (esp. layers) This is intended to lower the bookkeeping burden for the Layer Caching feature. Cached layers are now automatically purged when a picture is deleted. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/408923002
/external/skia/include/core/SkCanvas.h
|
b184f7f52b2a94e95aee326a3ca37110d2e43336 |
|
13-Jul-2014 |
reed <reed@chromium.org> |
Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels This reverts commit 651eaeadeb0b1407f5fe192aeda90db1680fa2b8. TBR= Author: reed@chromium.org Review URL: https://codereview.chromium.org/390693002
/external/skia/include/core/SkCanvas.h
|
651eaeadeb0b1407f5fe192aeda90db1680fa2b8 |
|
12-Jul-2014 |
reed <reed@chromium.org> |
Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (https://codereview.chromium.org/388803007/) Reason for revert: still failing (randomly?) bench sometimes. need stack dump to diagnose. Original issue's description: > Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels > usning it. > > Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)" > > This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce. > > TBR=scroggo@google.com > > Committed: https://skia.googlesource.com/skia/+/debba5c3d091159149f8a88ab5dcd44dd72e0dc7 R=reed@google.com TBR=reed@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/382543005
/external/skia/include/core/SkCanvas.h
|
debba5c3d091159149f8a88ab5dcd44dd72e0dc7 |
|
12-Jul-2014 |
reed <reed@google.com> |
Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels usning it. Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)" This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce. R=reed@chromium.org TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/388803007
/external/skia/include/core/SkCanvas.h
|
d08cb905a7cc80d8fb868bbd14fffe1cd68adcce |
|
11-Jul-2014 |
jcgregorio <jcgregorio@google.com> |
Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/) Reason for revert: Maybe causing crashes in bench. http://108.170.220.120:10117/builders/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/builds/2608/steps/RunBench/logs/stdio Original issue's description: > add readPixels() to SkBitmap > > BUG=chromium:390782 > > Committed: https://skia.googlesource.com/skia/+/c4f216151b6ade70c35fade09a353052f40236b1 R=scroggo@google.com, bsalomon@google.com, reed@google.com TBR=bsalomon@google.com, reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=chromium:390782 Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/382243003
/external/skia/include/core/SkCanvas.h
|
c4f216151b6ade70c35fade09a353052f40236b1 |
|
10-Jul-2014 |
reed <reed@google.com> |
add readPixels() to SkBitmap BUG=chromium:390782 R=scroggo@google.com, bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/377303002
/external/skia/include/core/SkCanvas.h
|
696d3611760b0465caaebf6243824960034c3592 |
|
01-Jul-2014 |
fmalita <fmalita@chromium.org> |
Temporarily resurface matrix/clip save flags enum values. Pending Android build fixes. R=reed@google.com, scroggo@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/365463005
/external/skia/include/core/SkCanvas.h
|
52d9ac6c92ddf33b3b05eb77ba9509a7aa441657 |
|
30-Jun-2014 |
reed <reed@google.com> |
stop calling SkCanvas::getDevice BUG=skia: R=bsalomon@google.com, robertphillips@google.com, junov@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/355193006
/external/skia/include/core/SkCanvas.h
|
5f6102d07982043542343ff0a6c67b1319ac9fc7 |
|
30-Jun-2014 |
Florin Malita <fmalita@chromium.org> |
SaveFlags be-gone Remove the deprecated save(SaveFlags), willSave(SaveFlags) and all traces of kMatrix_SaveFlags/kClip_SaveFlag. BUG=skia:2297 R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/340403003
/external/skia/include/core/SkCanvas.h
|
0766931dc44a0d5da67b732d4a69967abcc235c9 |
|
27-Jun-2014 |
reed <reed@google.com> |
delete code for SK_SUPPORT_LEGACY_GETTOTALCLIP TBR= NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/354953008
/external/skia/include/core/SkCanvas.h
|
9f0147143fbedba10bdae496d812a14995304924 |
|
19-Jun-2014 |
reed <reed@chromium.org> |
Revert of remove guarded code - there are no more callers (https://codereview.chromium.org/343783002/) Reason for revert: webkit still uses getTotalClip -- need to find where they define the guard. ../../skia/ext/skia_utils_mac.mm:400:42: error: no member named 'getTotalClip' in 'SkCanvas' const SkRegion& clipRgn = canvas_->getTotalClip(); ~~~~~~~ ^ Original issue's description: > remove guarded code - there are no more callers > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c5d5cf9489977aa6fba077d1dc242029fbb4859e R=scroggo@google.com, reed@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@chromium.org Review URL: https://codereview.chromium.org/342843002
/external/skia/include/core/SkCanvas.h
|
c5d5cf9489977aa6fba077d1dc242029fbb4859e |
|
18-Jun-2014 |
reed <reed@google.com> |
remove guarded code - there are no more callers BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/343783002
/external/skia/include/core/SkCanvas.h
|
6ca763f362f25500ffeee0cc0b5dd2b58e9f2a79 |
|
17-Jun-2014 |
fmalita <fmalita@chromium.org> |
More SaveFlags removal twiddling. This is a follow up to https://codereview.chromium.org/338913002/. More tweaks to allow migrating clients to the new API. 1) switch the shim call direction willSave(SaveFlags) -> willSave() (internal users are still using the former, so external overriders of the latter will not be notified otherwise - doh) 2) ensure willSave() stays visible in SkProxyCanvas (Chromium's TimingCanvas attempts to call it explicitly). BUG=skia:2297 R=reed@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/334393008
/external/skia/include/core/SkCanvas.h
|
07fc662d7ee018bfc9eeddab82cc1768f57a69d2 |
|
16-Jun-2014 |
fmalita <fmalita@chromium.org> |
Prepare for internal SaveFlags removal. Chromium has a couple of SkCanvas subclasses which override willSave(). This adds a transitional shim to facilitate converting these to the parameter-less API. BUG=skia:2297 R=reed@google.com, scroggo@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/338913002
/external/skia/include/core/SkCanvas.h
|
074fe9df9480016359ded1e9ebaf8624cfc46780 |
|
10-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove legacy drawPicture entry point With Skia 5713352a (Chromium should no longer need the legacy SkCanvas::drawPicture interface - https://codereview.chromium.org/317193002/) this code should no longer be needed. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324703002
/external/skia/include/core/SkCanvas.h
|
c3b589a24eb4d567a906189f882c259ecf5c2f58 |
|
05-Jun-2014 |
fmalita <fmalita@chromium.org> |
SkClipStack::Element tweaks. ( This is intended to facilitate efficient kMatrix_SaveFlags emulation on restore(): * collect all clip stack elements for the current save count into a side clip stack * canvas.restore(everything) * replay the collected clip ops to restore the initial clip state => we restored the matrix but the clip state is unchanged ) Two main changes: * expose the save count for SkClipStack::Element * expose a replay method for the same (logic relocated from SkCanvas::replayClips) The SkCanvas::ClipVisitor shuffling is to enable forward decl in SkClipStack.h (cannot fwdecl a nested class). R=reed@google.com, robertphillips@google.com TBR=reed@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/269693003
/external/skia/include/core/SkCanvas.h
|
9b14f26d0f3a974f3dd626c8354e1db1cfcd322f |
|
04-Jun-2014 |
robertphillips <robertphillips@google.com> |
Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613004
/external/skia/include/core/SkCanvas.h
|
868074b50b0fc3e460d2aa97c1096827fe0a1935 |
|
03-Jun-2014 |
reed <reed@google.com> |
remove SkBounder -- unused and unloved BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/312553006
/external/skia/include/core/SkCanvas.h
|
92a8916540b14549213332c5f9f0cd44ec12de75 |
|
30-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix casting issue with or operator R=reed@google.com, epoger@google.com TBR=reed@google.com NOTREECHECKS=true NOTRY=true Author: djsollen@google.com Review URL: https://codereview.chromium.org/305253002 git-svn-id: http://skia.googlecode.com/svn/trunk@15011 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
2a5cd60bfff32c92cf44a8cfc3e8c017b9aee456 |
|
30-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add an OR operator overload for SaveFlags to avoid extra static casts. R=reed@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/303373003 git-svn-id: http://skia.googlecode.com/svn/trunk@15005 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
559a8833f0eae4af37dc0ffc3ee97e1fb14817b1 |
|
30-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix the rendering error of SkDraw::drawVertices in gpu path for solid color. If both textures and vertex-colors are NULL, drawVertices should stroke hairlines with the paint's color. This behavior is a useful debugging mode to visualize the mesh. BUG=skia:2266 R=bsalomon@google.com, reed@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/189963004 git-svn-id: http://skia.googlecode.com/svn/trunk@14985 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
2a67e123a3e559774a16a58cbe5106bc0fb86740 |
|
19-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This adds a checkbox to the debugger to allow seeing the effect pathops has on the clip. A new tab shows the C code that the pathops generate. Once in place, this CL found a bug in the pathops code where it was not handling empty clip stack elements correctly. The Cl also has the change to SkCanvas to fix this bug. R=robertphillips@google.com, reed@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/282283002 git-svn-id: http://skia.googlecode.com/svn/trunk@14774 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
fc6dfbab7565bb02db50f38f21b2c7d6c8f61c5c |
|
14-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Inline noop willFoo/didFoo into SkCanvas.h. We've got our canvas subclasses all calling back up to these via INHERITED, all noops. That's fine but currently a little sad as they can't be optimized away without link-time optimization, which we and Chrome only do on Windows. We actually make a call for each of these today on non-Windows. So, move the empty implementations into the header so those chaining calls really can be optimized away. BUG=skia: R=reed@google.com, fmalita@google.com, mtklein@google.com, fmalita@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/287593005 git-svn-id: http://skia.googlecode.com/svn/trunk@14722 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
d70fa2013adccaa52d1f3e6ca501a4d4ab1520f3 |
|
24-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Deprecate SaveFlags use in the public SkCanvas API. Because we still have internal users for now (to support the deprecated mode), this CL introduces an external-only variant of deprecation. Chromium is no longer using the deprecated methods, but Android may need to suppress SK_ATTR_EXTERNALLY_DEPRECATED warnings. R=reed@google.com, robertphillips@google.com, scroggo@google.com, bungeman@google.com, mtklein@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/246023008 git-svn-id: http://skia.googlecode.com/svn/trunk@14367 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
b0430d024572b1a5e5d7b80e406c668e975e3030 |
|
24-Apr-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@14346 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
e0d9ce890e67d02727ac2811bb456ddb64f827d4 |
|
23-Apr-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)" associated chrome change (to be committed with DEPS roll) https://codereview.chromium.org/248693002/ This reverts commit bfaceb53f58c9625b5471fcff35b5ca9ca3ae29c. TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/248083002 git-svn-id: http://skia.googlecode.com/svn/trunk@14321 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
945ec3a2bec668ca845071a65df8ec55e8f43819 |
|
22-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/) Reason for revert: need to test more the code-path where we don't opt into the new virtuals Original issue's description: > make drawText calls non-virtual, to ease SkFont and TextBlob > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14307 R=robertphillips@google.com TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/247983003 git-svn-id: http://skia.googlecode.com/svn/trunk@14314 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4325d114a5679e46f25ae75b0e43547fd7694998 |
|
22-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make drawText calls non-virtual, to ease SkFont and TextBlob BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/243853006 git-svn-id: http://skia.googlecode.com/svn/trunk@14307 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
6b4aaa77dcc4f17d0e22986f5f4cca70011d1ee5 |
|
21-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add optional origin parameter to accessTopLayerPixels BUG=skia: R=bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/244763004 git-svn-id: http://skia.googlecode.com/svn/trunk@14290 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
cae54f1f211e3c293ef9afb968067d06ca0ea23d |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove picture-backed surfaces BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/233943002 git-svn-id: http://skia.googlecode.com/svn/trunk@14159 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c873329ae9ff00b0c45f7294172ad2e9b1ec44c8 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update bench to be able to preprocess skps This allows benchmarking of optimization improvements and plumbs in the purging API. The purging is necessary so we don't magically get faster because the saveLayers are always pre-generated. R=jvanverth@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/233663002 git-svn-id: http://skia.googlecode.com/svn/trunk@14154 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
28361fad1054d59ed4e6a320c7a8b8782a1487c7 |
|
28-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add discard API to SkCanvas, plumb it to glDiscardFramebuffer() BUG=skia:2349 R=robertphillips@google.com, reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/211683002 git-svn-id: http://skia.googlecode.com/svn/trunk@13976 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
f20fc24a7def23093a1abd2fc8de4a1302aeb9f8 |
|
26-Mar-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove all references to legacy Config8888 BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/211043002 git-svn-id: http://skia.googlecode.com/svn/trunk@13952 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
d9ea09e1f29b303e6fa36079e99729d2951925b9 |
|
25-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Consolidate SkCanvas matrix virtuals. Remove didTranslate, didScale, didRotate & didSkew, and rely on didConcat instead. Subclasses can sniff the matrix type if they want to differentiate. (work in progress) R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/203203004 git-svn-id: http://skia.googlecode.com/svn/trunk@13940 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
7111d463cee893a479280c7af41757e709e33ef5 |
|
25-Mar-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of implement readPixels and writePixels natively, w/o using the (deprecated) (https://codereview.chromium.org/199733016/)" This reverts commit 9a90bd16dc6756395c422adf0f24560d033ed9ea. BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/211293002 git-svn-id: http://skia.googlecode.com/svn/trunk@13939 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
231f6b81c22001cac4ea87ea412c4d6fd10ffb8a |
|
25-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of implement readPixels and writePixels natively, w/o using the (deprecated) (https://codereview.chromium.org/199733016/) Reason for revert: Android bots segfaulting in tests. Original issue's description: > implement readPixels and writePixels natively, w/o using the (deprecated) > SkCanvas::Config8888 enum. > > Revert "Revert "hide Config8888 entirely". Broke a bunch of builds." > > This reverts commit 763277ba157fef0f651004bb98a189e9f1ac730b. > > Needs chrome to remove the READPIXELS guard from skia's .gyp > > Committed: https://code.google.com/p/skia/source/detail?r=13931 R=reed@google.com TBR=reed@google.com NOTREECHECKS=true NOTRY=true Author: mtklein@google.com Review URL: https://codereview.chromium.org/209233004 git-svn-id: http://skia.googlecode.com/svn/trunk@13932 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
1121170477302e25ef2a020cf2092aa6b399b3ef |
|
25-Mar-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
implement readPixels and writePixels natively, w/o using the (deprecated) SkCanvas::Config8888 enum. Revert "Revert "hide Config8888 entirely". Broke a bunch of builds." This reverts commit 763277ba157fef0f651004bb98a189e9f1ac730b. Needs chrome to remove the READPIXELS guard from skia's .gyp Review URL: https://codereview.chromium.org/199733016 git-svn-id: http://skia.googlecode.com/svn/trunk@13931 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
520cf8b33e788268432c6314c52dfcef22e776ae |
|
20-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix cull nesting assertion. Cull rects are in local coordinates and cannot be compared directly. No wonder it was so hard enforcing this in Blink :o This moves the validation logic into SkCanvas, using a device-space cull stack (debug build only). There are still some Blink bugs causing violations, so for now I'd like to keep this as an error message only. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/200923008 git-svn-id: http://skia.googlecode.com/svn/trunk@13885 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
180e36abf6e5da1688c9da5ef614a78c471834d5 |
|
20-Mar-2014 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "hide Config8888 entirely". Broke a bunch of builds. This reverts commit fa11c49cc11a6c9ebafbf9c59e118917f9b3cc56. Revert "Sanitizing source files in Housekeeper-Nightly" to make the above revert clean. This reverts commit b5787422c8eb2a27a9576777597fd9e06784acdb. TBR=reed@google.com TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/205963003 git-svn-id: http://skia.googlecode.com/svn/trunk@13872 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
e14792d99fc7a1a314ef5e2ca5b269239468355a |
|
19-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
hide Config8888 entirely BUG=skia: R=bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/203993002 git-svn-id: http://skia.googlecode.com/svn/trunk@13865 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
92362383a4de7b0d819c88fa8b74242bb2507602 |
|
18-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove SkCanvas matrix ops return value. The internal SkMatrix ops can no longer fail -> we can remove the bool return value. R=bsalomon@google.com, reed@google.com, robertphillips@google.com, scroggo@google.com, fmalita@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/200223008 git-svn-id: http://skia.googlecode.com/svn/trunk@13849 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a713f9c6f6a06d216d53e268b9c691941053dabf |
|
17-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add new readPixels with direct memory parameters BUG=skia: R=scroggo@google.com, bsalomon@google.com, robertphillips@google.com, fmalita@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/199413013 git-svn-id: http://skia.googlecode.com/svn/trunk@13840 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4ef54f8d72420a521d4aae04ff5cd438810eca7f |
|
17-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG -- dead code BUG=skia: R=halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/201973003 git-svn-id: http://skia.googlecode.com/svn/trunk@13834 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
42b08932e81abd8ebf296bede1994d297811511d |
|
17-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add NewRasterDirect for creating a canvas drawing to pre-allocated pixels R=reed@google.com TBR=scroggo@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/196923004 git-svn-id: http://skia.googlecode.com/svn/trunk@13824 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
145d1c0fdcef63991d7f910cc067a653a8aa2c4c |
|
16-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Proposed SkCanvas API for preLoading textures to VRAM v2.0 This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)). Committed: http://code.google.com/p/skia/source/detail?r=13810 R=reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/197123003 git-svn-id: http://skia.googlecode.com/svn/trunk@13822 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
5ed01d1f8fa3fa38105c252929f02dd7603271e3 |
|
14-Mar-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r13810 (Proposed SkCanvas API for preLoading textures to VRAM v2.0) git-svn-id: http://skia.googlecode.com/svn/trunk@13811 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
1ab85c8719ef46a8f2de9912b3f84f387bddf0d1 |
|
14-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Proposed SkCanvas API for preLoading textures to VRAM v2.0 This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)). R=reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/197123003 git-svn-id: http://skia.googlecode.com/svn/trunk@13810 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
44c48d062f7996b5b46917e1b312a32ad101f326 |
|
13-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
De-virtualize SkCanvas matrix ops. This moves the matrix management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=reed@google.com, robertphillips@google.com, bsalomon@google.com BUG=skia:2297 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/195793012 git-svn-id: http://skia.googlecode.com/svn/trunk@13799 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
e54a23fcfa42b2fc9d320650de72bcb2d9566b2d |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
De-virtualize SkCanvas save/restore. This moves the state management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/194713008 git-svn-id: http://skia.googlecode.com/svn/trunk@13776 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
9c135db83d198e7d8200027c7d2cf60f38517ee3 |
|
12-Mar-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
support direct writing to top layer, and hide getTopLayer() this should remove many of the chrome callers that today call accessBitmap on the toplayer, so they can read/write those pixels. The ultimate fix will be to support custom allocation of raster layers (via GDI/cairo/mac) so we can remove PlatformDevice subclassing in skia/ext BUG=skia: R=bsalomon@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/197433002 git-svn-id: http://skia.googlecode.com/svn/trunk@13774 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
069a55a7fe2c3ae6f5049843b3fc1a167b51215c |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/196323003/) Reason for revert: Pulling out to rename the virtuals. Original issue's description: > Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/) > > Reason for revert: > Re-landing after roll fix. > > Original issue's description: > > Revert "De-virtualize SkCanvas save/restore." > > > > (To allow a roll fix into the tree). > > > > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. > > > > R=halcanary@google.com > > > > Committed: https://code.google.com/p/skia/source/detail?r=13748 > > TBR=halcanary@google.com,fmalita@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: http://code.google.com/p/skia/source/detail?r=13754 R=halcanary@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, halcanary@google.com NOTREECHECKS=true NOTRY=true Author: fmalita@google.com Review URL: https://codereview.chromium.org/197553002 git-svn-id: http://skia.googlecode.com/svn/trunk@13765 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4fcd92d0bf09dc9c28643e83b95b6cbf9f1ff2b2 |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/) Reason for revert: Re-landing after roll fix. Original issue's description: > Revert "De-virtualize SkCanvas save/restore." > > (To allow a roll fix into the tree). > > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. > > R=halcanary@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13748 R=halcanary@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, halcanary@google.com NOTREECHECKS=true NOTRY=true Author: fmalita@google.com Review URL: https://codereview.chromium.org/196323003 git-svn-id: http://skia.googlecode.com/svn/trunk@13754 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
f1292bc01fa3a2e398454b0cf03d36b23b6912f7 |
|
11-Mar-2014 |
fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "De-virtualize SkCanvas save/restore." (To allow a roll fix into the tree). This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. R=halcanary@google.com Review URL: https://codereview.chromium.org/194923008 git-svn-id: http://skia.googlecode.com/svn/trunk@13748 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
80b10518a27a47b25a7dbf3591b425a741ebf406 |
|
11-Mar-2014 |
fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
De-virtualize SkCanvas save/restore. This moves the state management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=robertphillips@google.com, reed@google.com Review URL: https://codereview.chromium.org/194713008 git-svn-id: http://skia.googlecode.com/svn/trunk@13747 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
b93ba45b58ad24e0e2cb75b842e24ff711c368b0 |
|
10-Mar-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
flag to make kClipToLayer_SaveFlag the default behavior #define SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG to get the old behavior The goal is to remove the feature of saveLayer that allows the canvas to draw outside of the top-most layer. R=robertphillips@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/190723004 git-svn-id: http://skia.googlecode.com/svn/trunk@13730 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
5c70cdca5efe541b70d010e91607bf8626ea49ca |
|
08-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
hide getTotalClip, so we can eventually remove it hide getClipType, so we can eventually remove it patch from issue 189443007 TBR=robertphilips@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/189883010 git-svn-id: http://skia.googlecode.com/svn/trunk@13715 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4cd9e2169e35cd67ee7358acea6541245e1d1744 |
|
07-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkCanvas::writePixels that takes info+pixels directly add corresponding methods to device (w/ diff name to avoid colliding with exising virtuals) BUG=skia: R=bsalomon@google.com, robertphillips@google.com, junov@google.com, junov@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/180113010 git-svn-id: http://skia.googlecode.com/svn/trunk@13697 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
759cf4846804be137229393e04925752423de2d0 |
|
06-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Now that the matching changes have landed in Chromium we can clean up the API on our side. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/187553003 git-svn-id: http://skia.googlecode.com/svn/trunk@13680 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
8f90a892c5130d4d26b5588e1ff151d01a40688a |
|
28-Feb-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add new onClip* methods to SkCanvas https://codereview.chromium.org/183453002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13627 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
03fc3b4f67a115e4a7945d173856a6c80b09311e |
|
28-Feb-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of r13620 (add new onClip* methods to SkCanvas - https://codereview.chromium.org/183453002/) due to broken Chrome Canary and failing tests. git-svn-id: http://skia.googlecode.com/svn/trunk@13622 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
392c9be344549e809d0468abafdbeb6e32135bcd |
|
28-Feb-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add new onClip* methods to SkCanvas https://codereview.chromium.org/183453002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13620 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
3107b6a85eee7914b37382f7145ab658e8c27667 |
|
27-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkCanvas::NewRaster factory -- a very common use-case in chrome BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/183533004 git-svn-id: http://skia.googlecode.com/svn/trunk@13617 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
210ae2a42613b9048e8e8c4096c5bf4fe2ddf838 |
|
27-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Culling API *** SKP format breaking change *** Adding a couple of culling primitives: pushCull(SkRect) & popCull(). These are currently only plumbed for SKP playback quickreject. At record time, we perform a couple of optimizations to trim down the number of redundant culls: * collapse empty pushCull/popCull pairs * skip pushCull/popCull pairs nested within an identical cull rect Things still missing/to consider: * use an inlineable, simplified quickreject (Mike's old prototype) * debugger visualization for cull boxes * BBH integration: the initial prototype had some minimal BBH support, but since the optimizations required expensive rewinds and culling is expected to be a BBH alternative, it got dropped. R=bsalomon@google.com, reed@google.com, robertphillips@google.com, caryclark@google.com, tomhudson@google.com, iancottrell@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/138013009 git-svn-id: http://skia.googlecode.com/svn/trunk@13611 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4ebe3821888d550d8a8b89341ec251ba942f0225 |
|
26-Feb-2014 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of Add getReducedClipStack to lua canvas (https://codereview.chromium.org/180283004/)" This reverts commit efded03a38d6147caaf2d951638d27fdd47eed64. Fixes builds Review URL: https://codereview.chromium.org/181903002 git-svn-id: http://skia.googlecode.com/svn/trunk@13599 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
1caedbb216703df58ce5ebe29955e53fa098d8dc |
|
26-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Add getReducedClipStack to lua canvas (https://codereview.chromium.org/180283004/) Reason for revert: breaking a bunch of builds Original issue's description: > Add getReducedClipStack to lua canvas > > Committed: http://code.google.com/p/skia/source/detail?r=13594 R=reed@google.com TBR=reed@google.com NOTREECHECKS=true NOTRY=true Author: bsalomon@google.com Review URL: https://codereview.chromium.org/181653004 git-svn-id: http://skia.googlecode.com/svn/trunk@13597 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a47ac2bcc228981bd9f04508ad0894b61704800e |
|
26-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add getReducedClipStack to lua canvas R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/180283004 git-svn-id: http://skia.googlecode.com/svn/trunk@13594 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
754de5f65b466f721d952a379194cc94de376f42 |
|
24-Feb-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add isClipEmpty() -- encourage clients to call this rather than checking clipFoo() results BUG=skia: R=robertphillips@google.com Review URL: https://codereview.chromium.org/177073006 git-svn-id: http://skia.googlecode.com/svn/trunk@13568 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ed9806f5c972513d4141c9d1b5a04ab78b3af4cb |
|
21-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkCanvas::drawDRRect BUG=skia: R=bsalomon@google.com, robertphillips@google.com, humper@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/174243003 git-svn-id: http://skia.googlecode.com/svn/trunk@13524 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
31acdeabce094e9d42f0d6db8eebcf788aaba11a |
|
18-Feb-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13483 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
87001ed1f6f1d498874f7f4ba39abcf608ae8bf5 |
|
17-Feb-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix style nit in drawIRect git-svn-id: http://skia.googlecode.com/svn/trunk@13479 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
403f8d7a052269583175e945689824838e5e0ef4 |
|
17-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
still trying to kill setDevice: rename to setRootDevice (better name) and make private BUG=skia: COLLABORATOR=reed@google.com R=bsalomon@google.com, scroggo@google.com, reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/169023002 git-svn-id: http://skia.googlecode.com/svn/trunk@13476 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
e5b2af955b7d06815ddd405659ad62a2a8355ca3 |
|
16-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Store SkRRects in SkClipStack BUG=skia:2181 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/163683002 git-svn-id: http://skia.googlecode.com/svn/trunk@13465 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
15a140599942f70e47380e3f700a825c7cece3b4 |
|
16-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change device factories to take SkImageInfo instead of SkBitmap::Config patch from issue 167033002 BUG=skia: R=reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/168653002 git-svn-id: http://skia.googlecode.com/svn/trunk@13463 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a3b532743dbb1d54a4c17a2574083ef93c949d50 |
|
15-Feb-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13462 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
9836bc3fdddd51ed050102d03916cc5c7928dcc6 |
|
14-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
When the CTM has perspective the back-project method in quickRejectY goes haywire. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/166873004 git-svn-id: http://skia.googlecode.com/svn/trunk@13460 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
02d6f546161e2c98d69066373cec3f54f3c46252 |
|
14-Feb-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13447 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c3bd8af6d5722e854feca70c40d92f4954c5b67b |
|
13-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add peekPixels to SkCanvas and SkSurface fix reference to SkBaseDevice, which was only a problem in no-gpu build This reverts commit 4fa44a6bf73891b21917fb90d02beef9143bffa3. R=reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/163603003 git-svn-id: http://skia.googlecode.com/svn/trunk@13432 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ea7d08e3bbc45a0a573c1ac06afa4452f8d7000a |
|
13-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add unit test for unbalanced save and restores in pictures. R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/150653010 git-svn-id: http://skia.googlecode.com/svn/trunk@13430 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
bda591c739001b41d77048d680f81e05723cbc05 |
|
13-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of add peekPixels to SkCanvas and SkSurface (https://codereview.chromium.org/161733002/) Reason for revert: compile issues with gm/xfermodes3 Original issue's description: > add peekPixels to SkCanvas and SkSurface > > clone of https://codereview.chromium.org/159723006/ > > Committed: https://code.google.com/p/skia/source/detail?r=13427 R=jvanverth@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/163823002 git-svn-id: http://skia.googlecode.com/svn/trunk@13428 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
b2d93a91222dac2edb3c19128fd58fa2e74272aa |
|
13-Feb-2014 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add peekPixels to SkCanvas and SkSurface clone of https://codereview.chromium.org/159723006/ Review URL: https://codereview.chromium.org/161733002 git-svn-id: http://skia.googlecode.com/svn/trunk@13427 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
5d54c29c70118dd8f038acf19c5293adbb64cdf1 |
|
07-Feb-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove unneeded SK_SUPPORT_LEGACY_CANVAS_CREATECOMPATIBLEDEVICE git-svn-id: http://skia.googlecode.com/svn/trunk@13363 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c4b12f19a46946e1c02f3525e0ea4902b09feac5 |
|
05-Feb-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement correct clipping for image filters. Image filters in Skia currently clip the size of the the offscreen bitmap used for filtering to the device clip bounds. This means that any pixel-moving filter (e.g., blur) has edge artifacts at the clip boundaries. This is problematic for tiling, where a single SkPicture is played back with a clip set to the tile boundaries. By implementing the onFilterBounds() traversal, and using it in saveLayer() when a filter is present, we can clip the layer to the expanded clip rect. Note that this requires that the traversal be performed in reverse as compared to computeFastBounds(). (It's also done in device space, unlike computeFastBounds()). New test imagefiltersclipped tests pixel-moving filters when clipped by various clip rects. New test imageblurtiled tests tiled (compositor-style) rendering of blurred text. There should be no artifacts at the tile boundaries. BUG=337831 R=reed@google.com Review URL: https://codereview.chromium.org/23011012 git-svn-id: http://skia.googlecode.com/svn/trunk@13323 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
76f10a3bd936af7dbe2b5873d5a7eedd73cdc5da |
|
05-Feb-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurface BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/154163002 git-svn-id: http://skia.googlecode.com/svn/trunk@13319 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
e254310a55d55a710309714c48f7fbbe7a6126f7 |
|
31-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkCanvas constructor that explicitly creates no_config with dimensions BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/137833016 git-svn-id: http://skia.googlecode.com/svn/trunk@13272 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c0784dbd408596aff13a5d97448f7a9e5d3cf7d9 |
|
13-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SkScalarCompare type and header BUG= R=fmalita@chromium.org Review URL: https://codereview.chromium.org/113193004 git-svn-id: http://skia.googlecode.com/svn/trunk@12681 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
91246b9fc7740547d4b1b3f144684483c8e968cd |
|
05-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update documentation around drawBitmap and shaders R=reed@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/105823004 git-svn-id: http://skia.googlecode.com/svn/trunk@12507 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
644629c1c7913a43ced172b98d56e0f471bc348b |
|
21-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement a benchmark for GrResourceCache Adds "grresourcecache_add" and "grresourcecache_find" bench tests to test GrResourceCache::add and GrResourceCache::find. The tests work only with GPU backends, since GrResourceCache needs an GrGpu. Modifies bench tests to override SkBenchmark::isSuitableFor(Backend) function that specifies what kind of backend the test is inteded for. This replaces the previous "fIsRendering" flag that would indicate test that did no rendering. Adds SkCanvas::getGrContext() call to get the GrContext that the canvas ends up drawing to. The member function solves a common use-case that is also used in the benchmark added here. R=mtklein@google.com, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/73643005 git-svn-id: http://skia.googlecode.com/svn/trunk@12334 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
e61a86cfa00ea393ecc4a71fca94e1d476a37ecc |
|
18-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Guard against most unintentionally ephemeral SkAutoFoo instantiations. I think I applied the trick everywhere possible. Limitations: - can't be used with templated classes - all constructors and destructors must be defined inline A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I deleted them. This change caught the same bugs Cary found in SkPath, plus one more in SampleApp. BUG= R=reed@google.com, caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/72603005 git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
5308c83a366f965c308862bed1b6acf594af3df9 |
|
13-Nov-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
drawPosTextOnPath is now deprecated, removing all overrides and impls BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/61743017 git-svn-id: http://skia.googlecode.com/svn/trunk@12270 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4469938e92d779dff05e745559e67907bbf21e78 |
|
31-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"" This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d. BUG= Review URL: https://codereview.chromium.org/54603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
6fcbfcead5dc1b61fa5b4c139a1a3714e8c58091 |
|
31-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning" This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497. git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
081560e3abe25c4821b79ca1465f4dbd371c4b5c |
|
31-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning BUG= R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/51033004 git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
7ce564cccb246ec56427085872b2e1458fe74bd1 |
|
22-Oct-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance." This reverts commit r11904 Review URL: https://codereview.chromium.org/35543002 git-svn-id: http://skia.googlecode.com/svn/trunk@11909 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ad254fee73ad70a45acba69dccb9b65f88c3a92a |
|
22-Oct-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance. Committed: http://code.google.com/p/skia/source/detail?r=11842 R=bsalomon@google.com Review URL: https://codereview.chromium.org/23484007 git-svn-id: http://skia.googlecode.com/svn/trunk@11904 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c2cc1dbe818c8a5a699fbe18c4fc79b9d93daa94 |
|
17-Oct-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r11842 (call drawRect to try GrAARectRenderer if the path is a rect - https://codereview.chromium.org/23484007) due to changes to the following GM images: inverse_paths pathopsinverse git-svn-id: http://skia.googlecode.com/svn/trunk@11845 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
521a46750d87d3d206617d05d917ad6aad242ca4 |
|
17-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance. R=bsalomon@google.com, robertphillips@google.com, reed@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/23484007 git-svn-id: http://skia.googlecode.com/svn/trunk@11842 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
2887119a63e314704673b971e9bc9a3461313a2c |
|
14-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
save/restore the canvas around every bench draw call BUG= Committed: http://code.google.com/p/skia/source/detail?r=11728 R=djsollen@google.com, reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/26848013 git-svn-id: http://skia.googlecode.com/svn/trunk@11755 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
1f2f338e23789f3eef168dcbd8171a28820ba6c1 |
|
29-Aug-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Split SkDevice into SkBaseDevice and SkBitmapDevice https://codereview.chromium.org/22978012/ git-svn-id: http://skia.googlecode.com/svn/trunk@10995 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
9b051a375ba6d6b61cea98f35834cd032aaa5347 |
|
20-Aug-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r10830 (Split SkDevice out of SkRasterDevice) until we can get Chromium ready. git-svn-id: http://skia.googlecode.com/svn/trunk@10835 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
3055b700189afdd02486ed8f2279cea1d8897243 |
|
20-Aug-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Split SkDevice out of SkBitmapDevice https://codereview.chromium.org/22978012/ git-svn-id: http://skia.googlecode.com/svn/trunk@10830 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
31acc11977815402e4ef2681350f8559285bec97 |
|
20-Aug-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix name of "bleed" flag https://codereview.chromium.org/22812014/ git-svn-id: http://skia.googlecode.com/svn/trunk@10805 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
7475811143e190e172bf83d13c4bdba85704b604 |
|
17-Aug-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@10790 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
eed779d866e1e239bfb9ebc6a225b7345a41adf9 |
|
16-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path. R=bsalomon@google.com, reed@google.com, edisonn@google.com, scroggo@google.com, jvanverth@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://chromiumcodereview.appspot.com/20806003 git-svn-id: http://skia.googlecode.com/svn/trunk@10765 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
d4236574cfe4ec333d20e7a30f37e084168bb050 |
|
13-Aug-2013 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Prevent picture recording from over optimizing the culling of clips. BUG=skia:1496 R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/22875008 git-svn-id: http://skia.googlecode.com/svn/trunk@10689 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
1cc07d940fcd10f52bf8228c272707f0f5df0b44 |
|
12-Aug-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Add SkCanvas::drawPosTextBounded." This reverts commit e158aea941a6202a40b75fcee013d002089854bb. This was an experimental API change. We will reintroduce this feature with a different API approach, and support it w/ detailed testing and performance measurements. BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/22861002 git-svn-id: http://skia.googlecode.com/svn/trunk@10680 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
2515242ee079af3b3555620ea0c92338f47620fd |
|
07-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkCanvas::drawPosTextBounded. This allows subclasses which need bounding box information to get it from the caller if it has already been computed. BUG=chromium:269080 R=reed@google.com, tomhudson@chromium.org, tomhudson@google.com Author: jbroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/22585002 git-svn-id: http://skia.googlecode.com/svn/trunk@10612 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
631a59b9393208ed3546e81ca843f2f7da06ca64 |
|
31-Jul-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
added drawVertices path to GameBench https://codereview.chromium.org/21168006/ git-svn-id: http://skia.googlecode.com/svn/trunk@10459 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
9bf380ce7f848dfb5886dd52b82746521454b739 |
|
25-Jul-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
drawBitmap* cleanup https://codereview.chromium.org/19977003/ git-svn-id: http://skia.googlecode.com/svn/trunk@10342 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a5d3e77420621c912383c3b22e542d9413d68278 |
|
30-May-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@9343 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ed8d6bb2be0ed6a20841573682afaa46dea15175 |
|
29-May-2013 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Moving updateClipConservativelyUsingBounds into SkCanvas This method is being moved from SkPictureRecord to become a protected member of SkCanvas so that other classes derived from SkCanvas can use it. This Patch also applies the fix provided by updateClipConservativelyUsingBounds to SkPictureUtils::GatherPixelRefs BUG=https://code.google.com/p/chromium/issues/detail?id=244893 Review URL: https://codereview.chromium.org/15894005 git-svn-id: http://skia.googlecode.com/svn/trunk@9326 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
0a4805e33f8ddb445a2fd061462e715e1707f049 |
|
29-May-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
First pass at Comment API https://codereview.chromium.org/13957009/ git-svn-id: http://skia.googlecode.com/svn/trunk@9310 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
45a75fb4d0ca5daa0ac5e634238970306e3b5838 |
|
25-Apr-2013 |
caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
path ops : make it real Add an option to SkCanvas to turn on path ops when combining clips. Allow Op() to use one of the input paths as an output path. Fix a bug in Op() when the minuend is empty and the subtrahend is not (for difference). Change the build to allow core to depend on pathops. Review URL: https://codereview.chromium.org/14474002 git-svn-id: http://skia.googlecode.com/svn/trunk@8855 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
45c3db827d5bcb7c08bf49eff035be667332ec05 |
|
11-Apr-2013 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed bug in SkSurface_Gpu to make the surface receive the new copy when copy on write happens. Review URL: https://codereview.chromium.org/13195002 git-svn-id: http://skia.googlecode.com/svn/trunk@8622 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
8d3cd7a170c810e3816bf00220cbef51e7b16795 |
|
30-Jan-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
clone of https://codereview.appspot.com/7208043/ Review URL: https://codereview.appspot.com/7232062 git-svn-id: http://skia.googlecode.com/svn/trunk@7476 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a44de9617a0a51014bacc4151287995ededcdf62 |
|
02-Jan-2013 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update documentation around picture playback. Review URL: https://codereview.appspot.com/7034045 git-svn-id: http://skia.googlecode.com/svn/trunk@6967 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4ed0fb768409bf97b79899c3990d8c15f5e9d784 |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 6766, thereby re-landing 6762-6763 now that the bots are ready git-svn-id: http://skia.googlecode.com/svn/trunk@6770 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
25c1408c3da9ca90509b84f21a1161ef40052bd1 |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 6762-6763, since those require new skps to be generated, and we can't do that immediately right now... will re-submit when we can. git-svn-id: http://skia.googlecode.com/svn/trunk@6766 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
68d61ed83ec7b6e98e9623c2f5c9e7b1a32d25bb |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make RRect and Oval first-class drawing primitives in SkCanvas. add RRect as a first-class clip primitive. Review URL: https://codereview.appspot.com/6923058 git-svn-id: http://skia.googlecode.com/svn/trunk@6762 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
f6c9a5ba5cded8d4f663b13e71e6e1e572322b41 |
|
20-Nov-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add restore() to SkAutoCanvasRestore git-svn-id: http://skia.googlecode.com/svn/trunk@6505 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
260eae59b4edef636685e640ec13d82490d3474f |
|
14-Nov-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
move setDevice() to protected: in preparation for its eventual demise git-svn-id: http://skia.googlecode.com/svn/trunk@6416 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
cd5f7e2222dfa9f6be188434e4bca459c1e4fc4a |
|
14-Nov-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
mark SkCanvas::setDevice as DEPRECATED -- need to remove all callers in chrome git-svn-id: http://skia.googlecode.com/svn/trunk@6414 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
8f0a7b8e7334187a5d7d5ab7fde5a3c3009555f5 |
|
07-Nov-2012 |
caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add temporary interfaces in blur and clip to permit testing if it is to our advantage to selectively disable soft clipping and high quality blurs during animations. Review URL: https://codereview.appspot.com/6812092 git-svn-id: http://skia.googlecode.com/svn/trunk@6328 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
fc84359aa920567e72742877a1249f52d076ad35 |
|
11-Oct-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@5892 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a6926b1f0352916c31cda66f2239a25d52f09315 |
|
10-Oct-2012 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reland r5861 but leave setMatrixClip virtual on SkDevice (IOW this is a partial revert of r5871 which reverted r5861). Unreviewed Review URL: https://codereview.appspot.com/6631062 git-svn-id: http://skia.googlecode.com/svn/trunk@5881 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
3fffb2ee9fa01ae61efb2395973eb7575eda4c96 |
|
10-Oct-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r5861 (remove gainfocus and setMatixClip) due to Chrome compilation issues git-svn-id: http://skia.googlecode.com/svn/trunk@5871 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a1c3d78f224874833920c8017f4287a3ec538779 |
|
09-Oct-2012 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove gainFocus() and setMatrixClip() virtuals from SkDevice. R=reed@google.com,robertphillips@google.com Review URL: https://codereview.appspot.com/6636050 git-svn-id: http://skia.googlecode.com/svn/trunk@5861 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
0e354aacd84d3bede3f97cbde35a54ba62a89533 |
|
08-Oct-2012 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove external matrix feature. We haven't been testing this for nearly two years. R=reed@google.com Review URL: https://codereview.appspot.com/6640044 git-svn-id: http://skia.googlecode.com/svn/trunk@5857 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
dde646afb522ac46d6917ada7c404d91da860bb0 |
|
01-Oct-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
re-land removal of setBitmapDevice git-svn-id: http://skia.googlecode.com/svn/trunk@5746 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
35e535a10fee7a738f8add54fc17271af0297a2a |
|
30-Sep-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Rolling back r5732 due to Chrome Mac compiler issues git-svn-id: http://skia.googlecode.com/svn/trunk@5744 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
768d59b97d9cdae1e66412b7fbe53c87c41a6cff |
|
28-Sep-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove setBitmapDevice -- no longer called, and is a necessary step on our way to removing setDevice (and hopefully getDevice after that). git-svn-id: http://skia.googlecode.com/svn/trunk@5732 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
74bb77ee4c747b8c70c5c613987c9f93df71df06 |
|
26-Sep-2012 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add getMetaData() to SkCanvas (as part of our master plan to remove subclasses of SkCanvas and SkDevice from our clients. git-svn-id: http://skia.googlecode.com/svn/trunk@5679 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c1ad0226087e10b1f300b5a45e3d6fdb23b8d1b8 |
|
19-Sep-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@5594 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
7112173c3c4cd1b1e7da8cdf971d71f01dd91299 |
|
18-Sep-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
re-re-land 5578 will follow w/ new .skp files to keep the waterfall green (I hope) git-svn-id: http://skia.googlecode.com/svn/trunk@5584 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
10f9f4a844c8d5260c0a02df94b940b6abf66b0d |
|
18-Sep-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 5580 git-svn-id: http://skia.googlecode.com/svn/trunk@5581 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
eab16dea1ce249dc8e4dc635cd76b6b1b7d0cc98 |
|
18-Sep-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
re-land 5578 w/ pipe fix git-svn-id: http://skia.googlecode.com/svn/trunk@5580 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c75c36a14b5dcc0dd5a82651d41792278cb27326 |
|
18-Sep-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 5578 -- broke pipe git-svn-id: http://skia.googlecode.com/svn/trunk@5579 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
f1ab723033a186dc53434104a636c2dfac5fc863 |
|
18-Sep-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change drawBitmapRect to take a float-src-rect instead of integer-src-rect. This allows the client more control over the scaling. Because of virtual overrides and wanting to keep the old call-sites up and running, this CL renames the virtual entry-point to drawBitmapRectToRect, and downgrades drawBitmapRect to a non-virtual helper function. The implementation is to use the float-rect for computing the matrix, but still cons-up an integer rect for the purposes of subsetting the original bitmap. We do this by calling float_src->roundOut(&int_src) so that we include all (partially) covered src pixels. No change needed on SkDevice, since that signature is explicitly passed the computed matrix. Review URL: https://codereview.appspot.com/6501140 git-svn-id: http://skia.googlecode.com/svn/trunk@5578 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
97af1a64ae6bdddd346d8babfd9f188279dd6644 |
|
28-Aug-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add caching of the snapshot image form a surface Notify the surface when the canvas draws into it, so it can invalidate the cached image, and (if needed) perform a copy-on-write on the surface if it was being shared with the image. Review URL: https://codereview.appspot.com/6441115 git-svn-id: http://skia.googlecode.com/svn/trunk@5306 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
3b3e895df6f8ee0f33010367c215944cd16a8334 |
|
16-Aug-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove EdgeType enum. Unimportant distinction, and removing speeds up quickReject Review URL: https://codereview.appspot.com/6448161 git-svn-id: http://skia.googlecode.com/svn/trunk@5140 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
20a550c6ea947f0ab239da1d4ecba209d76a98fd |
|
27-Jul-2012 |
justinlin@google.com <justinlin@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add virtual destructor to class with virtual functions. BUG= TEST= Review URL: https://codereview.appspot.com/6453052 git-svn-id: http://skia.googlecode.com/svn/trunk@4810 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
40a1ae4df28810aa5aa5cf2627d8387b2dfb867a |
|
13-Jul-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added SkDevice onAttachToCanvas & onDetachFromCanvas methods http://codereview.appspot.com/6348100/ git-svn-id: http://skia.googlecode.com/svn/trunk@4598 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
15e9d3e66e161ce23df30bc13f8a0c87d196b463 |
|
21-Jun-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Expanded distribution of instance counting http://codereview.appspot.com/6300114/ git-svn-id: http://skia.googlecode.com/svn/trunk@4291 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
1f90287df3129cb267422e482c52ebeca6a8990f |
|
01-Jun-2012 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Punctuation cleanup to satisfy idiosyncracies of OpenBSD gcc 4.2.1. Original patch by landry.breuil. http://code.google.com/p/skia/issues/detail?id=626 git-svn-id: http://skia.googlecode.com/svn/trunk@4112 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
90c07ea1d0aa6b7f20252c43fe23ee5ddc1d23cb |
|
13-Apr-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
replace getTotalClipStack() with replayClips()+ClipVisitor git-svn-id: http://skia.googlecode.com/svn/trunk@3670 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a707f6087455834fab5525a0c656cc5b6df2ff29 |
|
12-Apr-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
mark getTotalClip as deprecated remove unimplemented (and duplicate) getTotalClipBounds git-svn-id: http://skia.googlecode.com/svn/trunk@3661 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
b0a7ace7cb2a7559bbc254a7c93698bc71bbd245 |
|
05-Apr-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Renaming SkCanvas::fLayerCount to fSaveLayerCount for readability REVIEW=http://codereview.appspot.com/5992047/ git-svn-id: http://skia.googlecode.com/svn/trunk@3619 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
8926b169f6a0dfa4c2129a98ec2aee205f0c8527 |
|
23-Mar-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
apply imagefilter to all draw calls Review URL: https://codereview.appspot.com/5856048 git-svn-id: http://skia.googlecode.com/svn/trunk@3476 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
0b53d59a24f667350b4282f88470713902409030 |
|
19-Mar-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add optional updateMatrixClip param to getTopDevice(). Chrome should set this only when it is needed, and in doing so it can stop using the layeriter just to get its top device. git-svn-id: http://skia.googlecode.com/svn/trunk@3432 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
49794c0cbd934545854a7b4091af5af7dfb46570 |
|
15-Mar-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make commonBitmap un-virtual. That was a leftover from previous subclassing I think. git-svn-id: http://skia.googlecode.com/svn/trunk@3394 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
92d2a299d2738e4369508ea1296981a2f1f8aadb |
|
27-Feb-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
reapply r3259 (that was reverted) with fix. The SkASSERT was incorrect and failing on debug runs. Review URL: https://codereview.appspot.com/5699071 git-svn-id: http://skia.googlecode.com/svn/trunk@3263 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
a907ac3e3e3458fbb5d673c3feafb31fd7647b38 |
|
24-Feb-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Modify SkDeferredCanvas so that it uses its inherited SkCanvas to track matrix and clipping state Removed 'virtual' from a few canvas methods that no longer need it thanks to this change. BUG=http://code.google.com/p/skia/issues/detail?id=506 TEST=Canvas unit test REVIEW=http://codereview.appspot.com/5697052/ git-svn-id: http://skia.googlecode.com/svn/trunk@3261 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
3cc0d8a6f0feb66a60d3edac12c5a12a0e92ae93 |
|
24-Feb-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
reverting r3259 because of gm/test failure. git-svn-id: http://skia.googlecode.com/svn/trunk@3260 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
42bbef71c7ccba831caec84a9ab0e3ab15842de7 |
|
24-Feb-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Enable quickRejectY in SkCanvas to be inlined. This CL was tested against the picturePlayback bench and showed an approx 10-13% improvement on Android when playing back text. Review URL: https://codereview.appspot.com/5687083 git-svn-id: http://skia.googlecode.com/svn/trunk@3259 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
0b5b0ce39cea3e0eb83c70278b40fa52b3c5870d |
|
24-Feb-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
reverting r3257 because of gm failure. git-svn-id: http://skia.googlecode.com/svn/trunk@3258 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
421bcc375af0616c37a59b0508957ab54d8f6d12 |
|
24-Feb-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Modify SkDeferredCanvas so that it uses its inherited SkCanvas to track matrix and clipping state Removed 'virtual' from a few canvas methods that no longer need it thanks to this change. BUG=http://code.google.com/p/skia/issues/detail?id=506 TEST=Canvas unit test REVIEW=http://codereview.appspot.com/5697052/ git-svn-id: http://skia.googlecode.com/svn/trunk@3256 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
8f9ecbd3466d4330886b4c23b06e75b468c795ad |
|
13-Feb-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding API and unit testing for deferred canvas clearing/purging REVIEW=http://codereview.appspot.com/5646057/ TEST=DeferredCanvas unit test git-svn-id: http://skia.googlecode.com/svn/trunk@3181 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
bf6c1e4aff4d233f6502157fb73459cf69d0ab37 |
|
30-Jan-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding a flush method to SkCanvas BUG=http://code.google.com/p/skia/issues/detail?id=467 REVIEW=http://codereview.appspot.com/5600044/ TEST=gm uses the new code path on all its test cases git-svn-id: http://skia.googlecode.com/svn/trunk@3102 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
74b461961607fa57a150a9282c410ef0cab38764 |
|
28-Jan-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Formatting cleanup: remove extra whitespace Change by arthurhsu@chromium.org, original CL: http://codereview.appspot.com/5587049/ Review URL: https://codereview.appspot.com/5594043 git-svn-id: http://skia.googlecode.com/svn/trunk@3098 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4370aedf7f55af74e9ebb4ad1c2e010c08236dfa |
|
18-Jan-2012 |
junov@google.com <junov@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding class SkDeferredCanvas for deferred rendering. TEST=added a new pass to gm, so all gm tests are run through SkDeferredCanvas REVIEW=http://codereview.appspot.com/5430058/ git-svn-id: http://skia.googlecode.com/svn/trunk@3059 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
7c2029367cea5479fa3b74fb0ca2b0297b42b709 |
|
14-Dec-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add canvas::isDrawingToLayer(), as a fast query for chrome; faster than setting up a drawiter and counting the layers. git-svn-id: http://skia.googlecode.com/svn/trunk@2875 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
d58a1cd00b969a7755c375f55cf80f4d49d3047b |
|
10-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add config8888 support to writePixels Review URL: http://codereview.appspot.com/5374052/ git-svn-id: http://skia.googlecode.com/svn/trunk@2662 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
56c69773aea56c6c6bd47bc7e7970dd081205184 |
|
08-Nov-2011 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update files to use SK_BUILD_FOR_ANDROID. This CL also removes any unecessary references to the ANDROID definition. Review URL: http://codereview.appspot.com/5354049 git-svn-id: http://skia.googlecode.com/svn/trunk@2629 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
6850eab42ba4c2a7033a99824b02a2846ce0ef2a |
|
03-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Override 32BPP format in SkCanvas::readPixels Review URL: http://codereview.appspot.com/5330073/ git-svn-id: http://skia.googlecode.com/svn/trunk@2600 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
daba14b7d4fc96b915c45d82713b22729c0d0f37 |
|
02-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Line-endings only change (some windows line-endings snuck in) git-svn-id: http://skia.googlecode.com/svn/trunk@2588 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
c69809745e6496564639e42ef998ad39adf7dfb8 |
|
02-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Recommit r2584 with gpu pass of the new ReadPixels test disabled in fixed pt (gpu code doesn't work in general in fixed pt). git-svn-id: http://skia.googlecode.com/svn/trunk@2586 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ace7bd5623354ffabbd224d5b76550bab159c296 |
|
02-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r2584 (new test fails in fixed pt builds) git-svn-id: http://skia.googlecode.com/svn/trunk@2585 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
1a8ddf0a35bfb6c21a1184f81d2fdd50053acf31 |
|
02-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Changes the SkCanvas::readPixels API. Allows caller to read into prealloced bitmap pixels. Changes how clipping to device bounds is handled. Review URL: http://codereview.appspot.com/5307077/ git-svn-id: http://skia.googlecode.com/svn/trunk@2584 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
210ce003a5ec039dda80de0569fb47ca4efc4dc7 |
|
01-Nov-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add getDeviceSize() so callers won't need to call getDevice() so much ... we hope to make devices private in the future git-svn-id: http://skia.googlecode.com/svn/trunk@2577 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
071eef918d70b6ca8334bc1241d1ea6923e828d5 |
|
12-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add bool argument to canvas' clipRect and clipPath for antialiasing (currently ignored) git-svn-id: http://skia.googlecode.com/svn/trunk@2459 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
5e2457ef2eba0c3f2e4c8fc89be7f36659e4f3b1 |
|
10-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add getTotalClipBounds() as a partial replacement for getTotalClip. This can be faster than getTotalClip, since it doesn't need to compute the actual complex region for the answer. git-svn-id: http://skia.googlecode.com/svn/trunk@2452 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
fa6ac938e64fe11b442d05fe8a90ddac2d1951f9 |
|
05-Oct-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixup rendering of empty paths (including inverted fills) Add GM and Sample that draw empty paths with various styles and fills Review URL: http://codereview.appspot.com/5185047/ git-svn-id: http://skia.googlecode.com/svn/trunk@2414 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
bcb671c82a7341253864cda3a5c46d396402d7fb |
|
13-Sep-2011 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkCanvas::getClipDescription() and getClipDeviceBounds() so clients don't need to explicitly get the exact clip & compute those values themselves. (We may be able to provide description/bounds more cheaply than the exact clip.) git-svn-id: http://skia.googlecode.com/svn/trunk@2255 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
f0b5e1190af9807a027c0adba2f1380663c8e910 |
|
07-Sep-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add drawBitmapNine to canvas will add to device soon I think git-svn-id: http://skia.googlecode.com/svn/trunk@2233 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
52c748b1691f02f90b27c35bc05074fcef709e66 |
|
22-Aug-2011 |
bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Gpu can draw underlined text. http://codereview.appspot.com/4919047/ git-svn-id: http://skia.googlecode.com/svn/trunk@2154 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ec3ed6a5ebf6f2c406d7bcf94b6bc34fcaeb976e |
|
28-Jul-2011 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Automatic update of all copyright notices to reflect new license terms. I have manually examined all of these diffs and restored a few files that seem to require manual adjustment. The following files still need to be modified manually, in a separate CL: android_sample/SampleApp/AndroidManifest.xml android_sample/SampleApp/res/layout/layout.xml android_sample/SampleApp/res/menu/sample.xml android_sample/SampleApp/res/values/strings.xml android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java experimental/CiCarbonSampleMain.c experimental/CocoaDebugger/main.m experimental/FileReaderApp/main.m experimental/SimpleCocoaApp/main.m experimental/iOSSampleApp/Shared/SkAlertPrompt.h experimental/iOSSampleApp/Shared/SkAlertPrompt.m experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig gpu/src/android/GrGLDefaultInterface_android.cpp gyp/common.gypi gyp_skia include/ports/SkHarfBuzzFont.h include/views/SkOSWindow_wxwidgets.h make.bat make.py src/opts/memset.arm.S src/opts/memset16_neon.S src/opts/memset32_neon.S src/opts/opts_check_arm.cpp src/ports/SkDebug_brew.cpp src/ports/SkMemory_brew.cpp src/ports/SkOSFile_brew.cpp src/ports/SkXMLParser_empty.cpp src/utils/ios/SkImageDecoder_iOS.mm src/utils/ios/SkOSFile_iOS.mm src/utils/ios/SkStream_NSData.mm tests/FillPathTest.cpp Review URL: http://codereview.appspot.com/4816058 git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4f1151ab27485aff393d16559086c4c461f137a4 |
|
25-Jul-2011 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Documentation only: add warning to SkCanvas::writePixels() that this operation will not be recorded by SkPicture. Review URL: http://codereview.appspot.com/4815054 git-svn-id: http://skia.googlecode.com/svn/trunk@1947 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
6dc745506e6d6cc0936fed4de24443dc1ecb5a34 |
|
21-Jul-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove forward declaration and reference to extinct SkDeviceFactory git-svn-id: http://skia.googlecode.com/svn/trunk@1931 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
cde92111d50a96b6d0f3e166fbac7c9bc6eca349 |
|
06-Jul-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SkDeviceFactory from the collective consciousness, now that devices know how to create compatible siblings. git-svn-id: http://skia.googlecode.com/svn/trunk@1808 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
5667afc5cb4a8cd15a27667f222b6d9c94d61c38 |
|
27-Jun-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove drawShape from canvas api git-svn-id: http://skia.googlecode.com/svn/trunk@1723 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
e97f0856a8044866b12527819d14cdfbcdfd96f2 |
|
17-Jun-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add createNewCompatibleDevice. Allow devices to have a NULL factory and saveLayer will fall back on createNewCompatibleDevice. Review URL: http://codereview.appspot.com/4633044/ git-svn-id: http://skia.googlecode.com/svn/trunk@1625 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
af951c9bc4cbb6e60b430194fe5127ebe99c53fb |
|
16-Jun-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make SkDevice constructors explicit between offscreen and on/direct http://codereview.appspot.com/4632044/ git-svn-id: http://skia.googlecode.com/svn/trunk@1620 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
3048d4fd4e11399e412db4b3338cc0ff5a22b2b1 |
|
04-May-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove deprecated getViewport/setViewport git-svn-id: http://skia.googlecode.com/svn/trunk@1235 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ea4ac97dec2eb291139bd906939e0d2e05cdd7ef |
|
26-Apr-2011 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make SkDeviceFactory reference counted git-svn-id: http://skia.googlecode.com/svn/trunk@1180 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
2a98181f048c11f21f52fbd99f803f5fd6118261 |
|
14-Apr-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkCanvas::clear(SkColor color) to call the new virtual clear on device. git-svn-id: http://skia.googlecode.com/svn/trunk@1131 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
24fb8e2cce1bb9b169555bdda798b419b134debe |
|
11-Apr-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
mark viewport APIs as deprecated git-svn-id: http://skia.googlecode.com/svn/trunk@1108 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
9266fed56a46a4edc710a52c7be8d46fd7c2bc7a |
|
30-Mar-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add getTopLayer(), so clients don't have to use a LayerIter just to get the top. (very common for chrome) git-svn-id: http://skia.googlecode.com/svn/trunk@1016 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
7ffb1b21abcc7bbed5a0fc711f6dd7b9dbb4f577 |
|
15-Mar-2011 |
ctguil@chromium.org <ctguil@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add code needed to build skia as a windows dll within the chromium project. - Export/import skia APIs if SKIA_DLL is defined. - This change has no effect on skia. Review URL: http://codereview.appspot.com/4282042 git-svn-id: http://skia.googlecode.com/svn/trunk@944 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
cd9d69b9ce7eb301a9fd8d91b9f95fd99b07bae5 |
|
14-Mar-2011 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Upstreaming changes from android. - fix compile warnings in the GPU code - upstream android specific code (ifdef protected) - fail gracefully when a custom allocator fails git-svn-id: http://skia.googlecode.com/svn/trunk@936 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
d302f1401b3c9aea094804bad4e76de98782cfe8 |
|
03-Mar-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add support for clipstack to Gr. GrClip is now a list of rects and paths with set operations to combine them. The stencil buffer is used to perform the set operations to put the clip into the stencil buffer. Building Gr's clip from Skia's clipStack is currently disabled due to the fact that Skia's clipStack is relative to the root layer not the current layer. This will be fixed in a subsequent CL. git-svn-id: http://skia.googlecode.com/svn/trunk@878 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
7d7ca79c3e6e6be7b7849b0d9a7fe26effb89c38 |
|
23-Feb-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add fClipStack optional field to SkDraw (it is always set by canvas) git-svn-id: http://skia.googlecode.com/svn/trunk@844 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
5c3d1471e4908706cd053a5e2ea9ded3a6c2eaeb |
|
22-Feb-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add clipstack to canvas. not used yet, but will be for devices (e.g. gpu) that want to see how the clip was built git-svn-id: http://skia.googlecode.com/svn/trunk@824 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
3dd42b3c87299ad17b4df93fe251f6f9362495dc |
|
07-Feb-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
update dox for readPixels() git-svn-id: http://skia.googlecode.com/svn/trunk@772 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
4b226023832011bc3bcdd1e5092ff0645ad0bdee |
|
11-Jan-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add getter/setter for device-factory on canvas git-svn-id: http://skia.googlecode.com/svn/trunk@683 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
51df9e3fe3c1aec370854b2718df16fc02faa1b2 |
|
23-Dec-2010 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add gpu to gm tool add pass-through read/write pixels API to canvas git-svn-id: http://skia.googlecode.com/svn/trunk@660 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
f2b98d67dcb6fcb3120feede9c72016fc7b3ead8 |
|
20-Dec-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
merge with changes for GPU backend git-svn-id: http://skia.googlecode.com/svn/trunk@637 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
b70ae310bbdaa1b26786773aabce5548c1f48563 |
|
15-Oct-2010 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix a memory leak in the new Canvas/Device workflow. The previous change made it difficult to inherit from SkCanvas without leaking memory. By making SkDeviceFactory not reference counted, the right thing happens more naturally, just NewCanvas : public SkCanvas(new NewDeviceFactory()) {...} Review URL: http://codereview.appspot.com/2530042 git-svn-id: http://skia.googlecode.com/svn/trunk@605 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
8d84fac294682647694b0d2d8a87ac2bd19b6aab |
|
14-Oct-2010 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactor SkCanvas so that backends don't need to override it. Methods or classes that should go away are marked deprecated. The only thing I know of that breaks backward compatibility is SkCanvas((SkDevice*)NULL), but that is fairly unlikely to occur in the wild because that constructor had a default value of NULL. Review URL: http://codereview.appspot.com/2103045 git-svn-id: http://skia.googlecode.com/svn/trunk@604 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
40408614655c4057d93842c9b0f09aa6dfff9e02 |
|
02-Jul-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
oops, also update dox for saveLayerAlpha git-svn-id: http://skia.googlecode.com/svn/trunk@585 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ad164b2025cba65131ca68221a6ea7640d7b1de8 |
|
02-Jul-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
update dox for saveLayer() git-svn-id: http://skia.googlecode.com/svn/trunk@584 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
dc3381fc8194a6192af39539c6ac9787b20209d3 |
|
11-Feb-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
update save/restore comments to mention that the drawFilter is also saved add wrapper for harfbuzz font/fontclass git-svn-id: http://skia.googlecode.com/svn/trunk@500 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
ba09de4c4be66cc07790f23b0f3a925f47340e3e |
|
05-Feb-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
respect edgetype in quickreject git-svn-id: http://skia.googlecode.com/svn/trunk@489 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
cb60844b34766aad4151df5e87c144d4a57e9abe |
|
04-Dec-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add drawData() to canvas, to record data blobs git-svn-id: http://skia.googlecode.com/svn/trunk@452 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
845fdaca174f4675e9acc164b510e3a5ffa9053c |
|
23-Jun-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove deprecated use of porterduff enum git-svn-id: http://skia.googlecode.com/svn/trunk@235 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
199f108f14a5f60a9c2205ffa79b26102a206ad0 |
|
10-Jun-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
only call SkDevice::gainFocus() if we're actually drawing to a different device. Saves overhead when using GL. git-svn-id: http://skia.googlecode.com/svn/trunk@207 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
f76bacff7f66724072c67edb185abf9e3add11a0 |
|
13-May-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkSize for dimensions add SkShape baseclass, in the hopes of having SkPicture inherit from that, and also using shapes as the extension mechanism for things like animated-gif git-svn-id: http://skia.googlecode.com/svn/trunk@174 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|
8a1c16ff38322f0210116fa7293eb8817c7e477e |
|
17-Dec-2008 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
grab from latest android git-svn-id: http://skia.googlecode.com/svn/trunk@27 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkCanvas.h
|