a93a14a99816d25b773f0b12868143702baf44bf |
|
28-Aug-2017 |
Ben Wagner <bungeman@google.com> |
Convert NULL and 0 to nullptr. This was created by looking at warnings produced by clang's -Wzero-as-null-pointer-constant. This updates most issues in Skia code. However, there are places where GL and Vulkan want pointer values which are explicitly 0, external headers which use NULL directly, and possibly more uses in un-compiled sources (for other platforms). Change-Id: Id22fbac04d5c53497a53d734f0896b4f06fe8345 Reviewed-on: https://skia-review.googlesource.com/39521 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/include/core/SkMultiPictureDraw.h
|
5df4934b3e40cdc378e225d1dda39f015cae9bae |
|
12-Nov-2016 |
Mike Reed <reed@google.com> |
Revert[2] "Change SkCanvas to *not* inherit from SkRefCnt" Changes over original: - conditionalize ownership in SkPictureRecorder - conditionalize ownership in SkCanvasStateUtils This reverts commit b613c266df48cf45296ecc23d1bd7098c84bb7ba. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4742 Change-Id: Ib25514d6f546c69b6650b5c957403b04f7380dc2 Reviewed-on: https://skia-review.googlesource.com/4742 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkMultiPictureDraw.h
|
b613c266df48cf45296ecc23d1bd7098c84bb7ba |
|
10-Nov-2016 |
Heather Miller <hcm@google.com> |
Revert "Change SkCanvas to *not* inherit from SkRefCnt" This reverts commit 824075071885b6b741c141cbe2134d8345d34589. Reason for revert: Breaking WebView (chromium:663959) Original change's description: > Change SkCanvas to *not* inherit from SkRefCnt > > Definitely tricky for classes like SkNWayCanvas, where the caller (today) > need not pay attention to ownership of the canvases it gave the NWay > (after this CL, the caller *must* managed ownership) > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4441 > > DOCS_PREVIEW= https://skia.org/?cl=4441 > > Change-Id: Ib1ac07a3cdf0686d78e7aaa4735d45cc90bea081 > Reviewed-on: https://skia-review.googlesource.com/4441 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=djsollen@google.com,mtklein@google.com,halcanary@google.com,robertphillips@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I5e3b3e876b7d2c09833cf841801321033b6b968b Reviewed-on: https://skia-review.googlesource.com/4687 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Heather Miller <hcm@google.com>
/external/skia/include/core/SkMultiPictureDraw.h
|
824075071885b6b741c141cbe2134d8345d34589 |
|
09-Nov-2016 |
Mike Reed <reed@google.com> |
Change SkCanvas to *not* inherit from SkRefCnt Definitely tricky for classes like SkNWayCanvas, where the caller (today) need not pay attention to ownership of the canvases it gave the NWay (after this CL, the caller *must* managed ownership) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4441 DOCS_PREVIEW= https://skia.org/?cl=4441 Change-Id: Ib1ac07a3cdf0686d78e7aaa4735d45cc90bea081 Reviewed-on: https://skia-review.googlesource.com/4441 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkMultiPictureDraw.h
|
a7e9f05119174848c6be5028568f46eb5e85398e |
|
18-Feb-2016 |
bungeman <bungeman@google.com> |
Move SkTDArray to private. TBR=reed Moving to private is good. Review URL: https://codereview.chromium.org/1707213002
/external/skia/include/core/SkMultiPictureDraw.h
|
00b621cfc0dac2a0028757a974de33a78bb8579d |
|
18-Jun-2015 |
mtklein <mtklein@chromium.org> |
Add sk_parallel_for() This should be a drop-in replacement for most for-loops to make them run in parallel: for (int i = 0; i < N; i++) { code... } ~~~> sk_parallel_for(N, [&](int i) { code... }); This is just syntax sugar over SkTaskGroup to make this use case really easy to write. There's no more overhead that we weren't already forced to add using an interface like batch(), and no extra heap allocations. I've replaced 3 uses of SkTaskGroup with sk_parallel_for: 1) My unit tests for SkOnce. 2) Cary's path fuzzer. 3) SkMultiPictureDraw. Performance should be the same. Please compare left and right for readability. :) BUG=skia: No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1184373003
/external/skia/include/core/SkMultiPictureDraw.h
|
772604c214e8c12ee16d2eb60f4b7acbcdd2129e |
|
28-Jan-2015 |
senorblanco <senorblanco@chromium.org> |
Add a flag to flush the canvases during SkMultiPictureDraw::draw(). This is necessary for multisampling, so that each multisampled render target resolves before Chrome's compositor attempts to draw the texture. BUG=skia: Review URL: https://codereview.chromium.org/878653004
/external/skia/include/core/SkMultiPictureDraw.h
|
e71cd54ed4d83310d718490d40643c35b622b9f5 |
|
29-Oct-2014 |
mtklein <mtklein@chromium.org> |
SkTaskGroup::batch(fn, args, N) Porting QuiltTask isn't important in itself; this is mostly an API feeler. BUG=skia: Review URL: https://codereview.chromium.org/689673003
/external/skia/include/core/SkMultiPictureDraw.h
|
89889b69391a730f0ba2a1efb549864b7762263f |
|
29-Oct-2014 |
reed <reed@google.com> |
MultiPictureDraw is taskgroup aware. SampleApp is multipicturedraw aware. BUG=skia: Review URL: https://codereview.chromium.org/684923002
/external/skia/include/core/SkMultiPictureDraw.h
|
7eacd77ce63abec6c5a0e7be9bf9f40ea4145d11 |
|
21-Aug-2014 |
robertphillips <robertphillips@google.com> |
SkMultiPictureDraw API This CL adds a new API to optimize across multiple SkPicture draw calls. Note that multiple pictures rendered at once (i.e., picture piles) should be flattened into a single new picture that includes the required clipping on the different layers. R=bsalomon@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/491313003
/external/skia/include/core/SkMultiPictureDraw.h
|