bd8b25a7b4c20d7a612fbb6af9586ec994609202 |
|
21-Feb-2018 |
Cary Clark <caryclark@skia.org> |
writePixels should notify GPU that pixels have changed R=reed@google.com,robertphillips@google.com Bug: skia:7644 Change-Id: I469c537a649e4d8d05a78cedb26caa3057d824c1 Reviewed-on: https://skia-review.googlesource.com/108961 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
/external/skia/src/core/SkBitmap.cpp
|
80747ef591ff3c09c2b610eb21258132d1ff4ef5 |
|
23-Jan-2018 |
Mike Reed <reed@google.com> |
move the guts of SkMaskFilter.h into SkMaskFilterBase.h Bug: skia: Change-Id: I29ad0960156562867429542d3cfbf3d639529cab Reviewed-on: https://skia-review.googlesource.com/98802 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkBitmap.cpp
|
cff9ab7d9804804f0805b59ca5712f70b2d93bb2 |
|
12-Jan-2018 |
Hal Canary <halcanary@google.com> |
Bitmap: clearing pixelref keeps rowbytes Change-Id: Ibf8b69adcb4e9df597079a8d9ada75b4a31194e6 Reviewed-on: https://skia-review.googlesource.com/94040 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkBitmap.cpp
|
99578d24c0abd5b0e4fa2fc40b44fbec0c2bd627 |
|
15-Dec-2017 |
Hal Canary <halcanary@google.com> |
SkBitmap now *has* a SkPixmap. Before: class SkBitmap { sk_sp<SkPixelRef> fPixelRef; void* fPixels; SkImageInfo fInfo; uint32_t fRowBytes; uint8_t fFlags; }; After: class SkBitmap { sk_sp<SkPixelRef> fPixelRef; SkPixmap fPixmap; uint8_t fFlags; }; Change-Id: I62d59ca3e702b7adea022cd3cfbf0cc3186af957 Reviewed-on: https://skia-review.googlesource.com/85560 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmap.cpp
|
3c7d882c483b693124f94c07253807422583080f |
|
05-Jan-2018 |
Hal Canary <halcanary@google.com> |
SkBitmap::fPixelRefOrigin removed Motivation: makes SkBitmap 8 bytes smaller. fPixelRefOrigin is rarely used, and can be recaluated when needed. Also, remove two of SkBitmap's private methods and fold in their functions. Change-Id: I2cddb9e4b5480404bf6da3edfb0155ab82cf47d2 Reviewed-on: https://skia-review.googlesource.com/91300 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkBitmap.cpp
|
efe7c4920194796e997bff5bdb94e6fade6cb367 |
|
30-Nov-2017 |
Mike Reed <reed@google.com> |
remove read/write rawpixels Bug: skia: Change-Id: I000b70414119355fef0d45de4ae9ef996b8a5568 Reviewed-on: https://skia-review.googlesource.com/77903 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkBitmap.cpp
|
df429f3beac1c191289ba1e3bd918bf84df57bf5 |
|
08-Nov-2017 |
Cary Clark <caryclark@skia.org> |
move parts of SkPoint to SkPointPriv Move specialized SkPoint methods to SkPointPriv. Use constexpr and inline initialization where possible. R=reed@google.com,bsalomon@google.com Bug: skia: 6898 Change-Id: I01ec5186f010f2dc80c068c70d9cc352f3221338 Reviewed-on: https://skia-review.googlesource.com/68700 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
/external/skia/src/core/SkBitmap.cpp
|
f0ffb8943b7be477b769db23660a80013f3332eb |
|
03-Oct-2017 |
Mike Reed <reed@google.com> |
Revert[4] "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap" This reverts commit 5a2e50edc51006ce91366e177a9d21a16775d7fd. Bug: skia: Change-Id: I8d28b5c07d90130e5a1653923740eaf189ecb954 Reviewed-on: https://skia-review.googlesource.com/53900 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
5a2e50edc51006ce91366e177a9d21a16775d7fd |
|
02-Oct-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap""" This reverts commit cd284c532376d16fcc4ed75baf3da65c3e4a2e95. Reason for revert: assert fired in SkMallocPixelRef.cpp:61: fatal error: "assert(info.computeByteSize(rowBytes) == info.getSafeSize(rowBytes))" google3 thinks it was from surface_rowbytes Original change's description: > Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"" > > This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0. > > Bug: skia: > Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d > Reviewed-on: https://skia-review.googlesource.com/52665 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> TBR=fmalita@chromium.org,reed@google.com Change-Id: I41e3f7a3f791cc8183291847e783ed8a53bc91d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/53802 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
cd284c532376d16fcc4ed75baf3da65c3e4a2e95 |
|
29-Sep-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"" This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0. Bug: skia: Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d Reviewed-on: https://skia-review.googlesource.com/52665 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkBitmap.cpp
|
4b85b6dd5a7296f4543b226a534c76ef6f438e55 |
|
29-Sep-2017 |
Cary Clark <caryclark@skia.org> |
fix setPixelRef In setPixelRef() If dx or dy are negative, assert in debug. Pin pixel ref origin to account for dx and dy on right. If colorType is unknown, ignore pr pixelref. Set Bitmap rowbytes to match pixelref rowbytes. In tryAllocPixels() Return true early if colorType is unknown. This assumes that the desired behavior is for Bitmaps set to kUnknown_SkColorType to avoid allocating SkPixelRef while avoiding debug asserts, which is what current gm tests like BitmapCopy_extractSubset test for. R=reed@google.com Change-Id: I0d36032d36a0b7dc111f4aff18c71382874fe1f5 Reviewed-on: https://skia-review.googlesource.com/53420 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
/external/skia/src/core/SkBitmap.cpp
|
809cbedd4b252be221b2ac3b4269d312fd8f53a0 |
|
28-Sep-2017 |
Jim Van Verth <jvanverth@google.com> |
Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap" This reverts commit 88757dacd4f532a0f647c02ae0ee596d31ab5c68. Reason for revert: Still seems to be failing Chromium "telemetry_perf_unittests (with patch) on Android" on android_n5x_swarming_rel. Original change's description: > guard old apis for querying byte-size of a bitmap/imageinfo/pixmap > > Now with legacy behavior for allocpixels > > This was reverted, so the current CL is a "fix" on top of ... > https://skia-review.googlesource.com/c/skia/+/50980 > > Related update to Chrome (in preparation for this change) > https://chromium-review.googlesource.com/c/chromium/src/+/685719 > > Bug: skia: > Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9 > Reviewed-on: https://skia-review.googlesource.com/51341 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@google.com> TBR=fmalita@chromium.org,reed@google.com Change-Id: I827a0ca1d1e3909e648fde3342cdb8601d34da8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/52381 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/core/SkBitmap.cpp
|
88757dacd4f532a0f647c02ae0ee596d31ab5c68 |
|
26-Sep-2017 |
Mike Reed <reed@google.com> |
guard old apis for querying byte-size of a bitmap/imageinfo/pixmap Now with legacy behavior for allocpixels This was reverted, so the current CL is a "fix" on top of ... https://skia-review.googlesource.com/c/skia/+/50980 Related update to Chrome (in preparation for this change) https://chromium-review.googlesource.com/c/chromium/src/+/685719 Bug: skia: Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9 Reviewed-on: https://skia-review.googlesource.com/51341 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
f46633f8af5296341e33ec4cdb69c71dfa997396 |
|
26-Sep-2017 |
Greg Daniel <egdaniel@google.com> |
Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap" This reverts commit 98a6216b18b57c2f7a0d58f542c60503686aed69. Reason for revert: breaking the chrome roll. Looks like they may be writing data to create an image across all the row bytes and thus writing to unalloced data on the last row. Link to example failing bot: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/539960 Original change's description: > guard old apis for querying byte-size of a bitmap/imageinfo/pixmap > > Previously we had size_t and uint64_t variations. > > The new (simpler) API always.. > - returns size_t, or 0 if the calculation overflowed > - returns the trimmed size (does not include rowBytes padding for the last row) > > Bug: skia: > Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e > Reviewed-on: https://skia-review.googlesource.com/50980 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Leon Scroggins <scroggo@google.com> TBR=mtklein@google.com,herb@google.com,scroggo@google.com,fmalita@chromium.org,reed@google.com Change-Id: I726f6ab1b36b14979ba6f37105e0a469b3f0dbc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/51262 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
/external/skia/src/core/SkBitmap.cpp
|
98a6216b18b57c2f7a0d58f542c60503686aed69 |
|
26-Sep-2017 |
Mike Reed <reed@google.com> |
guard old apis for querying byte-size of a bitmap/imageinfo/pixmap Previously we had size_t and uint64_t variations. The new (simpler) API always.. - returns size_t, or 0 if the calculation overflowed - returns the trimmed size (does not include rowBytes padding for the last row) Bug: skia: Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e Reviewed-on: https://skia-review.googlesource.com/50980 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmap.cpp
|
d6c04d9a05c1b4066c09083a673d7d3cf61a3aa6 |
|
25-Sep-2017 |
Mike Klein <mtklein@chromium.org> |
Simplify / fix SkBitmap::ReadRawPixels() We no longer need to look at the field snugRB except to check for the simple no-pixels case. This is good, because our snugRB <= ramRB check is actually too weak, and is the source of this linked Chromium issue. BUG=chromium:765858 Instead of doing complicated checks against that stored snugRB and the computed ramRB, we now just ignore snugRB. We know the images written by write_row_bytes() will be snug, so we can just look at width, height, and color type to figure out exactly how many bytes we should be reading. Then it becomes the call to readByteArray()'s responsibility to make sure that we have an array there of exactly that many bytes to read. We've just got to make sure we check for its failure. Change-Id: Ia05c36d8a77b0de16ee03a80f6cb2dab6fcedbae Reviewed-on: https://skia-review.googlesource.com/50800 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkBitmap.cpp
|
a4083c97d48e8a4f88e2797d7363f141e3d42553 |
|
15-Sep-2017 |
Cary Clark <caryclark@skia.org> |
make most of SkColorPriv.h private created new file src/core/SkColorData.h for internal consumption. Note that many of the functions there are unused as well. Bug: skia: 6898 R: reed@google.com Change-Id: I25bfd5a9c21f53558c4ca65a77eb5d322d897c6d Reviewed-on: https://skia-review.googlesource.com/46848 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
323ae0eb4b8295352b259f8e4bfc80511a2348f9 |
|
25-Jul-2017 |
Mike Reed <reed@google.com> |
trim down colortable impl Bug: skia: Change-Id: I2a7d3719ccde753b723d33231be49b028ff1c313 Reviewed-on: https://skia-review.googlesource.com/26304 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
b7648a27583a2ef775384751fee25ac9cf3db5d5 |
|
19-Jul-2017 |
Mike Reed <reed@google.com> |
removed dead colortable code Bug: skia:6828 Change-Id: I2d3b3b7c846d3ac08bbcb9357cb644873fe5a286 Reviewed-on: https://skia-review.googlesource.com/24623 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmap.cpp
|
086a427b0cee3862f25c492fc5082ff24105dc53 |
|
18-Jul-2017 |
Mike Reed <reed@google.com> |
guard references to SkColorTable Bug: skia:6828 Change-Id: I0c8c78e70b118f51cb59dc45675e4ddcd4776108 Reviewed-on: https://skia-review.googlesource.com/24260 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmap.cpp
|
26e9dddf590bff620de38de752f15534b09ff951 |
|
17-Jul-2017 |
Mike Reed <reed@google.com> |
Don't store colortables in pixmaps or pixelrefs Lots more changes coming later (need to remove colortable parameters from bitmaps and pixmaps) Bug: skia:6828 Change-Id: Ic63e89570644839fab068141f49915b3f66d1053 Reviewed-on: https://skia-review.googlesource.com/24127 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
262b319dcdbf6329d5ca3212b22323ebec7a7b49 |
|
17-Jul-2017 |
Mike Reed <reed@google.com> |
Index8 is dead, remove guarded code Needs google3 to be updated before this can land. Bug: skia:6828 Change-Id: I2c16be13c6937ffa48768cc24f9f980171c824d6 Reviewed-on: https://skia-review.googlesource.com/23940 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
580501382fb1418fff7acc63680f3a9a6bf3938c |
|
13-Jul-2017 |
Mike Reed <reed@google.com> |
Guard to remove kIndex_8_SkColorType Bug: skia:6828 Change-Id: Ia942a36abb18213184f8d436555a658270d97d47 Reviewed-on: https://skia-review.googlesource.com/22721 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/core/SkBitmap.cpp
|
3928ff8e0b617c3a00eee1963bc31ce5470fba6d |
|
06-Jun-2017 |
Matt Sarett <msarett@google.com> |
Create an SkColorSpaceXform image generator This should be immediately useful in the Skia-Android rendering pipeline. Possible future uses include creating a "renderable" SkImage from a bitmap with a funny color space. Inspired by: https://skia-review.googlesource.com/c/13981/ Bug: b/62347704 Change-Id: I388c7af1fc43834b8ad22022d0caf3ac90b734c8 Reviewed-on: https://skia-review.googlesource.com/18598 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
56269ef4ac5927d94d73eb2f4f637f6686d0f722 |
|
09-May-2017 |
Leon Scroggins III <scroggo@google.com> |
Remove comments referencing locked pixels Pixels no longer need to be locked. TBR=reed@google.com Bug: skia: 6481 Change-Id: I4b49f710add9134205d1520755b44bee308bd502 Reviewed-on: https://skia-review.googlesource.com/16113 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmap.cpp
|
85591831b2fc0f67968116d73c79ee1232a59935 |
|
03-May-2017 |
Matt Sarett <msarett@google.com> |
Delete SkBitmap::copyTo() Bug: skia:6465 Change-Id: Ied95fe3aaed9126906fde15bfda73bd6597e3347 Reviewed-on: https://skia-review.googlesource.com/15220 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
d170c0fb48aa1e1a00d183d72f9e53ea9bb4d951 |
|
01-May-2017 |
Matt Sarett <msarett@google.com> |
Only store width and height on SkPixelRef (last part) Relanding https://skia-review.googlesource.com/c/14105/ in pieces to try to diagnose problems with the Chrome roll. Bug: skia:6535 Change-Id: Iefe4825b9ce9be999baeec8ab7ae6651f1caf451 Reviewed-on: https://skia-review.googlesource.com/14860 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
f758311c7362d9232b98b6519ec0af1f71ad02f8 |
|
01-May-2017 |
Matt Sarett <msarett@google.com> |
Only store width and height on SkPixelRef (part 2) Relanding https://skia-review.googlesource.com/c/14105/ in pieces to try to diagnose problems with the Chrome roll. Bug: skia:6535 Change-Id: Iada034fc41ef315f7f00984d8de9d9cc2f361ad2 Reviewed-on: https://skia-review.googlesource.com/14657 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
2fcd4a480deecb23e9fdde07e63d18d2735c9287 |
|
28-Apr-2017 |
Ben Wagner <benjaminwagner@google.com> |
Revert "Only store width and height on SkPixelRef" This reverts commit 2cbb6662e329981840f90ef4edd62f70f69e6030. Reason for revert: Likely cause of Chromium DEPS roll failure; speculative revert. Original change's description: > Only store width and height on SkPixelRef > > Bug: skia:6535 > Change-Id: Id91e8d1e82f593be7d4b23ca5abde752f2666a77 > Reviewed-on: https://skia-review.googlesource.com/14105 > Commit-Queue: Matt Sarett <msarett@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=djsollen@google.com,msarett@google.com,reed@google.com,stani@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I12a024a71833f33432d5ea8cffdfc642b8b4240a Bug: skia: Reviewed-on: https://skia-review.googlesource.com/14644 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
/external/skia/src/core/SkBitmap.cpp
|
68b8e3d50d0954eb5eeb7f625f06026c7fbd38c1 |
|
28-Apr-2017 |
Matt Sarett <msarett@google.com> |
Revert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag"" This reverts commit 0122af08f6af0dee490e1a4f35b552377d0d4753. Reason for revert: Fixed Android callsite Original change's description: > Revert "Delete copyTo(Allocator), hide copyTo() behind flag" > > This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971. > > Reason for revert: Looks like I missed something I was supposed to delete in Android. > > Original change's description: > > Delete copyTo(Allocator), hide copyTo() behind flag > > > > Replace uses of copyTo() in Skia. > > > > Bug: skia:6464 > > Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548 > > Reviewed-on: https://skia-review.googlesource.com/14502 > > Commit-Queue: Matt Sarett <msarett@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > > > TBR=msarett@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e > Reviewed-on: https://skia-review.googlesource.com/14602 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,reviews@skia.org,reed@google.com Change-Id: I81659a820f79f1958fda23cb62513065b57db99d Reviewed-on: https://skia-review.googlesource.com/14640 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
2cbb6662e329981840f90ef4edd62f70f69e6030 |
|
27-Apr-2017 |
Matt Sarett <msarett@google.com> |
Only store width and height on SkPixelRef Bug: skia:6535 Change-Id: Id91e8d1e82f593be7d4b23ca5abde752f2666a77 Reviewed-on: https://skia-review.googlesource.com/14105 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
0122af08f6af0dee490e1a4f35b552377d0d4753 |
|
27-Apr-2017 |
Matt Sarett <msarett@google.com> |
Revert "Delete copyTo(Allocator), hide copyTo() behind flag" This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971. Reason for revert: Looks like I missed something I was supposed to delete in Android. Original change's description: > Delete copyTo(Allocator), hide copyTo() behind flag > > Replace uses of copyTo() in Skia. > > Bug: skia:6464 > Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548 > Reviewed-on: https://skia-review.googlesource.com/14502 > Commit-Queue: Matt Sarett <msarett@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=msarett@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e Reviewed-on: https://skia-review.googlesource.com/14602 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
d4a338f4d0a0cdc08d7d3668931c60997f0fa971 |
|
27-Apr-2017 |
Matt Sarett <msarett@google.com> |
Delete copyTo(Allocator), hide copyTo() behind flag Replace uses of copyTo() in Skia. Bug: skia:6464 Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548 Reviewed-on: https://skia-review.googlesource.com/14502 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
ad8b5dc69cd613cc8974999f9e7c94a19eb01fec |
|
20-Apr-2017 |
Mike Reed <reed@google.com> |
remove vestigle code for lockpixels Bug: skia:6481 Change-Id: Icfd53981b8588fbea74fca2e3be58bc6f13ef923 Reviewed-on: https://skia-review.googlesource.com/13968 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
4edb5d219eb99aa1e8fbe5e37260d3b34314e54b |
|
17-Apr-2017 |
Mike Reed <reed@google.com> |
hide lockpixels api behind flag guarded by SK_SUPPORT_OBSOLETE_LOCKPIXELS needs https://codereview.chromium.org/2820873002/# to land first Bug: skia:6481 Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09 Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09 Reviewed-on: https://skia-review.googlesource.com/13580 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
b712089b93fadf3f3b560e9b21803f4c7626c94e |
|
14-Apr-2017 |
Mike Reed <reed@google.com> |
remove lock tracking in bitmaps -- they are always locked Bug: skia:6481 Change-Id: I551c9fd5cdf1ea99fc62042d24d638a1021c348d Reviewed-on: https://skia-review.googlesource.com/13473 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
818580d81b4a80071b5150e0febdf2fbe3826413 |
|
13-Apr-2017 |
Mike Reed <reed@google.com> |
remove code directly involved in lock/unlock in SkPixelRef Bug: skia:6481 Change-Id: I3c301ad42b082e04e233aa32d77862036fe998fa Reviewed-on: https://skia-review.googlesource.com/13463 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
96d5b9a273a5513fb3215fc06452cda82c3d6872 |
|
13-Apr-2017 |
Mike Reed <reed@google.com> |
remove unused fURI from pixelref Bug: skia: Change-Id: Ib25569862063b765b823b68ffdc22349a606f940 Reviewed-on: https://skia-review.googlesource.com/13324 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
8f30709e93ba377a0bf77f24aeae890d38b66e52 |
|
12-Apr-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "remove unused SkBitmap::copyPixelsTo"" This reverts commit 7bfdfda809e7273d7c962cc62ef9390b5007fb5a. Reason for revert: google3 has been updated Original change's description: > Revert "remove unused SkBitmap::copyPixelsTo" > > This reverts commit 0f3fdfacf32261f943dcac5cdfd14475011f40db. > > Reason for revert: Blink-headless in Google3 needs an update too. > > Original change's description: > > remove unused SkBitmap::copyPixelsTo > > > > Needs https://codereview.chromium.org/2812853002/ to land first > > > > Bug: skia:6465 > > Change-Id: I531e33b2848cd995f20844786ed1a8d34d63fb64 > > Reviewed-on: https://skia-review.googlesource.com/13171 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Mike Reed <reed@google.com> > > > > TBR=reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I5e7c4b0d05772e4948cb1dffdcc40e095fbdba41 > Reviewed-on: https://skia-review.googlesource.com/13185 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> > TBR=mtklein@google.com,reviews@skia.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Id441cec351fe580cbb00739ca9544aa5276cf16a Reviewed-on: https://skia-review.googlesource.com/13224 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
7bfdfda809e7273d7c962cc62ef9390b5007fb5a |
|
11-Apr-2017 |
Mike Klein <mtklein@google.com> |
Revert "remove unused SkBitmap::copyPixelsTo" This reverts commit 0f3fdfacf32261f943dcac5cdfd14475011f40db. Reason for revert: Blink-headless in Google3 needs an update too. Original change's description: > remove unused SkBitmap::copyPixelsTo > > Needs https://codereview.chromium.org/2812853002/ to land first > > Bug: skia:6465 > Change-Id: I531e33b2848cd995f20844786ed1a8d34d63fb64 > Reviewed-on: https://skia-review.googlesource.com/13171 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I5e7c4b0d05772e4948cb1dffdcc40e095fbdba41 Reviewed-on: https://skia-review.googlesource.com/13185 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
/external/skia/src/core/SkBitmap.cpp
|
0f3fdfacf32261f943dcac5cdfd14475011f40db |
|
11-Apr-2017 |
Mike Reed <reed@google.com> |
remove unused SkBitmap::copyPixelsTo Needs https://codereview.chromium.org/2812853002/ to land first Bug: skia:6465 Change-Id: I531e33b2848cd995f20844786ed1a8d34d63fb64 Reviewed-on: https://skia-review.googlesource.com/13171 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
c8e924c236b1b18062d4b219c6ab198d12e30d30 |
|
10-Apr-2017 |
Mike Reed <reed@google.com> |
remove unused lockPixelsAreWritable Bug: skia:4328 Change-Id: I7271a95a52fe6e5de781f83e0d48af5b69892a95 Reviewed-on: https://skia-review.googlesource.com/13066 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
42ce38f866a25ae84fe167987fe9ca69e9cdc607 |
|
06-Apr-2017 |
Mike Reed <reed@google.com> |
make copyTo_with_allocator android only Bug: skia:6464 Change-Id: I3d95daae2ae854671e6231e62f200913ce3586d0 Reviewed-on: https://skia-review.googlesource.com/11486 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
dc57b5d49647b6f6685df998ee7d81200ba7f652 |
|
05-Apr-2017 |
Mike Reed <reed@google.com> |
remove SK_SUPPORT_LEGACY_BITMAP_SETPIXELREF flag and code Bug: skia: Change-Id: I234d221d685a6feab891cbca84869177b4a954bb Reviewed-on: https://skia-review.googlesource.com/11404 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
d9836f44fb8b0482f6d0aaebf92d721200150c3d |
|
05-Apr-2017 |
Matt Sarett <msarett@google.com> |
Fix various SkBitmap::copyTo() bugs I believe that the best fix is to move this entire function into the framework and call SkPixmap::readPixels() from there. Given that, we have already branched, I think this is the simplest fix. (1) We never added F16 support. Enable F16. This involves assigning color spaces to src and dst pixmaps so that the conversion makes sense. (2) SkPixmap::readPixels() does not support parametric transfer functions. Fortunately, the framework never uses copyTo() to do color space conversions. We should at least support the case where the src color space matches the dst color space. Bug: skia: Change-Id: I129b7c02249eed34a9ec4aa0ca736aadccc19777 Reviewed-on: https://skia-review.googlesource.com/11387 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkBitmap.cpp
|
1987366b3c0a9dd9280620e62e0edb7d5087a828 |
|
05-Apr-2017 |
Matt Sarett <msarett@google.com> |
Delete SkPixelRef::readPixels() Nobody calls this or overrides this. Bug: skia: Change-Id: I6235e4c7bcdc45523ce7f63842635c79e00d2dc4 Reviewed-on: https://skia-review.googlesource.com/11357 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
6b3155c4be0476bc53541b0431c368a44e69f0a7 |
|
03-Apr-2017 |
Mike Reed <reed@google.com> |
Revert[4] "clean up (partially) colortable api"""" Fixes: - create temp api for android to pass nullptr - don't release and access sk_sp<SkData> at the same time in parameters This reverts commit b14131c1851eea6acbd34cc42a8f860daed36b21. Bug: skia: Change-Id: Ic0e4f62520ba9f35455499ed30d306ad19d998a8 Reviewed-on: https://skia-review.googlesource.com/11129 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
b14131c1851eea6acbd34cc42a8f860daed36b21 |
|
01-Apr-2017 |
Mike Reed <reed@google.com> |
Revert "Revert[2] "clean up (partially) colortable api""" This reverts commit 9920b10f5292838f00600f676c4578cd11705e60. Reason for revert: trying to get details on w2k failure https://chromium-swarm.appspot.com/task?id=354345d34ba3b310&refresh=10 Caught exception 3221225477 EXCEPTION_ACCESS_VIOLATION, was running: unit test HugeBlurImageFilter unit test FontNames unit test Codec_PngRoundTrip unit test ClampRange unit test FontHost unit test ColorMatrixFilter f16 image scaled_codec_premul abnormal.wbmp 565 image brd_android_codec_divisor_0.167 interlaced3.png_0.167 unit test Codec_png unit test ImageFilterBlurLargeImage unit test FontObj unit test DrawText unit test GrShape 565 image brd_android_codec_divisor_0.333 interlaced2.png_0.333 unit test PathOpsOpCubicsThreaded unit test PathOpsOpLoopsThreaded unit test FontMgr unit test ColorToHSVRoundTrip unit test Image_Serialize_Encoding_Failure Likely culprit: unit test Image_Serialize_Encoding_Failure step returned non-zero exit code: -1073741819 Original change's description: > Revert[2] "clean up (partially) colortable api"" > > This reverts commit 1d1165ca6575e082b892c5460492c411618783ad. > > Bug: skia: > Change-Id: Idbc0634ae3cec2e79f592d252de8751b077e6408 > Reviewed-on: https://skia-review.googlesource.com/11024 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia4e73434b083224baa36092c69526c2f59bb16aa Reviewed-on: https://skia-review.googlesource.com/11025 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
9920b10f5292838f00600f676c4578cd11705e60 |
|
01-Apr-2017 |
Mike Reed <reed@google.com> |
Revert[2] "clean up (partially) colortable api"" This reverts commit 1d1165ca6575e082b892c5460492c411618783ad. Bug: skia: Change-Id: Idbc0634ae3cec2e79f592d252de8751b077e6408 Reviewed-on: https://skia-review.googlesource.com/11024 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
1d1165ca6575e082b892c5460492c411618783ad |
|
31-Mar-2017 |
Mike Klein <mtklein@chromium.org> |
Revert "clean up (partially) colortable api" This reverts commit 2e491a6a113c5e16a3b7bede5fa6f588deeb928d. Reason for revert: Windows unit tests failing? Original change's description: > clean up (partially) colortable api > > Needs this to land: https://codereview.chromium.org/2789853002/ > > Bug: skia: > Change-Id: I38d916a546b7fa64d000d973e695ddda24a589e7 > Reviewed-on: https://skia-review.googlesource.com/10600 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,scroggo@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I626e7edfcea82576a440dcaa851a04cedee6233f Reviewed-on: https://skia-review.googlesource.com/10966 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkBitmap.cpp
|
2e491a6a113c5e16a3b7bede5fa6f588deeb928d |
|
31-Mar-2017 |
Mike Reed <reed@google.com> |
clean up (partially) colortable api Needs this to land: https://codereview.chromium.org/2789853002/ Bug: skia: Change-Id: I38d916a546b7fa64d000d973e695ddda24a589e7 Reviewed-on: https://skia-review.googlesource.com/10600 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
d2adc66efec8a172b71bf5572fbedde064025825 |
|
27-Mar-2017 |
Matt Sarett <msarett@google.com> |
Use SkTransferFunctionBehavior for raster pixel conversions Fixes some gbr-8888 behaviors. BUG=skia: Change-Id: I1351b043129f7ed0e125bfdb626a0ecaf64c15cc Reviewed-on: https://skia-review.googlesource.com/10169 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
dce25909ac0e84ee73640fd49dd3b82f66dd4ce1 |
|
14-Mar-2017 |
Leon Scroggins III <scroggo@google.com> |
Remove unused SkBitmap::RLEPixels TBR=reed@google.com Change-Id: I14a75b7cad89aa7eb4b146a5d269856a4ad5d821 Reviewed-on: https://skia-review.googlesource.com/9646 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmap.cpp
|
485c499a2797c1eb0e750fa4aaec57192799b424 |
|
14-Feb-2017 |
Matt Sarett <msarett@google.com> |
Rename SkConfig8888/SkPixelInfo to SkConvertPixels BUG=skia: Change-Id: I4f3c6370b3ef4247aa446716c7c154899925d089 Reviewed-on: https://skia-review.googlesource.com/8442 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkBitmap.cpp
|
8572d853514e3c73077540341edbf62a3f486605 |
|
14-Feb-2017 |
Matt Sarett <msarett@google.com> |
Make raster pipeline support all pixel conversions BUG=skia: CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: Idc76999d0f5591a567b3976cb9db829c350e4be2 Reviewed-on: https://skia-review.googlesource.com/8304 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
03dd6d5208a6e3d92190e7020300e4399178ae4b |
|
23-Jan-2017 |
Matt Sarett <msarett@google.com> |
Reland "Refactor trimming logic for read/writePixels()" Original CL: https://skia-review.googlesource.com/c/7326/ (1) Move trimming logic into Bitmap/Pixmap level for raster. Everything goes through here, so we'll only do the work once. (2) This means it also goes to GPU level. (3) Always use SkReadPixelsRec rather than inlining the logic. (4) Create an SkWritePixelsRec to encapsulate write trimming. (5) Disabled kIndex8 as a dst - always. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug BUG=skia:6021 Change-Id: I25a964e3c610c4e36d195a255e2150657baec649 Reviewed-on: https://skia-review.googlesource.com/7404 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
26ecfe0af8da1d17a079e17af85c5c576bfeca84 |
|
23-Jan-2017 |
Matt Sarett <msarett@google.com> |
Revert "Refactor trimming logic for read/writePixels()" This reverts commit 977f64cbfad1ecd7fd4b1231c694c7e828fda1f0. Reason for revert: Triggering nanobench asserts Original change's description: > Refactor trimming logic for read/writePixels() > > (1) Move trimming logic into Bitmap/Pixmap level for > raster. Everything goes through here, so we'll > only do the work once. > (2) This means it also goes to GPU level. > (3) Always use SkReadPixelsRec rather than inlining > the logic. > (4) Create an SkWritePixelsRec to encapsulate write > trimming. > (5) Disabled kIndex8 as a dst - always. > > BUG=skia:6021 > > Change-Id: I748f50c3b726f7c6de5462e2b1ccb54bc387a510 > Reviewed-on: https://skia-review.googlesource.com/7326 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,brianosman@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6021 Change-Id: If9aacc6ce8b20e3dfe8a0f22ebca653f28356175 Reviewed-on: https://skia-review.googlesource.com/7379 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
977f64cbfad1ecd7fd4b1231c694c7e828fda1f0 |
|
20-Jan-2017 |
Matt Sarett <msarett@google.com> |
Refactor trimming logic for read/writePixels() (1) Move trimming logic into Bitmap/Pixmap level for raster. Everything goes through here, so we'll only do the work once. (2) This means it also goes to GPU level. (3) Always use SkReadPixelsRec rather than inlining the logic. (4) Create an SkWritePixelsRec to encapsulate write trimming. (5) Disabled kIndex8 as a dst - always. BUG=skia:6021 Change-Id: I748f50c3b726f7c6de5462e2b1ccb54bc387a510 Reviewed-on: https://skia-review.googlesource.com/7326 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
cb6266b5aa5bbfd880532f08eec83b0c585e873f |
|
17-Jan-2017 |
Matt Sarett <msarett@google.com> |
Reland "Add SkImageInfoValidConversion() and SkImageInfoIsValid" The original is at: https://skia-review.googlesource.com/c/6887/ The only change to the original is to temporarily comment out a check in SkImageInfoPriv.h until a Chrome unit test can be fixed. The idea is share these standards for the following: SkImage::readPixels() SkCanvas::readPixels() SkCanvas::writePixels() SkBitmap::readPixels() SkPixmap::readPixels() On the raster side, SkPixmap::readPixels() is the right place to check, because all raster calls go through there eventually. Then at lower levels (ex: SkPixelInfo), we can assert. There's not really a unifying location for gpu calls, so I've added this in multiple places. I haven't really dug into the gpu code to SkASSERT() on invalid cases that we will have already caught. Follow-up work: Similar refactor for SkReadPixelRec::trim(). Code cleanup in SkPixelInfo::CopyPixels() BUG=skia:6021 Change-Id: I6a16f9479bc09e3c87e10c72b0378579f1a70866 Reviewed-on: https://skia-review.googlesource.com/7104 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkBitmap.cpp
|
7a6c9f7be115031a8a86fdae20e8869fd973fdb6 |
|
15-Jan-2017 |
Brian Osman <brianosman@google.com> |
Revert "Add SkImageInfoValidConversion() and SkImageInfoIsValid" This reverts commit cf5d6caff7a58f1c7ecc36d9a91ccdada5fc7b78. Reason for revert: Chrome DEPS roll failing, based on the unit tests, I suspect this is the cause. Original change's description: > Add SkImageInfoValidConversion() and SkImageInfoIsValid > > The idea is share these standards for the following: > SkImage::readPixels() > SkCanvas::readPixels() > SkCanvas::writePixels() > SkBitmap::readPixels() > SkPixmap::readPixels() > > On the raster side, SkPixmap::readPixels() is the right > place to check, because all raster calls go through > there eventually. Then at lower levels (ex: SkPixelInfo), > we can assert. > > There's not really a unifying location for gpu calls, > so I've added this in multiple places. I haven't really > dug into the gpu code to SkASSERT() on invalid cases > that we will have already caught. > > Follow-up work: > Similar refactor for SkReadPixelRec::trim(). > Code cleanup in SkPixelInfo::CopyPixels() > > BUG=skia:6021 > > Change-Id: I91ecce10e46c1a6530f0af24a9eb8226dbecaaa2 > Reviewed-on: https://skia-review.googlesource.com/6887 > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=mtklein@google.com,msarett@google.com,brianosman@google.com,reed@google.com,reviews@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia:6021 Change-Id: I63b88e90bdbb3051a14de00ac73a8351ab776d25 Reviewed-on: https://skia-review.googlesource.com/7095 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkBitmap.cpp
|
cf5d6caff7a58f1c7ecc36d9a91ccdada5fc7b78 |
|
13-Jan-2017 |
Matt Sarett <msarett@google.com> |
Add SkImageInfoValidConversion() and SkImageInfoIsValid The idea is share these standards for the following: SkImage::readPixels() SkCanvas::readPixels() SkCanvas::writePixels() SkBitmap::readPixels() SkPixmap::readPixels() On the raster side, SkPixmap::readPixels() is the right place to check, because all raster calls go through there eventually. Then at lower levels (ex: SkPixelInfo), we can assert. There's not really a unifying location for gpu calls, so I've added this in multiple places. I haven't really dug into the gpu code to SkASSERT() on invalid cases that we will have already caught. Follow-up work: Similar refactor for SkReadPixelRec::trim(). Code cleanup in SkPixelInfo::CopyPixels() BUG=skia:6021 Change-Id: I91ecce10e46c1a6530f0af24a9eb8226dbecaaa2 Reviewed-on: https://skia-review.googlesource.com/6887 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
68dd8d0e083e71042056163f6105d9ee103eea54 |
|
04-Jan-2017 |
Mike Reed <reed@google.com> |
add writePixels to SkBitmap BUG=skia: Change-Id: I6f4db9ddc0364d9785e0f1794d86b73e66845ea9 Reviewed-on: https://skia-review.googlesource.com/6593 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkBitmap.cpp
|
b2cb53589b81b450056732b524706fad39bfca1a |
|
20-Dec-2016 |
Robert Phillips <robertphillips@google.com> |
Fix more Skia filter fuzzer bugs This CL fixes 3 fuzzer bugs: the rowBytes computation is really unfortunate in ReadRawPixels when width or height is negative In two instances uints were being read through the underlying SkReader32 rather than going through the readUInt virtual In skip SkAlign4 can wrap around and return an answer of 0 for large size_ts!! Change-Id: I657e3afdb4804627604b59abc8008ccdfe47eab2 Reviewed-on: https://skia-review.googlesource.com/6332 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBitmap.cpp
|
1b3387b5cfef150c3237c6a8700b2d6f3730e4ce |
|
12-Dec-2016 |
Hal Canary <halcanary@google.com> |
SkBitmap::setPixelRef(): less reference churn BUG=skia: Change-Id: I9657e4af5fcc808f9175ff336155374ccc77999d Reviewed-on: https://skia-review.googlesource.com/5461 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkBitmap.cpp
|
58a769490a4593a93b08031365b88be7a5ecfa0e |
|
07-Dec-2016 |
Hal Canary <halcanary@google.com> |
SkBitmap::ComputeIsOpaque -> SkPixmap::computeIsOpaque Motivation: Twice internal Skia clients have to do something awkward like this: bool ComputeIsOpaque(const SkPixmap& pixmap) { SkBitmap bm; return bm.installPixels(pixmap) && SkBitmap::ComputeIsOpaque(bm); } Change-Id: I7263c06f754c1305ecb07c4c005d9cfb9d1f523d Reviewed-on: https://skia-review.googlesource.com/5684 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkBitmap.cpp
|
4cba3fe576de7f48edd0271498745462564fdd6d |
|
07-Dec-2016 |
Hal Canary <halcanary@google.com> |
SkBitmap::ComputeIsOpaque and SkBitmap::eraseColor support F16 Also add a unit test. Change-Id: I9b6635ce9dd504788ca36b3246eaac2b37c2f3a6 Reviewed-on: https://skia-review.googlesource.com/5443 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
22f348281a202f79989447cfde45a3834649e89f |
|
28-Nov-2016 |
Mike Reed <reed@google.com> |
don't support converting from alpha to non-alpha BUG=skia: Change-Id: Ia06bef6c0bfc03b5ca9f569c07e993da0bbd67c3 Reviewed-on: https://skia-review.googlesource.com/5288 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmap.cpp
|
704cd32e4a92d6c3eae6bfae4adcc20126bf4437 |
|
07-Nov-2016 |
Hal Canary <halcanary@google.com> |
src/core: s/SkAutoTUnref/sk_sp/g BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4492 Change-Id: I753ad01b03e891221965252e3befe280d09cdb9f Reviewed-on: https://skia-review.googlesource.com/4492 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkBitmap.cpp
|
94e1a2fa4a8fdbd53f1b2778f2d6793fe49ce7ca |
|
31-Oct-2016 |
Hal Canary <halcanary@google.com> |
SkPixmap::getColor() Implement SkBitmap::getColor() in terms of SkPixmap::getColor(). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4160 Change-Id: I6192a7979d82b3d301a06ae1339bcab4c7ebf7c1 Reviewed-on: https://skia-review.googlesource.com/4160 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkBitmap.cpp
|
a2415accf1f184c4df6cffc2ccdd38f8d61031f6 |
|
11-Oct-2016 |
lsalzman <lsalzman@mozilla.com> |
implement A8 destination fast-path for SkPixelInfo::CopyPixels BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2407093002 Review-Url: https://codereview.chromium.org/2407093002
/external/skia/src/core/SkBitmap.cpp
|
8ae991e433d2c0814ea5579613f00173805ff057 |
|
22-Aug-2016 |
mtklein <mtklein@chromium.org> |
Flush denorm half floats to zero. I think we convinced ourselves that denorms, while a good chunk of half floats, cover a rather small fraction of the representable range, which is always close enough to zero to flush. This makes both paths of the conversion to or from float considerably simpler. These functions now work for zero-or-normal half floats (excluding infinite, NaN). I'm not aware of a term for this class so I've called them "ordinary". A handful of GMs and SKPs draw differently in --config f16, but all imperceptibly. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256023002 Review-Url: https://codereview.chromium.org/2256023002
/external/skia/src/core/SkBitmap.cpp
|
7fd93e349ad20fb83433cdaafb1502f5eb255fd7 |
|
26-Jul-2016 |
mtklein <mtklein@chromium.org> |
Start measuring f16 and srgb speed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181073003 Review-Url: https://codereview.chromium.org/2181073003
/external/skia/src/core/SkBitmap.cpp
|
c7ec7c9cabf5c8ad08beb617b99831ece25dacdd |
|
25-Jul-2016 |
reed <reed@google.com> |
remove/deprecate SkBitmap::getTexture, as it now always returns false oh happy day BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002 Review-Url: https://codereview.chromium.org/2175873002
/external/skia/src/core/SkBitmap.cpp
|
58e389b0518b46bbe58ba01c23443cf23c18435c |
|
15-Jul-2016 |
mtklein <mtklein@chromium.org> |
Expand _01 half<->float limitation to _finite. Simplify. It's become clear we need to sometimes deal with values <0 or >1. I'm not yet convinced we care about NaN or +-inf. We had some fairly clever tricks and optimizations here for NEON and SSE. I've thrown them out in favor of a single implementation. If we find the specializations mattered, we can certainly figure out how to extend them to this new range/domain. This happens to add a vectorized float -> half for ARMv7, which was missing from the _01 version. (The SSE strategy was not portable to platforms that flush denorm floats to zero.) I've tested the full float range for FloatToHalf on my desktop and a 5x. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145663003 CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot Committed: https://skia.googlesource.com/skia/+/3296bee70d074bb8094b3229dbe12fa016657e90 Review-Url: https://codereview.chromium.org/2145663003
/external/skia/src/core/SkBitmap.cpp
|
64bbad360f30930befafee1bdefe4ad89f130dac |
|
14-Jul-2016 |
mtklein <mtklein@google.com> |
Revert of Expand _01 half<->float limitation to _finite. Simplify. (patchset #7 id:120001 of https://codereview.chromium.org/2145663003/ ) Reason for revert: Unit tests fail on Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast Original issue's description: > Expand _01 half<->float limitation to _finite. Simplify. > > It's become clear we need to sometimes deal with values <0 or >1. > I'm not yet convinced we care about NaN or +-inf. > > We had some fairly clever tricks and optimizations here for NEON > and SSE. I've thrown them out in favor of a single implementation. > If we find the specializations mattered, we can certainly figure out > how to extend them to this new range/domain. > > This happens to add a vectorized float -> half for ARMv7, which was > missing from the _01 version. (The SSE strategy was not portable to > platforms that flush denorm floats to zero.) > > I've tested the full float range for FloatToHalf on my desktop and a 5x. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145663003 > CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot > > Committed: https://skia.googlesource.com/skia/+/3296bee70d074bb8094b3229dbe12fa016657e90 TBR=msarett@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2151023003
/external/skia/src/core/SkBitmap.cpp
|
3296bee70d074bb8094b3229dbe12fa016657e90 |
|
14-Jul-2016 |
mtklein <mtklein@chromium.org> |
Expand _01 half<->float limitation to _finite. Simplify. It's become clear we need to sometimes deal with values <0 or >1. I'm not yet convinced we care about NaN or +-inf. We had some fairly clever tricks and optimizations here for NEON and SSE. I've thrown them out in favor of a single implementation. If we find the specializations mattered, we can certainly figure out how to extend them to this new range/domain. This happens to add a vectorized float -> half for ARMv7, which was missing from the _01 version. (The SSE strategy was not portable to platforms that flush denorm floats to zero.) I've tested the full float range for FloatToHalf on my desktop and a 5x. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145663003 CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2145663003
/external/skia/src/core/SkBitmap.cpp
|
74139f1b49d02b38006170c3e50439c1b33b175f |
|
28-Jun-2016 |
robertphillips <robertphillips@google.com> |
Address two fuzzer bugs: SkImageInfos that were made invalid weren't being caught Messing with the size of a SAVE record wasn't being caught GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104973003 Review-Url: https://codereview.chromium.org/2104973003
/external/skia/src/core/SkBitmap.cpp
|
b109b8c5ec40a7dd85a0a2951a1f98fa63b805aa |
|
16-Jun-2016 |
brianosman <brianosman@google.com> |
Lots of progress on switching to SkColorSpace rather than SkColorProfileType Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002 Committed: https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170 Review-Url: https://codereview.chromium.org/2069173002
/external/skia/src/core/SkBitmap.cpp
|
ab8241880d09eb1774b4993ca6df048a27b7020c |
|
16-Jun-2016 |
brianosman <brianosman@google.com> |
Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType (patchset #10 id:180001 of https://codereview.chromium.org/2069173002/ ) Reason for revert: Mac crashes in GrUploadPixmapToTexture Original issue's description: > Lots of progress on switching to SkColorSpace rather than SkColorProfileType > > Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002 > > Committed: https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170 TBR=reed@google.com,herb@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2072813002
/external/skia/src/core/SkBitmap.cpp
|
6a61a875467646f8dbc37cfecf49e12d1f475170 |
|
16-Jun-2016 |
brianosman <brianosman@google.com> |
Lots of progress on switching to SkColorSpace rather than SkColorProfileType Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002 Review-Url: https://codereview.chromium.org/2069173002
/external/skia/src/core/SkBitmap.cpp
|
0881fb545c7fe53d9572c22167458efdf9deece5 |
|
27-May-2016 |
msarett <msarett@google.com> |
Rewrite assignment operator on SkBitmap, fix asan TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2020683002 Review-Url: https://codereview.chromium.org/2020683002
/external/skia/src/core/SkBitmap.cpp
|
23c5110ba291cfc303e3fdc73af99cd3d595df67 |
|
27-May-2016 |
msarett <msarett@google.com> |
Add SkColorSpace to SkImageInfo BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=2000713003 Review-Url: https://codereview.chromium.org/2000713003
/external/skia/src/core/SkBitmap.cpp
|
b5d7468e5559c78a7c3fe2c0b97ea262fbac550c |
|
21-Apr-2016 |
herb <herb@google.com> |
Fix code regression to more precise call. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905993002 Review URL: https://codereview.chromium.org/1905993002
/external/skia/src/core/SkBitmap.cpp
|
9bc22351b59a77d9cafb0bccf69aac84425a7503 |
|
21-Apr-2016 |
herb <herb@google.com> |
Make all the codecs default profiles based on gTreatSkColorAsSRGB. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893203006 Review URL: https://codereview.chromium.org/1893203006
/external/skia/src/core/SkBitmap.cpp
|
149b47fec73ce945ef26463a3092bad5569b6a53 |
|
14-Apr-2016 |
herb <herb@google.com> |
Make sure the color profile propagetes through the system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1892543002 Review URL: https://codereview.chromium.org/1892543002
/external/skia/src/core/SkBitmap.cpp
|
fde05114e6c4107b36e1aa571c64d31def40f613 |
|
11-Mar-2016 |
reed <reed@google.com> |
Make sp variants for SkData Review URL: https://codereview.chromium.org/1779263003
/external/skia/src/core/SkBitmap.cpp
|
d96e7e503fd24825a6717d58e90a97f95e8ebbc6 |
|
17-Feb-2016 |
reed <reed@google.com> |
misc fixes to make float buffers work a little better BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703013002 TBR=fmalita Review URL: https://codereview.chromium.org/1703013002
/external/skia/src/core/SkBitmap.cpp
|
9d22fd6e7bd1e93bb192f4de649b6b170c9d261a |
|
11-Jan-2016 |
bsalomon <bsalomon@google.com> |
Make SkBitmap::CopyTo respect requested dst color type when bitmap is texture backed. BUG=chromium:550559 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1576983002 Review URL: https://codereview.chromium.org/1576983002
/external/skia/src/core/SkBitmap.cpp
|
e80eb928ba0248a5a5dea6e1f0005aa08ecf8740 |
|
17-Dec-2015 |
robertphillips <robertphillips@google.com> |
Add default ctor to SkMask The minimal fix here seems to be handling BoxBlur's return value in SkBlurMaskFilter.cpp::GrRRectBlurEffect::Create. We seem to do enough special handling of the fImage field though that always initialializing it may not be a bad idea. BUG=570232 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1539553002 Review URL: https://codereview.chromium.org/1539553002
/external/skia/src/core/SkBitmap.cpp
|
023bda0d836834eb1f98ceec15b169a492ab78ad |
|
14-Dec-2015 |
halcanary <halcanary@google.com> |
SkBitmap move Running `Release/dm --gpu 0`, the number of times we call SkBitmap::operator=(const SkBitmap&) (which refs the pixelref) is reduced from ~214929 to ~214626. Review URL: https://codereview.chromium.org/1514503004
/external/skia/src/core/SkBitmap.cpp
|
565901db954c231840750ea955ed31b820b9ade8 |
|
10-Dec-2015 |
scroggo <scroggo@google.com> |
Switch SkAutoMalloc to SkAutoTMalloc to avoid cast Make SkAutoTMalloc's interface look more like SkAutoMalloc: - add free(), which does what you expect - make reset() return a pointer fPtr No public API changes (SkAutoTMalloc is in include/private) BUG=skia:2148 Review URL: https://codereview.chromium.org/1516833003
/external/skia/src/core/SkBitmap.cpp
|
e36ec871768eb4f5372540c1167ff7ec592f2bec |
|
09-Dec-2015 |
halcanary <halcanary@google.com> |
SkBitmap::installPixels(const SkPixmap&); Review URL: https://codereview.chromium.org/1505333002
/external/skia/src/core/SkBitmap.cpp
|
b260d130ca8bead7713b290ff0b56b427761922d |
|
09-Dec-2015 |
halcanary <halcanary@google.com> |
SkBitmap::getColor repsects swizzle Review URL: https://codereview.chromium.org/1510253002
/external/skia/src/core/SkBitmap.cpp
|
b906daf112416c1698a79cf51aa70fe11aa19d0a |
|
29-Sep-2015 |
herb <herb@google.com> |
Have /src files use header directly. BUG=skia: Review URL: https://codereview.chromium.org/1373253003
/external/skia/src/core/SkBitmap.cpp
|
e6e41a8a19976a822de36379db23184ff2f28601 |
|
28-Sep-2015 |
herb <herb@google.com> |
Move SkAtomics.h to private. There are no API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1369333004
/external/skia/src/core/SkBitmap.cpp
|
b236d1a37bd8ee936587faa0a55128a1f901cb5a |
|
28-Aug-2015 |
reed <reed@google.com> |
change colortable to use factory for reinflating, check for empty BUG=525763 Review URL: https://codereview.chromium.org/1307023004
/external/skia/src/core/SkBitmap.cpp
|
62ce0303fb3f9857ee3ab8df05934642c226b1a3 |
|
28-Aug-2015 |
bungeman <bungeman@google.com> |
Replace SkPin32 with SkTPin and remove. SkPin32 is already just forwarding to SkTPin, so convert existing users and remove SkPin32. Review URL: https://codereview.chromium.org/1314583003
/external/skia/src/core/SkBitmap.cpp
|
96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr DOCS_PREVIEW= https://skia.org/?cl=1316233002 Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkBitmap.cpp
|
385fe4d4b62d7d1dd76116dd570df3290a2f487b |
|
26-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: SkNEW->new; SkDELETE->delete DOCS_PREVIEW= https://skia.org/?cl=1316123003 Review URL: https://codereview.chromium.org/1316123003
/external/skia/src/core/SkBitmap.cpp
|
d3ebb48320cf1b7e969974673e4bd7743816985e |
|
05-Aug-2015 |
bungeman <bungeman@google.com> |
IWYU: 'core' target, files starting A-C. TBR=reed@google.com Verbal lgtm, does not change API. Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 Review URL: https://codereview.chromium.org/1265033002
/external/skia/src/core/SkBitmap.cpp
|
fb8c1fcab19c99b56d2fdcf6234751d6f0465142 |
|
05-Aug-2015 |
reed <reed@chromium.org> |
Revert of IWYU: 'core' target, files starting A-C. (patchset #5 id:80001 of https://codereview.chromium.org/1265033002/ ) Reason for revert: revert to unblock DEPS roll ../../chrome/browser/chromeos/display/overscan_calibrator.cc:43:10: error: variable has incomplete type 'SkPath' SkPath base_path; Original issue's description: > IWYU: 'core' target, files starting A-C. > > TBR=reed@google.com > Verbal lgtm, does not change API. > > Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 TBR=reed@google.com,mtklein@google.com,bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1273613002
/external/skia/src/core/SkBitmap.cpp
|
7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 |
|
04-Aug-2015 |
bungeman <bungeman@google.com> |
IWYU: 'core' target, files starting A-C. TBR=reed@google.com Verbal lgtm, does not change API. Review URL: https://codereview.chromium.org/1265033002
/external/skia/src/core/SkBitmap.cpp
|
1b24933e52f50773de29332387a12721811f3012 |
|
07-Jul-2015 |
mtklein <mtklein@chromium.org> |
Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc Review URL: https://codereview.chromium.org/1215393002
/external/skia/src/core/SkBitmap.cpp
|
02802f64ea0b1fc9223386328a95280b74092c94 |
|
02-Jul-2015 |
jvanverth <jvanverth@google.com> |
Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/) Reason for revert: Breaking the roll. E.g. on android_chromium_gn_compile_dbg: FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/skia/ext/libskia.SkMemory_new_handler.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DDONT_EMBED_BUILD_METADATA -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DCOMPONENT_BUILD -D__GNU_SOURCE=1 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DSKIA_IMPLEMENTATION=1 -DSK_ARM_HAS_OPTIONAL_NEON -DSK_GAMMA_APPLY_TO_A8 -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSK_DEFAULT_FONT_CACHE_LIMIT=1048576 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DXML_STATIC -I../.. -Igen -I../../third_party/skia/include/private -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/zlib -I../../third_party/expat/files/lib -I../../third_party/freetype-android/include -I../../third_party/freetype-android/src/include -I../../third_party/android_tools/ndk/sources/android/cpufeatures -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fvisibility=hidden --sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm -Os -fdata-sections -ffunction-sections -fomit-frame-pointer -g1 -Wno-format -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -c ../../skia/ext/SkMemory_new_handler.cpp -o obj/skia/ext/libskia.SkMemory_new_handler.o ../../skia/ext/SkMemory_new_handler.cpp:12:52: fatal error: third_party/skia/include/core/SkThread.h: No such file or directory #include "third_party/skia/include/core/SkThread.h" Original issue's description: > Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. > > SkThread.h doesn't do anything anymore execept include those two, > and thankfully, it doesn't seem to be mentioned outside Skia. > > No public API changes. > TBR=reed@google.com > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1214603003
/external/skia/src/core/SkBitmap.cpp
|
c50acf2321d7a934c80d754e9cbe936dfb8eb4cc |
|
01-Jul-2015 |
mtklein <mtklein@chromium.org> |
Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1215393002
/external/skia/src/core/SkBitmap.cpp
|
871872f3f247f6b699617f6d9ef50ef5da6fbe74 |
|
22-Jun-2015 |
reed <reed@google.com> |
change old picture serialization to really handle images BUG=skia:3965 Review URL: https://codereview.chromium.org/1199473002
/external/skia/src/core/SkBitmap.cpp
|
7aefe0321122d92393d30ddc44fb76e4744f34bf |
|
08-Jun-2015 |
reed <reed@google.com> |
Revert "Revert of move erase into SkPixmap (patchset #1 id:1 of https://codereview.chromium.org/1161033005/)" This reverts commit cca9b3ac908cf3e9a0c5774a5ffd118d8429e08a. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1153473012
/external/skia/src/core/SkBitmap.cpp
|
cca9b3ac908cf3e9a0c5774a5ffd118d8429e08a |
|
08-Jun-2015 |
djsollen <djsollen@google.com> |
Revert of move erase into SkPixmap (patchset #1 id:1 of https://codereview.chromium.org/1161033005/) Reason for revert: broken builds Original issue's description: > move erase into SkPixmap > > harvested from https://codereview.chromium.org/1148793007 > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/0963f5dab079627c5523ce6a443af27a33e361f7 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1157303008
/external/skia/src/core/SkBitmap.cpp
|
0963f5dab079627c5523ce6a443af27a33e361f7 |
|
08-Jun-2015 |
reed <reed@google.com> |
move erase into SkPixmap harvested from https://codereview.chromium.org/1148793007 BUG=skia: TBR= Review URL: https://codereview.chromium.org/1161033005
/external/skia/src/core/SkBitmap.cpp
|
28937843f49b3015e9f4c04e04eb2604c3f873cf |
|
08-Jun-2015 |
robertphillips <robertphillips@google.com> |
Cap color index values In the provided example the color table has 10 entries but some of the pixels in the bitmap overflow. This CL goes through the pixel values and caps them to the max index. An alternate approach would be to just have the color table always have 256 entries but zero out the unused ones. BUG=492265 Review URL: https://codereview.chromium.org/1165493003
/external/skia/src/core/SkBitmap.cpp
|
cb674144545866ed31a9ab5dd8e7152282017e40 |
|
05-Jun-2015 |
reed <reed@google.com> |
use pixmaps for dst in sprites -- NO BITMAPS BUG=skia: TBR=scroggo@google.com Review URL: https://codereview.chromium.org/1143173011
/external/skia/src/core/SkBitmap.cpp
|
db74f62c7a464c215b95f563ae4f7a991c4fd058 |
|
30-May-2015 |
reed <reed@chromium.org> |
Revert[6] of add asserts around results from requestLock This reverts commit 11e833d91b5ba2193ed593cb74900dddbec24b6f. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1159183003
/external/skia/src/core/SkBitmap.cpp
|
11e833d91b5ba2193ed593cb74900dddbec24b6f |
|
30-May-2015 |
reed <reed@chromium.org> |
Revert of Revert[4] of add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.org/1159733006/) Reason for revert: gfx_unittests (under linux_asan) @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@Direct leak of 368 byte(s) in 1 object(s) allocated from:@@@ @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@ #0 0x4cc74b in __interceptor_malloc (/b/build/slave/linux_asan/build/src/out/Release/gfx_unittests+0x4cc74b)@@@ @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@ #1 0x7f2f7060ebdf in _cairo_image_surface_create_for_pixman_image /build/buildd/cairo-1.10.2/src/cairo-image-surface.c:158@@@ @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@@@@ @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@Indirect leak of 256 byte(s) in 1 object(s) allocated from:@@@ @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@ #0 0x4cc74b in __interceptor_malloc (/b/build/slave/linux_asan/build/src/out/Release/gfx_unittests+0x4cc74b)@@@ @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@ #1 0x7f2f6c7be26a in _pixman_image_allocate /build/buildd/pixman-0.30.2/build/pixman/../../pixman/pixman-image.c:184@@@ @@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@@@@ I think they are creating a cairo surface, but it has no pixels (zero size?). In this CL, if I see no pixels, I ignore the call-back which is used to free the surface (doh). Original issue's description: > Revert[4] of add asserts around results from requestLock > > This reverts commit 19663e54c017499406036746e7689193aa6417e6. > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/df91b73a34e3a306c93a5e320704736255c3d9f0 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1151063005
/external/skia/src/core/SkBitmap.cpp
|
df91b73a34e3a306c93a5e320704736255c3d9f0 |
|
30-May-2015 |
reed <reed@google.com> |
Revert[4] of add asserts around results from requestLock This reverts commit 19663e54c017499406036746e7689193aa6417e6. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1159733006
/external/skia/src/core/SkBitmap.cpp
|
e800657f2f8a42863481f5a4d7b0d698ecd94e4c |
|
28-May-2015 |
reed <reed@google.com> |
add assert that the pixelref really did success in requestlock BUG=skia: TBR= Review URL: https://codereview.chromium.org/1142343010
/external/skia/src/core/SkBitmap.cpp
|
95d343f4083570a670a2d2121d5b5257ed36fbde |
|
23-May-2015 |
reed <reed@chromium.org> |
move readPixels from bitmap -> pixmap BUG=skia: TBR= Review URL: https://codereview.chromium.org/1153893003
/external/skia/src/core/SkBitmap.cpp
|
92fc2ae58331662ec411a048686cb4801e0a909a |
|
22-May-2015 |
reed <reed@google.com> |
add SkPixmap and external locking to bitmaps BUG=skia: Review URL: https://codereview.chromium.org/1074983003
/external/skia/src/core/SkBitmap.cpp
|
567ff2f6143ecb993dbedede402a43feb71c420a |
|
27-Apr-2015 |
tfarina <tfarina@chromium.org> |
Cleanup: Remove unnecessary double-semicolons. The entries were found by the following command line: $ find . -regex ".*\.[cChH]\(pp\)?" | xargs git grep -e ';;' --and --not -e 'for *(.*;;' Which is a combination of http://stackoverflow.com/a/3858879 and http://gitster.livejournal.com/27674.html BUG=None R=mtklein@google.com Review URL: https://codereview.chromium.org/1088763005
/external/skia/src/core/SkBitmap.cpp
|
5fedef1c312a72faf30c1292279e3792087eb789 |
|
20-Mar-2015 |
reed <reed@google.com> |
remove SK_SUPPORT_LEGACY_PIXELREF_UNFLATTENABLE code BUG=skia: TBR= Review URL: https://codereview.chromium.org/1020403002
/external/skia/src/core/SkBitmap.cpp
|
0c9b1a8d05ea6ec5dfae0ead854304673d94d2c2 |
|
18-Mar-2015 |
reed <reed@chromium.org> |
add kGray_8_SkColorType patch from issue 1014783003 at patchset 60001 (http://crrev.com/1014783003#ps60001) BUG=skia: TBR= Review URL: https://codereview.chromium.org/1010343002
/external/skia/src/core/SkBitmap.cpp
|
44977485bdac75c055c3fa638f118874ccd2d22f |
|
27-Feb-2015 |
reed <reed@google.com> |
Revert of Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (patchset #1 id:1 of https://codereview.chromium.org/966753002/) Reason for revert: Android has been updated, so we can re-land this. Original issue's description: > Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (patchset #3 id:40001 of https://codereview.chromium.org/964613002/) > > Reason for revert: > This breaks Android framework build. See > > https://android-build.storage.googleapis.com/builds/git_master-skia-linux-volantisg-userdebug/1759130/7f0fcdbf3c0d47530d770a15c912298dac20dd7d90a01de63ecb9ba16c96b25c/logs/build_error.log?Expires=1425047630&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Signature=BHPS1lffyH7WykwyEw5RXVVXWqQK5rab%2B6Pl1VaUrTlmWT%2FXb6fq%2FBe22AUDZYFPG24MBR%2F2IzIDzTqH3mihQS9wIkcKJ4kJpA2G%2BI3l8jCX20brZSr3bsDSx%2F4wsLwU1bBpIxI%2FbrauoPRqddbXP8sNI1l51u6ZCxpvRQms9Mc%3D > > We need to stop them from using kIgnore before we can reland this. > > Original issue's description: > > replace kIgnore_SkAlphaType with kUnknown_SkAlphaType > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/1c8aeeaebce9675197be31bd769e8ffa2531bf86 > > TBR=reed@google.com,reed@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/574290f61a47bd1ce1f9e2d941533bda9c8f03fe TBR=reed@chromium.org,scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/966853002
/external/skia/src/core/SkBitmap.cpp
|
574290f61a47bd1ce1f9e2d941533bda9c8f03fe |
|
27-Feb-2015 |
scroggo <scroggo@google.com> |
Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (patchset #3 id:40001 of https://codereview.chromium.org/964613002/) Reason for revert: This breaks Android framework build. See https://android-build.storage.googleapis.com/builds/git_master-skia-linux-volantisg-userdebug/1759130/7f0fcdbf3c0d47530d770a15c912298dac20dd7d90a01de63ecb9ba16c96b25c/logs/build_error.log?Expires=1425047630&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Signature=BHPS1lffyH7WykwyEw5RXVVXWqQK5rab%2B6Pl1VaUrTlmWT%2FXb6fq%2FBe22AUDZYFPG24MBR%2F2IzIDzTqH3mihQS9wIkcKJ4kJpA2G%2BI3l8jCX20brZSr3bsDSx%2F4wsLwU1bBpIxI%2FbrauoPRqddbXP8sNI1l51u6ZCxpvRQms9Mc%3D We need to stop them from using kIgnore before we can reland this. Original issue's description: > replace kIgnore_SkAlphaType with kUnknown_SkAlphaType > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/1c8aeeaebce9675197be31bd769e8ffa2531bf86 TBR=reed@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/966753002
/external/skia/src/core/SkBitmap.cpp
|
1c8aeeaebce9675197be31bd769e8ffa2531bf86 |
|
27-Feb-2015 |
reed <reed@chromium.org> |
replace kIgnore_SkAlphaType with kUnknown_SkAlphaType BUG=skia: TBR= Review URL: https://codereview.chromium.org/964613002
/external/skia/src/core/SkBitmap.cpp
|
6af314724f51ad79a640844536c667bb83de5690 |
|
28-Jan-2015 |
sugoi <sugoi@chromium.org> |
Fixed clusterfuzz issue BUG=448423 Review URL: https://codereview.chromium.org/881423002
/external/skia/src/core/SkBitmap.cpp
|
bd0d9da981289504c9dcd8547eaad52b1f4a52cb |
|
07-Jan-2015 |
sugoi <sugoi@chromium.org> |
Verify size_t overflow In 32 bits, it's possible that multiplying 2 32b values might overflow a size_t, which could be 32b unsigned in that context, so I added a check for size_t overflow. BUG=445831 Review URL: https://codereview.chromium.org/836733005
/external/skia/src/core/SkBitmap.cpp
|
fa1e8a7cefd71f7b75f0b85f8eefe111814dd86f |
|
22-Dec-2014 |
jvanverth <jvanverth@google.com> |
Add sRGB texture support. Review URL: https://codereview.chromium.org/791823003
/external/skia/src/core/SkBitmap.cpp
|
cc969c4dd936c97670788395c9cbee3f346e87d1 |
|
02-Dec-2014 |
mtklein <mtklein@chromium.org> |
Make SkColorTable explicitly thread-safe. Mostly this means using SkLazyPtr for the 16-bit cache. We can remove the copy constructor now and just ref it instead. BUG=skia: Review URL: https://codereview.chromium.org/769323002
/external/skia/src/core/SkBitmap.cpp
|
775b8199a214af57c3ea7969e9d456f5f3eb137f |
|
02-Dec-2014 |
mtklein <mtklein@chromium.org> |
SkColorTable locking serves no purpose anymore. The only thing the unlock methods were doing was assert their balance. This removes the unlock methods and renames the lock methods "read". BUG=skia: Review URL: https://codereview.chromium.org/719213008
/external/skia/src/core/SkBitmap.cpp
|
e77dadd91ae6f4319c2c047e7e36cc79bb4d1eff |
|
21-Nov-2014 |
robertphillips <robertphillips@google.com> |
Revert of Add MultiPictureDraw to nanobench (patchset #7 id:120001 of https://codereview.chromium.org/731973005/) Reason for revert: Needs more work Original issue's description: > Add MultiPictureDraw to nanobench > > I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium. > > TBR=bsalomon@google.com > > Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe TBR=mtklein@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/750583002
/external/skia/src/core/SkBitmap.cpp
|
0ddad31012dabfc1267effc8071d37f7d606efbe |
|
21-Nov-2014 |
robertphillips <robertphillips@google.com> |
Add MultiPictureDraw to nanobench I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium. TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/731973005
/external/skia/src/core/SkBitmap.cpp
|
33a30503d76fdd989358cedd78445ba96bb809dd |
|
11-Sep-2014 |
reed <reed@google.com> |
SkData can allocate room for its contents in the same block BUG=skia: R=bungeman@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/560653004
/external/skia/src/core/SkBitmap.cpp
|
49f085dddff10473b6ebf832a974288300224e60 |
|
05-Sep-2014 |
bsalomon <bsalomon@google.com> |
"NULL !=" = NULL R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/544233002
/external/skia/src/core/SkBitmap.cpp
|
e5ea500d4714a7d84de2bf913e81be3b65d2de68 |
|
03-Sep-2014 |
reed <reed@google.com> |
Hide fields in SkImageInfo R=rmistry@google.com TBR=bsalomon Author: reed@google.com Review URL: https://codereview.chromium.org/536003002
/external/skia/src/core/SkBitmap.cpp
|
848250415eddc54075f7eb8795e8db79e749c6ab |
|
02-Sep-2014 |
reed <reed@google.com> |
make allocPixels throw on failure BUG=skia: R=mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/510423005
/external/skia/src/core/SkBitmap.cpp
|
bbe7a2ad32e3b54dbfa86d6de2ccf57526a10e2f |
|
18-Aug-2014 |
reed <reed@chromium.org> |
eliminate code related to SkBitmap::Config BUG=skia: R=reed@google.com, mike@reedtribe.org Author: reed@chromium.org Review URL: https://codereview.chromium.org/483593002
/external/skia/src/core/SkBitmap.cpp
|
0847059fcffe11d53d4ea803ba2d51c696eb6d07 |
|
16-Jul-2014 |
scroggo <scroggo@google.com> |
Remove kImageIsImmutable_Flag. This flag was only used when setting or checking SkBitmap's immutability when it did not have an SkPixelRef. Now that an SkBitmap *must* have one in order to draw (e.g. you can no longer have an SkBitmap that owns its pixels directly), its immutabity without an SkPixelRef makes no sense. Also, now that the flags are not contiguous starting from 0x01, use a more appropriate check to ensure only meaningful flags are used. R=reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/387083002
/external/skia/src/core/SkBitmap.cpp
|
7e4b2b502718ef1cc9ce48670682603e9e2dc02f |
|
14-Jul-2014 |
scroggo <scroggo@google.com> |
Remove unused kImageIsOpaque_Flag. This flag is never set or read. We now look at the alpha type to determine opacity. R=reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/385943003
/external/skia/src/core/SkBitmap.cpp
|
b184f7f52b2a94e95aee326a3ca37110d2e43336 |
|
13-Jul-2014 |
reed <reed@chromium.org> |
Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels This reverts commit 651eaeadeb0b1407f5fe192aeda90db1680fa2b8. TBR= Author: reed@chromium.org Review URL: https://codereview.chromium.org/390693002
/external/skia/src/core/SkBitmap.cpp
|
651eaeadeb0b1407f5fe192aeda90db1680fa2b8 |
|
12-Jul-2014 |
reed <reed@chromium.org> |
Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (https://codereview.chromium.org/388803007/) Reason for revert: still failing (randomly?) bench sometimes. need stack dump to diagnose. Original issue's description: > Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels > usning it. > > Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)" > > This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce. > > TBR=scroggo@google.com > > Committed: https://skia.googlesource.com/skia/+/debba5c3d091159149f8a88ab5dcd44dd72e0dc7 R=reed@google.com TBR=reed@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/382543005
/external/skia/src/core/SkBitmap.cpp
|
debba5c3d091159149f8a88ab5dcd44dd72e0dc7 |
|
12-Jul-2014 |
reed <reed@google.com> |
Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels usning it. Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)" This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce. R=reed@chromium.org TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/388803007
/external/skia/src/core/SkBitmap.cpp
|
d08cb905a7cc80d8fb868bbd14fffe1cd68adcce |
|
11-Jul-2014 |
jcgregorio <jcgregorio@google.com> |
Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/) Reason for revert: Maybe causing crashes in bench. http://108.170.220.120:10117/builders/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/builds/2608/steps/RunBench/logs/stdio Original issue's description: > add readPixels() to SkBitmap > > BUG=chromium:390782 > > Committed: https://skia.googlesource.com/skia/+/c4f216151b6ade70c35fade09a353052f40236b1 R=scroggo@google.com, bsalomon@google.com, reed@google.com TBR=bsalomon@google.com, reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=chromium:390782 Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/382243003
/external/skia/src/core/SkBitmap.cpp
|
c4f216151b6ade70c35fade09a353052f40236b1 |
|
10-Jul-2014 |
reed <reed@google.com> |
add readPixels() to SkBitmap BUG=chromium:390782 R=scroggo@google.com, bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/377303002
/external/skia/src/core/SkBitmap.cpp
|
ca95c19d27b505a1ac8f57b53cb49c198bc29267 |
|
08-Jul-2014 |
sugoi <sugoi@chromium.org> |
Adding validation before using an SkImageInfo object read from an SkReadBuffer. BUG=389574 R=senorblanco@google.com, reed@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/376803004
/external/skia/src/core/SkBitmap.cpp
|
060c41a499b1e8c2b34661b5eb988630e25c6421 |
|
07-Jul-2014 |
reed <reed@google.com> |
remove unneeded flags (have been purged from chrome and android) TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/372793003
/external/skia/src/core/SkBitmap.cpp
|
9a9eae21ed5235869702a66d6decddd6643792c3 |
|
07-Jul-2014 |
reed <reed@google.com> |
change pixelref to not inherit from SkFlattenable If I can "inline" MallocPixelRef unflatten, then I think we can delete this code. The only caller today should be unflattening in the legacy path for bitmaps. R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/320873003
/external/skia/src/core/SkBitmap.cpp
|
f0aed97aec3fa1c7f6460d8d6327358f3dcbabe6 |
|
01-Jul-2014 |
reed <reed@google.com> |
correctly plumb through explicit rowbytes for allocPixels BUG=skia: R=caryclark@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/357073003
/external/skia/src/core/SkBitmap.cpp
|
2fd0d14b9be34a7a945942733c3516d97d07f516 |
|
01-Jul-2014 |
scroggo <scroggo@google.com> |
Adjust the alpha type for pixelRefs. Move SkBitmap's validate_alphaType to SkImageInfo, with the new name SkColorTypeValidateAlphaType. Use it in SkPixelRef's constructors, as well as in SkDecodingImageGenerator. This fixes a bug where an SkPixelRef's SkAlphaType could get out of sync with its SkBitmap, when both were assigned the same SkAlphaType. R=reed@google.com, halcanary@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/346593003
/external/skia/src/core/SkBitmap.cpp
|
bae704b050491a8a98c67cb23eaccb10852d2bd5 |
|
28-Jun-2014 |
reed <reed@google.com> |
add rowbytes option to allocPixels TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/345263005
/external/skia/src/core/SkBitmap.cpp
|
c3b3266b7db2f1a41d41ecac010c766b7ad8eebc |
|
17-Jun-2014 |
reed <reed@google.com> |
hide SkBitmap::Config entirely (behind a flag) patch from issue 339463002 TBR= I think the NoGPU failure is unrelated, so ignoring NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/340533002
/external/skia/src/core/SkBitmap.cpp
|
0eb02a6abbe2964e4955863b0f82aff6a8661801 |
|
16-Jun-2014 |
piotaixr <piotaixr@chromium.org> |
Cleaned a repeated if(condition) with the same condition R=junov@chromium.org Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/338933002
/external/skia/src/core/SkBitmap.cpp
|
e4538f5b46d70798e34eb078f5d5e76a59d02318 |
|
11-Jun-2014 |
reed <reed@chromium.org> |
switch to colortype for deepcopy BUG=skia: R=robertphillips@google.com, bsalomon@google.com, reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/323283002
/external/skia/src/core/SkBitmap.cpp
|
6c22573edb234ad14df947278cfed010669a39a7 |
|
10-Jun-2014 |
reed <reed@chromium.org> |
hide SkBitmap::setConfig patch from issue 325733002 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/322963002
/external/skia/src/core/SkBitmap.cpp
|
0187dc2155830c1ae3390d97463d5dd3971eca41 |
|
05-Jun-2014 |
scroggo <scroggo@google.com> |
Fixes for SkAlphaTypes. When using allocPixels to set the info and create a new pixelRef in one shot, create the pixelRef with the corrected info of the bitmap (i.e. alphatype). Simplify the check to determine whether to copy the genID in SkBitmap:: copyTo's same configs/same sizes case. The old logic (only checking the height and assuming the others must be the same) relied on a deep (mis?)understanding of the rest of the function, and I cannot convince myself that it has to be true, given that readPixels may have switched src to a different SkBitmap. Instead, just compare the SkImageInfos, which is much clearer. (This also caught a bug where a 565 bitmap had the wrong alphatype, leading to the allocPixels fixes.) If readPixels succeeds but the source is unpremultiplied, fail out of copyTo, since readPixels assumes premultiplied. When copying from 8888 to 4444 or in the fallback case of drawing, return false if the alphatype is unpremul, which would have failed anyway. BUG=skia:2012 R=reed@google.com, bsalomon@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/317053003
/external/skia/src/core/SkBitmap.cpp
|
ddd014e65264e3f18b2d4305dd2fbc81549f5180 |
|
05-Jun-2014 |
reed <reed@google.com> |
remove SkBitmap::allocConfigPixels and update dox I see no callers in android R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/310283004
/external/skia/src/core/SkBitmap.cpp
|
a3264e53ee3f3c5d6a2c813df7e44b5b96d207f2 |
|
30-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)" This reverts commit eecaea4148805834f223681f70b6488ceba12d09. R=robertphillips@google.com, scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/301283003 git-svn-id: http://skia.googlecode.com/svn/trunk@14989 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
05858435ee8744de863be7e5ade05e4fd6edfb46 |
|
30-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixing a clusterfuzz found issue BUG=378175 R=reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/306033003 git-svn-id: http://skia.googlecode.com/svn/trunk@14983 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
d0f824cfbd8951bb948b19d7ff5dce028ce557a5 |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/) Reason for revert: broke all Windows bots Original issue's description: > setConfig -> setInfo > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14978 R=robertphillips@google.com, reed@google.com TBR=reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: epoger@google.com Review URL: https://codereview.chromium.org/302053002 git-svn-id: http://skia.googlecode.com/svn/trunk@14979 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
986d681f3e7a7eb6febd9df9fe21a8d277ba2296 |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
setConfig -> setInfo BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/308683005 git-svn-id: http://skia.googlecode.com/svn/trunk@14978 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
cba73780bbd12fd254229517aec04fcbf0b64b52 |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
replace config() with colorType() BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/303543009 git-svn-id: http://skia.googlecode.com/svn/trunk@14959 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
00f8d6c75d22ce8f95f932c5b101354b196fa0df |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)" Fix is to add colortable param to installPixels() This reverts commit 924205aaf2e0c3c65dda13e0eaccde3e7b2a5c40. BUG=skia: R=scroggo@google.com, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/300263005 git-svn-id: http://skia.googlecode.com/svn/trunk@14958 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
466f5f3e44e703ca58b43ac1c4ac3bfa0e1ff024 |
|
27-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SkBitmap::asImageInfo BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/305483005 git-svn-id: http://skia.googlecode.com/svn/trunk@14909 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
851155c28e18e3f5b702ef15ee7bfb12f3cbacda |
|
27-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SK_SUPPORT_LEGACY_BITMAPFLATTEN code BUG=skia: R=scroggo@google.com, reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/303563002 git-svn-id: http://skia.googlecode.com/svn/trunk@14888 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
3c134a97ed128ca95345e13619512df0f42e95f8 |
|
24-May-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@14884 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
968edcafa61442dc4f7f8ed8f89523d0f353e9fb |
|
23-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
stop calling SkBitmap::flatten BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/295793002 git-svn-id: http://skia.googlecode.com/svn/trunk@14867 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
eeef0cc49bf71e8b5e044d6a73b79cfe2b2c87b3 |
|
21-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromi… (https://codereview.chromium.org/291163005/) Reason for revert: broke 6 webgl/canvas tests in blink (don't know why yet) https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_7/27348/layout-test-results/results.html Original issue's description: > Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)""" > > This reverts commit 3dbceb4f8283b2fb1728d0daf010d036099a2eae. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14806 R=bsalomon@google.com, robertphillips@google.com TBR=bsalomon@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/295093003 git-svn-id: http://skia.googlecode.com/svn/trunk@14826 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
731b28daaadbea13b071b0de0d95c06058b940fc |
|
20-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)""" This reverts commit 3dbceb4f8283b2fb1728d0daf010d036099a2eae. BUG=skia: R=bsalomon@google.com, robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/291163005 git-svn-id: http://skia.googlecode.com/svn/trunk@14806 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
555e74f6fbd9acad79411f72342759ba2ee51b16 |
|
20-May-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
"Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)"" This reverts commit 65b9f33cab9f53821720f982667412e56a340093. git-svn-id: http://skia.googlecode.com/svn/trunk@14795 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
a369e36e9d00dc83798703814cebd0b04e9525a4 |
|
19-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)" TBR=bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/290883005 git-svn-id: http://skia.googlecode.com/svn/trunk@14785 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
eaca36b65743af0503d4e72242b3abbbbb2d9414 |
|
07-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove dead mipmap code from SkBitmap BUG=skia: R=fmalita@google.com, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/271693002 git-svn-id: http://skia.googlecode.com/svn/trunk@14611 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6e332f768f873323b418ee7b028f28662bfb43c6 |
|
23-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/) Reason for revert: Causes some layout_test failures around texture backed bitmaps. Test names and crash logs accessible via: https://storage.googleapis.com/chromium-layout-test-archives/linux_layout/13845/layout-test-results/results.html Original issue's description: > eliminate config param -- it was always self's config > > BUG=skia: > R=bsalomon@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=14303 R=reed@google.com TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: bsalomon@google.com Review URL: https://codereview.chromium.org/249373003 git-svn-id: http://skia.googlecode.com/svn/trunk@14324 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
60b5dce19984a5165f6b2f1d6d477f5e8a940761 |
|
22-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
expose CGImage -> SkBitmap BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/243463005 git-svn-id: http://skia.googlecode.com/svn/trunk@14315 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
dcacd5fd5a0baeb83d8c61bb6127c442ef72e29a |
|
22-Apr-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
eliminate config param -- it was always self's config BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/246513002 git-svn-id: http://skia.googlecode.com/svn/trunk@14303 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
28fcae2ec77eb16a79e155f8d788b20457f1c951 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) Reason for revert: Want to reland the original CL. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, bensong@google.com TBR=bensong@google.com, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: scroggo@google.com Review URL: https://codereview.chromium.org/235523003 git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
96edc2459820f0f60ea9b57959c1e5018ef95e28 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) Reason for revert: Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now. Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234833003 git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
d923288e50b5a69afb0bdd5c161191b24cab8345 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) Reason for revert: fixes on the chrome side are landing (brettw), keep fingers crossed. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/233813004 git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
757ebd20ef284b6428eb9f4b9b69826cc3640a82 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) Reason for revert: breaking the Chrome deps roll. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234243002 git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
149e9a107c356b0151433fb23c2b1c8d0634947c |
|
09-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Rename kPMColor_SkColorType to kN32_SkColorType. The new name better represents what this flag means. BUG=skia:2384 R=reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/227433009 git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
7669a77cd16fbab3618ca1f1a03bcfa05a93c447 |
|
27-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix SkBitmap::erase to handle RGBA and BGRA BUG=skia:2352 R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/212643014 git-svn-id: http://skia.googlecode.com/svn/trunk@13964 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0f10f7bf1fb43ca6346dc220a076773b1f19a367 |
|
13-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow toString capability to be toggled independent of developer mode. This change is motivated by the desire to see the text information in the debugger when not in developer mode. It is structured so user's can disable it if the capability is not wanted. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/197763008 git-svn-id: http://skia.googlecode.com/svn/trunk@13795 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
1db03d2fad5d7b40b21a9d694cb1127e8de8bce0 |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SK_SUPPORT_LEGACY_COPYTO_CONFIG TBR=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/196413009 git-svn-id: http://skia.googlecode.com/svn/trunk@13780 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
fab349c0bf3a305b7a7388b77bab13b0f7b37393 |
|
05-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SK_SUPPORT_DEEPCOPYTO_CONFIG code -- no longer used R=reed@google.com TBR=bsalomon@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/183763035 git-svn-id: http://skia.googlecode.com/svn/trunk@13664 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
e74e08c1d0e9a691b66347f3c71a416bc3601029 |
|
24-Feb-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix compile errors in legacy copyTo(). R=reed@google.com, reed Review URL: https://codereview.chromium.org/178003002 git-svn-id: http://skia.googlecode.com/svn/trunk@13562 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8a2ad3cae710f05cca57e48dd1732d575dba2dc7 |
|
23-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add new copyTo version to SkBitmap, which takes SkColorType BUG=skia: R=scroggo@google.com, halcanary@google.com, bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/171723007 git-svn-id: http://skia.googlecode.com/svn/trunk@13553 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6285f4f7662853336b788d6ee3e177c396f7fb01 |
|
20-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Offer single-param version of deepCopyTo -- much easier to migrate to colortypes BUG=skia: R=reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/167683006 git-svn-id: http://skia.googlecode.com/svn/trunk@13516 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
cbad22b0de917d307ffbb0f82240d75157d86117 |
|
19-Feb-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert to previous behavior in installPixels, allowing for NULL address BUG=skia: Review URL: https://codereview.chromium.org/172603002 git-svn-id: http://skia.googlecode.com/svn/trunk@13501 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
725cd8218c2f32afecfde9c1c6940ca2d045b3c5 |
|
18-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
installPixels returns true if null-pixels -- devolving to setConfig fixes assumptions in chrome's ui_unittests: RenderTextTest.SelectionKeepsLigatures R=robertphillips@google.com, bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/170713006 git-svn-id: http://skia.googlecode.com/svn/trunk@13492 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
dac522589e9395b4654a1a708f1bd971f37f95a5 |
|
17-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
replace SkBitmap::Config with SkColorType in gms add helper installMaskPixels() to SkBitmap BUG=skia: R=halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/169913003 git-svn-id: http://skia.googlecode.com/svn/trunk@13482 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6e58cf36f0eba4b195726aa714d5487c91d06d04 |
|
16-Feb-2014 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
restore old behavior of setPixels(): lockPixels after installPixels() git-svn-id: http://skia.googlecode.com/svn/trunk@13468 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
02d6f546161e2c98d69066373cec3f54f3c46252 |
|
14-Feb-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13447 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
d5414e5efe0a6a0bce0b5499e2358e2be4cb9b61 |
|
13-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
ensure that opaque-only colortypes always report opaque-alphatype BUG=skia: R=scroggo@google.com, djsollen@google.com, reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/164233006 git-svn-id: http://skia.googlecode.com/svn/trunk@13443 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
33fed14b1d4867015ac518874013e0b3e06ea982 |
|
13-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed clusterfuzz found crash BUG=343461 R=senorblanco@google.com, senorblanco@chromium.org, reed@chromium.org, reed@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/162943003 git-svn-id: http://skia.googlecode.com/svn/trunk@13439 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
61e96cd44624c9faceb625519c1b29775b161f45 |
|
11-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkBitmap now really stores SkImageInfo -- config is just a ruse BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/159653004 git-svn-id: http://skia.googlecode.com/svn/trunk@13411 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
1195a28892d37ae9632e81e1bc2407cf644522d2 |
|
11-Feb-2014 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "SkBitmap now really stores SkImageInfo -- config is just a ruse" BUG=skia: Review URL: https://codereview.chromium.org/147733004 git-svn-id: http://skia.googlecode.com/svn/trunk@13395 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
b53317c6fa0d7b2f86e9d069bb49dc157f04120a |
|
11-Feb-2014 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix test for empty config handle empty setconfig BUG=skia: Review URL: https://codereview.chromium.org/159533002 git-svn-id: http://skia.googlecode.com/svn/trunk@13394 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8ed6443e6c608007e1e62937acfaf29b7fe7b8b0 |
|
11-Feb-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13393 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c9114856e8e1b94b55725a4d86ef80bd3a76187b |
|
11-Feb-2014 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix warnings BUG=skia: Review URL: https://codereview.chromium.org/153003005 git-svn-id: http://skia.googlecode.com/svn/trunk@13392 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
169a0ed50a5e451711c341795572e7177a540a24 |
|
11-Feb-2014 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkBitmap now really stores SkImageInfo -- config is just a ruse (edited) clone of https://codereview.chromium.org/159173004/ Review URL: https://codereview.chromium.org/159463003 git-svn-id: http://skia.googlecode.com/svn/trunk@13391 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6be31f42cac550dfa6fd936b36484002b6eadc9c |
|
10-Feb-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SK_SUPPORT_LEGACY_ONLOCKPIXELS completely BUG=skia: Review URL: https://codereview.chromium.org/158893005 git-svn-id: http://skia.googlecode.com/svn/trunk@13382 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c2d768c0cf5a09bb481a8117a1351603eff84cee |
|
05-Feb-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
pass in the real rowBytes git-svn-id: http://skia.googlecode.com/svn/trunk@13328 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8b0e8ac5f582de80356019406e2975079bf0829d |
|
30-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactor read and write buffers. Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer a step each in the hierarchy. What used to be this: SkFlattenableWriteBuffer -> SkOrderedWriteBuffer SkFlattenableReadBuffer -> SkOrderedReadBuffer SkFlattenableReadBuffer -> SkValidatingReadBuffer is now SkWriteBuffer SkReadBuffer -> SkValidatingReadBuffer Benefits: - code is simpler, names are less wordy - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed - write buffers are completely devirtualized, important for record speed This refactoring was mostly mechanical. You aren't going to find anything interesting in files with less than 10 lines changed. BUG=skia: R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/134163010 git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c1587f94a77eaafe257a6ecf504364d40362c66a |
|
28-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
change setAlphaType to not modify the pixelref's genID BUG=skia: R=bsalomon@google.com, halcanary@google.com Review URL: https://codereview.chromium.org/137263009 git-svn-id: http://skia.googlecode.com/svn/trunk@13219 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0e8d0d6cdc2e02946b099006d0a47e60764905e5 |
|
27-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add optional SkAlphaType parameter to notifyPixelsChanged R=scroggo@google.com, halcanary@google.com, robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/147213002 git-svn-id: http://skia.googlecode.com/svn/trunk@13192 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
33c749a586648c068a43f4d983f10810420ba315 |
|
26-Jan-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13185 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
eb9a46cbbb475e862a084aa2224ec18d4ac5e95b |
|
25-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add legacy/helper allocN32Pixels, and convert gm to use it This is an intermediate api, but might help us quickly get to a point where no one is creating bitmaps in a 2-step process (setConfig + alloc). BUG=skia: R=halcanary@google.com Review URL: https://codereview.chromium.org/140593005 git-svn-id: http://skia.googlecode.com/svn/trunk@13182 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
d2ac07b64b7d46e81d00d389781f9f83810f0095 |
|
25-Jan-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13181 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9ebcac54635cde63110d73ad7c43d70772e7872f |
|
24-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add installPixels BUG=skia: R=halcanary@google.com Review URL: https://codereview.chromium.org/143073008 git-svn-id: http://skia.googlecode.com/svn/trunk@13174 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
f7ba41321b16ad8df611fa07e9ae48fe8a30a0bb |
|
16-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Hide bitmap rowbyes assert when LEGACY_ONLOCKPIXELS Motivation: without this, we break Blink. BUG=skia: NOTREECHECKS=true NOTRY=true R=robertphillips@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/140903002 git-svn-id: http://skia.googlecode.com/svn/trunk@13107 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5f62ed74342e44cb1b9671ffdac47c6a81416136 |
|
15-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
no need to refcnt colortables, since pixelrefs own them BUG=skia: R=halcanary@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/139463007 git-svn-id: http://skia.googlecode.com/svn/trunk@13098 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
615316cefbf16382f6a99c72d88a13d2be1d2408 |
|
15-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add asserts to validate BUG=skia: R=halcanary@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/139063003 git-svn-id: http://skia.googlecode.com/svn/trunk@13093 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5ccae2c5b134d1b971c188215433305e88491aec |
|
15-Jan-2014 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reland "Fix genID cloning bugs." SkBitmap.cpp: When copyTo calls readPixels, only clone the genID if the resulting SkPixelRef has the same dimensions as the original. This catches a bug where copying an SkBitmap representing the subset of an SkPixelRef (which implements onReadPixels) would result in the copy sharing the genID. (Thanks to r6710, this case can only happen using setPixelRef, so the updated GpuBitmapCopyTest checks for that.) Move some unnecessary NULL checks to asserts. When copyTo performs a memcpy, only clone the genID if the resulting SkPixelRef has the same dimensions as the original. This catches a bug where copying an extracted SkBitmap with the same width as its original SkPixelRef would incorrectly have the same genID. Add a comment and assert in deepCopyTo, when cloning the genID, since that case correctly clones it. BitmapCopyTest.cpp: Pull redundant work out of the inner loop (setting up the source bitmaps and testing extractSubset). Create a new inner loop for extractSubset, to test copying the result to each different config. Extract a subset that has the same width as the original, to catch the bug mentioned above. Remove the reporter assert which checks for the resulting rowbytes. Add checks to ensure that copying the extracted subset changes the genID. GpuBitmapCopyTest: Create an SkBitmap that shares an existing SkPixelRef, but only represents a subset. This is to test the first call to cloneGenID in SkBitmap::copyTo. In this case, the genID should NOT be copied, since only a portion of the SkPixelRef was copied. Also test deepCopy on this subset. TestIndividualCopy now takes a parameter stating whether the genID should change in the copy. It also does a read back using the appropriate subset. It no longer differentiates between copyTo and deepCopyTo, since that distinction was only necessary for copying from/to configs other than 8888 (which are no longer being tested), where copyTo did a read back in 8888 and then drew the result to the desired config (resulting in an imperfect copy). BUG=skia:1742 Committed: http://code.google.com/p/skia/source/detail?r=13021 R=mtklein@google.com Review URL: https://codereview.chromium.org/112113005 git-svn-id: http://skia.googlecode.com/svn/trunk@13090 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
e13af711d4ff9031c9ed3054a4c33a56a0c62e1f |
|
13-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of https://codereview.chromium.org/132643007/ Reason for revert: broken tests TBR= NOTREECHECKS=true NOTRY=true BUG= Author: reed@google.com Review URL: https://codereview.chromium.org/134843008 git-svn-id: http://skia.googlecode.com/svn/trunk@13058 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
f0b56e74485d59465194b21f89fa3bc3a7962ac6 |
|
13-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of https://codereview.chromium.org/129423002/" fixed new api references in unit tests This reverts commit ffc0058e1fbcbd69617e1f41b2dce5b5765ff99e. BUG= Review URL: https://codereview.chromium.org/132643007 git-svn-id: http://skia.googlecode.com/svn/trunk@13057 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9b06ba4c91484d09565ff4a572d8c5af15dd429e |
|
13-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of https://codereview.chromium.org/129423002/ Reason for revert: broke tests (compile) R=scroggo@google.com, halcanary@google.com TBR=halcanary@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG= Author: reed@google.com Review URL: https://codereview.chromium.org/137133003 git-svn-id: http://skia.googlecode.com/svn/trunk@13056 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
dd9ea9262cb61b545fcf414fbde677eb2b62fee4 |
|
13-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkBitmap::installPixelRef() BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/129423002 git-svn-id: http://skia.googlecode.com/svn/trunk@13055 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5c6f1d4424191539ebe5a5c3db883716d67efe12 |
|
10-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of https://codereview.chromium.org/112113005/ Reason for revert: breaks unit tests R=mtklein@google.com, bsalomon@google.com, reed@google.com, scroggo@google.com TBR=bsalomon@google.com, mtklein@google.com, reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:1742 Author: caryclark@google.com Review URL: https://codereview.chromium.org/134453002 git-svn-id: http://skia.googlecode.com/svn/trunk@13024 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
f2595e418661fe3b68c239a945ce8e1d2862e77d |
|
10-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix genID cloning bugs. SkBitmap.cpp: When copyTo calls readPixels, only clone the genID if the resulting SkPixelRef has the same dimensions as the original. This catches a bug where copying an SkBitmap representing the subset of an SkPixelRef (which implements onReadPixels) would result in the copy sharing the genID. (Thanks to r6710, this case can only happen using setPixelRef, so the updated GpuBitmapCopyTest checks for that.) Move some unnecessary NULL checks to asserts. When copyTo performs a memcpy, only clone the genID if the resulting SkPixelRef has the same dimensions as the original. This catches a bug where copying an extracted SkBitmap with the same width as its original SkPixelRef would incorrectly have the same genID. Add a comment and assert in deepCopyTo, when cloning the genID, since that case correctly clones it. BitmapCopyTest.cpp: Pull redundant work out of the inner loop (setting up the source bitmaps and testing extractSubset). Create a new inner loop for extractSubset, to test copying the result to each different config. Extract a subset that has the same width as the original, to catch the bug mentioned above. Remove the reporter assert which checks for the resulting rowbytes. Add checks to ensure that copying the extracted subset changes the genID. GpuBitmapCopyTest: Create an SkBitmap that shares an existing SkPixelRef, but only represents a subset. This is to test the first call to cloneGenID in SkBitmap::copyTo. In this case, the genID should NOT be copied, since only a portion of the SkPixelRef was copied. Also test deepCopy on this subset. TestIndividualCopy now takes a parameter stating whether the genID should change in the copy. It also does a read back using the appropriate subset. It no longer differentiates between copyTo and deepCopyTo, since that distinction was only necessary for copying from/to configs other than 8888 (which are no longer being tested), where copyTo did a read back in 8888 and then drew the result to the desired config (resulting in an imperfect copy). BUG=skia:1742 R=mtklein@google.com, bsalomon@google.com, reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/112113005 git-svn-id: http://skia.googlecode.com/svn/trunk@13021 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
303c4758ec7062daf1531c3642e9c7887423ef1b |
|
09-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use bitmap's fRowBytes, as the pixelref's is not (yet) reliable should fix linux browser_tests for DEPS roll BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/132273004 git-svn-id: http://skia.googlecode.com/svn/trunk@13002 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
672588b684d484dce6ae251e9e163e4a46924322 |
|
08-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
change offset to xy for pixelref subsetting BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/105893012 git-svn-id: http://skia.googlecode.com/svn/trunk@12958 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
dcea5300dc028b5ea210d778b9e34a7504fee6d2 |
|
03-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
assert in setPixelRef that the pr matches the bitmap's config BUG= R=halcanary@google.com Review URL: https://codereview.chromium.org/120063003 git-svn-id: http://skia.googlecode.com/svn/trunk@12880 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
f5e1f63461d0a4dcb4bd5d0388ec6d392b97e5f0 |
|
31-Dec-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@12849 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
4856964eae9cdb779baa08ef9e5646ccb9a3140d |
|
30-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
ComputeRowBytes must not overflow width when it shifts BUG= R=halcanary@google.com Review URL: https://codereview.chromium.org/122473002 git-svn-id: http://skia.googlecode.com/svn/trunk@12848 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
57212f9469c8056bab3c85243dbb904e386eab95 |
|
30-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of https://codereview.chromium.org/113823003/" This reverts commit 68b4b32066ea0ba9dbb5d326a836f8a54297b7aa. BUG= Review URL: https://codereview.chromium.org/122293002 git-svn-id: http://skia.googlecode.com/svn/trunk@12842 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
4ad4ae907fa83773f671137b0e4e8c9525ab81cd |
|
30-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of https://codereview.chromium.org/113823003/ Reason for revert: need to update callsites in linux codecs R=robertphillips@google.com TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG= Author: reed@google.com Review URL: https://codereview.chromium.org/122283002 git-svn-id: http://skia.googlecode.com/svn/trunk@12841 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
a306d93cd73c3fc1d81479cbba98638f1e055385 |
|
30-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove Sk64 from public API, and start to remove usage internally BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/113823003 git-svn-id: http://skia.googlecode.com/svn/trunk@12840 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
96f5fa02e996e39179f2eb88d57e8ed6114b06c5 |
|
16-Dec-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@12685 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
bf790232f6d94b54239dbc210d8beee7411ca458 |
|
13-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update all callsites to use info for pixelrefs #define SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR in chrome to keep old API signature (for now) BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/100723005 git-svn-id: http://skia.googlecode.com/svn/trunk@12677 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
4428734907480cdb4ccecb47152d7be8cd1aec32 |
|
13-Dec-2013 |
halcanary@google.com <halcanary@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow 0-width SkBitmap in setConfig. Previously, SkBitmap::setConfig would allow zero height, but not zero width. This is changed for consistancy. A unit test was added. BUG= R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/111953004 git-svn-id: http://skia.googlecode.com/svn/trunk@12673 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0daa1adb03b4b1fc11d854cb7754416ac05a31e8 |
|
13-Dec-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r12665 & r12666 (Remove duplicate impl for SkImageInfo flattening) due to Chromium/Blink compilation errors https://codereview.chromium.org/112603003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12667 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
93b40594b78ab40170b5a7fa0811fa95ab8fc30f |
|
13-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remvoe duplicate impl for SkImageInfo flattening Add onNewLockPixels This reverts commit bb8eff6a70c52b7644391cfd4f4d21bf7294a6bf. BUG= Review URL: https://codereview.chromium.org/111323005 git-svn-id: http://skia.googlecode.com/svn/trunk@12665 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
398337b3a5d66a7db5d36a3b5182e4407e2292f7 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "remvoe duplicate impl for SkImageInfo flattening" Reason: breaks chrome_mac_tests which still have non-imageinfo constructors This reverts commit a06b8cf60b39bda93e9ef1a73579007b2b930d29. BUG= Review URL: https://codereview.chromium.org/103033005 git-svn-id: http://skia.googlecode.com/svn/trunk@12631 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
a0d183d89160e31962e99475abe8a77c30626a40 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of https://codereview.chromium.org/108773003/" This reverts commit 947e6a3142af66b750f1247ef933b11ed8455dd4. BUG= Review URL: https://codereview.chromium.org/112963003 git-svn-id: http://skia.googlecode.com/svn/trunk@12630 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ff9c6c92e5f962b34f7421e67ac112f81a018bd3 |
|
11-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of https://codereview.chromium.org/108773003/ Reason for revert: breaks chrome-mac-tests TBR= NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/113193003 git-svn-id: http://skia.googlecode.com/svn/trunk@12629 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
f3aead2829fa515f790631ee65784a7b9b073343 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remvoe duplicate impl for SkImageInfo flattening Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""""" This reverts commit eabd6b2ed4e494b323c08f32358f45950a0368c3. BUG= Review URL: https://codereview.chromium.org/108773003 git-svn-id: http://skia.googlecode.com/svn/trunk@12624 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6a32add491cc736aab95561d137909cd7c5d65ef |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""""" This reverts commit d08eca87a0bef10112a211de540f89656a80b86a. BUG= Review URL: https://codereview.chromium.org/108303003 git-svn-id: http://skia.googlecode.com/svn/trunk@12623 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6965a0a2df9d35cd0a25e1738f0388272d03f399 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""" BUG= Review URL: https://codereview.chromium.org/110503003 git-svn-id: http://skia.googlecode.com/svn/trunk@12622 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9230ea29718bcf1a92a89a1a518fb896bbbe00cf |
|
09-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make info real in SkPixelRef, and add bitmap::asImageInfo BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/108663004 git-svn-id: http://skia.googlecode.com/svn/trunk@12586 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
2ebc10dd12a6fe55fda37a9bd5b1e0c1c1e08232 |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""" This reverts commit 5f035e90d6dea0139a4f204b634e7b7b3b4976d7. Reverting because it breaks chrome/blink due to new SkPixelRef constructor arg. BUG= Review URL: https://codereview.chromium.org/108993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12551 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
473f0aa2bb218e50fce5e19063f8c8fdaf57fad4 |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."" This reverts commit 4174afb18a9746bbad2a06c0ec2d4ad35f72d790. BUG= Review URL: https://codereview.chromium.org/108723003 git-svn-id: http://skia.googlecode.com/svn/trunk@12547 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c2e9db30d393862bd3485cfe57b4ac06433f2f32 |
|
06-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed a few places where uninitialized memory could have been read Also added early exit in SkImageFilter's constructor to avoid attempting to deserialize all inputs once a bad input has been found. This avoids hanging if a filter pretends to have 1 billion inputs when that's just an error on the number of inputs read by the filter. BUG=326206,326197,326229 R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/106943002 git-svn-id: http://skia.googlecode.com/svn/trunk@12544 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5b132b28da61e89cdcb84e95f30a58f8184739fc |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap." This reverts commit 154e08b2f5904ef533da694e3510befcb9a3f3e2. revert due to warnings Review URL: https://codereview.chromium.org/108513003 git-svn-id: http://skia.googlecode.com/svn/trunk@12538 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
3e89524e747b513986abfeeea00b6fac79593f26 |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap. R=mtklein@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/68973005 git-svn-id: http://skia.googlecode.com/svn/trunk@12537 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ab1c13864df34aecfd4840ea7d1e4f8730b44f4e |
|
05-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix compilation with SK_ENABLE_INST_COUNT=1 Add INHERITED declarations to class declarations that prevent compilation with the flag. Remove SK_DEFINE_INST_COUNT from all class implementations. Instead, use function-local static variables in the reference count helper classes to create the global instances to store the needed info. The accessor functions are defined inline in the helper classes, so definitions are not needed. The initialization point of the variables should be as well defined as previously. Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT instead. This avoids possible future compilation errors further. For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member function to all classes that use SK_DECLARE_INST_COUNT and SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes contain public INHERITED typedef. This member function seems to be compiled away. This shouĺd ensure that part of the compilation errors are caught earlier. Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses. R=robertphillips@google.com, richardlin@chromium.org, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/98703002 git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
cd3b15ca6364a04b0eeeb4f89c7daa8aefe854c8 |
|
04-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed bad bitmap size crashes There were 2 issues : 1 ) If the size of an SkBitmap's underlying SkPixelRef's alocated memory is too small to fit the bitmap, then the deserialization will now check this and set an error appropriately. 2 ) If a device fails to allocate its pixels, the device will be deleted and NULL will be returned to avoid attempting to draw on a bad device. BUG= R=senorblanco@chromium.org, reed@google.com, sugoi@google.com, halcanary@google.com, mtklein@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/92793002 git-svn-id: http://skia.googlecode.com/svn/trunk@12484 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
d6bab0238655dbab24dfe92bd0b16b464310a8c7 |
|
02-Dec-2013 |
rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r12427 git-svn-id: http://skia.googlecode.com/svn/trunk@12428 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5b39f5ba9c339d1e4dae391fee9ec1396feec180 |
|
02-Dec-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@12427 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
11f392ed531f05e8de6b6af6ae607f90aeb080c6 |
|
26-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "remove kA1_Config, as it is no longer supported"" This reverts commit 36d712f2d4c5c79719280ad95523e6aaa88b068e. BUG= R=rmistry@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/86483002 git-svn-id: http://skia.googlecode.com/svn/trunk@12392 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ce33d60187718e7bb01944ee130c9f5d9fb335ec |
|
25-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding more validation - Added a way to check that the number of inputs of a filter is not more than a filter expects - Added validation of reftype in SkBitmap::unflatten() - Added validation on fKD (diffuse lighting constant) and fKS (specular lighting constant) to make sure that they are always non-negative numbers - Added validation of SkPerlinNoiseShader::fType and SkPerlinNoiseShader::fNumOctaves BUG= R=reed@google.com, senorblanco@google.com, mtklein@google.com, senorblanco@chromium.org, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/83343003 git-svn-id: http://skia.googlecode.com/svn/trunk@12388 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
72e7808d62c02f0371135b1c152bd00b73f62479 |
|
25-Nov-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "remove kA1_Config, as it is no longer supported" This reverts commit 2d72d8b242eac6e9d30228f5b0a407236491c369. git-svn-id: http://skia.googlecode.com/svn/trunk@12387 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
2a1f4464d150d2dc8c3fe2f39e9fb3503b7f4f54 |
|
25-Nov-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove kA1_Config, as it is no longer supported BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/83093005 git-svn-id: http://skia.googlecode.com/svn/trunk@12384 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6e3e42296b0d7a93325146d9c9a7e23ef90760fe |
|
06-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Break up SkLazyPixelRef functionally into class hierarchy. The reason for this CL is to allow greater decoder flexibility. Chrome currently uses its own decoding functions. These allow for greater flexibility in dealing with images with multiple frames or partial data. The DecodeProc function was not flexible enough to handle these. Instead of asking the decoder to squeeze everything into the DecodeProc, we now ask the downstream library to inherit from SkCachingPixelRef. If WebKit's LazyDecodingPixelRef is re-tooled to inherit from SkCachingPixelRef, then it can make use of Skia's caching ability while still allowing it to deal with multiple frames, scaling, subsetting, and partial data. - The abstract SkCachingPixelRef class handles caching the decoded data in a SkScaledImageCache. This class relies on the virtual functions onDecodeInfo() and onDecode() to do the actual decoding of data. - The SkLazyCachingPixelRef class is derived from SkCachingPixelRef. It provides an implementation of onDecodeInfo() and onDecode() in terms of calls to a SkBitmapFactory::DecodeProc function. It also provides an Install() static method which installs a new SkLazyCachingPixelRef into a SkBitmap. SkLazyCachingPixelRef exists for two reasons: to test SkCachingPixelRef within Skia and as an example for downstream developers to make their own classes that inherit from SkCachingPixelRef. - The CachedDecodingPixelRefTest was updated to test the SkLazyCachingPixelRef class and indirectly the SkCachingPixelRef class. BUG= R=reed@google.com, scroggo@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/54203006 git-svn-id: http://skia.googlecode.com/svn/trunk@12149 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
4469938e92d779dff05e745559e67907bbf21e78 |
|
31-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"" This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d. BUG= Review URL: https://codereview.chromium.org/54603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6fcbfcead5dc1b61fa5b4c139a1a3714e8c58091 |
|
31-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning" This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497. git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
081560e3abe25c4821b79ca1465f4dbd371c4b5c |
|
31-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning BUG= R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/51033004 git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
50a3043194cf278a74ff51c33c6cdb52cbe1f8f9 |
|
24-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
We want to give SkPixelRef a way to signal over to GrResourceCache that it's become pointless to keep around textures based on that SkPixelRef when its pixels change, so that it can be a good citizen and free those textures. This adds an invalidation listener mechanism to SkPixelRef to let it send this message while still staying ignorant of who's listening. These messages are tricky to deliver. The SkPixelRefs they originates from and the GrResourceCaches they ultimately end up at may be on different threads; neither class is threadsafe; their object lifetimes are totally independent; it's a many-senders-to-many-receivers relation; and neither codebase should really know about the other. So I've added a per-message-type global message bus to broadcast messages to threadsafe inboxes. Anyone can post() a message, which will show up in all the inboxes of that type, read whenever the inbox's owner calls poll(). The implementation is _dumb_; it can be improved in several dimensions (inbox size limits, lock-free message delivery) if we find the need. I took some care to make sure not to send the invalidation message for any SkPixelRef that's sharing a generation ID with another SkPixelRef. BUG= R=bsalomon@google.com, scroggo@google.com, reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/26734003 git-svn-id: http://skia.googlecode.com/svn/trunk@11949 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c0b7e10c6a68f59e1653e6c18e6bc954b3c3f0cf |
|
23-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Initial error handling code I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11247 R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11922 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9cd697c69674d9499c86bd4c668e5c1411e0b85e |
|
21-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
change ERROR label to BAD_CONFIG -- avoid windows complaint BUG= Review URL: https://codereview.chromium.org/32623002 git-svn-id: http://skia.googlecode.com/svn/trunk@11878 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
383a697692cf46951fd451f6f4c3d03634a6a1cb |
|
21-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
store SkAlphaType inside SkBitmap, on road to support unpremul BUG= R=bsalomon@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/25275004 git-svn-id: http://skia.googlecode.com/svn/trunk@11877 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
353482251e61971a8cf3a60bbb6910f482be634f |
|
16-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
force readbuffer clients to use specialized readFoo for flattenables BUG= R=mtklein@google.com Review URL: https://codereview.chromium.org/26702002 git-svn-id: http://skia.googlecode.com/svn/trunk@11803 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0197b32bfb98c793c8104cefde26ca62562d1f0e |
|
10-Oct-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Always clear dest in SkBitmap::copyTo's draw path https://codereview.chromium.org/26268003/ git-svn-id: http://skia.googlecode.com/svn/trunk@11697 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0a6151d66cc32d91eca037c91e557158cf8a2be2 |
|
10-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "change SkColorTable to be immutable"" This reverts commit b8162cb840f4cb6002ef68d5ac775c6a122c52a9. Fixed was call-sites in benches that used the (now gone) setIsOpaque api. R=scroggo@google.com Review URL: https://codereview.chromium.org/26572006 git-svn-id: http://skia.googlecode.com/svn/trunk@11695 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
235002fb127fc5b7564910434faed84337c08238 |
|
09-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
low hanging calloc fruit BUG= R=reed@google.com, robertphillips@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/24267014 git-svn-id: http://skia.googlecode.com/svn/trunk@11683 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
48d9ff5b3475ad4b345fae35e1ce36b34069691b |
|
09-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "change SkColorTable to be immutable" This reverts commit 1c0ff422868b3badf5ffe0790a5d051d1896e2f7. BUG= Review URL: https://codereview.chromium.org/26709002 git-svn-id: http://skia.googlecode.com/svn/trunk@11677 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9864c24e40448ef64b1fe367eee1d63a872e51b8 |
|
09-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
change SkColorTable to be immutable BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/25353002 git-svn-id: http://skia.googlecode.com/svn/trunk@11676 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
2c86fbb0b14a1f674bf56ea5ad6a086cc004a76e |
|
26-Sep-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkDivMod with a special case for ARM. BUG=skia:1663 R=djsollen@google.com, tomhudson@google.com, reed@google.com Author: mtklein@google.com Review URL: https://chromiumcodereview.appspot.com/24159009 git-svn-id: http://skia.googlecode.com/svn/trunk@11482 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c8fb9983880e53ee5fee65f04e1f29cf95fdd3b3 |
|
22-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r11423 (low hanging calloc fruit) git-svn-id: http://skia.googlecode.com/svn/trunk@11427 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
2905ff552c75344309e858c4259e7489d3ab586d |
|
20-Sep-2013 |
mtklein@google.com <mtklein@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
low hanging calloc fruit BUG= R=reed@google.com Review URL: https://codereview.chromium.org/24267014 git-svn-id: http://skia.googlecode.com/svn/trunk@11423 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
24ddde97581624777feebc9e95ae558282f95d4c |
|
16-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert 11247, 11250, 11251, 11257, and 11279 to unblock DEPS roll (https://codereview.chromium.org/24159002/) 11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279 11257 Canary build fix - https://codereview.chromium.org/23532068 11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251 11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250 11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11288 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ba6e954140e45e251d67934ed6ad752149fcf72f |
|
16-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert the revert of 11247, 11250, 11251 and 11279 (Chrome already relies on changes in r11247) git-svn-id: http://skia.googlecode.com/svn/trunk@11287 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
478884f7d3b8c7be8b62f3fa2b79192f411c3fec |
|
16-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert 11247, 11250, 11251 and 11279 to unblock DEPS roll (https://codereview.chromium.org/24159002/) 11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279 11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251 11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250 11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11285 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5792cded61a7302f32bd0f4aeda51a9b2f1d00f6 |
|
13-Sep-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Initial error handling code I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure. BUG= R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://chromiumcodereview.appspot.com/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11247 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8dc8bc55479eb7895b3f0cf4fb42d9d917b21ee1 |
|
07-Aug-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add downsample from 8888 to 4444. Extend SkBitmap::copyTo to copy from a source with SkARGB_8888_Config to a destination bitmap with SkARGB_4444_Config. BUG=http://code.google.com/p/chromium/issues/detail?id=245774 R=reed@google.com Review URL: https://codereview.chromium.org/22350003 git-svn-id: http://skia.googlecode.com/svn/trunk@10621 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
7c6d26420d80275bb92f6d9ed86190554b0a6c13 |
|
06-Aug-2013 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix race condition when locking/unlocking pixels. R=reed@google.com Review URL: https://codereview.chromium.org/22235002 git-svn-id: http://skia.googlecode.com/svn/trunk@10556 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
a6ff36bd61a20077a93223d90bc97dce65f2e7e8 |
|
29-Jun-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@9826 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
92833f99b99f1f955c350f6f4f70acd3356a79a5 |
|
28-Jun-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use width() instead of fWidth to get int value git-svn-id: http://skia.googlecode.com/svn/trunk@9816 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
60d3235ab42bd1d32a070695ee30d6e3ec2fa222 |
|
28-Jun-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add bitmap::eraseArea BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/18029021 git-svn-id: http://skia.googlecode.com/svn/trunk@9815 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
b8d00db075b5ea09e353508a26ef5ced50722a6c |
|
26-Jun-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change undefined SkGpuRenderTarget and SkGpuTexture forward declares to GrRenderTarget and GrTexture. R=robertphillips@google.com, reed@google.com Author: bsalomon@google.com Review URL: https://chromiumcodereview.appspot.com/17269003 git-svn-id: http://skia.googlecode.com/svn/trunk@9775 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
afe397b079a854f707640362b44312c4c6e58a06 |
|
26-Jun-2013 |
edisonn@google.com <edisonn@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix build break, remove "RLE" from gConfigNames too Review URL: https://codereview.chromium.org/17893004 git-svn-id: http://skia.googlecode.com/svn/trunk@9765 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
2cb1480ff8ae030946cb5f218f9c5cbc1e54c7a9 |
|
26-Jun-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove kRLE_Index8_Config from SkBitmap BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/17740003 git-svn-id: http://skia.googlecode.com/svn/trunk@9764 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
62b260557d0e9aa9c8a2c08968eddb63a989f3fc |
|
25-Jun-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
move kConfigCount out of Config enum, so we don't pullute type-checking git-svn-id: http://skia.googlecode.com/svn/trunk@9759 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
020b25becb4a99061e8643780c887ad472eb0648 |
|
22-Jun-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@9738 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
45f746f521d6925d22a304921f6e17196f4f8157 |
|
21-Jun-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
restore bitmap.erase() support for 4444 : trivial, and BitmapCopyTest relied on it git-svn-id: http://skia.googlecode.com/svn/trunk@9731 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6ba4572eed5a4ecfdd22d118fa55b5c06902b574 |
|
21-Jun-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove dst/rendertarget support for kARGB_4444_Config BUG= Review URL: https://codereview.chromium.org/17335008 git-svn-id: http://skia.googlecode.com/svn/trunk@9727 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8e990eb440e0f61386ba21b06b8428d5b285c341 |
|
14-Jun-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update SkBitmap::validate to respect Android flag. Without this change, an SkBitmap with hardware mip will assert in validate. R=djsollen@google.com Review URL: https://codereview.chromium.org/16870002 git-svn-id: http://skia.googlecode.com/svn/trunk@9614 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
61d6c9ef8fa1f650722e13d35a9d4d490ffa24b4 |
|
21-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add prototype for warning. Fixes build. Review URL: https://codereview.chromium.org/15536007 git-svn-id: http://skia.googlecode.com/svn/trunk@9227 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
1b1bcc3ceac9b4adbb4de68429903a5f721ffe62 |
|
21-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
New API for encoding bitmaps during serialization. This change gives more flexibility to the implementation of EncodeBitmap to prefer calling refEncodedData, doing its own encode, or even doing both and making a decision about which to use. The new function signature also allows the implementation to tell the ordered write buffer whether to store the pixel offset, in the case where the encoded bitmap represents the larger bitmap, or to ignore the pixel offset, in the case where the implementation only encoded the subset that is used. Requires changes to chromium to use the new function signature. (https://codereview.chromium.org/15496006/) SkPicture: New API for EncodeBitmap. SkOrderedReadBuffer: Ifdef'd out addition of reading the offset. SkOrderedWriteBuffer: Never call refEncodedData. Allow the user to call that from their EncodeBitmap function, if desired. This addresses https://code.google.com/p/skia/issues/detail?id=1239 Add in ifdef'd out code to record the offset. PictureTest and PictureRenderer: Implement the new definition of EncodeBitmap. Also update the name of the function to meet coding style guidelines. BUG=https://code.google.com/p/skia/issues/detail?id=1239 R=reed@google.com Review URL: https://codereview.chromium.org/15489004 git-svn-id: http://skia.googlecode.com/svn/trunk@9226 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
e5f48243bdbed2662be7a31be0888abc273b09e8 |
|
25-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix a bunch of warnings, mainly around rowBytes. My recent change changed the way SkBitmap::fRowBytes is stored, and parameter/return values referring to rowBytes were changed to type size_t. Change the storage back, and eliminate warnings resulting from returning a size_t. Review URL: https://codereview.appspot.com/7396059 git-svn-id: http://skia.googlecode.com/svn/trunk@7855 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0ba4bf427acbd7707d04192a98c77ef194a0f25a |
|
25-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Use size_t for rowBytes. Previously, we were using uint32_t sometimes, int sometimes, and size_t sometimes. Switch to using size_t, since we are actually talking about a number of bytes. In copyPixelsTo, use 0 as a flag to use the internal rowBytes, which is more consistent with setConfig. Review URL: https://codereview.appspot.com/7370047 git-svn-id: http://skia.googlecode.com/svn/trunk@7843 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9349101b6cee7c4cfb570925a727c0bf7b0c676e |
|
05-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement support for origin-TopLeft render targets in GL backend. Committed: https://code.google.com/p/skia/source/detail?r=7545 Reverted in r7571; re-opening. Review URL: https://codereview.appspot.com/7230049 git-svn-id: http://skia.googlecode.com/svn/trunk@7592 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
e16efc1882ab34a0bb3ae361a2d37f840044cf87 |
|
26-Jan-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
76f9e938df0b5826fd4c80b854ceafaf385cfbe1 |
|
15-Jan-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added print out of SkShader information to debugger https://codereview.appspot.com/7105045/ git-svn-id: http://skia.googlecode.com/svn/trunk@7201 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
140d7286c5a40058932696eaa28818c313bd2ddf |
|
07-Jan-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix warnings Review URL: https://codereview.appspot.com/7073044 git-svn-id: http://skia.googlecode.com/svn/trunk@7064 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
a2a31928470dfb642880f6ab2e4d34b1c7f5d476 |
|
07-Dec-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix some extract subset bugs. In SkBitmap::extractSubset, perform a deepCopy, if the pixelRef supports it. Fixes a bug in the 'extractbitmap' gm, which attempts to draw a subset of a texture backed bitmap (if the canvas is really an SkGpuCanvas). Also fix some bugs that happen when there is a pixel offset. These fixes get bypassed by the deepCopy, but a user can still set a pixel offset manually. When copying GPU backed bitmap with a pixel offset, copy the offset. If the new config is the same as the old, copy fRowBytes as well. Add a function to SkBitmap.cpp (getUpperLeftFromOffset) to find the x,y coordinate to use when copying to a new config. Fix a bug where readPixels copied to the correct desired config and we were setting the generation ID to match even though the desired config was not the same as the original config (caught by my new tests!). Add some tests to verify the correct behavior. Review URL: https://codereview.appspot.com/6839043 git-svn-id: http://skia.googlecode.com/svn/trunk@6710 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
dbfac8a72393eaf01670aeb3244de0e18d8faf98 |
|
06-Dec-2012 |
junov@google.com <junov@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Defining new color constat for transparent color Review URL: https://codereview.appspot.com/6901044 git-svn-id: http://skia.googlecode.com/svn/trunk@6696 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
2a7579d11796866b0026755ab52597d09f4509cc |
|
07-Nov-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
CG imagedecoder never sets isOpaque, so add method to SkBitmap to compute that, and call it from CG imagedecoder. Review URL: https://codereview.appspot.com/6816101 git-svn-id: http://skia.googlecode.com/svn/trunk@6334 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
1bdb857768e4a01489060e16c875fa553a847a25 |
|
25-Oct-2012 |
bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX test since it has been rebaselined. https://codereview.appspot.com/6778044/ git-svn-id: http://skia.googlecode.com/svn/trunk@6111 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
04685d29b1c5280717dfcd63c3cbe1ee84fa6923 |
|
15-Oct-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
#define SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX to keep old, slow, non-opaque behavior in SkBitmap::extractSubset. This will allow chrome to keep this behavior until we can fix the callers in PNG and WEBP image decoders, that are incorrectly marking partially-loaded images as opaque (which they aren't, since they have undecoded pixels, which need to be transparent). git-svn-id: http://skia.googlecode.com/svn/trunk@5949 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
3768853169d5eac2198cd1199637edb1101b47b5 |
|
12-Oct-2012 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r3219. r3219 was a revert of r3036. r3036 made extractSubset copy the opaque bit but was reverted because of a partally-loaded jpeg issue in WK which has since been fixed: https://bugs.webkit.org/show_bug.cgi?id=78239 Related chrome bug: http://code.google.com/p/chromium/issues/detail?id=114107 git-svn-id: http://skia.googlecode.com/svn/trunk@5911 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5b5bba36dcbc69b0033c2acc9981734956394816 |
|
24-Sep-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Addressed xcode analysis complaints http://codereview.appspot.com/6558048/ git-svn-id: http://skia.googlecode.com/svn/trunk@5646 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
fbfcd5602128ec010c82cb733c9cdc0a3254f9f3 |
|
23-Aug-2012 |
rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) This CL is part I of IV (I broke down the 1280 files into 4 CLs). Review URL: https://codereview.appspot.com/6485054 git-svn-id: http://skia.googlecode.com/svn/trunk@5262 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
d5764e8ab731dd12df9293e52ce644eaa45333bd |
|
22-Aug-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
When copying a bitmap, copy the generation ID. Review URL: https://codereview.appspot.com/6462084 git-svn-id: http://skia.googlecode.com/svn/trunk@5227 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
21830d90096d2dccc4168d99a427e78035ce942a |
|
07-Aug-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactor Bitmap Storage for SkPicture using SkPipe's design. Refactor Picture and Pipe bitmap storage into common data structure Update SkFlattenable buffers to be more modular. This CL is an effort to stage the conversion to named parameters for all SkFlattenable commands. This particular stage only does the following two things... 1. Move flattenable buffers from SkFlattenable.h into their own header. 2. Update and Add new read write methods for better clarity and convenience. BUG= Review URL: https://codereview.appspot.com/6445079 git-svn-id: http://skia.googlecode.com/svn/trunk@4994 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c73dd5c6880739f26216f198c757028fd28df1a4 |
|
07-Aug-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update SkFlattenable buffers to be more modular. This CL is an effort to stage the conversion to named parameters for all SkFlattenable commands. This particular stage only does the following two things... 1. Move flattenable buffers from SkFlattenable.h into their own header. 2. Update and Add new read write methods for better clarity and convenience. BUG= Review URL: https://codereview.appspot.com/6448095 git-svn-id: http://skia.googlecode.com/svn/trunk@4980 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8e1034e9ca0e3009f65125239e21b06ec51a55a6 |
|
30-Jul-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
detect null pixles in setPixels() and just clear out any existing pixelref. git-svn-id: http://skia.googlecode.com/svn/trunk@4827 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c84b8335ee4fd864c30a4703afc643cf4b5010d9 |
|
27-Jul-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reapply "Remove Bitmaps Raw Pixel Support." This CL reapplies r4722. Now that we have addressed the issues in Chrome tests that were causing asserts to be fired. Review URL: https://codereview.appspot.com/6452050 git-svn-id: http://skia.googlecode.com/svn/trunk@4804 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
56f8f338b6d2f9c75bfb045db51405fcab351cd0 |
|
26-Jul-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Remove Bitmaps Raw Pixel Support." BUG= TEST= Review URL: https://codereview.appspot.com/6449049 git-svn-id: http://skia.googlecode.com/svn/trunk@4780 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
7cf0e9e555290e11d18496a01d85a0ece00b3f43 |
|
25-Jul-2012 |
bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Prevent MipMaps from crashing. git-svn-id: http://skia.googlecode.com/svn/trunk@4753 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c1d1f414a08de25d8cbf4ba08fc64d701ffca32e |
|
23-Jul-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove Bitmaps Raw Pixel Support. bitmap.setPixels(...) now creates a mutable pixelRef instead of just setting fPixels. Review URL: https://codereview.appspot.com/6419044 git-svn-id: http://skia.googlecode.com/svn/trunk@4722 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
15e9d3e66e161ce23df30bc13f8a0c87d196b463 |
|
21-Jun-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Expanded distribution of instance counting http://codereview.appspot.com/6300114/ git-svn-id: http://skia.googlecode.com/svn/trunk@4291 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8ae3c7f67eb3721bb656cffeadc1442332f10159 |
|
13-Jun-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
For SkGPipe, store bitmaps in a common location. Also make a change to SkBitmap::copyTo() so that we do not crash. Review URL: https://codereview.appspot.com/6296066 git-svn-id: http://skia.googlecode.com/svn/trunk@4249 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
64a0ec36555352ec31aa7c5a7630a5d042b010ba |
|
12-Jun-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Move SkColorTable into its own header and reduce includes in SkFlattenable.h Review URL: https://codereview.appspot.com/6299072 git-svn-id: http://skia.googlecode.com/svn/trunk@4236 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
1f90287df3129cb267422e482c52ebeca6a8990f |
|
01-Jun-2012 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Punctuation cleanup to satisfy idiosyncracies of OpenBSD gcc 4.2.1. Original patch by landry.breuil. http://code.google.com/p/skia/issues/detail?id=626 git-svn-id: http://skia.googlecode.com/svn/trunk@4112 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ff0da4ff483ba7b4468b862949ffb3de505cba14 |
|
17-May-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Mutexes in pixelrefs were done very sloppily initially. The code (a) assumes all pixelref subclasses want a mutex to guard their lock/unlock virtuals, and (b) most subclasses use the same mutex for *all* of their instances, even when there is no explicit need to guard modifying one instances with another. When we try drawing bitmaps from multiple threads, we are seeing a lot of slow- down from these mutexes. This CL has two changes to try to speed things up. 1. Add setPreLocked(), for pixelrefs who never need the onLockPixels virtual to be called. This speeds up those subclasses in multithreaded environs as it avoids the mutex lock all together (e.g. SkMallocPixelRef). 2. Add setMutex() to allow a subclass to change the mutex choice. ashmem wants this, since its unflattening constructor cannot pass down the null, it needs to cleanup afterwards. Review URL: https://codereview.appspot.com/6199075 git-svn-id: http://skia.googlecode.com/svn/trunk@3985 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
5370cd969d8f3957e4306068e6195ac1bca3d6cd |
|
28-Mar-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Consolidate PixelRef flattables with the standard impl The flatten method on these functions can no longer be const as SkFlattenables declaration is not const and would result in the const methods only being called when the reference to the object was const. Review URL: https://codereview.appspot.com/5941043 git-svn-id: http://skia.googlecode.com/svn/trunk@3533 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
d43b0a87f85ca26ec771e094c62df33b0537b563 |
|
26-Mar-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make use of the functions in the flattenable reader/writer Review URL: https://codereview.appspot.com/5905066 git-svn-id: http://skia.googlecode.com/svn/trunk@3493 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
80e1459c32f5f3acbc688ae4f0e046aa283e8c3a |
|
16-Mar-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add IRect variant of getBounds() git-svn-id: http://skia.googlecode.com/svn/trunk@3414 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
86b2e43a33c486a0b150aa14fadf7af8323a11f5 |
|
15-Mar-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add getBounds() helper git-svn-id: http://skia.googlecode.com/svn/trunk@3409 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
543c719a6d2d8f27f125cb5cb02aaa9c2e563bfd |
|
17-Feb-2012 |
caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r3036. This change breaks loading images as described in Chromium issue 114107. The Chromium break may be fixed by WebKit patch 78239, at which time this patch can be reapplied. Review URL: https://codereview.appspot.com/5675077 git-svn-id: http://skia.googlecode.com/svn/trunk@3219 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0eb7576c659a165f1d73b6b7ddfd43dc3782f62b |
|
16-Jan-2012 |
skyostil@google.com <skyostil@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Modify SkBitmap::extractSubset() to respect volatility The resulting subset bitmap will always have the same volatility flag as the source bitmap. BUG=452 Review URL: http://codereview.appspot.com/5544052 git-svn-id: http://skia.googlecode.com/svn/trunk@3039 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ce7adb580ee7cc608e1049732b1ebb3f0533df4a |
|
13-Jan-2012 |
skyostil@google.com <skyostil@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Modify SkBitmap::extractSubset() to respect opaqueness The resulting subset bitmap will always have the same opaqueness flag as the source bitmap. BUG=439 Review URL: http://codereview.appspot.com/5534051 git-svn-id: http://skia.googlecode.com/svn/trunk@3036 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0c00f21fee3f5cfa3aa7e5d46ff94cb8cf340451 |
|
28-Dec-2011 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkDEBUGFAIL to clean up use of SkASSERT(!"text"); catch a couple of latent SkASSERT("text") bugs. http://codereview.appspot.com/5504090/ git-svn-id: http://skia.googlecode.com/svn/trunk@2926 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
b052129a4121c1e3f051e374541a93d3d7a98064 |
|
15-Dec-2011 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Exposing the isImmutable/setImmutable API of SkPixelRef in SkBitmap REVIEW=http://codereview.appspot.com/5491055/ git-svn-id: http://skia.googlecode.com/svn/trunk@2883 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ef843cdcd1be858fe55cc99ff134ffbd080c9a51 |
|
02-Dec-2011 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
When a bitmap is texture-backed, change SkBitmap::copyTo() to do a deep copy of the texels in VRAM rather than a readback and re-upload. This gives a 3-10X speedup on recursive canvas-to-canvas draws. N.B.: This introduces a new GM test, which will need new baselines. git-svn-id: http://skia.googlecode.com/svn/trunk@2790 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
c69809745e6496564639e42ef998ad39adf7dfb8 |
|
02-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Recommit r2584 with gpu pass of the new ReadPixels test disabled in fixed pt (gpu code doesn't work in general in fixed pt). git-svn-id: http://skia.googlecode.com/svn/trunk@2586 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ace7bd5623354ffabbd224d5b76550bab159c296 |
|
02-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r2584 (new test fails in fixed pt builds) git-svn-id: http://skia.googlecode.com/svn/trunk@2585 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
1a8ddf0a35bfb6c21a1184f81d2fdd50053acf31 |
|
02-Nov-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Changes the SkCanvas::readPixels API. Allows caller to read into prealloced bitmap pixels. Changes how clipping to device bounds is handled. Review URL: http://codereview.appspot.com/5307077/ git-svn-id: http://skia.googlecode.com/svn/trunk@2584 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
cad8176281c787c64e83fb5028731c021f84becb |
|
01-Nov-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove unused copyPixelsFrom ... (copyPixelsTo is next on the chopping block) git-svn-id: http://skia.googlecode.com/svn/trunk@2579 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
02f55841854ae32f21a13417e9ee711463e488cf |
|
04-Oct-2011 |
bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change SkAutoMaskImage so that we're less likely to write leaky code. http://codereview.appspot.com/5180047/ git-svn-id: http://skia.googlecode.com/svn/trunk@2409 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ec3ed6a5ebf6f2c406d7bcf94b6bc34fcaeb976e |
|
28-Jul-2011 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Automatic update of all copyright notices to reflect new license terms. I have manually examined all of these diffs and restored a few files that seem to require manual adjustment. The following files still need to be modified manually, in a separate CL: android_sample/SampleApp/AndroidManifest.xml android_sample/SampleApp/res/layout/layout.xml android_sample/SampleApp/res/menu/sample.xml android_sample/SampleApp/res/values/strings.xml android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java experimental/CiCarbonSampleMain.c experimental/CocoaDebugger/main.m experimental/FileReaderApp/main.m experimental/SimpleCocoaApp/main.m experimental/iOSSampleApp/Shared/SkAlertPrompt.h experimental/iOSSampleApp/Shared/SkAlertPrompt.m experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig gpu/src/android/GrGLDefaultInterface_android.cpp gyp/common.gypi gyp_skia include/ports/SkHarfBuzzFont.h include/views/SkOSWindow_wxwidgets.h make.bat make.py src/opts/memset.arm.S src/opts/memset16_neon.S src/opts/memset32_neon.S src/opts/opts_check_arm.cpp src/ports/SkDebug_brew.cpp src/ports/SkMemory_brew.cpp src/ports/SkOSFile_brew.cpp src/ports/SkXMLParser_empty.cpp src/utils/ios/SkImageDecoder_iOS.mm src/utils/ios/SkOSFile_iOS.mm src/utils/ios/SkStream_NSData.mm tests/FillPathTest.cpp Review URL: http://codereview.appspot.com/4816058 git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9c49bc3e643c435677727c1c0904c4a7cb7a6907 |
|
07-Jul-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow texture-backed bitmaps to perform a read-back when lockPixels is called. This means we have to be even more cautious about when we call lock, and we should always check getTexture() first if we can handle a texture directly, rather than forcing the read-back to get the bits. git-svn-id: http://skia.googlecode.com/svn/trunk@1815 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
4ee7ae5dcfe2055cfcfc21bf2cec1d790330eb4a |
|
30-Jun-2011 |
junov@google.com <junov@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding the notion of a volatile bitmap to SkBitmap. Volatility is a hint that indicates that the contents of a bitmap are ephemeral. SkGpuDevice will not preserve volatile bitmaps in its texture cache, and will use textures from a pool of keyless (recyclable) textures to avoid the performance hit of texture allocation and release. A subsequent change is required in webkit in order to take advantage of this optimization. putImageData, and other methods that create temporary bitmaps will have to mark their bitmaps as volatile. before rendering them through skia. git-svn-id: http://skia.googlecode.com/svn/trunk@1769 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
a87cd2af4c7f46ba8437c2e500805c9deb9e3a40 |
|
15-Jun-2011 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Increase compatibility with clang, mostly around SK_RESTRICT. Attempting to fix up our use of __restrict__ so Chrome can enable it. git-svn-id: http://skia.googlecode.com/svn/trunk@1597 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
3b521d05335a1bf76be3456feb9dbfba0a51b339 |
|
29-Apr-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
update dox code style git-svn-id: http://skia.googlecode.com/svn/trunk@1215 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
586f48cfa8b1fa7b29d8ee8d0a028489a33866de |
|
14-Apr-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add genID for SkBitmaps with raw pixels Review URL: http://codereview.appspot.com/4413047/ git-svn-id: http://skia.googlecode.com/svn/trunk@1125 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
669fdc4ed8ed461a141cb97d0afdd9ef72a82be1 |
|
05-Apr-2011 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adds read pixels to GrTexture and GrRenderTarget Adds SkGrRenderTargetPixelRef for SkBitmaps that are backed by RTs that aren't textures. Adds onReadPixels implementations for SkGr pixel ref types git-svn-id: http://skia.googlecode.com/svn/trunk@1056 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
50dfa0130b0705414df7ba7da9915139f6320b09 |
|
01-Apr-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add pixelref->readPixels() unimplemented (for now) on the gpu side git-svn-id: http://skia.googlecode.com/svn/trunk@1037 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
cd9d69b9ce7eb301a9fd8d91b9f95fd99b07bae5 |
|
14-Mar-2011 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Upstreaming changes from android. - fix compile warnings in the GPU code - upstream android specific code (ifdef protected) - fail gracefully when a custom allocator fails git-svn-id: http://skia.googlecode.com/svn/trunk@936 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
112706d4c566e283890322bb246b4b86d59837e1 |
|
24-Feb-2011 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkBitmap::getColor(int x, int y) - return the color of a pixel in a bitmap. Review URL: http://codereview.appspot.com/4230041 git-svn-id: http://skia.googlecode.com/svn/trunk@854 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
57f4969724a1dd88c8d9ae35a863e6cf621181d5 |
|
23-Feb-2011 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
merge from android tree: - optional parameters added to descriptorProc and allocPixels - clip options to image decoders - check for xfermode in blitter_a8 - UNROLL loops in blitrow reviewed by reed@google.com git-svn-id: http://skia.googlecode.com/svn/trunk@841 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
3f0260d0f7692f28057cfcf7121829285e972e28 |
|
22-Feb-2011 |
wjmaclean@chromium.org <wjmaclean@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Cleanup issues related to SkBitmap getSize()/extractSubset(). Some minor revisions to do cleanup regarding getSize() and extractSubset(). All are related to avoid read/write past end of the pixel buffer when getSize() is used on a bitmap that is the result of a call to extractSubset(). git-svn-id: http://skia.googlecode.com/svn/trunk@835 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
82065d667f64e232bcde2ad849756a6096fcbe6f |
|
07-Feb-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SkRefCnt safeRef() and safeUnref(), and replace the call-sites with SkSafeRef() and SkSafeUnref(). This is basically a bug waiting to happen. An optimizing compiler can remove checks for null on "this" if it chooses. However, SkRefCnt::safeRef() relies on precisely this check... void SkRefCnt::safeRef() { if (this) { this->ref(); } } Since a compiler might skip the if-clause, it breaks the intention of this method, hence its removal. static inline void SkSafeRef(SkRefCnt* obj) { if (obj) { obj->ref(); } } This form is not ignored by an optimizing compile, so we use it instead. git-svn-id: http://skia.googlecode.com/svn/trunk@762 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
0bde180bf12207f69685ed16f3fba37ef496b448 |
|
22-Dec-2010 |
wjmaclean@chromium.org <wjmaclean@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Security fixes re getSize(). git-svn-id: http://skia.googlecode.com/svn/trunk@646 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
86bff1f008308267c4ff75456b202a9cf60c6193 |
|
16-Nov-2010 |
wjmaclean@chromium.org <wjmaclean@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add safe size/copy functions to Skia. This patch adds four methods to SkBitmap. There are two functions to return "safe size", defined as the number of pixels from the value returned by getPixels() to the end of the allocated buffer. There is one version of fillPixels() to copy the bitmap instance into an external buffer (with specified size, and using specified stride), and another fillPixels() to copy from an external buffer to the instance bitmap. In the latter case the specified height, width and pixel format must match that used by the bitmap instance, although the specified stride may be any value at least as large as the minimum stride for the specified geometry. It is assumed that the external buffer is of size at least (height - 1)*stride + width * bytesPerPixel. Both fillPixels() functions return false if the copy is not possible with the specified parameters. Review URL: http://codereview.appspot.com/2837041/ git-svn-id: http://skia.googlecode.com/svn/trunk@625 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
49099b25367d1b9ef45ccaa7fe370facea6b89bf |
|
09-Sep-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
move SkMallocPixelRef into its own .cpp file, rather than embedding it inside SkBitmap.cpp. core_files.mk updated, but if your build does not reference that, you will need to add SkMallocPixelRef.cpp to your list git-svn-id: http://skia.googlecode.com/svn/trunk@597 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
ce4e53a2347040a3c145768c193a7a7958c0d4ec |
|
09-Sep-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add abstract wrapper for platform-specific bitmap backends git-svn-id: http://skia.googlecode.com/svn/trunk@596 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
1cdcb5138f9b70aff547ea1c3af96f0c90b12f8f |
|
24-Aug-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix warning in sampler lock pixels when we extract alpha disabling hinting when linear-text is set git-svn-id: http://skia.googlecode.com/svn/trunk@333 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
cafc9f9e80e30fa75ad8a952e7a290e72f211ce7 |
|
22-Aug-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fixes around isOpaque and dithering - copyTo() now preserves isOpaqueness, and BitmapCopyTest tests it - bitmap shader doesn't claim to have shadespan16 if dithering is on, since its sampler doesn't auto-dither (note that gradients do auto-dither in their 16bit sampler) - blitter setup just relies on the shader to report if its 16bit sampler can be called (allowing gradients to say yes regardless of dither, but bitmaps to say no if dithering is on) git-svn-id: http://skia.googlecode.com/svn/trunk@331 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
83f7bc30af2837c985934e14597caec332899a1c |
|
17-Jul-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove conditional build flag for mipmaps remove obsolete SkBitmapShader.cpp file git-svn-id: http://skia.googlecode.com/svn/trunk@271 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
4516f4786f5dda1b86a8f825b9e8e910d9c2363c |
|
29-Jun-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use sk_bzero instead of bzero, since it isn't always available. git-svn-id: http://skia.googlecode.com/svn/trunk@244 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
829c83c7c9a997993207b68f6fcaf7a5bbcd10b2 |
|
08-Jun-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix odd-pixel bug in mipmap downsamplers (thanks brett) git-svn-id: http://skia.googlecode.com/svn/trunk@204 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
9e0c2fcdafa8f2cfe2113e6335eff4efe3e28c86 |
|
02-Jun-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix break in setConfig() where we always reset the bitmap remove use of non-standard ssize_t in SkSfntUtils.cpp git-svn-id: http://skia.googlecode.com/svn/trunk@197 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
6b8cb256e62b22f921b7e41eb44b07ab7cc0bd56 |
|
02-Jun-2009 |
agl@chromium.org <agl@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Style only change to make SkBitmap to make it build with VC2005. TBR=reed git-svn-id: http://skia.googlecode.com/svn/trunk@196 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
89bb83abb420c126b02fcdd4047fd6574e9b73fc |
|
29-May-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix trailing-ws initialize fFlags in bitmapprocshader git-svn-id: http://skia.googlecode.com/svn/trunk@191 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
149e2f6159a797989f6f0fa93ecfaa66cdd55c40 |
|
22-May-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkSafeRef / SkSafeUnref as inline static functions, to use in place of our existing obj->safeRef(), which is unsafe since it can its 'if (this)' can be optimized away by some compilers. fix some overflows in mimpmap generation git-svn-id: http://skia.googlecode.com/svn/trunk@181 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
fbaa88d9695347299321cbce2bf803726999fb58 |
|
06-May-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add canCopyTo(), to preflight if copyTo can succeed. update unittests for it git-svn-id: http://skia.googlecode.com/svn/trunk@169 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
311c82db3115fc6810855cbcc42a6bc6fbd48265 |
|
06-May-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix copyTo to only copy the minimum pixels per row, and to lock the src before trying to access its colorTable. Update unittest for copyTo. Add sample for using a mask to clip a layer. git-svn-id: http://skia.googlecode.com/svn/trunk@168 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
f9ab99aaade8c451c0e9309b4c61a448373019e3 |
|
03-May-2009 |
weita@google.com <weita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow copying an Index8 bitmap when srcConfig and dstConfig are both Index8. Also, change the logic of SkBitmap.copyTo() to do memcpy() if srcConfig and dstConfig are the same. git-svn-id: http://skia.googlecode.com/svn/trunk@164 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
f459a4949d4edb179e015cf12635d26c596fd17c |
|
27-Mar-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make bitmap width/height 32bits, matching the API git-svn-id: http://skia.googlecode.com/svn/trunk@137 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
49f0ff25a046d6001dc2d095b6fa3c30f0f46b6a |
|
19-Mar-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
promote SkMask's rowBytes to 32bits, since its bounds is a 32bit rect be sure a rect is sorted before using it as the path's bounds cache git-svn-id: http://skia.googlecode.com/svn/trunk@128 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|
8a1c16ff38322f0210116fa7293eb8817c7e477e |
|
17-Dec-2008 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
grab from latest android git-svn-id: http://skia.googlecode.com/svn/trunk@27 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkBitmap.cpp
|