| 8dc8dbc8211e7b0245a6e7db911265efbe0fccaf |
|
05-Jan-2018 |
Mike Reed <reed@google.com> |
begin cleanup of malloc porting layer
1. Merge some of the allocators into sk_malloc_flags by redefining a flag to mean zero-init
2. Add more private helpers to simplify our call-sites (and handle some overflow mul checks)
3. The 2-param helpers rely on the saturating SkSafeMath::Mul to pass max_size_t as the request,
which should always fail.
Bug:508641
Change-Id: I322f1e6ed91113467e0fdb12c91c3dad33d890c8
Reviewed-on: https://skia-review.googlesource.com/90940
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 63fd760a37905c45d26fc3d49cac261fad1b4808 |
|
09-Oct-2017 |
Ben Wagner <bungeman@google.com> |
Remove trailing whitespace.
Also adds a presubmit to prevent adding trailing whitespace to source
code in the future.
Change-Id: I41a4df81487f6f00aa19b188f0cac6a3377efde6
Reviewed-on: https://skia-review.googlesource.com/57380
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| c5eb97dd8875accf2b5db5343dace78d0d4c6f79 |
|
09-Oct-2017 |
Mike Reed <reed@google.com> |
add helper to check for overflow
pre-CL to aid in changing the convention for when we overflow
Bug: skia:
Change-Id: I1e34a18fefb80187787a1c0c8ed7ee3516744d24
Reviewed-on: https://skia-review.googlesource.com/57103
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 384f0a7d6626026f21313e85e51890d747171ee8 |
|
06-Oct-2017 |
Mike Reed <reed@google.com> |
Revert "change computeByteSize to return max_size_t on overflow"
This reverts commit 24295462722fd5a298d108a80b0aacbb0964da53.
Reason for revert: broke running dm on google3
Original change's description:
> change computeByteSize to return max_size_t on overflow
>
> Bug: skia:7132
> Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf
> Reviewed-on: https://skia-review.googlesource.com/56620
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=bungeman@google.com,herb@google.com,reed@google.com
Change-Id: I5f58ec37241d2fae3ebdb7a3d6b41f9fd6d3c2ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7132
Reviewed-on: https://skia-review.googlesource.com/56880
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 24295462722fd5a298d108a80b0aacbb0964da53 |
|
06-Oct-2017 |
Mike Reed <reed@google.com> |
change computeByteSize to return max_size_t on overflow
Bug: skia:7132
Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf
Reviewed-on: https://skia-review.googlesource.com/56620
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| f0ffb8943b7be477b769db23660a80013f3332eb |
|
03-Oct-2017 |
Mike Reed <reed@google.com> |
Revert[4] "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"
This reverts commit 5a2e50edc51006ce91366e177a9d21a16775d7fd.
Bug: skia:
Change-Id: I8d28b5c07d90130e5a1653923740eaf189ecb954
Reviewed-on: https://skia-review.googlesource.com/53900
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 5a2e50edc51006ce91366e177a9d21a16775d7fd |
|
02-Oct-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"""
This reverts commit cd284c532376d16fcc4ed75baf3da65c3e4a2e95.
Reason for revert:
assert fired in SkMallocPixelRef.cpp:61: fatal error: "assert(info.computeByteSize(rowBytes) == info.getSafeSize(rowBytes))"
google3 thinks it was from surface_rowbytes
Original change's description:
> Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap""
>
> This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0.
>
> Bug: skia:
> Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d
> Reviewed-on: https://skia-review.googlesource.com/52665
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
TBR=fmalita@chromium.org,reed@google.com
Change-Id: I41e3f7a3f791cc8183291847e783ed8a53bc91d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/53802
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| cd284c532376d16fcc4ed75baf3da65c3e4a2e95 |
|
29-Sep-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap""
This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0.
Bug: skia:
Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d
Reviewed-on: https://skia-review.googlesource.com/52665
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkBitmapCache.cpp
|
| 809cbedd4b252be221b2ac3b4269d312fd8f53a0 |
|
28-Sep-2017 |
Jim Van Verth <jvanverth@google.com> |
Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"
This reverts commit 88757dacd4f532a0f647c02ae0ee596d31ab5c68.
Reason for revert: Still seems to be failing Chromium "telemetry_perf_unittests (with patch) on Android" on android_n5x_swarming_rel.
Original change's description:
> guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
>
> Now with legacy behavior for allocpixels
>
> This was reverted, so the current CL is a "fix" on top of ...
> https://skia-review.googlesource.com/c/skia/+/50980
>
> Related update to Chrome (in preparation for this change)
> https://chromium-review.googlesource.com/c/chromium/src/+/685719
>
> Bug: skia:
> Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9
> Reviewed-on: https://skia-review.googlesource.com/51341
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=fmalita@chromium.org,reed@google.com
Change-Id: I827a0ca1d1e3909e648fde3342cdb8601d34da8d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/52381
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 88757dacd4f532a0f647c02ae0ee596d31ab5c68 |
|
26-Sep-2017 |
Mike Reed <reed@google.com> |
guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
Now with legacy behavior for allocpixels
This was reverted, so the current CL is a "fix" on top of ...
https://skia-review.googlesource.com/c/skia/+/50980
Related update to Chrome (in preparation for this change)
https://chromium-review.googlesource.com/c/chromium/src/+/685719
Bug: skia:
Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9
Reviewed-on: https://skia-review.googlesource.com/51341
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| f46633f8af5296341e33ec4cdb69c71dfa997396 |
|
26-Sep-2017 |
Greg Daniel <egdaniel@google.com> |
Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"
This reverts commit 98a6216b18b57c2f7a0d58f542c60503686aed69.
Reason for revert: breaking the chrome roll. Looks like they may be writing data to create an image across all the row bytes and thus writing to unalloced data on the last row. Link to example failing bot:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/539960
Original change's description:
> guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
>
> Previously we had size_t and uint64_t variations.
>
> The new (simpler) API always..
> - returns size_t, or 0 if the calculation overflowed
> - returns the trimmed size (does not include rowBytes padding for the last row)
>
> Bug: skia:
> Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e
> Reviewed-on: https://skia-review.googlesource.com/50980
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Leon Scroggins <scroggo@google.com>
TBR=mtklein@google.com,herb@google.com,scroggo@google.com,fmalita@chromium.org,reed@google.com
Change-Id: I726f6ab1b36b14979ba6f37105e0a469b3f0dbc0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/51262
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 98a6216b18b57c2f7a0d58f542c60503686aed69 |
|
26-Sep-2017 |
Mike Reed <reed@google.com> |
guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
Previously we had size_t and uint64_t variations.
The new (simpler) API always..
- returns size_t, or 0 if the calculation overflowed
- returns the trimmed size (does not include rowBytes padding for the last row)
Bug: skia:
Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e
Reviewed-on: https://skia-review.googlesource.com/50980
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 086a427b0cee3862f25c492fc5082ff24105dc53 |
|
18-Jul-2017 |
Mike Reed <reed@google.com> |
guard references to SkColorTable
Bug: skia:6828
Change-Id: I0c8c78e70b118f51cb59dc45675e4ddcd4776108
Reviewed-on: https://skia-review.googlesource.com/24260
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 7a542c559a6e584107b94e6254ac3c7f9f24b591 |
|
11-Apr-2017 |
Mike Reed <reed@google.com> |
Change bitmapcache to not rely on lockpixels.
The Rec in the cache is the owner of the pixel memory
- discardable or
- malloc
Each external client has a pixelref that just points to those pixels,
and whose destructor will notify the rec.
This eliminates the dependency on lockPixels in pixelref, freeing us
to remove that entirely from pixelref.
Bug: skia:
Change-Id: If45ed0ae202a1211336626364235215253e8aa7c
Reviewed-on: https://skia-review.googlesource.com/10300
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 5fa3d6d4b15fd6417de877561f5e4bca422e383c |
|
25-Mar-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "simplify api to bitmapcache""
Remove (for now) overly agressive assert
This reverts commit dd1b4e94c4298213f1f238a8634471086d6749fb.
Bug: skia:
Change-Id: Ibdcf0b2e92cf108ae710cd180d4fa359f81176d1
Reviewed-on: https://skia-review.googlesource.com/10129
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| dd1b4e94c4298213f1f238a8634471086d6749fb |
|
24-Mar-2017 |
Florin Malita <fmalita@chromium.org> |
Revert "simplify api to bitmapcache"
This reverts commit 9f4b0ae91e1875831cc11f0629b5db998ad85438.
Reason for revert: Nanobench asserts.
../../../src/core/SkBitmapCache.cpp:81: fatal error: "assert(scaledWidth != image->width() || scaledHeight != image->height())"
Aborted
Command exited with code 134
step returned non-zero exit code: 134
https://chromium-swarm.appspot.com/task?id=351b1d10c7936310&refresh=10
Original change's description:
> simplify api to bitmapcache
>
> Force all Find callers to make a bitmpacachedesc, which now
> has more rigid validation.
>
> Goal is to ensure we never make two desc (which turn into keys)
> that look different but represent the same image/transformation.
>
> BUG=skia:
>
> Change-Id: I8571837ee4754a69acc99e949bee9a465fa25f2b
> Reviewed-on: https://skia-review.googlesource.com/10114
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
>
TBR=brianosman@google.com,fmalita@chromium.org,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Change-Id: I21b3c8a5bae409ba740cfc28b352c3b970dcf5af
Reviewed-on: https://skia-review.googlesource.com/10171
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkBitmapCache.cpp
|
| 9f4b0ae91e1875831cc11f0629b5db998ad85438 |
|
24-Mar-2017 |
Mike Reed <reed@google.com> |
simplify api to bitmapcache
Force all Find callers to make a bitmpacachedesc, which now
has more rigid validation.
Goal is to ensure we never make two desc (which turn into keys)
that look different but represent the same image/transformation.
BUG=skia:
Change-Id: I8571837ee4754a69acc99e949bee9a465fa25f2b
Reviewed-on: https://skia-review.googlesource.com/10114
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 4dc6474b73ec4e5d6a1a0070e50d3d6766e4c94a |
|
23-Mar-2017 |
Mike Reed <reed@google.com> |
remove dead code in bitmapcache
BUG=skia:
Change-Id: If17511179851ac192758f9d96092ff6dd7c60888
Reviewed-on: https://skia-review.googlesource.com/10055
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| d3b65972aad96453ff4510caa3e25a2b847c6d1e |
|
22-Mar-2017 |
Brian Salomon <bsalomon@google.com> |
Mark overridden destructors with 'override' and remove 'virtual'
This silences a new warning in clang 5.0
Change-Id: Ieb5b75a6ffed60107c3fd16075d2ecfd515b55e8
Reviewed-on: https://skia-review.googlesource.com/10006
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkBitmapCache.cpp
|
| 7b8400dad2f82dcc6ed3c7cc1707ebaf85f04840 |
|
08-Nov-2016 |
Brian Osman <brianosman@google.com> |
Rename SkSourceGammaTreatment to SkDestinationSurfaceColorMode
This is much more explicit about what that type represents (are we in
legacy mode or not), which also makes it suitable for other (upcoming)
usage.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4529
Change-Id: Iacb397c34e7765f1ca86c0195bc622b2be4d9acf
Reviewed-on: https://skia-review.googlesource.com/4529
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| d3a2af75a959823a6a6d143409a64414ac64896a |
|
07-Nov-2016 |
Mike Reed <reed@google.com> |
minor simplification: use SkBitmapCacheDesc
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4523
Change-Id: I2bbcbc8a9839e74195ff147cab2cd1e6ab34b4c5
Reviewed-on: https://skia-review.googlesource.com/4523
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBitmapCache.cpp
|
| 6644d9353f3f0c09914385fd762e073f98d54205 |
|
10-Jun-2016 |
reed <reed@google.com> |
respect srgb gamma when building mips
Proposed policy:
- If the target is *legacy* (e.g. L32/PMColor) ignore gamma
- If the target is S32/F16 respect gamma
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2029373004
Review-Url: https://codereview.chromium.org/2029373004
/external/skia/src/core/SkBitmapCache.cpp
|
| 98ed7b6d01c16ad9ace652ec25861689d765d0b5 |
|
15-Sep-2015 |
reed <reed@google.com> |
create SkBitmapProvider to abstract images and bitmaps
BUG=skia:
Review URL: https://codereview.chromium.org/1340223003
/external/skia/src/core/SkBitmapCache.cpp
|
| 995b4bddd9a1eef933b0acb3ff03c98e7864a8f9 |
|
14-Sep-2015 |
reed <reed@google.com> |
be sure to use cached bitmap when we need to upload something to make a texture
BUG=skia:4334
Review URL: https://codereview.chromium.org/1338373002
/external/skia/src/core/SkBitmapCache.cpp
|
| 99138876a699a41637fe8c46ccdb0292dcabd7ce |
|
01-Sep-2015 |
reed <reed@google.com> |
simplify bitmap scaler and cache
BUG=skia:
Review URL: https://codereview.chromium.org/1320513005
/external/skia/src/core/SkBitmapCache.cpp
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkBitmapCache.cpp
|
| 385fe4d4b62d7d1dd76116dd570df3290a2f487b |
|
26-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: SkNEW->new; SkDELETE->delete
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
/external/skia/src/core/SkBitmapCache.cpp
|
| 216b643fc77e754a3fabbb0ed397e7cf55d1954d |
|
19-Aug-2015 |
reed <reed@google.com> |
private iterator to visit all resource cache entries
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1271033002
/external/skia/src/core/SkBitmapCache.cpp
|
| 6f1216ac158e36a3a1cc805e7f899c755c5b98a2 |
|
04-Aug-2015 |
reed <reed@google.com> |
cache private readback for gpu-images
Does not try to cache calls to readPixels at the moment:
- not triggered by drawing
- not clear if we want to perform any pixel transformations (that readPixels allows) on the GPU or CPU
Can consider that another time.
BUG=513695
Review URL: https://codereview.chromium.org/1262923003
/external/skia/src/core/SkBitmapCache.cpp
|
| 36352bf5e38f45a70ee4f4fc132a38048d38206d |
|
26-Mar-2015 |
mtklein <mtklein@chromium.org> |
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}
NOPRESUBMIT=true
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002
Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/core/SkBitmapCache.cpp
|
| 83787d0ff0a2b2f839a4a3ce6dadd033f83fe643 |
|
25-Feb-2015 |
reed <reed@google.com> |
only notify bitmaps that have been added to the cache
old code:
- calls=2677 hit-rate=3.51139%
new code:
- calls=94 hit-rate=97.8723%
BUG=skia:
Review URL: https://codereview.chromium.org/960563002
/external/skia/src/core/SkBitmapCache.cpp
|
| 7eeba2587760a0802fd2b90765b4fd0e5e895375 |
|
24-Feb-2015 |
reed <reed@chromium.org> |
Notify resource caches when pixelref genID goes stale
patch from issue 954443002 at patchset 40001 (http://crrev.com/954443002#ps40001)
BUG=skia:
Review URL: https://codereview.chromium.org/950363002
/external/skia/src/core/SkBitmapCache.cpp
|
| 90c6bc4e85df2da37f436ea1da203e194c4740e2 |
|
19-Feb-2015 |
mtklein <mtklein@google.com> |
Revert of notify resource caches when pixelref genID goes stale (patchset #4 id:60001 of https://codereview.chromium.org/825263005/)
Reason for revert:
Crazy failures.
http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/builds/1428/steps/dm/logs/stdio
Original issue's description:
> notify resource caches when pixelref genID goes stale
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4675819b9dbb3ad71ec851776e5de26d342f29fe
TBR=bsalomon@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/936423002
/external/skia/src/core/SkBitmapCache.cpp
|
| 4675819b9dbb3ad71ec851776e5de26d342f29fe |
|
19-Feb-2015 |
reed <reed@google.com> |
notify resource caches when pixelref genID goes stale
BUG=skia:
Review URL: https://codereview.chromium.org/825263005
/external/skia/src/core/SkBitmapCache.cpp
|
| 72c9faab45124e08c85f70ca38536914862d947c |
|
09-Jan-2015 |
mtklein <mtklein@chromium.org> |
Fix up all the easy virtual ... SK_OVERRIDE cases.
This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.
for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end
BUG=skia:
Review URL: https://codereview.chromium.org/806653007
/external/skia/src/core/SkBitmapCache.cpp
|
| 171e5b73a862418f4acd61faf8cecfbc8f58694c |
|
22-Oct-2014 |
fmalita <fmalita@chromium.org> |
SkResourceCache::Key namespace support.
Add a unique-per-subclass namespace tag to make Keys from different
domains comparable.
Also drop the SkPictureShader cache and convert to using the global
resource cache instead.
R=reed@google.com,mtklein@google.com,robertphillips@google.com
Review URL: https://codereview.chromium.org/668223002
/external/skia/src/core/SkBitmapCache.cpp
|
| 9d93c2ebb31bf996905532446644f242339a774e |
|
08-Oct-2014 |
reed <reed@google.com> |
Add SkCachedData and use it for SkMipMap
This reverts commit 37c5a815d8ea33247968212ef4cc83394ceee1bc.
TBR=mtklein
Review URL: https://codereview.chromium.org/635333002
/external/skia/src/core/SkBitmapCache.cpp
|
| 37c5a815d8ea33247968212ef4cc83394ceee1bc |
|
03-Oct-2014 |
reed <reed@google.com> |
Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap"
This reverts commit 92561a0b99ad6c08ab7a11dd1872f028199392e9.
crasher in question:
https://code.google.com/p/chromium/issues/detail?id=420178
Review URL: https://codereview.chromium.org/617613003
/external/skia/src/core/SkBitmapCache.cpp
|
| 92561a0b99ad6c08ab7a11dd1872f028199392e9 |
|
02-Oct-2014 |
reed <reed@google.com> |
Add SkCachedData and use it for SkMipMap
Review URL: https://codereview.chromium.org/592843003
/external/skia/src/core/SkBitmapCache.cpp
|
| 30ad5306be25565484a3dd76237984e071b7c4b3 |
|
16-Sep-2014 |
reed <reed@google.com> |
allow SkBitmapCache to operate on a local instance, for testability
BUG=skia:
R=mtklein@google.com, danakj@chromium.org, piotaixr@chromium.org, junov@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/576763002
/external/skia/src/core/SkBitmapCache.cpp
|
| c90e0149ec530075cae7bf51072a16628311855e |
|
15-Sep-2014 |
reed <reed@google.com> |
Change SkResourceCache to take a Visitor inside its find().
This reverts commit 595aa05efcb504e85358b8d328ac4a9fa1c46e2e.
BUG=skia:
R=mtklein@google.com, danakj@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/569353002
/external/skia/src/core/SkBitmapCache.cpp
|
| 595aa05efcb504e85358b8d328ac4a9fa1c46e2e |
|
15-Sep-2014 |
reed <reed@google.com> |
Revert of Change SkResourceCache to take a Visitor inside its find(). (patchset #2 id:20001 of https://codereview.chromium.org/567393002/)
Reason for revert:
crashes on android bots, haven't diagnosed yet
Original issue's description:
> Change SkResourceCache to take a Visitor inside its find().
>
> This simplifies the API/contract, in that there are not any exposed
> lock/unlock scopes.
>
>
> patch from issue 572573002
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/dee6a8e67db39fcbde2b3bb09be1d088ebb9db8a
R=mtklein@google.com, danakj@chromium.org
TBR=danakj@chromium.org, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/569303002
/external/skia/src/core/SkBitmapCache.cpp
|
| dee6a8e67db39fcbde2b3bb09be1d088ebb9db8a |
|
15-Sep-2014 |
reed <reed@google.com> |
Change SkResourceCache to take a Visitor inside its find().
This simplifies the API/contract, in that there are not any exposed
lock/unlock scopes.
patch from issue 572573002
BUG=skia:
R=mtklein@google.com, danakj@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/567393002
/external/skia/src/core/SkBitmapCache.cpp
|
| 790ffe3feb90370318f42b28eb9c6af6e38cd4f9 |
|
11-Sep-2014 |
danakj <danakj@chromium.org> |
Make SkBitmapCache remove invalid bitmaps from the SkResourceCache.
This adds SkResourceCache::Remove() which will remove a resource from
its cache. The resource is required to be unlocked at the time Remove()
is called.
Then SkBitmapCache::Find() makes use of this to Remove() bitmaps from
the cache whose pixels have been evicted. This allows the bitmap to be
re-added to the cache with pixels again.
After this change, background a tab (and discarding all the bitmaps'
contents) no longer disables image caching for those discarded images
once the tab is visible again.
BUG=skia:2926
NOTRY=true
R=reed@android.com, tomhudson@google.com, reed@google.com
Author: danakj@chromium.org
Review URL: https://codereview.chromium.org/561953002
/external/skia/src/core/SkBitmapCache.cpp
|
| 91cab830c81025e0af800b528bed582ea6e4d3d7 |
|
03-Sep-2014 |
piotaixr <piotaixr@chromium.org> |
Remove SkBitmapCache::Find/Add(_,width,height,_)
in favor of the versions having a SkIRect as input parameter
BUG=skia:2909
R=reed@google.com, junov@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/539643002
/external/skia/src/core/SkBitmapCache.cpp
|
| 42b0dfeb29e993b7fd247dcecff705d3dd4cf191 |
|
03-Sep-2014 |
piotaixr <piotaixr@chromium.org> |
The key for SkBitmapCache can now be genID+SkIRect
BUG=skia:2894
R=junov@chromium.org, reed@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/518983002
/external/skia/src/core/SkBitmapCache.cpp
|
| 14b6aba0997a8b463eae824d770fc5ad1ab89617 |
|
29-Aug-2014 |
reed <reed@google.com> |
harden requirements on SkBitmapCache
BUG=skia:
R=humper@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/521433002
/external/skia/src/core/SkBitmapCache.cpp
|
| 011f39aeb2b9715546eb74d9ebb71be7baf95fde |
|
28-Aug-2014 |
reed <reed@google.com> |
rename ScaledImageCache to ResourceCache
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/511283002
/external/skia/src/core/SkBitmapCache.cpp
|
| 680fb9e8f10d24b5fe35c90338de37c57392f1aa |
|
26-Aug-2014 |
reed <reed@google.com> |
retool image cache to be generic cache, allowing the client to subclass "Rec", so they can provide a custom Key and arbitrary Value.
Follow-on CLs
- rename ScaledimageCache to something like GeneralCache
- explore if we can use call-backs or some mechanism to completely hide "lock/unlock", by forcing all clients to support "copying" their value out of the cache as the result of a Find.
R=mtklein@google.com, senorblanco@google.com, bsalomon@google.com, qiankun.miao@intel.com, senorblanco@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/507483002
/external/skia/src/core/SkBitmapCache.cpp
|
| 045bb7f00b217e7726d517acf783c661bd6f639e |
|
25-Aug-2014 |
qiankun.miao <qiankun.miao@intel.com> |
Clean up useless comments in SkScaledImageCache.h
BUG=skia:
R=reed@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/499203002
/external/skia/src/core/SkBitmapCache.cpp
|
| 04617139f7f715bdc05a32a58e65e3c208bccff4 |
|
21-Aug-2014 |
reed <reed@google.com> |
expose generalized imagecache key
BUG=skia:
R=mtklein@google.com, halcanary@google.com, qiankun.miao@intel.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/483493003
/external/skia/src/core/SkBitmapCache.cpp
|