| de5c50268c3ff0af507c0a9b47ab58809b89867c |
|
26-Jan-2018 |
Mike Reed <reed@google.com> |
move checkLE functionality directly onto readbuffer
Bug: skia:
Change-Id: I549717f04e2e4cafc41ccbe13009805f47943d5d
Reviewed-on: https://skia-review.googlesource.com/99703
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| a83d0132baa681339e7e7f018dbdcc4051caae3d |
|
24-Jan-2018 |
Robert Phillips <robertphillips@google.com> |
Misc guarding of enums in ImageFilter CreateProcs
Change-Id: I51886aaf2a4670f46ca489b2369dc00e60403c75
Reviewed-on: https://skia-review.googlesource.com/99328
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 757c15402ddb3dd03f0b5f208d288164c7317499 |
|
23-Jan-2018 |
Robert Phillips <robertphillips@google.com> |
Remove superfluous SkReadBuffer validity checks
The pattern is to create the spurious object & delete it later
Change-Id: I435e2872127e02c241b5dd27cd965f3c7047a77a
Reviewed-on: https://skia-review.googlesource.com/98783
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| bee273291f735248f6a2018aeb29a82e7584eaf7 |
|
23-Jan-2018 |
Robert Phillips <robertphillips@google.com> |
Fix some fuzzer bugs from Skia's image filter fuzzer
Change-Id: I432b3a351eecca0d36635e37f91d32c0e281b7d9
Reviewed-on: https://skia-review.googlesource.com/98384
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| bf6828ee72f0b0a73fc9577e4d9f7d251875d522 |
|
05-Jan-2018 |
Jim Van Verth <jvanverth@google.com> |
Add fp-friendly check for zero-width BlurImageFilters
Bug: skia:7453
Change-Id: I9fc2d8f97e7a1264479c3a759d4bec06fd15f17d
Reviewed-on: https://skia-review.googlesource.com/91505
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| dca92e8a622cec7579dd2d44b8b7121603850b93 |
|
19-Dec-2017 |
Herb Derby <herb@google.com> |
Account for border with small sigma.
When sigma is small a very small border is generated,
but no actual blurring happens. Copy the image and
add the small border instead of just copying the image.
Tested by patching into chrome, and observing no shift.
BUG=chromium:795528
Change-Id: I9eee74a3155575c747fafc71ace77ed4247bcae5
Reviewed-on: https://skia-review.googlesource.com/87420
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 661c542e4ad2626d872e9321392a56c99e1c1011 |
|
13-Dec-2017 |
Herbert Derby <herb@google.com> |
Simplify image clearing
TBR=fmalita@google.com
Change-Id: Ibc7271d599bf2a1b85f3cd2dc07e49bef38fddb0
Reviewed-on: https://skia-review.googlesource.com/84520
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 72b4e07e44353892b5972379d6e98c7334e8fe14 |
|
11-Dec-2017 |
Herb Derby <herb@google.com> |
Handle small sigma in one direction
Because GPU/CPU must interoperate, the border calculation
code adds transparent black border pixels for sigmas
that produce a window of 1. This is a very rare case
and seems to only happen in fuzzers. In this case
cleare everything to black before bluring.
BUG=chromium:793285
Change-Id: I2b56f9ad88304abaa2669c9c9ef69b5443ba4333
Reviewed-on: https://skia-review.googlesource.com/83562
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| d8e2b13ad4d45d8224c2e0b6ef77bfaff404c5b5 |
|
29-Nov-2017 |
Herbert Derby <herb@google.com> |
Remove previous blur image implementation. Try 2
The last version had a problem with the no simd compilation.
TBR=mtklein@google.com
Change-Id: I139388cf3bf1b55cb4a49133a98be129fd9711c6
Reviewed-on: https://skia-review.googlesource.com/80983
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 2a3985e98d50ddfbec4d3a8fe53cc513a3c2d329 |
|
06-Dec-2017 |
Herb Derby <herb@google.com> |
Revert "Remove previous blur image implementation"
This reverts commit a11346dd24fa7122246dc96ba15604713e460036.
Reason for revert: Compile problems on linux
Original change's description:
> Remove previous blur image implementation
>
> Change-Id: Ie3bada767f0ba945cb17f174f179510768eb178d
> Reviewed-on: https://skia-review.googlesource.com/77583
> Commit-Queue: Herb Derby <herb@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
TBR=mtklein@google.com,herb@google.com
Change-Id: I5f157fbc2fd4e2a37618dc9c0e72621ff9892ef6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/81100
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| a11346dd24fa7122246dc96ba15604713e460036 |
|
29-Nov-2017 |
Herbert Derby <herb@google.com> |
Remove previous blur image implementation
Change-Id: Ie3bada767f0ba945cb17f174f179510768eb178d
Reviewed-on: https://skia-review.googlesource.com/77583
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 65f6985a96ef631b033f299fc6796122013782b8 |
|
01-Dec-2017 |
Herbert Derby <herb@google.com> |
Initialize dst image memory for small sigma
The GPU and CPU share the same code for layout; the layout is too large for CPU. So,
the CPU code must clear some of the destination even if there would be no work to do.
Change-Id: I29a04217b620b033a01db53487dc64e377661436
BUG=chromium:789812
Reviewed-on: https://skia-review.googlesource.com/79401
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| a0ec54829eb77ec51747d2c8fd1ecfb7c0587965 |
|
20-Nov-2017 |
Herb Derby <herb@google.com> |
Eliminate the use of a tmp buffer for image blur
Because the blur_one_direction routine, only reads the
source buffer once for each result, it can be used to
blur inplace. This allows the code to avoid using
a temporary buffer for the intermediate result.
This produces the same pixels according to skdiff, and
has the same speed.
Change-Id: I6485a71f0eb39936d69b8a98ab429a2cf592a7cd
Reviewed-on: https://skia-review.googlesource.com/74520
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| f8e2502819499894dff40c4f2f46e46edda15507 |
|
08-Nov-2017 |
Robert Phillips <robertphillips@google.com> |
Prepare to enable explicit gpu resource allocation (take 2)
Change-Id: I3fd78d53e8bea84c0217b9fe6e180eaa9e4ac753
Reviewed-on: https://skia-review.googlesource.com/68920
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 065b41dd90782e22b5708c8b43696db641d54f46 |
|
08-Nov-2017 |
Greg Daniel <egdaniel@google.com> |
Revert "Prepare to enable explicit gpu resource allocation"
This reverts commit f290376736b42a19b87da78c6ba2558313896860.
Reason for revert: Changed generated effect instead of FP
Original change's description:
> Prepare to enable explicit gpu resource allocation
>
> Change-Id: I407e45711c61831febbac3d3d3a88e3fdde92c5f
> Reviewed-on: https://skia-review.googlesource.com/68212
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,robertphillips@google.com
Change-Id: I949500d94c7461b7cf38d615117cfcdc9a791780
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/68900
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| f290376736b42a19b87da78c6ba2558313896860 |
|
08-Nov-2017 |
Robert Phillips <robertphillips@google.com> |
Prepare to enable explicit gpu resource allocation
Change-Id: I407e45711c61831febbac3d3d3a88e3fdde92c5f
Reviewed-on: https://skia-review.googlesource.com/68212
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 60aaeb2b551d5e3e90baacac315e899e26f758f1 |
|
03-Nov-2017 |
Cary Clark <caryclark@skia.org> |
create imagepriv and name params
Named all parameters and made the names consistent
for documentation.
Moved SK_IMAGEFILTER_UNFLATTEN_COMMON to private file.
TBR=reed@google.com
Bug: skia:6898
Change-Id: I1343d2b16d4217088fa3bc9c40f1f4177fa32740
Reviewed-on: https://skia-review.googlesource.com/66521
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 9d96df1f1f5a47a044e31787dbcf7d1b04766816 |
|
02-Nov-2017 |
Brian Osman <brianosman@google.com> |
Fix GPU blurring when using SkColorSpaceXformCanvas
Several GMs didn't draw at all (and asserted in debug builds). This fixes
all of that, so that the xform canvas (or even just pure-legaacy canvas)
doesn't accidentally blur in linear space by creating sRGB render target
contexts for sRGB-tagged inputs.
Bug: skia:
Change-Id: I37c567a1c5b0e004dc301e5c272c7b470ac5f4c8
Reviewed-on: https://skia-review.googlesource.com/66884
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| f3569f0f6d312570c7344b345f8b3a03a892f751 |
|
24-Oct-2017 |
Brian Salomon <bsalomon@google.com> |
Add GrColorSpaceInfo and use in place of GrRenderTargetContext in paint conversion.
This moves us closer to making GrAtlasTextContext and related classes usable without a GrRenderTargetContext.
Change-Id: Ife52d69a3f925e23da88043acb4d8dc9f672a025
Reviewed-on: https://skia-review.googlesource.com/63304
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 0cc4824141883d84aa122c5a08a3d5900d575e04 |
|
18-Oct-2017 |
Herb Derby <herb@google.com> |
Reland the combined 3 pass image blur with a fix to the bounds calculation
Use the old bounds calculation so that CPU and GPU agree. Adjust all the
combined 3 pass code to use the new bounds.
This reverts commit 59f8f154872a66433eb1dfccd3d56b540193089e and
fixes bound calculation.
Original change's description:
> Revert "Use combined three pass code for image blur."
>
> This reverts commit d4a0fc7383546d106db2216515b3753937398ece.
>
> Reason for revert: Too naive about bounds
>
> Original change's description:
> > Use combined three pass code for image blur.
> >
> > This changes more closely matches the GL output, and the runtimes are similar or
> > faster for the common cases.
> >
> > x86_64 times:
> > benchmark old-Us new-Us old/new
> > blur_image_filter_large_80.00_80.00 4842.04 2626.10 1.84381
> > blur_image_filter_small_80.00_80.00 3297.72 854.97 3.85712
> > blur_image_filter_large_10.00_10.00 930.44 720.50 1.29138
> > blur_image_filter_small_10.00_10.00 69.96 42.15 1.65979
> > blur_image_filter_large_1.00_1.00 682.66 521.78 1.30833
> > blur_image_filter_small_1.00_1.00 19.21 14.43 1.33125
> > blur_image_filter_large_0.50_0.50 696.17 64.14 10.8539
> > blur_image_filter_small_0.50_0.50 16.26 5.02 3.23904
> >
> > arm64 times:
> > benchmark old-Us new-Us old/new
> > blur_image_filter_large_80.00_80.00 42144.53 14128.42 2.98296
> > blur_image_filter_small_80.00_80.00 24840.58 4392.58 5.65512
> > blur_image_filter_large_10.00_10.00 3556.40 3793.70 0.937449
> > blur_image_filter_small_10.00_10.00 282.53 220.62 1.28062
> > blur_image_filter_large_1.00_1.00 2502.20 2937.99 0.851671
> > blur_image_filter_small_1.00_1.00 83.32 81.93 1.01697
> > blur_image_filter_large_0.50_0.50 5643.80 272.83 20.6861
> > blur_image_filter_small_0.50_0.50 141.02 38.29 3.68295
> >
> > Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD
> > Change-Id: Ic53b3186607d5485477b92e4ca7b092bf1366c52
> > Reviewed-on: https://skia-review.googlesource.com/52771
> > Commit-Queue: Herb Derby <herb@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
>
> TBR=mtklein@google.com,herb@google.com,senorblanco@chromium.org
>
> Change-Id: Idf679a8fc6d777625ad9527b843aa1614d878cba
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD
> Reviewed-on: https://skia-review.googlesource.com/60900
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Herb Derby <herb@google.com>
Change-Id: Idda0d83b1e2f753c9c8e703f9506dd31b117ec55
Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD
Reviewed-on: https://skia-review.googlesource.com/61320
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 59f8f154872a66433eb1dfccd3d56b540193089e |
|
18-Oct-2017 |
Herb Derby <herb@google.com> |
Revert "Use combined three pass code for image blur."
This reverts commit d4a0fc7383546d106db2216515b3753937398ece.
Reason for revert: Too naive about bounds
Original change's description:
> Use combined three pass code for image blur.
>
> This changes more closely matches the GL output, and the runtimes are similar or
> faster for the common cases.
>
> x86_64 times:
> benchmark old-Us new-Us old/new
> blur_image_filter_large_80.00_80.00 4842.04 2626.10 1.84381
> blur_image_filter_small_80.00_80.00 3297.72 854.97 3.85712
> blur_image_filter_large_10.00_10.00 930.44 720.50 1.29138
> blur_image_filter_small_10.00_10.00 69.96 42.15 1.65979
> blur_image_filter_large_1.00_1.00 682.66 521.78 1.30833
> blur_image_filter_small_1.00_1.00 19.21 14.43 1.33125
> blur_image_filter_large_0.50_0.50 696.17 64.14 10.8539
> blur_image_filter_small_0.50_0.50 16.26 5.02 3.23904
>
> arm64 times:
> benchmark old-Us new-Us old/new
> blur_image_filter_large_80.00_80.00 42144.53 14128.42 2.98296
> blur_image_filter_small_80.00_80.00 24840.58 4392.58 5.65512
> blur_image_filter_large_10.00_10.00 3556.40 3793.70 0.937449
> blur_image_filter_small_10.00_10.00 282.53 220.62 1.28062
> blur_image_filter_large_1.00_1.00 2502.20 2937.99 0.851671
> blur_image_filter_small_1.00_1.00 83.32 81.93 1.01697
> blur_image_filter_large_0.50_0.50 5643.80 272.83 20.6861
> blur_image_filter_small_0.50_0.50 141.02 38.29 3.68295
>
> Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD
> Change-Id: Ic53b3186607d5485477b92e4ca7b092bf1366c52
> Reviewed-on: https://skia-review.googlesource.com/52771
> Commit-Queue: Herb Derby <herb@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
TBR=mtklein@google.com,herb@google.com,senorblanco@chromium.org
Change-Id: Idf679a8fc6d777625ad9527b843aa1614d878cba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD
Reviewed-on: https://skia-review.googlesource.com/60900
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| d4a0fc7383546d106db2216515b3753937398ece |
|
17-Oct-2017 |
Herb Derby <herb@google.com> |
Use combined three pass code for image blur.
This changes more closely matches the GL output, and the runtimes are similar or
faster for the common cases.
x86_64 times:
benchmark old-Us new-Us old/new
blur_image_filter_large_80.00_80.00 4842.04 2626.10 1.84381
blur_image_filter_small_80.00_80.00 3297.72 854.97 3.85712
blur_image_filter_large_10.00_10.00 930.44 720.50 1.29138
blur_image_filter_small_10.00_10.00 69.96 42.15 1.65979
blur_image_filter_large_1.00_1.00 682.66 521.78 1.30833
blur_image_filter_small_1.00_1.00 19.21 14.43 1.33125
blur_image_filter_large_0.50_0.50 696.17 64.14 10.8539
blur_image_filter_small_0.50_0.50 16.26 5.02 3.23904
arm64 times:
benchmark old-Us new-Us old/new
blur_image_filter_large_80.00_80.00 42144.53 14128.42 2.98296
blur_image_filter_small_80.00_80.00 24840.58 4392.58 5.65512
blur_image_filter_large_10.00_10.00 3556.40 3793.70 0.937449
blur_image_filter_small_10.00_10.00 282.53 220.62 1.28062
blur_image_filter_large_1.00_1.00 2502.20 2937.99 0.851671
blur_image_filter_small_1.00_1.00 83.32 81.93 1.01697
blur_image_filter_large_0.50_0.50 5643.80 272.83 20.6861
blur_image_filter_small_0.50_0.50 141.02 38.29 3.68295
Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD
Change-Id: Ic53b3186607d5485477b92e4ca7b092bf1366c52
Reviewed-on: https://skia-review.googlesource.com/52771
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 5a4fb6eb335d29f24a1b239d1c0eb11b5d2ee59f |
|
28-Sep-2017 |
Herb Derby <herb@google.com> |
Reorganize blur filter to insert new implementation
Change-Id: Ie9afd2de2bfb9bcd04b5f8b7f319a24025520bef
Reviewed-on: https://skia-review.googlesource.com/52400
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Stephen White <senorblanco@chromium.org>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| a4083c97d48e8a4f88e2797d7363f141e3d42553 |
|
15-Sep-2017 |
Cary Clark <caryclark@skia.org> |
make most of SkColorPriv.h private
created new file src/core/SkColorData.h for
internal consumption. Note that many of the
functions there are unused as well.
Bug: skia: 6898
R: reed@google.com
Change-Id: I25bfd5a9c21f53558c4ca65a77eb5d322d897c6d
Reviewed-on: https://skia-review.googlesource.com/46848
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| b4aab9ae6d27c446af8302b79d15b832c816c633 |
|
16-Aug-2017 |
Ben Wagner <bungeman@google.com> |
Replace SkFAIL with SK_ABORT.
SkFAIL is a legacy macro which is just SK_ABORT. This CL mechanically
changes uses of SkFAIL to SK_ABORT in preparation for its removal. The
related sk_throw macro will be changed independently, due to needing to
actually clean up its users.
Change-Id: Id70b5c111a02d2458dc60c8933f444df27d9cebb
Reviewed-on: https://skia-review.googlesource.com/35284
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 49f58a3825ca7f7745d7f311baa2b65c5eb46c02 |
|
31-Jul-2017 |
Robert Phillips <robertphillips@google.com> |
Add asserts to SkBlurImageFilter flatten & CreateProc
It seems rather implausible that this could be occuring but the Chrome
bug seems to say otherwise.
Bug: 748155
Change-Id: I8e14f1562c71da4ae80d626e4dba053d7ee13d97
Reviewed-on: https://skia-review.googlesource.com/28863
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| da69944cbb9e561694716b8882d201d4f7f8790e |
|
11-Jul-2017 |
wutao <wutao@chromium.org> |
Serialize the new TileMode in SkBlurImageFilterImpl.
Serialize the new TileMode in SkBlurImageFilterImpl. And also update the
SkReadBuffer::Version and CURRENT_PICTURE_VERSION in SkPicture.
Bug: 622128
Change-Id: I3b04be2a36406227c6d8112e943d7415566c0c42
Reviewed-on: https://skia-review.googlesource.com/22079
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 6d9f42984d94a2e9116dd951d47cd65cd8f4d401 |
|
06-Jul-2017 |
Mike Reed <reed@google.com> |
only create new instance if needed for colorspacexformer
just an experiment to address performance when imagefilters are cached.
Bug: skia:
Change-Id: Ic1033c897d0a569b46a339fb3ae7f8f961882953
Reviewed-on: https://skia-review.googlesource.com/21395
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 039a7c70cea29aa40c4fb880b0d6bb523d449568 |
|
30-Jun-2017 |
wutao <wutao@google.com> |
Added new edge handling mode (clamp and repeat) to Gaussian blur filter.
Gaussian blur filter will interpolate value by using out of bounds
coords, which is 0. This makes it appears darker near the bounds in the
blurred images. There are two issues: 1) when downsampling and
upsampling, we should use GrTextureDomainEffect kClamp_Mode to clamp
the texture coords to the bounds; 2) during Gaussian blur, we need to
clamp to texture bounds.
BUG=622128
TEST=cc_unittests, GM image test & manual. Some test results can be found at:
https://bugs.chromium.org/p/chromium/issues/detail?id=622128#c49
Change-Id: I9283da1d91efb0da94a991f2d372e9f62c288bdc
Reviewed-on: https://skia-review.googlesource.com/20465
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 70e3e9adc57d765cbd1e86d8f54145e1b4a564f4 |
|
26-Jun-2017 |
Robert Phillips <robertphillips@google.com> |
Remove SkImageFilter::MakeBlur entry point
AFAICT none of our clients use this entry point and it is tangling up efforts to add a new parameter to the BlurImageFilter.
Change-Id: I494634db98a1d246854a5e3735380fbe55f425c2
Reviewed-on: https://skia-review.googlesource.com/20837
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 4edb5d219eb99aa1e8fbe5e37260d3b34314e54b |
|
17-Apr-2017 |
Mike Reed <reed@google.com> |
hide lockpixels api behind flag
guarded by SK_SUPPORT_OBSOLETE_LOCKPIXELS
needs https://codereview.chromium.org/2820873002/# to land first
Bug: skia:6481
Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09
Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09
Reviewed-on: https://skia-review.googlesource.com/13580
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| fafe135349bd34961a12bfd8185733709cd0e45e |
|
11-Apr-2017 |
Hal Canary <halcanary@google.com> |
SkSize can be aggregate-initialized
Previosly, SkSize had a base class, which prevented it.
Also removes unused SkISize::clampNegToZero() and
SkSize::clampNegToZero().
Change-Id: I7b93b42f6f6381c66e294bbedee99ad53c6c3436
Reviewed-on: https://skia-review.googlesource.com/13187
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 6d72ed918d8763e65899183c2d12b06958c791f4 |
|
10-Apr-2017 |
Matt Sarett <msarett@google.com> |
SkImageFilter::onMakeColorSpace() - more overrides
Fills out most of the simple implementations.
Improves 22 gms in gbr-8888.
Bug: skia:
Change-Id: I881ade140993568263de75be51aed240d2de8cc6
Reviewed-on: https://skia-review.googlesource.com/13126
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 2c6d2bfced6d20703d52ab14a598c76d926f52fb |
|
21-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Remove SkSpecialImage's GrTexture-based ctors
Change-Id: Id71b8ab0477cd1d459089d97af27d63f9f08d21b
Reviewed-on: https://skia-review.googlesource.com/7889
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 8e1c4e672553ecae2745168514240705f3516773 |
|
19-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Remove asTextureRef from SkSpecialImage & update effects accordingly (take 2)
This CL also renames SkSpecialImage::asTextureProxy to asTextureProxyRef
This is a reland of: https://skia-review.googlesource.com/c/7995/ (Remove asTextureRef from SkSpecialImage & update effects accordingly)
It should be good to land since https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2)) fixes the Chrome-side issue
Change-Id: I3d88b2b3d23fd69f3fb914a69dacca96cbc038a4
Reviewed-on: https://skia-review.googlesource.com/8450
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 696b29346e85307a05af47768d358161eba3f6bd |
|
08-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Revert "Remove asTextureRef from SkSpecialImage & update effects accordingly"
This reverts commit e88cf6b7aa5deaeaa9dab18ada7d9d11e1e4be12.
Reason for revert: See if breaking DEPS roll
Original change's description:
> Remove asTextureRef from SkSpecialImage & update effects accordingly
>
> This CL also renames SkSpecialImage::asTextureProxy to asTextureProxyRef
>
> Change-Id: I5ed8e475bb9688453b825ae4500ed0e8d324b5ac
> Reviewed-on: https://skia-review.googlesource.com/7995
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
>
TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I227cbd5fcaf7e2f86e858331d9ec7ff7a5f203ca
Reviewed-on: https://skia-review.googlesource.com/8184
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| e88cf6b7aa5deaeaa9dab18ada7d9d11e1e4be12 |
|
07-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Remove asTextureRef from SkSpecialImage & update effects accordingly
This CL also renames SkSpecialImage::asTextureProxy to asTextureProxyRef
Change-Id: I5ed8e475bb9688453b825ae4500ed0e8d324b5ac
Reviewed-on: https://skia-review.googlesource.com/7995
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| a99b6ceff92183b424634f2e7276b9ea1d59e69d |
|
04-Feb-2017 |
Mike Reed <reed@google.com> |
start removing uses of SkScalarMul
BUG=skia:6197
Change-Id: Ic444c7ee4ca547f483dc8232dcacd6d4ba87d913
Reviewed-on: https://skia-review.googlesource.com/8041
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 08c5ec71303aa58d6f081914f3e868fa5cce9f4c |
|
30-Jan-2017 |
Robert Phillips <robertphillips@google.com> |
Make blur utils take GrTextureProxies - take 2
This is a re-land of https://skia-review.googlesource.com/c/7738/ (Make blur utils take GrTextureProxies) with a fix for the Nexus7
Change-Id: I5821a26b1e986daa11d960ae826a1207512cd2a0
Reviewed-on: https://skia-review.googlesource.com/7746
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 877b15b301d798a0eb7aeb9ad36db383ef63ace9 |
|
30-Jan-2017 |
Robert Phillips <robertphillips@google.com> |
Revert "Make blur utils take GrTextureProxies"
This reverts commit d0dc05b98b71af43b44f13beba1292db52b75539.
Reason for revert: assertion failure on N7
Original change's description:
> Make blur utils take GrTextureProxies
>
> Change-Id: I1c5054de6d9827eece2f73c4c78818b4db0bc611
> Reviewed-on: https://skia-review.googlesource.com/7738
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
>
TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I82d9385e23279db4c7a6757f1224e603e231354c
Reviewed-on: https://skia-review.googlesource.com/7744
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| d0dc05b98b71af43b44f13beba1292db52b75539 |
|
30-Jan-2017 |
Robert Phillips <robertphillips@google.com> |
Make blur utils take GrTextureProxies
Change-Id: I1c5054de6d9827eece2f73c4c78818b4db0bc611
Reviewed-on: https://skia-review.googlesource.com/7738
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 75a475cf2e7c66eb58b6b8b1441deb5911e53181 |
|
13-Jan-2017 |
Robert Phillips <robertphillips@google.com> |
Try out refFoo pattern on GrRenderTargetContext
Change-Id: Ifae5618f30c2202b9083f479b58556709ff6126a
Reviewed-on: https://skia-review.googlesource.com/6990
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 5f500920e719b215d5e0e36a6679995ed3c9b4ad |
|
29-Dec-2016 |
Brian Osman <brianosman@google.com> |
Change GaussianBlur logic wrt color spaces
I was using 'source' where I should have said 'input'. Also, to be
consistent with other image filters, ensure that the input is in the
destination gamut before we start blurring.
BUG=skia:
Change-Id: I751961b42a2a5d110ee8ea8916279c8fe0d5248e
Reviewed-on: https://skia-review.googlesource.com/6486
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 51d77ffdc635b3208350262a3edea8d685453583 |
|
02-Dec-2016 |
Robert Phillips <robertphillips@google.com> |
Second part of piecemeal revert
This is a partial revert of https://codereview.chromium.org/2514543002 (Defer more renderTargetContexts in the GPU image filter paths - take 2)
I have been unable to reproduce the performance regression in crbug.com/668179 locally so intend to revert the above CL piecemeal.
BUG=668179
Change-Id: Iee9d0164f85ae33ff8dfa9b3eb01c07fd825f017
Reviewed-on: https://skia-review.googlesource.com/5541
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| d728f0c1a94fe926b59d8ebc9ae174019ccd3606 |
|
21-Nov-2016 |
robertphillips <robertphillips@google.com> |
Defer more renderTargetContexts in the GPU image filter paths - take 2
This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should prevent a reoccurence of this Nexus7 failures.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/2514543002
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 833dcf48844dd053ddf7ecea20e3e1c2b6b47e01 |
|
18-Nov-2016 |
Robert Phillips <robertphillips@google.com> |
Add handling for instantiate failure up the call stack
The following two CLs were created via grep:
https://skia-review.googlesource.com/c/4929/ (Guard against instantiate & accessRenderTarget failures)
https://skia-review.googlesource.com/c/4961/ (Remove accessRenderTarget call in SkGpuDevice ctor)
This CL was created by running through all the tests and having instantiate fail so it catches up-stack failures to handle a null return.
BUG=665681,665500,665621
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4991
Change-Id: I6611eec8d36679123eef140538ee2526fb18628f
Reviewed-on: https://skia-review.googlesource.com/4991
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 4e344c8b93c7c2d1ef3cb7fd339bba55c479ece0 |
|
15-Nov-2016 |
Robert Phillips <robertphillips@google.com> |
Revert "Defer more renderTargetContexts in the GPU image filter paths"
This reverts commit fd01ce05ef7902c49b0272b3524a389693c72b35.
Reason for revert: see if this is the cause of the Nexus7 assertion failure
Original change's description:
> Defer more renderTargetContexts in the GPU image filter paths
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4767
>
> Change-Id: I4c1f27247ef340a49d1ac96761810e77e6047ca2
> Reviewed-on: https://skia-review.googlesource.com/4767
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
>
TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I158f96ec1252481345fc5dca15086ffd4b47cb95
Reviewed-on: https://skia-review.googlesource.com/4875
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| fd01ce05ef7902c49b0272b3524a389693c72b35 |
|
14-Nov-2016 |
Robert Phillips <robertphillips@google.com> |
Defer more renderTargetContexts in the GPU image filter paths
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4767
Change-Id: I4c1f27247ef340a49d1ac96761810e77e6047ca2
Reviewed-on: https://skia-review.googlesource.com/4767
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 1105224f9701e57ec5ce0354d6a380b664f5c638 |
|
27-Oct-2016 |
Brian Osman <brianosman@google.com> |
Rename GrDrawContext to GrRenderTargetContext
This is in preparation for GrTextureContext and GrSurfaceContext
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4030
Change-Id: Ie58c93052e68f3f1f5fe8d15d63760de274a6fbd
Reviewed-on: https://skia-review.googlesource.com/4030
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 958788ab461bf84e8c604a17dba5ebc2d6c27dfa |
|
20-Oct-2016 |
Mike Reed <reed@google.com> |
remove 4 legacy flags (clients already updated)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3785
Change-Id: I187e50e09ed7a3316719fae51af770259928fdf9
Reviewed-on: https://skia-review.googlesource.com/3785
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 2a75e5df300a2838f943ca52a52a85a5cf69802b |
|
22-Sep-2016 |
brianosman <brianosman@google.com> |
Add output format properties to SkImageFilter::Context
For now, this is just the color space (of the original
requesting device). This is used when constructing
intermediate rendering surfaces, so that we ensure we
land in a surface that's similar/compatible to the
final consumer of the DAG's output.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002
Review-Url: https://codereview.chromium.org/2357273002
/external/skia/src/core/SkBlurImageFilter.cpp
|
| e1e5c74086ceb7143bf2f7968a324e8c06d33914 |
|
23-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moving SkBlurImageFilter into core
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
Committed: https://skia.googlesource.com/skia/+/a97a1ab5719d5c355f7900b7f17dec1e467cf57e
Review-Url: https://codereview.chromium.org/2255803003
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 2a57f2fb2f61462b2ba1e9dac0c3d6e306e2ac68 |
|
23-Aug-2016 |
bungeman <bungeman@google.com> |
Revert of Moving SkBlurImageFilter into core (patchset #9 id:160001 of https://codereview.chromium.org/2255803003/ )
Reason for revert:
Breaking internal roll. Still needs 'Create'.
Original issue's description:
> Moving SkBlurImageFilter into core
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
>
> Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
> Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
> Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
> Committed: https://skia.googlesource.com/skia/+/a97a1ab5719d5c355f7900b7f17dec1e467cf57e
TBR=reed@google.com,fmalita@chromium.org,vjiaoblack@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2274603003
/external/skia/src/core/SkBlurImageFilter.cpp
|
| a97a1ab5719d5c355f7900b7f17dec1e467cf57e |
|
23-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moving SkBlurImageFilter into core
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
Review-Url: https://codereview.chromium.org/2255803003
/external/skia/src/core/SkBlurImageFilter.cpp
|
| a90dcf791b70ee5147faebd1d102f51c455b2889 |
|
22-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Revert of Moving SkBlurImageFilter into core (patchset #8 id:140001 of https://codereview.chromium.org/2255803003/ )
Reason for revert:
Misnamed function.
Original issue's description:
> Moving SkBlurImageFilter into core
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
>
> Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
> Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
> Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
TBR=reed@google.com,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2265263002
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 4d760175686df8f61a11b66946eb307d89dd2c75 |
|
22-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moving SkBlurImageFilter into core
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
Review-Url: https://codereview.chromium.org/2255803003
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 7b145120f2387aeb69fdcf444aa406c70075de27 |
|
22-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Revert of Moving SkBlurImageFilter into core (patchset #8 id:140001 of https://codereview.chromium.org/2255803003/ )
Reason for revert:
Fixed it wrong, needs to revert to re-discuss and re-land.
Original issue's description:
> Moving SkBlurImageFilter into core
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
>
> Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
> Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
TBR=reed@google.com,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2266063002
/external/skia/src/core/SkBlurImageFilter.cpp
|
| e426babe7552b1cb4e27cdf4e90826feabb9e3b0 |
|
22-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moving SkBlurImageFilter into core
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Review-Url: https://codereview.chromium.org/2255803003
/external/skia/src/core/SkBlurImageFilter.cpp
|
| 2ec417257b5866b653af1af6ef5e91388cc40f49 |
|
22-Aug-2016 |
mtklein <mtklein@google.com> |
Revert of Moving SkBlurImageFilter into core (patchset #6 id:100001 of https://codereview.chromium.org/2255803003/ )
Reason for revert:
It looks like this breaks our roll into Google3:
https://test.corp.google.com/ui#id=OCL:130943857:BASE:130944046:1471881622765:61dbdd3
Original issue's description:
> Moving SkBlurImageFilter into core
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
>
> Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
TBR=reed@google.com,fmalita@chromium.org,vjiaoblack@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2263283002
/external/skia/src/core/SkBlurImageFilter.cpp
|
| dd3259eb95c3b47e11eefa3b176365a112a32b48 |
|
22-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moving SkBlurImageFilter into core
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Review-Url: https://codereview.chromium.org/2255803003
/external/skia/src/core/SkBlurImageFilter.cpp
|