| 2a223358ed19f3dd25f9b127aa21f1dd138cb9f0 |
|
06-Feb-2018 |
Mike Reed <reed@google.com> |
init matrix if buffer is already bad
Bug: skia:
Change-Id: I8d21d846a0657a1e9530adc6613d398932b69e5f
Reviewed-on: https://skia-review.googlesource.com/104660
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 574b06f7038f32680919b72ca7a3ef95584184db |
|
23-Jan-2018 |
Mike Reed <reed@google.com> |
init out-param on buffer failure
Bug:804651
Change-Id: Ia3c71e2fbe35b55bf27075e6a11ec8c5bd3fb40f
Reviewed-on: https://skia-review.googlesource.com/98663
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| c183d1642055fb9a6304f2ae9d3e75656fd82b7b |
|
16-Jan-2018 |
Mike Reed <reed@google.com> |
it is not an error to have no flattenable
Bug:801768
Change-Id: Ib6a0a27a1e6828819879c4b5eef9fe0fd319b225
Reviewed-on: https://skia-review.googlesource.com/94761
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| d1c65d6708de536a5971575809d7172fa4f54b37 |
|
03-Jan-2018 |
Mike Reed <reed@google.com> |
remove unneeded readbuffer flags
- buffers are always 'cross-process'
- readbuffer is always validating
Bug:796107
Change-Id: I59614e9c29490c0b029c60d2aafe2806671bc9e1
Reviewed-on: https://skia-review.googlesource.com/90560
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| efe9842af0a9ef0564ae45e288bd821620de7dc2 |
|
02-Jan-2018 |
Mike Reed <reed@google.com> |
simplify/cleanup readbuffer impl
- rely more on readPad32
- try to use signed or unsigned read-int correctly
Bug: skia:
Change-Id: Idd9c9b52f54cb47717dbba0d6da654419b3466e8
Reviewed-on: https://skia-review.googlesource.com/89902
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 5c68dce7750a5525a5cfae29943716ce5c0d51b3 |
|
22-Dec-2017 |
Mike Reed <reed@google.com> |
add safemath version of readbuffer->skip
Bug: skia:
Change-Id: I6a5d24569cc1bd93bd190d81e3375993da9c56f0
Reviewed-on: https://skia-review.googlesource.com/88581
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkReadBuffer.cpp
|
| 594706566a62da1e00fa1bb678cc84c36464e811 |
|
16-Dec-2017 |
Mike Reed <reed@google.com> |
remove dead SK_SUPPORT_LEGACY_IMAGEDESERIALIZER code
Bug: skia:
Change-Id: I76be4b179ff23c8584b62b1bb0fa7a964c2ee97e
Reviewed-on: https://skia-review.googlesource.com/86320
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 45ab630045ec72dcc0c4546cc1e96ac518897896 |
|
13-Dec-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "impl SkSerial picture procs""
This reverts commit 2a3009931d7bb0f5ca31490c4cf19eef205e4e7a.
Implement SkSerialProcs for pictures
Bug: skia:
Change-Id: Icde2d912941a19999e204ac5213f519ed5387e12
Reviewed-on: https://skia-review.googlesource.com/84480
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 2a3009931d7bb0f5ca31490c4cf19eef205e4e7a |
|
13-Dec-2017 |
Mike Reed <reed@google.com> |
Revert "impl SkSerial picture procs"
This reverts commit c8226728541fdd6434a7f1b97678246202b0edc5.
Reason for revert: broke old skps
Original change's description:
> impl SkSerial picture procs
>
> The picture serialization code is a bit of a mess, with duplicated functions for streams and buffers.
> Could not see how to fix that and land this at the same time, but I will try to circle back and
> simplify if possible afterwards.
>
> Bug: skia:
> Change-Id: I9053fdc476c60f483df013d021e248258181c199
> Reviewed-on: https://skia-review.googlesource.com/83943
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com
Change-Id: I68ae019a286691b65cc373cb29c941d6620fd34a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/84460
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| c8226728541fdd6434a7f1b97678246202b0edc5 |
|
13-Dec-2017 |
Mike Reed <reed@google.com> |
impl SkSerial picture procs
The picture serialization code is a bit of a mess, with duplicated functions for streams and buffers.
Could not see how to fix that and land this at the same time, but I will try to circle back and
simplify if possible afterwards.
Bug: skia:
Change-Id: I9053fdc476c60f483df013d021e248258181c199
Reviewed-on: https://skia-review.googlesource.com/83943
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| bb091a08d1c60ccf3d014d94490c5b4134586ee2 |
|
11-Dec-2017 |
Florin Malita <fmalita@chromium.org> |
Fix fuzzer crash in SkReadBuffer::readTypeface()
BUG=skia:7398
Change-Id: I1d0f7a37c6f02ec5f621f7c1b5983b668530dcd9
Reviewed-on: https://skia-review.googlesource.com/83561
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 73822257cb01fb31c3ea90de0b88948def4caacf |
|
11-Dec-2017 |
Mike Reed <reed@google.com> |
read signed 32 if we want to treat it as signed
Bug:793603
Change-Id: I040d775fcf76da095ea2a25c33408508b3466fd7
Reviewed-on: https://skia-review.googlesource.com/83280
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkReadBuffer.cpp
|
| 58a3fcd4b3a2f7210586f4ec74dde8ac2b231e0f |
|
11-Dec-2017 |
Mike Reed <reed@google.com> |
add virtual to confirm flattenable type
meant to replace https://skia-review.googlesource.com/c/skia/+/83381
Bug:793639
Change-Id: I972dc80725bf5ce5be24769aafa23269735e089c
Reviewed-on: https://skia-review.googlesource.com/83444
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkReadBuffer.cpp
|
| 8e74cbcd6526a7542b9f704b9e40b0c60d475849 |
|
08-Dec-2017 |
Mike Reed <reed@google.com> |
Revert "Revert "use serialprocs for typefaces""
This reverts commit 1a104bce20adc47a343fa910899ca6c4f261be40.
Change (from first version) is
- only signal error in readbuffer for corrupt stream, not default fonts
- change test to ensure a non-null typeface (i.e. MakeDefault())
Bug: skia:
Change-Id: I325445b56b0a402e1b89a2439df06e92314c793f
Reviewed-on: https://skia-review.googlesource.com/82687
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 34e368af276dc9931c46afc3cde23d20728fc882 |
|
07-Dec-2017 |
Mike Reed <reed@google.com> |
enforce 4-byte alignment and length for buffers
Bug:792859
Change-Id: Ib4cde1015429153709956d4ffc2d4321decb79b0
Reviewed-on: https://skia-review.googlesource.com/82160
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 1a104bce20adc47a343fa910899ca6c4f261be40 |
|
07-Dec-2017 |
Mike Reed <reed@google.com> |
Revert "use serialprocs for typefaces"
This reverts commit b681972e79993e37adb9de9666cc9064b528db8b.
Reason for revert: need to handle null typeface in new procs
Original change's description:
> use serialprocs for typefaces
>
> Bug: skia:
> Change-Id: Ibf59a0fdcf68e8555bd4241e9473e733f6a30993
> Reviewed-on: https://skia-review.googlesource.com/81840
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=mtklein@chromium.org,mtklein@google.com,fmalita@chromium.org,reed@google.com
Change-Id: Id69500fbc291ecee753e7ee6b80abc2a7cd60d18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/82341
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| b681972e79993e37adb9de9666cc9064b528db8b |
|
07-Dec-2017 |
Mike Reed <reed@google.com> |
use serialprocs for typefaces
Bug: skia:
Change-Id: Ibf59a0fdcf68e8555bd4241e9473e733f6a30993
Reviewed-on: https://skia-review.googlesource.com/81840
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 75d55d3d4509669009d6202cab23ce9320fe8577 |
|
07-Dec-2017 |
Mike Reed <reed@google.com> |
don't read directly from fReader for bare types, need available check
Bug:792810
Change-Id: Ibb9d4b1dff05d48d7cb6674acf88a7a461bca818
Reviewed-on: https://skia-review.googlesource.com/82180
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 44aa9b2d1e708acb0e32db549abff793283ff442 |
|
07-Dec-2017 |
Mike Reed <reed@google.com> |
check for bad strings in readFlattenable
Bug:792815
Change-Id: I3b79d8b182bd129e9a17185991020d1dafb66a34
Reviewed-on: https://skia-review.googlesource.com/82060
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| fadbfcd4aba676d44dfb08de1a83143a1c63b95c |
|
06-Dec-2017 |
Mike Reed <reed@google.com> |
upgrade SkReadBuffer to always validate
Bug: skia:
Change-Id: I054560b66c6cde346d939015326d8547879d2c4b
Reviewed-on: https://skia-review.googlesource.com/81160
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 60691a5127852631b03250f15fa6cda9a504befc |
|
05-Dec-2017 |
Mike Reed <reed@google.com> |
add serial procs to pictures
Bug: skia:7380
Change-Id: Ic1b7e437316c7913711cf5cb119e3fe904cd2c05
Reviewed-on: https://skia-review.googlesource.com/76980
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkReadBuffer.cpp
|
| efe7c4920194796e997bff5bdb94e6fade6cb367 |
|
30-Nov-2017 |
Mike Reed <reed@google.com> |
remove read/write rawpixels
Bug: skia:
Change-Id: I000b70414119355fef0d45de4ae9ef996b8a5568
Reviewed-on: https://skia-review.googlesource.com/77903
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkReadBuffer.cpp
|
| 725d9dbfa59d6804b157f876a7e5d4c0553c6455 |
|
28-Nov-2017 |
Mike Reed <reed@google.com> |
remove unused readBitmapAsImage from readbuffer
Bug: skia:
Change-Id: Ic200ec39999a06f407de29e15b646baddb9e341d
Reviewed-on: https://skia-review.googlesource.com/76982
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 48723156c597ec4d7be8e0648548ff27ef6c4e02 |
|
10-Nov-2017 |
Mike Reed <reed@google.com> |
remove legacy code for resolution
Bug: skia:
Change-Id: I6909325d4ee51140ec0edb47682de18617c23cc7
Reviewed-on: https://skia-review.googlesource.com/70100
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkReadBuffer.cpp
|
| 4123d0ff867f41c40fd288b31f4c976069753ccc |
|
22-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Add serialization support for drawShadowRec
Change-Id: Ic7f76681a037d8f53a6fdc25061c39559f5c3e30
Reviewed-on: https://skia-review.googlesource.com/17457
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| 185130c643f0f6b20dcf14c200074748be282a7e |
|
15-Feb-2017 |
Mike Reed <reed@google.com> |
return and take SkImageGenerator as unique_ptr
BUG=skia:
Change-Id: I4bc11042dd1dbf1eabd40af206027bc65acc3186
Reviewed-on: https://skia-review.googlesource.com/8444
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| b2cb53589b81b450056732b524706fad39bfca1a |
|
20-Dec-2016 |
Robert Phillips <robertphillips@google.com> |
Fix more Skia filter fuzzer bugs
This CL fixes 3 fuzzer bugs:
the rowBytes computation is really unfortunate in ReadRawPixels when width or height is negative
In two instances uints were being read through the underlying SkReader32 rather than going through the readUInt virtual
In skip SkAlign4 can wrap around and return an answer of 0 for large size_ts!!
Change-Id: I657e3afdb4804627604b59abc8008ccdfe47eab2
Reviewed-on: https://skia-review.googlesource.com/6332
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkReadBuffer.cpp
|
| e54c75f351c775201049743c506d7a508d0fef91 |
|
13-Oct-2016 |
Mike Klein <mtklein@chromium.org> |
remove SkError
It has not caught on.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3321
Change-Id: Ib2ee4ef99bc89c8f4b7504e42a9d7d9dfc483015
Reviewed-on: https://skia-review.googlesource.com/3321
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkReadBuffer.cpp
|
| 97bbf8211fa35bbb0811d5835cb0eaaf37cc679e |
|
25-Sep-2016 |
brianosman <brianosman@google.com> |
Add SkColor4f serialization
Adjusted usage in color shader, and will also be using this
in gradients, soon.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334123003
Review-Url: https://codereview.chromium.org/2334123003
/external/skia/src/core/SkReadBuffer.cpp
|
| 54dc4878b02765efea39e68b218df1e4bfff4b88 |
|
13-Sep-2016 |
reed <reed@google.com> |
add pipecanvas
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201323003
Review-Url: https://codereview.chromium.org/2201323003
/external/skia/src/core/SkReadBuffer.cpp
|
| 2867e7648069272ad1827ebafe49bd0d22a619b3 |
|
29-Aug-2016 |
reed <reed@google.com> |
change readTypeface to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290653002
TBR=mtklein
Review-Url: https://codereview.chromium.org/2290653002
/external/skia/src/core/SkReadBuffer.cpp
|
| a9ca05ca5e604b9ee18e9cce19b059085ca0e22c |
|
11-Aug-2016 |
reed <reed@google.com> |
Deserialize pictures with custom image-deserializer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187613002
Review-Url: https://codereview.chromium.org/2187613002
/external/skia/src/core/SkReadBuffer.cpp
|
| 96e4e1ca5a7dbe08b396817da30adfa3ecfd438c |
|
09-Jun-2016 |
mtklein <mtklein@chromium.org> |
Add raw pixel serialization fallback for SkImages that cannot be encoded.
This fixes serialize-8888 for 2 GMs on Mac that I'm now unblacklisting.
I think another was already fixed, and two more were Windows-only.
Seems safe to use encoded_size=1 as another sentinel here (like we already
use =0); I can't imagine any encoded image format that can encode an image
in a single byte.
I suspect this is the root of the referenced bug too,
but this is a good idea even if not.
BUG=chromium:601851
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2039813007
CQ_EXTRA_TRYBOTS=client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot;client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Release-Trybot
Review-Url: https://codereview.chromium.org/2039813007
/external/skia/src/core/SkReadBuffer.cpp
|
| 444f1ba1b7fcca7eca9fda839ca6b613ff31135e |
|
03-May-2016 |
brianosman <brianosman@google.com> |
Remove SkBitmapHeap and SkBitmapHeapReader. They're unused.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1938033002
Review-Url: https://codereview.chromium.org/1938033002
/external/skia/src/core/SkReadBuffer.cpp
|
| 18f13f3673c20fec220a1594b3174f9dcab35c5d |
|
02-May-2016 |
brianosman <brianosman@google.com> |
Remove (almost) unused read/writeFunctionPtr API.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1937053002
Review-Url: https://codereview.chromium.org/1937053002
/external/skia/src/core/SkReadBuffer.cpp
|
| 57b46159740020ef904aaf41e9e5ae07106591cc |
|
02-May-2016 |
brianosman <brianosman@google.com> |
Remove unused encodedString API on SkWriteBuffer/SkReadBuffer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1936103002
Review-Url: https://codereview.chromium.org/1936103002
/external/skia/src/core/SkReadBuffer.cpp
|
| a3b3b238f507a6ec7f43febc6bf0bb17e04e770f |
|
22-Apr-2016 |
msarett <msarett@google.com> |
Enable flattening/unflattening with custom unflatten procs
Now flattenables are serialized using a string name, so that
flattenables do not necessarily need to be registered before
serialization. They just need to override getTypeName().
Allows custom unflatten procs to be set on the SkReadBuffer.
This is optional if the flattenable is registered, but otherwise
must be called.
This was split off from:
https://codereview.chromium.org/1837913003/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858323002
Review URL: https://codereview.chromium.org/1858323002
/external/skia/src/core/SkReadBuffer.cpp
|
| 9ca06c4b00bfb9bb1a7f352efd264185e5a95fbc |
|
20-Apr-2016 |
robertphillips <robertphillips@google.com> |
Fix ImageFilter fuzzer issue
What appears to be happening in this fuzz is that a paint index inside the picture of an SkPictureImageFilter is getting changed to be out of range.
BUG=skia:5192
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893423002
Review URL: https://codereview.chromium.org/1893423002
/external/skia/src/core/SkReadBuffer.cpp
|
| 6c71e0a065c2eb32139682bb1ca1cbbeb02ebcb9 |
|
07-Apr-2016 |
benjaminwagner <benjaminwagner@google.com> |
Reverse dependency between SkScalar.h and SkFixed.h.
The following are unused in Chromium, Android, Mozilla, and Google3:
- SkFixedToScalar
- SkScalarToFixed
The following are additionally unused in Skia:
- SkStrAppendFixed
- SkWriteBuffer::writeFixed
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1841123002
Review URL: https://codereview.chromium.org/1841123002
/external/skia/src/core/SkReadBuffer.cpp
|
| 3b37545bc594a96de45eba62dea0ce478750f2a9 |
|
04-Apr-2016 |
mtklein <mtklein@google.com> |
Revert of Delete SkFlattenable::Type (patchset #2 id:20001 of https://codereview.chromium.org/1834303003/ )
Reason for revert:
Used by Chrome.
c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C2039: 'GetFlattenableType': is not a member of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\third_party\skia\include\core\skshader.h(19): note: see declaration of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C3861: 'GetFlattenableType': identifier not found
Original issue's description:
> Delete SkFlattenable::Type
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003
>
> Committed: https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f
TBR=reed@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1853383002
/external/skia/src/core/SkReadBuffer.cpp
|
| 99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f |
|
04-Apr-2016 |
msarett <msarett@google.com> |
Delete SkFlattenable::Type
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003
Review URL: https://codereview.chromium.org/1834303003
/external/skia/src/core/SkReadBuffer.cpp
|
| 60c9b58b3214b0154c931656e91e39b230e987d8 |
|
03-Apr-2016 |
reed <reed@google.com> |
change flattenable factory to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855733002
Review URL: https://codereview.chromium.org/1855733002
/external/skia/src/core/SkReadBuffer.cpp
|
| d19d83ce5e3e388fadea0e02d99a645364d41640 |
|
31-Mar-2016 |
msarett <msarett@google.com> |
Remode dead code from SkReadBuffer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845283002
Review URL: https://codereview.chromium.org/1845283002
/external/skia/src/core/SkReadBuffer.cpp
|
| 9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 |
|
29-Mar-2016 |
halcanary <halcanary@google.com> |
Style bikeshed - remove extraneous whitespace
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002
Review URL: https://codereview.chromium.org/1842753002
/external/skia/src/core/SkReadBuffer.cpp
|
| 7fb4f8bd031eda87e1da9bc0f749968c0e872e6f |
|
11-Mar-2016 |
reed <reed@google.com> |
Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1778393002/ )"
Fix was to call get() instead of release() when passing the sp to a bare-ptr method.
This reverts commit e683c56115a210b5993df9294260bb147b408bfa.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1789443002
TBR=
Review URL: https://codereview.chromium.org/1789443002
/external/skia/src/core/SkReadBuffer.cpp
|
| e683c56115a210b5993df9294260bb147b408bfa |
|
11-Mar-2016 |
robertphillips <robertphillips@google.com> |
Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1778393002/ )
Reason for revert:
Experimental revert to try to clear up ASAN failures
Original issue's description:
> add Make variations to return SkImage by sk_sp
>
> some internal call-sites update, but not. Will follow-up in future to complete that.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778393002
>
> Committed: https://skia.googlesource.com/skia/+/bd73ffb83022f1f6b1997e2a91c049949e88a8a2
TBR=fmalita@chromium.org,bsalomon@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1783063002
/external/skia/src/core/SkReadBuffer.cpp
|
| bd73ffb83022f1f6b1997e2a91c049949e88a8a2 |
|
10-Mar-2016 |
reed <reed@google.com> |
add Make variations to return SkImage by sk_sp
some internal call-sites update, but not. Will follow-up in future to complete that.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778393002
Review URL: https://codereview.chromium.org/1778393002
/external/skia/src/core/SkReadBuffer.cpp
|
| 950fb1ca24cca9803eb29dc6aa5472b0f506a67f |
|
19-Feb-2016 |
scroggo <scroggo@google.com> |
Insert an empty image when we cannot decode
In SKP deserialization, if there is a 0 byte encoded image, we insert
an empty image into the output SkPicture so that we can continue
deserializing. Do the same when our decoder cannot decode it. This may
be the result of a bug in our decoder, or in the stream serialization.
But it should not mean the entire stream is invalid.
BUG=skia:4691
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715853002
Review URL: https://codereview.chromium.org/1715853002
/external/skia/src/core/SkReadBuffer.cpp
|
| b0d25466be6106a0084a4d76c6f79efe389ba820 |
|
21-Jan-2016 |
reed <reed@google.com> |
detect bad/corrupt flattenable factory indices
BUG=skia:4814
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1615883002
Review URL: https://codereview.chromium.org/1615883002
/external/skia/src/core/SkReadBuffer.cpp
|
| c752badbe3e4af84ca4c2b1d10adabbe4096e204 |
|
20-Oct-2015 |
caryclark <caryclark@google.com> |
remove debug statement
R=djsollen@google.com
Review URL: https://codereview.chromium.org/1415603004
/external/skia/src/core/SkReadBuffer.cpp
|
| cd56f812e09fdd8f8322c5c28cbc4423a74b9a0a |
|
14-Sep-2015 |
fmalita <fmalita@chromium.org> |
SkImageSource
Blink is migrating away from SkBitmaps, so we need an SkImage-based
SkImageFilter source. This is pretty much a 1-1 equivalent of
SkBitmapSource.
To avoid duplication, relocate the SkImage deserialization logic
from SkPictureData to SkReadBuffer.
R=reed@google.com,robertphillips@google.com,senorblanco@chromium.org
Review URL: https://codereview.chromium.org/1343703005
/external/skia/src/core/SkReadBuffer.cpp
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkReadBuffer.cpp
|
| 88fd0fbcccea615f2d2cd61a121ac9e3185adfe4 |
|
01-Dec-2014 |
mtklein <mtklein@chromium.org> |
Bump min picture version.
Chrome Stable is M39, which produces picture format v35:
https://chromium.googlesource.com/skia/+/chrome/m39/include/core/SkPicture.h
We don't need any code to deal with pictures older than v35.
(When M40 goes stable, we can step up to v37, the current latest version.)
BUG=skia:
Review URL: https://codereview.chromium.org/770703002
/external/skia/src/core/SkReadBuffer.cpp
|
| 09a79d09981ee363b1518bb40c108e6266bc28c6 |
|
12-Nov-2014 |
reed <reed@google.com> |
cleanup comments
BUG=skia:
Review URL: https://codereview.chromium.org/715233005
/external/skia/src/core/SkReadBuffer.cpp
|
| ac6a2f964ee9821df6a4a8f3c46796322a4c37b8 |
|
12-Nov-2014 |
reed <reed@google.com> |
detect bad bitmaps during deserialization
BUG=skia:3117
Review URL: https://codereview.chromium.org/718103002
/external/skia/src/core/SkReadBuffer.cpp
|
| b3c9d1c33caf325aada244204215eb790c228c12 |
|
12-Aug-2014 |
dandov <dandov@google.com> |
SkCanvas::drawPatch param SkPoint[12]
drawPatch now receives as parameter const SkPoint cubics[12]
Adjusted derived classes and serialization.
Ajusted GM's and benches that take into account combinations of optional
parameters, the scale of the patch and 4 different types of patches.
Planning on adding the extra functionality of SkPatch in another CL.
BUG=skia:
R=egdaniel@google.com, reed@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/463493002
/external/skia/src/core/SkReadBuffer.cpp
|
| 963137b75c0a1fe91f35e9826742f36309f5e65d |
|
07-Aug-2014 |
dandov <dandov@google.com> |
Stopped skipping tests in dm of SkPatch by implementing the
corresponding drawPath calls on classes that derive from SkCanvas.
BUG=skia:
R=egdaniel@google.com, bsalomon@google.com, mtklein@google.com, robertphillips@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/429343004
/external/skia/src/core/SkReadBuffer.cpp
|
| 75e9e6373ef25b43acbef6f2e9389a262d7286ba |
|
07-Jul-2014 |
reed <reed@google.com> |
don't look at SK_SCALAR_IS_FLOAT -- it is true, but no longer defined
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/371033004
/external/skia/src/core/SkReadBuffer.cpp
|
| 0951fe12984944406e0f1bb105b9fa4c54fcdcdd |
|
06-Jun-2014 |
sugoi <sugoi@chromium.org> |
Fixing another clusterfuzz issue
This was introduced by removing SkValidatingReadBuffer::readBitmap in https://codereview.chromium.org/295793002/
Since SkReadBuffer::skip wasn't virtual, it was using the unsafe SkReadBuffer::skip within SkReadBuffer::readBitmap rather than using SkValidatingReadBuffer::skip. I also removed direct uses of fReader within SkReadBuffer::readBitmap so that it can use the virtual readInt / readFixed functions that have a version in SkValidatingReadBuffer.
Also, I changed SkReadBuffer::readPoint so that it uses the virtual readScalar, that way, it becomes redundant with SkValidatingReadBuffer::readPoint, which can then be removed.
BUG=380723
R=reed@google.com, mtklein@google.com, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/317003003
/external/skia/src/core/SkReadBuffer.cpp
|
| a3264e53ee3f3c5d6a2c813df7e44b5b96d207f2 |
|
30-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)"
This reverts commit eecaea4148805834f223681f70b6488ceba12d09.
R=robertphillips@google.com, scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/301283003
git-svn-id: http://skia.googlecode.com/svn/trunk@14989 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| d0f824cfbd8951bb948b19d7ff5dce028ce557a5 |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)
Reason for revert:
broke all Windows bots
Original issue's description:
> setConfig -> setInfo
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14978
R=robertphillips@google.com, reed@google.com
TBR=reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: epoger@google.com
Review URL: https://codereview.chromium.org/302053002
git-svn-id: http://skia.googlecode.com/svn/trunk@14979 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 986d681f3e7a7eb6febd9df9fe21a8d277ba2296 |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
setConfig -> setInfo
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/308683005
git-svn-id: http://skia.googlecode.com/svn/trunk@14978 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 851155c28e18e3f5b702ef15ee7bfb12f3cbacda |
|
27-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SK_SUPPORT_LEGACY_BITMAPFLATTEN code
BUG=skia:
R=scroggo@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/303563002
git-svn-id: http://skia.googlecode.com/svn/trunk@14888 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 968edcafa61442dc4f7f8ed8f89523d0f353e9fb |
|
23-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
stop calling SkBitmap::flatten
BUG=skia:
R=scroggo@google.com, halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/295793002
git-svn-id: http://skia.googlecode.com/svn/trunk@14867 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 83f23d87f1d67e6e73873e1ef7cda621c43703a0 |
|
22-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove unused (by clients) SkUnitMapper
This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.
TBR=scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/288313009
git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 3339ac54a5ed75f2872ab16e9052a8b9ff3564bf |
|
22-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/)
Reason for revert:
required blink change failed to land
Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
>
> This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830
R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/296823008
git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 4b8f8022550daa7458ed3de207d1300917d4a8cb |
|
21-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/288343009
git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 7ed173b1ebac84671fb0dc1b9bd323a5e6e63771 |
|
20-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
formalize named picture versions
BUG=skia:
R=mtklein@google.com, robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/291913004
git-svn-id: http://skia.googlecode.com/svn/trunk@14807 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| e2b193ca5c76f01f8e12b4a92e9bd6ccb3ed4280 |
|
16-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
Reason for revert:
does not address all legacy callsites in chrome.
e.g.
[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));
Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/287063009
git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| ee0cac336c6a3a357ae3cb18be8ef4b3cb5edddb |
|
16-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove unused (by clients) SkUnitMapper
BUG=skia:
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/283273002
git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| f117781362ecf673f43f93918781853690f0e145 |
|
23-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix size_t/int warnings
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/247753003
git-svn-id: http://skia.googlecode.com/svn/trunk@14332 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 0943f5f58abcff15c7583faafe44549b9a44f47a |
|
28-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Thread picture version through to SkReadBuffer.
This will let code outside SkPicture* fork its read code based on the picture version.
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/214413008
git-svn-id: http://skia.googlecode.com/svn/trunk@13984 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|
| 8b0e8ac5f582de80356019406e2975079bf0829d |
|
30-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactor read and write buffers.
Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer
a step each in the hierarchy.
What used to be this:
SkFlattenableWriteBuffer -> SkOrderedWriteBuffer
SkFlattenableReadBuffer -> SkOrderedReadBuffer
SkFlattenableReadBuffer -> SkValidatingReadBuffer
is now
SkWriteBuffer
SkReadBuffer -> SkValidatingReadBuffer
Benefits:
- code is simpler, names are less wordy
- the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed
- write buffers are completely devirtualized, important for record speed
This refactoring was mostly mechanical. You aren't going to find anything
interesting in files with less than 10 lines changed.
BUG=skia:
R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/134163010
git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkReadBuffer.cpp
|