| 3b7658a4752e1332c684ad757686ce9ee0e5fbd1 |
|
20-Sep-2017 |
Mike Klein <mtklein@chromium.org> |
Teach TSAN directly about semaphore_t.
Instead of teaching TSAN than SkMutex is a lock to get around it not
understanding Mach semaphore_t routines, teach it that there is a
happens-before relationship between semaphore_signal() and
semaphore_wait().
This reverts commit e395bf2d189e22822ddf2b46541c510d6d8fbcc0.
New changes are entirely restricted to SkSemaphore.cpp.
Change-Id: I27f647b93c48e81e8327db849881d669c4cd3d04
Reviewed-on: https://skia-review.googlesource.com/49180
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkSharedMutex.cpp
|
| e395bf2d189e22822ddf2b46541c510d6d8fbcc0 |
|
19-Sep-2017 |
Mike Klein <mtklein@chromium.org> |
Mac TSAN support: annotate Sk[Base]Mutex as a mutex.
TSAN does not intercept Mach semaphore_t calls used to implement
SkBaseMutex's fSemaphore (its OSSemaphore field). We can teach
it that Sk[Base]Mutex is a mutex anyway with the same annotations
we use for SkSharedMutex.
Change-Id: Ib91928bb9fcfa94f5cea985b46dea31ff2b56963
Reviewed-on: https://skia-review.googlesource.com/48580
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/core/SkSharedMutex.cpp
|
| e6ec16356ec677e582230002bd3ffab46fd14a49 |
|
30-Aug-2016 |
mtklein <mtklein@chromium.org> |
Detect TSAN instead of relying on #ifdef THREAD_SANITIZER.
And reindent.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293063002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot
Review-Url: https://codereview.chromium.org/2293063002
/external/skia/src/core/SkSharedMutex.cpp
|
| e4c17356b6c819df8effb29dfb4bb903520b8c2b |
|
29-Sep-2015 |
herb <herb@google.com> |
Unify ThreadID.
BUG=skia:
Review URL: https://codereview.chromium.org/1371303003
/external/skia/src/core/SkSharedMutex.cpp
|
| b906daf112416c1698a79cf51aa70fe11aa19d0a |
|
29-Sep-2015 |
herb <herb@google.com> |
Have /src files use header directly.
BUG=skia:
Review URL: https://codereview.chromium.org/1373253003
/external/skia/src/core/SkSharedMutex.cpp
|
| e6e41a8a19976a822de36379db23184ff2f28601 |
|
28-Sep-2015 |
herb <herb@google.com> |
Move SkAtomics.h to private.
There are no API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1369333004
/external/skia/src/core/SkSharedMutex.cpp
|
| 7f0a3d7523377097184309152f883f1fcb12a4b8 |
|
24-Sep-2015 |
herb <herb@google.com> |
Make mutex semaphore based.
This implementation improves performance of SkMutex acquire / release pair from 42ns -> 13 ns.
SkSharedMutex and SkSpinlock have the same performance.
It also removes specialized windows and linux/mac code.
BUG=skia:
Review URL: https://codereview.chromium.org/1359733002
/external/skia/src/core/SkSharedMutex.cpp
|
| 966e3d30baf676dc399dc9c97ef15cc2c4f8d461 |
|
18-Sep-2015 |
herb <herb@google.com> |
Add debug mode to shared mutex.
Review URL: https://codereview.chromium.org/1307863009
/external/skia/src/core/SkSharedMutex.cpp
|
| 3060f3efa0d15f613eeeb25221f2b9bf728cc8aa |
|
16-Sep-2015 |
herb <herb@google.com> |
Use atomic subtract in shared mutex.
BUG=skia:
Review URL: https://codereview.chromium.org/1348173003
/external/skia/src/core/SkSharedMutex.cpp
|
| ab42ec79d5dbf38b81394c55670b495cdf78b243 |
|
19-Aug-2015 |
herb <herb@google.com> |
Add asserts for shared mutex.
BUG=skia:
Review URL: https://codereview.chromium.org/1285973003
/external/skia/src/core/SkSharedMutex.cpp
|
| fd9a6a227b269f23fb5b353318f1d3a667617329 |
|
15-Jul-2015 |
herb <herb@google.com> |
Fix undefined behavior.
BUG=skia:4050
Review URL: https://codereview.chromium.org/1232003008
/external/skia/src/core/SkSharedMutex.cpp
|
| dec1afcf34dfb91f3bf0552feffc46b8865fcb36 |
|
30-Jun-2015 |
herb <herb@google.com> |
Add annotations to SkSharedMutex.
BUG=skia:3997
Review URL: https://codereview.chromium.org/1213663004
/external/skia/src/core/SkSharedMutex.cpp
|
| c782b2a046763dc427fa47d4e33afca59c994d60 |
|
29-Jun-2015 |
herb <herb@google.com> |
Implement shared locks in the style of pthread's rwlock.
BUG=skia:
Review URL: https://codereview.chromium.org/1215503005
/external/skia/src/core/SkSharedMutex.cpp
|