| bbfd5161ed08710de6106101e64e3417ab32d2db |
|
07-Nov-2017 |
Chris Dalton <csmartdalton@google.com> |
Don't use analytic clip FPs when drawing to stencil
It doesn't make sense to multiply by coverage when drawing to stencil.
This could theoretically work with FPs that discard and/or modify
the sample mask, but for the time being an analytic FP means one that
calculates a coverage value.
Bug: skia:7190
Change-Id: I44140a5823f8683ec08244bdf9d369f51fa05dd9
Reviewed-on: https://skia-review.googlesource.com/68362
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/src/gpu/GrClip.h
|
| 428e568fd8b0555688f8520c0b57291fbbbb3b69 |
|
07-Nov-2017 |
Chris Dalton <csmartdalton@google.com> |
Revert "Don't use analytic clip FPs when drawing to stencil"
This reverts commit 4c92d4aa3ed653afdff9996b90a1139ed1dc9420.
Reason for revert: Chromecast bot failure
Original change's description:
> Don't use analytic clip FPs when drawing to stencil
>
> It doesn't make sense to multiply by coverage when drawing to stencil.
> This could theoretically work with FPs that discard and/or modify
> the sample mask, but for the time being an analytic FP means one that
> calculates a coverage value.
>
> Bug: skia:7190
> Change-Id: Ic40cf6c19c377cba80bad458993582f5cc07022a
> Reviewed-on: https://skia-review.googlesource.com/67423
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
TBR=bsalomon@google.com,robertphillips@google.com,csmartdalton@google.com
Change-Id: Ie5bd4852c201e47daee0920f5644141bee2d8a46
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7190
Reviewed-on: https://skia-review.googlesource.com/68400
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/src/gpu/GrClip.h
|
| 4c92d4aa3ed653afdff9996b90a1139ed1dc9420 |
|
06-Nov-2017 |
Chris Dalton <csmartdalton@google.com> |
Don't use analytic clip FPs when drawing to stencil
It doesn't make sense to multiply by coverage when drawing to stencil.
This could theoretically work with FPs that discard and/or modify
the sample mask, but for the time being an analytic FP means one that
calculates a coverage value.
Bug: skia:7190
Change-Id: Ic40cf6c19c377cba80bad458993582f5cc07022a
Reviewed-on: https://skia-review.googlesource.com/67423
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/src/gpu/GrClip.h
|
| ba7cf29fa8cb60514177bcf7c91f5f1607480ad6 |
|
02-Nov-2017 |
Jim Van Verth <jvanverth@google.com> |
Revert "Revert "Fix int overflow issues with clip and path bounds, take 2.""
This reverts commit e3a700522f6e088be00011bc98fcdc4a13bd798b.
Reason for revert: The GM changes I saw appear to be due to a new bot.
Original change's description:
> Revert "Fix int overflow issues with clip and path bounds, take 2."
>
> This reverts commit 430ad1f2065c182746e43e67ca95fb911cc55892.
>
> Reason for revert: Many bad GMs.
>
> Original change's description:
> > Fix int overflow issues with clip and path bounds, take 2.
> >
> > * Change IsInsideClip test to be more int overflow friendly
> > * Check to make sure path bounds can have representable width and height
> >
> > Bug: skia:7239
> > Bug: skia:7240
> > Change-Id: If8468e46bc74a428c25d466ff3756d0cad385c09
> > Reviewed-on: https://skia-review.googlesource.com/66154
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Commit-Queue: Jim Van Verth <jvanverth@google.com>
>
> TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com
>
> Change-Id: I5b1a651b60340bb4230893ef5f5d2df2ce6fd241
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:7239, skia:7240
> Reviewed-on: https://skia-review.googlesource.com/67240
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com
Change-Id: I710ebeec30a4d7eb5fe7dd3a168df28073733cab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7239, skia:7240
Reviewed-on: https://skia-review.googlesource.com/66862
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/gpu/GrClip.h
|
| e3a700522f6e088be00011bc98fcdc4a13bd798b |
|
02-Nov-2017 |
Jim Van Verth <jvanverth@google.com> |
Revert "Fix int overflow issues with clip and path bounds, take 2."
This reverts commit 430ad1f2065c182746e43e67ca95fb911cc55892.
Reason for revert: Many bad GMs.
Original change's description:
> Fix int overflow issues with clip and path bounds, take 2.
>
> * Change IsInsideClip test to be more int overflow friendly
> * Check to make sure path bounds can have representable width and height
>
> Bug: skia:7239
> Bug: skia:7240
> Change-Id: If8468e46bc74a428c25d466ff3756d0cad385c09
> Reviewed-on: https://skia-review.googlesource.com/66154
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com
Change-Id: I5b1a651b60340bb4230893ef5f5d2df2ce6fd241
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7239, skia:7240
Reviewed-on: https://skia-review.googlesource.com/67240
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/gpu/GrClip.h
|
| 430ad1f2065c182746e43e67ca95fb911cc55892 |
|
02-Nov-2017 |
Jim Van Verth <jvanverth@google.com> |
Fix int overflow issues with clip and path bounds, take 2.
* Change IsInsideClip test to be more int overflow friendly
* Check to make sure path bounds can have representable width and height
Bug: skia:7239
Bug: skia:7240
Change-Id: If8468e46bc74a428c25d466ff3756d0cad385c09
Reviewed-on: https://skia-review.googlesource.com/66154
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/gpu/GrClip.h
|
| e26062a169e2ff15436b715ea237a0342a4abf55 |
|
31-Oct-2017 |
Mike Klein <mtklein@chromium.org> |
Revert "Fix int overflow issues with clip and path bounds."
This reverts commit b1fc36829de69da5376019403fdd649c06f4cf1b.
Reason for revert:
I hate to revert this, but I think it's caused some layout test diffs that are holding up the roll.
https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/17909/layout-test-results/results.html
Original change's description:
> Fix int overflow issues with clip and path bounds.
>
> * Clamp scissor clip bounds to query bounds (which are RT bounds)
> * Change IsInsideClip test to be more int overflow friendly
> * Check to make sure path bounds can have representable width and height
>
> Bug: skia:7239
> Bug: skia:7240
> Change-Id: I4c512d05c5609a5a466393408282101697ebea83
> Reviewed-on: https://skia-review.googlesource.com/65506
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
TBR=jvanverth@google.com,bsalomon@google.com,csmartdalton@google.com
Change-Id: Ic5c15219cdbe92811284130bce1e984823f0c4d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7239, skia:7240
Reviewed-on: https://skia-review.googlesource.com/65920
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/gpu/GrClip.h
|
| b1fc36829de69da5376019403fdd649c06f4cf1b |
|
31-Oct-2017 |
Jim Van Verth <jvanverth@google.com> |
Fix int overflow issues with clip and path bounds.
* Clamp scissor clip bounds to query bounds (which are RT bounds)
* Change IsInsideClip test to be more int overflow friendly
* Check to make sure path bounds can have representable width and height
Bug: skia:7239
Bug: skia:7240
Change-Id: I4c512d05c5609a5a466393408282101697ebea83
Reviewed-on: https://skia-review.googlesource.com/65506
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/gpu/GrClip.h
|
| 348060fa820e1ee7a4fd246afe517a80a9ef311d |
|
05-Jun-2017 |
Chris Dalton <csmartdalton@google.com> |
Fix GrReducedClip.cpp: assertion failure surrounding tiny query bounds
Some assertions cannot be relied upon due to FP error.
Bug: skia:5990
Change-Id: I32445b320b9100ae2f80d2f762707d823da77805
Reviewed-on: https://skia-review.googlesource.com/18602
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/src/gpu/GrClip.h
|
| 97180af7f5e577a451367aa0c15cfaff1b6076f5 |
|
14-Mar-2017 |
Brian Salomon <bsalomon@google.com> |
Compute clipped draw bounds outside GrAppliedClip.
We will be storing GrAppliedClips alongside ops. The op already stores the
clipped bounds. If GrAppliedClip has draw bounds then as ops combine the
GrAppliedClip's bounds should be merged to be consistent. However, we won't
actually ever use those bounds again so it would be wasteful to merge them.
Change-Id: I4ef3010dc04761e256120a2e0e074bc3c6ff6ca1
Reviewed-on: https://skia-review.googlesource.com/9642
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
/external/skia/src/gpu/GrClip.h
|
| c65aec97619682b2c0191554f44ddf35f618a94d |
|
09-Mar-2017 |
Brian Salomon <bsalomon@google.com> |
Make GrClip.h private
BUG=skia:
Change-Id: I4aa3c2707811ece3a63d161035e316c3bbc1cd15
Reviewed-on: https://skia-review.googlesource.com/9482
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/gpu/GrClip.h
|