| a0657609f1f9304b1de63871ef91fc6cbca0d0f7 |
|
26-Apr-2018 |
Brian Salomon <bsalomon@google.com> |
Revert "Reland "Revert "Add arcs as a specialized geometry to GrShape."""
This reverts commit 580aee2fa4a57bf8208498fbc23acea04e16e092.
Bug: skia:7794
Change-Id: I9c2b923859c826dff58c22c529dc4e2ab4d0f186
Reviewed-on: https://skia-review.googlesource.com/124042
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
(cherry picked from commit e4949406ebcc5d5d8f83c1cd96209763d278b1e2)
Reviewed-on: https://skia-review.googlesource.com/124560
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
/external/skia/src/gpu/GrShape.h
|
| da6d0720300a29a4deb5dd4c433a92a3ec41286e |
|
03-Jan-2018 |
Brian Salomon <bsalomon@google.com> |
Make GrShape lazily initialize an original path for gen id change listeners
Change-Id: I3a1cb400190cf18241436b7e655a4a267bb2e22d
Reviewed-on: https://skia-review.googlesource.com/90482
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/gpu/GrShape.h
|
| 72f78c37010eb2bf20be4884d4f376d122830dfd |
|
21-Dec-2017 |
Brian Salomon <bsalomon@google.com> |
Make GrShape recognize horizontal/vertical dashed lines with 0 off intervals as rrects.
Change-Id: Ic29b41911e0185d36093d5352f4494709e8124ba
Reviewed-on: https://skia-review.googlesource.com/88428
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/src/gpu/GrShape.h
|
| 2fad74a0fdc5eb3f505a052849c3cbeffa6e2d17 |
|
20-Dec-2017 |
Brian Salomon <bsalomon@google.com> |
Make GrRenderTargetContext::drawPath() use GrShape to identify simpler
geometries.
Change-Id: I24230efc8bcb60f00c0c855090e3311ad13d7da8
Reviewed-on: https://skia-review.googlesource.com/85962
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/gpu/GrShape.h
|
| b379dcd64eb69140f4393ac922d0774cc7d15596 |
|
04-Oct-2017 |
Brian Osman <brianosman@google.com> |
Sever fOriginalPath connection whenever a GrShape becomes a simple type
When drawing a round-rect, for example, we may end up in drawPath with a
temporary path that was created with the rrect added. We ended up putting
a genID listener on that (stack allocated) path, so we would evict cache
entries immediately. This restores the old behavior, where cache entries
for paths derived from simple types are never invalidated.
Bug: skia:7087
Change-Id: I3eed9c3a289241bfe1e42036be3362f592256693
Reviewed-on: https://skia-review.googlesource.com/54460
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/gpu/GrShape.h
|
| f6f7cf60985d8e109cc136f25e2a3c3383ca05ea |
|
25-Sep-2017 |
Brian Osman <brianosman@google.com> |
Invalidate path VBs when paths are destroyed
For this to work, we need access to the "original" path,
before any style was applied. To that end, add an original
path to GrShape (and unit tests of that functionality).
Then add a version of addGenIDChangeListener to GrShape,
that propagates to the original path, and use that in
tessellating path renderer.
Includes unit tests of caching behavior in the PR, all
of which failed without this change.
Bug: skia:
Change-Id: I98bb505f521e8ff07184f5c3fbd3c5fd1a22d3d5
Reviewed-on: https://skia-review.googlesource.com/50300
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/gpu/GrShape.h
|
| 4f40caf33e15c4e2e21742854dfd5cfd31812c3f |
|
01-Sep-2017 |
Brian Salomon <bsalomon@google.com> |
Add methods for converting GrShape to filled style
Bug: skia:
Change-Id: I6726428d1358909972adec8d63686b637ef5bb5e
Reviewed-on: https://skia-review.googlesource.com/40222
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/gpu/GrShape.h
|
| 085c0862f674337c5a60f8c46da4c12f0d12511a |
|
31-Aug-2017 |
Brian Salomon <bsalomon@google.com> |
Revert "Revert "Add a GrShape::Type value for an inverted empty path""
This reverts commit 07f5b71f996ec387408ac7c85952b63bf893ec88.
Bug: skia:
Change-Id: I14cc34ab563028a4a24de2112575ab4516f1c7c7
Reviewed-on: https://skia-review.googlesource.com/41441
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/gpu/GrShape.h
|
| 07f5b71f996ec387408ac7c85952b63bf893ec88 |
|
31-Aug-2017 |
Brian Salomon <bsalomon@google.com> |
Revert "Add a GrShape::Type value for an inverted empty path"
This reverts commit d5a3f7f9673a152928332a38e53a5fc55f590f40.
Reason for revert: GMs changed
Original change's description:
> Add a GrShape::Type value for an inverted empty path
>
> Change-Id: Ib34a608db07a2ff1d7bdfbd96867fa5ff0ac9782
> Reviewed-on: https://skia-review.googlesource.com/41540
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,robertphillips@google.com
Change-Id: I320dcda62bdb08163fe274325a38f59dd51b3927
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/41640
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/gpu/GrShape.h
|
| d5a3f7f9673a152928332a38e53a5fc55f590f40 |
|
31-Aug-2017 |
Brian Salomon <bsalomon@google.com> |
Add a GrShape::Type value for an inverted empty path
Change-Id: Ib34a608db07a2ff1d7bdfbd96867fa5ff0ac9782
Reviewed-on: https://skia-review.googlesource.com/41540
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/gpu/GrShape.h
|
| 67fa4e31d885acf74514527a2cc3ed759c05d3c4 |
|
21-Sep-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape compute keys for short paths from path data instead of using the gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357643002
Review-Url: https://codereview.chromium.org/2357643002
/external/skia/src/gpu/GrShape.h
|
| 0a0f67ececbdf1a7f81296ed0d2cb9e3bc00e4dc |
|
28-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make lines a special case in GrShape
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
Review-Url: https://codereview.chromium.org/2108523002
/external/skia/src/gpu/GrShape.h
|
| 635df95a9a25c66959f76b4bbb594b75333ded21 |
|
28-Jun-2016 |
bsalomon <bsalomon@google.com> |
Revert of Make lines a special case in GrShape (patchset #5 id:120001 of https://codereview.chromium.org/2108523002/ )
Reason for revert:
Assertion failures
Original issue's description:
> Make lines a special case in GrShape
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
>
> Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2109613003
/external/skia/src/gpu/GrShape.h
|
| c62318c748a1907649bd75382c4f4fd10533f2b3 |
|
28-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make lines a special case in GrShape
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
Review-Url: https://codereview.chromium.org/2108523002
/external/skia/src/gpu/GrShape.h
|
| 728b0f750570ada198bde4c5b4605bc1902de1d4 |
|
27-Jun-2016 |
bsalomon <bsalomon@google.com> |
Use a union inside GrShape to hold geometry
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2094023002
Review-Url: https://codereview.chromium.org/2094023002
/external/skia/src/gpu/GrShape.h
|
| 425c27fab9d82d19b0bce7c091533d546465bbae |
|
23-Jun-2016 |
bsalomon <bsalomon@google.com> |
Add some more getters to GrShape.
These will be used to deploy GrShape in GrPathRenderer subclasses.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2070643002
Review-Url: https://codereview.chromium.org/2070643002
/external/skia/src/gpu/GrShape.h
|
| a4817afe5095b67a68c907ff2e48e3e07907140c |
|
23-Jun-2016 |
bsalomon <bsalomon@google.com> |
Canonicalize path fill types for stroked paths in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085913003
Review-Url: https://codereview.chromium.org/2085913003
/external/skia/src/gpu/GrShape.h
|
| 93f66bc3af522fdd2a5315407ba6d3f65c13fd1c |
|
21-Jun-2016 |
bsalomon <bsalomon@google.com> |
Apply canonicalizations to path GrShapes.
The following canonicalizations of path-backed GrShapes are added:
*convex shapes are stored with even/odd (or inv even/odd) fill.
*filled paths are closed.
*dashed paths ignore inverseness of the fill
This will improve the results of queries about the geometry that will be added in a future change.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067283003
Review-Url: https://codereview.chromium.org/2067283003
/external/skia/src/gpu/GrShape.h
|
| 1b28c1adc1e156831d5332546e942b63fd29075b |
|
20-Jun-2016 |
bsalomon <bsalomon@google.com> |
Some simplifications of GrShape reductions/canonicalizations
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064113004
Review-Url: https://codereview.chromium.org/2064113004
/external/skia/src/gpu/GrShape.h
|
| fd32df716cfc787a3ac50efb293a9317a97078c5 |
|
14-Jun-2016 |
bsalomon <bsalomon@google.com> |
Fix GrShape to preserve inverseness of rrects for strokes but not dashes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2051263003
Review-Url: https://codereview.chromium.org/2051263003
/external/skia/src/gpu/GrShape.h
|
| 398e3f4b9f67e0c7f635e68cae1ff7f42213bbfc |
|
13-Jun-2016 |
bsalomon <bsalomon@google.com> |
Add control over whether lines are special cased in SkDashPath. Disable when called from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002
Review-Url: https://codereview.chromium.org/2055253002
/external/skia/src/gpu/GrShape.h
|
| 7049396b65660907af5292d899053280430d929a |
|
10-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape capable of representing inverse filled rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056523002
Review-Url: https://codereview.chromium.org/2056523002
/external/skia/src/gpu/GrShape.h
|
| 06115ee4300ef6756729dfbcb3e2fc70ebf0413a |
|
07-Jun-2016 |
bsalomon <bsalomon@google.com> |
Get segment masks from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2046753002
Review-Url: https://codereview.chromium.org/2046753002
/external/skia/src/gpu/GrShape.h
|
| ee295645bd91fcbe1714847c5fe5341759037cc5 |
|
06-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape track the winding direction and starting point for rrect types.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042813002
Review-Url: https://codereview.chromium.org/2042813002
/external/skia/src/gpu/GrShape.h
|
| 9fb420393ee1c24fc3282b7155985fa8fa7bcad4 |
|
13-May-2016 |
bsalomon <bsalomon@google.com> |
Add bounds to GrShape
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970003003
Review-Url: https://codereview.chromium.org/1970003003
/external/skia/src/gpu/GrShape.h
|
| 7c73a53894927d222d4aceed96893daae8ea14f1 |
|
12-May-2016 |
bsalomon <bsalomon@google.com> |
Add isEmpty() query to GrShape and improve comments.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971613004
Review-Url: https://codereview.chromium.org/1971613004
/external/skia/src/gpu/GrShape.h
|
| 97fd2d42b97104fa32a58d7e7a5b7255913f9c9d |
|
09-May-2016 |
bsalomon <bsalomon@google.com> |
Incorporate scale into GrStyle and GrShape
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952383003
Review-Url: https://codereview.chromium.org/1952383003
/external/skia/src/gpu/GrShape.h
|
| 06077565b18714ff3fc0db9118e2c21f6f25243f |
|
04-May-2016 |
bsalomon <bsalomon@google.com> |
Make cap only affect the keys of GrShapes that are possibly-open
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1949193002
Review-Url: https://codereview.chromium.org/1949193002
/external/skia/src/gpu/GrShape.h
|
| fb08327e592a1dd19a0c3107243ccd01f6b7f848 |
|
04-May-2016 |
bsalomon <bsalomon@google.com> |
Expand GrStyle's interface.
Adds some basic getters on GrStyle as well as static const instances for fill and hairline.
Adds the ability to apply a GrStyle to a SkPath to produce an output SkPath.
Moves style key functions from GrShape to GrStyle.
Also fixes some issues with SkPath creation when applying style to GrShapes.
Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1951613002
Review-Url: https://codereview.chromium.org/1951613002
/external/skia/src/gpu/GrShape.h
|
| 5e410b4a68d11a06c331139905171952ef535cf8 |
|
28-Apr-2016 |
bsalomon <bsalomon@google.com> |
Detect empty (r)rects in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1929643002
Review-Url: https://codereview.chromium.org/1929643002
/external/skia/src/gpu/GrShape.h
|
| 72dc51c288169f38177c71081090581c5ff415b1 |
|
27-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922713002
Review URL: https://codereview.chromium.org/1922713002
/external/skia/src/gpu/GrShape.h
|
| 47cc7691181e3c9d74f7d66d5bc3c0b7ac7855d5 |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrShape.h
|
| 82ecc5773faa0068186557f8ab2957620a7d72ea |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ )
Reason for revert:
test failing
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
>
> Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1919243002
/external/skia/src/gpu/GrShape.h
|
| 824e58fc6df8fc149d9675f577f7deeaba698b09 |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrShape.h
|
| 83af0a63b1d91c7cd4306c4bcdfb60f99b5cbb46 |
|
26-Apr-2016 |
robertphillips <robertphillips@google.com> |
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #10 id:260001 of https://codereview.chromium.org/1822723003/ )
Reason for revert:
From what I can tell, this compiles on 2015 but not 2013.
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
TBR=egdaniel@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1918203002
/external/skia/src/gpu/GrShape.h
|
| c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 |
|
25-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrShape.h
|