| dfc0e910dfdf7ad11995d357e44c029d839f2e73 |
|
16-Feb-2018 |
Mike Reed <reed@google.com> |
add decal tilemode to shaders
Plenty more to follow-up:
- gradients
- gpu impl
Bug: skia:7638
Change-Id: I8e54fd0e24921f040f178c793b36c7fb855b136e
Reviewed-on: https://skia-review.googlesource.com/107420
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| db78cba957889285604aeacb75e47af4600880c4 |
|
15-Feb-2018 |
Brian Osman <brianosman@google.com> |
Avoid creating MIPs until necessary when MIP bias is active
With sharpened mips, the scale at which we begin to sample level 1 is
(obviously) less than 1. This change avoids creation of mips for images
that are only slightly downscaled (and for which we wouldn't have sampled
those MIPs anyway).
Change-Id: If8ffc79c2ce2ff1f3aae7f5732d8a50aca0e26be
Reviewed-on: https://skia-review.googlesource.com/107801
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 5b6fa82ee12bcebbb5bced07347a6d113a0d87fd |
|
14-Feb-2018 |
Brian Osman <brianosman@google.com> |
Respect FPArgs local matrix when picking a filtering mode in image shader
Includes a GM that previously drew bilerp, now draws bicubic.
Change-Id: I5e39e8adb49057b57729d9eb9748911ee8584401
Reviewed-on: https://skia-review.googlesource.com/107280
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 154771b4dccff130d246c6b067129bafd64afb1a |
|
12-Feb-2018 |
Mike Klein <mtklein@chromium.org> |
clean up SK_LEGACY_HIGH_QUALITY_SCALING_CLAMP
After this rolls out, we can remove
-DSK_LEGACY_HIGH_QUALITY_SCALING_CLAMP from Google and Chromium,
finally.
Change-Id: Ie277843d5ab6e6e762b1b2eea1c23a40cca55a38
Reviewed-on: https://skia-review.googlesource.com/106622
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 1f31309d7a09f5431fef181fd77c59a2da58da81 |
|
03-Jan-2018 |
Mike Klein <mtklein@chromium.org> |
yet another approach to unpremul scale pixels
This keeps punning things to premul (in anticipation of pulling
back on any unpremul support outside read/write/scalePixels),
and yet still clamps correctly for scalePixels() + unpremul + HQ
and/or gamut transform.
Change-Id: I75977cfdb94ffbe62c538ddee39f1abd2cc01935
Reviewed-on: https://skia-review.googlesource.com/106265
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 47cf048abecb5064b9e851ea01f75b23797c1611 |
|
09-Feb-2018 |
Mike Klein <mtklein@chromium.org> |
Revert "alternate approach to unpremul scalePixels()"
This reverts commit c4616804bb407506c6ac1046c7e25e2016911449.
Reason for revert: screwed up the guard I think
Original change's description:
> alternate approach to unpremul scalePixels()
>
> We want to keep the clamps in SkImageShader, and keep unpremul
> scalePixels() happy too.
>
> So we extend SkImageShader's internal API to allow specifying an output
> alpha type, which controls whether we premul or unpremul and how we
> clamp. scalePixels() uses this to draw instead of a drawBitmap() call.
>
> Sort of backwards of usual, we opt our local builds into
> SK_LEGACY_HIGH_QUALITY_SCALING_CLAMP (and Google3 is already defining
> this). Then to rebase Chromium we will _define_ this in Chromium's user
> config, fold it through as if always defined in Skia, then finally
> remove the definition from Chromium's user config.
>
> Change-Id: I38035f0886f79700e7301c3c6042ce362c771d96
> Reviewed-on: https://skia-review.googlesource.com/90480
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com,reed@google.com
Change-Id: Ib53a7f29c25310b667f9a61f67f8638403ec9da3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/106220
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| c4616804bb407506c6ac1046c7e25e2016911449 |
|
03-Jan-2018 |
Mike Klein <mtklein@chromium.org> |
alternate approach to unpremul scalePixels()
We want to keep the clamps in SkImageShader, and keep unpremul
scalePixels() happy too.
So we extend SkImageShader's internal API to allow specifying an output
alpha type, which controls whether we premul or unpremul and how we
clamp. scalePixels() uses this to draw instead of a drawBitmap() call.
Sort of backwards of usual, we opt our local builds into
SK_LEGACY_HIGH_QUALITY_SCALING_CLAMP (and Google3 is already defining
this). Then to rebase Chromium we will _define_ this in Chromium's user
config, fold it through as if always defined in Skia, then finally
remove the definition from Chromium's user config.
Change-Id: I38035f0886f79700e7301c3c6042ce362c771d96
Reviewed-on: https://skia-review.googlesource.com/90480
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 7558e4dbecac109c5e971f5d028b847070e773e7 |
|
07-Feb-2018 |
Florin Malita <fmalita@chromium.org> |
Refactor explicit inverse calculation in SkImageShader::onAppendStages()
We have SkShaderBase::computeTotalInverse() which does exactly that.
Change-Id: I77695f9261d700c3ac25fe94250b798e6edfc25d
Reviewed-on: https://skia-review.googlesource.com/105000
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| a12c419679e5b37b6140a2b33d207fb00a2b891a |
|
01-Feb-2018 |
Mike Reed <reed@google.com> |
check matrix for SkFixed32.32 compatibility
Will have to see if we change any layouttest results
Bug: skia:7569
Change-Id: Id9676ec76a931c9d4d40c79fb0a469c2a215ad5a
Reviewed-on: https://skia-review.googlesource.com/102206
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 28eaed254dcd73b42c15b73528f349cccd7797e5 |
|
01-Feb-2018 |
Mike Reed <reed@google.com> |
add gpu impl for shadermaskfilter
adds MulChildAlphaByInput
renames MulOutputByInputAlpha --> MulChildByInputAlpha
Bug: skia:7500
Change-Id: Ic0615d4d23a887fbee510901ed77a36f98a1b11d
Reviewed-on: https://skia-review.googlesource.com/102440
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| ac568a934f8f82bf3a359b757d67eb3a797d3593 |
|
25-Jan-2018 |
Mike Klein <mtklein@chromium.org> |
1010102, 101010x, 888x in sw
Same sort of deal as before, now with all three new formats.
While I was at it, I made sure RGBA 8888 and BGRA 8888 both work too.
We don't want the 101010's in lowp, but 888x should be fine.
After looking at the DM images on monitors at work, I decided to
re-enable dither even on 10-bit images.
Looking at the GMs in 888x or 101010x is interesting... I think we must
not be clearing the memory allocated for layers? Seems like we want to
allocate layers as 8888?
Change-Id: I3a85b4f00877792a6425a7e7eb31eacb04ae9218
Reviewed-on: https://skia-review.googlesource.com/101640
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| e3429e62b0d020b27de3daa55893953eff581c4f |
|
19-Jan-2018 |
Mike Reed <reed@google.com> |
rename inner AsFPArgs to stand-alone GrFPArgs
This prepares us to share this with other effects (most notably maskfilters)
Bug: skia:
Change-Id: I12530fdf10c4e5f2a9ab6d394bf9e87c54ea60c4
Reviewed-on: https://skia-review.googlesource.com/97062
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 1fa9c434fc0dbe28342c28b7d08cb9361f80c4e2 |
|
11-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
attempt 3: add experimental bilerp_clamp_8888 stage
It looks like we can specialize hot image shaders into their
own single stages for a good speedup on both x86 and ARM.
I've started here with bilerp_clamp_8888, and will
follow up with bgra and 565, and lowp versions of those,
and probably also the same for nearest neighbors.
All pixels are identical in GMs.
This time, rewrite the loop over sample points to be a little
friendlier to 32-bit x86 code generation. The previous version
created an object file indirection feature build_stages.py can't handle.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-All-Android,Test-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-All-Android
Change-Id: I150b6af4a5b89e009dc04ca69e1857892e173deb
Reviewed-on: https://skia-review.googlesource.com/89180
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| d63b6e4c1ebf574336cea2e4517876ba3dc67002 |
|
19-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
Reland "remove bicubic clamp in SkImageShader"
This is a reland of bc9f3499c345ce59f8cd3889c580fa75db54034b
Original change's description:
> remove bicubic clamp in SkImageShader
>
> We ought to be able to handle out-of-gamut colors now, whatever
> their provenance. Should be we can just not clamp here.
>
> Bug: skia:5733
>
> Change-Id: Icd9851543638fd81755afee2eac2347702b88e9f
> Reviewed-on: https://skia-review.googlesource.com/87000
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Brian Osman <brianosman@google.com>
Bug: skia:5733
Change-Id: I66dafdb12abdb02e8677a6f6b18602a2fa3f5f8b
Reviewed-on: https://skia-review.googlesource.com/88760
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 6685555efc64c55156fa76a95add4a0945a1d223 |
|
21-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
Revert "remove bicubic clamp in SkImageShader"
This reverts commit bc9f3499c345ce59f8cd3889c580fa75db54034b.
Reason for revert: gotta be the reason for layout test issues.
Original change's description:
> remove bicubic clamp in SkImageShader
>
> We ought to be able to handle out-of-gamut colors now, whatever
> their provenance. Should be we can just not clamp here.
>
> Bug: skia:5733
>
> Change-Id: Icd9851543638fd81755afee2eac2347702b88e9f
> Reviewed-on: https://skia-review.googlesource.com/87000
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Brian Osman <brianosman@google.com>
TBR=mtklein@chromium.org,brianosman@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:5733
Change-Id: I3bccf494479b845210ee2a6824dcc32b89a93312
Reviewed-on: https://skia-review.googlesource.com/88423
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| bc9f3499c345ce59f8cd3889c580fa75db54034b |
|
19-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
remove bicubic clamp in SkImageShader
We ought to be able to handle out-of-gamut colors now, whatever
their provenance. Should be we can just not clamp here.
Bug: skia:5733
Change-Id: Icd9851543638fd81755afee2eac2347702b88e9f
Reviewed-on: https://skia-review.googlesource.com/87000
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 245c4b21c1b95452b9ed406c43096157bd9e6402 |
|
19-Dec-2017 |
Mike Klein <mtklein@google.com> |
Revert "attempt 2: add experimental bilerp_clamp_8888 stage"
This reverts commit 8a64e52a98d178be13fd137b3b3a3c6aff457d85.
Reason for revert:
Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-All-Android
Test-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-All-Android
Original change's description:
> attempt 2: add experimental bilerp_clamp_8888 stage
>
> It looks like we can specialize hot image shaders into their
> own single stages for a good speedup on both x86 and ARM.
>
> I've started here with bilerp_clamp_8888, and will
> follow up with bgra and 565, and lowp versions of those,
> and probably also the same for nearest neighbors.
>
> All pixels are identical in GMs.
>
> Change-Id: Ib5ed6e528efd9e3eed96ba67d02fbec2e8133a81
> Reviewed-on: https://skia-review.googlesource.com/86860
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,liyuqian@google.com
Change-Id: I34409a7b4aee4fd54baee44f7fc53bd0982500fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/86601
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 8a64e52a98d178be13fd137b3b3a3c6aff457d85 |
|
11-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
attempt 2: add experimental bilerp_clamp_8888 stage
It looks like we can specialize hot image shaders into their
own single stages for a good speedup on both x86 and ARM.
I've started here with bilerp_clamp_8888, and will
follow up with bgra and 565, and lowp versions of those,
and probably also the same for nearest neighbors.
All pixels are identical in GMs.
Change-Id: Ib5ed6e528efd9e3eed96ba67d02fbec2e8133a81
Reviewed-on: https://skia-review.googlesource.com/86860
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| f1f1162273b382db99f8609e5bbfff24f5594821 |
|
18-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
remove append_from_srgb()
It's now no different than append(from_srgb).
Bug: skia:7419
Change-Id: I97c59b6987f033ec2f1859db40ca3056b87b370a
Reviewed-on: https://skia-review.googlesource.com/86741
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 2bbcda3071a2656612fa5a8bc8ab12335ef98aa2 |
|
11-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
Revert "add experimental bilerp_clamp_8888 stage"
This reverts commit a7fa3377d24643d86117159f8a58d2ee66880a4d.
Reason for revert: lots of crashing GPU bots.
Original change's description:
> add experimental bilerp_clamp_8888 stage
>
> It looks like we can specialize hot image shaders into their
> own single stages for a good speedup on both x86 and ARM.
>
> I've started here with bilerp_clamp_8888, and will
> follow up with bgra and 565, and lowp versions of those,
> and probably also the same for nearest neighbors.
>
> All pixels are identical in GMs.
>
> Change-Id: I2f6995767cd38053d670b8d0bfdb71b687803d70
> Reviewed-on: https://skia-review.googlesource.com/82100
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,mtklein@google.com,liyuqian@google.com
Change-Id: If70abb91b69bcd781e395dd3ac05ff1eebb1169f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/83340
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| a7fa3377d24643d86117159f8a58d2ee66880a4d |
|
11-Dec-2017 |
Mike Klein <mtklein@chromium.org> |
add experimental bilerp_clamp_8888 stage
It looks like we can specialize hot image shaders into their
own single stages for a good speedup on both x86 and ARM.
I've started here with bilerp_clamp_8888, and will
follow up with bgra and 565, and lowp versions of those,
and probably also the same for nearest neighbors.
All pixels are identical in GMs.
Change-Id: I2f6995767cd38053d670b8d0bfdb71b687803d70
Reviewed-on: https://skia-review.googlesource.com/82100
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 725d9dbfa59d6804b157f876a7e5d4c0553c6455 |
|
28-Nov-2017 |
Mike Reed <reed@google.com> |
remove unused readBitmapAsImage from readbuffer
Bug: skia:
Change-Id: Ic200ec39999a06f407de29e15b646baddb9e341d
Reviewed-on: https://skia-review.googlesource.com/76982
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| f06ead925c631c42fae734de1e7c72237a2e91f4 |
|
30-Oct-2017 |
Brian Osman <brianosman@google.com> |
Add support for transfer functions to GrColorSpaceXform
With this change, untagged sources (eg N32) are treated as
sRGB data, which causes a huge number of GMs to render more
correctly in GPU sRGB/F16/etc... configs. Also, because the
sources are treated as having a color space, we actually do
gamut conversion for wide or narrow gamut outputs.
This change also applies the transfer function math to
individual colors in the case of gradient stops and color
shaders. (The CPU backend doesn't do this yet, but I think
we've decided there's no reason not to support it).
Bug: skia:
Change-Id: If76e9e4a268f9f74110ff4bbe4fe189ba5d19d9f
Reviewed-on: https://skia-review.googlesource.com/64100
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 4cbb6e6d551e8bea2c040b1aa9dce253cffb9af0 |
|
25-Oct-2017 |
Brian Salomon <bsalomon@google.com> |
Pass GrRenderTargetContext's GrColorSpaceInfo to SkShader and SkColorFilter.
Also to SkColorTo(Premul|Unpremul)GrColor4f.
This can avoid cache lookups to find GrColorSpaceXforms as the xform pointer is stored in GrColorSpaceInfo after the first lookup.
Also uses GrColorSpaceInfo to construct GrTextUtils::Paint.
Bug: skia:
Change-Id: Idf19d512a60d2269e6921c7fb54d93aee499a70d
Reviewed-on: https://skia-review.googlesource.com/63660
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 1cb41717bc4a44272eab48bd47ca7579425dc22e |
|
19-Oct-2017 |
Brian Osman <brianosman@google.com> |
Remove color space xform support from SkSL
Bug: skia:
Change-Id: Ia50c1f750e4626211f012ae7543db126b10134c3
Reviewed-on: https://skia-review.googlesource.com/61906
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 2240be96d97b5ac0886381d74a21f1e2a0928f55 |
|
18-Oct-2017 |
Brian Osman <brianosman@google.com> |
Remove color space xform from GrTextureDomain & GrSimpleTextureEffect
Bug: skia:
Change-Id: I31435d334da28cce9bbc654c4b98746b03078897
Reviewed-on: https://skia-review.googlesource.com/61460
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 85f8536ca2dd446f2f68d82b0e69134a3e7a88b7 |
|
17-Oct-2017 |
Mike Klein <mtklein@chromium.org> |
Feed seed_shader() iota through a context pointer.
As this array grows longer it causes troublesome code generation
when we're compiling offline, but it's easy as an argument.
Change-Id: I53526443f534f29d3bff17c3aec24a9e916c9b86
Reviewed-on: https://skia-review.googlesource.com/60564
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 5e34167d53c06c3c4512592bd1477fcf2df97172 |
|
18-Oct-2017 |
Brian Osman <brianosman@google.com> |
Convert more code to use color space xform FP
Special images, image shaders, and all texture producers,
as well as bicubic (which simplifies factory call sites).
Bug: skia:
Change-Id: I3f7c178060f25db8b659fe66e132f5ea066317b1
Reviewed-on: https://skia-review.googlesource.com/61261
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| f3b4e16c36a6c789fc129aa3bd15c34b44ee8743 |
|
22-Sep-2017 |
Mike Klein <mtklein@chromium.org> |
Fold clamp_{x,y} into the gathers.
All three image tile modes go through exclusive_clamp() and then a
gather today, so we can move the work of exclusive_clamp() into eac
gather_ stage, eliminating the need for clamp_{x,y} stages.
Luckily, we've got a convenient place to bottleneck this, ptr_and_ix(),
which works out the pointer and vector of indices to load for gathers.
This deletes SkRasterPipeline_repeat_tiling unit test, which now
no longer exactly makes sense. It tests that repeat_x does that
clamp, but that's now done automatically outside that stage.
Change-Id: I24637ef60921bec7aa00082984c0c6a49dd86ca9
Reviewed-on: https://skia-review.googlesource.com/50260
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 2bbdcc44c63974f29f3743bb58d929601a3f65c6 |
|
07-Sep-2017 |
Brian Salomon <bsalomon@google.com> |
Rework GrSamplerParams to be more compact and use its own wrap mode enum.
The main change is to make GrSamplerParams smaller by making its enums have byte-sized underlying types. The rest is cosmetic.
Change-Id: Ib71ea50612d24619a85e463826c6b8dfb9b445e3
Reviewed-on: https://skia-review.googlesource.com/43200
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 1d8c42eb903b66035ecf4d45b03dfeb1ad07b957 |
|
29-Aug-2017 |
Mike Reed <reed@google.com> |
fold params into StageRec
pre-CL before trying to add a hint-rect field to allow shaders to "optimize"
their stages for a given restriction in device space
- e.g. if the shader's intrinsic domain is contained, it won't need to tile/clamp
Bug: skia:
Change-Id: Ia2da557691da25f31e4b9e3f53c3bc6709b89083
Reviewed-on: https://skia-review.googlesource.com/40224
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| dc03ddeb7e716ca871f9ca6a3b3ffb0ce6caa548 |
|
23-Aug-2017 |
Mike Reed <reed@google.com> |
remove code associated with legacy affine imageshaders
requires https://skia-review.googlesource.com/c/33180
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD
Bug: skia:
Change-Id: I226e120cc5aebe393bda8bc069e7927fdc981a0e
Reviewed-on: https://skia-review.googlesource.com/36800
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| eefe9f971b77eff93e6551240342b4772e69546f |
|
21-Aug-2017 |
Mike Reed <reed@google.com> |
use rasterpipeline if localmatrix is rotated or skewed for images
Bug: skia:
Change-Id: Ib269b5b9d79b055fe614aaacfd7e0d05d48f6085
Reviewed-on: https://skia-review.googlesource.com/33180
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 766656d2a997372bda7295a9ffce3adf175dd85e |
|
21-Aug-2017 |
Mike Reed <reed@google.com> |
remove unused flag for rotated imageshaders
Bug: skia:
Change-Id: I9066ec33a9742f6937cc61ff0afafd13af809222
Reviewed-on: https://skia-review.googlesource.com/36741
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 6274c42b8241fba14b003c55e6997cfe274a1066 |
|
18-Aug-2017 |
Florin Malita <fmalita@chromium.org> |
Add back raster pipeline image tiling guard
(SK_SUPPORT_LEGACY_TILED_BITMAPS)
We have a couple of M61 regressions related to this change. Adding the
guard back in case we decide to revert.
TBR=
Change-Id: I0703e61d70aa919b71ff9711ec28bcfc67e3e84a
Reviewed-on: https://skia-review.googlesource.com/36120
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| aff329b8e9b239bca1d93b13a914fbef45ccf7fe |
|
11-Aug-2017 |
Brian Salomon <bsalomon@google.com> |
Make GrFragmentProcessor be non-refcounted and use std::unique_ptr.
Change-Id: I985e54a071338e99292a5aa2f42c92bc115b4008
Reviewed-on: https://skia-review.googlesource.com/32760
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 3404207e2418e791231e36d2848e9137d6c73cad |
|
08-Aug-2017 |
Mike Reed <reed@google.com> |
use rasterpipeline for images if matrix is >= scale+translate
Bug: skia:
Change-Id: I36112fe54c6f2d0965d0b88f0291d7ffe0902715
Reviewed-on: https://skia-review.googlesource.com/30480
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| ff46ace077da67957dc74754db960a3e78e7c41b |
|
22-Jul-2017 |
Mike Reed <reed@google.com> |
remove guard for tiling
Bug: skia:
Change-Id: Ie8e4a6d209fc9623a30cac9f66b312c36876ac40
Reviewed-on: https://skia-review.googlesource.com/25940
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| f5d4d86d857fd3619ae5f253cb8cc2552f552542 |
|
22-Jul-2017 |
Mike Klein <mtklein@google.com> |
Revert "use rasterpipeline for filtering for very large images"
This reverts commit 97d4cf0e7eb15340b1f513ff8cfba4e55ee3acf2.
Reason for revert: looks like this is breaking one cc unit test, LayerTreeHostScrollbarsPixelTest.HugeTransformScale, which appears to be a comparison against a golden .png.
Original change's description:
> use rasterpipeline for filtering for very large images
>
> Bug: skia:
> Change-Id: I8d1c2fca1bf2ad94cdfbef32d068f47503ea1e03
> Reviewed-on: https://skia-review.googlesource.com/24140
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com
Change-Id: Idc94873cca90a73fbd567b16ed2c45b961e76e85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/25806
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 97d4cf0e7eb15340b1f513ff8cfba4e55ee3acf2 |
|
21-Jul-2017 |
Mike Reed <reed@google.com> |
use rasterpipeline for filtering for very large images
Bug: skia:
Change-Id: I8d1c2fca1bf2ad94cdfbef32d068f47503ea1e03
Reviewed-on: https://skia-review.googlesource.com/24140
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 0fddb2d7c17a953c0d3986e5f8bcfdeaf2cc401d |
|
20-Jul-2017 |
Mike Klein <mtklein@chromium.org> |
Retry cleaning up SkLinearBitmapPipeline.
This is mostly dead code.
In order to make it truly dead, we need to opt drawing unpremul images
into SkRasterPipelineBlitter. They had been handled by
SkLinearBitmapPipeline, but can't be draw by SkBitmapProcLegacyShader.
Drawing unpremul images is tested by the GM all_variants_8888, which
gave us trouble last time around (serialize-8888 drew right, 8888 wrong)
but now draws fine. I think this was probably also the root of the
revert, drawing some unpremul image in Chrome's tests somewhere.
Change-Id: I453f9df44ade807316935921cbae82961e2f08aa
Reviewed-on: https://skia-review.googlesource.com/24862
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| e32500f0642df381fd79731df2f7a4a4a71a46e2 |
|
19-Jul-2017 |
Mike Reed <reed@google.com> |
Assume HQ is handled by pipeline, delete legacy code-path
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD
Bug: skia:
Change-Id: If6f0d0a57463bf99a66d674e65a62ce3931d0116
Reviewed-on: https://skia-review.googlesource.com/24644
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 968af43f721cd949ba3005f8e5f3c03c6c978a74 |
|
18-Jul-2017 |
Mike Klein <mtklein@chromium.org> |
remove gather_i8, unify memory-touching contexts
gather_i8 is now unused, so we can remove it.
That in turn makes the ctable field of SkJumper_GatherCtx unused.
After removing ctable, SkJumper_GatherCtx and SkJumper_PtrStride look
identical, so I've now fused them into SkJumper_MemoryCtx, which will
eventually be used by everything loading from, gathering from, or
storing to memory.
Change-Id: Ia882d2dbd54c9fcf9a8250a1ce83304389dd284a
Reviewed-on: https://skia-review.googlesource.com/24085
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 086a427b0cee3862f25c492fc5082ff24105dc53 |
|
18-Jul-2017 |
Mike Reed <reed@google.com> |
guard references to SkColorTable
Bug: skia:6828
Change-Id: I0c8c78e70b118f51cb59dc45675e4ddcd4776108
Reviewed-on: https://skia-review.googlesource.com/24260
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 262b319dcdbf6329d5ca3212b22323ebec7a7b49 |
|
17-Jul-2017 |
Mike Reed <reed@google.com> |
Index8 is dead, remove guarded code
Needs google3 to be updated before this can land.
Bug: skia:6828
Change-Id: I2c16be13c6937ffa48768cc24f9f980171c824d6
Reviewed-on: https://skia-review.googlesource.com/23940
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 580501382fb1418fff7acc63680f3a9a6bf3938c |
|
13-Jul-2017 |
Mike Reed <reed@google.com> |
Guard to remove kIndex_8_SkColorType
Bug: skia:6828
Change-Id: Ia942a36abb18213184f8d436555a658270d97d47
Reviewed-on: https://skia-review.googlesource.com/22721
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 5769dd2c9ad9443b8cf2d62748d5747e547c7ad5 |
|
12-Jul-2017 |
Florin Malita <fmalita@chromium.org> |
Add some raster pipeline perspective asserts
I meant to add these when removing the guard, but since we landed without
a guard, might as well do it now.
A couple of things exposed by these asserts:
1) we need to also catch perspective in local matrices
2) we need to disallow burst mode with perspective
Also tweak the predicate to hasPerspective() instead of explicit mask
check.
Change-Id: I099e5125fca52dccffca77c60fc800bbdf539b53
Reviewed-on: https://skia-review.googlesource.com/22483
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 6b59bf424c9d9d8a72d3c002871f143e6aff623e |
|
04-Jul-2017 |
Mike Reed <reed@google.com> |
consolidate logic for matrix stage
Bug: skia:
Change-Id: Id1559b31692a1aed9aa4d15620b2019ae9c7c22b
Reviewed-on: https://skia-review.googlesource.com/21404
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 41dc6cc6213a4e54597325026b4a08aaf27b8780 |
|
29-Jun-2017 |
Mike Reed <reed@google.com> |
remove unreachable samples for non-N32 imageshaders
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD
Bug: skia:
Change-Id: I2d9a22b22d72c81a742b8fd497797bff8174915b
Reviewed-on: https://skia-review.googlesource.com/21264
Commit-Queue: Eric Boren <borenet@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 7f22511c1cb4e823e17446c54aa308a2f2203899 |
|
28-Jun-2017 |
Mike Reed <reed@google.com> |
add guard for handling swizzles via rasterpipeline
Bug: skia:
Change-Id: I26499659c15bf79a840246a2eb6eb064e43b4c32
Reviewed-on: https://skia-review.googlesource.com/21163
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 111f8a9eea6980a70a300e3a8bfd758257310fe2 |
|
27-Jun-2017 |
Mike Klein <mtklein@chromium.org> |
add bgra as 1st class format
This is a start to eliminating swap_rb as a stage.
I've just hit the main hot spots here. Going to look into
the ~dozen other spots to see how they should work next.
Change-Id: I26fb46a042facf7bd6fff3b47c9fcee86d7142fd
Reviewed-on: https://skia-review.googlesource.com/20982
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| cbbb58af7a1c9d00ce3408fd0964ec00438d42b7 |
|
24-Jun-2017 |
Mike Reed <reed@google.com> |
Revert "speculative fix for chrome roll"
This reverts commit 4220a929f881de79420eb3551653848678666c13.
Reason for revert: did not seem to help chrome
Original change's description:
> speculative fix for chrome roll
>
> Bug: skia:
> Change-Id: Ib1d7d0839093a4ced89f591bc329bbd3adc635f8
> Reviewed-on: https://skia-review.googlesource.com/20768
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=reed@google.com
Change-Id: I1906664ebf4aae8bc61bd410a74231bce3f4b562
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/20782
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 4220a929f881de79420eb3551653848678666c13 |
|
24-Jun-2017 |
Mike Reed <reed@google.com> |
speculative fix for chrome roll
Bug: skia:
Change-Id: Ib1d7d0839093a4ced89f591bc329bbd3adc635f8
Reviewed-on: https://skia-review.googlesource.com/20768
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 2e3c955254388927095147e606a1dc2913b80bd1 |
|
24-Jun-2017 |
Mike Reed <reed@google.com> |
disable optimization (for now) for android
Bug: skia:
Change-Id: I5e66d6f0a1aede5239b5a51a8b51283cede2be93
Reviewed-on: https://skia-review.googlesource.com/20781
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 587d082f5044966d9766f43b2632169329986207 |
|
23-Jun-2017 |
Mike Reed <reed@google.com> |
optimize imageshaders to use clamp for dimension==1
Bug: skia:
Change-Id: I12021acb5349bd139dceee8ce46de3cfd1ff4d28
Reviewed-on: https://skia-review.googlesource.com/20698
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| bc4c26b7a2452f482b6f9a39daea39c44932f2c5 |
|
23-Jun-2017 |
Mike Reed <reed@google.com> |
reduce exposure of SK_SUPPORT_LEGACY_TILED_BITMAPS to not replace repeats yet
A large swath of skps slowed down ~5-6x, likely because of repeat_repeat tiling
slowdowns. This CL reduces our exposure to keep those in legacy mode for now.
Bug: skia:
Change-Id: I16d03c01fe8c14a8b9b6a1a9a0c5f31f8d616b4a
Reviewed-on: https://skia-review.googlesource.com/20694
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 51e46d5e1c48072c08637ba8f875ba249eda2376 |
|
23-Jun-2017 |
Mike Reed <reed@google.com> |
use mul_inv instead of div for tiling
Bug: skia:
Change-Id: I5f88e7923fe204faba8dc5d87454805a4d470d52
Reviewed-on: https://skia-review.googlesource.com/20688
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 0cc60b8bbd251efbeb374815395ea3e5fb62e184 |
|
22-Jun-2017 |
Mike Klein <mtklein@chromium.org> |
fix repeat/mirror sampling bleed
I think this has been broken since we tried to simplify this in
https://skia-review.googlesource.com/16547
The HSW backend does still look a little wrong, but improved,
and the others seem fixed. Can you see how this affects your
test cases, layout tests, etc?
BUG=skia:6783
Change-Id: I17957ac8100331bea5b64d674bf43105048b72f6
Reviewed-on: https://skia-review.googlesource.com/20548
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 980e2790ddd2268ec4a6c958b98dda829f737dd9 |
|
21-Jun-2017 |
Mike Reed <reed@google.com> |
Revert[2] "use rasterpipeline for non-8888-clamp shaders (so we can delete more legacy code)""
Now with guard for Chrome and fix for bench
https://codereview.chromium.org/2947233002/
This reverts commit 19d0b99922712df3f07ba4622f1e5ccddc3b7168.
Bug: skia:
Change-Id: I5991955d0d927d34a184cf4d9844b0d565e03b88
Reviewed-on: https://skia-review.googlesource.com/20461
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 19d0b99922712df3f07ba4622f1e5ccddc3b7168 |
|
21-Jun-2017 |
Mike Reed <reed@google.com> |
Revert "use rasterpipeline for non-8888-clamp shaders (so we can delete more legacy code)"
This reverts commit 00b8ab61ddf6723a593bfcc931bbabb957aa7b19.
Reason for revert: breaks nanobench
Original change's description:
> use rasterpipeline for non-8888-clamp shaders (so we can delete more legacy code)
>
> Definitely changes some GMs, but I think they're all more correct.
>
> Bug: skia:
> Change-Id: Ic30622f2c17325bce4c82b4d7997036d3cc026c2
> Reviewed-on: https://skia-review.googlesource.com/20363
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=mtklein@google.com,herb@google.com,fmalita@chromium.org,reed@google.com
Change-Id: I6b7e8d68deb8b62bd9688c95a5937a0bba8b4cf5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/20431
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 00b8ab61ddf6723a593bfcc931bbabb957aa7b19 |
|
21-Jun-2017 |
Mike Reed <reed@google.com> |
use rasterpipeline for non-8888-clamp shaders (so we can delete more legacy code)
Definitely changes some GMs, but I think they're all more correct.
Bug: skia:
Change-Id: Ic30622f2c17325bce4c82b4d7997036d3cc026c2
Reviewed-on: https://skia-review.googlesource.com/20363
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| fbcef6eb8abad142daf45418516550f7635b4a52 |
|
15-Jun-2017 |
Robert Phillips <robertphillips@google.com> |
Clean up GrResourceProvider usage
The only substantive changes are the removal of GrProxy instantiation in:
SkGpuBlurUtils::GaussianBlur
GrSimpleTextureEffect::Make*
Change-Id: I10970609693bd6ff5b3a3c21b41d82642bb277bc
Reviewed-on: https://skia-review.googlesource.com/19965
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| 5df94d508ecfb62d54b757961dba611a00ff563c |
|
01-Jun-2017 |
Mike Klein <mtklein@chromium.org> |
have shaders that need seed_shader call it themselves
This ought to make compose shader and our sprite blitter a bit more
efficient. Compose shader can simply re-seed instead of saving the
xy values off to a buffer. The sprite blitter doesn't need xy at all.
Change-Id: Ib4b3509288810f74a4c8e2978ce2ca14d8644980
Reviewed-on: https://skia-review.googlesource.com/18405
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 9c6645e787669e5af2b9de73d0a6d1cd4d77bbf0 |
|
31-May-2017 |
Mike Klein <mtklein@chromium.org> |
assume sRGB transfer function on untagged images
This has been a long time coming. There are probably one or two more
places we'd want to do this on the CPU side too, but it's a start.
Somewhat seriously, this is my proposed fixed for colorburn +
xfermodes2. We're not interpreting the red or green images sensibly.
BUG=skia:6680
Change-Id: Iea15be08c1907ac1ac46ef358d3d74f1cc35a156
Reviewed-on: https://skia-review.googlesource.com/18221
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| 5edba45dca995baed5e66dfaaa7859132e716314 |
|
30-May-2017 |
Florin Malita <fmalita@chromium.org> |
[Reland] Relocate shaders to own dir
Consolidate all shader impls under src/shaders/.
(reland of https://skia-review.googlesource.com/c/17927/)
Change-Id: I7918bdc1aafe842ed194412ba95b9ae53a2ec1d7
Reviewed-on: https://skia-review.googlesource.com/18146
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/shaders/SkImageShader.cpp
|
| d8872be505c5c9c48072fe62c244e53e9b7334f1 |
|
26-May-2017 |
Stan Iliev <stani@google.com> |
Revert "Relocate shaders to own dir"
This reverts commit fabe0b26d05624ce7374f6ca89bd66df6142534e.
Reason for revert: Last android roll failed with "external/skia/src/effects/SkGaussianEdgeShader.h:11:10: fatal error: 'SkShaderBase.h' file not found"
Original change's description:
> Relocate shaders to own dir
>
> Consolidate all shader impls under src/shaders/.
>
> Change-Id: I450e37541214704c1ad9e379d9d753b7cc62fac3
> Reviewed-on: https://skia-review.googlesource.com/17927
> Commit-Queue: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Herb Derby <herb@google.com>
>
TBR=mtklein@google.com,herb@google.com,fmalita@chromium.org,reed@google.com
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Idbb2b75053969df1dad9d8ce0217cd39189b9ddb
Reviewed-on: https://skia-review.googlesource.com/18020
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|
| fabe0b26d05624ce7374f6ca89bd66df6142534e |
|
25-May-2017 |
Florin Malita <fmalita@chromium.org> |
Relocate shaders to own dir
Consolidate all shader impls under src/shaders/.
Change-Id: I450e37541214704c1ad9e379d9d753b7cc62fac3
Reviewed-on: https://skia-review.googlesource.com/17927
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/shaders/SkImageShader.cpp
|