| 2252636923271daba4678b54ca72cd5bad227c49 |
|
28-Feb-2018 |
Jim Van Verth <jvanverth@google.com> |
Fall back to blurs for unsupported DrawShadow cases
Bug: skia:7263
Change-Id: Ifb70212e369ed783bd03a6ff2a540a8f46282595
Reviewed-on: https://skia-review.googlesource.com/109388
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| a947e29bfda69618723341f3487076c3256cfffc |
|
26-Feb-2018 |
Jim Van Verth <jvanverth@google.com> |
Add some additional checks for shadow generation
Change-Id: I4dae4173ad879827e4e1fa3ad12aa0447d1df252
Reviewed-on: https://skia-review.googlesource.com/110360
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 19d7bd65045e88724ad59a8d7066a9092754c7e4 |
|
19-Feb-2018 |
Mike Reed <reed@google.com> |
hide virtual and rename to onMakeComposed
Bug: skia:
Change-Id: Ic18ee2af3273f81ebec9c9031162e808186c0acd
Reviewed-on: https://skia-review.googlesource.com/108300
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| b1b80f7de4224c5083dfc1475e1988b2ce839a65 |
|
18-Jan-2018 |
Jim Van Verth <jvanverth@google.com> |
Remove tonal color from DrawShadow internals
Bug: b/71719631
Change-Id: I676c34dfe5ea9b5e184ea53dd49a8b835d4e8cb6
Reviewed-on: https://skia-review.googlesource.com/95741
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 57c2b8b16ab958214ecad2c4bd4aad75f7d255c6 |
|
31-Dec-2017 |
Mike Reed <reed@google.com> |
remove unused declarations
Bug: skia:
Change-Id: If8ca5e3d649dab3cf8b2bdb1cf072ff23cea9465
Reviewed-on: https://skia-review.googlesource.com/90026
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 744cbb388870bc1ae0f6b3ac0fbeaa136f55917b |
|
19-Dec-2017 |
Jim Van Verth <jvanverth@google.com> |
Fix alpha contribution to tonal color.
Also adds a tonal color GM, a grayscale mode to shadowutils GM,
and animated alpha to SampleAndroidShadows.
Bug: skia:
Change-Id: I1dcb5cab7e53ffa7a3bf1a07b6ebfed38df1a9ed
Reviewed-on: https://skia-review.googlesource.com/85002
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 53d863c18cd3b53d8b4c4dcb8505f2c52f1e5c59 |
|
20-Nov-2017 |
Jim Van Verth <jvanverth@google.com> |
Enable tonal color for shadows by default.
This change swaps the sense of the tonal color shadow flag, so
tonal color will always be on unless explicitly disabled.
Change-Id: I56ce4228022cf59b570cd7461327628cf7fe7173
Reviewed-on: https://skia-review.googlesource.com/73900
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| aae47c878b83ab6d9742d92a6fa47e762f6b9204 |
|
10-Nov-2017 |
Ethan Nicholas <ethannicholas@google.com> |
sksl enum support
Bug: skia:
Change-Id: I4d505b31cf8b59de12bcdbca410aafc085977ba9
Reviewed-on: https://skia-review.googlesource.com/68621
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 4cbb6e6d551e8bea2c040b1aa9dce253cffb9af0 |
|
25-Oct-2017 |
Brian Salomon <bsalomon@google.com> |
Pass GrRenderTargetContext's GrColorSpaceInfo to SkShader and SkColorFilter.
Also to SkColorTo(Premul|Unpremul)GrColor4f.
This can avoid cache lookups to find GrColorSpaceXforms as the xform pointer is stored in GrColorSpaceInfo after the first lookup.
Also uses GrColorSpaceInfo to construct GrTextUtils::Paint.
Bug: skia:
Change-Id: Idf19d512a60d2269e6921c7fb54d93aee499a70d
Reviewed-on: https://skia-review.googlesource.com/63660
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| a4083c97d48e8a4f88e2797d7363f141e3d42553 |
|
15-Sep-2017 |
Cary Clark <caryclark@skia.org> |
make most of SkColorPriv.h private
created new file src/core/SkColorData.h for
internal consumption. Note that many of the
functions there are unused as well.
Bug: skia: 6898
R: reed@google.com
Change-Id: I25bfd5a9c21f53558c4ca65a77eb5d322d897c6d
Reviewed-on: https://skia-review.googlesource.com/46848
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| b4aab9ae6d27c446af8302b79d15b832c816c633 |
|
16-Aug-2017 |
Ben Wagner <bungeman@google.com> |
Replace SkFAIL with SK_ABORT.
SkFAIL is a legacy macro which is just SK_ABORT. This CL mechanically
changes uses of SkFAIL to SK_ABORT in preparation for its removal. The
related sk_throw macro will be changed independently, due to needing to
actually clean up its users.
Change-Id: Id70b5c111a02d2458dc60c8933f444df27d9cebb
Reviewed-on: https://skia-review.googlesource.com/35284
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| aff329b8e9b239bca1d93b13a914fbef45ccf7fe |
|
11-Aug-2017 |
Brian Salomon <bsalomon@google.com> |
Make GrFragmentProcessor be non-refcounted and use std::unique_ptr.
Change-Id: I985e54a071338e99292a5aa2f42c92bc115b4008
Reviewed-on: https://skia-review.googlesource.com/32760
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 1af03d4396a9567e3ca127830676eb4fd5a76266 |
|
31-Jul-2017 |
Jim Van Verth <jvanverth@google.com> |
Compute correct bounds for DrawShadowRec.
Bug: skia:6880
Change-Id: Ia8b94e52eec3feb5104d2351bf7a7e6f99101deb
Reviewed-on: https://skia-review.googlesource.com/26370
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 0274b30feeacae0bcd12f03ae96cb4721c1393a2 |
|
14-Jul-2017 |
Ethan Nicholas <ethannicholas@google.com> |
converted GrBlurredEdgeFragmentProcessor to sksl
Bug: skia:
Change-Id: I028c85f692b2e54e64be301940708387014ee0c7
Reviewed-on: https://skia-review.googlesource.com/23540
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 7d8955ee4b6e75c684708089bbf737aedf663fd5 |
|
13-Jul-2017 |
Jim Van Verth <jvanverth@google.com> |
Add null check for non-cached shadows.
Change-Id: I8015a026d4bb54f04ee86fca0d4b0be3bc1d9bd8
Reviewed-on: https://skia-review.googlesource.com/23123
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 9c1d7802284bf5a0e6fcf1a43e9218e21ce1a9e0 |
|
29-Jun-2017 |
Mike Reed <reed@google.com> |
remove filterSpan from SkColorFilter
Bug: skia:
Change-Id: Ie8a31ea8131c08d251a825622484342e3e174474
Reviewed-on: https://skia-review.googlesource.com/21207
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 34d6e4b09f81a7fa6a4fe3c667d4663e55af97bc |
|
09-Jun-2017 |
Jim Van Verth <jvanverth@google.com> |
Add tonal color support for shadows.
Bug: skia:
Change-Id: Ib9bd9083da1d8a9fa90ae7c710386e6903541fd5
Reviewed-on: https://skia-review.googlesource.com/18148
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 25f3805efa465bc3f804f192fe1ee64450f01d7c |
|
31-May-2017 |
Mike Reed <reed@google.com> |
slant colorfilter away from filterSpan4f
rename to make it easy to delete any impl that also had onAppendStages...
i.e. rename to make it clear that it is just an impl trick for rasterpipeline.
Bug: skia:
Change-Id: If3c3b2811eff12d399cdf7a77552c01e72c06996
Reviewed-on: https://skia-review.googlesource.com/18234
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 6533159f2c83d0af51f79c3d85461580e2346080 |
|
24-May-2017 |
Mike Reed <reed@google.com> |
add stage for gaussian alpha to rgba for shadows
speeds up GM:shadow_utils 20%
Bug: skia:
Change-Id: If52dd5e2c76ace82d06351af1419e0663a3a634f
Reviewed-on: https://skia-review.googlesource.com/17844
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| eb63eb757e9f39730bc1b7a0a29d29b4d6c599fb |
|
23-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Fix TSAN error for shadow cache
Change-Id: I84b94a19c724e2152d1eac269f425f7f0f2286f5
Reviewed-on: https://skia-review.googlesource.com/17706
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 8793e3889833a3de18254cd8a147e213ec98b7fc |
|
22-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Cache ambient and spot shadows at a canonical position
Change-Id: I1f80931513f7d2268b358fb38c86dd331f32f064
Reviewed-on: https://skia-review.googlesource.com/17394
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 3af1af9e979552cf2e3b22feb1de5aeba810fc4e |
|
18-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Remove ambient and spot mask filters.
Also remove a deprecated interface in SkShadowUtils.
Change-Id: I32e67271be953f11071c512cb39a47ea1e7dcaaf
Reviewed-on: https://skia-review.googlesource.com/17266
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 4204da25aa4c6e0b321314aa32fd9affb4865563 |
|
17-May-2017 |
Mike Reed <reed@google.com> |
move shadows to device virtual
This CL keeps the impl for each device backend in the
utils file for simplicity (shared helpers). Future CLs
may move into their respective impl as they become
more specialized.
Bug: skia:
Change-Id: I97ce6cdcc5106ebf4c84778f943cc32d0b7613c1
Reviewed-on: https://skia-review.googlesource.com/15893
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 4c9b893953a4dddc20edafd7583523c94c01c889 |
|
15-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Allow shadow zParams to be applied to affine transformations
Change-Id: Iedfded98ce82d15945667232fde22d046d5106b3
Reviewed-on: https://skia-review.googlesource.com/16879
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 78c8f30d6167b4bf40937c6a8814cd448e2228a6 |
|
15-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Add filled occluders to shadow_utils GM, take 2
Classifies fully visible opaque shadows differently
than transparent to avoid cache collisions.
Change-Id: Iba5aab2b2cbe08f70205c343e86fe92b0cab7497
Reviewed-on: https://skia-review.googlesource.com/16858
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| a783c3623d3cf8b0d2106f055ae4a21d4f8d23d8 |
|
11-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Classify spot shadows for general shapes
Add some simple checks so we can tell whether a shadow's umbra is
completely covered by the occluder, partially covered, or less than
halfway covered.
Change-Id: I092281c4933bd0380946eb0fdd458ce04b0d713c
Reviewed-on: https://skia-review.googlesource.com/16603
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 37c5a96bbdeac2000c8b31d40f4786b31c39f2dd |
|
10-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Unify ShadowUtils interface
Bug: skia:
Change-Id: I116bec82783d297e91ef061217b5e61f7ff16a76
Reviewed-on: https://skia-review.googlesource.com/16371
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| be25600e9ee1f9a4e1b2e0134265fcf1f6b77397 |
|
08-May-2017 |
Mike Klein <mtklein@chromium.org> |
fix commented-out gaussian
The original was
static inline float eval_gaussian(float x) {
float factor = 1 - x;
return sk_float_exp(-factor * factor * 4) - 0.018f;
}
Change-Id: I0590f9b4b41870a0145a4fb7aff5ce3fa4d4e412
Reviewed-on: https://skia-review.googlesource.com/15781
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| e308a122ef996a64a21a6339e3b50b9edfdf654f |
|
08-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Remove height functor for shadows and replace with plane equation params
Change-Id: I948eceb2c58dc50468993dba54c209f18e440e48
Reviewed-on: https://skia-review.googlesource.com/15873
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 8d1e0ac9989c4caa537930e352bfc2dfe375c69b |
|
05-May-2017 |
Jim Van Verth <jvanverth@google.com> |
More analytic shadow refactoring.
This is mostly to simplify and reduce redundant calculations.
Change-Id: I895bd43fbc9defd812969870c2145f9f19d69a6b
Reviewed-on: https://skia-review.googlesource.com/15462
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| b1485f2a05faad77bb849a911ddc83fddb96514e |
|
05-May-2017 |
Mike Reed <reed@google.com> |
tweak the gaussian quartic
Bug: skia:
Change-Id: I0e50568ddea344443ae80c24aad3eb43736f77bc
Reviewed-on: https://skia-review.googlesource.com/15636
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| e12c69e78db3b6451c42e36524ae9e87f75f24fc |
|
05-May-2017 |
Mike Reed <reed@google.com> |
optimize gaussian with herbs quartic
Bug: skia:
Change-Id: Ia06ad1023129dfcade3f648087b2070eab29b4b2
Reviewed-on: https://skia-review.googlesource.com/15523
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| b9641bd55a8f63757a63d9302755feb55d2e9502 |
|
04-May-2017 |
Mike Reed <reed@google.com> |
force all colorfilters to implement 4f
high-contrast gms differ at most by 1 bit
Bug: skia:
Change-Id: I1308bd105020ea3cd5a30fd3dd322ed134fb5ed5
Reviewed-on: https://skia-review.googlesource.com/15249
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 060d9820364b0cf09c7eb3bda449f24c3dcba2e2 |
|
04-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Combine the ambient and spot alphas into the base color
for geometric shadows.
This matches the analytic shadow approach better, and
is color space invariant.
Also includes cleanup in SampleAndroidShadows.
Bug: skia:6546
Change-Id: I7a7cd060420dae741f967334c8b19542a14f0bcf
Reviewed-on: https://skia-review.googlesource.com/15228
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| ab244f045a0740fa6106ed21a4e5824cd09f84f3 |
|
03-May-2017 |
Florin Malita <fmalita@chromium.org> |
Revert "Revert "Reland: Remove SkLights include from SkCanvas.h""
This reverts commit 9d5f66d9c21eda7d3e2ed47654180c0c4b6e38b1.
Reason for revert: Leon landed Android fixes.
Original change's description:
> Revert "Reland: Remove SkLights include from SkCanvas.h"
>
> This reverts commit fed00319c9bafa41c8df658708030c072b301a41.
>
> Reason for revert: breaking the Android roll.
>
> Original change's description:
> > Reland: Remove SkLights include from SkCanvas.h
> >
> > SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
> > works fine).
> >
> > Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb
> > TBR=reed@google.com
> > Reviewed-on: https://skia-review.googlesource.com/15143
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
> > Reviewed-by: Florin Malita <fmalita@chromium.org>
> >
>
> TBR=fmalita@chromium.org,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Change-Id: I3b0e69f1d04d160f16a5567b09982d35cc9ca84e
> Reviewed-on: https://skia-review.googlesource.com/15195
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Florin Malita <fmalita@chromium.org>
>
TBR=msarett@google.com,reviews@skia.org,fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I0a1c2f9df61f16987ab72dfb4f3a205fbcc37667
Reviewed-on: https://skia-review.googlesource.com/15229
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 9d5f66d9c21eda7d3e2ed47654180c0c4b6e38b1 |
|
03-May-2017 |
Florin Malita <fmalita@chromium.org> |
Revert "Reland: Remove SkLights include from SkCanvas.h"
This reverts commit fed00319c9bafa41c8df658708030c072b301a41.
Reason for revert: breaking the Android roll.
Original change's description:
> Reland: Remove SkLights include from SkCanvas.h
>
> SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
> works fine).
>
> Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb
> TBR=reed@google.com
> Reviewed-on: https://skia-review.googlesource.com/15143
> Commit-Queue: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
>
TBR=fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I3b0e69f1d04d160f16a5567b09982d35cc9ca84e
Reviewed-on: https://skia-review.googlesource.com/15195
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| fed00319c9bafa41c8df658708030c072b301a41 |
|
02-May-2017 |
Florin Malita <fmalita@chromium.org> |
Reland: Remove SkLights include from SkCanvas.h
SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
works fine).
Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb
TBR=reed@google.com
Reviewed-on: https://skia-review.googlesource.com/15143
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 37f16551f45919a1a039f081b5c8ea275e58427d |
|
02-May-2017 |
Mike Reed <reed@google.com> |
speedup exp() in gaussian colorfilter
~20% faster
differs in low 1 from prev impl
Bug: skia:
Change-Id: If7aa7f5523f15a5424ebf5a09313c5e1d43e1a1f
Reviewed-on: https://skia-review.googlesource.com/15105
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 38aad81a542612a86c5765ec2bf9d2c164280e9e |
|
02-May-2017 |
Florin Malita <fmalita@chromium.org> |
Revert "Remove SkLights include from SkCanvas.h"
This reverts commit 9ff301bf918cd85d9f67047f10631b7a74345a90.
Reason for revert: need to update G3, Flutter.
Original change's description:
> Remove SkLights include from SkCanvas.h
>
> SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
> works fine).
>
> Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f
> Reviewed-on: https://skia-review.googlesource.com/14904
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Florin Malita <fmalita@chromium.org>
>
TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I4799ad5b31aaeaf529c8b912bbe09aa8869a5e6c
Reviewed-on: https://skia-review.googlesource.com/15107
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 9ff301bf918cd85d9f67047f10631b7a74345a90 |
|
01-May-2017 |
Florin Malita <fmalita@chromium.org> |
Remove SkLights include from SkCanvas.h
SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
works fine).
Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f
Reviewed-on: https://skia-review.googlesource.com/14904
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| e7e1d9d039b12a86b9a595871a2bd13fe1c28f72 |
|
01-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Fix up shadows in raster.
* Re-enable shadow blurs for raster circles and rrects
* Fix up the tessellation as much as possible to remove skinny triangles
Bug: skia:6425
Change-Id: I6548055084bc8596a052bcd3cec852766e084ba2
Reviewed-on: https://skia-review.googlesource.com/14943
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| b6069dfba7b7ab563a3fccb2f38307e47035300c |
|
28-Apr-2017 |
Jim Van Verth <jvanverth@google.com> |
Fix fast blur for shadow rrects.
* Handles case where blur is greater than
corner radius.
* Speeds up shader by avoiding a divide.
* Tweaks shadow sample to be more MD-ish.
Bug: skia:
Change-Id: I2990357b39784c22f02a8e51872391fd68e8226a
Reviewed-on: https://skia-review.googlesource.com/14141
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 8f7dc9f6caabe798723d9f17aff371121369b846 |
|
20-Apr-2017 |
Jim Van Verth <jvanverth@google.com> |
Circular shadow fixes for Flutter.
* Fix spot shadow placement for SkSpotShadowMaskFilter.
* Make sure we don't try to render an oval as a plain RRect
due to floating point error.
* Use fast path for uncached circles.
* Make sure ShadowMaskFilters can handle near-circles.
Change-Id: Ia9967a00a6e1c980a1c0a7ba8248f09fde61a3b7
Reviewed-on: https://skia-review.googlesource.com/13969
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| b436655ad5c40a04b65c1642d0a0e781ce296c96 |
|
27-Mar-2017 |
Jim Van Verth <jvanverth@google.com> |
Add height function to shadow tessellators.
Prep work for adding perspective support.
Bug: skia:
Change-Id: Id07d3050afb3f0d001b885e482adb8d03125b619
Reviewed-on: https://skia-review.googlesource.com/10167
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| aa9e3326f71c74e6250ae783cc3257d835624dd0 |
|
16-Mar-2017 |
Mike Reed <reed@google.com> |
Revert[4] "store vertices arrays inline with object""""
This reverts commit 0c492cfe1713d6895d1d513e754d938ff0faa5e5.
BUG=skia:
Change-Id: I63bce834fee6dd6f043b3889ac4ec287dd03d2e6
Reviewed-on: https://skia-review.googlesource.com/9809
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 0c492cfe1713d6895d1d513e754d938ff0faa5e5 |
|
16-Mar-2017 |
Mike Reed <reed@google.com> |
Revert[3] "store vertices arrays inline with object"""
This reverts commit 7d9f9e30204ee8a380443b868e4cc281319a2051.
Reason for revert: speculative revert to try to fix google3
Original change's description:
> Revert[2] "store vertices arrays inline with object""
>
> This reverts commit 9e62df6ecd1000860ad19ab9425579dfb7002ba0.
>
> Reason for revert: behavior in reader32 fixed
>
> Fix is here: https://skia-review.googlesource.com/c/9729/
>
> Original change's description:
> > Revert "store vertices arrays inline with object"
> >
> > This reverts commit eaaebb19a17d213355e7a70e0cfabe4ba61929d4.
> >
> > Reason for revert: may call SkReader32::read(null, 0) -- reader needs to handle this
> >
> > Original change's description:
> > > store vertices arrays inline with object
> > >
> > > Also unify some of naming (esp. around texCoords)
> > >
> > > BUG=skia:6366
> > >
> > > Change-Id: I5a6793f029cccf0cd0a2c1d180b259ce4eab526f
> > > Reviewed-on: https://skia-review.googlesource.com/9705
> > > Commit-Queue: Mike Reed <reed@google.com>
> > > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > >
> >
> > TBR=bsalomon@google.com,reed@google.com,reviews@skia.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:6366
> >
> > Change-Id: Ie421654bcd74d74f8be6676291e3d6e16e2a7a16
> > Reviewed-on: https://skia-review.googlesource.com/9727
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Mike Reed <reed@google.com>
> >
>
> TBR=bsalomon@google.com,reviews@skia.org,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:6366
>
> Change-Id: I1f12108fff8f551d66455cfadd6d5dd9412e9aa8
> Reviewed-on: https://skia-review.googlesource.com/9760
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>
TBR=bsalomon@google.com,reviews@skia.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:6366
Change-Id: Ie23130a07fbecd5664e37291bc167008a6b496bc
Reviewed-on: https://skia-review.googlesource.com/9806
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 7d9f9e30204ee8a380443b868e4cc281319a2051 |
|
15-Mar-2017 |
Mike Reed <reed@google.com> |
Revert[2] "store vertices arrays inline with object""
This reverts commit 9e62df6ecd1000860ad19ab9425579dfb7002ba0.
Reason for revert: behavior in reader32 fixed
Fix is here: https://skia-review.googlesource.com/c/9729/
Original change's description:
> Revert "store vertices arrays inline with object"
>
> This reverts commit eaaebb19a17d213355e7a70e0cfabe4ba61929d4.
>
> Reason for revert: may call SkReader32::read(null, 0) -- reader needs to handle this
>
> Original change's description:
> > store vertices arrays inline with object
> >
> > Also unify some of naming (esp. around texCoords)
> >
> > BUG=skia:6366
> >
> > Change-Id: I5a6793f029cccf0cd0a2c1d180b259ce4eab526f
> > Reviewed-on: https://skia-review.googlesource.com/9705
> > Commit-Queue: Mike Reed <reed@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> >
>
> TBR=bsalomon@google.com,reed@google.com,reviews@skia.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:6366
>
> Change-Id: Ie421654bcd74d74f8be6676291e3d6e16e2a7a16
> Reviewed-on: https://skia-review.googlesource.com/9727
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>
TBR=bsalomon@google.com,reviews@skia.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:6366
Change-Id: I1f12108fff8f551d66455cfadd6d5dd9412e9aa8
Reviewed-on: https://skia-review.googlesource.com/9760
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 9e62df6ecd1000860ad19ab9425579dfb7002ba0 |
|
15-Mar-2017 |
Mike Reed <reed@google.com> |
Revert "store vertices arrays inline with object"
This reverts commit eaaebb19a17d213355e7a70e0cfabe4ba61929d4.
Reason for revert: may call SkReader32::read(null, 0) -- reader needs to handle this
Original change's description:
> store vertices arrays inline with object
>
> Also unify some of naming (esp. around texCoords)
>
> BUG=skia:6366
>
> Change-Id: I5a6793f029cccf0cd0a2c1d180b259ce4eab526f
> Reviewed-on: https://skia-review.googlesource.com/9705
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
>
TBR=bsalomon@google.com,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:6366
Change-Id: Ie421654bcd74d74f8be6676291e3d6e16e2a7a16
Reviewed-on: https://skia-review.googlesource.com/9727
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| eaaebb19a17d213355e7a70e0cfabe4ba61929d4 |
|
15-Mar-2017 |
Mike Reed <reed@google.com> |
store vertices arrays inline with object
Also unify some of naming (esp. around texCoords)
BUG=skia:6366
Change-Id: I5a6793f029cccf0cd0a2c1d180b259ce4eab526f
Reviewed-on: https://skia-review.googlesource.com/9705
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 4d1955c43aaab045511b74a495dfbea4ef0057c5 |
|
10-Mar-2017 |
Ben Wagner <bungeman@google.com> |
Fix SkFILEStream.
Change-Id: I8c66e4e3e857227aed3d0bc497982f4c0d96d917
Reviewed-on: https://skia-review.googlesource.com/9498
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| cf40e307cd7c78c3ac8812229a7f4f2796b8688e |
|
02-Mar-2017 |
Jim Van Verth <jvanverth@google.com> |
Use fast path for circular shadows.
Also cleans up some of the MaskFilter code to make it
more correct.
BUG=skia:6119
Change-Id: I93016bcdd9c55fcb2d1dc8776428a72eb563d67a
Reviewed-on: https://skia-review.googlesource.com/9116
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 804e091df9879ad0f83a9b2f2216ed8ea8951489 |
|
23-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Make shadow_utils GM use its own SkResourceCache
This should stabilize the replay testing on the bots.
Change-Id: I89e3e308000743da6e1a765751103cffabc7e4ba
Reviewed-on: https://skia-review.googlesource.com/8902
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| bc9956de31da06529b540918832f2435f884ac26 |
|
22-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Attempt to stabilize shadow_utils GM for replay configs
Change-Id: I0ed15ab102fa1e0a364d5f3a953bedd8afbda3c3
Reviewed-on: https://skia-review.googlesource.com/8853
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 3c5cfb0d156d09d0da76d9d0a036b08f4ba8a537 |
|
08-Feb-2017 |
Ben Wagner <benjaminwagner@google.com> |
Remove exec bit from source files.
Ran:
find src include \( -name '*.cpp' -o -name '*.h' \) -executable -exec chmod -x {} \;
BUG=skia:
Change-Id: I04a4adbfcea9fd9860ab83d43734dc5158d3a884
Reviewed-on: https://skia-review.googlesource.com/8220
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| aff27a23ad4b38851429066dbfb43cfa7199e37c |
|
06-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Use SkVertices for tessellated spot and ambient shadow rendering.
Change-Id: Ia81e7a771d345286533752708e4304c1ae3b97c9
Reviewed-on: https://skia-review.googlesource.com/8042
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 67386d44c77a1bef1cd9a896d779bd92ea03a558 |
|
06-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
ShadowUtils: Fix umbra inset calculation when determining if umbra is fully occluded.
Change-Id: Id0db49ad45b341d39abf7ee532ecc0799a832192
Reviewed-on: https://skia-review.googlesource.com/8079
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| a84898dbb8d8f7cb8c3e9bdfb4c31d85dff1922f |
|
06-Feb-2017 |
Jim Van Verth <jvanverth@google.com> |
Have ShadowTessellators transform path; add SkShadowTessellator base class
BUG=skia:6119
Change-Id: I37639ebab43c9f32f48d2d7dbb8d4619efb9b09e
Reviewed-on: https://skia-review.googlesource.com/8061
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| d1ac9823fd351ccb54f463273e5c34b6d719ea46 |
|
03-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Improved SkShadowUtils caching
Multiple ambient and spot shadows can be cached for each geometry.
Spot shadows can be reused when x,y light offset is different.
We categorize spot shadows for rrects as either transparent, opaque with partial umbra occlusion, or opaque with full umbra occlusion and use that to improve cache performance.
Change-Id: Id530bdaa5092edb46c8f584979090fbb766307fc
Reviewed-on: https://skia-review.googlesource.com/7987
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 0dda9cb881900241c1c2193ddf3bede72cda898b |
|
03-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Make shadow tessellators fail gracefully and add unit test for this.
Change-Id: I42a9d06a18928588347a6dea2f6150518ba29aa8
Reviewed-on: https://skia-review.googlesource.com/7886
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 0bd699e497819344083df4715928a54a597cd630 |
|
01-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Add a GM for SkShadowUtils and fix a few issues.
1) Transform the path center to device space before computing the shadow offset.
2) Modulate the shadow color by the color filter's output color.
3) Make the scale of path points in the spot tessellator be relative to the path centroid.
4) Clamp the shadow alphas at 1.
Change-Id: I480476df79b959f11c1eca0ba2a49a134d355cbb
Reviewed-on: https://skia-review.googlesource.com/7860
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 5e6895295a88fb702f49309542149d73f709bb10 |
|
01-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Add caching of ambient and spot shadow meshes.
Change-Id: If882186225621af4af4b4ddae0c786ec33ff40f3
Reviewed-on: https://skia-review.googlesource.com/7643
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 958fbc460a1e680c6a9979e140da8bfc00b8831d |
|
30-Jan-2017 |
Brian Salomon <bsalomon@google.com> |
Make SkShadowUtils tessellations ref counted in preparation for caching them.
Change-Id: I60133fcc4101a27bcc3e7ad38e7348ad9147b8a9
Reviewed-on: https://skia-review.googlesource.com/7784
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| efe3dedbb3493b738abdb56041b093245e4e8711 |
|
30-Jan-2017 |
Jim Van Verth <jvanverth@google.com> |
Change shadow tessellators to use SkColor and move to util.
BUG=skia:6119
Change-Id: I4c4a8933c663ccc057596318a06c538175b9f16b
Reviewed-on: https://skia-review.googlesource.com/7726
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 2103cf0ff09763aeaa35508734f765aec9b75665 |
|
16-Jan-2017 |
Jim Van Verth <jvanverth@google.com> |
Split ShadowMaskFilter into separate ambient and spot mask filters
This does not change the public API.
BUG=skia:6119
Change-Id: Ibdcd2f8611bc2eec332d8a65e5d51246b89a0a90
Reviewed-on: https://skia-review.googlesource.com/7083
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|
| 43475ad9dc43c4cbe13d924d8caff8916dcbbc06 |
|
13-Jan-2017 |
Jim Van Verth <jvanverth@google.com> |
Move Android shadow rendering interface to util library.
BUG=skia:6119
Change-Id: I8318cf2758042ffd0c81c5fa74240acbf7bea61f
Reviewed-on: https://skia-review.googlesource.com/6999
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/utils/SkShadowUtils.cpp
|