e083f7c9f2ed6640866e2d974aabb98e6f3d0712 |
|
07-Feb-2018 |
Mike Klein <mtklein@chromium.org> |
Reland "remove SkCanvas::kIsOpaque_SaveLayerFlag" This reverts the revert 9ff8c8c073ba553dc8b22bb9aacc23949292f72f. Original: This is a performance-only hint that no one but fuzzers is using. It's even explicitly filtered out in Android. The fuzzers have noticed they can trick us into allocating uninitialized memory and treating it as opaque, blending uninitialized pixels, etc. Since no one's using this, we can just kill the bit. Bug: skia:7566, chromium:808830 Docs-Preview: https://skia.org/?cl=105282 Change-Id: I4326c663f777aa373ff7ec9f319519da9729350d Reviewed-on: https://skia-review.googlesource.com/105282 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/tools/debugger/SkObjectParser.cpp
|
9ff8c8c073ba553dc8b22bb9aacc23949292f72f |
|
07-Feb-2018 |
Mike Klein <mtklein@google.com> |
Revert "remove SkCanvas::kIsOpaque_SaveLayerFlag" This reverts commit 9a7a2ee5ad8453a985d7d76c1e0ebb50d17fec63. Reason for revert: still need to update blink_headless in Google3 Original change's description: > remove SkCanvas::kIsOpaque_SaveLayerFlag > > This is a performance-only hint that no one but fuzzers > is using. It's even explicitly filtered out in Android. > > The fuzzers have noticed they can trick us into allocating > uninitialized memory and treating it as opaque, blending > uninitialized pixels, etc. > > Since no one's using this, we can just kill the bit. > > Bug: skia:7566, chromium:808830 > > Change-Id: Id74a85e51bc4d0907b4127eb9ac5b02576f8f0a7 > Reviewed-on: https://skia-review.googlesource.com/104441 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,fmalita@chromium.org,reed@google.com Change-Id: I10d3c7e5184b9322715a5bfb6a7106292c8876a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7566, chromium:808830 Reviewed-on: https://skia-review.googlesource.com/104781 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
9a7a2ee5ad8453a985d7d76c1e0ebb50d17fec63 |
|
06-Feb-2018 |
Mike Klein <mtklein@chromium.org> |
remove SkCanvas::kIsOpaque_SaveLayerFlag This is a performance-only hint that no one but fuzzers is using. It's even explicitly filtered out in Android. The fuzzers have noticed they can trick us into allocating uninitialized memory and treating it as opaque, blending uninitialized pixels, etc. Since no one's using this, we can just kill the bit. Bug: skia:7566, chromium:808830 Change-Id: Id74a85e51bc4d0907b4127eb9ac5b02576f8f0a7 Reviewed-on: https://skia-review.googlesource.com/104441 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/tools/debugger/SkObjectParser.cpp
|
e41e1769e76dcce573038d04d90d62043ece7e4f |
|
25-Jan-2018 |
Brian Salomon <bsalomon@google.com> |
Add kRGBX_8888, kRGBA_1010102, and kRGBX_1010102 color types. Unused for now. BUG= skia:7533 Change-Id: I4b3f6b827fd833ba2d07895884d2abc9a3132366 Reviewed-on: https://skia-review.googlesource.com/99781 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
262b319dcdbf6329d5ca3212b22323ebec7a7b49 |
|
17-Jul-2017 |
Mike Reed <reed@google.com> |
Index8 is dead, remove guarded code Needs google3 to be updated before this can land. Bug: skia:6828 Change-Id: I2c16be13c6937ffa48768cc24f9f980171c824d6 Reviewed-on: https://skia-review.googlesource.com/23940 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
580501382fb1418fff7acc63680f3a9a6bf3938c |
|
13-Jul-2017 |
Mike Reed <reed@google.com> |
Guard to remove kIndex_8_SkColorType Bug: skia:6828 Change-Id: Ia942a36abb18213184f8d436555a658270d97d47 Reviewed-on: https://skia-review.googlesource.com/22721 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
ac42aebb7b49ef3d916da1e5a75b4c7cd4cfb119 |
|
12-Jan-2017 |
Stan Iliev <stani@google.com> |
Add support for drawImageLattice in SKIA debugger Add support in SKIA debugger for SkCanvas.drawImageLattice calls. Test: Tested with an SKP from android settings app. Change-Id: I3f39f353dca8a3a2854241e7ef995d4d8c635f3e Reviewed-on: https://skia-review.googlesource.com/6882 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
ebfce6d9b42198e04288a15953f40c395a7b6139 |
|
12-Dec-2016 |
Mike Reed <reed@google.com> |
change SkClipOp to a class enum BUG=skia: Change-Id: I25dbe6d6b8666a2a0a7be7bdd2ae0b067868d14e Reviewed-on: https://skia-review.googlesource.com/5718 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
c1f7774e8d327e3c98b4094c9c01d26e27013f71 |
|
09-Dec-2016 |
Mike Reed <reed@google.com> |
Revert[2] "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS" This reverts commit a129dfef2aaab0b5995cdf1ab7b2cdd41c29cf72. BUG=skia: Change-Id: I717de6e5fcd4516aa684b014b1414b0f82ac2b91 Reviewed-on: https://skia-review.googlesource.com/5722 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
a129dfef2aaab0b5995cdf1ab7b2cdd41c29cf72 |
|
09-Dec-2016 |
Mike Reed <reed@google.com> |
Revert "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS" This reverts commit 8e7432b7f98dd592e529a0c8bb038d73ebfb0478. Reason for revert: <INSERT REASONING HERE> external/skia/bench/../tools/android/SkAndroidSDKCanvas.h:103:36: error: C++ requires a type specifier for all declarations void onClipRect(const SkRect&, ClipOp, ClipEdgeStyle) override; Original change's description: > remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS > > > switch over to SkClipOps now that SK_SUPPORT_LEGACY_CLIP_REGIONOPS is gone > > BUG=skia: > > Change-Id: Ifdc8b3746d508348a40cc009a4e529a1cb3c405d > Reviewed-on: https://skia-review.googlesource.com/5714 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org BUG=skia: NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: If26ea91d7464615e43c1d3d2f726e337ff56b55c Reviewed-on: https://skia-review.googlesource.com/5721 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
8e7432b7f98dd592e529a0c8bb038d73ebfb0478 |
|
08-Dec-2016 |
Mike Reed <reed@google.com> |
remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS switch over to SkClipOps now that SK_SUPPORT_LEGACY_CLIP_REGIONOPS is gone BUG=skia: Change-Id: Ifdc8b3746d508348a40cc009a4e529a1cb3c405d Reviewed-on: https://skia-review.googlesource.com/5714 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkObjectParser.cpp
|
73603f3c52ffd89fe9d035be827b566a0e7d3b79 |
|
20-Sep-2016 |
reed <reed@google.com> |
abstract name of clipping ops, to transtion to a more restricted set SkRegion::Op --> SkCanvas::ClipOp (alias) --> SkClipOp pre-CL needed in chrome : https://codereview.chromium.org/2355583002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355483002 Review-Url: https://codereview.chromium.org/2355483002
/external/skia/tools/debugger/SkObjectParser.cpp
|
9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 |
|
29-Mar-2016 |
halcanary <halcanary@google.com> |
Style bikeshed - remove extraneous whitespace GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002 Review URL: https://codereview.chromium.org/1842753002
/external/skia/tools/debugger/SkObjectParser.cpp
|
50a8dd0a00538840e55233146cb202e256cc6c34 |
|
10-Feb-2016 |
ethannicholas <ethannicholas@google.com> |
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. SkJSONCanvas and SkJSONRenderer will be deleted once the debug server has been updated. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002 Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4 Review URL: https://codereview.chromium.org/1681643002
/external/skia/tools/debugger/SkObjectParser.cpp
|
d116561ddcca3f961b30cd9e485d81b654bc10ec |
|
10-Feb-2016 |
caryclark <caryclark@google.com> |
Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #3 id:40001 of https://codereview.chromium.org/1681643002/ ) Reason for revert: breaks various android builds, e.g. https://android-build.storage.googleapis.com/builds/git_master-skia-linux-bullhead-userdebug/2596406/acb02999d48ace628601452700d4b4f8dcd5ed71b426e6ecdb1c7f5bc5452f7b/logs/build_error.log?Signature=BkLEdMOdi0LelP0v939QECdTZzznSD2dLFIkPu52E7%2BPr5Oj1ktq5nNlxGZn%2F4ZhCKXAw2%2FNHxy27nNJ8lffcgXn7PhQpa82bP%2B8F%2Bbyo9j%2BT%2B3etmOdQFEejJSRsEv2RrVWtKsKYRX%2FuZinrF9yD37jUpSbKNZvmvIbKa4V4IQ%3D&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Expires=1455108483 external/skia/bench/../tools/debugger/SkDrawCommand.cpp:602:9: error: use of undeclared identifier 'free' free(data); Original issue's description: > Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. > SkJSONCanvas and SkJSONRenderer will be deleted once the debug server > has been updated. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002 > > Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e > > Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4 TBR=jcgregorio@google.com,joshualitt@chromium.org,ethannicholas@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1683093002
/external/skia/tools/debugger/SkObjectParser.cpp
|
46cb6d6b82b0ab71033aef91419e8beae25bb8a4 |
|
09-Feb-2016 |
ethannicholas <ethannicholas@google.com> |
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. SkJSONCanvas and SkJSONRenderer will be deleted once the debug server has been updated. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002 Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e Review URL: https://codereview.chromium.org/1681643002
/external/skia/tools/debugger/SkObjectParser.cpp
|
3cb954245cecf262d740a83913681b9fe4b41555 |
|
09-Feb-2016 |
ethannicholas <ethannicholas@google.com> |
moved debugger support files from src/utils/debugger to tools/debugger GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678893003 Review URL: https://codereview.chromium.org/1678893003
/external/skia/tools/debugger/SkObjectParser.cpp
|