| 0a7aa14bf36cbb444b84902a37591d7a9c84fbd0 |
|
21-Feb-2018 |
Greg Daniel <egdaniel@google.com> |
Add checks for failed SkImageInfo2GrPixelConfig calls
Bug: skia:7645
Change-Id: I32b9326fb43490ef6a7a99527243b68d89184ae1
Reviewed-on: https://skia-review.googlesource.com/109083
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| bdecacfbe47bc7211336bb847bb33c00ef85ea3e |
|
03-Feb-2018 |
Brian Salomon <bsalomon@google.com> |
Revert "Revert "Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend.""""""
This reverts commit 3a2cc2c2ec124de36d2544b2a523ef1dd317ca32.
Fix code with samplecnt=0 that slipped in between trybots/CQ and landing of previous version
Change-Id: Iab19f2e8d1e9901601c8c76244d7a88c5d707fab
Reviewed-on: https://skia-review.googlesource.com/103181
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 3a2cc2c2ec124de36d2544b2a523ef1dd317ca32 |
|
03-Feb-2018 |
Brian Salomon <bsalomon@google.com> |
Revert "Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend."""""
This reverts commit 5bb82cbecd740d21b92e8d2944280ab6eb6af7a6.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend.""""
>
> This reverts commit 18c52a7b52211de5d0dcd86dc048adef758c6c75.
>
> Also relands "More sample count cleanup:" and "Add new GrContext queries for imagability, surfacability, and max sample count of color types"
>
>
> Bug: skia:
> Change-Id: I4028105a3a1f16ce3944e134619eb6245af6b947
> Reviewed-on: https://skia-review.googlesource.com/102940
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
TBR=egdaniel@google.com,bsalomon@google.com
Change-Id: Idee23be2f1719f0bdc9305043e95a2d589bee8d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/103220
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 5bb82cbecd740d21b92e8d2944280ab6eb6af7a6 |
|
02-Feb-2018 |
Brian Salomon <bsalomon@google.com> |
Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend.""""
This reverts commit 18c52a7b52211de5d0dcd86dc048adef758c6c75.
Also relands "More sample count cleanup:" and "Add new GrContext queries for imagability, surfacability, and max sample count of color types"
Bug: skia:
Change-Id: I4028105a3a1f16ce3944e134619eb6245af6b947
Reviewed-on: https://skia-review.googlesource.com/102940
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 18c52a7b52211de5d0dcd86dc048adef758c6c75 |
|
02-Feb-2018 |
Brian Salomon <bsalomon@google.com> |
Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend."""
This reverts commit d0d7270fcc32546005b8e847df516cb11592cd30.
Revert "More sample count cleanup:"
This reverts commit d653cac70ed17983125ceed053138c09f1401846.
Revert "Add new GrContext queries for imagability, surfacability, and max sample count of color types"
This reverts commit 85ae7159c9c8a9186a4c7e74304eabb35bca9a79.
Need to understand NVPR perf changes before relanding
Change-Id: I0db075fb42438ef2a1f9885df184dce52892ac4b
Reviewed-on: https://skia-review.googlesource.com/102780
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| d653cac70ed17983125ceed053138c09f1401846 |
|
01-Feb-2018 |
Brian Salomon <bsalomon@google.com> |
More sample count cleanup:
rename getSampleCount -> getRenderTargetSampleCount because it will return
0 when a config is not renderable but *is* supported as a texture format.
(Old name kept around until Chrome stops calling it)
Add virtual GrCaps::maxRenderTargetSampleCount(GrPixelConfig).
Devirtualize isConfigRenderable() and implement as maxRTSC != 0. Separate implementation for version with bool withMSAA param to be removed after Flutter is updated to no longer call.
Consolidate various file static GrSurfaceDesc validators fns into GrCaps::validateSurfaceDesc().
Bug: skia:
Change-Id: Ie30a291aa027e910df3bd90fac8518ccdb39e53f
Reviewed-on: https://skia-review.googlesource.com/102141
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 040238bded7b932b916c84912cbaec1207aa29c0 |
|
18-Dec-2017 |
Chris Dalton <csmartdalton@google.com> |
Add a tools flag to suppress geometry shaders
Bug: skia:
Change-Id: I38736c5d49e3b281c2d23af3908575274ff97b5c
Reviewed-on: https://skia-review.googlesource.com/86282
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 7a0ebfc033463907e2088401972d14ea8589cdb5 |
|
13-Oct-2017 |
Chris Dalton <csmartdalton@google.com> |
Add a tooling flag for path mask caching
Adds the flag and a disables caching on the CCPR bots.
Bug: skia:
Change-Id: Icb85e77f89634dda1d419dacac5b8a93340723f0
Reviewed-on: https://skia-review.googlesource.com/59740
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 81e7bf8d6d338d944f3c5075b14c21580398aeb6 |
|
19-Jul-2017 |
Greg Daniel <egdaniel@google.com> |
Update gpu caps for valid sample counts.
Instead of query and maxSampleCount and using that to cap, we now have
each config store its supported values and when requested returns either
the next highest or equal supported value, or if non the max config supported.
Bug: skia:
Change-Id: I8802d44c13b3b1703ee54a7e69b82102d4b8dc2d
Reviewed-on: https://skia-review.googlesource.com/24302
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| ce5ee602ed19b8493bf4dd1654d29486088bad63 |
|
17-Jul-2017 |
Brian Salomon <bsalomon@google.com> |
Add support for GL 565 and 4444 configs to test tools
Change-Id: I395e3387df44cf5370fef6ab73db73228225622f
Reviewed-on: https://skia-review.googlesource.com/23946
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 12e946b4bfdf598bffb276776ea6e25439e25265 |
|
17-Apr-2017 |
Mike Reed <reed@google.com> |
deprecate odd variants of SkCanvas::readPixels
Bug: skia:6513
Change-Id: I51179a85f0912d3f899c368c30a943d346dd1d05
Reviewed-on: https://skia-review.googlesource.com/13589
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 008b9d80ab9adbf2656eceaf54d11cd15e4dda05 |
|
22-Feb-2017 |
csmartdalton <csmartdalton@google.com> |
Add the ability to enable/disable GPU path renderers
Adds a bitfield to GrContextOptions that masks out path renderers.
Adds commandline flags support to set this bitfield in tools apps.
Removes GrGLInterfaceRemoveNVPR since we can now accomplish the same
thing in the context options.
BUG=skia:
Change-Id: Icf2a4df36374b3ba2f69ebf0db56e8aedd6cf65f
Reviewed-on: https://skia-review.googlesource.com/8786
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| e812d496aaa5e5e9f2117de8f442c297c9cb1367 |
|
21-Feb-2017 |
csmartdalton <csmartdalton@google.com> |
Rename GrContextFactory::ContextOptions to ContextOverrides
Also changes the behavior of these flags to only override their
corresponding context options when set, and to leave them unchanged
when not set.
BUG=skia:
Change-Id: I09f6be09997594fa888d9045dd4901354ef3f880
Reviewed-on: https://skia-review.googlesource.com/8780
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| bf111d7bc9ba3857433e30eae27f0272c34ed0fb |
|
08-Nov-2016 |
Ben Wagner <bungeman@google.com> |
Move SkOSPath out of include/core.
It is moved to src/utils. It is almost a tool, but has two uses in
src/ports.
The existing SkOSFile.cpp is left empty for the time being since it is
mentioned in Chromium's BUILD.gn for Skia.
Change-Id: I3bb7f7c4214359eb6ab906bfe76737d20bf1d6c7
Reviewed-on: https://skia-review.googlesource.com/4536
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/tools/skpbench/skpbench.cpp
|
| 5772eaa91d6a10d74959d7732513c5ab9c057e03 |
|
12-Oct-2016 |
csmartdalton <csmartdalton@google.com> |
skpbench: add warmup run
Does actual work while waiting for hardware settings to kick in,
rather than just sleeping.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410373002
Review-Url: https://codereview.chromium.org/2410373002
/external/skia/tools/skpbench/skpbench.cpp
|
| c6618dd1dadeac8b47b81fbee108c42cca8ab166 |
|
05-Oct-2016 |
csmartdalton <csmartdalton@google.com> |
skpbench: add option for gpu timing
Adds a gpu timing option with a GL implementation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003
Committed: https://skia.googlesource.com/skia/+/c06720d06faab3b01eba1b8693e0ac791f06dc96
Review-Url: https://codereview.chromium.org/2388433003
/external/skia/tools/skpbench/skpbench.cpp
|
| 56df2de7fb48e879446938f47464c7a2c8223616 |
|
04-Oct-2016 |
mtklein <mtklein@chromium.org> |
Revert of skpbench: add option for gpu timing (patchset #7 id:120001 of https://codereview.chromium.org/2388433003/ )
Reason for revert:
many bots failing
Original issue's description:
> skpbench: add option for gpu timing
>
> Adds a gpu timing option with a GL implementation.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003
>
> Committed: https://skia.googlesource.com/skia/+/c06720d06faab3b01eba1b8693e0ac791f06dc96
TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2390383002
/external/skia/tools/skpbench/skpbench.cpp
|
| c06720d06faab3b01eba1b8693e0ac791f06dc96 |
|
04-Oct-2016 |
csmartdalton <csmartdalton@google.com> |
skpbench: add option for gpu timing
Adds a gpu timing option with a GL implementation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003
Review-Url: https://codereview.chromium.org/2388433003
/external/skia/tools/skpbench/skpbench.cpp
|
| 421a3c1cc1b227084c7c84618d0b6a6804faabef |
|
04-Oct-2016 |
csmartdalton <csmartdalton@google.com> |
Move GPU fences into sk_gpu_test
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2383383002
Review-Url: https://codereview.chromium.org/2383383002
/external/skia/tools/skpbench/skpbench.cpp
|
| 6904b19f18006a4130f8a3a19169b2a5e01fe208 |
|
29-Sep-2016 |
csmartdalton <csmartdalton@google.com> |
skpbench: use accumulative result as the default
Uses accum instead of median for the first column in skpbench.cpp, and
the default result for parseskpbench.py. The accum is empirically
proving to be more repeatable than the median.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378383002
Review-Url: https://codereview.chromium.org/2378383002
/external/skia/tools/skpbench/skpbench.cpp
|
| e038489a743d6c0ab1cb208862c305180815bc8e |
|
28-Sep-2016 |
csmartdalton <csmartdalton@google.com> |
skpbench: use double buffering instead of triple
We have no need for our command stream to get more than a couple of
frames deep. Any more and we only increase our chances of sporadic
flushing and unreliable timings.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376043002
Review-Url: https://codereview.chromium.org/2376043002
/external/skia/tools/skpbench/skpbench.cpp
|
| 037adf34f5f00e5806b09b202c96cac5c0a5da0a |
|
28-Sep-2016 |
csmartdalton <csmartdalton@google.com> |
skpbench: run for a fixed duration
Runs for a fixed amount of time instead of a fixed amount of samples.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2374093002
Review-Url: https://codereview.chromium.org/2374093002
/external/skia/tools/skpbench/skpbench.cpp
|
| d7a9db644496785100c4e61add1c9f8ed0494408 |
|
22-Sep-2016 |
csmartdalton <csmartdalton@google.com> |
Add hardware monitoring to skpbench
Adds a Hardware class with hooks for entering and exiting
"benchmarking" mode (e.g. locking clocks, etc.) as well as periodic
polling of hardware to verify the environment is stable.
Adds a partial implementation for generic Android hardware, but
ultimately we will need to write specific classes tailored to each
unique platform we need to test.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360473002
Review-Url: https://codereview.chromium.org/2360473002
/external/skia/tools/skpbench/skpbench.cpp
|
| 4b5179b74c49498e5b2b7d94319476672170b61d |
|
19-Sep-2016 |
csmartdalton <csmartdalton@google.com> |
skpbench
skpbench is a benchmarking suite for skps that aims to generate 100%
repeatable results. The initial commit consists of three parts:
skpbench
A minimalist program whose sole purpose is to open an skp file,
benchmark it on a single config, and exit. No tiling, looping, or
other fanciness is used; it just draws the skp whole into a size-
matched render target and syncs the GPU after each draw.
Limiting the entire process to a single config/skp pair helps to keep
the results repeatable.
skpbench.py
A wrapper to execute the skpbench binary with various configs and skps.
It also monitors the output in order to filter out and re-run results
with an unacceptable stddev.
In the future this script will lock down and monitor clocks and
temperatures.
parseskpbench.py
A utility for parsing skpbench output into a spreadsheet.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341823002
Review-Url: https://codereview.chromium.org/2341823002
/external/skia/tools/skpbench/skpbench.cpp
|