History log of /external/tensorflow/tensorflow/compiler/xla/service/tuple_simplifier.cc
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
7ec44b7541faabe781bb9b6113534452cda7598c 29-Sep-2017 Justin Lebar <jlebar@google.com> [XLA] Make HloModule::computations() return raw pointers.

Like HloComputation::instructions(), HloModule::computations() used to
return a list of unique_ptrs. But this is an implementation detail that
shouldn't be leaked into the public API.

This patch also adds HloModule::MakeNonFusionComputations(), because
many of the callers of computations() went on to filter out all the
fusion computations.

It would be possible to implement MakeNonFusionComputations() "in place"
using a filtering iterator, but I don't think it's necessary -- we never
have *that* many computations, and since many callers go on to copy the
list of non-fusion computations, making it unconditionally a copy is
simpler and avoids a footgun.

PiperOrigin-RevId: 170529051
/external/tensorflow/tensorflow/compiler/xla/service/tuple_simplifier.cc
9b1b5d85b9ce3c812dc772da1f3f5d09581e5b49 29-Sep-2017 Justin Lebar <jlebar@google.com> [XLA] Make HloComputation::instructions() return a view of HloInstruction*s.

Currently it returns a view of unique_ptr<HloInstruction>s. But the
fact that these are unique_ptrs is an implementation detail, and it's
ugly to leak it everywhere.

PiperOrigin-RevId: 170445375
/external/tensorflow/tensorflow/compiler/xla/service/tuple_simplifier.cc
f972d800ca3accc9af0ad5b9dcabbc5d9b125ab5 28-Sep-2017 Justin Lebar <jlebar@google.com> [XLA] Replace HloComputation::ReplaceUsesOfInstruction with HloInstruction::ReplaceAllUsesWith.

RAUW used to be *almost* synonymous with RUOI, except RAUW didn't update
the computation's root. This was a dangerous footgun -- if you
accidentally called RAUW when you wanted RUOI (which you almost always
did), your code would work perfectly, except when the relevant node
happened to be the root of a computation.

This change simplifies our APIs so there's just one Right Way To Do It,
by making RAUW update the computation.

PiperOrigin-RevId: 170290230
/external/tensorflow/tensorflow/compiler/xla/service/tuple_simplifier.cc
64cca2be776a332e1e9e8e7c6bbf1b170020e819 27-Sep-2017 Mark Heffernan <meheff@google.com> Do not simplify Tuple->GetTupleElement->Tuple constructs in TupleSimplifier if
the input and output tuples are not compatible.

PiperOrigin-RevId: 170213262
/external/tensorflow/tensorflow/compiler/xla/service/tuple_simplifier.cc
079061306d4f58295e48b452818875c6a9bdbfaa 27-Sep-2017 Mark Heffernan <meheff@google.com> Add TupleSimplifier pass which collapses structures of Tuple and GetTupleElement instructions.

PiperOrigin-RevId: 170122192
/external/tensorflow/tensorflow/compiler/xla/service/tuple_simplifier.cc