| 456696a9c1bbd586701dcca3e4b2695e419a10ba |
|
01-Oct-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Reland Change WebRTC SslCipher to be exposed as number only
This is to revert the change of https://codereview.webrtc.org/1380603005/
TBR=pthatcher@webrtc.org
BUG=523033
Review URL: https://codereview.webrtc.org/1375543003 .
Cr-Commit-Position: refs/heads/master@{#10126}
/external/webrtc/talk/app/webrtc/fakemetricsobserver.cc
|
| 27dc29b0df23eed5034f28d4d5f66ea0bb425d6c |
|
01-Oct-2015 |
guoweis <guoweis@webrtc.org> |
Revert of Change WebRTC SslCipher to be exposed as number only. (patchset #20 id:750001 of https://codereview.webrtc.org/1337673002/ )
Reason for revert:
This broke chromium.fyi bot.
Original issue's description:
> Change WebRTC SslCipher to be exposed as number only.
>
> This makes the SSL exposed as uint16_t which is the IANA value. GetRfcSslCipherName is introduced to handle the conversion to names from ID. IANA value will be used for UMA reporting. Names will still be used for WebRTC stats reporting.
>
> For SRTP, currently it's still string internally but is reported as IANA number.
>
> This is used by the ongoing CL https://codereview.chromium.org/1335023002.
>
> BUG=523033
>
> Committed: https://crrev.com/4fe3c9a77386598db9abd1f0d6983aefee9cc943
> Cr-Commit-Position: refs/heads/master@{#10124}
TBR=juberti@webrtc.org,rsleevi@chromium.org,pthatcher@webrtc.org,davidben@chromium.org,juberti@google.com,davidben@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=523033
Review URL: https://codereview.webrtc.org/1380603005
Cr-Commit-Position: refs/heads/master@{#10125}
/external/webrtc/talk/app/webrtc/fakemetricsobserver.cc
|
| 4fe3c9a77386598db9abd1f0d6983aefee9cc943 |
|
01-Oct-2015 |
guoweis <guoweis@webrtc.org> |
Change WebRTC SslCipher to be exposed as number only.
This makes the SSL exposed as uint16_t which is the IANA value. GetRfcSslCipherName is introduced to handle the conversion to names from ID. IANA value will be used for UMA reporting. Names will still be used for WebRTC stats reporting.
For SRTP, currently it's still string internally but is reported as IANA number.
This is used by the ongoing CL https://codereview.chromium.org/1335023002.
BUG=523033
Review URL: https://codereview.webrtc.org/1337673002
Cr-Commit-Position: refs/heads/master@{#10124}
/external/webrtc/talk/app/webrtc/fakemetricsobserver.cc
|
| 91d6edef35e7275879c30ce16ecb8b6dc73c6e4a |
|
17-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to (D)CHECKs and related macros.
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.
Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.
BUG=chromium:468375
NOTRY=true
Review URL: https://codereview.webrtc.org/1335923002
Cr-Commit-Position: refs/heads/master@{#9964}
/external/webrtc/talk/app/webrtc/fakemetricsobserver.cc
|
| ea1012b2a41b1b56fe7366792f10390639d82495 |
|
21-Aug-2015 |
guoweis <guoweis@webrtc.org> |
address comments from https://codereview.webrtc.org/1277263002/
TBR=juberti@webrtc.org,pthather@webrtc.org
Review URL: https://codereview.webrtc.org/1305113002
Cr-Commit-Position: refs/heads/master@{#9757}
/external/webrtc/talk/app/webrtc/fakemetricsobserver.cc
|
| 3d564c10157d7de1d2d4236f4e2a13ff1363d52b |
|
20-Aug-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Add instrumentation to track the IceEndpointType.
The IceEndpointType has the format of <local_endpoint>_<remote_endpoint>. It is recorded on the BestConnection when we have the first OnTransportCompleted signaled.
BUG=webrtc:4918
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1277263002 .
Cr-Commit-Position: refs/heads/master@{#9737}
/external/webrtc/talk/app/webrtc/fakemetricsobserver.cc
|
| ac8869ec5a606e0a0ab71e70937c8fbf403630ce |
|
03-Jul-2015 |
jbauch <jbauch@webrtc.org> |
Report metrics about negotiated ciphers.
This CL adds an API to the metrics observer interface to report negotiated
ciphers for WebRTC sessions. This can be used from Chromium for UMA metrics
later to get an idea which cipher suites are used by clients (e.g. compare
the use of DTLS 1.0 / 1.2).
BUG=428343
Review URL: https://codereview.webrtc.org/1156143005
Cr-Commit-Position: refs/heads/master@{#9537}
/external/webrtc/talk/app/webrtc/fakemetricsobserver.cc
|