| 8c266e6baff043a1fa5c9134f46042908a376d5b |
|
24-Sep-2015 |
Peter Boström <pbos@webrtc.org> |
H264 bitstream parser.
Parsing the encoded bitstream is required for doing downscaling
decisions based on average encoded QP to improve perceived quality.
BUG=webrtc:4968
R=noahric@chromium.org, stefan@webrtc.org
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1314473008 .
Cr-Commit-Position: refs/heads/master@{#10051}
/external/webrtc/webrtc/base/bitbuffer.cc
|
| 91d6edef35e7275879c30ce16ecb8b6dc73c6e4a |
|
17-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to (D)CHECKs and related macros.
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.
Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.
BUG=chromium:468375
NOTRY=true
Review URL: https://codereview.webrtc.org/1335923002
Cr-Commit-Position: refs/heads/master@{#9964}
/external/webrtc/webrtc/base/bitbuffer.cc
|
| 9b9f1c45626f727bc1f646b1edb718064e719a8a |
|
12-May-2015 |
Noah Richards <noahric@chromium.org> |
Remove basictypes.h dependency from bitbuffer.
This reduces the types exported in webrtc proper, which can cause other
issues (since it doesn't generally use webrtc/base/basictypes.h).
basictypes.h integral types (e.g. uint8) have been replaced by the
stdint counterparts (e.g. uint8_t), which matches general webrtc style.
The include for common.h has been replaced by constructormagic.h, which
was the only part used.
BUG=
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50859004
Cr-Commit-Position: refs/heads/master@{#9181}
/external/webrtc/webrtc/base/bitbuffer.cc
|
| 86153c26a00b30579a5b6c226ad5fd2b46b9926b |
|
29-Apr-2015 |
Noah Richards <noahric@chromium.org> |
Added a BitBufferWriter subclass that contains methods for writing bit and byte-sized data, along with exponential golomb encoded data.
This pattern (read-only base, writable subclass) was picked to maintain a *Buffer option that doesn't copy the source bits when parsing. ByteBuffer and Buffer both copy. I'm open to discussion on what the type relationship would be, though :)
Tests have been added to ensure the symmetric nature of read/write operations.
BUG=
R=bcornell@google.com, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/45259005
Cr-Commit-Position: refs/heads/master@{#9107}
/external/webrtc/webrtc/base/bitbuffer.cc
|
| bbf7c864ad7b9c6b643ece24967cab77c87ad26c |
|
22-Apr-2015 |
Noah Richards <noahric@chromium.org> |
Add a new BitBuffer class to webrtc base.
Provides a read-only interface for reading byte and bit-sized data from
an underlying buffer in network/big-endian order. Also provides a method
for reading exponential golomb encoded values, which will be useful in
H.264 packet parsing (separate CL).
BUG=
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49719004
Cr-Commit-Position: refs/heads/master@{#9046}
/external/webrtc/webrtc/base/bitbuffer.cc
|