| 36220ae24f8f5d34b660d6c4c91dd4260886dcb9 |
|
12-Jan-2016 |
kwiberg <kwiberg@webrtc.org> |
Slap deprecation notices on Pass methods
There's no reason not to use std::move instead now that we can use the
C++11 standard library.
BUG=webrtc:5373
Review URL: https://codereview.webrtc.org/1531013003
Cr-Commit-Position: refs/heads/master@{#11225}
/external/webrtc/webrtc/base/buffer.h
|
| cea7c2f7839eef81ecbd6dd10d103190ef68875c |
|
07-Jan-2016 |
kwiberg <kwiberg@webrtc.org> |
Replace manual casting to rvalue reference with calls to std::move
Review URL: https://codereview.webrtc.org/1570473002
Cr-Commit-Position: refs/heads/master@{#11163}
/external/webrtc/webrtc/base/buffer.h
|
| 0eb15ed7b806125774bd13fb214aeb403e2c6857 |
|
17-Dec-2015 |
kwiberg <kwiberg@webrtc.org> |
Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector
We can now use std::move instead!
This CL leaves the Pass methods in place; a follow-up CL will add deprecation annotations to them.
Review URL: https://codereview.webrtc.org/1460043002
Cr-Commit-Position: refs/heads/master@{#11064}
/external/webrtc/webrtc/base/buffer.h
|
| 27dfe201a55b345c17ca4586a5a5a3a9ab245ee9 |
|
23-Oct-2015 |
noahric <noahric@chromium.org> |
Remove final from rtc::Buffer.
With it removed, you can now use it with scoped_refptr by wrapping it in
an rtc::RefCountedObject<rtc::Buffer>.
BUG=
Review URL: https://codereview.webrtc.org/1414053003
Cr-Commit-Position: refs/heads/master@{#10386}
/external/webrtc/webrtc/base/buffer.h
|
| c56ac1ec298630ba95e44a9da9efeb9d1a6d43d4 |
|
04-May-2015 |
Karl Wiberg <kwiberg@webrtc.org> |
rtc::Buffer: Remove backwards compatibility band-aids
This CL makes two changes to rtc::Buffer that have had to wait for
Chromium's use of it to be modernized:
1. Change default return type of rtc::Buffer::data() from char* to
uint8_t*. uint8_t is a more natural type for bytes, and won't
accidentally convert to a string. (Chromium previously expected
the default return type to be char, which is why
rtc::Buffer::data() initially got char as default return type in
9478437f, but that's been fixed now.)
2. Stop accepting void* inputs in constructors and methods. While
this is convenient, it's also dangerous since any pointer type
will implicitly convert to void*.
(This was previously committed (9e1a6d7c) but had to be reverted
(cbf09274) because Chromium on Android wasn't quite ready for it).
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47109004
Cr-Commit-Position: refs/heads/master@{#9132}
/external/webrtc/webrtc/base/buffer.h
|
| cbf0927473c10a0a25bbf55707f1ca2b2fd57708 |
|
30-Apr-2015 |
Karl Wiberg <kwiberg@webrtc.org> |
Revert "rtc::Buffer: Remove backwards compatibility band-aids"
This reverts commit 9e1a6d7c236c9a8a322bef54d4ec2a087e5baa07, because
Chromium for Android still isn't happy with it.
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49869004
Cr-Commit-Position: refs/heads/master@{#9122}
/external/webrtc/webrtc/base/buffer.h
|
| 9e1a6d7c236c9a8a322bef54d4ec2a087e5baa07 |
|
30-Apr-2015 |
Karl Wiberg <kwiberg@webrtc.org> |
rtc::Buffer: Remove backwards compatibility band-aids
This CL makes two changes to rtc::Buffer that have had to wait for
Chromium's use of it to be modernized:
1. Change default return type of rtc::Buffer::data() from char* to
uint8_t*. uint8_t is a more natural type for bytes, and won't
accidentally convert to a string. (Chromium previously expected
the default return type to be char, which is why
rtc::Buffer::data() initially got char as default return type in
9478437f, but that's been fixed now.)
2. Stop accepting void* inputs in constructors and methods. While
this is convenient, it's also dangerous since any pointer type
will implicitly convert to void*.
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44269004
Cr-Commit-Position: refs/heads/master@{#9121}
/external/webrtc/webrtc/base/buffer.h
|
| 011c00f708f1bdcbecf6c941343e090f378f09a6 |
|
20-Apr-2015 |
Karl Wiberg <kwiberg@webrtc.org> |
rtc::Buffer: Accept void* in addition to the byte-sized types
We used to accept void* (until 9478437f), and we'll have to continue
to do so for a little while longer, until Chromium doesn't need it
anymore.
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48179004
Cr-Commit-Position: refs/heads/master@{#9035}
/external/webrtc/webrtc/base/buffer.h
|
| 9478437fdea4eb31b92ffe0c10368fe5bc9b9e16 |
|
20-Apr-2015 |
Karl Wiberg <kwiberg@webrtc.org> |
rtc::Buffer improvements
1. Constructors, SetData(), and AppendData() now accept uint8_t*,
int8_t*, and char*. Previously, they accepted void*, meaning that
any kind of pointer was accepted. I think requiring an explicit
cast in cases where the input array isn't already of a byte-sized
type is a better compromise between convenience and safety.
2. data() can now return a uint8_t* instead of a char*, which seems
more appropriate for a byte array, and is harder to mix up with
zero-terminated C strings. data<int8_t>() is also available so
that callers that want that type instead won't have to cast, as
is data<char>() (which remains the default until all existing
callers have been fixed).
3. Constructors, SetData(), and AppendData() now accept arrays
natively, not just decayed to pointers. The advantage of this is
that callers don't have to pass the size separately.
4. There are new constructors that allow setting size and capacity
without initializing the array. Previously, this had to be done
separately after construction.
5. Instead of TransferTo(), Buffer now supports swap(), and move
construction and assignment, and has a Pass() method that works
just like std::move(). (The Pass method is modeled after
scoped_ptr::Pass().)
R=jmarusic@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42989004
Cr-Commit-Position: refs/heads/master@{#9033}
/external/webrtc/webrtc/base/buffer.h
|
| 61c2a6f241ac9db626aeab755e49897030b289e1 |
|
16-Apr-2015 |
Karl Wiberg <kwiberg@webrtc.org> |
Remove rtc::Buffer::length(), since no one uses it anymore
Chromium now uses size() instead, just like WebRTC.
This CL also fixes a new length() call that had crept in.
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44119004
Cr-Commit-Position: refs/heads/master@{#9024}
/external/webrtc/webrtc/base/buffer.h
|
| 4d14592c6744d12c24968b4fc0b5a3bdae3d1093 |
|
24-Mar-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
rtc::Buffer: Restore length method for backwards compatibility
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43939004
Cr-Commit-Position: refs/heads/master@{#8845}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8845 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/buffer.h
|
| eebcab5ce99d3e8641dd92a569916b0d24e29fca |
|
24-Mar-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
rtc::Buffer: Rename length to size, for conformance with the STL
And add a constructor for creating an uninitialized Buffer of a
specified size.
(I intend to follow up with more Buffer changes, but since it's rather
widely used, the rename is quite noisy and works better as a separate
CL.)
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48579004
Cr-Commit-Position: refs/heads/master@{#8841}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8841 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/buffer.h
|
| 67186fe00cc68cbe03aa66d17fb4962458ca96d2 |
|
09-Mar-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Fix clang style warnings in webrtc/base
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/buffer.h
|
| 11426dc719f24ece3246fd8fb24ae073c49b42ed |
|
11-Feb-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Don't rely on webrtc/base/scoped_ptr.h to include stuff for you
webrtc/base/scoped_ptr.h doesn't need to include webrtc/base/common.h
anymore, but a couple of its users were relying on it to pull in other
things for them. Fix that, and remove the now really unnecessary
webrtc/base/common.h include.
R=andrew@webrtc.org, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37169004
Cr-Commit-Position: refs/heads/master@{#8333}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8333 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/buffer.h
|
| f048872e915a3ee229044ec4bc541f6cbf9e4de1 |
|
13-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/buffer.h
|
| e9a604accd54ab14dbf98f99ccdcf3ae1c54d27c |
|
13-May-2014 |
perkj@webrtc.org <perkj@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/buffer.h
|
| 2c7d1b39b9374d2bc9bda4755fd4813db66a135c |
|
12-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/buffer.h
|