a41ab9326c8f0f7eb738e5d51a239a2b9e276361 |
|
31-Oct-2015 |
tfarina <tfarina@chromium.org> |
Switch usage of _DEBUG macro to NDEBUG. http://stackoverflow.com/a/29253284/5237416 BUG=None R=tommi@webrtc.org NOPRESUBMIT=true Review URL: https://codereview.webrtc.org/1429513004 Cr-Commit-Position: refs/heads/master@{#10468}
/external/webrtc/webrtc/base/stringutils.cc
|
91d6edef35e7275879c30ce16ecb8b6dc73c6e4a |
|
17-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to (D)CHECKs and related macros. We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition. Alternative solutions: * Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable. * Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce. * Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable. * Changes in Chromium for this is obviously not an option. BUG=chromium:468375 NOTRY=true Review URL: https://codereview.webrtc.org/1335923002 Cr-Commit-Position: refs/heads/master@{#9964}
/external/webrtc/webrtc/base/stringutils.cc
|
6ae5a6d7fefff6759d338b5a3e3613e050ebaa62 |
|
16-Sep-2014 |
andrew@webrtc.org <andrew@webrtc.org> |
Add a target for the approved subset of rtc_base. rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and json) not required for standalone webrtc (aka rtc/media). The root of the problem appears to be that MessageQueue depends on a socket server. (And since common.h -> logging.h -> thread.h -> messagequeue.h, this dependency spreads quickly.) This starts a new target for a "purified" subset of rtc_base. It adds the files which are already being used, replacing the use of common.h with checks.h. desktop_capture is a lost cause, and retains its dependency on the full rtc_base. The hope is that as additional components are desired they will be cleaned and added to rtc_base_approved. BUG=3806 R=andresp@webrtc.org, henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22649004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/stringutils.cc
|
f048872e915a3ee229044ec4bc541f6cbf9e4de1 |
|
13-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/stringutils.cc
|
e9a604accd54ab14dbf98f99ccdcf3ae1c54d27c |
|
13-May-2014 |
perkj@webrtc.org <perkj@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..." This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome. http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457 > Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. > > BUG=N/A > R=andrew@webrtc.org, wu@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/12199004 TBR=henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/14479004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/stringutils.cc
|
2c7d1b39b9374d2bc9bda4755fd4813db66a135c |
|
12-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=andrew@webrtc.org, wu@webrtc.org Review URL: https://webrtc-codereview.appspot.com/12199004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/stringutils.cc
|