dce40cf804019a9898b6ab8d8262466b697c56e0 |
|
24-Aug-2015 |
Peter Kasting <pkasting@google.com> |
Update a ton of audio code to use size_t more correctly and in general reduce use of int16_t/uint16_t. This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects. This was be reviewed and approved in pieces: https://codereview.webrtc.org/1224093003 https://codereview.webrtc.org/1224123002 https://codereview.webrtc.org/1224163002 https://codereview.webrtc.org/1225133003 https://codereview.webrtc.org/1225173002 https://codereview.webrtc.org/1227163003 https://codereview.webrtc.org/1227203003 https://codereview.webrtc.org/1227213002 https://codereview.webrtc.org/1227893002 https://codereview.webrtc.org/1228793004 https://codereview.webrtc.org/1228803003 https://codereview.webrtc.org/1228823002 https://codereview.webrtc.org/1228823003 https://codereview.webrtc.org/1228843002 https://codereview.webrtc.org/1230693002 https://codereview.webrtc.org/1231713002 The change is being landed as TBR to all the folks who reviewed the above. BUG=chromium:81439 TEST=none R=andrew@webrtc.org, pbos@webrtc.org TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher Review URL: https://codereview.webrtc.org/1230503003 . Cr-Commit-Position: refs/heads/master@{#9768}
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|
d40af69278f867965fd10313f9c99f90266a9469 |
|
28-Jul-2015 |
andrew <andrew@webrtc.org> |
Split MoveReadPosition into Forward and Backward versions. This makes the interface consistent in its use of size_t, and will reduce casts in callers as they shift to size_t, e.g. this CL: https://codereview.webrtc.org/1227203003/ Review URL: https://codereview.webrtc.org/1252943007 Cr-Commit-Position: refs/heads/master@{#9646}
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|
728d9037c016c01295177fa700fc7927f0bb80bb |
|
11-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Reformat existing code. There should be no functional effects. This includes changes like: * Attempt to break lines at better positions * Use "override" in more places, don't use "virtual" with it * Use {} where the body is more than one line * Make declaration and definition arg names match * Eliminate unused code * EXPECT_EQ(expected, actual) (but use (actual, expected) for e.g. _GT) * Correct #include order * Use anonymous namespaces in preference to "static" for file-scoping * Eliminate unnecessary casts * Update reference code in comments of ARM assembly sources to match actual current C code * Fix indenting to be more style-guide compliant * Use arraysize() in more places * Use bool instead of int for "boolean" values (0/1) * Shorten and simplify code * Spaces around operators * 80 column limit * Use const more consistently * Space goes after '*' in type name, not before * Remove unnecessary return values * Use "(var == const)", not "(const == var)" * Spelling * Prefer true, typed constants to "enum hack" constants * Avoid "virtual" on non-overridden functions * ASSERT(x == y) -> ASSERT_EQ(y, x) BUG=none R=andrew@webrtc.org, asapersson@webrtc.org, henrika@webrtc.org, juberti@webrtc.org, kjellander@webrtc.org, kwiberg@webrtc.org Review URL: https://codereview.webrtc.org/1172163004 Cr-Commit-Position: refs/heads/master@{#9420}
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|
00b8f6b3643332cce1ee711715f7fbb824d793ca |
|
26-Feb-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away BUG= R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/36229004 Cr-Commit-Position: refs/heads/master@{#8517} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|
d35a5c350617cc9d60ce45201764a99229b7299a |
|
10-Feb-2015 |
aluebs@webrtc.org <aluebs@webrtc.org> |
Make ChannelBuffer aware of frequency bands Now the ChannelBuffer has 2 separate arrays, one for the full-band data and one for the splitted one. The corresponding accessors are added to the ChannelBuffer. This is done to avoid having to refresh the bands pointers in AudioBuffer. It will also allow us to have a general accessor like data()[band][channel][sample]. All the files using the ChannelBuffer needed to be re-factored. Tested with modules_unittests, common_audio_unittests, audioproc, audioproc_f, voe_cmd_test. R=andrew@webrtc.org, kwiberg@webrtc.org Review URL: https://webrtc-codereview.appspot.com/36999004 Cr-Commit-Position: refs/heads/master@{#8318} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8318 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|
035e9123e9c7de3b09b37bc8e57907e4af7ce219 |
|
28-Jan-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Move channel_buffer.{h,cc} to common_audio. In https://code.google.com/p/webrtc/source/detail?r=8166 I added a check preventing GYP files from referencing sources above their directory level. This CL fixes the disallowed reference added in https://code.google.com/p/webrtc/source/detail?r=8157 by moving channel_buffer.{h,cc} to common_audio for real. BUG=4185 R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/35939004 Cr-Commit-Position: refs/heads/master@{#8190} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8190 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|
922cfcd1500f62f76154957c99b9bf75d12a3e28 |
|
27-Jan-2015 |
andrew@webrtc.org <andrew@webrtc.org> |
Use non-zero data in AudioRingBufferTest. TBR=aluebs@webrtc.org Review URL: https://webrtc-codereview.appspot.com/35909004 Cr-Commit-Position: refs/heads/master@{#8176} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8176 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|
041035b390e25b1d388d73ef52c9e68a550a982f |
|
26-Jan-2015 |
andrew@webrtc.org <andrew@webrtc.org> |
Add an AudioRingBuffer class wrapper for the ring_buffer.h C interface. Integrate it in Blocker to demonstrate use. TEST=beamforming sounds good. R=aluebs@webrtc.org, mgraczyk@chromium.org, sahark@google.com Review URL: https://webrtc-codereview.appspot.com/36799004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8157 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_audio/audio_ring_buffer_unittest.cc
|