dce40cf804019a9898b6ab8d8262466b697c56e0 |
|
24-Aug-2015 |
Peter Kasting <pkasting@google.com> |
Update a ton of audio code to use size_t more correctly and in general reduce use of int16_t/uint16_t. This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects. This was be reviewed and approved in pieces: https://codereview.webrtc.org/1224093003 https://codereview.webrtc.org/1224123002 https://codereview.webrtc.org/1224163002 https://codereview.webrtc.org/1225133003 https://codereview.webrtc.org/1225173002 https://codereview.webrtc.org/1227163003 https://codereview.webrtc.org/1227203003 https://codereview.webrtc.org/1227213002 https://codereview.webrtc.org/1227893002 https://codereview.webrtc.org/1228793004 https://codereview.webrtc.org/1228803003 https://codereview.webrtc.org/1228823002 https://codereview.webrtc.org/1228823003 https://codereview.webrtc.org/1228843002 https://codereview.webrtc.org/1230693002 https://codereview.webrtc.org/1231713002 The change is being landed as TBR to all the folks who reviewed the above. BUG=chromium:81439 TEST=none R=andrew@webrtc.org, pbos@webrtc.org TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher Review URL: https://codereview.webrtc.org/1230503003 . Cr-Commit-Position: refs/heads/master@{#9768}
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|
b297c5a01f88219da26cffe433804963d1b70f0f |
|
23-Jul-2015 |
pkasting <pkasting@chromium.org> |
Miscellaneous changes split from https://codereview.webrtc.org/1230503003 . These are mostly trivial changes and are separated out just to reduce the diff on that change to the minimum possible. Note explanatory comments on patch set 1. BUG=none TEST=none Review URL: https://codereview.webrtc.org/1235643003 Cr-Commit-Position: refs/heads/master@{#9617}
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|
36b7cc32643bae0379d8102ce05dae82ecc466a1 |
|
12-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Reland "Upconvert various types to int.", neteq portion. This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the files in webrtc/modules/audio_coding/neteq/ are relanded. The original commit message is below: Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none TBR=kwiberg Review URL: https://codereview.webrtc.org/1181073002 Cr-Commit-Position: refs/heads/master@{#9427}
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|
cb180976dd0e9672cde4523d87b5f4857478b5e9 |
|
11-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Revert "Upconvert various types to int." This reverts commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. BUG=499241 TBR=hlundin Review URL: https://codereview.webrtc.org/1179953003 Cr-Commit-Position: refs/heads/master@{#9418}
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|
83ad33a8aed1fb00e422b6abd33c3e8942821c24 |
|
10-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none R=andrew@webrtc.org, kwiberg@webrtc.org Review URL: https://webrtc-codereview.appspot.com/54629004 Cr-Commit-Position: refs/heads/master@{#9405}
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|
9c55f0f957534144d2b8a64154f0a479249b34be |
|
09-Jun-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Rename neteq4 folder to neteq Keep the old neteq4/audio_decoder_unittests.isolate while waiting for a hard-coded reference to change. This CL effectively reverts r6257 "Rename neteq4 folder to neteq". BUG=2996 TBR=tina.legrand@webrtc.org Review URL: https://webrtc-codereview.appspot.com/21629004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6367 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|
1b9df05c8521d1d807b08d7c00eb2f7e5b097fdf |
|
28-May-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 6257 "Rename neteq4 folder to neteq" > Rename neteq4 folder to neteq > > BUG=2996 > R=turaj@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/12569005 TBR=henrik.lundin@webrtc.org Review URL: https://webrtc-codereview.appspot.com/13549004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6259 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|
a90f6d67f72359cf63b59480fa87a13aae808c03 |
|
28-May-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Rename neteq4 folder to neteq BUG=2996 R=turaj@webrtc.org Review URL: https://webrtc-codereview.appspot.com/12569005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6257 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/dsp_helper.cc
|