55674ffb32307c6f3efaab442340d3c5c075073b |
|
14-Jan-2016 |
Stefan Holmer <stefan@webrtc.org> |
Reland Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. Chromium reported errors when building libjingle_nacl due to some methods used virtual instead of override when they were overriding the base class. My guess is that when one method starts using override, all other in the same class must too. R=tommi@webrtc.org TBR=pthatcher@webtrc.org BUG=4173 Review URL: https://codereview.webrtc.org/1589563003 . Cr-Commit-Position: refs/heads/master@{#11251}
/external/webrtc/webrtc/p2p/base/turnport.h
|
e5e0e57bdfd8831b2ad917e7990e273fdfe26af4 |
|
14-Jan-2016 |
tommi <tommi@webrtc.org> |
Revert of Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. (patchset #3 id:40001 of https://codereview.webrtc.org/1577873003/ ) Reason for revert: Broke Chrome: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/143025/steps/compile%20%28with%20patch%29/logs/stdio FAILED: cd ../../third_party/libjingle; python ../../native_client/build/build_nexe.py --root ../.. --product-dir ../../out/Debug/xyz --config-name Debug -t ../../native_client/toolchain/ --arch pnacl --build newlib_plib --name ../../out/Debug/gen/tc_pnacl_newlib/lib/libjingle_nacl.a --objdir ../../out/Debug/obj/third_party/libjingle/libjingle_nacl.gen/pnacl_newlib-pnacl/libjingle_nacl "--include-dirs=../../out/Debug/gen/tc_pnacl_newlib/include ../.. \"../../out/Debug/gen\" ./source ../ ../../native_client_sdk/src/libraries ../../native_client_sdk/src/libraries/nacl_io/include ../../native_client_sdk/src/libraries/third_party/newlib-extras ../expat/files/lib ../boringssl/src/include" "--compile_flags=-O2 -g -Wall -fdiagnostics-show-option -Werror -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function \"-std=gnu++11\" " --gomadir /b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS \"CLD_VERSION=2\" \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD \"CR_CLANG_REVISION=255169-1\" COMPONENT_BUILD UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"IMAGE_LOADER_EXTENSION=1\" \"ENABLE_WEBRTC=1\" \"ENABLE_MEDIA_ROUTER=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" \"ENABLE_TOPCHROME_MD=1\" USE_UDEV DONT_EMBED_BUILD_METADATA \"DCHECK_ALWAYS_ON=1\" FIELDTRIAL_TESTING_ENABLED \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PDF=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" V8_USE_EXTERNAL_STARTUP_DATA FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL EXPAT_RELATIVE_PATH FEATURE_ENABLE_SSL GTEST_RELATIVE_PATH HAVE_OPENSSL_SSL_H NO_MAIN_THREAD_WRAPPING NO_SOUND_SYSTEM WEBRTC_POSIX SRTP_RELATIVE_PATH SSL_USE_OPENSSL USE_WEBRTC_DEV_BRANCH \"timezone=_timezone\" XML_STATIC \"USE_LIBPCI=1\" \"USE_OPENSSL=1\" \"USE_OPENSSL_CERTS=1\"" "--link_flags=-B../../out/Debug/gen/tc_pnacl_newlib/lib " "--source-list=../../out/gypfiles/third_party/libjingle/pnacl_newlib.libjingle_nacl.source_list.gypcmd" In file included from ../webrtc/p2p/base/tcpport.cc:67: ../webrtc/p2p/base/tcpport.h:50:23: error: 'CreateConnection' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual Connection* CreateConnection(const Candidate& address, ^ ../webrtc/p2p/base/portinterface.h:71:23: note: overridden virtual function is here virtual Connection* CreateConnection( ^ In file included from ../webrtc/p2p/base/tcpport.cc:67: ../webrtc/p2p/base/tcpport.h:53:16: error: 'PrepareAddress' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual void PrepareAddress(); ^ ../webrtc/p2p/base/portinterface.h:63:16: note: overridden virtual function is here virtual void PrepareAddress() = 0; ^ (etc) Original issue's description: > Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. > > To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it. > > BUG=4173 > R=pthatcher@webrtc.org > > Committed: https://crrev.com/7307952a5bf63311e5f9a2a90089a06177e42716 > Cr-Commit-Position: refs/heads/master@{#11247} TBR=pthatcher@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=4173 Review URL: https://codereview.webrtc.org/1586063002 Cr-Commit-Position: refs/heads/master@{#11249}
/external/webrtc/webrtc/p2p/base/turnport.h
|
7307952a5bf63311e5f9a2a90089a06177e42716 |
|
14-Jan-2016 |
Stefan Holmer <stefan@webrtc.org> |
Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it. BUG=4173 R=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1577873003 . Cr-Commit-Position: refs/heads/master@{#11247}
/external/webrtc/webrtc/p2p/base/turnport.h
|
6b9ab9204b9e0891cb0be2595a0d7ada92945cea |
|
05-Jan-2016 |
honghaiz <honghaiz@webrtc.org> |
Cease all future TURN requests when a TURN refresh request fails for a given TURN port. This fixes an assert error in Turnport::OnSendStunPacket BUG=webrtc:5388 Review URL: https://codereview.webrtc.org/1547373002 Cr-Commit-Position: refs/heads/master@{#11152}
/external/webrtc/webrtc/p2p/base/turnport.h
|
f9945b2d1aa2d78b19987219ea872605167d7b5f |
|
15-Dec-2015 |
Honghai Zhang <honghaiz@webrtc.org> |
Only try to pair protocol matching candidates for creating connections. If the local port and the remote candidate's protocols do not match, do not even try to pair them. This avoids printing out confusing logs like "Attempt to change a remote candidate..." in p2ptransportchannel when two remote candidates have the same port number but different protocols. BUG= R=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1516613002 . Cr-Commit-Position: refs/heads/master@{#11034}
/external/webrtc/webrtc/p2p/base/turnport.h
|
f67c548576ad957a1e9c3196e11d45f41e320424 |
|
12-Dec-2015 |
Honghai Zhang <honghaiz@webrtc.org> |
Handle Turn error response to RefreshRequest, CreatePermissionRequest, and ChanelBindRequest BUG=webrtc:5116 R=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1453823004 . Cr-Commit-Position: refs/heads/master@{#10994}
/external/webrtc/webrtc/p2p/base/turnport.h
|
c3e0fe7c21a6c6c367ce38b54634dc38f6222693 |
|
03-Dec-2015 |
honghaiz <honghaiz@webrtc.org> |
Make it extra safe when deleting a turn entry. Check if it is in the list of turn entries before attempting to delete it. BUG= Review URL: https://codereview.webrtc.org/1458013004 Cr-Commit-Position: refs/heads/master@{#10877}
/external/webrtc/webrtc/p2p/base/turnport.h
|
376e1235c7b602e86afe9f36eb81289e42643718 |
|
25-Nov-2015 |
deadbeef <deadbeef@webrtc.org> |
Destroy a Connection if a CreatePermission request fails. This means that if a TURN server denies permission for an unreachable address, we'll no longer ping it fruitlessly. BUG=webrtc:4917 Review URL: https://codereview.webrtc.org/1415313004 Cr-Commit-Position: refs/heads/master@{#10789}
/external/webrtc/webrtc/p2p/base/turnport.h
|
32f39968ce79cfca5146069e410ded2f104bba23 |
|
17-Nov-2015 |
honghaiz <honghaiz@webrtc.org> |
Re-apply change https://codereview.webrtc.org/1426673007/ Do not delete the turn port entry right away when the respective connection is deleted. The dependency on asyncinvoker has been added in chromium libjingle-nacl. BUG=webrtc:5120 Review URL: https://codereview.webrtc.org/1450263002 Cr-Commit-Position: refs/heads/master@{#10679}
/external/webrtc/webrtc/p2p/base/turnport.h
|
54e92326af4ce409e5c9e139cd50329b790061e2 |
|
16-Nov-2015 |
tommi <tommi@webrtc.org> |
Revert of Do not delete the turn port entry right away when the respective connection is deleted. (patchset #5 id:260001 of https://codereview.webrtc.org/1426673007/ ) Reason for revert: I have to revert this unfortunately because it adds a dependency on AsyncInvoker, which is not included when building libjingle_nacl in Chromium. AsyncInvoker needs to first be added to the list of sources in Chromium. Original issue's description: > Do not delete the turn port entry right away when the respective connection is deleted. > BUG=webrtc:5120 > > Committed: https://crrev.com/e58fe8ef0e6d959f54adee3ed77764927d3845cc > Cr-Commit-Position: refs/heads/master@{#10641} TBR=pthatcher@webrtc.org,honghaiz@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5120 Review URL: https://codereview.webrtc.org/1449863002 Cr-Commit-Position: refs/heads/master@{#10649}
/external/webrtc/webrtc/p2p/base/turnport.h
|
e58fe8ef0e6d959f54adee3ed77764927d3845cc |
|
14-Nov-2015 |
honghaiz <honghaiz@webrtc.org> |
Do not delete the turn port entry right away when the respective connection is deleted. BUG=webrtc:5120 Review URL: https://codereview.webrtc.org/1426673007 Cr-Commit-Position: refs/heads/master@{#10641}
/external/webrtc/webrtc/p2p/base/turnport.h
|
8597543ae845073ca32876bfaaff207017b6c0eb |
|
12-Nov-2015 |
Honghai Zhang <honghaiz@webrtc.org> |
Schedule a CreatePermissionRequest after the success of a previous request unless a channel binding request is already scheduled. BUG=5178 R=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1434603002 . Cr-Commit-Position: refs/heads/master@{#10625}
/external/webrtc/webrtc/p2p/base/turnport.h
|
0c4e06b4c6107a1b94f764e279e4fb4161e905b0 |
|
07-Oct-2015 |
Peter Boström <pbos@webrtc.org> |
Use suffixed {uint,int}{8,16,32,64}_t types. Removes the use of uint8, etc. in favor of uint8_t. BUG=webrtc:5024 R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org Review URL: https://codereview.webrtc.org/1362503003 . Cr-Commit-Position: refs/heads/master@{#10196}
/external/webrtc/webrtc/p2p/base/turnport.h
|
b19eba3d4bbc70ece91d524e21e2e9d4253ff7a9 |
|
03-Aug-2015 |
honghaiz <honghaiz@webrtc.org> |
Fix Turn TCP port issue. Sometimes the port still try to send stun packet when the connection is disconnected, causing an assertion error. BUG=4859 Review URL: https://codereview.webrtc.org/1247573002 Cr-Commit-Position: refs/heads/master@{#9671}
/external/webrtc/webrtc/p2p/base/turnport.h
|
19e4e8d751478d34c05bc2d73e065429ed65a1c1 |
|
10-Jan-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Add support for trying alternate server (STUN 300 error message) on TCP BUG=3774 R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/32979004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8036 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/turnport.h
|
0ba1533fdbe4a098723da8262f1374d71c3a1806 |
|
10-Jan-2015 |
pthatcher@webrtc.org <pthatcher@webrtc.org> |
Added support for an Origin header in STUN messages. For WebRTC there are instances where it may be desirable to provide information to the STUN/TURN server about the website that initiated a peer connection. This modification allows an origin string to be included in the MediaConstraints object provided by the browser, which is then passed as a STUN header in communications with the server. A separate change will be submitted to the Chromium project that uses and is dependent on this change, implementing IETF draft http://tools.ietf.org/html/draft-johnston-tram-stun-origin-02 Originally a patch from skobalt@gmail.com. (https://webrtc-codereview.appspot.com/12839005/edit) R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/41409004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8035 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/turnport.h
|
332331fb01f8a316ac6d61cf4572478610fb3472 |
|
06-Nov-2014 |
pkasting@chromium.org <pkasting@chromium.org> |
Use uint16s for port numbers in webrtc/p2p/base. This is a necessary precursor to using uint16s for port numbers more consistently in Chromium code. This also makes some minor formatting changes in surrounding code (function declaration wrapping, virtual -> override). BUG=chromium:81439 TEST=none R=henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/32379004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7656 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/turnport.h
|
269fb4bc90b79bebbb8311da0110ccd6803fd0a8 |
|
28-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
move xmpp and p2p to webrtc Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p. Also makes libjingle use those version instead of the one in the talk folder. BUG=3379 Review URL: https://webrtc-codereview.appspot.com/26999004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7549 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/turnport.h
|
28100cb38896fe298b6df11ffd31838d9faf5b8a |
|
18-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Reverts r7459 "Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p." BUG=N/A TBR=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/29829004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7472 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/turnport.h
|
d1ba6d9cbfc44618d2c553ff7851948c730ae37b |
|
15-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p. BUG=3379 R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/27709005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7459 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/turnport.h
|