| 57e5fd2e604ff7e60425c3f7654b40da03fc763c |
|
25-May-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
PRESUBMIT: Improve PyLint check and add GN format check.
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).
Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.
Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py
TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.
R=henrika@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50069004
Cr-Commit-Position: refs/heads/master@{#9274}
/external/webrtc/webrtc/tools/barcode_tools/barcode_decoder.py
|
| cf9d364063dbf8e72f327177aaa99e8af32865f4 |
|
07-Jan-2014 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Now printing less output from compare_videos.py.
Alternative solution to the one in
https://codereview.chromium.org/114003006/.
I considered adding a verbose flag, but it needs to be passed through
like 5 functions, so I didn't think it was worth it for a function of
such speculative use.
BUG=chromium:327990
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5347 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/tools/barcode_tools/barcode_decoder.py
|
| 3260f109e3042809c5a67651bb7755f3adb34cf4 |
|
25-Nov-2013 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Made video quality toolchain more configurable.
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4139007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5171 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/tools/barcode_tools/barcode_decoder.py
|
| 8400246fcecc3515052faa66238036bc2aaaeac5 |
|
29-Jul-2013 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Improved error messages when binaries are missing. Also stderr = stdout now.
Now that these scripts are called from browser tests, we need to print everything on stdout since the tests will throw away stderr when invoking programs. I chose to assign sys.stderr to sys.stdout. Otherwise I would have missed stuff like parser.error, which print to stderr.
The error message will get improved because the old code did not catch the case when the binary was missing, which lead to a very confusing error when that was the case. This gets fixed now.
BUG=
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1886004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4416 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/tools/barcode_tools/barcode_decoder.py
|
| a6ff84503ed5a8ed799c12625759dee84f9b2d39 |
|
14-May-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add script for comparing video quality
This script makes it easier to run a simple command line
comparison between a captured YUV file and a reference video.
BUG=none
TEST=command line invocation
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1320007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4022 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/tools/barcode_tools/barcode_decoder.py
|
| 38ebf98c2a7ed1871f1e32087efddce81023eb20 |
|
08-Mar-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Refactor barcode decoder to use Zxing's C++ version
By using the C++ version of Zxing, we can avoid having Java and Ant
as a dependency when running Video quality analysis on the bots.
This makes it far more easy to setup automation on new machines.
I also moved the scripts into the webrtc/ folder so it will be synced by default when building in Chrome (eliminating the need of a separate solution).
This CL also removes the need of the FFMPEG_HOME variable and replaces
its use with a command line flag to make the tool run smoothly on
Windows.
BUG=none
TEST=locally running the script on Windows, Mac and Linux.
Review URL: https://webrtc-codereview.appspot.com/1099007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3640 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/tools/barcode_tools/barcode_decoder.py
|