| a5e165d3a9074c09b67df5a89aa26b153cf69562 |
|
08-Dec-2017 |
Mikhail Naganov <mnaganov@google.com> |
audiopolicy: Make fields of HwModule private
It's a good practice not to expose fields of the class.
Use getter / setter methods instead.
Test: compiles
Change-Id: I9d939d17fafdfff016a300d4f5a979bdc8414f2b
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 2478d528186436f693b02c3534f04425086b638c |
|
07-Dec-2017 |
Mikhail Naganov <mnaganov@google.com> |
audiopolicy: Use range for loops in managerdefinitions classes
Use "range for" loops where it improves readability.
Change-Id: I4fc0360956b7aa70b9e282b83f6bb371c05a8522
Test: compiles
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| d4120148e72b2352f19f74dd493e903992371ef9 |
|
07-Dec-2017 |
Mikhail Naganov <mnaganov@google.com> |
audiopolicy: Refactor HwModuleCollection
-- make AudioPolicyManager::mHwModules to only store
loaded modules; all modules stored in mHwModulesAll;
this removes lots of checks for HwModule::mHandle;
-- use "for range" loops when iterating over mHwModules;
-- use HwModulesCollection::getModuleFromName for finding
the remote submix module;
-- log statements print HwModule's name instead of index.
Test: audio still works
Change-Id: I2d86caae23e87e25b6a367cb4042741f0b32e99c
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 9ee0540d3a61bff03d561ca431a371c3d9335d2b |
|
14-Oct-2016 |
Mikhail Naganov <mnaganov@google.com> |
Remove last references to hardware/audio.h
DeviceHalInterface transitioned to "capabilities" model
(similar to the one already used by streams, e.g. 'supportsDrain').
No direct checking of the HAL version is needed.
AudioPolicy uses its own version read from the configuration,
and these values never checked against the actual HAL version,
thus it does not need versions and macroses from hardware/*.
Test: make & run on N6P
Change-Id: Ic4a56bfa19a9a61edac2b9f9a163fd8f63a0ff87
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| cbc8f617c1aebef5d041fa40dcd38a5466690b99 |
|
12-Oct-2016 |
Mikhail Naganov <mnaganov@google.com> |
Eliminate dependencies on hardware/audio.h (trivial cases)
frameworks/av must not depend on hardware/ (except for the code
from libaudiohal that actually calls into HAL).
This CL deals with simple cases where depending on system/audio.h
is enough.
Change-Id: Ia2cb66cc8c92316ce5ab884a008d5e531263c2e4
Test: make
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| e964d4e421e2d1ca937227a580c0c837091a11e3 |
|
09-Aug-2016 |
Chih-Hung Hsieh <chh@google.com> |
Fix clang-tidy warnings in audio and playerservice.
* Add explicit keyword to conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
Test: build with WITH_TIDY=1
Change-Id: I265f3b094e08d5705b506b3fbba51439c134af84
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 634b71478742310960f3fdb4241e70a0735712c4 |
|
20-Apr-2016 |
Eric Laurent <elaurent@google.com> |
audio policy: fix regression in getDeviceConnectionState().
Fix problem in DeviceVector() device search logic causing
failure to report connection of devices when no address is provided
(e.g when called from AudioManager.isBluetoothA2dpOn()).
Bug: 28286051
Change-Id: I7ca732e195d2ddcdc1a93b78aed21523b3461aa9
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| a13cde98a880341f0a56d91da6364b093fb5d24e |
|
29-Mar-2016 |
Glenn Kasten <gkasten@google.com> |
Use audio_module_handle_t and audio_patch_handle_t consistently
Bug: 27814144
Change-Id: I54b7a73ec318779fd3addb060998f4d94141152d
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| f7f85438503e6964aba3ddabd6228e7fefb36735 |
|
10-Mar-2016 |
Jean-Michel Trivi <jmtrivi@google.com> |
AudioPolicy: tighter match for device descriptor query
When querying a module for a device descriptor, the matching was
too "loose": if a device type and address was not found, a
match was returned for just the device. While this works for device
types where only one is connected to the system (e.g. wired headphones),
this is an improper behavior for devices such as REMOTE_SUBMIX where
multiple are "connected" to the DUT, but with different addresses.
Bug 27337358
Bug 27336527
Change-Id: I9b6464485da2bedde2d14b624133e02b5a3fa357
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 52d49a8a1f48c2d59769b9257e2eed988014aa03 |
|
28-Jan-2016 |
Eric Laurent <elaurent@google.com> |
audio policy: fix connected device address.
Also update the audio device address with the one passed by
setDeviceConnectionState() if the device is in the list of
declared devices but does not have an address set.
Change-Id: Ibe9008b0c96fc336a90646b98703ed238a6cf4a9
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| f4ad6e5637b6deccdac4b60615383f290b3806cf |
|
19-Nov-2015 |
François Gaffie <francois.gaffie@intel.com> |
Audio policy: implement configuration file in XML
This patch introduces configuration file of the policy in XML.
Legacy configuration file is used by default and
compilation flag USE_XML_AUDIO_POLICY_CONF must be defined to
use XML file format.
Change-Id: I352b788b5829d42ed82c851a4faef0e526be582e
Signed-off-by: François Gaffie <francois.gaffie@intel.com>
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| cbb3044d6bfa9ab30c83b67874f40344e29805e1 |
|
19-Nov-2015 |
François Gaffie <francois.gaffie@intel.com> |
audio policy: introduce audio route concept
As a preambule of introduction of topology concept within
audio policy configuration file, this patch introduces the notion
of audio route, i.e. a link between one sink and one or more sources.
This link may be shareable (mix) or mutual exclusive (mux).
From this route concept, and in order to keep backward compatibility,
the supported device of ioprofile (what will become AudioMixPort) must
be updated.
Change-Id: If078830dbe74b003be4a64c584521df481101294
Signed-off-by: François Gaffie <francois.gaffie@intel.com>
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 112b0af826aeca45855690b9c105b2cdf9938bbe |
|
19-Nov-2015 |
François Gaffie <francois.gaffie@intel.com> |
audio policy: introduction of AudioProfile
In order to be able to declare the possible sample
specifications for an Audio Port (a given format, a list of
sample rates, a list of channels), a new object AudioProfile is
introduced.
Change-Id: Ie3ca3400f05984e7b4132fc7ba90020eb4d998c7
Signed-off-by: François Gaffie <francois.gaffie@intel.com>
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 7b279bbc24139ee1e01b58055ca94926ec18e2e9 |
|
14-Dec-2015 |
Eric Laurent <elaurent@google.com> |
audio policy: remove compilation warnings
Change-Id: I4d41ca903dfbe37066ef20a13ebabaff1e5b7326
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 1d4481fb9cb1ea149f79f2a5d22110af84fbc90b |
|
19-Nov-2015 |
François Gaffie <francois.gaffie@intel.com> |
audio policy: clarify tag and name for device description
In preparation to introduction of topology within policy configuration
file, this patch clarifies the meaning of tag and name attributes of a
device.
Change-Id: I8db58be939823e87aa05b991e2afe0762eb741ca
Signed-off-by: François Gaffie <francois.gaffie@intel.com>
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| a8ecc2c72ca26389bd6b0162181d60aaeaca8149 |
|
09-Nov-2015 |
François Gaffie <francois.gaffie@intel.com> |
audio policy: remove deserialization from policy objects
This patch removes the responsability of the deserialization of all
objects managed by the policy by:
-adding required accessors
-moving deserialization function to Config parser helper
-adds a TypeConverter to associate string to / from values of all
audio enumeration shared between HALs and policy.
Change-Id: I1ce798848f4657b37e47446c9fbdc63f7ed0390e
Signed-off-by: François Gaffie <francois.gaffie@intel.com>
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 7288ab87a7aa730ffe97d7dc7e118123107bfcea |
|
07-May-2015 |
Eric Laurent <elaurent@google.com> |
audio policy: clarify use of mName field for audio devices
The audio port field mName was used for two different purposes
which caused a problem when exposing this information at the SDK API.
Create a new "mTag" field storing the audio_policy.conf device tag
if needed.
Field "mName" is now used to store any additional name associated to
a given device when available (e.g Manufacturer and model name for a USB device).
Change-Id: I17fa872e4a3a2e1b7cbb807c6f72e095a8a2c9c5
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 322b4d25387a04c9afebe998326d005bbdf17ede |
|
04-Apr-2015 |
Eric Laurent <elaurent@google.com> |
audio policy: fix unique audio port ID.
Remove mId member from AudioPort as it was shadowed
by mId in DeviceDescriptor.
Add getters for Id, and HW module name and version to device,
output and input descriptors.
Fix DeviceDescriptor name initialization.
Change-Id: I4a69f385e40330954d9dad5f2926c521f60b2ec1
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 887a9ed4446cb451181c392a0e51a69914e58fbf |
|
01-Apr-2015 |
Jean-Michel Trivi <jmtrivi@google.com> |
Updates to AudioPolicyManager refactor
Use protected access in AudioPolicyManager class for
- engine field
- querying phone state
- isStrategyActive
Fix inclusion of AudioPolicyManagerInterface header.
Use "APM_" prefix in audio policy conf parsing code to avoid
naming conflicts with some HALs.
DeviceDescriptor and its collection class are good friends now.
Change-Id: I236d62a2b8a4b6bf68dd515932650b912577c145
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 53615e29c99c5e9d2ca77aaefd7bf5c770513120 |
|
19-Mar-2015 |
François Gaffie <francois.gaffie@intel.com> |
Migrate helper functions from managerdefault to common
This patch moves from manager to common:
-parse helper functions of the policy configuration file
-collection helper function on
-output / input descriptors
-DeviceDescriptor
-AudioPatch / Audio Port
-IO Profile
-HwModule
Change-Id: If45e53418db75af1af198f43c4ef27884499055f
Signed-off-by: François Gaffie <francois.gaffie@intel.com>
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|
| 98cc191247388132b6fd8a4ecd07abd6e4c5a0ed |
|
18-Mar-2015 |
François Gaffie <francois.gaffie@intel.com> |
Split ManagerDefault into Manager and ManagerDefinitions
This patch splits the managerdefault into a manager and a manager
defintion library that contains all pillar elements of a policy manager.
It renames the file with the name of the main class they contains.
It splits the AudioPort into AudioPort and AudioPatch.
Change-Id: I992cf0b8aed895805cc003ba0980d2c9e92c985b
Signed-off-by: François Gaffie <francois.gaffie@intel.com>
/frameworks/av/services/audiopolicy/common/managerdefinitions/src/HwModule.cpp
|