2992cd084cd5cfd9ef253c37ef269d6c75e7e144 |
|
23-Aug-2017 |
Jack He <siyuanh@google.com> |
Fix checkstyle errors (2/2) * Manual style corrections with IDE assistance * Variable name refactors are done through IDE * Corrected general style errors such as: - "final private var" -> "private final var" - "&&", "+", "||" should not be at the end of line - Non-static private variable should be like "mVar" - Private static variable should be like "sVar" - Code file should always end with newline - Inherited methods should be annotated with @Override and no @hide tags - Public methods should always have a JavaDoc entry - "int[] array" is preferred over "int array[]" - private methods should be accessed without "this." when there is no name collisions. - "boolean ? true : false" -> boolean - "boolean ? false : true" -> !boolean - "boolean == true" OR "boolean != false" -> boolean - "boolean != true" OR "boolean == false" -> !boolean Bug: 63596319 Test: make checkbuild, no functional changes Change-Id: Iabdc2be912a32dd63a53213d175cf1bfef268ccd
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
a355e5efaf45a534ee6437aa4bae7d30f18c0ec2 |
|
23-Aug-2017 |
Jack He <siyuanh@google.com> |
Fix checkstyle errors (1/2) * Automatic style corrections through IDE Bug: 63596319 Test: make checkbuild, no manual changes, no functional changes Change-Id: I2397d55abc34c9b7a9b748bec6137778df3421a7
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
6b1f39502c7d5f71b42d82ac6d511ee0afd1191e |
|
09-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth: Fix interval low/min values Bug: 38175945 Test: none Change-Id: Idf487c7aafc518f2c57be78a1fa979b2c4a383d6
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
9d4abb5631c7719de8d919e0c37c9aee54354266 |
|
28-Apr-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth: bluetooth.le API fixes Fix minor spelling problems. Throw IllegalStateException instead of IllegalArgumentException in build(). Bug: 37532634 Test: none Change-Id: I73b6f04aec98f5baffb06a363e2a3f71e8cec3c4
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
9e377194e35c0fb9ac5771f5658c095ed97e0838 |
|
12-Apr-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth 5 PHY simplification Having PHY_LE_* constants defined in four different places, with one value being different than others is misleading. Leave just PHY_LE_* definitions in BluetoothDevice, and add PHY_LE*_MASK for the mask used in PHY update API. This patch also removes need to translate PHY value between PHY update request and event, as mask is used for request, and the value is returned in event. Bug: 30622771 Test: manual Change-Id: I897effa1204a024465d55501c83c542566c4d37c
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
010cc95583d6b93bdcc9cf7959f8470d109f8a3d |
|
06-Apr-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth 5 fix default AdvertisingSetParameters values Having advertiser be scannable and connectable by default is a bad choice for new advertising set. Bug: 30622771 Test: sl4a Bt5ScanTest Change-Id: I4fc270e78ca4e62d3077c5cd28aa59b0518d2e77
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
f4ed33f5fa6ffa3bda6faff773a3fb90b16a760c |
|
30-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth LE Advertising minor improvements This patch adds some additional error checking for the advertising set parameters, and some more comments. Test: manual Bug: 30622771 Change-Id: I87bd44f4179ef63694ad3ed656dc2acc52e40f1e
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
e7f89b07e6fa3a99877af3298c2a80db23a591d7 |
|
23-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth: fix comment wording Test: manual Bug: 30622771 Change-Id: I5a589c98553f35248b0d95d332e9f35774075b24
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
08ed924d8922eec0555f6a860d80e6e2770c8a2d |
|
23-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth API spelling fixes ("wether" -> "whether") Bug: 30622771 Test: manual Change-Id: I01c8b18d0057f2fd6e477ce2ca0b779321b6c0e6
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
d12b5688f06b0f3428730262cf208713442f6f5b |
|
20-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Add setScannable to AdvertisingSetParameters (1/2) There must be a proper way to specify if advertisment is scannable, when updating the parameters. Test: manual Bug: 30622771 Change-Id: Ie520609d3fff07ccc2960015c19311d773842852
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
adbf2eef2fda68a5c3acc78a67e5dda00d8a14d7 |
|
17-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth 5 move timeout parameter (1/2) Timeout is not a parameter, it is a property of enabling the advertising. Move it into more proper place. Test: manual Bug: 30622771 Change-Id: I09ebc6c770bc02938ea16a9738a7e03dc8006fde
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
bc2991e8665d2f2484e24b7e9f72b18c3c740ae1 |
|
11-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth 5 spelling fixes Bug: 30622771 Test: manual Change-Id: I46b6486619cc7366e56b25ca48937e6792f53e1d (cherry picked from commit 53501ad210dd5c65c7910a6b75b2b481e92dd22f)
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|
a9d1a32e5e51ebc3c141370c9d5045c6c938aaf9 |
|
10-Jan-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth 5 Advertising API Test: manual Bug: 30622771 Change-Id: Id6856e6110872ec50ff1af54ddc75c0104a6459c (cherry picked from commit 5324a14cf490656269ef862d7f8f6b139a21c0e6)
/frameworks/base/core/java/android/bluetooth/le/AdvertisingSetParameters.java
|