| 1a1b0464cb43903ed540f4c43fd423b16e398c04 |
|
12-Jan-2018 |
Bookatz <bookatz@google.com> |
Statsd and frameworks reference proto enums
For frameworks constants that don't have intrinsic meaning (i.e. their actual
value and order don't matter), so that it is unlikely that their values
will be changed:
This cl introduces proto enums representing some constants found in
the Android codebase, and connects the two.
By using the Proto enum as the source-of-truth, it means that Java and
proto can be kept in sync. Otherwise, when the Java frameworks code
changes, it silently breaks the protos from working properly, since the enums
are wrong. By having the Java code reference the proto enums, it ensures
that everything is in sync. The values of the constants are unchanged.
But future changes to these constants will need to be done in the proto
file, which the Java file merely references.
The protos are necessary for incidentd and statsd and, in the future,
possibly dumpsys. In this way, the logging mechanism is much less likely
to get broken when new constants are added, and we can be ensured that
the logging accurately reflects the underlying codebase.
Bug: 69478930
Test: cts-tradefed run cts-dev -m CtsStatsdHostTestCases
Test: cts-tradefed run cts-dev -m CtsIncidentHostTestCases
Change-Id: If79032c34b2799db1e3e70cb47b1312fd72092b9
/frameworks/base/core/proto/android/service/battery.proto
|
| 1ad1b77270744748bf113819fef6c6c9cfc60328 |
|
23-Jan-2018 |
Kweku Adams <kwekua@google.com> |
Adding privacy tags to battery-related protos.
Bug: 72393215
Test: Android builds
Change-Id: Iaa41aaf4ed931610f990ea96f4e21510171b6ac4
/frameworks/base/core/proto/android/service/battery.proto
|
| f871231aee7f6d820bcfeda64e561e7c47c8bb55 |
|
29-Nov-2017 |
Kweku Adams <kwekua@google.com> |
Adding comments to BatteryServiceDumpProto.
BUG: 65750806
Test: N/A...just comments
Change-Id: Idffa959ec502d34255321b0669e80db163eec784
/frameworks/base/core/proto/android/service/battery.proto
|
| e6b00c2a1698386dcc26f1b152e7e4b2393c4238 |
|
24-Oct-2017 |
Kweku Adams <kwekua@google.com> |
incidentd: Updating PowerManagerService proto files.
Moving to the proto/.../server directory since PowerManagerService is in
com.android.server.
Extracting enums from other components into their own files.
Bug: 65750826
Bug: 65750806
Test: flash device and check incident.proto output
Change-Id: Ib91b7c08142fa66adf18b6e85106d4cbb5adf660
/frameworks/base/core/proto/android/service/battery.proto
|
| c7f93070b6a5c8c12afcb77eb4e95c3018e1729f |
|
30-Sep-2017 |
Yi Jin <jinyithu@google.com> |
Convert proto3 to proto2 to avoid forced zero enum value.
The rationale for this change:
1. When defining enum values for platform, we want to use the current
integers, in some cases zero is not defined, but proto3 enforces a zero
default value.
2. Android Metrics Team uses proto2 on server-side
3. When copying .proto to server-side, the known issue of dropping
unknown fields might affect if using proto3
4. Not much benefits from using proto3
Bug: 67110257
Test: manully generate incident report and it looks normal
Change-Id: Ia63e39de549a46683e9f80fcb74f1d771782b7f4
/frameworks/base/core/proto/android/service/battery.proto
|
| e2a3cd8f6944250348f4e346b7bdead4b0b5c8dc |
|
27-Jan-2017 |
Netta P <nettap@google.com> |
Protobufferize BatteryManager dumpsys
Bug: 34227623
Test: cts-tradefed run cts-dev -t CtsIncidentHostTestCases
Change-Id: I6e36d725c50105ad1f6f86f890db49ea253907c0
/frameworks/base/core/proto/android/service/battery.proto
|