History log of /frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
92a2613353cec71ea390234414ffb8f95a5df01a 06-Feb-2018 Fan Zhang <zhfan@google.com> Use framework onNavigateUp() instead of simply finish().

- Simply finishing activity bypasses the entire nav-up chain, making
taskAffinity/parentActivity defined in androidmanifest.xml no-op, which
is bad.

- Also removed showMenu() logic, this is from drawer era and was only
needed by mobile settings. We no longer need drawer so this method can
be removed.

Bug: 72337421
Test: atest

Change-Id: Idee1b72751363b5162887a799197404a9498c83e
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
f5e032b116fb6b91f6e7d3a69a7f2067f416dcd3 06-Jul-2017 Fan Zhang <zhfan@google.com> Return result when set tile enabled/disabled

Bug: 63149109
Test: settings robotest in same topic
Change-Id: I5cd346e9acef52412508bc29c24f9fd82100559a
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
34106dd9e4831dee0b42b1f6dd8301aba794508f 21-Apr-2017 Fan Zhang <zhfan@google.com> Fix SettingsDrawerActivityTest on fugu.

Change-Id: I98d69e7ab96a1dbb81673dcc67ec36ac05ce9a6a
Fix: 37222268
Test: runtest --path tests/integ/src/com/android/settingslib/drawer/SettingsDrawerActivityTest.java
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
51fac1237d3e072f6c3725afac1f11effacbfd1d 17-Mar-2017 Fan Zhang <zhfan@google.com> Code clean up: remove some dead code.

Test: existing tests pass
Change-Id: I1e0e6f8218b3a6550476fe1aa092f685d7433d53
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
f1c1bb49f8d9d57b0138dbd4358e32f9ecff87de 28-Feb-2017 Fan Zhang <zhfan@google.com> Remove drawer code from settings

Change-Id: I3e9920f62745f6ba2236e37689f7603f9a30d6a9
Fix: 35809663
Test: make RunSettingsLibRoboTests
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
5ba2d3fef993987e1d5760c29c715f63970fee53 22-Feb-2017 Fan Zhang <zhfan@google.com> Disable settings nav drawer entirely.

Change-Id: I3e9bdd3759a47fc09a654b6dad00b611138d5de6
Fix: 34806148
Test: make RunSettingsLibRoboTests
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
f8eb6644922eade340746fd780a339215d0e45e6 13-Feb-2017 Fan Zhang <zhfan@google.com> Deprecate openTile method.

We no longer have tile drawer. Deprecatign this will make logging easier.

Bug: 30137094
Test: RunSettingsLibTests
Change-Id: I19777ede597e9db57b7c27b1850c39f9e2a61aa7
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
d2d3e2cce82aed190009a1467381f18f8b8af83f 06-Jan-2017 Fan Zhang <zhfan@google.com> Move category refresh call into a separeate method.

By default we no longer refresh category with each setTileEnabled.
Instead app will call update after all setTileEnabled are called.

This saves a lot of async task execution when Settings app starts

Bug: 34103984
Test: RunSettingsRoboTest (no regresssion)
Change-Id: I71ddcdb3e1fc0df6cacb53583a4f7e8ae8d675f1
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
0a454c39cb5bc03cd646546aa3b8baaed1962178 06-Jan-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Only parse new IA category when needed."
8bfb3eac9418708130e9b13f30719d59a045e279 05-Jan-2017 Fan Zhang <zhfan@google.com> Only parse new IA category when needed.

Bug: 34103984
Test: RunSettingsLibRoboTests
Change-Id: I66dd023dc119e06fded9409f03fb8e12200857db
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
9db32f35fbd16973efc7de4c48b7b7dbfcbb1076 16-Dec-2016 Fan Zhang <zhfan@google.com> Add Theme and ThemeOverride for new Settings

Bug: 33558692
Test: visual inspection

The new action bar theme has
- light background
- colorAccent as textColorPrimary
- no elevation

Change-Id: I4c1b88410701a35b0e2305d9162ba448d1f5d67b
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
8f06ab0774d44c49fbb5b122b7266192c49271c0 08-Dec-2016 roger xue <rogerxue@google.com> making changes to settingsLib so we can create car setting using settingsLib

Test: make -j40 RunSettingsLibRoboTests

Change-Id: I4eff074ebbbf1d4a4325580d68a2123d3f5ff930
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
cf439c0e802e159c0162909fc10074751b515a2d 03-Jan-2017 Fan Zhang <zhfan@google.com> Disable nav drawer in Settings app.

Bug: 34054123
Test: runtest --path frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/drawer/SettingsDrawerActivityTest.java
Change-Id: Ia6ae42315c3d1798803b9554aa8400aafa2f31fa
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
11b650722029e480b33399ac808ea2ceaed788f4 01-Nov-2016 Fan Zhang <zhfan@google.com> Move checking tile user logic into ProfileSelectDialog.

Bug: 32470791
Test: make & run SettingsLibTests
Change-Id: I46342b96f030469502e890301d322cccd7f8032d
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
5adc26695fb4282125d4b6b641e04820a028d87b 05-Oct-2016 Fan Zhang <zhfan@google.com> Do not clear category tile cache in every reload.

Bug: 31781480
Test: manual

The cache is useful when setting summary text on tiles. If tile cache is
cleared and rebuilt, summaryloader won't find existing tile to update
summary.

The cache should only be cleared when entire resource config changes,
tracked by InterestingConfigChnages.

Change-Id: I3afcaba30b835f59ffaad9c27564f0345af00d66
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
c8a5b790fa13826b21aee97ed5d1960d785333da 04-Oct-2016 Fan Zhang <zhfan@google.com> Refresh dashboard category data when package changes.

Category needs to refresh when package information changes. So
CategoryUpdateTask should not early exit by just checking config
changes.

This is needed to refresh UI when user enables activity such as
developement options.

Also made CategoryManager thread safe because it's called in both UI
thread and asynctasks

Bug: 31781480
Test: manual

Change-Id: Idcdcd39f727aba423350f3874af5612474e24e28
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
22a56d775d047a1926f2a6d9c855c802d561d487 28-Sep-2016 Fan Zhang <zhfan@google.com> Add a component to load category/tiles by key.

And switch between using SettingDrawerActivity.getDashboardCategories()
and the new CategoryManager in different conditions.

Test: SettingsRoboTests for regression. Will write tests for new feature
soon once we are set on the data structure.
Bug: 31781480

Change-Id: I864e5aea869071df63ca89002fb378c235d0a1fe
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
4bb0e11326d711a283bc11fc84fe4b5b5f0e97db 17-Sep-2016 Fan Zhang <zhfan@google.com> Show hamburger menu if the activity is top level setting. am: f311b74b8f am: b785de5c57
am: 108fee24aa

Change-Id: If1162835aab5ef068ddd40e7aeeac49da9ac4324
f311b74b8fd1e391f62bac39842328dc8e6a6014 16-Sep-2016 Fan Zhang <zhfan@google.com> Show hamburger menu if the activity is top level setting.

Bug: 27584874
Test: manual inspection (automated test coming later)

This makes it possible to show menu icon when top level setting activity
is open from outside of Settings (eg, quick setting tiles)

Change-Id: Ic8e755f43b3f6a92118657741b37e09dbc2b53d0
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
57f096b1f361e5973753dbe7e033ee38585bc8e7 16-Sep-2016 Lei Yu <jackqdyulei@google.com> Merge "Add userhandle testcases in SettingsDrawerActivity."
8accac9e9ea48c52625c65f4cd7187d5599f1f0a 14-Sep-2016 jackqdyulei <jackqdyulei@google.com> Add userhandle testcases in SettingsDrawerActivity.

Bug: 31398277
Test: make SettingsLibTests

Change-Id: I66d28562dd881eaeb7741b945b7e7f3df710822c
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
089a2c059df7cc41621ead61711fa25e53a38802 15-Sep-2016 Fan Zhang <zhfan@google.com> Control logging using the right flag.

Test: manually ran settings app and monitored logcat
Change-Id: I918cb1f5f2e34356df26e4810fc0f690304f13a3
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
dfc6ce5d9523eaeb6a409814a8666bf7a6153164 24-Aug-2016 jackqdyulei <jackqdyulei@google.com> Remove the deleted userhanle in cache to stop crashing.

Because the user handles are not up-to-date, we need to update it when
necessary.

Bug: 30919785
Test: This branch doesn't support robo test, testcases will be added in
master branch when merged down(ag/1419729)

Change-Id: Ia095c3946c49db239e0b1b2bcc8588b02158c036
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
c10db985f399a3257a5dcfa80c3388e8b8ee3db4 11-Aug-2016 Fan Zhang <zhfan@google.com> Update navup button content description when it's menu.

Bug: 30090247
Change-Id: I2ff9529a3dd5f197f2d142ef2993d5d8e90b5645
(cherry picked from commit df915bbbb9d97bdb10185a5b0280ffa0b9582694)
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
354c9ff3d5b3a1270761e1df8e272de58944fdc0 15-Jun-2016 Richard Ho <horichard@google.com> Merge \"added null check in doInBackground and if null, properly intializes variables.\" into nyc-dev
am: 07a375186e

Change-Id: Icd7c52967c634dbdbef55166523039f4004e4d9a
8c4e4b0865dada1f89c72b8abd44229df44a3250 14-Jun-2016 Richard Ho <horichard@google.com> added null check in doInBackground and if null, properly intializes
variables.

Bug:29234237
Change-Id: I1d65b1a232c71efdd11a917769aec5044867a085
(cherry picked from commit 0f0f5414f4860de7f5e98d783b3172a39a42df2f)
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
76b1217b9aaefb2b997e84e6b4fcd7aeb844c6c5 08-Jun-2016 Jason Monk <jmonk@google.com> Merge \"Settings: Better handling for disabled tiles\" into nyc-dev
am: 27eadb6f1d

Change-Id: Iaf1558df689ba4ea033b081ba1c24b5d45d7e36c
fcad09a777353d24fe38ba054c0e1007d3eeb2f4 07-Jun-2016 Jason Monk <jmonk@google.com> Settings: Better handling for disabled tiles

Push disabling into SettingsDrawerActivity and add a blacklist to
make sure they disappear immediately.

Change-Id: I79b9c596373cf9634008f6be88f4808af70eb071
Fixes: 29080209
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
be6c44823bc29a275539b5fd3876994e73a78f94 04-May-2016 Hyunyoung Song <hyunyoungs@google.com> Add Shortcut API to Settings (1/2)
b/28298258

Initial CL to simply add first time shortcuts in the beginning.

Change-Id: Ib64e3cf1b17979da1548c168cd551ae125289132
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
9c3cebf7291a9e88d1bfb6815d5fec18e0125e68 29-Apr-2016 Clara Bayarri <clarabayarri@google.com> Merge "Make EXTRA_SHOW_MENU visible to Settings so StorageSettings can use it" into nyc-dev
am: 88545ce446

* commit '88545ce4463939b90be1e5141b1dc3c1994fa35d':
Make EXTRA_SHOW_MENU visible to Settings so StorageSettings can use it

Change-Id: I6738c82f8e390596b267782e5e8d872041b5c089
962694db3834b20a10e7d7756470b389f418c8d8 29-Apr-2016 Clara Bayarri <clarabayarri@google.com> Make EXTRA_SHOW_MENU visible to Settings so StorageSettings can use it

Bug: 28197210
Change-Id: I798a891b1de9777f652a46c1d938e23c0c62f783
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
7163d771088906d1beb8a9503175b4cc708ace4c 29-Mar-2016 Fan Zhang <zhfan@google.com> Allow fragments set their own header view below actionbar.

Bug: 27751187
Bug: 28269035
Change-Id: Iac081c009800a71afe413cf63ddd9788b2e90d6a
(cherry picked from commit ff2e0f4be8d0085f6db2315bcf184eccdbb69554)
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
b0ae8f820927fc6c039b4e4efd6d3f15c1a6a141 12-Apr-2016 Jason Monk <jmonk@google.com> Settings dashboard performance work

- Allow rebuilding apps not in the foreground
- Allow rebuilding apps without a comparator
- Initially apply current configuration so we don't immediately clear
tile cache

Change-Id: I8d57f7e8f7fa119915bf6fdc8ece8bee976edbdc
Fixes: 26541310
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
4ea6657d587f0e06a335b9faf355e222d7cbd385 30-Mar-2016 Jason Monk <jmonk@google.com> Clear out old views when setting new content in settings

Bug: 27529989
Change-Id: Id44ca442c2117bc5df7929bcd79434c0ae23cded
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
68dab67de2d9d254f5e71b6b8912f3c940eda1fd 29-Mar-2016 Udam Saini <udam@google.com> Calling setIsDrawerPresent(false) twice causes a crash.

We should only call setDrawerLockMode(...) if mDrawerLayout isn't
null.

bug:26288300
Change-Id: I8a1b77e03414360f9cd7e3fa6e6c98ef0e139ebf
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
ec02e471a628f8b893a629d0d6116712290f828e 28-Mar-2016 Jason Monk <jmonk@google.com> Make sure settings tiles pick up locale changes

Bug: 27727312
Change-Id: Ic54437805bb264dd8e569ac38673c5ee36b2378a
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
14ee8d7e17b179f7ae1d109adb9d7bd5fc15b97f 16-Mar-2016 Jason Monk <jmonk@google.com> Fix Settings home lifecycle

Bug: 26268813
Bug: 27330440
Change-Id: I6f5ab4a412b129728db3e8dff134c04272909997
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
9cf94182fce16a7de28369263b5ced06a989f71e 03-Mar-2016 Udam Saini <udam@google.com> Merge "Only adds translucent status bar according to theme values." into nyc-dev
48987f65df7825b18bb16d2135d267d090c8a6fb 03-Mar-2016 Udam Saini <udam@google.com> Only adds translucent status bar according to theme values.

On SUW screens, we do not want to add a translucent status bar. This
also affects ime insets when keyboards are shown.

bug:27479424
bug:27063940
Change-Id: Ic339a9d931f6580a9af8deea85ec5e5bb60f6cca
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
6bea950bfae14380959203b447bd870569061e4a 25-Feb-2016 Jason Monk <jmonk@google.com> Guard against monkey crash

Bug: 27337783
Change-Id: Ifa1538a0a0521789a516f8cdbc0615a057611ce7
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
cafda1f90ebf79ec3a56d43d8d3c0d63c9d84cb2 05-Feb-2016 Jason Monk <jmonk@google.com> Settings drawer work

- Final visuals
- Show under status bar
- Fix activity flow surrounding drawer use

Change-Id: I161702219c26cabc6b2d1adbaa6fbfb1d9fd5b07
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
fb695c633cb57de8746e624fc62127a0a7fa6ec7 02-Feb-2016 Anna Galusza <agalusza@google.com> Fix breakage due to incomplete name change.

Change-Id: Ief02bd4a994a4ff3a571fedfead05c732043500d
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
1774a27b8405146153aba9a6f1c6427a072d458c 02-Feb-2016 Anna Galusza <agalusza@google.com> Allow the drawer to not be shown.

Change-Id: If616c6b801382c307fa7db85bed02a4b8cae6ea5
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
946483a69e55b661c42e1976f4c70dabff9df89a 22-Jan-2016 Jason Monk <jmonk@google.com> Only show settings drawer on top level items

Bug: 26080590
Change-Id: Id8d387492e2e1e09fc87f4123bf7c399a2c1380e
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
f509d7e65a062957be86619b3cb894e99268c4ae 07-Jan-2016 Jason Monk <jmonk@google.com> Add suggestions parsing to SettingsLib

Add a parser that will parse an XML of the suggestion categories
and ordering and query those categories into Tiles.

Change-Id: I3154c94e176108358163bbe36feb48e889fe00d1
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
2a5d79aa6fd882ef6f46439f5156c516f173f06a 03-Dec-2015 Jason Monk <jmonk@google.com> Fix crashes in Settings + SUW

Bug: 25981625
Bug: 25989520
Bug: 25987331
Change-Id: Ib53c99edf45bb4550bfb9761ed09ca3677068591
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
e79790b26803ee338b2fdc3404344094d7f94476 02-Dec-2015 Jason Monk <jmonk@google.com> Speed up setting launch

Try to avoid too many calls to the PM and cache the info we get
from it to avoid too much stuff during settings launch.

Change-Id: I64132cbe47cf8eac6080c8c82583b0b5eeb75a28
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
3175a6e395e870c9ab5f291ed7d5edb8f802e218 30-Nov-2015 Jason Monk <jmonk@google.com> Guard against monkey crash

Bug: 25795998
Change-Id: I351faae1e29d09b7577435207ec466a1ff5ed237
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
f18a55da5a757199090a96439e9d12ca6b5f7f80 12-Nov-2015 Jason Monk <jmonk@google.com> SettingsLib Drawer: Listen to theme about actionbar

Show it or not based on windowNoTitle.

Bug: 25567755
Change-Id: Ie1a6b79eb87dcc101bd76785df7c5330acc54603
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
51a942380ba15f83393922203e7e9aebe64e8deb 04-Nov-2015 Jason Monk <jmonk@google.com> Updates to Drawer

Support doing nothing on tvs and watches. Also better not doing
anything with no categories existing.

Change-Id: I4a12d4d907a08e75ed3cdcd3f7c68a3a100c687d
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
0d72d20c2f2a3c5c98a73e97914e96a82b04eff8 04-Nov-2015 Jason Monk <jmonk@google.com> Settings Drawer: Handle multi-profile/user correctly

Change-Id: Ibef3cb38325415d514dc86fcd4ce7b95825361f8
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java
744b63632a0d41eabf60e95a7b61e235e43f6d07 04-Nov-2015 Jason Monk <jmonk@google.com> First pass at drawer support for SettingsLib

Change-Id: I9669bd511dd3c4b7f59b8600a5af65d9837af015
/frameworks/base/packages/SettingsLib/src/com/android/settingslib/drawer/SettingsDrawerActivity.java