History log of /frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
6dceace0eddd08156e6b71c17e3de4ed5f4f2f41 16-May-2018 Jason Monk <jmonk@google.com> Reduce usages of main looper in sysui tests

Push over to a standard testable looper, and a testable looper +
setAsMain when needed.

Also make tests more synchronous and single threaded as possible.
This will make them more deterministic and speeds them up noticeably.

Test: runtest systemui
Bug: 79550837
Change-Id: Iab0eb794329d7b1de95aef904ec08ecae7dadc98
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
4fbeac438109a9866fb49117c1d51e88d0100772 30-Apr-2018 shawnlin <shawnlin@google.com> Fix incorrect icon alignment on shelf

ExpandableNotificationRow set the scrollX of notification icon in shelf while the notification is
swiped, but didn't set it back when reset without animation(ex: screen
off device).

Reset the scrollX of icon in shelf.

Test: runtest systemui
Change-Id: I05a428a7502de1618a7929b71a832c9e945a6aff
Fixes: 77569193
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
63411fc9f3fe35ccf4256f123f4f4ec915c44c44 29-Mar-2018 Rohan Shah <shahrk@google.com> [Notif] Dont show blocking helper for non-blockable notifs

If the notification is considered non-blockable, we don't want to show
it. Moved necessary logic around into the appropriate classes (minor
refactor).

Cached system info (IPC) in ExpandableNotifRow instead of calling so
late in the game.

Updated tests & added nonblocking checks.

Change-Id: Ic010a0b32cf6df42e9d0d2c600cbbe95a68ffde2
Bug: 74115090
Test: atest {notif tests}
Test: Visually via debug flag on sys notif
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
524cf7b68df47b39509cee59523458efb7611210 15-Mar-2018 Rohan Shah <shahrk@google.com> [Notif] Add Blocking helper to swipe

Implemented blocking helper UI as part of guts - the
ExpandableNotificationRow that's swiped away is effectively detached
from the notification logic but kept in as a view in the layout (it'll
still show up when looping through the normal view hierarchy). We
purposefully open up NotificationInfo with the intent of showing it as
the blocking helper.

It's animated away/closed when the user interacts with any other content
or swipes away, as with guts (Can be changed in the future if we want it
to stick around for longer).

KIs, that will be tracked in bugs once CL is in:
- Swiping a notification if it's partially hidden by the shelf does not
bring it up into focus
- If only one notification is showing, the shade auto-closes as if it
didn't have any notifications (which it technically doesn't)
- Animation on multiple blocking helper shows cuts too early and doesn't
allow the notification to transition out
- Long press on notification dismisses (it should probably ignore it)
- Metrics are still missing
- Accessibility needs a runthrough

Bug: 63095540,73783854
Test: Visually & Ran all tests
Change-Id: Iaa5e3d5537bbb72c946fdd7ee35b155e22ca2b05
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
c6990a019f90149a8033d0ee09224bf1bad037f5 24-Mar-2018 Rohan Shah <shahrk@google.com> [Notif] Disable long click listener after dismiss

Fix for blocking helper - disable long click after the main notification
has been dismissed, in preparation for the blocking helper (which can't
be long pressed)

Test: Visually
Change-Id: I78795df4e77cb8d51382c1103bfa4ce02c1a11f3
Fixes: 76227576
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
8875de1d0837ebaa5aabe9230e07ac3e6c23ba53 22-Mar-2018 Selim Cinek <cinek@google.com> Fixed an issue where the roundness of a notification could be wrong

When animating away a heads-up, there was no listener in place and
if the view in question wasn't the first notification, it's
roundness could be wrong.

Change-Id: I0676ee18c9fb0c52b190b82b8b9adfa63d584262
Fixes: 76147670
Test: runtest systemUI
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
b586745d86a7335901646da128ef296e80ba0a22 28-Feb-2018 Julia Reynolds <juliacr@google.com> Show app ops guts when tap app ops icons

Test: runtest systemui
Bug: 64085448
Change-Id: Ia51044f77311ab705ffb9dd1ae204d0131316396
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
fc64001126c62581447b4b0e9c843d60af5c14c6 21-Feb-2018 Julia Reynolds <juliacr@google.com> Tag foreground notis that use certain services

- Draw over other apps
- Camera
- Microphone

The icons are not yet clickable, and the system 'drawing over
other apps' notification still appears even when the app's
notification is tagged.

Test: runtest systemui
Bug: 64085448
Change-Id: Ib3b0cdd9adced82f562f256cb81af80dc395440d
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
0b9cf469add55f62bd12dc8ed88a9773a22e4145 08-Dec-2017 Selim Cinek <cinek@google.com> Fixed an issue where the statusbar wouldn't expand properly

Because we were measuring the notification in the wrong state,
the contentheight could be wrong. This should fix several other
issues related to redaction.

Change-Id: I15f2cb6b7c2880b0771db67360c24431b8471e0d
Fixes: 69927267
Test: Unlock lockscreen, drag down quickly with fingerprint, normal display
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
cecc7c233a298f533f28ce7e2792026b3427680e 13-Sep-2017 Lucas Dupin <dupin@google.com> Do not play sounds when unlocking from AoD.

Playing tap target sounds when unlocking from AoD
make them overlap. Let's skip taps and only play
the "unlock" sound.

Change-Id: I381e13604c61938ceceac903a8e2a52bf9192bbe
Fixes: 64411995
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
c429f690e54db1bdc4631aab7c0191e30ccf1d51 27-Jun-2017 Jason Monk <jmonk@google.com> Add system to avoid a crash stopping tests from running

Add a system such that when a crash happens on the main thread, it is
delayed until the tests complete, then thrown.

Also mark some old flaky tests as not flaky as they should be good
now.

Test: runtest systemui
Change-Id: Ic18a38daf4a93dab63549d834fa00f295644fbf1
Fixes: 62935720, 62251903, 62529569
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
a27856d443ce65271aa16ea22a7b413e9dd9c664 08-Jun-2017 Ian Pedowitz <ijpedowitz@google.com> resolve merge conflicts of 695f21a66189 to oc-dr1-dev

Test: I solemnly swear I tested this conflict resolution.
Change-Id: Ifeffa55c7fb80b0f327ecc5b50cefeca9db6457b
Merged-In: I558447f282bb54f13be1622c3f2528a383fbc3b7
a7c69637f8fa7cc8c0e7ac7c4d73659730315841 08-Jun-2017 Selim Cinek <cinek@google.com> Fixed an issue where the icons had the wrong color

The color of the icons was taken from the ambient view
and wasn't updated when dark changed.

Change-Id: I472e76ff9d4d92500faae5517f10bdeb2658936d
Fixes: 62423352
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
5cf1d0589a0045ee5f01802975f394847e891215 02-Jun-2017 Selim Cinek <cinek@google.com> Fixed an issue where the qs panel wasn't properly placed

The QS panel should only be placed below the notifications
if it has notifications above the shelf. This ensures that
all animations including icons are appearing in the right
place.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/AboveShelfObserverTest.java
Fixes: 35305470
Change-Id: I97fb0c76ed69b7638ce83a7c06856d87bf6bf65f
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
6abac008700c38ad43d4dba6b67ee72afcb6482d 06-Jun-2017 Lucas Dupin <dupin@google.com> Merge "Fix icon tint on notification shelf" into oc-dev am: 285ad4ce66
am: 6b5b7c4d31

Change-Id: I286f4e0881d225a859f465e37a60944fb4427828
b6ed63b5670e64c853ad69bc2262c6ea88535f5d 31-May-2017 Lucas Dupin <dupin@google.com> Fix icon tint on notification shelf

Public layout icon color wasn't being propagated correctly.

Change-Id: I6396e8dc5a9a18f614afd0e184c99c6d799151cb
Fixes: 38371661
Test: runtest -x tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
25a52b65b2cac1f49f37f4532cfa62282432957a 23-May-2017 Jason Monk <jmonk@google.com> Add test to verify all sysui tests extend the right stuff

And then make it pass.

Test: runtest systemui
Fixes: 38500852
Change-Id: I377164219e4a4f4d1a99f11ef06da03c2b527eb0
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
e736807efddf27a4d2bf462f1923078ed0a7b6b6 25-May-2017 Selim Cinek <cinek@google.com> Merge "Fixed an issue where groups could stay userlocked" into oc-dev
91f41cea2e34f1a363e460627c82918da4826d5e 24-May-2017 Selim Cinek <cinek@google.com> Fixed an issue where groups could stay userlocked

It also fixes an issue where the reinflation wasn't
working properly.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Merged-In: If359256a3ac0c574260b5ff5af3fc2042e1dce9a
Change-Id: If359256a3ac0c574260b5ff5af3fc2042e1dce9a
Fixes: 36469584
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
817abe7ebbedf5d84e485a15addf626d6d065773 24-May-2017 Selim Cinek <cinek@google.com> Fixed an issue where groups could stay userlocked

It also fixes an issue where the reinflation wasn't
working properly.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Change-Id: If359256a3ac0c574260b5ff5af3fc2042e1dce9a
Fixes: 36469584
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
dc0a407de73934117292307e36f470d1854309da 24-May-2017 Geoffrey Pitsch <gpitsch@google.com> resolve merge conflicts of a5e114333110 to master

Test: runtest systemui
Change-Id: I898b2467474e029cdaba0f9d21fe8fa70dd45318
70950def80d1aa5938c104e125635e0d42933ba7 23-May-2017 Geoffrey Pitsch <gpitsch@google.com> Change Ignores to FlakyTest so we can check if they're fixed

Test: runtest systemui
Bug: 38500852
Change-Id: I84fd8178086dbd4e35c72e7ef2780248a00791e8
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
fba8faf5c5f58f115fa3c099da9ef0953b484147 23-May-2017 Jason Monk <jmonk@google.com> Add test to verify all sysui tests extend the right stuff

And then make it pass.

Test: runtest systemui
Bug: 38500852
Change-Id: I377164219e4a4f4d1a99f11ef06da03c2b527eb0
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
351a321371c307e92ee73ea6d179de41518d1ef3 22-May-2017 Geoffrey Pitsch <gpitsch@google.com> Ignore a bunch of systemui tests until flakes are found

Test: runtest systemui
Bug: 38500852
Change-Id: I54f0e868bd9432758ff21a344631b6888bc83a4b
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
2630dc7ecf16a965321cfc615104f372cd2b0e96 21-Apr-2017 Selim Cinek <cinek@google.com> Moved notification builder creation to the background

In preparation of future colorization work, the creation
of the notification builder is moved to the background.

Test: manual, add notifications, update them etc.
Test: runtest systemui
Bug: 36561228
Merged-In: Iaec5febf4d8d9da348d77e0d4f6f61b9746fae16
Change-Id: Iaec5febf4d8d9da348d77e0d4f6f61b9746fae16
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
6fd06b5b8089952a7fa6e3286d246ab910090b79 08-Mar-2017 Selim Cinek <cinek@google.com> Fixed a bug where the low-priority header wasn't cleared

For notification groups, the header could not be removed
properly leading to overlapping text.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/stack/NotificationChildrenContainerTest.java
Change-Id: I6823a6137655e9266e46eb33dc33c0ceaee1f45c
Fixes: 36006673
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
1826d98381cd69fd4fdcf6ad527fec8ece22ec26 07-Mar-2017 Selim Cinek <cinek@google.com> Fixes an issue where the notification header could be invisible

It's not actually necessary to set the visibility of the notification header
since it is actually in the ChildrenContainer which already handles the visiblity.
This existed from legacy times where it was outside of the viewgroup.
When animating the headers, this could actually lead to blank headers.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Change-Id: I7763b47340a347ed44fc9ce34a98f74c7e55ef8d
Fixes: 35993698
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
2ffa02fcbb6359630a09e3d8617c514330ee31f1 07-Mar-2017 Selim Cinek <cinek@google.com> Fixed a crash when creating a public notification group

The method whether it was showing an icon was wrong

runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Fixes: 35981843

Change-Id: Ieffeb7480960586fc644e04baaa0c28e98df7736
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java