History log of /frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
678722f9d0b73c3a080d21daa33b87de2534bd05 11-May-2018 Anarghya Mitra <anarghyamitra@google.com> Change status bar icons upon capability changes in the default network.

SysUI status bar updates currently happen upon receiving either the
CONNECTIVITY_ACTION broadcast (which is deprecated) and
INET_CONDITION_ACTION broadcast (which is sent upon validation state
change of networks only).

This leads to status bar showing stale connectivity state. The correct
fix for this is to listen to changes in network state by registering
NetworkCallbacks (see more details in http://b/79286300#comment9).

In the P timeframe, not listening to the broadcasts completely is out of
scope. So this CL just listens for changing network capabilities of the
default data network, which should fix all the cases where the
broadcasts are not getting sent.

Later, when we stop relying on the broadcasts, we will also have to
override onAvailable and onLost (and perhaps the other callbacks too).

Test: runtest --path frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/
Bug: 71904788
Change-Id: I2e58b9cfceb9937a0b54874dee116ead5339b37b
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
f5830cade5cf607989cf629a7855e384cdeef783 09-Mar-2018 Amin Shaikh <ashaikh@google.com> Show the H+ icon in HSPA+ network

Adds the H+ icon. If status bar should distinguish HSPA data icon from
UMTS data icon, this icon is shown as default while connected to HSPA+
network.

Fixes: 69505790
Test: runtest systemui and visually check in demo mode
Change-Id: Ia911fcdb98d2c118e2ef71d7a062efbf72a0809c
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
d64e6269daa6eaf3aba7b843e606d87cc80153bc 08-Mar-2018 Amin Shaikh <ashaikh@google.com> Display mobile data type icons in status bar.

Instead of showing the type in the top left corner of the signal.
- Add new status bar mobile data indicator assets
- Remove unused qs/status bar mobile data indicator assets

Bug: 72540392
Test: visual using demo mode
Change-Id: Ic63ad3307daabf2e0f023308b7e0682dbd29f1ca
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
af4c19394e841b7ec89e7bf4859a943634d45bc6 08-Mar-2018 Amin Shaikh <ashaikh@google.com> Remove upper left X icon on mobile signal.

Use the signal drawable cutout to represent both data disabled and no
internet state. ag/3690757 displays the description of these icons ("No
internet" or "Mobile data off") in the secondary text of the mobile data
tile.

Bug: 72540392
Test: visual && runtest systemui
Change-Id: I806c41bc96420c42461c0a75b93a485f9a2186f7
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
9dcd3226c10a864bca9720e68169ac07893cfa32 04-Dec-2017 Evan Laird <evanlaird@google.com> Make data RAT icon test pass

Change merged in from aosp (I0428ba1749bdb884d210f1ff02cdf86b376a0ca8)
had a test written that was failing because the CL only updated the
status bar icon, not qs icon.

This is my attempt to make the code work as it seemed to be intended.

Test: runtest -x \
packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java \
-m testAlwaysShowDataRatIcon

Change-Id: I4fe11c2e866cbb1f7784e4ed109671a957ffdf36
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
c52f0b61b411974597a87f06b4f2d46caf916cd6 04-Dec-2017 Evan Laird <evanlaird@google.com> Resolve merge conflicts of 710b3946e535 to master

Test: runtest -x
packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java

Change-Id: I95ed65102c3d61a0afa0744663d6966c10f876e5
63364fe24a487f2632c2b57e4a443ca171da25dd 07-Feb-2017 Wenting Xiong <wenting.xa.xiong@sonymobile.com> SystemUI: Display RAT icon when data is off

Introduce customization and implementation to display RAT icon in status
bar even when data is off. Since some carriers require, this feature is
necessary.

Test: Test with simulated RIL
Bug: 28805511
Change-Id: I0428ba1749bdb884d210f1ff02cdf86b376a0ca8
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
2515f4725aad094037fdfd674bb32e2f6cf17639 19-Sep-2017 Jason Monk <jmonk@google.com> Make NetworkController tests more deterministic

Test: runtest systemui
Fixes: 63386204

Change-Id: I371c6897c929e70e61a44e116c5a508f494eff0c
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
2388248362c12c2237bbc8ce48edc14aeff92be1 24-Jul-2017 Geoffrey Pitsch <gpitsch@google.com> Turn some systemui tests back on.

Test: runtest systemui
Fixes: 63887322
Change-Id: I8bcf8c1d2d118a7327736734a39529e51a2a8d2f
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
ba918dbf0c62fdff27d7f332783be0b2173aa77e 12-Jul-2017 Geoffrey Pitsch <gpitsch@google.com> Move @Ignore from class-level to test level.

Workaround for reporting error.

Test: runtest systemui
Bug: 63521982
Change-Id: I81e70605471469b0ffa630ff874427a621fc1135
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
ca8d3d7c6a549f7a08db717113ef85f3d4d6fd1e 06-Jul-2017 Jason Monk <jmonk@google.com> Disable test in presubmit

It seems to have gotten up to .5% flakiness, get it out of presubmit.

Test: runtest systemui
Bug: 63386204
Change-Id: I39e44a0e863022337b578b4d3efa9d1721eff298
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
9d10a3cf306d34f598216c6354c87c45a059b5b3 16-Jun-2017 Sundeep Ghuman <sghuman@google.com> Revert "Update Status Bar with Badged Wifi Icons."

This reverts commit d57f3247766d7e5f2a5c2cbe7be6d241526a9eba.

Reason for revert: Kill badging in ODR

Bug: b/35628911
Test: runtest --path
frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerWifiTest.java
Change-Id: I153863dfc02aaa211e1d76f0d85a2779894f72ee
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
01df36f37fc470d3fd8c120b09cc4e7943cfacfb 07-Jun-2017 Jason Monk <jmonk@google.com> Move QS cell indicator back into mobile data tile

Remove it from the header and drop it back in its old location.

This reverts commit 10b4c8a4ab3fc1fd55e5a636066e210ad17cf92b.

Test: runtest systemui
Fixes: 62331189
Change-Id: I087589c256894e0972656619e665b6a16536ce6c
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
10b4c8a4ab3fc1fd55e5a636066e210ad17cf92b 26-May-2017 Jason Monk <jmonk@google.com> Make QS signal indicator act like a QS signal indicator

It had the behavior of the status bar before, so switch it over to
QS behavior but keep status bar icons for the appearance. Ditch
the old QS data icons because we no longer need them.

Test: runtest systemui
Change-Id: I1356bbc19c4874ae467e192b9129136ebd0a37c8
Fixes: 62128809
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
7e6c83c752e0825320e44bd87661b6422d3a3db6 26-Apr-2017 Jason Monk <jmonk@google.com> Revert "Status bar updates" DO NOT MERGE

Test: runtest systemui
Fixes: 37626598
This reverts commit d1ba5fbb54a02fad0c68f71183078527bfa9bd49.

Change-Id: I12c70b67fafd46ec98b1c1ee28b911e19afbf6e5
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
d1ba5fbb54a02fad0c68f71183078527bfa9bd49 13-Apr-2017 Jason Monk <jmonk@google.com> Status bar updates

- Wifi moves to right of cell
- Cell data and roaming indicator swap places
- Data disabled and no internet on cell look the same
- Don't show wifi in QS signal cluster, it has its status
right below.

Test: visual && runtest systemui
Fixes: 36717491
Change-Id: I16ebe6fb6dd519526a1e174753c8ce08c713d405
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
48edc0c62805450fcecd11622dbcc91a433dcd0c 10-Apr-2017 Jason Monk <jmonk@google.com> Convert signal icon to be custom drawable

This will make it really easy to change the number of bars it
displays.

Test: runtest systemui
Change-Id: If0b8a606f56430ea08fa0887af85aa0e90de1d40
Fixes: 35902355
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
28cc1660607d64caac49ec70a1cf6cf7500e2eea 02-Mar-2017 Jason Monk <jmonk@google.com> Disable flaky test

Don't have a fix yet, disable to avoid any unwanted flakes.

Bug: 35866797
Test: runtest systemui
Change-Id: I8865253fbb58f619eb23d1c24c4370e819c58a29
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
0288de0e5635b714273ff8185b4bdbfb9ece447c 23-Feb-2017 Jason Monk <jmonk@google.com> Fix data disabled icon from not showing in status bar

The NetworkController seemed to think the user wasn't set up since
the DeviceProvisionedController didn't send an initial callback
on add.

Also add some extra listening to data disabled state to avoid race
conditions there.

Change-Id: I17f759894a283da08eb0da7ceb5181355c8f4d55
Fixes: 35708363
Fixes: 35632846
Test: runtest systemui
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
0f0de13c37082f9443e3f0c8cc413188ec66d3fe 19-Dec-2016 Jason Monk <jmonk@google.com> Add separate roaming icon for status bar + QS

Now data + roaming will be shown at the same time.

Test: runtest systemui
Bug: 31205845
Change-Id: I8fe167a0909c952ad0824e24e178857df2541554
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
d57f3247766d7e5f2a5c2cbe7be6d241526a9eba 14-Jan-2017 Sundeep Ghuman <sghuman@google.com> Update Status Bar with Badged Wifi Icons.

This change inserts badged wifi icons into the status bar to indicate
historical network strength. The existing callback handler was modified
to explicitly pass the drawable as currently the icon is a rendered from
two separate resources, composited together in a LayeredDrawable.

Badging is controlled by Settings.Global.NETWORK_RECOMMENDATIONS_ENABLED
and can be enabled from the Wifi Settings page.

Bug: 34056846
Test: runtest --path
frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerWifiTest.java
Change-Id: I33b736d4543e380887513cbb5937f49945794c09
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
9c7844cb91b43929d0a86b1c90aa1efb37f5463a 18-Jan-2017 Jason Monk <jmonk@google.com> Work on sysui dependencies

One of the many problems with PhoneStatusBar is that it holds
dependencies for many other parts of SysUI. Fix this by creating
a static method of grabbing dependencies that are global to sysui
this cleans up a lot of chains of interdependence.

Also add easy way to inject mocks of these dependencies for the
purpose of testing.

Test: runtest systemui
Change-Id: Ia0e947faea62d15b665facada47ac9916c99f895
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
26ad85a646a2480336c4947ff143f0c5d2fbf63d 08-Dec-2016 Jason Monk <jmonk@google.com> Switch sysui to updated mockito target

Some updates required for tests to pass. Also did a little cleanup
of bad verify matching.

Test: runtest systemui
Change-Id: I75b9f34ab7e9af111dafd5a648840893e1cee434
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
2c403db659db615831d8bd02661f8769c7762241 26-Aug-2016 Geoffrey Pitsch <gpitsch@google.com> Convert SysUI tests to use JUnit4

Run tests with android.support.test.runner.AndroidJUnitRunner,
modification to runtest target in separate CL.

No longer inherit from TestCase, stripped unneeded code from
SysuiTestCase, which now assigns mContext via
InstrumentationRegistry.getTargetContext().

Can no longer create Handlers with default constructor,
Looper.myLooper() was never able to receive messages in tests
and it is now enforced that you pass the Looper.getMainLooper().

Change-Id: I13f499175a459cef1a554431911f4b21126e126e
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
fd57ea730e65afd6dcb848664dde0cdb64624659 29-Apr-2016 Jason Monk <jmonk@google.com> Don't show data disabled icon when user isn't setup

Change-Id: I2d540b8c0cb613cbf120ffadc404ee03d0447a8b
Fixes: 28246388
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
f668d7cceb3c6cc9143fcf92230681bddd7ccf21 14-Jan-2016 Jason Monk <jmonk@google.com> Support data usage changes in Settings

Change-Id: I78c6a3956e7136c3ed64d9323d3fe74df2898c5d
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
5bdfd8c12604b7d907e32c8c1697edc76c87608f 13-Jan-2016 Jason Monk <jmonk@google.com> Get data type from service state as well am: 67b2c16a9a am: 05130f3f23
am: 8ced692e44

* commit '8ced692e445526a74d51391f2c7c30bd43322d46':
Get data type from service state as well
67b2c16a9a9060d37888bdab4dfadd384a76e9d7 12-Jan-2016 Jason Monk <jmonk@google.com> Get data type from service state as well

Bug: 26276354
Bug: 26413831
Change-Id: Ic080300db7d5e5200caf611cc2ee1ef3af93736e
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
46c4a32ed9668294dc87c11e466f4e4b27bf48e1 18-Nov-2015 Jason Monk <jmonk@google.com> Fix build

Change-Id: Ib784f3b8e1f8e5166128a86d07b43859ee803765
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
4cf95aef839701a43c9bde292f5e2d8ca3213509 16-Nov-2015 Jason Monk <jmonk@google.com> Move some stuff to SettingsLib to use for Settings Home

Change-Id: Id903747069fe83a896132714e580b1a1d7ee895c
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
e427cb80762c5cd067f3c419eb0a427d077b3d95 28-Jul-2015 Jason Monk <jmonk@google.com> Add sizes to SysUI tests

Change-Id: I27e4a60e2658d3a5db32cdeb73bd0a031865ce86
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
7150d7fa357e00b2904ff3bcf9e06a1014bfbb39 09-Jul-2015 Jason Monk <jmonk@google.com> Remove data icon for WFC

Bug: 22095746
Change-Id: I0ca8420c2d88425cbb6da5fcc02c083355e933e9
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
c6cc6266c9325f180b1a073f733fdf0a64e9286f 11-Jun-2015 Jason Monk <jmonk@google.com> Fix EmergencyCallback in NetworkController

- Do some cleanup so that things are more testable
- Test emergency callback since its possible
- Fix emergency callback in no sims case

Bug: 16218652
Change-Id: Ic859eff732cc11c5ae8aa6ced3584905bbe215c7
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
33f8ae7543fbf7d94266f0f1621ec873aa2542f1 08-May-2015 Jason Monk <jmonk@google.com> Show data icon when appropriate.

Show it in the status bar when its a default network, but always show
it in QS when its connected, so that users can know its connected.

Also fix the tests.

Bug: 18776546
Change-Id: I553588fc6850b0c2ef6e6015b313222bf4c786e7
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
07b75fe65dcb5b8add8246654c65f95f1191933e 14-May-2015 Jason Monk <jmonk@google.com> Move NetworkController broadcasts/listeners to BG

Also do some refactoring to avoid having to sets of callback interfaces
with 75% of the same data.

Bug: 19520495
Change-Id: Ife1c71174c0d6a21f924f7de3cb2f97a04c3d5a1
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
3aaabd71242bf8aedb8edb87565943460a79226d 12-Dec-2014 Jason Monk <jmonk@google.com> Handle config changes in NetworkController

We need to remap or recalculate icons after a config change, so
configs based on mccmnc can update properly.

Bug: 18654943
Change-Id: I6a4c1debf9b266d486143b9869abb569bbc31aef
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
b574627ebc383d35cf8212ee241b191b26518a0d 12-Nov-2014 Jason Monk <jmonk@google.com> SysUI: Actual MSIM status bar support

Expand SignalClusterView and NetworkController to handle multiple
SIMs. It does this by creating multiple MobileSignalControllers
for each of the active subscriptions on the device.

Also some minor changes for followup on the NetworkController
refactor that went in before this.

Bug: 18222975
Change-Id: Ic7a857cfc5cadb46d51bb9ded0df8187eea799f7
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java
f13b4b39f266e43239e40e3bf7d6997600555068 07-Nov-2014 Jason Monk <jmonk@google.com> SysUI: Add basic test coverage for signal levels

Add some tests that verify for varios wifi, and mobile signal
strengths and types that the correct icons are sent out in the
callbacks. Still in prep for MSIM refactoring.

Bug: 18222975
Change-Id: I477bf9a90e5c32fb1cba9c150ec6314f4b707108
/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerDataTest.java