| 97d2820cf89eab4ca7e86b4f9022b3f45d8e461f |
|
28-Feb-2018 |
chaviw <chaviw@google.com> |
Synchronize all WindowTestsBase and WindowTestUtils methods.
Several WindowManager tests access WindowManager code that assume the WM
lock is already held. This can cause crashes in native code and cause
unexpected behavior. Added synchronize blocks around all helper methods
to avoid adding synchronized blocks in all WM tests methods.
This does not guarantee that all WM tests are synchronized, but handles
a good bulk of them for now.
The largest number of failures were from ZOrderingTests since that tests
creates a lot of windows, making synchronicity issues more likely. Ran
that test class multiple times to ensure I was unable to get the
failure.
Test: ZOrderingTests
Bug: 73966377
Change-Id: I96f586e7ea91223589caef885c87ecded555ab13
Fixes: 72976082
/frameworks/base/services/tests/servicestests/src/com/android/server/wm/DragDropControllerTests.java
|
| fabca09f0f5cf32eeebb4c8ae793f498aa182d58 |
|
19-Dec-2017 |
Daichi Hirono <hirono@google.com> |
Remove DragDropController#prepareDrag()
The prepareDrag() call is used by apps to ask the system server to
create a surface for drag shadow. Now the app creates a surface by
itself, thus we can reduce the method.
Bug: 70818582
Test: com.android.server.wm.DragDropControllerTests,
android.server.wm.CrossAppDragAndDropTests,
manually check the drag and drop behavior on test app.
Change-Id: Iae4acbff4f9ad68faa6324beb32bf9a28dcd67be
/frameworks/base/services/tests/servicestests/src/com/android/server/wm/DragDropControllerTests.java
|
| a1fb9be437b672f52ad64e1506038757ec060dcf |
|
18-Dec-2017 |
Daichi Hirono <hirono@google.com> |
Create a drag shadow surface in app process,
Previoulsy a drag shadow surface is created in the system process. App needs
to call one more binder call (prepareDrag) to obtain the surface from
the system process.
The CL lets an app to create a drag shadow surface by itself. Then app
transfer the surface to system server by using reparent
API.
Bug: 70818582
Test: com.android.server.wm.DragDropControllerTests,
android.server.wm.CrossAppDragAndDropTests,
manually check the drag and drop behavior on test app.
Change-Id: I72796efffbefe78a802d7c441dea308d1cdea572
/frameworks/base/services/tests/servicestests/src/com/android/server/wm/DragDropControllerTests.java
|
| da0748d00c645225317ed2656b8b3b0561aaaf4c |
|
12-Dec-2017 |
Daichi Hirono <hirono@google.com> |
Fix NPE occured when null ClipData is passed to startDrag.
Previously we have NPE for the following cases:
* when specifying both DRAG_FLAG_GLOBAL and DRAG_FLAGS_URI_ACCESS, OR
* when the userIds of source and target apps are different
Bug: 70477060
Test: com.android.server.wm.DragDropControllerTests,
android.server.wm.CrossAppDragAndDropTests,
manually check the drag and drop behavior on test app.
Change-Id: I454b434e4466cb159ce23e0982012cdb21c9d002
/frameworks/base/services/tests/servicestests/src/com/android/server/wm/DragDropControllerTests.java
|
| 1821c5a0db9fa186b4e0a40fc7ff45f3dc5539a9 |
|
12-Dec-2017 |
Daichi Hirono <hirono@google.com> |
Let prepareDrag return error when 0 size drag shadow is specified.
Since ag/2837472, creating 0 size surface resulted in raising an
exception. To avoid it, the CL lets prepareDrag return error.
Bug: 70393408
Test: com.android.server.wm.DragDropControllerTests,
android.server.wm.CrossAppDragAndDropTests,
manually check the drag and drop behavior on test app.
Change-Id: Ie0c477dd9e76dd5ec8b7aed6a472e24032777cc8
/frameworks/base/services/tests/servicestests/src/com/android/server/wm/DragDropControllerTests.java
|