History log of /frameworks/native/cmds/lshal/ListCommand.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
f31aa05f9c3df1d278f55fd6f4ab742542e77c80 03-Feb-2018 Yifan Hong <elsk@google.com> lshal --init-vintf: can specify manifest partition

lshal --init-vintf [--init-vintf-partition=vendor] generates
device manifest.

lshal --init-vintf --init-vintf-partition=system generates
framework manifest.

lshal --init-vintf --init-vintf-partition=odm generates odm manifest.

Test: the above commands
health/backup is in system manifest
IBase is not in any manifest
graphics.composer/vr is in system manifest

Test: lshal_test

Fixes: 71802285
Change-Id: Ie16c8914218ece5c3cd698c93f2bada1be3ee29f
/frameworks/native/cmds/lshal/ListCommand.h
22ea7b851dbe753eda2a703952bbc803c1dcfc1f 15-Sep-2017 Yifan Hong <elsk@google.com> lshal: clean up ListCommand::fetchBinderized

Refactor fetchBinderized. Move logic for each TableEntry to
a separate fetchBinderizedEntry function.

* Change allDebugInfos to allTableEntries to contain more information.
* Use getPidInfoCached instead of allPids for cache.
* TableEntry can be default constructed.

Test: lshal_test
Change-Id: Iceea7296b7fd4f3fa268daa74bd3b89360294124
/frameworks/native/cmds/lshal/ListCommand.h
1243ddeac9e35eaf1ca8f665eff24a89226b2f01 15-Sep-2017 Yifan Hong <elsk@google.com> lshal: ListCommand::getPidInfo should be cached.

The function parses a big file and its result should be cached.
Add ListCommand::getPidInfoCached, which is a cached version
of this function.

Test: lshal_test
Change-Id: I03d8f149bf67b1512be431a3c4c29e83f7743a2f
/frameworks/native/cmds/lshal/ListCommand.h
93b8bfffba852a9048f0445143eb6252bd5a7467 15-Sep-2017 Yifan Hong <elsk@google.com> lshal: omit description text in tests.

There is no point on testing on the exact description text.
Test: lshal_test

Change-Id: Ieb7caaf992c62b772357a67e9e2abeba525c4bce
/frameworks/native/cmds/lshal/ListCommand.h
a6b93f0d61201b0318b65a8ffeb2b9cfeea0c9ea 14-Sep-2017 Yifan Hong <elsk@google.com> lshal: register options for ListCommand.

ListCommand parseArgs() and usage() uses a list of RegisteredOption's
instead of hardcoding all options.

Test: lshal_test
Change-Id: I94418b22791fbff7a17756c4266252a76570fb84
/frameworks/native/cmds/lshal/ListCommand.h
795b6ec89541879d7c11d20842ab5e854bfc4caa 13-Sep-2017 Yifan Hong <elsk@google.com> lshal: Lshal register commands

Register commands to the controller class Lshal to autogenerate
help messages and select the correct Command.

Test: lshal_test
Change-Id: I846aef13d77bcee328c8410dc61f2e8b4c0e0d69
/frameworks/native/cmds/lshal/ListCommand.h
a8bedc6ae3f6d610aa634445809835c26aaf16bc 09-Sep-2017 Yifan Hong <elsk@google.com> lshal: add HelpCommand

Add *Command::usage() function for each Command and let
Lshal class to call them.

Suppress output from getopt_long and write our own
error message to customized error stream (for testing).

Test: lshal_test
Test: lshal --help

Change-Id: I8f5847c84a3e01af29fa85871479cab3baeb5312
/frameworks/native/cmds/lshal/ListCommand.h
ded398e5b6530c4ced5bd42f9b75ca2caa527239 07-Sep-2017 Yifan Hong <elsk@google.com> lshal: Add class Command.

Command is the base class for all *Command classes.

Test: lshal_test

Bug: 35389839
Change-Id: I9aca19e66824536d13e618ffd0f012ac3da9880d
/frameworks/native/cmds/lshal/ListCommand.h
91e655dc2be238fafcf832c73e62166d7b69c848 14-Sep-2017 Yifan Hong <elsk@google.com> lshal: DISALLOW_COPY_AND_ASSIGN needs to be in private

Test: pass
Change-Id: Ic2abdbe0309957f1a72ca4a788bb09dd660c746c
/frameworks/native/cmds/lshal/ListCommand.h
8bf7316ebc75f9e5b3a6349bbc9c7140e6e90234 08-Sep-2017 Yifan Hong <elsk@google.com> lshal: add tests for ListCommand::fetch* and dumpVintf

Test: lshal_test
Change-Id: I9e519ec93709ba4dfa7f95e4c5fff60cbda36134
/frameworks/native/cmds/lshal/ListCommand.h
b2a2ecb642d1dad620bd91f6b875521a55b08224 08-Sep-2017 Yifan Hong <elsk@google.com> lshal: Add tests for ListCommand::parseArgs

Test: lshal_test
Bug: 35389839
Change-Id: Iaef39b048b0e7c06e70e21c96448c2f2e24d3128
/frameworks/native/cmds/lshal/ListCommand.h
ca3b6609625c838cfc0975e00bbbc7386f618874 08-Sep-2017 Yifan Hong <elsk@google.com> lshal: fix file streams for testing.

* If a file is specified for list, the file is opened and
closed within the ListCommand::dump() function.

* Add a missing break in ListCommand::parseArgs, case
for '--init-vintf'

Test: lshal_test
Test: lshal --init-vintf
Test: lshal --init-vintf=/data/data/a.xml ; adb shell cat \
/data/data/a.xml
Test: lshal -d
Test: lshal --debug=/data/data/d.txt ; adb shell cat \
/data/data/d.txt

Change-Id: I1acee5878638d25257a13244713dc416e9d8d6b2
/frameworks/native/cmds/lshal/ListCommand.h
76ac14a10d9c7bc095d5029928033478f29fdf3c 08-Sep-2017 Yifan Hong <elsk@google.com> lshal: fix output streams for testing.

ListCommand does not keep a reference to output
and err streams (for easier mock in testing). Instead,
ListCommand uses out() and err() that calls into
Lshal::out() and err().

Test: lshal
Test: lshal_test
Change-Id: Ie6720833ad513ba5cb1246e34ef96afed5d4373c
/frameworks/native/cmds/lshal/ListCommand.h
d4a77e8a1a9bcb778c01738b0dce640ff7d4e8a5 07-Sep-2017 Yifan Hong <elsk@google.com> lshal: remove ListCommand addLine

Remove obnoxious addLine(...) in ListCommand.cpp by moving
the feature of selecting columns into the "Table" class.

Test: lshal
Test: lshal -m
Test: lshal -d (shows debug info for context hub)
Test: lshal_test
Bug: 35389839
Change-Id: Ieb4a6e544ef39c9f1a63b046a44b6a8e1416ea62
/frameworks/native/cmds/lshal/ListCommand.h
05494a552269b9b9d102bb4f65ef37f4b2557057 30-Aug-2017 Yifan Hong <elsk@google.com> lshal: table columns affected by arg order.

Test: lshal
Test: lshal -pita

Bug: 35389839
Change-Id: I845a13b8d7cdf483f4d269e5c33626f6013b42d7
/frameworks/native/cmds/lshal/ListCommand.h
1bc1e9ffe224e4938d667a567a99619d7dd66229 30-Aug-2017 Yifan Hong <elsk@google.com> lshal: pretty print table.

Table column length is not hardcoded, but computed
from length of each cell.

Without --neat, table column length varies for each
table.

As an effect, --neat does not emit debug info. Update
warning messages to reflect this.

Test: lshal
Test: lshal_test
Test: lshal --neat

Bug: 35389839

Change-Id: Id1d626a10ba58e20d2799854432dba74cfeaae6f
/frameworks/native/cmds/lshal/ListCommand.h
d8e20191c2fa10a458b29bb06502487d704ba076 24-May-2017 Steven Moreland <smoreland@google.com> Add thread usage output to lshal.

This output shows how many threads are in use at a give time.

Test: lshal, manual
Bug: 35099601
Change-Id: I3a22bb131b828cdd77e73e7810229d9c68a496d3
/frameworks/native/cmds/lshal/ListCommand.h
6da06916211a1292ce83d5fa730cd8f805902b13 13-May-2017 Yifan Hong <elsk@google.com> Add lshal --neat option

... that doesn't output explanatory text and title line.

Test: lshal --neat
Test: lshal
Test: lshal --neat -itrpc

Change-Id: I269a5d284903dc0e9bc3be96379ed41aecea8ddb
Fixes: 38211518
/frameworks/native/cmds/lshal/ListCommand.h
443df7932cedd88d523164ac7175fa19ec553c7b 10-May-2017 Yifan Hong <elsk@google.com> Lshal: support commands.

Support the following commands:
lshal list
lshal list -itrpc
lshal help
lshal help list
lshal list -h
lshal list --help

Test: run these commands
Bug: 37725279
Change-Id: I970fbc8d250d43f57e92f783229e0645d7e8df4e
/frameworks/native/cmds/lshal/ListCommand.h