| d66be0ae6929fee064a229d6c6bac3a871aba137 |
|
05-Oct-2017 |
Chih-Hung Hsieh <chh@google.com> |
Use -Werror in frameworks/native/libs/gui and ui
* Remove unused variable and function.
* Suppress warning of unused return results.
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: If6f445be1e7677a37bf780844a79b84d6d7e1c1e
/frameworks/native/include/private/ui/RegionHelper.h
|
| 836513bfbf166217d57d1ef212d9d700ed25620c |
|
23-Jun-2017 |
Steven Moreland <smoreland@google.com> |
Merge "IWYU RegionHelper += <limits>" am: bbf3096e22
am: f08008db9f
Change-Id: Ida5d67d96a8c3eb87f25202872b2c30ed5b6c25e
|
| 1da0289905bfd34795e12fa4f9b5cfc07ae49fa1 |
|
23-Jun-2017 |
Steven Moreland <smoreland@google.com> |
IWYU RegionHelper += <limits>
Test: compiles when transitive dependency is removed
Bug: 35363681
Change-Id: Ia405e41102e6ded07720e424167df7e4d080581e
/frameworks/native/include/private/ui/RegionHelper.h
|
| ea969d53ddd53a8f125e6f2d10074c2f4a0b6554 |
|
10-Mar-2017 |
Steven Moreland <smoreland@google.com> |
RegionHelper.h: include <limits> directly.
Includes are transitively imported by <string> in String8.h + String16.h
but that include is being removed.
Test: pass
Change-Id: I378d533ee5445bc0286c7535581a491f55ca36c9
/frameworks/native/include/private/ui/RegionHelper.h
|
| f8e9366df2fc079c37de6ea35d70bf2b227e6946 |
|
17-Feb-2017 |
Fabien Sanglard <sanglardf@google.com> |
Fix typo in Region to avoid unexpected values
b/34193533 showed that Framework can sometimes use very large rect
(presumably to hide a window **very** far out of the screen visible
rectangle). Which results in SF freezing and using 100% of CPU.
max_value is not initialized to the right value. Really it should be
0x7FFFFFFF instead of
0x7FFFFFF
Since Region was templatized (originally to potentially use int16_t)
the fix uses C++11 numeric_limits instead of INT_MAX.
Test: Manual
Change-Id: Iaee64727226730dbea1f05618a97b801254cde4d
/frameworks/native/include/private/ui/RegionHelper.h
|
| 6027ba747a985fd14edf411395c79624f87f575b |
|
17-Feb-2017 |
Fabien Sanglard <sanglardf@google.com> |
Fix typo in Region to avoid unexpected values
b/34193533 showed that Framework can sometimes use very large rect
(presumably to hide a window **very** far out of the screen visible
rectangle). Which results in SF freezing and using 100% of CPU.
max_value is not initialized to the right value. Really it should be
0x7FFFFFFF instead of
0x7FFFFFF
Since Region was templatized (originally to potentially use int16_t)
the fix uses C++11 numeric_limits instead of INT_MAX.
Test: Manual
Change-Id: Iaee64727226730dbea1f05618a97b801254cde4d
/frameworks/native/include/private/ui/RegionHelper.h
|
| 382ecd3d6345aeeda158a8d94cc0aee1bd3a45dc |
|
26-Sep-2016 |
Colin Cross <ccross@android.com> |
Fix constructor parameters shadowing member variables
Using the same name for the constructor parameter and the member
variable causes a warning that was being hidden by the use of -isystem
to include frameworks/native/include. Prefix the parameter with an
underscore.
Bug: 31752268
Test: m -j
Change-Id: I7748934f1e9515176e2ae98d2c0e58d165a7a5c2
/frameworks/native/include/private/ui/RegionHelper.h
|
| 8f279960c6ad8803e36503250b7ab89e34c9477b |
|
26-Sep-2016 |
Colin Cross <ccross@android.com> |
Use uint32_t consistently for region op
An implicit conversion warning was being hidden by the use of -isystem
to include frameworks/native/include.
Bug: 31752268
Test: m -j
Change-Id: I008ef537a24311d58816fae12ef8c4aeaba07547
/frameworks/native/include/private/ui/RegionHelper.h
|
| 17576de056a57753eb4af797545db88ef4f81ef0 |
|
26-Sep-2016 |
Colin Cross <ccross@android.com> |
Fix trailing semicolon warnings
Remove semicolons after inline function definitions. The warnings were
being hidden by the use of -isystem to include
frameworks/native/include.
Bug: 31752268
Test: m -j
Change-Id: I1027e87f459c36a575cd04b3afb645736832b07b
/frameworks/native/include/private/ui/RegionHelper.h
|
| 60d6922a011fe18c111b8d30fb6ef1f655b6b15e |
|
07-Aug-2015 |
Pablo Ceballos <pceballos@google.com> |
libsgui: Change Rect default constructor
The current Rect default constructor initializes to all zeroes. Change
it to initialize to an invalid Rect.
Modify all of the existing invocations of the default constructor to
maintain the existing behavior.
Bug 18173359
Change-Id: Ibbad076f1550a94f56d7b1cf5350071f2022e09a
/frameworks/native/include/private/ui/RegionHelper.h
|
| 068d47f29dfead847999a7b33b4217ee9514152b |
|
12-Sep-2012 |
Mathias Agopian <mathias@google.com> |
strengthen region validation
Change-Id: I75ee7bc4dd7a2f5357ac8994a23bc8b8bfb6eb44
/frameworks/native/include/private/ui/RegionHelper.h
|
| 3aecbb0715cb6928e0530ff1e4caa9c0993cc371 |
|
17-Apr-2012 |
Mathias Agopian <mathias@google.com> |
fix Region const_iterator.
- it returned an empty rect when the region was empty, instead
of returning an empty list of rect.
- also fixed an infinite loop when boolean_operation was given
an empty list of rects
Change-Id: I62225c7dcd2832025bb8f12e6cb3762f2a7b36cb
/frameworks/native/include/private/ui/RegionHelper.h
|
| 38a7fa2ae37236952e5fb0186fddb4f6da5990d8 |
|
16-Oct-2009 |
Mathias Agopian <mathias@google.com> |
fix [2182249] [MR1] valgrind error in surface flinger
/frameworks/native/include/private/ui/RegionHelper.h
|
| e7c4c28d0fe9b62eacaa04d901464e501e511265 |
|
07-Jul-2009 |
Mathias Agopian <mathias@google.com> |
add a virtual destructor to region_rasterizer, to be on the safe side
/frameworks/native/include/private/ui/RegionHelper.h
|
| 20f68782a4ea71c6a977d7f87d8288d3daa265ec |
|
11-May-2009 |
Mathias Agopian <mathias@google.com> |
Region now has its own implementation instead of relying on SkRegion, which allows us to break libui's dependency on libcorecg.
/frameworks/native/include/private/ui/RegionHelper.h
|