| 0f8285e1e039af673f0cc3a3d76ed071da875d79 |
|
02-Jun-2018 |
Etan Cohen <etancohen@google.com> |
[WIFI] Add null check before variable access to prevent an APR
Bug: 80498990
Test: None - not clear how to trigger
Change-Id: Ic86a3ca660aa364a647e80577e6c7a92599b1da7
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/util/WifiAsyncChannel.java
|
| e7ebc3fba71f4f996794bc5fa939674f8b4b2c5a |
|
10-Jan-2017 |
Sohani Rao <sohanirao@google.com> |
Fix WifiScanningServiceImpl stand-alone unit test failure
WifiAsyncChannel and WifiHandler objects use lazy intialization for the
logging objects. WifiInjector.getInstance() may return a null object if
the unit test is run by itself or if earlier tests have not created it.
If the unit tests are able to update these instances with a logging
objects that are not null, then unit test can pass stand-alone.
- Add a method in FrameworkFacade to return new instances of
WifiAsyncChannel
- Update WifiAsyncChannel to expose setWifiLog() API for testing only
- Call this method on instances of WifiAsyncChannel returned by the mock
of FrameworkFacade factory to ensure mLog is not null
- Add a method in WifiScanningServiceImpl, also meant for testing only
to update WifiHandler with logging object
- Change unit tests to call this method after starting scanning service
Bug: 34127212
Test: WifiScanningServiceTest by itself and all unit tests pass
Change-Id: I0bc7a55d6d6862e2360bfb20897828e84358dd39
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/util/WifiAsyncChannel.java
|
| cda805612a020057f7363b8e89be72ca9d6958f9 |
|
19-Oct-2016 |
Sohani Rao <sohanirao@google.com> |
Async Channel with Logging for Wifi Services
Subclassing AsyncChannel to override and add logging calls to
- sendMessage()
- replyToMessage()
- sendMessageSynchronously()
Bug: 31746964
Test: Flash and bringup phone, verify logging for services
using the WifiAsyncChannel instead of AsyncChanel
Change-Id: I0b075f3db16284ffcae0fa2881e5e73310c14e72
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/util/WifiAsyncChannel.java
|