| 618a4449bb3e9be43586040ea2fb9a6371365ae7 |
06-Mar-2018 |
Maurice Lam <yukl@google.com> |
Add touch feedback to links
- Clear selection after LinkSpan is clicked so that the highlight
effect will be cleared when the tap completes
- Set focusableInTouchMode to true and revealOnFocusHint to false
in RichTextView for N MR1 or above to allow the highlight effect
to be visible in touch mode.
Test: ./gradlew test connectedAndroidTest
Bug: 73350031
Change-Id: Ibb6f67102775802cdfebaa1529c09d936b4096cb
(cherry picked from commit bc1c7a159c14f8b8f532fec60681d34771cd7909)
om/android/setupwizardlib/test/RichTextViewTest.java
|
| 3514ad526af3d95f61383ec374ea4c384ba9b540 |
17-Mar-2018 |
Maurice Lam <yukl@google.com> |
Add methods to set GLIF icon content description
Test: ./gradlew connectedAndroidTest
Bug: 74435529
Change-Id: I22e3abe8dce0663a7d1e7ee3050d327abeec4ad2
(cherry picked from commit c38af2fb55868523e5ddcceb6331947501f43adf)
om/android/setupwizardlib/template/IconMixinTest.java
|
| 97d3a11d5e6a2bf9ec3f50de7b77ef94333110d3 |
14-Feb-2018 |
Maurice Lam <yukl@google.com> |
Add setIcon(int) to IconMixin
This allows vector drawable compat to be used on pre-L.
Test: ./gradlew connectedAndroidTest
Change-Id: I405f28eae11e68532165f89b1c1a226972ee06a3
om/android/setupwizardlib/template/IconMixinTest.java
|
| c9c5c4431a920e8a22d96bf3721e2c5377c9b57b |
02-Feb-2018 |
Maurice Lam <yukl@google.com> |
Set the back button sysUiVisibility as well
Changes to window sysUiVisibility is not picked up after the window
is laid out, so add a call to set the decor view's sysUiVisibility as
well.
Test: ./gradlew connectedAndroidTest
Bug: 72840994
Change-Id: I6f0744599f46adf1840738f226b4394e5b7ed1df
om/android/setupwizardlib/test/SystemBarHelperTest.java
|
| f344307345a421dc89650799c38ad74ced44ee38 |
11-Jan-2018 |
Maurice Lam <yukl@google.com> |
Add error-prone to gradle build
So that error prone failures can be caught before dropping to
Google3.
Test: make
Change-Id: I0ff6f7a4c124433d907703fd1204395c34bab6bf
om/android/setupwizardlib/test/GlifPatternDrawableTest.java
|
| 58195c5316855122593366bd867ed51a91bd5c11 |
03-Nov-2017 |
Maurice Lam <yukl@google.com> |
Hide icon view if icon is null
To remove the extra margin when the icon is not used.
Test: ./gradlew connectedAndroidTest
Bug: 68826871
Change-Id: Ic23307a28b2829fdbe029c61f912f04bab90ca13
om/android/setupwizardlib/template/IconMixinTest.java
|
| a23e50896f6ddb40f14551d7fc1af129ce501f3f |
02-Aug-2017 |
Maurice Lam <yukl@google.com> |
Allow keyboard to focus on switch item
Test: ./gradlew connectedAndroidTest test
Bug: 63115991
Change-Id: If03b3e469fd740631b5eabb6031f11fd2165bdb3
om/android/setupwizardlib/test/SystemBarHelperTest.java
|
| c57872c2603e788b3802d340f55079ceffe3e25d |
01-May-2017 |
Maurice Lam <yukl@google.com> |
Set GLIF v1 background color to true white/black
To make sure the same video asset can be used for both GLIF v1 and
v2, change the background of v1 to be #ffffff and #000000 to match
GLIF v2.
Bug: 37686500
Test: Manual. Existing tests updated
Change-Id: I70c60f8a9dfade6dbac376f01f26023bac1c7aee
om/android/setupwizardlib/test/GlifLayoutTest.java
|
| 6011b35deae30839cd454e0ec5866487e90860f5 |
26-Apr-2017 |
Maurice Lam <yukl@google.com> |
Allow setting DividerInsetEnd
- Added XML attribute suwDividerInsetEnd, and replaced
suwDividerInset with suwDividerInsetStart.
- Modified the themes so that the divider insets are set
automatically. If the activity uses GLIF (v1) or material, and the
list does not have icons, it should set
app:suwDividerInsetStart="?attr/suwDividerInsetStartNoIcon"
in the Glif[Recycler/List]Layout
Test: ./gradlew connectedAndroidTest test
Bug: 37677772
Change-Id: Ia4cb9954dd7e3c59cbc72db8937989557689061b
om/android/setupwizardlib/template/ListMixinTest.java
om/android/setupwizardlib/test/GlifListLayoutTest.java
om/android/setupwizardlib/test/SetupWizardListLayoutTest.java
|
| 51f4609c813c2336bd12eaf7d6a719fd7f2fc5f2 |
19-Apr-2017 |
Maurice Lam <yukl@google.com> |
Allow set LinkSpan click listener on RichTextView
In addition to allowing setting a LinkSpan click listener in the
context, also allow setting it on RichTextView itself.
Test: ./gradlew connectedAndroidTest
Change-Id: I6b300068db0e68d351d635897220535a5aa92c93
om/android/setupwizardlib/test/RichTextViewTest.java
|
| 24885729e3571ebca96c3fb8041f882d79e0fc0c |
06-Apr-2017 |
Maurice Lam <yukl@google.com> |
Fix description item with material theme
SuwItemTitle.Description style can be used with material theme and
therefore should not reference GLIF specific attributes. Created new
attribute suwItemDescriptionTitleStyle so that GLIF item can use a
GLIF specific style to adjust description text alignment, while
material theme will use the normal SuwTitle style.
Test: ./gradlew connectedAndroidTest test
Bug: 37033526
Change-Id: I0d162bf6984f6a2fbbf04143a256fb70862527b0
om/android/setupwizardlib/test/ItemLayoutTest.java
|
| e46be9bcf0dd195989b10768ceb57dd2c70095a9 |
03-Apr-2017 |
Maurice Lam <yukl@google.com> |
Rename GLIF Pixel to GLIF v2
Since we are giving the option to OEMs to use the center alignment
theme, rename it to something not Pixel specific.
Test: Tests updated. ./gradlew connectedAndroidTest test
Bug: 36857917
Change-Id: I09b0ebb743ccaa0ad6b215a12576ce1109a3fa31
om/android/setupwizardlib/test/GlifLayoutTest.java
|
| 339cbc0f38d81adda4d2f9bf44a5514e2f027031 |
27-Mar-2017 |
Maurice Lam <yukl@google.com> |
Don't set null tint color on Lollipop
There is a bug in Lollipop framework where setting a null progress
tint will cause NPE when drawn.
Test: ./gradlew connectedAndroidTest
Change-Id: I0ba0aa8847f6ab2b0608f55c96814d383de67277
om/android/setupwizardlib/template/ProgressBarMixinTest.java
|
| 0ceb8d53e39ebb5bc103863787afb39ec5c41ad8 |
18-Mar-2017 |
Maurice Lam <yukl@google.com> |
Add ability to require scroll to GlifLayout
Generalize RequireScrollHelper and turn it into a mixin to allow
GlifLayout to use require scrolling.
This is only applicable to GLIF with sticky footer, since inline
content button requires scrolling by definition.
Also added Robolectric test support for full-support, by moving
full-support/test's contents into full-support/test/instrumentation
and put the new Robolectric tests in full-support/test/robotest.
Bug: 36387078
Test: ./gradlew connectedAndroidTest test
Change-Id: Ib07ec0ddf07affa30c46e786f4e9be7853a243c4
om/android/setupwizardlib/test/ListViewRequireScrollHelperTest.java
om/android/setupwizardlib/test/RequireScrollHelperTest.java
|
| ab45bdf67a01ba13efb45334cc43f9632de6f034 |
26-Feb-2016 |
Maurice Lam <yukl@google.com> |
Support RecyclerView notifications in items
Propagate the recycler view notifications
notifyItem{Changed/Removed/Inserted} in ItemHierarchy so that
recycler view animations can be used with ItemHierarchy more
easily.
Test: ./gradlew connectedAndroidTest test
Bug: 36388000
Change-Id: I583952044995b174baec2610422611f6d40a9a11
om/android/setupwizardlib/test/ItemAdapterTest.java
om/android/setupwizardlib/test/ItemGroupTest.java
om/android/setupwizardlib/test/ItemTest.java
|
| 921c65f4b9dd01d331e8a80e3d165966c915d4fe |
18-Mar-2017 |
Maurice Lam <yukl@google.com> |
Add scroll indicator to bottom in GLIF theme
With sticky footer in GLIF theme, the divider should be shown between
the footer and the content if there is more stuff below the fold.
Test: ./gradlew connectedAndroidTest
Change-Id: I05b2241fa58c74f5c9bea3aebd54a1dca38ea390
om/android/setupwizardlib/test/GlifLayoutTest.java
|
| 039a55c144bc968ca9e242640ea107df10ac2867 |
03-Mar-2017 |
Maurice Lam <yukl@google.com> |
Add scroll indicators to GLIF Pixel theme
Add the scroll indicators to clearly indicate the divide between
status bar, content area, and footer, even though they all have the
same background color.
The scroll indicator will only be shown if there are content beyond
the fold.
Test: ./gradlew connectedAndroidTest test
Bug: 35446596
Change-Id: I5419e4f443a2414f8c983241b8fc61cadb48ef68
om/android/setupwizardlib/test/GlifLayoutTest.java
|
| 39056e5dc4b068745c2d9be69e5cd0c008bdc117 |
03-Mar-2017 |
Maurice Lam <yukl@google.com> |
Make status bar white on GLIF pixel theme
Add attributes suwBackgroundBaseColor and suwBackgroundPatterned to
GlifLayout, which allows the GLIF Pixel theme to display a solid
off-white status bar background instead of the pattern in regular
GLIF.
Test: ./gradlew connectedAndroidTest test
Bug: 35446596
Change-Id: Icbf3608882367ce00188fd124df5d2ba0de00864
om/android/setupwizardlib/test/GlifLayoutTest.java
|
| d3ffc713be68823409d5dc6d2d44bb21bde5bfd0 |
28-Feb-2017 |
Maurice Lam <yukl@google.com> |
Add center alignment for 2017 themes
Add "GLIF Pixel" theme that is a drop-in replacement for
SuwThemeGlif, which will center align the header and description
text.
To use GLIF Pixel theme, simply set the activity theme (using
android:theme or Activity#setTheme) to SuwThemeGlifPixel and use the
GLIF layouts normally.
Other theme attributes like status bar background will be done in a
separate CL.
Test: ./gradlew connectedAndroidTest test
Bug: 35446596
Change-Id: I3edee9cf80c1c84018ed08f47f9859e51a3936e6
om/android/setupwizardlib/test/GlifLayoutTest.java
om/android/setupwizardlib/test/WizardManagerHelperTest.java
|
| fca3ee628d9d5c1c1109f3df6e02cdd31c57c000 |
22-Feb-2017 |
Maurice Lam <yukl@google.com> |
Fix GLIF pattern for versions < L
For versions < L, setGlifPatternColor should still change the
background drawable, since they are visible on tablets.
Replaced the v21 specific attrs with attribute references in the
themes, removing the need for a separate version attrs.xml.
Moved GlifLayoutTest that doesn't require test XMLs to Robolectric,
so make SDK version testing easier. Robolectric on gradle doesn't
seem to have a good way to include test XMLs, so tests for XML
inflation are kept as instrumentation tests.
Test: ./gradlew connectedAndroidTest test
Change-Id: I36b3765848e462ee920c563a6fa335a0e67dd471
om/android/setupwizardlib/test/GlifLayoutTest.java
|
| 97860ddbfea1075cfd281102b93a3982c2b66537 |
22-Feb-2017 |
Maurice Lam <yukl@google.com> |
Fix ListMixinTest and RecyclerMixinTest for KitKat
A dexmaker issue with KitKat makes it so that accessing package
private methods on a spy will throw IllegalAccessError. Use mock with
delegatesTo instead to workaround the issue.
Test: ./gradlew connectedAndroidTest
Change-Id: I18ad132593a646e6955024caaef0238486b69703
om/android/setupwizardlib/template/ListMixinTest.java
|
| db0a8d653fb37519e10134470201f8e30bdb2c75 |
21-Feb-2017 |
Maurice Lam <yukl@google.com> |
Merge "Implement ButtonFooterMixin"
|
| 8721e6e37afdda2d3aba487334f96e270a57ad19 |
10-Feb-2017 |
Maurice Lam <yukl@google.com> |
Implement ButtonFooterMixin
The ButtonFooterMixin allows creating GLIF-compatible sticky footer
with buttons. The mixin assumes that buttons on the start side
(left for LTR) are borderless buttons and buttons on the end side
(right for LTR) are accent colored raised buttons.
Bug: 35448201
Test: ./gradlew connectedAndroidTest test
Change-Id: I26fc1a19290308f8d39466652308366e9677afbd
om/android/setupwizardlib/template/ButtonFooterMixinTest.java
|
| 9e8d18dc62c8a933a16f83a03ebab080897fd38e |
18-Feb-2017 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Add theme fallback"
|
| e2a8d27c2a43cf0b48b80e5b05f893222c541e04 |
17-Feb-2017 |
Maurice Lam <yukl@google.com> |
Add theme fallback
- Add FallbackThemeWrapper, which behaves like ContextThemeWrapper,
except that the base context's theme attributes takes precedence
over the wrapper context's.
- Use the FallbackThemeWrapper in TemplateLayout (SetupWizardLayout
and GlifLayout), so that inflating them with the wrong theme will
not crash, but rather look wrong.
This allows SuwLib to add required attributes without risking
crashing clients that for some reason doesn't use the right themes.
Test: ./gradlew connectedAndroidTest
Change-Id: I694ad7279ce733659f6aa5d72e2087a09d3f1e22
om/android/setupwizardlib/test/GlifLayoutTest.java
om/android/setupwizardlib/test/SetupWizardLayoutTest.java
om/android/setupwizardlib/util/FallbackThemeWrapperTest.java
|
| 2831318df83781bb5bada256e35726612d225052 |
14-Feb-2017 |
Maurice Lam <yukl@google.com> |
Fix ButtonItem theme in appcompat
Inflate the button from XML rather than calling the constructor
directly, so that AppCompatActivity can use the injected layout
inflater to tint the button drawables.
- Migrated existing ButtonItemTest to robolectric
- Added new ButtonItemDrawingTest as instrumentation test to test
the drawing behavior. Created DrawingTestHelper and
DrawingTestActivity to help in testing draw behaviors in normal and
AppCompat contexts.
Bug: 35325693
Test: ./gradlew connectedAndroidTest
Change-Id: Ic2215f5510c246a861ab109e3dffee49f9cf9b3c
om/android/setupwizardlib/test/ButtonItemTest.java
om/android/setupwizardlib/test/util/DrawingTestHelper.java
|
| b2ff57b17efb727c24b096ac7b1d7f8870bf1bde |
11-Feb-2017 |
Maurice Lam <yukl@google.com> |
Use constants=BuildConfig.class for robolectric
In robolectric tests, use @Config(constants=BuildConfig.class), which
is the "gradle way" to configure Robolectric. Added the hacks that
are needed to make that happen in our setup, like
PatchedGradleManifestFactory and the custom build directory lookup.
Having this change allows Robolectric tests to run against merged
resources, which means different build variants will now resolve
resources correctly. Previously a test would fail in, say, resolving
@style/SuwThemeGlif.
Also migrated GlifDimensionTest to run on Robolectric.
Test: ./gradlew test
Change-Id: Ia7231f95818891a649678a0a6da0220a44031bf7
om/android/setupwizardlib/test/GlifDimensionTest.java
|
| d349adb3941c88ae27ec451acd19641ba03205df |
26-Jan-2017 |
Maurice Lam <yukl@google.com> |
Add ListMixin
Add ListMixin to allow common interface to a TemplateLayout containing
lists.
Test: ./gradlew connectedAndroidTest
Change-Id: I6ebd2c5a83b14db534cf66e5de7fe12584441537
om/android/setupwizardlib/template/ListMixinTest.java
|
| c274e39f369114aa0bc54f695db84d7f598783b1 |
21-Jan-2017 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Migrate PartnerTest to Robolectric"
|
| 94b2ec08a88831548dcd811b016f953ca6f64ed5 |
18-Jan-2017 |
Maurice Lam <yukl@google.com> |
Merge "Remove material_blue constants"
|
| 5ed761c1df4f5165a14218b64579e14af29d68a6 |
13-Jan-2017 |
Maurice Lam <yukl@google.com> |
Fix ReflectionInflater
Don't append default package when the tag name itself is qualified
(i.e. contains a '.').
Also moved the inflater test cases into test/instrumentation to the
same place as other instrumentation tests. (Other tests were moved
with the introduction of Robolectric tests)
Bug: 34254689
Test: ./gradlew connectedAndroidTest
Change-Id: I2f22613f80b4e3a65a73c4a4f8bd084ad3d4654f
om/android/setupwizardlib/template/ColoredHeaderMixinTest.java
om/android/setupwizardlib/template/HeaderMixinTest.java
om/android/setupwizardlib/template/IconMixinTest.java
om/android/setupwizardlib/template/NavigationBarMixinTest.java
om/android/setupwizardlib/template/ProgressBarMixinTest.java
om/android/setupwizardlib/template/TemplateLayoutMixinTest.java
om/android/setupwizardlib/test/ReflectionInflaterTest.java
om/android/setupwizardlib/test/SimpleInflaterTest.java
|
| ae6590148b2af0848e8d8be391b840a4c19109ef |
12-Jan-2017 |
Maurice Lam <yukl@google.com> |
Remove material_blue constants
Those constants were never released and there are no references to
it on code search.
Test: Existing tests pass (./gradlew connectedAndroidTest)
Change-Id: I231a719414e436dc4204302d6211da8923282fa7
om/android/setupwizardlib/test/WizardManagerHelperTest.java
|
| 199cec9d40aef7ac34dd0cd4badae4eb2e7373c5 |
29-Dec-2016 |
Maurice Lam <yukl@google.com> |
Migrate PartnerTest to Robolectric
Since PartnerTest depends on resources, add BaseRobolectricTest class
to configure the manifest (and the SDK version).
In addition, to work around a Robolectric issue, add dependency on
Open GL API.
Test: ./gradlew test
Bug: 32975598
Change-Id: I41a8099197412ce6353c1920fb7b59d83fb7c9d5
om/android/setupwizardlib/test/PartnerTest.java
|
| 2e634640f3ed1b101f3748849b415fa14d57991c |
29-Dec-2016 |
Maurice Lam <yukl@google.com> |
Add robolectric test
Configure the build target and migrate LinkSpanTest to Robolectric.
Move existing instrumentation tests into test/instrumentation
Bug: 32975598
Test: ./gradlew test
Change-Id: I9bb39142c616a2c44fe38f48d92e89ab8ebda7ba
om/android/setupwizardlib/TemplateLayoutTest.java
om/android/setupwizardlib/test/BottomScrollViewTest.java
om/android/setupwizardlib/test/ButtonBarItemTest.java
om/android/setupwizardlib/test/ButtonItemTest.java
om/android/setupwizardlib/test/DrawableLayoutDirectionHelperTest.java
om/android/setupwizardlib/test/GlifDimensionTest.java
om/android/setupwizardlib/test/GlifLayoutTest.java
om/android/setupwizardlib/test/GlifListLayoutTest.java
om/android/setupwizardlib/test/GlifPatternDrawableTest.java
om/android/setupwizardlib/test/IllustrationTest.java
om/android/setupwizardlib/test/ItemAdapterTest.java
om/android/setupwizardlib/test/ItemGroupTest.java
om/android/setupwizardlib/test/ItemInflaterTest.java
om/android/setupwizardlib/test/ItemTest.java
om/android/setupwizardlib/test/ListViewRequireScrollHelperTest.java
om/android/setupwizardlib/test/PartnerTest.java
om/android/setupwizardlib/test/RequireScrollHelperTest.java
om/android/setupwizardlib/test/SetupWizardLayoutTest.java
om/android/setupwizardlib/test/SetupWizardListLayoutTest.java
om/android/setupwizardlib/test/SpanHelperTest.java
om/android/setupwizardlib/test/StatusBarBackgroundLayoutTest.java
om/android/setupwizardlib/test/SystemBarHelperTest.java
om/android/setupwizardlib/test/WizardManagerHelperTest.java
om/android/setupwizardlib/test/util/MockWindow.java
|