History log of /frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
3ced483cd038e9fd14490ac33b0d1f2d8d2517a4 09-May-2018 Jack Yu <jackyu@google.com> Fixed crash when RAT changes with tethering on

We should use the orignal APN setting used for data setup
to determine if the data connection has DUN capability.

Test: Manual
Bug: 78592192
Change-Id: I57c823061d49238c9c76deb54c59dbcf95153108
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
83c687ec72da1c98d962f4d5ea8ed072d3283258 20-Feb-2018 Nathan Harold <nharold@google.com> Grant Default Perms for DataService on Bind

When we bind to a DataService, it needs a
permissions grant that allows the data service
to access information relevant to setting up
a PDN connnection either over Cell (modem) or
over WiFi (using IWLAN w/ IPsec). This CL adds
a call to grant the required permissions for
those to work.

Bug: 66955045
Test: runtest frameworks-telephony (on taimen)
Change-Id: I9ae6edc0d5e01a99b1d630556cf25810c95fa50b
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
c6da9a6d7e12feeb09b9e3150df10e26c50b62d2 14-Mar-2018 Nathan Harold <nharold@google.com> Add a Test for NattKeepalive Unsupported on WLAN

Adds a test that verifies that NATT Keepalive requests
are rejected on WLAN while passed on WWAN.

Bug: 72417084
Test: runtest -x DataConnectionTest.java
Merged-In: I710cd8c47a712aec7211cfd026610bb7449743d8
Change-Id: I710cd8c47a712aec7211cfd026610bb7449743d8
(cherry picked from commit 8e990e5f4f1e98979bc633fc1435e30f7b99ac41)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
7afdb3942adde7efd33b5af5556fead92243e49c 08-Feb-2018 Nathan Harold <nharold@google.com> Pipe Radio 1.2 LCE to DataConnection

-Add a new LinkCapacityEstimate class to handle
both 1.0 and 1.2 formats of LCE for sending to
DataConnection.
-Convert to a multi-registrant so that all active
data connections can receive LCE updates.
-Add conversion for 1.2 LCE HAL to framework LCE.
-Automatically register for LCE when data connections
become active.
-If 1.2 or greater HAL is detected, we no longer start
the LCE service in the modem: rather it's always-on.

Bug: 72117292
Test: runtest frameworks-telephony
Change-Id: I076f2af404855cf961380559793b7328d7b83372
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
3c09fb7eec26ecb5e3b684d7e3f25c9df142775b 09-Feb-2018 Nathan Harold <nharold@google.com> NATT Keepalive Unit Test

-Fix a bug that DC was registering itself
twice for keepalive status notifications.

-Verify that callbacks register/unregister
when entering/exiting DC_ACTIVE state
-Verify that KA sessions are cached by a map
of slotId and sessionHandle.
-Verify that start/stop requests are sent to the
RIL as needed.
-Verify that KA sessions are cleaned up after a
call to stop()
-Verify that a failed keepalive is cleaned up and
the records are either not created or are created
and then deleted depending on the error scenario.

Bug: 72417084
Test: runtest -x DataConnectionTest.java
Change-Id: I113e170fe20b9bdd74c2670109b8271f2114dab1
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
71f909237a9921f52d91440fb8f9c6fc97465a52 04-Feb-2018 Jack Yu <jackyu@google.com> Connected with data service manager

Routed all data requests and respones through the
new cellular data service and data service manager.

Test: Telephony sanity tests + unit tests
Bug: 64132030
Merged-In: I66adf6492ee1952e20384c38add107c89da0ac41
Change-Id: I66adf6492ee1952e20384c38add107c89da0ac41
(cherry picked from commit 4b2c78c078d59466d18a4f7f926bb3bc0eccff9d)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
06ed6fceace1df6db89e2e4fa5b98da080a94435 31-Jan-2018 Jack Yu <jackyu@google.com> Added support for the new 1.2 data setup/deactivate API

Added support for the 1.2 IRadio APIs that support IWLAN handover.

Test: Telephony sanity tests
Bug: 64132030

Merged-In: I61840939fa7130b0ef1bc0353dd065486831679c
Change-Id: I61840939fa7130b0ef1bc0353dd065486831679c
(cherry picked from commit d5a7979d5c82f1fd568d80267216402bc9d8d0ba)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
99e1eab9e37ba86b8a1c8f8c82264ccf73c1dcfe 18-Jan-2018 Jeff Sharkey <jsharkey@android.com> Add ability to override subscriber capabilities.

In a future set of CLs, NPMS will offer to override a handful of
capabilities on a per-subId basis. Respond to these overrides
in the telephony code.

Add basic locking around collections that were unprotected
against cross-thread interactions.

Test: bit FrameworksNetTests:android.net.,com.android.server.net.
Test: bit FrameworksTelephonyTests:com.android.internal.telephony.dataconnection.DataConnectionTest
Bug: 64133169
Change-Id: Ia66bc5f420c3678bd940bc02c2adaefc7b9ecf90
(cherry picked from commit 92c66f10cbdb5f50c462c7be24c120b6edb04584)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
06e7286b5b3cc0fdbf09985adb553c7698e4f2c9 11-Jan-2018 Jack Yu <jackyu@google.com> Used LinkAddress insteaad of InterfaceAddress

Also removed InterfaceAddress which was added
in aosp/561351 since LinkAddress is exactly same
as InterfaceAddress.

Test: Telephony sanity tests
bug: 64132030
Merged-In: Iefc12dd025edb4f67cf0e9080da1ad8d6cfb63b5
Change-Id: Iefc12dd025edb4f67cf0e9080da1ad8d6cfb63b5
(cherry picked from commit 129675838ba8258b6c9ddba93c31fe15f17346a4)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
f894832e415f506b83eba61ea65bc6e683aacd58 12-Dec-2017 Jack Yu <jackyu@google.com> Fixed empty dns not properly handled issue

1. The original code was not moved correctly when moved
from data call response into data connection in ag/3296869.
2. Removed the unnecessary stack trace print.
3. Added a new unit test to cover empty dns case.

Test: Unit tests + Telephony sanity tests.
bug: 70506433
Merged-In: Id95304705d3fd0560c0104621c407ad9f8f1148c
Change-Id: Id95304705d3fd0560c0104621c407ad9f8f1148c
(cherry picked from commit 5a9a6b847f268adf37e41f74a755c8c8f8661cc2)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
c0a3ed8c70021d47cd55bbc1406a9cf63bd6afe2 30-Nov-2017 Jack Yu <jackyu@google.com> Moved data connection response into system api.

This is a preliminary step for IWLAN refactoring, where data response
will be one of the parameter in data service callback.

Test: Telephony sanity tests
bug: 64132030
Merged-In: Ie3cfc59c98bdd362a89207dc517f92619fa2278a
Change-Id: Ie3cfc59c98bdd362a89207dc517f92619fa2278a
(cherry picked from commit 3f8bd3dd2c7bceeab44854231411e9517417b944)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
886183cde1263ea524cdf08524442724e246ed42 20-Nov-2017 Jack Yu <jackyu@google.com> Moved DataProfile from telephony internal hidden API to System API

This is the preliminary change in order to make the new data call
setup API for IWLAN refactoring.

Test: Telephony sanity tests + unit tests
bug: 64132030

Merged-In: I5aa50001ef6374b080c10eb29e59363c21008639
Change-Id: I34b9a40b587092f28ffe5d5c96a4e3636f52ed53
(cherry picked from commit b02e63a76e4c3d5e364b0d0017e1a0f57916959d)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
1deef79497a77ee936242ee56750cca989fbd95f 29-Nov-2017 Jack Yu <jackyu@google.com> Merge "Combined setLinkProperties in DataConnection and DataResponse"
am: 462b114734

Change-Id: I779cae44e62f737d3627fd58a0789508a889f55d
a21232c2c1956555bad5832d78f0526d7962b197 29-Nov-2017 Jack Yu <jackyu@google.com> Combined setLinkProperties in DataConnection and DataResponse

1. Merged the method setLinkProperties from DataCallResponse into
the same method in DataConnection.
2. Made gateways field in DataCallResponse final.
3. Moved SetupResult into DataConnection.

This is the preliminary step of moving DataResponse to system API
so it can be part of the data service API, which is required by
IWLAN refactoring.

Test: Telephony sanity tests
bug: 64132030
Merged-In: I434c4f1553954fdda0c58c2eada888d7d6087af4
Change-Id: I434c4f1553954fdda0c58c2eada888d7d6087af4
(cherry picked from commit 86632debcc5a94a8a1a2f9995eb407e26ca2869a)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
4caa11d8e1d6790b2813d48a91924492a60b5156 20-Nov-2017 Jack Yu <jackyu@google.com> Moved DataProfile from telephony internal hidden API to System API

This is the preliminary change in order to make the new data call
setup API for IWLAN refactoring.

Test: Telephony sanity tests + unit tests
bug: 64132030

Merged-In: I320632be0d50b03c948b02fa664640ecfb401357
Change-Id: I21aa0ac07d251804716dd88846e7b4913673cdc9
(cherry picked from commit b02e63a76e4c3d5e364b0d0017e1a0f57916959d)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
58c265414152e6dc948d491c58cf3fd17f28d14f 28-Nov-2017 Jack Yu <jackyu@google.com> Merge "Revert "Moved DataProfile from telephony internal hidden API to System API""
am: ff4c852798

Change-Id: I55a242e3d23f94358c78ce9aeaff2055f26a17f9
3a953e80c4f83c153fcebc71a9814b77f320bc19 28-Nov-2017 Jack Yu <jackyu@google.com> Merge "Moved DataProfile from telephony internal hidden API to System API"
am: 3fd8b3ecfd

Change-Id: I031c600f0d2a8cac02a24eed7fb58e9a4fa87146
4bb301ce081b348fbb8b6b7a990e0c6e65b9e039 28-Nov-2017 Jack Yu <jackyu@google.com> Revert "Moved DataProfile from telephony internal hidden API to System API"

This reverts commit c36b42eb847959f451900d1eac4e32be180a0b99.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I7fd9fbb181fcc74de585e3224ed230e029db1049
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
c36b42eb847959f451900d1eac4e32be180a0b99 20-Nov-2017 Jack Yu <jackyu@google.com> Moved DataProfile from telephony internal hidden API to System API

This is the preliminary change in order to make the new data call
setup API for IWLAN refactoring.

Test: Telephony sanity tests + unit tests
bug: 64132030

Merged-In: I320632be0d50b03c948b02fa664640ecfb401357
Change-Id: I320632be0d50b03c948b02fa664640ecfb401357
(cherry picked from commit b02e63a76e4c3d5e364b0d0017e1a0f57916959d)
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
41da47291be208a78a9908d000756945760fdc50 03-Aug-2017 Narayan Kamath <narayan@google.com> Merge "DataConnection: Use InetAddress.isNumeric rather than a regex." am: 39eda215ad am: 1f2b12fe1b am: 06030c1830
am: 7d5ac28f51

Change-Id: Ia25fe35cb3f92758fbd25c5a262f5cc778bbb12c
9532f2980833b32446de2b3762bd993ec6de1b62 01-Aug-2017 Narayan Kamath <narayan@google.com> DataConnection: Use InetAddress.isNumeric rather than a regex.

android.util.Patterns is pretty heavy weight; it can take a long
time to initialize and can increase java heap usage (dirty memory)
by hundreds of kilobytes. InetAddress.isNumeric provides the same
functionality using getaddrinfo(..AI_NUMERIC) and friends, and
provides a guarantee that the resulting string will be parseable
by InetAddress.getByName and friends can parse it correctly.

Bug: 63107244
Test: DataConnectionTest

Change-Id: I9078aea83dd2da621576ff3328b975bd65c00b72
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
947183ce4b882fcffefea8d3fd50750a997a58b6 12-Jul-2017 Jeff Sharkey <jsharkey@android.com> Follow removal of NetworkInfo metered flag.

The OS now completely relies on NET_CAPABILITY_NOT_METERED to avoid
confusion and staleness.

Bug: 63391323
Test: builds, boots, Wi-Fi policy is upgraded
Change-Id: I306092056f7c350081688bc2fdfbb97a1b25f00c
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
16fb750132532b5d3012576fa52805e3546551f7 23-May-2017 Jack Yu <jackyu@google.com> Fixed file descriptor leak in telephony unit tests

The handler thread in SimulatedCommands was not closed after
each unit test run. Fixed by adding a dispose method to quit
the thread.

Also use quit() instead of quitSafely() for all thread quiting
because we don't care if the messages were dispatched or not
after the test. This can fix some messages sending to dead
threads non-harmful exceptions in the output debug messages.

Test: Telephony unit tests
bug: 29579544
Merged-In: I112e46b0147a1950046a35cd9ac2498560c6ee1b
Change-Id: I112e46b0147a1950046a35cd9ac2498560c6ee1b
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
ae6e8f99bdb297f906d6dcdc0a385ba27eee47fd 23-May-2017 Jack Yu <jackyu@google.com> Fixed file descriptor leak in telephony unit tests

The handler thread in SimulatedCommands was not closed after
each unit test run. Fixed by adding a dispose method to quit
the thread.

Also use quit() instead of quitSafely() for all thread quiting
because we don't care if the messages were dispatched or not
after the test. This can fix some messages sending to dead
threads non-harmful exceptions in the output debug messages.

Test: Telephony unit tests
bug: 29579544
Change-Id: I112e46b0147a1950046a35cd9ac2498560c6ee1b
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
c92c9085143cc80dfc0e36336325fc4945a95fcd 03-Apr-2017 Jack Yu <jackyu@google.com> Merged makeNetworkCapabilities and getCopyNetworkCapabilities

Merge two identical methods into getNetworkCapabilities. This
is the preliminary work for unmetered mms fix for b/30936226.

Test: build
bug: 30936226
Merged-In: I2e41dd1ecac03da12b47c843f1f10c500026aa28
Change-Id: I2e41dd1ecac03da12b47c843f1f10c500026aa28
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
6289b21a3b9f0214a862878096384d8ce90a572c 03-Apr-2017 Jack Yu <jackyu@google.com> Merged makeNetworkCapabilities and getCopyNetworkCapabilities

Merge two identical methods into getNetworkCapabilities. This
is the preliminary work for unmetered mms fix for b/30936226.

Test: build
bug: 30936226
Change-Id: I2e41dd1ecac03da12b47c843f1f10c500026aa28
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
caecd75617c11d33e000c4d90f8a6557c5b2de7e 13-Feb-2017 Jack Yu <jackyu@google.com> Data call refactoring and hidlization

Support the new HIDL interface for data call APIs.
The affacted APIs are RIL_REQUEST_SETUP_DATA_CALL,
RIL_REQUEST_SET_DATA_PROFILE, RIL_REQUEST_SET_INITIAL_ATTACH_APN
More parameters are passing down to the modem to address
some issues we had earlier.

bug: 32224135, 30173958, 33561503, 30282096, 32020264
Test: Telephony sanity tests, unit tests

Merged-In: I239baa144bcee413f67e77c6b79b4ae5278077e8
Change-Id: I239baa144bcee413f67e77c6b79b4ae5278077e8
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
8e9d1e601dce62cd0328701d7054e03db24727c7 13-Feb-2017 Jack Yu <jackyu@google.com> Data call refactoring and hidlization

Support the new HIDL interface for data call APIs.
The affacted APIs are RIL_REQUEST_SETUP_DATA_CALL,
RIL_REQUEST_SET_DATA_PROFILE, RIL_REQUEST_SET_INITIAL_ATTACH_APN
More parameters are passing down to the modem to address some
issues we had earlier.

bug: 32224135, 30173958, 33561503, 30282096, 32020264
Test: Telephony sanity tests, unit tests

Change-Id: I239baa144bcee413f67e77c6b79b4ae5278077e8
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
48a5ba5d3cc80ffaaa82caed6f2344166da99c08 31-Aug-2016 Jack Yu <jackyu@google.com> Fixed failing unit test cases.

bug: 31041734
Change-Id: Ia633484f768ea7565abf497a8689866a6eea264a
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
7e9240253edb59e0aa657de434faa1ccdf17a742 29-Aug-2016 Amit Mahajan <amitmahajan@google.com> Fixed failing tests.

Also marked some of them @Postsubmit.

Bug: 31041734
Change-Id: I9a93bbb6d7f9c28fa90bab260d837761bc07eb77
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
38ea8753cf66bbdca0257e2c9bd02befec61764a 26-Aug-2016 Amit Mahajan <amitmahajan@google.com> Mark flaky/failing tests as @Postsubmit.

This is done so that telephony tests can be enabled for presubmit.
All tests not passing at least 95% of the time are marked
@Postsubmit. Test passing metrics are based on
go/tel-nyc-mr1-apct-dashboard and go/tel-master-apct-dashboard.
These tests will be fixed as part of b/29579544.

Bug: 31041734
Change-Id: I5e65e94696b6526eb3c270238fd80795319ea2ff
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
a8201a7b8ce12cfada51784ebe06534e35c2ae04 12-Aug-2016 Jack Yu <jackyu@google.com> Set NetworkInfo's meter flag when capability changes.

bug: 30812533
Change-Id: Ib25eebc5f439895317c4011384b1b10a330911b3
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
0852a954be5937a1b0bca94df0c2007d7ee3c0c7 13-Apr-2016 Jack Yu <jackyu@google.com> Fixed that data retry didn't happen issue

When modem return -1 as the retry value in setup data call response,
we should interpret it correctly and retry the data connection.

bug: 27787361
Change-Id: I0a3e442f5125730dd9a196ce632120b44b880090
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java
e3f497323441d0c9215f6cbad9ce950f054cce72 09-Mar-2016 Jack Yu <jackyu@google.com> Added unit test cases for DataConnection

bug: 25691077
Change-Id: I90920c7625ec7f8f716fbab15f65c7f4323628cc
/frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataConnectionTest.java