History log of /frameworks/rs/rsScriptGroup.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
82e135c4bbe18855d8ed02632bb074f8da0b96e0 28-Feb-2017 Miao Wang <miaowang@google.com> Remove libutils.so dependency from libRSDriver, libRSCpuRef, and most
parts of libRS_internal.

NOTE: we're resolving dependencies to provide a model for vendors.
For us, all this code is above the HAL, thus the dependencies
are acceptable; whereas for vendors, their equivalent of this code is
below the HAL, and so the dependencies are not acceptable.

This CL resolves the libutils dependency by:
- Implement the timings functions in android::renderscript namespace
using NDK APIs, instead of using libutils counterparts.
- Replace android::Vector and android::String8 by std::vector and
std::string.
- PROPERTY_VALUE_MAX is replaced as PROP_VALUE_MAX.

This CL didn't resolve the libutils dependency of rsFont.cpp and
rsDebugger.cpp in libRS_internal:
The dependent functionality in rsDebugHelper.h is off by default, and
only intended for use during development; and rsFont.cpp is part of
graphics API which is not implemented below the HAL and is not used as
a model by vendors.

Additionally, this CL fixed the bug that mNodes was sorted in a
decreasing order. Nodes in ScriptGroup should be executed in
ascending order. The bad sort was only for support lib; so there was a
previously-unknown bug in support lib implementation of ScriptGroup.

Background:
libutils contains a collection of things like Vector, String8,
CallStack. It served the purpose similar to a STL library, when there
was no stable STL implementation available in Android. And most
importantly, it is not part of NDK.
Support lib used to use our own implementations of android::Vector and
android::String8, because it can only depend on NDK, similarly for the
timing related functions.
As part of the Treble requirements, native RS, including vendor version
libRS_internal, libRSDriver, libRSCpuRef could only depend on NDK
too. So we need to break the dependency on libutils. And since we now
have reasonable support of STLs, we should use that instead.

Bug: 34396220
Test: mm, and all CTS tests pass on Bullhead;
RsTest and RSTest_CompatLib (both native and compat path) also pass.
Change-Id: Ib9a37d16235c1dcd0f5bae3b95c374e394483c91
/frameworks/rs/rsScriptGroup.cpp
62237219e567b9f972c86e7ca4e96f9b3d5ad4de 28-Feb-2017 Miao Wang <miaowang@google.com> Remove RS_SERVER macros and references to unused headers.

- The RS_SERVER macros were intended to have a version of RenderScript
running on the desktop. It has not fully worked for a very long time.

Bug: 35473587
Test: build and CTS tests pass
Change-Id: I0da3fc9d4601951442384d05f9dbecaeddeff8cc
/frameworks/rs/rsScriptGroup.cpp
11496ac131bb691edf5bdcab3029dceef5c1e4e1 16-Nov-2016 Chih-Hung Hsieh <chh@google.com> Fix google-build-using-namespace warnings in rs.

* Most files define classes in renderscript namespace.
Define them in the namespace instead of "using namespace ...".
Some files define global C++ names, and we replace
"using namespace ..." with using declarations of the required names.
* Add "NOLINT" comment to rsg_generator.c output code to suppress
such warnings.

Bug: 32670901
Test: build with WITH_TIDY=1
Change-Id: I9b0edcad3e1fb37c79927b05fd58fb1a301bdf22
/frameworks/rs/rsScriptGroup.cpp
c2459dc5f1c9d299247f77d565c5be5dc57c75e0 25-Mar-2016 Yang Ni <yangni@google.com> Remove unused variables

Bug: 27272549

Also removed unused return value of FifoSocket::init().

Change-Id: Ia5db289a0daefdb3dd8802b5b7e539545e488da2
/frameworks/rs/rsScriptGroup.cpp
b8353c5943f4038fd7f08db3d958390ce9418798 15-Feb-2015 Yang Ni <yangni@google.com> Revert "Replaced android::Vector with std::vector."

b/19148482

This reverts commit 93d6bc872b7d9fba63abfa7513d56b38d9c3d371.

I also made some changes to Make it work with HEAD.

Change-Id: I5e516976ec1d85ffe1cf388c01795348a9441982
/frameworks/rs/rsScriptGroup.cpp
d52f6605dc83955e2f9f669be08536baf9604895 07-Feb-2015 Miao Wang <miaowang@google.com> Fix the typo of ScriptGroup::execute

Change-Id: Ibc7de2ada0da1c4f15fc84e4a87677162060cf73
/frameworks/rs/rsScriptGroup.cpp
61d5ed595d77cd1eedc0c9dbf563214075946121 16-Jan-2015 Yong Chen <yong.a.chen@intel.com> Fix memory leak due to ~ScriptGroup does not clear alloc refs

Change-Id: I6920487d88c8a0c6850d533cdf2f89bb1464bbae
Signed-off-by: Yong Chen <yong.a.chen@intel.com>
/frameworks/rs/rsScriptGroup.cpp
1ffd86b448d78366190c540f98f8b6d641cdb6cf 07-Jan-2015 Yang Ni <yangni@google.com> New Script Group API: runtime and cpu driver support.

Change-Id: I9c612cf8874aabaf0ca7d1640567464c71ed3070
/frameworks/rs/rsScriptGroup.cpp
44bef6fba6244292b751387f3d6c31cca96c28ad 12-Aug-2014 Chris Wailes <chriswailes@google.com> Replace NULL macros with nullptr literals.

Change-Id: I918c40879aa547438f77e7d1a95fa2aa33bec398
/frameworks/rs/rsScriptGroup.cpp
93d6bc872b7d9fba63abfa7513d56b38d9c3d371 29-Jul-2014 Chris Wailes <chriswailes@google.com> Replaced android::Vector with std::vector.

Change-Id: I4c6abd964dc4b1412ec2e592fc8e835fecfe53f6
/frameworks/rs/rsScriptGroup.cpp
f37121300217d3b39ab66dd9c8881bcbcad932df 17-Jul-2014 Chris Wailes <chriswailes@google.com> Collapse code paths for single- and multi-input kernels.

This patch simplifies the RenderScript driver and CPU reference implementation
by removing the distinction between sing- and multi-input kernels in many
places. The distinction is maintained in some places due to the need to
maintain backwards compatibility. This permits the deletion of some functions
and struct members that are no longer needed. Several related functions were
also cleaned up.

Change-Id: Id70a223ea5e3aa2b0b935b2b7f9af933339ae8a4
/frameworks/rs/rsScriptGroup.cpp
4b2bea3dc20865f3a198797702e19912a6a2171c 13-Aug-2014 Stephen Hines <srhines@google.com> Revert "Collapse code paths for single- and multi-input kernels."

This reverts commit 818cfa034e257c7bb48356257f5cb67334e19aa6.

Change-Id: I59f39f52e6c8f60bb01cbcb8ccf2215eaf46a57f
/frameworks/rs/rsScriptGroup.cpp
818cfa034e257c7bb48356257f5cb67334e19aa6 17-Jul-2014 Chris Wailes <chriswailes@google.com> Collapse code paths for single- and multi-input kernels.

This patch simplifies the RenderScript driver and CPU reference implementation
by removing the distinction between sing- and multi-input kernels in many
places. The distinction is maintained in some places due to the need to
maintain backwards compatibility. This permits the deletion of some functions
and struct members that are no longer needed. Several related functions were
also cleaned up.

Change-Id: I77e4b155cc7ca1581b05bf901c70ae53a9ff0b12
/frameworks/rs/rsScriptGroup.cpp
5f6f16fe612e1c30732becc66205500994889ac9 25-Jul-2014 Yang Ni <yangni@google.com> Validate input/output for a ScriptGroup.

If a script group requires input or output allocations, make sure
they are set before starting the execution of the script group.
If any allocation is missing, skip the execution and set a bad
value error with a message.

Change-Id: I7ee2da96aca3e6c9820225e6b2c39cb9378cb42f
/frameworks/rs/rsScriptGroup.cpp
b0934b67b95cc27e2358c2aa4db5f7c1067c8f9b 04-Jul-2013 Stephen Hines <srhines@google.com> Remove libutils and fix rsDebug for RS support library.

Bug: 9664050

Our bitcode runtime library translates vector rsDebug() calls into passing
their parameters via pointers. The previous version of libRSSupport.so was
being created with non-pointer versions of these routines accidentally.
This change also fixes a missing permission issue for ImageProcessing2, so
that the compatibility library can be verified.

This change also removes the use of libutils by switching the implementation of
String8/Vector in the compatibility library to internal types backed by
libstlport_static.

Change-Id: I20da75e8c19a82a42dc2bceaba1937d21372db84
/frameworks/rs/rsScriptGroup.cpp
61c86951f6a1192fafc536aee613beb6f899064b 10-Apr-2013 Stephen Hines <srhines@google.com> Add incUserRef() for ScriptGroup/ScriptKernelID/ScriptFieldID.

Bug: 8530206

This change also fixes a small bug in zeroUserRef(), where we mistakenly
decrement the zeroed out count.

Change-Id: I5097e59faad52291218657c10e99c598a00ad84b
/frameworks/rs/rsScriptGroup.cpp
0b575de8ed0b628d84d256f5846500b0385979bd 15-Mar-2013 Tim Murray <timmurray@google.com> Add x86 server support.

Change-Id: I674acaf15b67afa48bc736f72942a11e2e38e940
/frameworks/rs/rsScriptGroup.cpp
dbe66d6783c1e53cd1572de0ef6ef6fdf6f76f48 17-Sep-2012 Jason Sams <jsams@google.com> Add backed for script groups.

Change-Id: If2fdbde7381fcdaeb54d41a913b855fd83d4f186
/frameworks/rs/rsScriptGroup.cpp