349e2285f933743829cdef1810106d62d0f1c4fc |
|
03-May-2018 |
Anthony Chen <ajchen@google.com> |
Expand the touch target size for supplemental icons. To accomplish this, use a TouchDelegate. This means that only the supplemental icon can have a TouchDelegate since all other views share a common parent. If there is a need for other views to also have an expanded touch target, that refactoring can happen at that time. Bug: 79108547 Test: car:connectedCheck Test: build sample app and check touch targets for TextListItemActivity and SeekbarListItemActivity. Change-Id: I588b48ae8691b2931a835323623c8cff3f3babf1
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
52a80988da3d27f591abd43faa27eae120996ec2 |
|
26-Apr-2018 |
Anthony Chen <ajchen@google.com> |
Make complyWithUxRestrictions() protected instead of package private. This allows ListItem.ViewHolder to be extendable outside of the support lib package. Bug: 78643055 Test: ./gradlew car:connectedCheck Change-Id: I23f64c37936a979db24d8568ad894141f0e518e3
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
65ec7f1338516c11ea1442912a22d50033fe8fb8 |
|
03-Apr-2018 |
Yao, Yuxing <yaoyx@google.com> |
Support setting supplemental icon with drawable. Bug: 77496999 Test: ./gradlew :car:connectedCheck Change-Id: Ib55b5d23dcd9b377f52089b5e66226daf74d653e
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
d966fe86972fad3a06b915535acc78a5386824c6 |
|
13-Mar-2018 |
Yao, Yuxing <yaoyx@google.com> |
Remove nested LinearLayout in TextListItem. Bug: 70353770 Test: ./gradlew :car:connectedCheck # Also verified in demo apk. Change-Id: If75b13c12af19714dc9c27b7e09930c4745401f5
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
ac5fe7c617c66850fff75a9fce9979c6e5674b0f |
|
06-Mar-2018 |
Aurimas Liutikas <aurimas@google.com> |
Refactor support library Test: None Change-Id: I92e450c739fc9d77e8f8840bed4165ab88247fd6
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
f27b1ffc67228d73326ec3426fef4c9db75cd6fd |
|
06-Mar-2018 |
Aurimas Liutikas <aurimas@google.com> |
Revert "Refactor support library." This reverts commit b31c3281d870e9abb673db239234d580dcc4feff. Change-Id: Icfa5b9af633739ad2c857dff22a2181bac6661ef
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
b31c3281d870e9abb673db239234d580dcc4feff |
|
20-Feb-2018 |
Aurimas Liutikas <aurimas@google.com> |
Refactor support library. Test: None Change-Id: I11a047324832801555673dac45ec1d6590a6338b
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
fed7322872fe0e2f786a8d8c09a024a2fabd62c8 |
|
05-Mar-2018 |
Anthony Chen <ajchen@google.com> |
Fix error when setting textAppearances. Previously, the TextListItem was not setting the correct text appearance for title and body text when the body text is supposed to be the primary text. Test: run car:connectedCheck Change-Id: Ie6edaa53f404339e776a9a117128bc27a706b994 Fixes: 74129843
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
15c4392796f5bb261c632412953db3fe753f9dda |
|
28-Feb-2018 |
Anthony Chen <ajchen@google.com> |
Create a dark theme for applications to extend. This theme will automatically color all PagedListViews and the drawer to be dark. Note, that the "light" versions of these themes right now are just pass-throughs for the base theme. Refactoring this requires touching many applications, so keeping it the same for now. Lastly, the dark themes just use the night colors for now. Eventually, the dark colors in the day should be slightly different. Test: Test in a sample app. Bug: 74088862 Change-Id: I12f1c1531267ff43622ce2853bb13cbb31cee3ab
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
461cc7c0bdf1c9f9f609cacda1ac9228b4281d51 |
|
27-Feb-2018 |
Yao, Yuxing <yaoyx@google.com> |
Use explicit function instead of lambda. Also make methods that uses drivingstate API non-public. Fixes: 73902945 73904539 Test: ./gradlew :support-car-demos:installDebug Change-Id: Ibeca9119f30633d02e31c921acaa08203a5f3701
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
01d01f75491903e13913da5ac050ee86b31dc464 |
|
23-Feb-2018 |
Yao, Yuxing <yaoyx@google.com> |
Always set OnClickListener on binding. This is to avoid ViewHolder carrying-over onClickListener from previous bound item. Fixes: 73829886 Test: ./gradlew :car:connectedCheck Change-Id: I83685ecc225f6f605abf0a90da39848b402cd038
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
b308672ec84f4ca7b49c6640135cdc58b49dc46d |
|
16-Feb-2018 |
Anthony Chen <ajchen@google.com> |
Refactor car support themes. The naming now falls more inline with Android theme naming conventions. This will also allow for future extensions to be more granular. For example, the main car themes now have "Light" included in them. There will be a "Dark" theme in upcoming commits. Test: build mojave and deploy. Bug: 73501454 Change-Id: Ie0a910cefa66eba3c94a85db092e03a148a8098e
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
3737d1dff953969c27652b49b010ea9902b3da4f |
|
07-Feb-2018 |
Yao, Yuxing <yaoyx@google.com> |
Support UXR in drawer and list item adapter. Bug: 72970870 Fixes: 72160941 Test: ./gradlew :car:connectedCheck make target for generating the stubs.jar is in ag/3569597. - All tests will only run on automotive devices now due to implicit dependency on android.car. - We are ignoring exception from Car/UXR. Exception comes from car connection failure, which should be handled in UxrManager so default behavior (fully restricted vs. no restrictions) can be configured by OEMs. Also this way 3rd party apps will not need to worry about retrying. - We are opting for unrestricted mode when UXR is unavailable. This is more of a product decision to be made. So current decision is taking the easier route. - APIs in car support lib cannot expose APIs from android.car, namely implementing OnUXRChangedListener, since android.car stub is only available at compile time. Change-Id: I4903838d9e21b3ba68508345bbbafa6fbab29ac4
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
a92a509e61fef9b8065f4c5aeeb8727f3724202e |
|
03-Feb-2018 |
Yao, Yuxing <yaoyx@google.com> |
Add a method to toggle switch in TextListItem. Bug: 72881918 Test: ./gradlew :car:connectedCheck Change-Id: I77cb1324644d32af85fca3ed08bbbeb4cf1327f1
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
20e9f85df9325d7dc79750be2527bd8dd1c38fcb |
|
25-Jan-2018 |
Yao, Yuxing <yaoyx@google.com> |
Support clearing up custom view binders by: create ViewHolder that accepts view binders for clearing up. move addViewBinders() to parent ListItem class. create new abstract methods in ListItem that used in bind(). change ListItemAdapter to expect ListItem instead of generic RecyclerView type. Fixes: 71721195 Test: ./gradlew :car:connectedCheck Change-Id: I48686b3dfe7feeb96c447af72a428950f89f2baf
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
172425512285f6da3c69b9405738df1f064336c1 |
|
17-Jan-2018 |
Yao, Yuxing <yaoyx@google.com> |
Update ListItem API from Builder to setters. This allows ListItem to be modified post construction, e.g. changing icon based on Wifi state. Bug: 70578638 Test: ./gradlew :car:connectedCheck # Also verified in demo apk. Change-Id: If7364917ad93ee68f6d3c5d9002cbe29840af596
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
4e832ea4269fff1780e0726c16bc37584957ba10 |
|
18-Dec-2017 |
Yao, Yuxing <yaoyx@google.com> |
Support list item with seekbar. This CL includes several changes: - Add abstract ListItem type - Rename the original ListItem to TextListItem - Add SeekbarListItem that extends ListItem with Car Seekbar style Change-Id: Ic1ecd7ea986b91c45d08fcfd661077c6857da762 Fixes: 70578577 Test: ./gradlew :car:connectedCheck
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
acdf6a30e3d5b12defece58c35cfca2129838264 |
|
10-Jan-2018 |
Yuxing Yao <yaoyx@google.com> |
Revert "Support list item with seekbar." This reverts commit 9ee1e2cb4f8f711403148ff57c800a25d6d8e178. Reason for revert: accidentally enabled auto-submit. i made a few major changes so would like another round of review. Change-Id: I231928e51307cfe5ce6337bb784cf080e445ede4
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|
9ee1e2cb4f8f711403148ff57c800a25d6d8e178 |
|
18-Dec-2017 |
Yao, Yuxing <yaoyx@google.com> |
Support list item with seekbar. This CL includes several changes: - Add abstract ListItem type - Rename the original ListItem to TextListItem - Add SeekbarListItem that extends ListItem with Car Seekbar style Fixes: 70578577 Test: ./gradlew :car:connectedCheck Change-Id: I36819c16ac7521a8700c6a731bac393b900ce122
/frameworks/support/car/src/main/java/androidx/car/widget/TextListItem.java
|