| 28f10aef67d29479eb0821b63967450e1bcee8e4 |
01-Jun-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Clickable errors from sage args plugin
Test: errors in studio are clickable
Change-Id: I612190966d0ba29c2690ec424bcbd5afba7af0a8
otlin/androidx/navigation/safe/args/generator/Context.kt
otlin/androidx/navigation/safe/args/generator/GeneratorOutput.kt
otlin/androidx/navigation/safe/args/generator/NavLogger.kt
otlin/androidx/navigation/safe/args/generator/NavParser.kt
otlin/androidx/navigation/safe/args/generator/NavSafeArgsGenerator.kt
otlin/androidx/navigation/safe/args/generator/XmlContext.kt
otlin/androidx/navigation/safe/args/generator/XmlContextParser.kt
otlin/androidx/navigation/safe/args/generator/XmlPosition.kt
otlin/androidx/navigation/safe/args/generator/XmlPositionParser.kt
|
| 73d7c77fb8b34198d06bf1d0f672accbdcac61a9 |
15-May-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Report errors with fileName, line and column
bug: 79627172
Test: InvalidXmlTest
Change-Id: I1c39802def04d5ecae244f7cbf8244f53917d6d5
otlin/androidx/navigation/safe/args/generator/NavParser.kt
otlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
otlin/androidx/navigation/safe/args/generator/NavSafeArgsGenerator.kt
otlin/androidx/navigation/safe/args/generator/Types.kt
otlin/androidx/navigation/safe/args/generator/XmlContext.kt
otlin/androidx/navigation/safe/args/generator/XmlContextParser.kt
otlin/androidx/navigation/safe/args/generator/XmlPullParserExt.kt
|
| e2120a18a83f308acbf732f823aeda1d1be9c5a0 |
27-Apr-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Boolean type support
Test: new and old tests pass
Change-Id: I076a0e15ed9c472df4e063687dee67fee69659d4
otlin/androidx/navigation/safe/args/generator/NavParser.kt
otlin/androidx/navigation/safe/args/generator/Types.kt
|
| 3554be52da710d28a78fc55ec21c98d22d9fd437 |
27-Apr-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Float type support
Test: new and old tests pass
Change-Id: I916e7185e3a5d31f717dadc2923af5475416aef4
otlin/androidx/navigation/safe/args/generator/NavParser.kt
otlin/androidx/navigation/safe/args/generator/Types.kt
|
| b265bf1dc4efe0263667b48aafd7c638b16a154a |
04-Apr-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Infer args types
Test: NavParserTest#testArgInference
Change-Id: Id239a7b28289b80f6352ded4f97aa0180f4258f7
otlin/androidx/navigation/safe/args/generator/NavParser.kt
|
| 0be67c5018839811c475a706b46bdb8ef185e632 |
03-Apr-2018 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Make ArgumentsGenerationTask incremental" into flatfoot-navigation
|
| 7e7dfaccd4c66e8eec029590c334b3839c3d09b7 |
09-Mar-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Make ArgumentsGenerationTask incremental
Test: PluginTest
Change-Id: I10af03a1d3f045cda2a7cd1c1d543c76d1466b4e
otlin/androidx/navigation/safe/args/generator/NavSafeArgsGenerator.kt
|
| e287a49fd22dc33cdb989945866bdf7095ef356c |
07-Mar-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Fix class name resolution for relative names with subpackages
bug: 74205407
Test: DestinationTest
Change-Id: Ic844774d735084eb74c586f6a454a5c0a98f6925
otlin/androidx/navigation/safe/args/generator/models/Destination.kt
|
| b25fc0b0bf1ad4e0ead5980fb911d932cb9becc2 |
19-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Merge "Improvements for generated code" into flatfoot-navigation
|
| ca9ad8f7124dc9f61b59c6c981084b7a62701bf6 |
17-Feb-2018 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Support hex ints" into flatfoot-navigation
|
| 4466fd24c092861816ffa85b5c101d914fae634a |
17-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Support hex ints
Test: NavParserTest
Change-Id: Ica6d2927c8e9e4ebb9ad34703e19375a9f27870c
otlin/androidx/navigation/safe/args/generator/NavParser.kt
|
| 1fff02f2f847b3ac9731fb9e0cd55ceb63fdb864 |
17-Feb-2018 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Remove options from NavDirections" into flatfoot-navigation
|
| e1b804a9825ee15f382c36db13956bd42d324d82 |
17-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Improvements for generated code
- use "this." when accessing fields, so they don't mix with local vars
- make build() method "public"
Test: NavWriterTest
Change-Id: I99cddf6dff75877a3ea805d6f115b6195f48aba2
otlin/androidx/navigation/safe/args/generator/NavWriter.kt
|
| 2c3e4c4b0b2af61fe21ec9e70176dd1e0a4bfa46 |
16-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Remove options from NavDirections
Also return action id instead of destination id, so options'd be
correctly added in runtime.
Test: NavWriterTest
Change-Id: I8110bccd1528f454e7453df7bcdb44868e07a693
otlin/androidx/navigation/safe/args/generator/NavWriter.kt
|
| ad4c2c52bea7874b9af121ed7492efad54c54d91 |
16-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Actually write Args file
Test: NavGeneratorTest#test
Change-Id: Ib3dca9979e53e4a856e625c5b36cd910f9f412e0
otlin/androidx/navigation/safe/args/generator/NavSafeArgsGenerator.kt
|
| 1503d52153986fdcfe7e744795010708b7410892 |
15-Feb-2018 |
Ian Lake <ilake@google.com> |
Move Navigation to androidx.navigation package
Test: existing tests pass
BUG: 73496185
Change-Id: I8b4f08b1aa5f9c5678816f47302463fb14e2c629
otlin/android/arch/navigation/safe/args/generator/NavArgumentResolver.kt
otlin/android/arch/navigation/safe/args/generator/NavParser.kt
otlin/android/arch/navigation/safe/args/generator/NavSafeArgsGenerator.kt
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/Types.kt
otlin/android/arch/navigation/safe/args/generator/XmlPullParserExt.kt
otlin/android/arch/navigation/safe/args/generator/ext/NavJavaPoet_ext.kt
otlin/android/arch/navigation/safe/args/generator/models/Action.kt
otlin/android/arch/navigation/safe/args/generator/models/Argument.kt
otlin/android/arch/navigation/safe/args/generator/models/Destination.kt
otlin/android/arch/navigation/safe/args/generator/models/ResReference.kt
otlin/androidx/navigation/safe/args/generator/NavArgumentResolver.kt
otlin/androidx/navigation/safe/args/generator/NavParser.kt
otlin/androidx/navigation/safe/args/generator/NavSafeArgsGenerator.kt
otlin/androidx/navigation/safe/args/generator/NavWriter.kt
otlin/androidx/navigation/safe/args/generator/Types.kt
otlin/androidx/navigation/safe/args/generator/XmlPullParserExt.kt
otlin/androidx/navigation/safe/args/generator/ext/NavJavaPoet_ext.kt
otlin/androidx/navigation/safe/args/generator/models/Action.kt
otlin/androidx/navigation/safe/args/generator/models/Argument.kt
otlin/androidx/navigation/safe/args/generator/models/Destination.kt
otlin/androidx/navigation/safe/args/generator/models/ResReference.kt
|
| 433ea43ba238254f9cf01f8e959ef1a7c9b66f51 |
09-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Add Builder class for Args
Also allow to modify required parameters in direction classes
Test: ./gradlew :nav:safe-args-gen:test
Change-Id: Ia5ecca75ee05a7e523339ede5968df759d193d27
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
|
| 9ca584405af88767f97ec06fbb5f5e1b7e98b1b4 |
09-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Support resource references as types
Test: ./gradlew :nav:safe-args-gen:test
Change-Id: Ia9064ec7e1cdc4e8bb415a09ed356dc59da1df09
otlin/android/arch/navigation/safe/args/generator/NavArgumentResolver.kt
otlin/android/arch/navigation/safe/args/generator/NavParser.kt
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/Types.kt
otlin/android/arch/navigation/safe/args/generator/models/Action.kt
otlin/android/arch/navigation/safe/args/generator/models/Argument.kt
otlin/android/arch/navigation/safe/args/generator/models/Destination.kt
otlin/android/arch/navigation/safe/args/generator/models/Id.kt
otlin/android/arch/navigation/safe/args/generator/models/ResReference.kt
|
| 90ee199ee11cc50ff6abbad162cca5c4b75fa3fc |
30-Jan-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Generate args classes
Test: ./gradlew :nav:safe-args-gen:test
Change-Id: If364b9c346fc652ef50b9313d1f5b7f50c8962b2
otlin/android/arch/navigation/safe/args/generator/NavParser.kt
otlin/android/arch/navigation/safe/args/generator/NavSafeArgsGenerator.kt
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/Types.kt
otlin/android/arch/navigation/safe/args/generator/models/Destination.kt
|
| b324f579abfa7aa78a8dbd67ca2d2e02e8a8714c |
06-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Merge "Infrastructure for different types." into flatfoot-navigation
|
| fb97caaf48ddb265adca54c03569b2ea7ab5a390 |
02-Feb-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Support distinction between applicationId and R class package
Test: MainDestinationTest, FlavorDestinationTest
Change-Id: I02f945e54363ef922ce5480bc823624a374e21ee
otlin/android/arch/navigation/safe/args/generator/NavSafeArgsGenerator.kt
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
|
| 9f96cb0c8832d66c2c0a20690241bab243621b02 |
25-Jan-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Use correct package name for generated classes
Test: ./gradlew :nav:safe-args-gen:test
Change-Id: I3706394b48726069c92ad425fb67b8486e13711c
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/models/Destination.kt
|
| f49d36a214375ac9a735ab9af9e1b3a4b9d2a3cd |
20-Jan-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Infrastructure for different types.
This patch adds support of decimal int
Test: ./gradlew :nav:safe-args-gen:test
Change-Id: I10c170ed9b87484131281c37694a6d1e34eee677
otlin/android/arch/navigation/safe/args/generator/NavArgumentResolver.kt
otlin/android/arch/navigation/safe/args/generator/NavParser.kt
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/Types.kt
otlin/android/arch/navigation/safe/args/generator/ext/NavJavaPoet_ext.kt
otlin/android/arch/navigation/safe/args/generator/models/Argument.kt
|
| 973a5c08a9d5a6951830f9dc6c0fa875392491e4 |
12-Jan-2018 |
Sergey Vasilinets <sergeyv@google.com> |
Naive safeargs gradle plugin + test infrastructure
Test: ./gradlew :nav:safe-args-gradle-pl:test
Change-Id: I5279d502cb2cd1288c412f724d553bdf52cfb31b
otlin/android/arch/navigation/safe/args/generator/NavSafeArgsGenerator.kt
|
| d88974530aa8463cd0d66cdc7ff8bf77ca7fca72 |
07-Dec-2017 |
Sergey Vasilinets <sergeyv@google.com> |
Resolve arguments for destinations
Test: NavArgumentResolverTest
Change-Id: I4d067dbb7c59d3f13d997fec08e7633aa92d5c95
otlin/android/arch/navigation/safe/args/generator/NavArgumentResolver.kt
|
| 9007455f4c0c977fc456c8d50caa72ff385183b0 |
06-Dec-2017 |
Sergey Vasilinets <sergeyv@google.com> |
Parse id in destinations
Also it makes Id in Action nullable
Test: NavWriterTest/NavParserTest
Change-Id: I9fea8fa23aa86910980e60d566f0289f8e915b68
otlin/android/arch/navigation/safe/args/generator/NavParser.kt
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/models/Action.kt
otlin/android/arch/navigation/safe/args/generator/models/Destination.kt
|
| 0b9982004dda5288caf194f062249cbad7ecb3c4 |
05-Dec-2017 |
Sergey Vasilinets <sergeyv@google.com> |
Proper Id parsing
Test: NavParserTest
Change-Id: I1adbd2dfcc9a397709926a115f96c9fc0a3ce006
otlin/android/arch/navigation/safe/args/generator/NavParser.kt
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/models/Action.kt
otlin/android/arch/navigation/safe/args/generator/models/Id.kt
|
| 16e05dcb2c2b47193b55239be6ae498f7e6e082a |
01-Dec-2017 |
Sergey Vasilinets <sergeyv@google.com> |
Naive writer for NavDirections
Test: NavWriter
Change-Id: I5476f8abb976e6b3de378e87b1a4ea4b92166505
otlin/android/arch/navigation/safe/args/generator/NavWriter.kt
otlin/android/arch/navigation/safe/args/generator/models/Destination.kt
|
| b3e31f33297405a0a5dd0182a42403722f6aad2c |
09-Nov-2017 |
Sergey Vasilinets <sergeyv@google.com> |
Naive parser for navigation files
Test: NavParserTest
Change-Id: Ifd5b47e2f7deb13c54b22fca84a13b9ea3e020be
otlin/android/arch/navigation/safe/args/generator/NavParser.kt
otlin/android/arch/navigation/safe/args/generator/XmlPullParserExt.kt
otlin/android/arch/navigation/safe/args/generator/models/Action.kt
otlin/android/arch/navigation/safe/args/generator/models/Argument.kt
otlin/android/arch/navigation/safe/args/generator/models/Destination.kt
|