| 62588b69f6289e2ccb7a363a4b0727d51b76bfb5 |
|
20-Dec-2017 |
Kevin Rocard <krocard@google.com> |
Audio V4: Make effect default wrapper device independent
What was done in this patch:
# move headers in all-versions/default folder for qualified inclusion
mkdir -p audio/effect/all-versions/include/effect/all-versions/default/
mv audio/effect/all-versions/*[hp] $_
# Go in the all-versions header folder
cd $_
# Use a macro for the version
sed -i '/^#/!s/V2_0/AUDIO_HAL_VERSION/g' *
#Remove 2.0 includes
sed -i "/include.*2.0/d" *
# Add include guard to make sure AUDIO_HAL_VERSION is set
sed -i '/limitations under the License/!b;N;a\n#include <common/all-versions/IncludeGuard.h>' *
# Remove guard include macro
sed -i '/^#.*[H_]$/d' *
# Remove LOG_TAG
sed -i '/LOG_TAG/d' *
# Remove local include (include "XXX")
sed -i '/include.*"/{N;/\n$/d;D}' *
# Replace implementation with inclusion
cd audio/effect/2.0/
git checkout HEAD^^
ls *h *cpp| sed -r 's/.*h$/\0 \0/;s/(.*)cpp/\1impl.h \0/' |xargs -L1 printf '1h;2,$H;$!d;g;s$namespace.*}[^\\n]*$#define AUDIO_HAL_VERSION V2_0\\\n#include <effect/all-versions/default/%s>\\\n#undef AUDIO_HAL_VERSION$\000%s\000'|xargs -0 -n2 sed -i
+ manual update of Android.bp and removal of duplicate include
Bug: 38184704
Test: compile
Change-Id: If99871516f3069fcb9e699ab670a665d7d507e7d
/hardware/interfaces/audio/effect/2.0/default/BassBoostEffect.cpp
|
| 1bd2a336bc13b14a7fd556ce6e39b6b4c1d3b1c8 |
|
14-Dec-2017 |
Kevin Rocard <krocard@google.com> |
Audio V4: Move the legacy effect wrapper before refactor
This will make diff much more clear and allow git to follow the files.
Bug: 38184704
Test: compile
Change-Id: I90deaad883a52ef8fbcd3109937f90d46d458f8c
Signed-off-by: Kevin Rocard <krocard@google.com>
/hardware/interfaces/audio/effect/2.0/default/BassBoostEffect.cpp
|
| 22505e6bf1959d2b2217a399f75e0721631718d5 |
|
15-Dec-2017 |
Kevin Rocard <krocard@google.com> |
Audio V4: Fix issues in the effect legacy wrapper raised by clang-format
This patch only contains cosmetic reformatting imposed by clang-format.
Bug: 38184704
Test: compile
Change-Id: If5e61eecd0a67fec19997792c9db73936ce7be2e
Signed-off-by: Kevin Rocard <krocard@google.com>
/hardware/interfaces/audio/effect/2.0/default/BassBoostEffect.cpp
|
| f4f2ff39746a36b3d657e34ec1724589051b1ec8 |
|
19-Jan-2017 |
Mikhail Naganov <mnaganov@google.com> |
audiohal: Fix volume changes handling
Some legacy implementations of the effects HAL use the condition
of the reply buffer being NULL as an indication that they shouldn't
apply attenuation to the input audio data. Therefore, separate
methods are needed to distinguish the use cases of delegating the
volume control to the effect, and just informing the effect of the
volume changes.
A new method added to IEffect: volumeChangeNotification that implements
the second use case. The contract of setAndGetVolume method has been
updated to indicate that it is only called in the first use case.
Also updated the wrapper for a generic IEffect commands to pass NULL
pointers to the command and reply buffers in case when the size
of the input or output data is 0, to preserve compatibility with
direct calls from the framework.
Bug: 34368451
Test: volume control works when both Bass Boost and Equalizer are
enabled in the NXP implementation of the effects
Change-Id: I3c9a5bbdff561802bc94080c51703385a8903282
/hardware/interfaces/audio/effect/2.0/default/BassBoostEffect.cpp
|
| a331de14219b34b08f4cbb462a45f1fd82a92d48 |
|
05-Jan-2017 |
Mikhail Naganov <mnaganov@google.com> |
audiohal: Re-implement effect process using FMQ and IMemory
Result: no hwbinder calls due music processing.
Added IEffect.close method for explicitly freeing up of resources
consumed by the effect before automatic server objects reaping
gets to it.
Added IEffect.setProcessBuffers method for updating the input /
output buffers on the go.
Test: make, use Play Music with effects, check traces
Bug: 30222631
Change-Id: Ia1e1bc7098fab59aa970e0ce4acdb48007409644
/hardware/interfaces/audio/effect/2.0/default/BassBoostEffect.cpp
|
| f9d303435d80161fabb16cdff3b8f2f75f362480 |
|
30-Nov-2016 |
Yifan Hong <elsk@google.com> |
Update to use the correct logging library.
Test: mma compiles
Change-Id: Idb33dea5faaf1a5e54719c2a5a683d2d47e9b8e8
/hardware/interfaces/audio/effect/2.0/default/BassBoostEffect.cpp
|
| 7cbf2f1fb15a2a7d9b8b61ca81ad93fa9ddcaea3 |
|
28-Oct-2016 |
Mikhail Naganov <mnaganov@google.com> |
Implement audio effects HAL delegating to legacy HAL
Changes made to the .hal definition:
- added missing generated Result for methods implemented via legacy
"command" function;
- fixed Aux Channels feature definition;
- added "size" parameter for reply data in cases where the wrapper
needs to allocate a reply buffer;
- added method for generic support of feature configs;
- added new Result type;
- use arrays instead of strings in effect descriptor to ease
conversion from / to legacy HAL;
- added missing method to the Preset Reverb interface;
- fixed names of the Visualizer enums to avoid clashes with defines
from the legacy HAL file.
The implementation isn't hooked up to the server yet. Need to implement
devices and streams first.
Bug: 30222631
Change-Id: I75bb42f19ac3303759e918b6d6a91646b1555f8c
Test: make
/hardware/interfaces/audio/effect/2.0/default/BassBoostEffect.cpp
|