| 40d3a9bd8c62714ee58f9363c4456f764aa5a95d |
|
29-Mar-2017 |
Andreas Huber <andih@google.com> |
Convert all comments into "doxygen-ready" comments.
Bug: 36453077
Test: mma
Change-Id: I0b1f77dfae5d2258969e33d85ecf45401ffbdfaa
/hardware/interfaces/audio/effect/2.0/types.hal
|
| b0abafbf0a6174e8c8933cc5fb19501a2d22c53b |
|
01-Feb-2017 |
Mikhail Naganov <mnaganov@google.com> |
audiohal: Make closing of effects and streams fast
There were two problems:
1. Joining of reader / writer / process threads (the threads that
interact with HAL) was taking up to 1 second because the thread
was usually waiting for an event flag to be toggled, or a 1s
timeout.
2. Calling IStream.close or IEffect.close shouldn't tax the caller.
Changed the code so a call to close only signals the thread that
it's time to exit, and then the thread is only joined in the
effect or stream destructor.
Bug: 34800063
Bug: 34499806
Test: see repro steps in the bugs
Change-Id: Ife20524a1eba4ec9a78152e89862526e8cd5c960
/hardware/interfaces/audio/effect/2.0/types.hal
|
| a331de14219b34b08f4cbb462a45f1fd82a92d48 |
|
05-Jan-2017 |
Mikhail Naganov <mnaganov@google.com> |
audiohal: Re-implement effect process using FMQ and IMemory
Result: no hwbinder calls due music processing.
Added IEffect.close method for explicitly freeing up of resources
consumed by the effect before automatic server objects reaping
gets to it.
Added IEffect.setProcessBuffers method for updating the input /
output buffers on the go.
Test: make, use Play Music with effects, check traces
Bug: 30222631
Change-Id: Ia1e1bc7098fab59aa970e0ce4acdb48007409644
/hardware/interfaces/audio/effect/2.0/types.hal
|
| d26dc50abbad068cd1a673f204fa538c1c61bdb2 |
|
29-Nov-2016 |
Steven Moreland <smoreland@google.com> |
Always specify underlying enum type.
Bug: 33197891
Test: compiles
Change-Id: I3d4822ea9a665708302d3bd1460425fddf1dcda9
/hardware/interfaces/audio/effect/2.0/types.hal
|
| 7cbf2f1fb15a2a7d9b8b61ca81ad93fa9ddcaea3 |
|
28-Oct-2016 |
Mikhail Naganov <mnaganov@google.com> |
Implement audio effects HAL delegating to legacy HAL
Changes made to the .hal definition:
- added missing generated Result for methods implemented via legacy
"command" function;
- fixed Aux Channels feature definition;
- added "size" parameter for reply data in cases where the wrapper
needs to allocate a reply buffer;
- added method for generic support of feature configs;
- added new Result type;
- use arrays instead of strings in effect descriptor to ease
conversion from / to legacy HAL;
- added missing method to the Preset Reverb interface;
- fixed names of the Visualizer enums to avoid clashes with defines
from the legacy HAL file.
The implementation isn't hooked up to the server yet. Need to implement
devices and streams first.
Bug: 30222631
Change-Id: I75bb42f19ac3303759e918b6d6a91646b1555f8c
Test: make
/hardware/interfaces/audio/effect/2.0/types.hal
|
| c1158951544817f1433c68aaef3e1f42ab6e780e |
|
11-Oct-2016 |
Mikhail Naganov <mnaganov@google.com> |
Remove redundant prefixes from enums in audio common types and effects HAL
Since in generated C++ code class enums are used, the names of enum
values are scoped anyway, thus carrying the prefix only clutters
code.
For C enums, newly introduced "value_prefix" annotation is used
to add the required prefix.
Added annotations for effects HAL types are just informational,
but can be used would C headers generation ever be required.
Also:
- renamed AudioInputFlags -> AudioInputFlag for consistency;
- moved AUDIO_INTERLEAVE_... constants into their own enum.
Bug: 31800672
Change-Id: I5b325f3440e0057ca98c4617040c7e5a89d2283d
Test: make
/hardware/interfaces/audio/effect/2.0/types.hal
|
| 40be06cdf3a34856144574cf5e70b60e4ad4940c |
|
28-Sep-2016 |
Mikhail Naganov <mnaganov@google.com> |
Define HAL for audio effects
Created after hardware/audio_effect.h with the following changes:
- names changed to satisfy HAL style guide;
- defined an interface per effect, an interface method
per command, and getter / setter methods for properties;
- retained methods for executing proprietary commands
and accessing proprietary properties, only to be used
for third-party software effects;
- HIDL vector type is used instead of count / array pairs;
- provider callback changed to be used over RPC;
- 'dump' is method is already defined by generated code.
Note that audio data is currently transferred using AudioBuffers,
which is not effective due to memory copy and HwBinder transaction
involved. The transfer method will be changed to FastMessageQueue.
Bug: 30222631
Test: make
Change-Id: Ic8ea5c19688610ebe642c7597d2bcfa3226977e7
/hardware/interfaces/audio/effect/2.0/types.hal
|