| e637aa32b86dec4778ac8dd934266bb3755bc773 |
|
18-Aug-2017 |
Nick Desaulniers <ndesaulniers@google.com> |
biometrics: fingerprint: add locking to default impl
There exists the following race condition:
a). thread A receives setNotify and sets the callback to some object
b). thread B of the wrapped implementation calls
BiometricsFingerprint::notify which it was given a handle to. Thread B
executes past the nullptr check:
c). thread A receives setNotify and sets the callback to some other
object (or nullptr)
d). thread B resumes in notify with unknown state
Add mutex to protect access to mClientCallback.
Change-Id: I9163204ff5802e9246056caeb2a7857e6138531c
Fixes: 64802340
Test: VtsHalBiometricsFingerprintV2_1IfaceFuzzer
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 10dfcc14dcab31318db1a73d2788d4e28656e487 |
|
25-Apr-2017 |
Kevin Chyn <kchyn@google.com> |
Add onAcquired log back
It was in fingerprintd, which is replaced now
Fixes: 37677260
Test: touch FP when enrolling/authenticating and make sure
onAcquired log is there
Change-Id: Iadecdfa1c18b0aaa083de18dbe7f701c78465ace
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 04b086dd08cd492e1860d23845334786b16d9154 |
|
15-Apr-2017 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "setActiveGroup null, 0 length, unwritable dir should fail" into oc-dev
|
| d7e9b0fdc7e2c461973e34568fbca8f5bd0c0373 |
|
07-Apr-2017 |
Kevin Chyn <kchyn@google.com> |
setActiveGroup null, 0 length, unwritable dir should fail
with this change, VTS test needs to run in /data/system/
due to SELinux policy + Linux directory permissions
Test: run VTS tests and make sure they all pass
Fixes 37153318
Change-Id: Ib1f19ce7fc0d08ae2941aec5c08c5857c7a9f2fd
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 750ede4cf9c0f09b14bfbd8c6066292bd27a7f33 |
|
14-Apr-2017 |
Steven Moreland <smoreland@google.com> |
fingerprint: clean up includes
Bug: 33241851
Test: links
Test: works with BOARD_VNDK_VERSION := current
Change-Id: I7cfec2b8459964edf9a180d01cfdd90dae376fb9
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| d361f033d46f85af7e6de0b81d7a5914d2794979 |
|
07-Apr-2017 |
Jim Miller <jaggies@google.com> |
Log errno
Bug 36790737
Test: ensure errno is logged
Change-Id: Ifa9a0b6ee0baebfdfce894622ef40888dd83dddf
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 8174a847f24b09262166f43fa16dc218ea715a35 |
|
20-Mar-2017 |
Nick Desaulniers <ndesaulniers@google.com> |
fingerprint: check return status of hwbinder calls
If system_server dies, and return codes of hwbinder calls are not
checked, an abort of the HAL service will occur. In this case,
warn in the logs, but allow system_server to reopen HAL.
Bug: 34867134
Change-Id: I9fe1c2c0f1c03e8debafb56bff8a7490ccbbcec0
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 20105c8b71859c7dc4567053b72ab4861e8a2d8a |
|
07-Feb-2017 |
Nick Desaulniers <ndesaulniers@google.com> |
Fingerprint VTS
Bug: 34179855
Test:
make vts;
adb push
out/host/linux-x86/vts/android-vts/testcases/DATA/nativetest64/fingerprint_hidl_hal_test/fingerprint_hidl_hal_test
/data/local/tmp/.;
adb shell /data/local/tmp/fingerprint_hidl_hal_test;
Change-Id: If9174dc34d0802388a9af8cda88b28329248bc42
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 2b60a7d5e104847de718adc5a2f8b2f427854999 |
|
31-Jan-2017 |
Yifan Hong <elsk@google.com> |
nit fix: compiler warning for BiometricsFingerprint.cpp
Test: make -j64 compiles without warning
Change-Id: Ieb8e9cd081a4e0511031b7a01deb0f7368a9d70e
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 5f26c1ace2d63797c585de24bbe7123ba224622e |
|
20-Jan-2017 |
Jim Miller <jaggies@google.com> |
clean up default fingerprint HIDL@2.1 implementation
- remove Binder dependency by passing keystore token to onAuthenticated()
- move notify() to cpp file
Test: recovers from killing keystore, fingerprint unlocks device,
FingerprintDialog works with crypto objects.
Fixes bug 34264028
Change-Id: Ic0de31603f4bc4147d6faf014af89e787b1ef244
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| a47afa94395c0c0102d68a911a11236639a3a0b7 |
|
20-Jan-2017 |
Janis Danisevskis <jdanis@google.com> |
Adjust for minor changes in the native keystore client interface
Test: boot and use fingerprint to get an auth token
Change-Id: Ib5089457f31d17b73842e5aa4c73e61b590e6fbd
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 7f7eb474ce3e57cc7582ea5fece1dd5108cd7158 |
|
19-Jan-2017 |
Jim Miller <jaggies@google.com> |
Fix fingerprint crypto operations.
This fixes a bug introduced in the HIDL port where fingerprint no
longer notifies keystore of authentications.
Test: keyguard, FingerprintDialog
Fixes bug 34200870
Change-Id: I5227a5f7feb9eee926ea1511001d0303c90dc594
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 902de51533645294a29008e858841da7fb372868 |
|
16-Dec-2016 |
Jim Miller <jaggies@google.com> |
have hal2.1 register as the fingerprint service
Test: fingerprint's should be add-able.
Bug: 33199080
Change-Id: I30dd26c484848163ad63ee9bbd45f1d1ae869a14
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 52640ee9e13f2c9d453935bc3daadad97b77c147 |
|
10-Nov-2016 |
Sasha Levitskiy <sanek@google.com> |
Fingerprint: Treble: Fix compatibility in the interface description
Bug: 31973669
Test: Human functionality test
Change-Id: I7e3ef8eb9fbcd88a1a22e2e8bbae71756e079862
Signed-off-by: Sasha Levitskiy <sanek@google.com>
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|
| 965bd32a70f17836796124dd7e3dc8c44a1449c5 |
|
21-Oct-2016 |
Sasha Levitskiy <sanek@google.com> |
Fingerprint: HIDL: add default HAL 2.1 implementation
Test: Manual fingerprint functionality verification.
Bug: 31973669
Change-Id: Ib8bcf602ba0c8884b13d31eb23baa88a912ace20
Signed-off-by: Sasha Levitskiy <sanek@google.com>
/hardware/interfaces/biometrics/fingerprint/2.1/default/BiometricsFingerprint.cpp
|