History log of /hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
5d901420712fca4fe97b14e8364c6d68d47b53c7 06-Apr-2018 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Camera: various external camera fixes" into pi-dev
aa91a992eb870de3f903610dd1b1e9321b8b65a1 04-Apr-2018 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Camera: use finer lock in external camera OutputThread" into pi-dev
bc0e16519f6f0b98508720d11be34e871be7470f 03-Apr-2018 Emilian Peev <epeev@google.com> Camera: Check external camera v4l2 buffer size

V4L2 buffer size should fall within a reasonable range
like (0. width*height*2]. Check and return appropriate
status in case the size is not within this range.

Bug: 72261912
Test: Camera CTS
Change-Id: I1945dc734afb552ecb8d4ef74c9198eca8ce00e7
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
2d61bfd2b0faee0a8daddfdec1fe0541d0e16f71 14-Mar-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: various external camera fixes

1. Add EXIF MAKE/MODEL tag
2. Add retry loop for V4L2 open failure
3. Do not add external camera if ExternalCameraDevice cannot be
initialized

Bug: 72261912
Bug: 72569850
Change-Id: I06df1fbbb4afabea1a9a74aca9e288b24966cb0b
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
94f52a39c2c82fd296ef1e906a5f474f10936c81 07-Mar-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: use finer lock in external camera OutputThread

To avoid OutputThread waiting for mLock.

Test: CTS RecordingTest + systrace
Bug: 72261744
Change-Id: If387a1d4a2b0081c4bc43cb648a98e3706864f19
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
c15a1cab6f7ac4ba7cd30cf7441aa08423c228ae 02-Mar-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: more external camera CTS fix

Also update default external camera config to prevent
over promising peformance on lower end devices.

Test: API2 CTS tests except RecordingTest
Bug: 72261744
Change-Id: I20310606520099abf0f5173690f4aaf56a3e52a9
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
8b699aaf374f3b17219d1bfd3d97346c0635541a 01-Mar-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: various external camera CTS fixes

1. Update the FPS range to list (0.5*fps, fps) only
as webcams tends to skip a lot of frames and not
able to output at stable framerate.
2. Exif: don't expect focal length to present
3. Thumbnail: allow 0x0 size for no thumbnail output
4. Allow retry some ioctl during configureStream as
some webcams seems having problem in quick close
reopen operation.

Test: CTS CameraTest
Bug: 72261912
Change-Id: Ic23b7fb293b7579694c59240e854d750c842886d
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
e99cf209ded7b27f377f7ffb8fb967eaecc64949 28-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: add profiling traces

Bug: 72261744
Change-Id: I82e4d8ecc702c12bb7beb4f3d9979869ce6f4ac2
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
3aa9ae979c4250afa58572ef04671d905d9e4f74 24-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: add external camera fps control

V4L2 doesn't seem to allow changing fps at runtime, so we need to
wait until pipeline is idle and reconfigure V4L2 streams.

Also update the fps filtering logic to make sure supported fps
are consistent as long as the major dimension is the same.
Ex: for 4:3 webcams, all 1280*N sizes has the same fps set, or
for 16:9 webcams, all N*720 sizes has the same fps set.

Bug: 72261912
Change-Id: I534f09bebadb2f532a030a841633a8be7d3a87cc
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
8c76b8c4653966e5e04df80b98f26fa458436aa0 21-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Merge "Camera: avoid copying of HalRequest"
fa5aafbec3ac38d174579b1ffc23ec333a868163 21-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Merge "Camera: implement external camera dumpState/close"
e086fb7b4a91e20533f6f17d0e307f02ee221b6e 16-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: avoid copying of HalRequest

Bug: 64874137
Change-Id: I46ea14facf467921da633cde7e24ff9703a6a8f7
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
4a3393cd8aaf5eeb6ff037368ebd03f540da208f 14-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: implement external camera dumpState/close

Also switch to v4l2 timestamp is it's MONOTONIC

Test: Cts CameraDeviceTest
Bug: 72261676
Change-Id: Iec82c254dcf16a56952ff8910d13c92782d48090
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
d477e1e092ec8249f50dcd354950ad86ba7e6d0d 16-Feb-2018 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Camera: implement external camera flush"
72eb5eea6b5c2a35dbb574f7381ff07d86e3063a 14-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Merge "Camera: use rational/double for external camera framerate"
190e5601d6efdac6134fdf626001590015a4a255 14-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: implement external camera flush

Test: CTS abort capture test
Bug: 72261676
Change-Id: I0c3af8693a885672953ff394121c40c5ade59964
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
9eee6a9fd18b0e712a567d59586877e4b7412d72 13-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Merge "Camera: plumb external camera API1 support"
134093a43fa3430c913eb3b48726c42510a1e6ad 12-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: use rational/double for external camera framerate

For better precision.
Ex: minFrameDuration of 30fps 333333334->333333333

Bug: 72261912
Change-Id: I830d694d34eb01426e46279c4c986d8879b9d847
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
1798249b8f8a47bab9e7b96ef4ec1b13ae76aa6f 06-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: plumb external camera API1 support

And also some refactoring to unify external camera
config file logics.

Bug: 72261912
Change-Id: If83d779c57540809bdaa58a5a32cf4ade734fafe
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
0a2a9fc18cdbf318b1f9312074084cbd16595ede 06-Feb-2018 Eino-Ville Talvala <etalvala@google.com> camera.device@3.4/metadata@3.3: Revise MOTION_TRACKING capability

Simplify the API for the P release

- Remove new templates
- Update docs
- Also update some metadata docs from prior changes

Test: Revised Camera CTS passes
Bug: 63629224
Change-Id: I47fb170052cf6062955278ace624a91e8a0078b3
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
9cdd6f951608e680a3bccbf986c602b3c8b56bbd 01-Feb-2018 Yuriy Romanenko <yromanenko@google.com> External: Switch to legacy V4L2 buffer mapping

Required for older kernels like 3.x

Change-Id: I0680320b606727bdb0b22dab1df8c5954d623f10
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
fe1192ecfc96c723234dbc12bcf1aab917152307 06-Feb-2018 TreeHugger Robot <treehugger-gerrit@google.com> Merge "External camera: add device config file"
1e089661785333668afd7d5562aa7155625b6aab 03-Feb-2018 Yin-Chia Yeh <yinchiayeh@google.com> Camera: fix external camera FD double close

Release fence close was handled by freeReleaseFences so
hidl_handle should not own the native handle.

Test: running external camera on marlin
Bug: 64874137
Change-Id: I68e76d31985380eb3c502276df07d3648f67b6f1
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
53f4cb140a6254f9c41b140fd2d49eb0177ebd69 29-Jan-2018 Yin-Chia Yeh <yinchiayeh@google.com> External camera: add device config file

Also remove sizes cannot be cropped from maximal
size.

Bug: 72261897
Change-Id: Icb50cfa58a12e80be3cacc49569fac90be03c8e5
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
e932f1b5cb1dd3ba0d9c3fe537b340607c41f132 20-Jan-2018 Yuriy Romanenko <yromanenko@google.com> Implement JPEG support in external camera HAL

* Certain tests are still failing

Change-Id: I01bb90757cd969ace30857a8d246e4701498d379
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
083de0c3c6331fa7921028eebe15fc4a34e5138e 27-Jan-2018 Yuriy Romanenko <yromanenko@google.com> ExternalCameraDeviceSession: Fix request initialization

This code was exiting because of unsupported RequestTemplate::*
enum values that are now just ignored.

Change-Id: I37f79cbbfe99664ec173458721d71947f0d002ff
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
354db50595b2b44bb432d1af751887b33ee21ea4 26-Jan-2018 TreeHugger Robot <treehugger-gerrit@google.com> Merge "External Camera: more CTS fix"
4acd76e647a0e229fda04c244eedb80e3218795d 24-Jan-2018 Yin-Chia Yeh <yinchiayeh@google.com> External Camera: fix aspect ratio/crop issue

Also switch to new EXTERNAL hardware level.

Test: ImageReaderTest#testAllOutputYUVResolutions pass
Bug: 72261912
Change-Id: I95f05a20827b413bfa480b0336fff395159678eb
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
fb1c15434256c208916d13d63c0df221491e2535 25-Jan-2018 Yin-Chia Yeh <yinchiayeh@google.com> External Camera: more CTS fix

Test: CameraDeviceTest, CaptureResultTest, StaticMetadataTest
ExtendedCameraCharacteristicsTest, RobustnessTest
Bug: 72261912

Change-Id: Id99d86db99a905afcc41d3e9d297ce3533d852a2
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
658d30d3c84bf656032adcd7bc7bf5e82e8203e1 18-Jan-2018 Eino-Ville Talvala <etalvala@google.com> camera.device@3.4: Add MOTION_TRACKING template enums

- Extend RequestTemplate with two new values
- Add legacy wrapper support for the new templates

Test: Builds, camera continues to run. CTS coverage of templates
tests new templates as expected.
Bug: 63629224
Change-Id: I2a44d86a815690798fa4b8327794c64716d134ee
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp
1903059507815cc89e9cf268f73d86b2bb3feef7 20-Oct-2017 Yin-Chia Yeh <yinchiayeh@google.com> Camera: Add external camera provider

Bug: 64874137 63873538

Change-Id: I4309874a7dedd3dd71d4bd0c2004d460421db679
/hardware/interfaces/camera/device/3.4/default/ExternalCameraDeviceSession.cpp