| 9df082e93368ae2cc86e706f1f106a4422df1e42 |
|
24-Jan-2018 |
Dmitry Shmidt <dimitrysh@google.com> |
camera 3_4: Fix compilation errors
Compile Error:
hardware/libhardware/modules/camera/3_4/camera.cpp:502:9: error: non-constant-expression cannot be narrowed from type 'std::__1::vector<camera3_stream_buffer, std::__1::allocator<camera3_stream_buffer> >::size_type' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
request->output_buffers.size(),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Test: Add to device.mk
USE_CAMERA_V4L2_HAL := true
PRODUCT_PACKAGES += camera.v4l2
mma
Change-Id: Ia6bbd6bac06540214d2c6167a8826f3f4c946e57
Signed-off-by: Dmitry Shmidt <dimitrysh@google.com>
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| eadafff6aeee592ba373c1465f5d8feac3ef9d48 |
|
01-Aug-2017 |
Eric Jeong <ericjeong@google.com> |
Close acquire fence fd after camera capture
Camera capture should close acquire fence. If not, fd remains unused,
which consumes all available fd resources for a process (usually 1024).
Bug: 64214375
Test: Running camera preview of camera sample app for a long time
should not break preview image.
Exempt-From-Owner-Approval: This is a cherry-pick CL from oc-iot-dev.
Change-Id: I91d6d3a7b7a95ed5b33c7c73bc85d42f69f4c856
(cherry picked from commit da3c52413a7499a3cd91246b0634f839315ed7b7)
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| 5acb400d18d40220df829193355736a0df782ab7 |
|
30-Nov-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Fix camera close sequencing.
Flush the device before disconnecting from it.
Hasn't caused identifiable bugs yet, but seems
dangerous and easy to fix.
TEST: builds & runs sample
Change-Id: Icaf27d4de5628087278b84bff586aab8e1e62e28
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| ef52310613342dd51a928af92e3287f6783ae8c7 |
|
22-Nov-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Correctly process streams
The reference implementation stream validation/setting
was all out of whack, particularly the handling of "reuse"
streams. This CL does away with that, and plugs in the
static_properties/request_tracker validation/tracking of
configured streams.
Implementation specific features, such as gralloc flags,
are moved down into the V4L2Camera class out of the Camera class.
BUG: https://b/33057320, https://b/31044638
TEST: unit tests pass, some previously failing CTS tests are passing
(and no regressions), simple test camera preview app runs.
Change-Id: Ie8568239a1348dac45bf829ef928e500e01fdcda
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| e31e1f33b482b7459b63bf1f2198556020c95332 |
|
17-Nov-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Only provide templates for supported capabilities
Plugs in the StaticProperties class for ease of accessing the
static metadata.
Expands StaticProperties to handle checking template support.
Test: Unit tests pass, test app runs, fixes 2 failing CTS tests on rpi3
BUG: b/32951283
Change-Id: I3077a3507751c3072b88f7d91902bdaa5b53c30e
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| c5a485245169c1da02c4a5bfb80876cff68882eb |
|
16-Nov-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Implement flushing and improve request tracking.
BUG: https://b/29937783, https://b/32941326
TEST: unit tests pass, fixes 8 failing cts tests
Change-Id: Idc390bdc1e51ba2bdbda91d90acc459a09a5f174
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| ad6fe2b033997ab0401b0a519b18cea6e957dac0 |
|
16-Nov-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Remove spurious logging.
When logging was enabled, the log was a little *too*
verbose, making it unreadable. Removing some of the
more frequently hit log messages.
BUG: b/32942120
TEST: Can run camera samples
Change-Id: I136c20279699e4c87b3ef1c3042b88c20c301002
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| 0b2113c54f716e710aff60989cba5d5f0b080f0f |
|
03-Oct-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Track in-flight requests
This allows for verification of callbacks, and will also be helpful
when implementing flush.
BUG: 31653306
TEST: unit tests pass, test program runs
Change-Id: Id43d6cb3c2b9ca4adc96fc08282f88e0b7b904e1
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| fb161115c80816a90f252313d53bbb599b90dd6c |
|
29-Sep-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Send error notification when request fails.
Sends a generic request error when a request fails.
BUG: 31653322
TEST: Test program runs
Change-Id: Ib0694d655e584dcfeaeacc1ce55177191abe42e3
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| fbac174a46445f410b0cde31c35b19b6f9f34b30 |
|
19-Sep-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Use correct gralloc flags in V4L2 Camera HAL
Also checks gralloc return results, and cleans up style.
BUG: https://b/31595935, https://b/31589070
TEST: test streaming app works
Change-Id: I4d910524ae21a7b666a1f456e2b7122a8671560f
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| 2738a9c3b5f8f1dfc208841e72035c72d8a8ebb5 |
|
22-Sep-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Refactor capture processing to be async friendly
Set up a series of methods that can be producers/consumers/callbacks.
For now, they call each other synchronously.
TEST: manually tested with app
BUG: 29334616
Change-Id: Icb6cf9d9970521d5291c54f02dc5032f43b26616
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| abbf9cc0bd4160642c36f7bd47c0277a8bf17adf |
|
23-Aug-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Plug in metadata refactor.
Replaces metadata usage in Camera/V4L2Camera with the
new Metadata class.
Switches Camera from camera_metadata_t to android::CameraMetadata
where appropriate for ease of use/clarity of ownership.
Also cleaned up some "error" logs that were potentially expected,
leaving it to the caller to log if something goes wrong, since
they were numerous and cluttering the log feed.
BUG: https://b/30140438, https://b/29335262
TEST: unit tests pass, test picture program still works,
tested setting a V4L2 control to a non-default value.
Change-Id: I24e50c9b71736dfc576debf8d09dbe36b9bbf23a
/hardware/libhardware/modules/camera/3_4/camera.cpp
|
| 3841a7f4951fe1498bf5ba88466def3ea18f8867 |
|
20-Jul-2016 |
Ari Hausman-Cohen <arihc@google.com> |
Style fix: renaming and include guards.
Fixes file name style and include guard style, before
even more and more files get added.
BUG: 30224839
Change-Id: Ie5ebcf14672c7e9d3faae86b88d4f62b516ae00d
TEST: test program that takes a picture still works.
/hardware/libhardware/modules/camera/3_4/camera.cpp
|