| 9f471e2dd80b528a384813210ae64e3ea3527f35 |
|
07-Feb-2017 |
Weilun Du <wdu@google.com> |
Fix race condition in at_send_command_*
b/34883617
Change-Id: I946125e1c4db44e05afbc0e5d1fb22cc880f1d89
Signed-off-by: Weilun Du <wdu@google.com>
/hardware/ril/reference-ril/atchannel.c
|
| 40be36d427f641333832424ab7dc74907d5200c8 |
|
01-Jul-2016 |
Sanket Padawe <sanketpadawe@google.com> |
Merge commit 'f0c8ca7f09ed9a827e5c79e019526e8f2c77eeb4' into manual_merge_f0c8ca7
Change-Id: I670c9270d5d6fccd4b1a223de142d61e26541b7e
|
| f0c8ca7f09ed9a827e5c79e019526e8f2c77eeb4 |
|
01-Jul-2016 |
Sanket Padawe <sanketpadawe@google.com> |
Fix build warnings in hardware/ril.
Bug: 29401612
Change-Id: I8473294655ad24ec001cedb84856004ab0ba22a7
/hardware/ril/reference-ril/atchannel.c
|
| 78e2c9c17f922cd2c8b3116fa6b228ea990d8f4b |
|
16-May-2016 |
Robert Greenwalt <rgreenwalt@google.com> |
resolve merge conflicts of c9badf1 to nyc-dev-plus-aosp
Change-Id: I59d138a61554a2439577bcfdf400ea663c6bb91d
|
| 434554c687a6735dcac99fbcd78582c80577d70a |
|
12-May-2016 |
Chih-Hung Hsieh <chh@google.com> |
Fix misc-macro-parentheses warnings.
Bug: 28705665
Change-Id: Ib7520c64075a652eb0b15483f36383c4632624d1
/hardware/ril/reference-ril/atchannel.c
|
| f3769c17615bc9c227cff83cad0e55bb9f878197 |
|
31-Mar-2016 |
Yu Ning <yu.ning@intel.com> |
reference-ril: Stop using pthread_cond_timedwait_relative_np()
pthread_cond_timedwait_relative_np() is deprecated, and is only
available in the 32-bit ABI (see bionic/libc/include/pthread.h). It is
still used by the 32-bit version of reference-ril. Thanks to a recent
bugfix for 64-bit [1], it is now safe to replace the deprecated
function with the standard pthread_cond_timedwait(). Doing so also
simplifies the code, as there is now a unified logic for 32 and 64-bit
targets.
[1] https://android-review.googlesource.com/210301
Signed-off-by: Yu Ning <yu.ning@intel.com>
(cherry picked from commit 3480b1832d3581c708868117c0eb21ba291df165)
Change-Id: I1a15ee0fdfea38b6ee9c9fd49845d10d45f485b1
/hardware/ril/reference-ril/atchannel.c
|
| 99f6a4e8fa12a6d54df5420aaa3eda29d9ba22a6 |
|
24-Mar-2016 |
Jinhui Li <jinhui.li@intel.com> |
reference-ril/atchannel.c: Fix time conversion
setTimespecRelative() converts a relative time to an absolute time, by
adding the relative time to current system time. However, it fails to
handle the case where the nanosecond component (tv_nsec) of the
conversion result exceeds 10^9, which can cause a subsequent call to
pthread_cond_timedwait() to return EINVAL.
This bug is the root cause of the "no SIM card" error seen occasionally
on x86_64 Android emulator. In fact, all 64-bit targets use
setTimespecRelative() in conjunction with pthread_cond_timedwait()
during AT handshake, but an EINVAL return value from the latter will
lead to an infinite loop and hang the communication. With this fix,
x86_64 emulator can boot with functional 3G networking every time.
Signed-off-by: Jinhui Li <jinhui.li@intel.com>
[Revised code and commit message]
Signed-off-by: Yu Ning <yu.ning@intel.com>
(cherry picked from commit 11476211584f1a82c870b9486ace8f6f8bb9fc7c)
Change-Id: I5d7396ef7f0af5ef02ccab785046d635fb8f168c
/hardware/ril/reference-ril/atchannel.c
|
| 9cfa20c2f5c2c2bcde6a55eb9dbe4a80fbadcab8 |
|
01-Apr-2016 |
Yu Ning <yu.ning@intel.com> |
Merge "reference-ril: Stop using pthread_cond_timedwait_relative_np()" am: 2e481da
am: e3546c6
* commit 'e3546c6cb66f2d100de5d0a249f53a783d2d5222':
reference-ril: Stop using pthread_cond_timedwait_relative_np()
Change-Id: I27b6544423c1ee9fe98c18df452b035f37049b76
|
| 3480b1832d3581c708868117c0eb21ba291df165 |
|
31-Mar-2016 |
Yu Ning <yu.ning@intel.com> |
reference-ril: Stop using pthread_cond_timedwait_relative_np()
pthread_cond_timedwait_relative_np() is deprecated, and is only
available in the 32-bit ABI (see bionic/libc/include/pthread.h). It is
still used by the 32-bit version of reference-ril. Thanks to a recent
bugfix for 64-bit [1], it is now safe to replace the deprecated
function with the standard pthread_cond_timedwait(). Doing so also
simplifies the code, as there is now a unified logic for 32 and 64-bit
targets.
[1] https://android-review.googlesource.com/210301
Change-Id: I0895bbf65ddb71965018d6945dfb8baa786d5d89
Signed-off-by: Yu Ning <yu.ning@intel.com>
/hardware/ril/reference-ril/atchannel.c
|
| 0ae0fbbd5cc8fc56a2eb1fa273a73251b1735fd0 |
|
30-Mar-2016 |
Jinhui Li <jinhui.li@intel.com> |
Merge "reference-ril/atchannel.c: Fix time conversion" am: 0bbaed7
am: 230df4a
* commit '230df4ab9c69358026634079c1dece849b10d2f0':
reference-ril/atchannel.c: Fix time conversion
Change-Id: I02f358e240858166c4360b368b23c0dfdee67ff1
|
| 11476211584f1a82c870b9486ace8f6f8bb9fc7c |
|
24-Mar-2016 |
Jinhui Li <jinhui.li@intel.com> |
reference-ril/atchannel.c: Fix time conversion
setTimespecRelative() converts a relative time to an absolute time, by
adding the relative time to current system time. However, it fails to
handle the case where the nanosecond component (tv_nsec) of the
conversion result exceeds 10^9, which can cause a subsequent call to
pthread_cond_timedwait() to return EINVAL.
This bug is the root cause of the "no SIM card" error seen occasionally
on x86_64 Android emulator. In fact, all 64-bit targets use
setTimespecRelative() in conjunction with pthread_cond_timedwait()
during AT handshake, but an EINVAL return value from the latter will
lead to an infinite loop and hang the communication. With this fix,
x86_64 emulator can boot with functional 3G networking every time.
Signed-off-by: Jinhui Li <jinhui.li@intel.com>
[Revised code and commit message]
Signed-off-by: Yu Ning <yu.ning@intel.com>
Change-Id: If04ba560e350bc4e13b22c51f8d215a673230667
/hardware/ril/reference-ril/atchannel.c
|
| 1fbb38212cfd3b07be5532dd372432a3ec75d387 |
|
10-Mar-2016 |
Sanket Padawe <sanketpadawe@google.com> |
Fix memory leak in atchannel.c
Bug: 27134985
Change-Id: I0273a40f175212bed4aad42e46feb333d9df9a2b
/hardware/ril/reference-ril/atchannel.c
|
| 894fbbd4272a5075d99a6aa245ca3f6bc2b62989 |
|
25-Jan-2014 |
Colin Cross <ccross@android.com> |
Set USE_NP based on HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE
64 bit bionic does not define pthread_cond_timeout_np, use
HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE to determine whether or
not to use it.
Change-Id: Ia94dd76f7ea4b0268f07049c127342a8bd016ec0
/hardware/ril/reference-ril/atchannel.c
|
| 88d0e0e497af4da9bf571354197755dfe2496484 |
|
21-Nov-2013 |
Elliott Hughes <enh@google.com> |
Remove references to <linux/omap_csmi.h>.
This header no longer exists in modern kernels, and it looks like
this code was only meant to be enabled for 'sooner' anyway.
Change-Id: I6e7449a31942a54daa925c14e8843752a835bd42
/hardware/ril/reference-ril/atchannel.c
|
| 4dcab4f90d2d49e40100e4888b1411dfbd1c9783 |
|
20-Nov-2012 |
Wink Saville <wink@google.com> |
Add RLOGx
This will eventually allow us to remove the code in
logd_write.c#__android_log_write which uses the tag
to direct logs to the radio buffer.
Change-Id: I7a6a966bc12e59a3ec68a56a41dd681fb325dfd8
/hardware/ril/reference-ril/atchannel.c
|
| f423cde8f901a72fd0cb811583a2cdabe62c64bd |
|
08-Jan-2012 |
Steve Block <steveblock@google.com> |
Rename (IF_)LOGE(_IF) to (IF_)ALOGE(_IF) DO NOT MERGE
See https://android-git.corp.google.com/g/#/c/157220
Bug: 5449033
Change-Id: Id52de89149d4580873215fafc922ec4bd8d722ed
/hardware/ril/reference-ril/atchannel.c
|
| 6464068a31ff890d42d3da9cdf580d07c9c630d8 |
|
20-Dec-2011 |
Steve Block <steveblock@google.com> |
Rename (IF_)LOGD(_IF) to (IF_)ALOGD(_IF) DO NOT MERGE
See https://android-git.corp.google.com/g/156016
Bug: 5449033
Change-Id: Ib3eab0b780391f9a0ac9b53282616d66a0154ade
/hardware/ril/reference-ril/atchannel.c
|
| 00f06fc3fdb05d4276e76091cacb42b6f6862222 |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/hardware/ril/reference-ril/atchannel.c
|
| c2efc51d848d68147320a5983954f9c76428885c |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/hardware/ril/reference-ril/atchannel.c
|
| dbbb392e15b5ace6f19e76c49c80ea14292e8a4d |
|
21-Oct-2008 |
The Android Open Source Project <initial-contribution@android.com> |
Initial Contribution
/hardware/ril/reference-ril/atchannel.c
|