| 1088ed822e211d57ff674aa4941361cb0b0b0b1a |
|
21-Nov-2016 |
Przemyslaw Szczepaniak <pszczepaniak@google.com> |
Support clearing cookies by adding it with "max-age=0"
This change fixes regression in Android N. Android supports
clearing cookies by re-adding the cookie with max-age: 0.
Test: CtsLibcoreTestCases
Bug: 33034917
Change-Id: Iae0e5f928ae29103f6424f2ef077fab2f0d8e17b
|
| 7ee8e1d8d92555a9d12aa88ee00fdde386404e84 |
|
16-Nov-2016 |
Przemyslaw Szczepaniak <pszczepaniak@google.com> |
Make Cookes "expires" parsing more lenient
OpenJdk cookies implementation is more
strict about the "expires" field parsing and requires
the "GMT" prefix before timezone value. This is a
regression from Android M and earlier. We were more
lenient and accepted values without the GMT prefix.
This change switches "expires" parsing code to use
libcore.net.http.HttpDate code.
Bug: 31039416
Test: CtsLibcoreTestCases
Change-Id: I13359ed3451fa480ee6f949fd657bf639335ef37
|
| dfbb01e4bead8c81274884a65627252f1a22f536 |
|
08-Sep-2016 |
Yi Kong <yikong@google.com> |
Fix CookiesTest#testCookieStoreNullUris
The test is broken, NPE should not be thrown here.
Bug: 31359736
Test: CookiesTest#testCookieStoreNullUris
Change-Id: I75b1989a043bed11ed2b81c380f191831ae4aee1
|
| d4b7449574ca69c713a3f2230cb77c68ee642700 |
|
06-Sep-2016 |
Tobias Thierer <tobiast@google.com> |
Fix 58 libcore tests that caught "expected" Exceptions but didn't fail()
There were no changes to code under test.
4 tests were fixed to not tolerate an Exception:
- libcore.java.util.CollectionsTest#test_CheckedMap_computeIfAbsent
In the case where a Map key is present, computeIfAbsent() should
not invoke the Function, so there is no return value that could
be expected to undergo a type check. The test was changed to
verify that the Function is not invoked.
- libcore.java.util.concurrent.CopyOnWriteArrayListTest#test_sort and
libcore.java.util.concurrent.CopyOnWriteArrayListTest#test_subList_sort
were sorting an already-sorted non-null list that contains no null
values. That logic was redundant and wouldn't have thrown.
- org.apache.harmony.security.tests.java.security.KeyStoreSpiTest#test_engineEntryInstanceOf
(the KeyStoreSpi documentation does not mention whether NPE is thrown;
the implementation comes from upstream and does not throw it).
54 tests were fixed by adding the missing
fail();
No attempt was made to make this failure message specific to the
exception that was expected.
Tests that weren't changed:
- SSLEngineTest.test_wrap_ByteBuffer_ByteBuffer_04() requires
investigation to determine the correct resolution.
A comment was added to the test linking to the corresponding bug.
- ThreadTest#testParkUntilWithUnderflowValue() and
OldNodeChangeEventTest.waitForEvent() were not touched since
it was not clear whether that it was relevent to the test whether
or not the exception was thrown.
- two cases in Files2Test#test_setPosixFilePermissions_NPE() are
left to a future CL
Test:
(croot; make vogar core-tests) \
&& git diff aosp/master --name-only | xargs vogar `cparg core-tests`
Change-Id: I1cd3220a06e331ff049b146b393f78879f07211a
|
| 5ab3ae80ddc60b7f36bdb8f76be3b6b53335c580 |
|
11-Aug-2016 |
Yi Kong <yikong@google.com> |
Import upstream change: CookieHandler does not work with localhost
Upstream change:
7169142: CookieHandler does not work with localhost
Summary: Add .local to derived effective hostnames without dot
Reviewed-by: chegar
http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/42f9ad39bf42
This change depends on OpenJDK change 5c1f90dd0405 (libcore change
505d890c)
Bug: 29067535
Test: libcore.java.net.AbstractCookiesTest
Change-Id: Iaba4f6f4b666d55167748e4e35ed57cc97eb9ba4
|
| 22bfef3e51bb2b39c870465775a0d32b46d6ebe8 |
|
28-Jun-2016 |
Neil Fuller <nfuller@google.com> |
Tidy up MockWebServer usage
Make sure that MockWebServer instances are shut down
correctly after tests.
Test: Ran the tests under CTS
Bug: 29820565
Bug: 29365528
(cherry picked from commit 9cc268daf1a03b745f5c161173816a3340beffa0)
Change-Id: If9b5a0681cd1e0633accbb4cd84feb10d863c0d7
|
| 9cc268daf1a03b745f5c161173816a3340beffa0 |
|
28-Jun-2016 |
Neil Fuller <nfuller@google.com> |
Tidy up MockWebServer usage
Make sure that MockWebServer instances are shut down
correctly after tests.
Test: Ran the tests under CTS
Bug: 29820565
Change-Id: I5455de018e2e6e3dd57cfc572becc93e0f566a26
|
| 7363410d6ab95420d62cc5e2ee52801a693781eb |
|
27-Jan-2016 |
Narayan Kamath <narayan@google.com> |
Revert "Revert "Cookies: Add targetSdkVersion based compatibility for domain matching.""
This reverts commit 225d1301a97641464a1b437219eb60853260b28c.
bug: 26456024
Change-Id: I1bf63a71a3b950b37a0fa8eb6e04c14f67fd8737
|
| 225d1301a97641464a1b437219eb60853260b28c |
|
27-Jan-2016 |
Narayan Kamath <narayan@google.com> |
Revert "Cookies: Add targetSdkVersion based compatibility for domain matching."
This reverts commit 1e7abd80b139d532f53d6ca8a2a0b5671fa1fb43.
Change-Id: Iefc1342b628ee241bbb999b59ca0fa211bedf5b9
|
| 1e7abd80b139d532f53d6ca8a2a0b5671fa1fb43 |
|
27-Jan-2016 |
Narayan Kamath <narayan@google.com> |
Cookies: Add targetSdkVersion based compatibility for domain matching.
This change also consolidates our three CookieManager related tests
into a single test so that it can be easily extended to test both the
M compatibility mode and the current behaviour.
bug: 26456024
Change-Id: I153e69d471c83744c0420a07313e0fda70a80e6b
|