| f2cfb1223a3a2f682d657d97cdb0cd9108c5c30c |
|
13-Jul-2017 |
vichang <vichang@google.com> |
Remove File.deleteOnExit in ZipEntryTest
File.deleteOnExit will not ensure file deletion
Bug: 37696493
Test: cts-tradefed run cts -m CtsLibcoreTestCases -t \
libcore.java.util.zip.ZipEntryTest
Change-Id: Ia3d4c93c0436719e09ef08ac25afbfd05222bc95
|
| fac06a434f4498173f0d2ed675eae7285ec3ef18 |
|
06-Jul-2017 |
Victor Chang <vichang@google.com> |
Make ZipEntryTest time-insensitive
Fix ZipEntryTest to not depend on the current system time.
The ZIP format represents timestamps outside of DOS time
(before 1980) via an extra field.
ZipEntryTest.testCommentAndExtraInSameOrder() asserts that
the extra field can be read back unchanged, but since it
defaulted to the current system time, this check failed
when the system time was before 1980.
This CL fixes the test by explicitly setting a timestamp
in 2010 on the new entry. It also adds new tests for the
behavior difference before/after 1980.
Bug: 37696493
Test: cts-tradefed run cts -m CtsLibcoreTestCases -t \
libcore.java.util.zip.ZipEntryTest
Test: cts-tradefed run cts -m CtsLibcoreTestCases -t \
libcore.java.util.zip.ZipOutputStreamTest
Change-Id: I179c193e503ec1f2c5549327ab64a15a33e5866b
|
| 35efa1b58a958cf5ab80308e8cf3abefc6e00b22 |
|
12-Jul-2017 |
Nicolas Geoffray <ngeoffray@google.com> |
Revert "Make ZipEntryTest time-insensitive"
Test fails:
junit.framework.AssertionFailedError
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at libcore.java.util.zip.ZipOutputStreamTest.testPutNextEntryUsingCurrentTime(ZipOutputStreamTest.java:126)
at java.lang.reflect.Method.invoke(Native Method)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at libcore.junit.junit3.TestCaseWithRules.superRunBare(TestCaseWithRules.java:110)
at libcore.junit.junit3.TestCaseWithRules.-wrap0(Unknown Source:0)
at libcore.junit.junit3.TestCaseWithRules$1.evaluate(TestCaseWithRules.java:66)
at dalvik.system.CloseGuardSupport$FailTestWhenResourcesNotClosedRule$1.evaluate(CloseGuardSupport.java:111)
at libcore.junit.junit3.TestCaseWithRules.runBare(TestCaseWithRules.java:106)
libcore.java.util.zip.ZipOutputStreamTest#testPutNextEntryUsingCurrentTime FAIL (EXEC_FAILED)
Bug: 37696493
This reverts commit 27feef25778031d9c1fc330f0cca570ecb17c188.
Change-Id: I7b8d1b976e7f23465522e8b48f41183fcef49252
|
| feda69d88f642d9580050fc6d54d8e23aecf2279 |
|
12-Jul-2017 |
Nicolas Geoffray <ngeoffray@google.com> |
Revert "Remove File.deleteOnExit in ZipEntryTest"
Test fails
Bug: 37696493
This reverts commit 2674d25fff95d1fa1382bc601687dd3c13ffd45c.
Change-Id: I2a6ad981e98a062c70f1c02f1ab2ec2f115f1a17
|
| 2674d25fff95d1fa1382bc601687dd3c13ffd45c |
|
11-Jul-2017 |
Victor Chang <vichang@google.com> |
Remove File.deleteOnExit in ZipEntryTest
File.deleteOnExit will not ensure file deletion
Bug: 37696493
Test: cts-tradefed run cts -m CtsLibcoreTestCases -t \
libcore.java.util.zip.ZipEntryTest
Change-Id: If992fe571dc484dfc55c1d9c243b8b68b59155d6
|
| 27feef25778031d9c1fc330f0cca570ecb17c188 |
|
06-Jul-2017 |
Victor Chang <vichang@google.com> |
Make ZipEntryTest time-insensitive
Fix ZipEntryTest to not depend on the current system time.
The ZIP format represents timestamps outside of DOS time
(before 1980) via an extra field.
ZipEntryTest.testCommentAndExtraInSameOrder() asserts that
the extra field can be read back unchanged, but since it
defaulted to the current system time, this check failed
when the system time was before 1980.
This CL fixes the test by explicitly setting a timestamp
in 2010 on the new entry. It also adds new tests for the
behavior difference before/after 1980.
Bug: 37696493
Test: cts-tradefed run cts -m CtsLibcoreTestCases -t \
libcore.java.util.zip.ZipEntryTest
Test: cts-tradefed run cts -m CtsLibcoreTestCases -t \
libcore.java.util.zip.ZipOutputStreamTest
Change-Id: I8024c9dcb23179a69e1805e66c6b051f1a358800
|
| 8456b1f15317e7fd59267ab8cafe0a78f1d5b1a0 |
|
27-Jan-2016 |
Shubham Ajmera <shubhamajmera@google.com> |
Enable a few black listed tests
Removed UrlUtilsTest as the class has been removed.
commit ca31a11 fixes X509CertificateTest. ZipEntryTest has
been re-added with a few modifications.
Bug: 26352408
Bug: 26870388
Change-Id: I10b58ee2ded9f6ccccb7af5c3729eec465795650
|
| a812a87e69850d1492c45bd88d7ff3dbf21d5075 |
|
24-Mar-2015 |
Narayan Kamath <narayan@google.com> |
Don't use zip64 by default.
This change was breaking tools like dexmaker that would write
zipfiles to disk so that the runtime could read them.
We don't want to go back and amend the local file header, so
we just throw an IOException if somebody writes more than 4GB
of data to an entry that doesn't have a declared size. If the
entry has a declared size > 4GB, we can write the zip64 header
in advance.
bug: 19574093
Change-Id: I771e821996efd3ef4c3de5e02f5a0062e62f9244
|
| 12f5c69e074d6ef012706068416f0a61b70b4e52 |
|
27-Jan-2015 |
Narayan Kamath <narayan@google.com> |
Implement zip64 support for ZipFile/ZipInputStream/ZipOutputStream.
There are several open questions that I hope to resolve in future
changes :
- Our heuristics for detecting whether a zip outputstream should
switch over to zip64 or not are imprecise.
- Also, given that we now officially support zip64, we have to assume
new entries whose size is unknown need the zip64 header / footer.
This will make output files slightly larger and less compatible with
older tools. If we don't do this, we'll have to go back and rewrite &
compact parts of the stream we'd already flushed, which isn't always
possible. The other option is to assume zip32 for streams of unknown
length and throw if more than 4G of data is written to them.
Change-Id: Ibb4a97b5f83fd3ab850d7c407ecfda663968a6b9
|
| 613ebea3da2d973bbe6496d6e57eb4c8d75b148e |
|
21-Aug-2013 |
Kenny Root <kroot@google.com> |
Fix extra and comment ordering in ZipEntry reading
(cherry picked from commit c242577b1569f97f806ef176e4549141df147b78)
Bug: 10424836
Change-Id: I99e6722ef898baa7f9a2d56e84e88aae5a6c9f4a
|
| c242577b1569f97f806ef176e4549141df147b78 |
|
21-Aug-2013 |
Kenny Root <kroot@google.com> |
Fix extra and comment ordering in ZipEntry reading
Change-Id: I99e6722ef898baa7f9a2d56e84e88aae5a6c9f4a
|
| 15a93894f19b27f3d85b8e3c3de8cff8a33964d3 |
|
09-Jul-2013 |
Elliott Hughes <enh@google.com> |
Tests for ZIP sign extension bugs.
Bug: 9695860
(cherry picked from commit 406b85296a7ba29d2f480280d2f2a96133f940ec)
Change-Id: If9740163a67c2bccebd46552fbba0518087232ba
|
| 406b85296a7ba29d2f480280d2f2a96133f940ec |
|
09-Jul-2013 |
Elliott Hughes <enh@google.com> |
Tests for ZIP sign extension bugs.
Bug: 9695860
Change-Id: I61e5a932d73c14b964c44e753c7317b532b51b6d
|
| 355a98498e4bc434dde8809eacf6e150f9b25f89 |
|
02-Sep-2010 |
Jesse Wilson <jessewilson@google.com> |
Fix a findbugs bug where ZipEntry.clone() didn't call super.clone().
See http://b/2099615
Change-Id: Ib1347aa5e35c62501d9d59eccfdfed098559d552
|
| 4557728efb66c455a52b7669a8eefef7a9e54854 |
|
11-Aug-2010 |
Jesse Wilson <jessewilson@google.com> |
Moving tests to be under the libcore.* package.
This is indended to make it easier to run on VMs that restrict the packages
from which application classes can be loaded. For example, on the RI you need
to use the bootclasspath to load these tests.
Change-Id: I52193f35c5fcca18b5a3e1d280505b1e29b388af
|